refactor: Avoid -W*-whitespace in git archive
What the developer wrote
Authored by MarcoFalke
refactor: Avoid -W*-whitespace in git archive
What changed, and why it matters
This is a minor code cleanup in Bitcoin Core. It changes a copyright year range to 'present', adds a blank line between include statements, and reformats a comment about how git fills in commit IDs in archived source code. There is no security-relevant change.
No security action needed. Treat as ordinary refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies src/clientversion.cpp only. It updates the copyright header from ‘2012-2022’ to ‘2012-present’, inserts a blank line between #include
Changed components
src/clientversion.cppInspect captured patch +4 / −2
diff --git a/src/clientversion.cpp b/src/clientversion.cpp
index d9e65037..86610112 100644
--- a/src/clientversion.cpp
+++ b/src/clientversion.cpp
@@ -1,10 +1,11 @@
-// Copyright (c) 2012-2022 The Bitcoin Core developers
+// Copyright (c) 2012-present The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <bitcoin-build-config.h> // IWYU pragma: keep
#include <clientversion.h>
+
#include <util/string.h>
#include <util/translation.h>
@@ -30,7 +31,8 @@ const std::string UA_NAME("Satoshi");
// - "#define BUILD_GIT_COMMIT ...", if the top commit is not tagged
// - "// No build information available", if proper git information is not available
-//! git will put "#define GIT_COMMIT_ID ..." on the next line inside archives. $Format:%n#define GIT_COMMIT_ID "%H"$
+// git will expand the next line to "#define GIT_COMMIT_ID ..." inside archives:
+//$Format:%n#define GIT_COMMIT_ID "%H"$
#ifdef BUILD_GIT_TAG
#define BUILD_DESC BUILD_GIT_TAG
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.