Bitcoin Core

This commit only cleans up a single test file. It fixes how the test checks return values from internal Bitcoin IPC calls and renames some variables for clarity. It does not change any production code that handles real Bitcoin transactions, blocks, or network messages, so it has no direct security impact on running Bitcoin nodes.

This commit is a small performance and consistency cleanup in Bitcoin Core's network code. It changes the inactivity timeout checks so that the current time is fetched once per loop and passed into helper functions, rather than each helper fetching its own slightly different timestamp. There is no security-relevant change here.

This is a code cleanup change that turns on a static-analysis check (clang-tidy 'bugprone-unused-return-value') and makes small, behavior-preserving edits so the codebase passes the new check. It does not fix a security bug or change how the software behaves at runtime.

This commit introduces a new internal helper class, util::Expected, that gives Bitcoin Core a cleaner way to return either a successful result or an error message from a function. It is a pure code-quality/refactoring change: it replaces the existing std::optional<std::string> pattern used by FetchBlock with the new Expected<void, std::string> type. There is no change to network behavior, RPC behavior, or consensus rules, and no security bug is fixed or introduced.

This commit only adds a new fuzz test for an existing string-parsing helper called ParseByteUnits(). It does not change any production code, fix a bug, or alter behavior. Fuzz tests feed random inputs to functions to help find crashes or bugs during automated testing, but the function itself is unchanged.

This commit is a routine code cleanup. It removes the old `LogPrintf` logging macro, which was already marked as deprecated and was simply an alias for the newer `LogInfo`. The change updates documentation and a test case to match. There is no security issue here.

This commit is a simple automated rename that changes every use of the logging macro LogPrintf to LogInfo across 15 source files. The commit message and the included verification script confirm it is a pure refactor with no intended behavior change. There is no security issue here.

This change is a simple code cleanup: it wraps some shared helper functions and constants in a namespace called index_util and updates the two files that use them to reference the new namespace. There is no change to what the code does, only to how it is organized. It does not fix a security bug or introduce a vulnerability.

This commit is a simple code cleanup: it removes two nearly identical helper functions from two separate files and puts one shared copy in a common header. The behavior of the function is unchanged; only its location and the way callers pass block information to it are adjusted. There is no security fix here.

This commit is a routine code cleanup: it moves duplicated database-key handling code shared by two Bitcoin Core indexes into one shared header file. The actual behavior is essentially unchanged, except that a couple of error messages now say 'index' generically instead of naming the specific index. There is no security fix or vulnerability here.

This commit only changes the help text for a debug/test command-line option called -stopatheight. It adds a note warning users that the node might process a few blocks past the target height while shutting down. There is no code behavior change, no bug fix, and no security issue.

This is a test-only cleanup in Bitcoin Core's functional test suite. It fixes how temporary 'block template' objects are cleaned up during an automated test by using Python context managers. The old code called destroy routines but forgot to 'await' them, so cleanup happened later by garbage collection instead of immediately. There is no change to the actual Bitcoin node software, no security vulnerability in production code, and no attacker-accessible behavior changed.

This commit fixes a bug in a Bitcoin Core functional test, not in the actual Bitcoin network code. The test was accidentally creating the same transaction twice and putting fees on the wrong transaction, so it wasn't really testing what it was supposed to test. The fix makes the test exercise the intended cluster-size-limit enforcement behavior correctly. There is no security issue in production software here.

This commit is a code cleanup that replaces old-style 'count the number of matching entries' checks with newer, clearer 'does this container contain the key' checks. It does not change program behavior, fix a bug, or address a security issue. It is purely a readability and maintainability improvement.

This commit is a pure code cleanup: it replaces older-style container lookups like `m.count(k)` with the newer, clearer `m.contains(k)` across many files. The behavior is identical, so there is no security impact.

This commit is a pure code cleanup: it replaces verbose 'find ... == end()' checks with the simpler 'contains()' method on C++ containers. There is no change in behavior, no bug fix, and no security impact.

This is a small fix to a developer helper script that generates manual pages for Bitcoin Core command-line programs. A previous change caused the script to grab the wrong word from the program's version output, so it could not build the man pages. The patch uses a regular expression to reliably find the version string. It does not change any network, wallet, or consensus code and has no security relevance.

This Bitcoin Core commit changes when and how the node warns users about a potentially serious problem: an invalid blockchain that has more work than the node's own best chain. Previously, the warning was skipped while the node was still downloading the blockchain for the first time (Initial Block Download, or IBD). Now it also runs at startup and during IBD. The wording is also made more neutral, mentioning both database corruption and consensus incompatibility as possible causes, instead of assuming corruption. This is a diagnostic/logging improvement, not a fix for an exploitable vulnerability.

This commit only adds a clearer warning message in the log when Bitcoin Core receives block headers for blocks it has already marked as invalid. It does not change how blocks are validated, accepted, or rejected. The goal is to help users diagnose database corruption or consensus incompatibility that can cause an endless 'headers sync' loop, not to fix a security vulnerability.

This commit simply removes an unused dependency import. A previous change added the Tcl programming language package to the Guix build manifest, but it turned out SQLite did not actually need it. This revert cleans up the build configuration with no effect on Bitcoin Core's runtime security.

This commit fixes a build-system issue in Bitcoin Core's dependency packaging for SQLite. It ensures the correct native C compiler is passed through when SQLite's build tool (autosetup) needs to compile a small local helper program called jimsh0. It also quotes that compiler variable so paths with spaces or multiple flags don't get split incorrectly. This is a build reliability fix, not a vulnerability in Bitcoin's network code or wallet cryptography.

This commit only updates documentation. It adds a warning to Bitcoin Core's JSON-RPC guide explaining that anyone with valid RPC credentials effectively has significant control over the node and the underlying machine, and that RPC whitelists should not be treated as a strong security boundary. No code behavior was changed.

This commit only adds a new automated test to Bitcoin Core. It checks that wallet backups can (or cannot) be loaded on pruned nodes that are using the assumeutxo snapshot feature. There is no change to production wallet, consensus, or networking code, so it does not introduce or fix a live security issue on its own.

This commit is a minor cleanup of a Bitcoin Core test file. It moves existing snapshot-import and background-validation checks into new helper functions without changing what the test actually verifies. There is no change to production code, no security fix, and no vulnerability.

This change adds a warning when users import a Bitcoin wallet descriptor containing an 'older()' time or block lock that looks safe but actually has no consensus effect. Because of how Bitcoin encodes relative locktimes, values above 65535 silently wrap around: older(65536) behaves like older(1). Someone could accidentally create a wallet that unlocks far sooner than they think. The patch does not block the import; it only warns.