init: point out -stopatheight may be imprecise
What the developer wrote
Authored by brunoerg
init: point out -stopatheight may be imprecise
What changed, and why it matters
This commit only changes the help text for a debug/test command-line option called -stopatheight. It adds a note warning users that the node might process a few blocks past the target height while shutting down. There is no code behavior change, no bug fix, and no security issue.
No action needed. This is a documentation-only clarification for a debug option.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a one-line string change in src/init.cpp that updates the description of the -stopatheight argument. The option remains DEBUG_ONLY and ALLOW_ANY. No logic, validation, shutdown sequence, or consensus code is modified.
Changed components
src/init.cpp command-line help text for -stopatheightInspect captured patch +1 / −1
diff --git a/src/init.cpp b/src/init.cpp
index bfb9483a..b35c6b72 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -632,7 +632,7 @@ void SetupServerArgs(ArgsManager& argsman, bool can_listen_ipc)
argsman.AddArg("-checkpoints", "", ArgsManager::ALLOW_ANY, OptionsCategory::HIDDEN);
argsman.AddArg("-deprecatedrpc=<method>", "Allows deprecated RPC method(s) to be used", ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
argsman.AddArg("-stopafterblockimport", strprintf("Stop running after importing blocks from disk (default: %u)", DEFAULT_STOPAFTERBLOCKIMPORT), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
- argsman.AddArg("-stopatheight", strprintf("Stop running after reaching the given height in the main chain (default: %u)", DEFAULT_STOPATHEIGHT), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
+ argsman.AddArg("-stopatheight", strprintf("Stop running after reaching the given height in the main chain (default: %u). Blocks after target height may be processed during shutdown.", DEFAULT_STOPATHEIGHT), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
argsman.AddArg("-limitancestorcount=<n>", strprintf("Deprecated setting to not accept transactions if number of in-mempool ancestors is <n> or more (default: %u); replaced by cluster limits (see -limitclustercount) and only used by wallet for coin selection", DEFAULT_ANCESTOR_LIMIT), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
// Ancestor and descendant size limits were removed. We keep
// -limitancestorsize/-limitdescendantsize as hidden args to display a more
Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.