Bitcoin Core

This is a small code cleanup that replaces hand-written time-unit conversions with safer, purpose-built helper functions. It does not change program behavior or fix any security issue.

This commit is a minor code cleanup with no security relevance. It adds a named alias 'NodeClock::epoch' for the zero time point and a compile-time check that it equals zero. No behavior changes, no bug fixes, and no security impact.

This is a one-line code cleanup in Bitcoin Core. It replaces an older way of getting the current time with a newer, type-correct equivalent. The commit message explicitly says it does not change behavior, and the diff shows only that single replacement with no logic changes.

This commit is a test-only cleanup. It removes a custom test logging hook called DEBUG_LOG_OUT and replaces it with Bitcoin Core's existing -printtoconsole=1 command-line option. There is no change to the production wallet, networking, consensus, or node code that ordinary users run.

This commit only adds a new test case to Bitcoin Core's functional test suite. It checks that when a user starts the software with an unusually high fallback transaction fee, the software still works but prints a warning message. There is no code change to the actual Bitcoin Core wallet or fee logic—only a test that verifies existing behavior.

This commit only changes a test file. It improves an existing functional test to verify that Bitcoin Core's wallet correctly fails to send transactions when the fallback fee is unset or set to zero, and succeeds when a fallback fee is configured. There is no change to production code, no security fix, and no vulnerability being patched.

This is a minor test-code cleanup. It renames a test class to match the actual topic (fallback fee), shortens a comment, and pulls three repeated 'sending must fail' checks into a helper function. No production code or security behavior is changed.

This commit only changes Bitcoin Core's internal fuzz testing code, which is used to automatically generate random inputs to find bugs during development. It does not change any production networking, consensus, or wallet code that runs on real Bitcoin nodes. There is no security issue here for end users.

This Bitcoin Core commit tweaks how the node decides whether a privately broadcast transaction is 'stale' and should be re-broadcast. Previously, a transaction could be marked stale just one minute after it was added, even if it had never actually been sent to any peer. Now, transactions that have not yet been picked for sending use a longer five-minute window, while already-sent transactions keep the one-minute window. The commit also exposes the 'time_added' field in an RPC diagnostic so users can see when each transaction entered the private-broadcast queue. There is no claim in the commit that this fixes a security vulnerability; it reads as a robustness/usability improvement.

This commit simply removes two outdated code comments (TODOs) from a Bitcoin Core wallet file related to external signers. No actual code behavior was changed, so it does not fix or introduce any security issue on its own.

This commit removes unused global pointer variables in three test-only fuzzing files. It is a code cleanup change to silence compiler warnings and has no effect on the live Bitcoin Core software that users run.

This commit only adds a new test case to Bitcoin Core's test suite. It verifies that a 65535-byte data push in Bitcoin scripts is considered 'minimal' only when encoded with OP_PUSHDATA2, not OP_PUSHDATA4. The commit does not change any production code, so it cannot directly introduce or fix a live vulnerability. It is a regression test that documents an existing consensus rule boundary.

This is a developer tooling fix for a Python script that generates manual pages for Bitcoin Core. The script was failing on non-English systems because bitcoin-qt's version and help output was translated, causing an assertion to fail. The fix forces English output by adding --lang=en. It does not change any user-facing code, network behavior, or wallet handling.

This is a large but purely cosmetic cleanup commit. It removes unnecessary '&' captures from C++ lambda functions used to define Bitcoin RPC commands. The code behavior is unchanged; the change only makes the source code slightly cleaner and avoids compiler warnings about unused captures.

This commit is a purely cosmetic rename of a C++ class used to define Bitcoin RPC commands. Every occurrence of 'RPCHelpMan' is replaced with 'RPCMethod' across 27 source files using an automated script. No behavior, logic, or security properties of the software change.

This commit simply archives the release notes for Bitcoin Core version 28.4. It is a documentation-only change that adds a markdown file summarizing what went into the release. There is no code change and no security issue introduced or fixed by this commit itself.

This commit is a hardening change for Bitcoin Core's test code. It removes most uses of shutil.rmtree, a Python function that recursively deletes directories, because it could accidentally wipe out the wrong folder if a test variable ever pointed somewhere unexpected. The patch replaces those calls with safer alternatives: a new cleanup_folder helper that refuses to delete anything outside the test's temporary directory, tempfile.TemporaryDirectory which cleans itself up, or explicit removal of known files. It also adds a lint rule to prevent new rmtree uses in test code. This is a defensive, preventive fix in the test suite, not a fix for an active security bug in the running Bitcoin node software.

This commit removes an unused command-line option called --keepcache from Bitcoin Core's functional test runner. It is a cleanup change that switches test cache handling to an automatic temporary directory. There is no security relevance.

This commit is a defensive cleanup: it removes almost all uses of a filesystem function called remove_all() that can wipe out entire directory trees, and adds an automated lint check to prevent it from being reintroduced. The changes only affect benchmark and test code, not the live Bitcoin wallet or node software that ordinary users run. It reduces the risk of accidental data loss during testing, but does not fix an active security bug.

This commit only updates a documentation file (doc/cjdns.md) describing how to use Bitcoin Core with the CJDNS network. It removes outdated manual peering instructions and replaces them with current upstream CJDNS v22 guidance about automatic peer discovery via DNS seeding. No code, configuration defaults, or security behavior of Bitcoin Core is changed.

This commit adds a new public API to Bitcoin Core's kernel library that lets outside callers run basic sanity checks on a raw Bitcoin block (for example, checking size limits, coinbase structure, and optionally proof-of-work and the merkle root). It is purely an addition of a new validation entry point and its tests. There is no bug fix, no change to existing consensus logic, and no indication of a security issue.

This commit is a simple variable rename inside Bitcoin Core's continuous integration (CI) scripts. It changes the name `TIDY_LLVM_V` to `IWYU_LLVM_V` in scripts that run the 'Include What You Use' (IWYU) code-analysis tool. There is no change to the Bitcoin software that users run, no change to security logic, and no fix for a vulnerability.

This commit adds a new public API to the Bitcoin Core library that lets outside programs read the network's consensus parameters (like block timing rules) from the existing chain parameters object. It does not change any validation logic or security behavior; it only exposes data that was already available internally in a more convenient way for library users.

This commit is a small internal code cleanup in Bitcoin Core's private transaction-broadcast feature. It wraps an existing list of per-peer send records inside a new 'TxSendStatus' container and adds a timestamp for when each transaction was first added. There is no change to network behavior, no bug fix, and no security-relevant change visible in the diff.