Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This change makes three Bitcoin command-line tools (bitcoin-tx, bitcoin-util, and bitcoin-wallet) automatically pick the fastest SHA-256 hashing implementation available on the computer, such as hardware-accelerated versions on modern CPUs…
This is a one-line fix in Bitcoin Core's network code. It changes how the size of a list of block headers is converted to a signed integer inside a loop. Previously, if the list was empty, the conversion could trigger undefined-behavior wa…
UndefinedBehaviorSanitizer integer sanitizer warning addressedImplicit signed/unsigned conversion in loop counterUnsigned integer wraparound on empty vector size
This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…
Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…
New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …
Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…
Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…
This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …
Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…
No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…
Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …
New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…
Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…
No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …
Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …
This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…
This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…
No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…
OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…
No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…
Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidateImplement PSBTv2 in decodepsbtby Ava Chow · dcc9a3c8 · Apr 29, 2026 · 1 fileMessage 35 · OpaqueInformational 18Details
Commit message · Ava Chow
Implement PSBTv2 in decodepsbt
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100
This commit updates the Bitcoin Core 'decodepsbt' RPC command so it can display the newer PSBT version 2 format. It only changes what information is shown to the user; it does not change how transactions are validated, signed, or broadcast. There is no indication this is a security fix.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 20/100
This commit finishes implementing the 'AddInput' and 'AddOutput' methods for PSBT version 2 in Bitcoin Core. PSBTs are files used to collaboratively build or sign Bitcoin transactions offline. Previously, adding inputs/outputs to a PSBTv2 would silently fail (return false). The change now properly checks version compatibility, respects the 'modifiable' flags that say whether inputs/outputs may be added, and handles time-lock consistency when new inputs are appended. It is a feature-completion patch with defensive checks, not a fix for an active vulnerability.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 28/100
This commit adds support for a new version of Partially Signed Bitcoin Transactions (PSBTv2) in Bitcoin Core. It introduces serialization and deserialization code for new PSBTv2 fields, including transaction version, input/output counts, modifiable flags, per-input previous outpoints and locktimes, and per-output amounts and scripts. The commit also adds validation rules to reject malformed or version-inconsistent PSBT data. There is no indication in the commit message or diff that this is a security fix; it appears to be a feature implementation.
Security candidateImplement PSBTv2 field mergingby Ava Chow · ab38c301 · Apr 29, 2026 · 2 filesMessage 35 · OpaqueLow 28Details
Commit message · Ava Chow
Implement PSBTv2 field merging
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 28/100
This commit updates how Bitcoin Core combines two Partially Signed Bitcoin Transactions (PSBTs). It adds checks to prevent merging PSBTs of different versions, propagates failure if any input or output cannot be merged, and copies new PSBTv2-only fields such as sequence numbers, locktimes, and modifiable flags. The change is a correctness and robustness improvement rather than a clear security fix.
Security candidateAdd psbt_version to PSBT RPCs and default to v2by Ava Chow · bcc1dca7 · Apr 29, 2026 · 12 filesMessage 68 · AdequateInformational 24Details
Commit message · Ava Chow
Add psbt_version to PSBT RPCs and default to v2
walletcreatefundedpsbt, createpsbt, converttopsbt, and psbtbumpfee take a psbt_version argument to set the version of the PSBT that they produce. The default psbt_version is 2.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 24/100
This commit updates Bitcoin Core's Partially Signed Bitcoin Transaction (PSBT) RPC commands so they can produce the newer PSBT version 2 format, and makes version 2 the default. It is a feature and compatibility change, not a fix for an active security vulnerability. The code validates that only versions 0 or 2 can be requested, and updates tests to match the new output structure. There is no indication in the commit that this resolves a disclosed security issue.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100
This commit only adds release notes documentation. It describes a planned change where several Bitcoin RPC commands will default to creating a newer PSBT format (version 2) and gain an optional version argument. There is no code change, no bug fix, and no security issue in this commit itself.
Security candidatetest: Tests for PSBT AddInput and AddOutputby Ava Chow · 5bd0579c · Apr 29, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · Ava Chow
test: Tests for PSBT AddInput and AddOutput
67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only adds new automated tests for existing PSBT (Partially Signed Bitcoin Transaction) helper functions called AddInput and AddOutput. It does not change any production wallet, consensus, or networking code. The tests verify that the functions correctly reject mismatched PSBT versions, duplicate inputs, inputs that violate timelock rules, and additions when the transaction is marked as non-modifiable. There is no indication this commit fixes a security bug or introduces a vulnerability.
AI review queuedtests: Add test vectors from BIP 370by Ava Chow · 0bc1c2e5 · Apr 29, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Ava Chow
tests: Add test vectors from BIP 370
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds new test data (sample PSBT strings) to a JSON file used by Bitcoin Core's automated tests. It does not change any production code, wallet logic, or network behavior. There is no security issue here.
Security candidatefuzz: Enforce additional version invariants in PSBT fuzzerby Antoine Poinsot · 470e52a5 · Apr 29, 2026 · 3 filesMessage 60 · AdequateInformational 17Details
Commit message · Antoine Poinsot
fuzz: Enforce additional version invariants in PSBT fuzzer
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundaryfuzzing or regression evidencesigning or wallet path
AI analysis · Informational 17/100
This commit only changes test/fuzzing code and adds equality operators to internal data structures so the fuzzer can check round-trip behavior of PSBT (Partially Signed Bitcoin Transaction) data. It does not change production transaction handling, consensus rules, or network code. There is no indication it fixes an exploitable vulnerability.
Security candidateUpdate test_framework/psbt.py for PSBTv2by Ava Chow · 863cf47b · Apr 29, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Ava Chow
Update test_framework/psbt.py for PSBTv2
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit updates Bitcoin Core's internal test-framework Python helper for Partially Signed Bitcoin Transactions (PSBT) to support the newer PSBT version 2 format. It is a test/development tooling change, not a change to the live Bitcoin network code that validates transactions or consensus rules. There is no indication this fixes a security bug or introduces a vulnerability.
Security candidatetests: Add PSBT unit test for ComputeTimeLockby Ava Chow · b8b6e7f0 · Apr 29, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Ava Chow
tests: Add PSBT unit test for ComputeTimeLock
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only adds a new unit test file for an existing PSBT (Partially Signed Bitcoin Transaction) function called ComputeTimeLock. It does not change any production code, wallet logic, or network behavior. There is no security fix or vulnerability being patched here.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 32/100
This change updates the Bitcoin Core 'joinpsbts' RPC command so it only accepts PSBT version 0 files. Previously, it could accept newer PSBT versions, which might have led to incorrect or unexpected behavior when combining partially signed transactions. The change adds an explicit version check and rejects non-v0 PSBTs with a clear error message.
Function to compute the lock time for the transaction
50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 27/100
This commit adds a helper function that calculates when a Bitcoin transaction becomes valid based on time or block height locks inside a Partially Signed Bitcoin Transaction (PSBT). It also makes the existing unsigned-transaction builder use this new calculation instead of always using a simple fallback value. The change appears to be a correctness improvement for PSBT version 2 locktime handling, not an obvious security fix, but it prevents a PSBT from being turned into a transaction when its inputs disagree about whether the lock is based on time or block height.
Security candidateReplace PSBT.tx with PSBT::GetUnsignedTx and PSBT::GetUniqueIDby Ava Chow · 3da0e160 · Apr 29, 2026 · 6 filesMessage 85 · StrongLow 33Details
Commit message · Ava Chow
Replace PSBT.tx with PSBT::GetUnsignedTx and PSBT::GetUniqueID
The global unsigned tx is decomposed into separate fields inside of PSBT, which mirrors what PSBTv2 will do. However, we still need to get the global unsigned tx so PSBT::GetUnsignedTx is introduced to do that. In order to also have a stable unique ID, we also introduce PSBT::GetUniqueID to replace uses of PSBT.tx.GetHash().
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 33/100
This commit refactors how Bitcoin Core handles Partially Signed Bitcoin Transactions (PSBTs). Previously, a PSBT stored a complete copy of the unsigned transaction. Now, the transaction is broken into separate fields and reconstructed on demand. The change also introduces a stable unique ID for each PSBT. This is primarily a code-cleanup and preparation step for a future PSBT version 2, not a direct fix for an active security bug.
Security candidateAllow specifying PSBT version in constructorby Ava Chow · b39c86ae · Apr 29, 2026 · 3 filesMessage 60 · AdequateInformational 19Details
Commit message · Ava Chow
Allow specifying PSBT version in constructor
The constructor will create the PSBT of the specified version, as long as it is 0 or 2.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100
This change lets the PSBT constructor choose between version 0 or version 2 when creating a new Partially Signed Bitcoin Transaction. It also fixes a small consistency bug in the joinpsbts RPC where newly created PSBTs during joining/shuffling were always version 0, even when the inputs being joined were version 2. There is no direct evidence this is a security fix, and the new version parameter is guarded by an assertion that only allows 0 or 2.
Security candidatepsbt: Change default psbt version to 2by Ava Chow · e0e4dbde · Apr 29, 2026 · 2 filesMessage 45 · ThinInformational 21Details
Commit message · Ava Chow
psbt: Change default psbt version to 2
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 21/100
This commit changes the default version number used when Bitcoin Core creates new Partially Signed Bitcoin Transactions (PSBTs) from version 0 to version 2. PSBT is a standard format for passing around unsigned or partially signed transactions between wallets and signers. The change itself is a one-line default-value update plus a test that confirms new PSBTs are created as version 2. It does not fix a memory corruption bug, crash, or remote-code-execution flaw, and there is no evidence in the commit or supplied references that it addresses a known security incident.
test: Test merging implicit PSBTv0 with explicit PSBTv0
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit adds a new test case to Bitcoin Core's functional test suite. It verifies that two PSBT (Partially Signed Bitcoin Transaction) version 0 encodings—one with the version field explicitly set to 0 and one with it omitted—can be merged together correctly. There is no code change to the actual Bitcoin Core node software, only a new regression test.
DuplicateMockDatabase is no longer used. Furthermore, as SQLite gets used more as a database and less as a key value store, this function gets more complicated and more bug prone. As the benchmarks now run equivalently quickly with a real database, retaining this duplication function is no longer necessary.
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply removes an unused test helper function called DuplicateMockDatabase and its declaration. It is a code cleanup change with no effect on the live Bitcoin wallet software users run.
unused() descriptors do not have scriptPubKeys. Instead, the wallet uses them to store keys without having any scripts to watch for.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit adds a new wallet descriptor type called unused(KEY). It lets Bitcoin Core wallets store a key without watching any blockchain addresses for it. The change is a feature addition, not a fix for an active security bug. It includes parsing rules, tests, and a small wallet tweak to skip address labeling for descriptors that do not produce output scripts. There is no evidence in the commit or supplied references of a disclosed vulnerability or exploit.
AI review queuedtest: Simple test for importing unused(KEY)by Ava Chow · 82bc280d · Apr 29, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · Ava Chow
test: Simple test for importing unused(KEY)
67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds a new automated test to Bitcoin Core that checks the behavior of importing a special 'unused(KEY)' wallet descriptor. It verifies that importing a public-only version is rejected for wallets that have private keys enabled, while importing a private-key version succeeds and registers the expected extended public key. There is no change to production wallet code, no bug fix, and no security-relevant behavior beyond normal test coverage.
Security candidateHave PSBTInput and PSBTOutput know the PSBT's versionby Ava Chow · 990b084f · Apr 29, 2026 · 4 filesMessage 50 · ThinInformational 18Details
Commit message · Ava Chow
Have PSBTInput and PSBTOutput know the PSBT's version
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100
This commit is a small internal refactor in Bitcoin Core's Partially Signed Bitcoin Transaction (PSBT) handling. It makes each PSBT input and output aware of which PSBT version it belongs to, currently hard-coded to version 0. The change does not fix a known bug or vulnerability by itself; it appears to lay groundwork for future PSBT version support. There is no evidence in the commit or supplied references that this is a security patch.
Security candidatepsbt: Use PSBTInput and PSBTOutput fields instead of accessing global txby Ava Chow · 82c9fe31 · Apr 29, 2026 · 8 filesMessage 73 · AdequateInformational 19Details
Commit message · Ava Chow
psbt: Use PSBTInput and PSBTOutput fields instead of accessing global tx
PSBTInput now has the previous txid and output index, and PSBTOutput has the amount and script. We no longer need to access the global unsigned tx for these fields.
Additionally, we can change iterating tx.vin and tx.vout to psbtx.inputs and psbtx.outputs.
This is in prepration for use with PSBTv2 where the global unsigned tx will not exist.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100
This commit is a code cleanup in Bitcoin Core's Partially Signed Bitcoin Transaction (PSBT) handling. It changes internal code to read input and output details from the PSBT data structures themselves rather than from the global unsigned transaction. The stated goal is to prepare for a future PSBT version (PSBTv2) where the global unsigned transaction may not exist. There is no direct security fix here, but any inconsistency between the PSBT fields and the global transaction could, in principle, lead to wrong analysis or signing behavior. The patch appears to keep behavior equivalent by using the same data through a different path.
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100
This commit is a small code cleanup: it adds a helper function called GetOutPoint to PSBTInput and replaces several direct accesses to transaction input data with calls to that helper. There is no change in behavior or security fix visible in the diff. It appears to be a refactoring to make the code easier to maintain.
Security candidatepsbt: AddInput and AddOutput should take only PSBTInput and PSBTOutputby Ava Chow · 95897507 · Apr 29, 2026 · 4 filesMessage 50 · ThinLow 27Details
Commit message · Ava Chow
psbt: AddInput and AddOutput should take only PSBTInput and PSBTOutput
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 27/100
This commit refactors how inputs and outputs are added to Partially Signed Bitcoin Transactions (PSBTs). Previously, callers had to pass both a raw transaction input/output and a PSBT-specific input/output, which could become inconsistent. Now the functions accept only the PSBT-specific object and derive the raw transaction data from it. For PSBT version 2, the code currently just returns false and does not actually add anything, which appears to be intentional but incomplete support. The change reduces the risk of mismatched data and duplicate inputs, but it is primarily a code-quality and API-safety improvement rather than a fix for an active exploit.
Instead of allowing PSBTs to be default constructor, force usage of the deserialization constructor.
CombinePSBTs, DecodeBase64PSBT, and DecodeRawPSBT are all changed to return std::optional or util::result rather than using an output parameter to avoid the need for a default constructor.
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 19/100
This commit is a code-quality refactor for Bitcoin Core's Partially Signed Bitcoin Transaction (PSBT) handling. It removes the ability to create an empty/default PSBT object and changes helper functions so they return a valid PSBT or an explicit failure instead of filling in an empty object. This makes accidental use of an uninitialized PSBT impossible, but it does not fix a known active bug or vulnerability by itself.