BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 51 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPCby Ava Chow · fcf76ea5 · Nov 6, 2026 · 5 filesMessage 91 · StrongInformational 19Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36333: wallet: Delete `removeprunedfunds` RPC

ec7f64d02e370e04354e64fa745fca240bcb3cbe doc: release note for removeprunedfunds rpc deletion (David Gumberg)
3d8c55734e91049f50bb90637be2678bf3ab3619 wallet: rpc: Delete removeprunedfunds (David Gumberg)

Pull request description:

Deprecated in v32 (https://github.com/bitcoin/bitcoin/pull/35605), this deletes the useless and harmful `removeprunedfunds` RPC.

~~It also removes deleting of watchonly transactions from the not-watchonly migrated wallet, which in theory we should clean up, but in practice this does nothing for the user, the only observable change is that if the user knows the txid they can do `gettransaction` and the migrated wallet will return the transaction information even though it does not have keys for the transaction, AFAICT for both GUI and RPC having irrelevant transactions inside of wallet is harmless and does not affect the output of anything, since most stuff is gated behind `IsMine()` anyways.~~

~~Removing both the RPC and the deletion of watchonly tx'es allows deleting the logic for transaction removal and the associated tests.~~

Edit: This will be done in a follow-up, all this PR does is delete the `removeprunedfunds` RPC.

_LLM Disclosure: Not used to write this PR or PR description, but I recently replaced clang on my machine with gemma-4-26B directly generating machine code._

ACKs for top commit:
achow101:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
pablomartin4btc:
re-ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
w0xlt:
ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe
polespinasa:
untested ACK ec7f64d02e370e04354e64fa745fca240bcb3cbe

Tree-SHA512: dd9f982db05f0b74eafe0fac11e4f8b9b59ffba26a7c9d04b15dba7b6d0b070ef4115e44d9ae9c0f619b0b401c3df3a0f9181ed49e080f300406513267faee81

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes an old Bitcoin Core wallet RPC command called removeprunedfunds that was already marked deprecated in the previous release. The change is a planned cleanup, not a security fix. It deletes the command's code, its registration, release notes, and related tests. There is no indication in the commit that this fixes a vulnerability or that the removal itself creates a security issue.

Security candidateMerge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizesby merge-script · 6996cf7a · Nov 5, 2026 · 10 filesMessage 96 · StrongLow 27Details
Commit message · merge-script

Merge bitcoin/bitcoin#36725: refactor: Use u64 consistently for flatfile sizes

fa2c8df1810f23e1c510e310eb246fd5abd3a066 Add test coverage for varint overflow (MarcoFalke)
faed02f6d0aba80e1f99842fcd575625d9e89fc1 refactor: Use LARGE_INTEGER QuadPart on Windows (MarcoFalke)
faf8d0e33ad000f72539aeedf4ab47c2e25b97ba refactor: Use u64 consistently for flatfile sizes (MarcoFalke)

Pull request description:

`unsigned` is a 32-bit integer (even on 64-bit platforms). File sizes are generally measured in 64-bit integers and using 32-bit integers or architecture-dependent integers is brittle and confusing.

So use u64 consistently for flatfile sizes in this refactor.

Also, use `LARGE_INTEGER`'s `QuadPart` on Windows, which is recommended since C++11.

Also, unit test VarInt overflow errors.

ACKs for top commit:
darosior:
utACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
frankomosh:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066
sedited:
ACK fa2c8df1810f23e1c510e310eb246fd5abd3a066

Tree-SHA512: f79593a6d01296177e432a25d9ce2af0fb8a2cbcea3a2ba8160f6ac03c16ea6a26ba97341475bf9a22c3bc4a28f7fce741bc544b82d604fe209c43786508966d

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 27/100

This is a code cleanup (refactor) that switches file-size variables from 32-bit or platform-dependent types to a consistent 64-bit unsigned type. It also adds unit tests for variable-integer overflow and simplifies a Windows file-size API call. The changes reduce the risk of future bugs related to very large files or integer overflow, but they do not by themselves fix a known exploitable vulnerability.

Lower-priorityMerge bitcoin/bitcoin#36741: policy: Document rounding behavior of feerate fee gettersby merge-script · 46a004d0 · Nov 5, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36741: policy: Document rounding behavior of feerate fee getters

fa3d4f099282a79099e59427180dffce4012a2b6 policy: Document rounding behavior of feerate fee getters (MarcoFalke)

Pull request description:

Now that the impl moved into the C++ file in 38ece2a9c853ae3db9afb5215611c3e23e40461f, it could make sense to document the rounding behavior in the header file doxygen comment.

Also, drop the "special case", which seems more confusing than helpful. (It is only a special case for negative feerates, which are mostly irrelevant and only possible with manual fee prioritization deltas)

ACKs for top commit:
pablomartin4btc:
re-ACK fa3d4f099282a79099e59427180dffce4012a2b6
polespinasa:
ACK fa3d4f099282a79099e59427180dffce4012a2b6
sedited:
ACK fa3d4f099282a79099e59427180dffce4012a2b6

Tree-SHA512: da230551e8ccb0c01ce1789c8b2ac6e523a48e0944338cb1596767feb81af3261ba8c9977b8c18c84c3b38f9aaec3f8c7c3d10c79940a5bd49405989af8c9aff

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search completeby merge-script · 80d1da3c · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36775: test: wallet: BnB marks exhaustive search complete

ac2c946d3b211e90abb48357b0cb2afadbc64a38 test: BnB marks exhaustive search complete (conradgabe)

Pull request description:

`SelectCoinsBnB` marks its result as completed when it exhausts the search space before reaching `TOTAL_TRIES`. Only the incomplete case is checked in the unit tests (`bnb_exhaustion_with_solution_test`), and the `bnb_finds_min_waste` fuzz target only reads the flag to decide whether to assert optimality, so reporting false goes unnoticed.

This PR checks `GetAlgoCompleted()` in `TestBnBSuccess` for cases that finish below the attempt limit (100,000).

Kills the following mutant (https://mutanthub.space/mutants/1096):
```diff
--- a/src/wallet/coinselection.cpp
+++ b/src/wallet/coinselection.cpp
@@ -233,7 +233,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
if (curr_selection.empty()) {
// Exhausted search space before running into attempt limit
is_done = true;
- result.SetAlgoCompleted(true);
+ result.SetAlgoCompleted(false);
break;
}
// Set `next_utxo` to one after last selected, then deselect last selected UTXO
```

ACKs for top commit:
yancyribbens:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/ac2c946d3b211e90abb48357b0cb2afadbc64a38
murchandamus:
ACK ac2c946d3b211e90abb48357b0cb2afadbc64a38

Tree-SHA512: f7c00f01fba900557fe26e2b7c6651ea6217508bd1f55202122e1b64ce1efa30f36ab474d24c61b29112b4e5594c7bed8d1e4787492dcd73ae61ca7592450d0e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new check to an existing unit test. It makes sure that when Bitcoin Core's coin-selection algorithm (called Branch-and-Bound or BnB) finishes searching all possible coin combinations, it correctly reports that the search was completed. The actual production code is unchanged; only the test is strengthened. There is no security fix or vulnerability being patched.

AI review queuedMerge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32by merge-script · 83e4347e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36777: refactor: rpc: doc: Mark longpoll counter u32

fa8817e6087e0d112f6421de47cb2bc7504b3ca1 refactor: rpc: doc: Mark longpoll counter u32 (MarcoFalke)

Pull request description:

The counter will only ever be a valid u32 value in normal operation, so document that without changing any behavior.

In theory, the behavior could be changed to use `LocaleIndependentAtoi<uint32_t>()`, but this is left for the future.

The change is needed to be able to fuzz the `rpc` target.

To test after compiling with `-DSANITIZERS=undefined,integer,float-divide-by-zero`:

```
$ base64 /tmp/a.crash
Z2V0YmxvY2t0ZW1wbGF0ZVyzXC1sb25ncG9sbGlkXNHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
AAAAAAAAAAAAAAAgAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAABCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJCQkJC
QkJCQkJCQkJCQkJCQkLR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRZ2VsA6NjA2+pYysAmfcAuMXhQwjp7WJsXA==

$ FUZZ=rpc ./bld-cmake/test/with_sanitizer_env.py ./bld-cmake/bin/fuzz /tmp/a.crash
src/rpc/mining.cpp:842:42: runtime error: implicit conversion from type 'long' of value 9223372036854775807 (64-bit, signed) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
#0 0x5603ba69a874 in getblocktemplate()::$_0::operator()(RPCMethod const&, JSONRPCRequest const&) const
...
```

Or:

```
$ UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=0:report_error_type=1" ./bld-cmake/bin/bitcoind -datadir=/tmp -regtest &

$ ./bld-cmake/bin/bitcoin-cli -datadir=/tmp -regtest getblocktemplate '{"rules":["segwit"],"longpollid":"00000000000000000000000000000000000000000000000000000000000000009223372036854775807"}'

ACKs for top commit:
sedited:
ACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1
darosior:
utACK fa8817e6087e0d112f6421de47cb2bc7504b3ca1

Tree-SHA512: 607c14632d900c3a99b82560c858967bfd1475f6d274c97942428ebe2f26fb47d5086de4fb142814107a7231d2443d732addb4b27b23b01ab21202b4bf47848b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationfuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 21/100

This is a small code cleanup in Bitcoin Core's getblocktemplate RPC. It changes the type of an internal counter from 'unsigned int' to the explicitly-sized 'uint32_t' and documents that the long-poll counter is expected to be a 32-bit value. The patch does not change runtime behavior; it merely makes the existing implicit truncation explicit so that fuzzing and sanitizer tools don't flag it as suspicious. There is no direct security fix here, but making the code's assumptions explicit helps future testing catch real bugs.

Security candidateMerge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsingby merge-script · 9f03a91c · Nov 5, 2026 · 15 filesMessage 81 · StrongInformational 21Details
Commit message · merge-script

Merge bitcoin/bitcoin#36384: rpc: Use self.Arg<_>(name) helper over manual and duplicate parsing

fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b doc: Fix typo in walletcreatefundedpsbt dev comment (MarcoFalke)
fa62bc2b42f129495541f122707183185da1062b refactor: rpc: Use self.Arg<_>(name) helper over manual isNull() ? fallback : getter() (MarcoFalke)
faee904d88faa33aeac317119b245730e5e0fcfe rpc: Align psbt_version parsing (MarcoFalke)
fab17591d5155dc5e903025ff8d021f9ac3e42de rpc: Parse generatetoaddress maxtries as u64 (MarcoFalke)
fa105f82c3cb4b48c992cdb3e04096c86a34f2c9 rpc: doc: Use proper RPCArg::Default in verifychain (MarcoFalke)
6666c799b956c0403cb68a85fe9f1d8a3935ed76 rpc: Use the first arg name in GetParamIndex (MarcoFalke)

Pull request description:

The `Arg()` helper has many benefits:

* It does not require manual `isNull` checks
* It does not require hard-coding the fallback/default value a second time
* It does not require manually specifying the getter for the type. Specifying the type is enough.

So use it more broadly.

ACKs for top commit:
stickies-v:
re-ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b
fanquake:
ACK fa7b2d05387ef2735b1a8b0b1a91ab4d3a070b4b

Tree-SHA512: d057a5be92656cc6b5d4104e7adc43075e9e78852ce99c3ded73a967e08c51d0eba5d02442c57f19b7c62b0ae368031581e10677bbad29f87de1ed0af2498d27

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 21/100

This is a code cleanup change in Bitcoin Core's RPC (remote procedure call) handling. It replaces manual argument parsing with a helper called self.Arg<_>(name). The goal is to reduce duplicated code and make defaults easier to maintain. There is no obvious security vulnerability introduced, but any refactor touching many RPC commands carries a small risk of subtle behavior changes.

Lower-priorityMerge bitcoin/bitcoin#36609: ci: update some lint infraby merge-script · 093586bf · Nov 5, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36609: ci: update some lint infra

e9e57d1056743454727b8c9b9699b2d3e4aa2aa1 lint: set ruff target-version to py310 (fanquake)
80020a95640f7fd958b7c14e7bc32c1754b778c1 ci: use pyzmq 27.3.0 (fanquake)
cec51655f36d0f59fc413b408bc8bac0c35f1fa0 ci: use MLC 1.3.0 (fanquake)
a8520e6433a39ea00169915835fad768e9ee21b6 ci: use mypy 2.4.1 (fanquake)
a1053449c67695582980e038adc6beeb9d088f3f ci: use ruff 0.17 (fanquake)
661b4755425a4ef20af8c38dcf8c9d0c92d97523 ci: use uv 0.13 (fanquake)

Pull request description:

Bump `uv`, `ruff`, `mypy`, `pyzmq` and `MLC`.

ACKs for top commit:
willcl-ark:
ACK e9e57d1056743454727b8c9b9699b2d3e4aa2aa1

Tree-SHA512: 3625fcd30f14f0eff5839eb749971848150ba171d1eeafb4a2e066262759dd05a181fbd55b635f4419098fc4429208cd096702b4ad7dec5a1ce4016b8d3dbb41

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36774: test: Add missing suppression for race:std::__1::__pad_and_outputby merge-script · a8a0e3ae · Nov 5, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36774: test: Add missing suppression for race:std::__1::__pad_and_output

fa3821edc0b55639a6c194fddd15ab024abc3402 test: Add missing suppression for race:std::__1::__pad_and_output (MarcoFalke)

Pull request description:

From https://github.com/bitcoin/bitcoin/actions/runs/41684419453/job/126086262840?pr=35990#step:11:8669:

```
WARNING: ThreadSanitizer: data race (pid=17903)
Write of size 8 at 0x7ff5c1990c20 by thread T12 (mutexes: write M0):
#0 width /llvm-project/libcxx/include/ios:498:18 (libc++.so.1+0xd3816) (BuildId: 6e001266114c9106207bb18363e2d5a09b534306)
#1 std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>> std::__1::__pad_and_output[abi:dee230102]<char, std::__1::char_traits<char>>(std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>>, char const*, char const*, char const*, std::__1::ios_base&, char) /llvm-project/libcxx/include/__locale_dir/pad_and_output.h:67:9 (libc++.so.1+0xd3816)
#2 std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>> std::__1::num_put<char, std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>>>::__do_put_integral[abi:dee230102]<long long>(std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>>, std::__1::ios_base&, char, long long) const /llvm-project/libcxx/include/__locale_dir/num.h:907:10 (libc++.so.1+0xbcfa0) (BuildId: 6e001266114c9106207bb18363e2d5a09b534306)
#3 std::__1::num_put<char, std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>>>::do_put(std::__1::ostreambuf_iterator<char, std::__1::char_traits<char>>, std::__1::ios_base&, char, long long) const /llvm-project/libcxx/include/__locale_dir/num.h:919:16 (libc++.so.1+0xbcb79) (BuildId: 6e001266114c9106207bb18363e2d5a09b534306)
#4 put /llvm-project/libcxx/include/__locale_dir/num.h:780:12 (libc++.so.1+0x9b40c) (BuildId: 6e001266114c9106207bb18363e2d5a09b534306)
#5 std::__1::basic_ostream<char, std::__1::char_traits<char>>& std::__1::basic_ostream<char, std::__1::char_traits<char>>::__put_num[abi:dee230102]<long long>(long long) /llvm-project/libcxx/include/__ostream/basic_ostream.h:104:21 (libc++.so.1+0x9b40c)
#6 std::__1::basic_ostream<char, std::__1::char_traits<char>>::operator<<(long long) /llvm-project/libcxx/include/__ostream/basic_ostream.h:316:10 (libc++.so.1+0x9b2a0) (BuildId: 6e001266114c9106207bb18363e2d5a09b534306)
#7 KernelLog::LogMessage(btck::LogEntry const&) /home/runner/work/_temp/src/bitcoin-chainstate.cpp:49:33 (bitcoin-chainstate+0xf2667) (BuildId: cff46198c8fd29997404a749cd55fdd6fcb3e865)

ACKs for top commit:
fanquake:
utACK fa3821edc0b55639a6c194fddd15ab024abc3402

Tree-SHA512: 383705fe33e429d40baaf7811a3edd6ce5164c423a1450c7a7a5d749d1ba44b8dac7a1270cbb593fcd0888dd9a2efbe7507650adf69b2f46ac09db4488cb9aec

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationmerge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding optionsby merge-script · 0fe899d0 · Nov 5, 2026 · 7 filesMessage 91 · StrongLow 33Details
Commit message · merge-script

Merge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding options

faeb073ca68348bc663c80b3f2b70d7014466b07 test: Use new named arg aliases in tests (MarcoFalke)
fac8ef10f4c618136dd318f642fd7ccb4587d509 wallet: rpc: Add snake_case aliases for wallet funding options (MarcoFalke)

Pull request description:

The options for wallet funding RPCs have several issues:

* snake_case aliases are accepted by the server, but unsupported by bitcoin-cli, not mentioned in the docs and rejected by the schema.
* If both the snake_case and camelCase are provided, the camelCase is silently ignored.
* The server silently ignores `subtract_fee_from_outputs`. (reported by stutxo in https://github.com/bitcoin/bitcoin/pull/35317)

Fix all issues, by:

* Adding the snake_case aliases to the CLI, docs and the schema.
* Rejecting if both are supplied.
* Reading `subtract_fee_from_outputs` instead of silently ignoring it.

ACKs for top commit:
Conradgabe:
tACK faeb073ca68348bc663c80b3f2b70d7014466b07
sedited:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07
willcl-ark:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07

Tree-SHA512: d434c98d9a2aacf3d547d727f7d31a052beea7079f6ca32ed08877523f28231ae0bc7f1ff9a909856b7b14f7e89560058ec723918277d259b2810bcb90982804

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100

This update fixes a quirk in Bitcoin Core's wallet commands where some option names using underscores (like subtract_fee_from_outputs) were accepted by the server but not properly handled by the command-line tool or documentation. More importantly, the server was silently ignoring subtract_fee_from_outputs, meaning a user who thought they had told the wallet to deduct the transaction fee from a recipient's payment would actually end up paying the fee themselves. The patch also now rejects supplying both the old camelCase name and the new snake_case name at the same time, preventing confusion. It is a bug fix with a mild financial-impact risk rather than a direct theft or remote-code-execution vulnerability.

Security candidateMerge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestampby merge-script · b4f341a9 · Nov 5, 2026 · 6 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36192: test: cover unsatisfiable mining timestamp

c000f6ef15e06856b9111ee433877a2b1bf31eb4 test: assert Murch-Zawy period boundaries (Sjors Provoost)
9b4f05a240a3feaf99976fd14952a21b3f96e029 test: cover unsatisfiable mining timestamp (Sjors Provoost)
2137b7b2ee3ae3c39aa74a9ac7e26d821c1b4988 test: share block timing constants through blocktools (Sjors Provoost)
bb32ef4d541d14752f2dca9b1a633aecea9d40a7 test: drop REGTEST_ prefix from block difficulty constants (Sjors Provoost)
9f34ea1605bd0c8726cc69ecf5686cc6d3d0d125 test: rename REGTEST_RETARGET_PERIOD to HALVING_INTERVAL (Sjors Provoost)

Pull request description:

This PR adds test coverage for what happens in the (extremely unlikely) event that the miner can't satisfy the constraints. This is inspired by the recently added timewarp-protection and Murch-Zawy rules (for the miner, not for consensus, see #30681 and #35949), but this is a pre-existing issue. It is not made worse by these rules.

The test has an attacker mine 6 blocks, which set MTP at the victim's future-time limit. It calls `getblocktemplate` and the equivalent IPC method, which both fail. It then moves mock time one second forward, and demonstrates mining works again (and we don't drop the IPC connection).

This (impractical) attack can be done at any height, be we illustrate it for blocks 142, 143 and 0 of a retarget period, to clarify that the timewarp-protection and Murch-Zawy rules do not matter.

The test was added to `ipc_mining.py`, to avoid having to add IPC support to `mining_basic.py`. Mining coverage is currently split between various test files and not always mirrored between RPC and IPC. A followup could unify these, while still skipping the IPC side when that's not compiled.

A few refactor commits to prepare:

- fix incorrect name: `REGTEST_RETARGET_PERIOD` -> `HALVING_INTERVAL`
- drop `REGTEST_` prefix from `REGTEST_N_BITS` and `REGTEST_TARGET` (consistent with `HALVING_INTERVAL`, `DIFFICULTY_ADJUSTMENT_INTERVAL` and `TIME_GENESIS_BLOCK`).
- move `DIFFICULTY_ADJUSTMENT_INTERVAL` to the framework

The last commit picks up a Murch-Zawy followup suggested in https://github.com/bitcoin/bitcoin/pull/35949#discussion_r3944011135 and takes advantage of our refactor, but is otherwise unrelated.

ACKs for top commit:
fjahr:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
ismaelsadeeq:
reACK c000f6ef15e06856b9111ee433877a2b1bf31eb4
sedited:
ACK c000f6ef15e06856b9111ee433877a2b1bf31eb4

Tree-SHA512: e92c46ba5366024eca6d2af5569f3665bea22db232608ca8b94abf3c921a2cc39e70af1aa2612c972a4ad2838da0d9ad47941d676b6f802bbc8987ed8ac6639c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languageconsensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and reorganizes Bitcoin Core's own functional tests. It renames some test constants, moves a shared constant into the test framework, and adds a new test that checks how the mining code behaves when an attacker manipulates block timestamps to make template creation temporarily fail. The commit does not change any production consensus, networking, or wallet code, and the pull request description explicitly calls the scenario an 'impractical' test-case. There is no security patch or vulnerability fix here.

Lower-priorityMerge bitcoin/bitcoin#35598: test: cover feeThreshold = MAX_MONEY in interface_ipc_mining.pyby merge-script · d2897c20 · Nov 5, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#35598: test: cover feeThreshold = MAX_MONEY in interface_ipc_mining.py

7dfc7ef17ca33d01b854f63789cd357fee84f22d test: cover feeThreshold = MAX_MONEY (Sjors Provoost)

Pull request description:

This adds coverage for when [BlockWaitOptions](https://github.com/bitcoin/bitcoin/blob/master/src/node/mining_types.h#L94-L113)'s `feeThreshold` is set to `MAX_MONEY`. In other words, when the IPC client is only interested in tip updates, not in fee increases.

This tested ended up in #33922 at some point https://github.com/bitcoin/bitcoin/pull/33922#issuecomment-3674495132, but doesn't really belong there.

ACKs for top commit:
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/7dfc7ef17ca33d01b854f63789cd357fee84f22d
sedited:
ACK 7dfc7ef17ca33d01b854f63789cd357fee84f22d
enirox001:
reACK https://github.com/bitcoin/bitcoin/pull/35598/changes/7dfc7ef17ca33d01b854f63789cd357fee84f22d

Tree-SHA512: c030846d8b1cbdebd3a96909368a0059b9feff63138b6c7192f6b8f9c9b31ffaf88c4f6b109a79cec10b8dfb62067498f62131da7b15f20217626e6d06b239f2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0by merge-script · fefea34e · Nov 5, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36592: build: Bump macOS SDK version to 15.0

eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d build: Bump macOS SDK version to 15.0 (Hennadii Stepanov)

Pull request description:

Qt 6.12, which supports deployment targets up to macOS 26, requires the macOS 15 SDK or higher.

See https://doc.qt.io/qt-6.12/macos.html.

This is a prerequisite for the upcoming update of Qt in depends from 6.8 LTS to 6.12 LTS.

My partial Guix build:
```console
$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
727bcc7343afc599cadad3891a6aaa73883594a5feea6695b81056eaf1881914 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/SHA256SUMS.part
cea76395e4761c9cc6c1e7fc0eae52abd3bb024caeed62a3461a9cf0de2f4b08 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-codesigning.tar.gz
8886c05cca9f518441284be4cb415d275b7d118e8150e441d053e3fc61d27807 guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.tar.gz
7c6c4423e6272a821fd6adefaac6dd4a1e09f7f85ecf9efa6bd7e97c0ddc79bc guix-build-eaa8d1f5a5fc/output/arm64-apple-darwin/bitcoin-eaa8d1f5a5fc-arm64-apple-darwin-unsigned.zip
a74db20b1a8acd1a570a733d02ea7e3aa28ac8902462e9be9fac10e0f84e4ca1 guix-build-eaa8d1f5a5fc/output/dist-archive/bitcoin-eaa8d1f5a5fc.tar.gz
f708d94dc0343a5057d3b8791242acd67dbb1f481b2da7fc778aa981e9fc2e42 guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/SHA256SUMS.part
98ddcc471b967208e491c06f697e94d09005631da463e085ee88e281c035180e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-codesigning.tar.gz
7aeb9b6f84679f11d22ffe1faf4b0aa386c09f641a6d742f70ef727466b24d0f guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.tar.gz
de23e46dbe3c0886fd689b16ab345120907445212ffb6fcb41ccca8cfc8d628e guix-build-eaa8d1f5a5fc/output/x86_64-apple-darwin/bitcoin-eaa8d1f5a5fc-x86_64-apple-darwin-unsigned.zip
```

ACKs for top commit:
maflcko:
lgtm ACK eaa8d1f5a5fcfeefcb3ff432aeb969e8f8f14a7d

Tree-SHA512: 6dd679e9dfdae60e4a2cb6f891c3779699dc27045fe877a820dd839972fd0771dcdf9d0a432a0cb64a1de58b138e4e5fe24d1ab43af7cd8aa3fe632f4717cab4

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This commit simply updates the version number of the Apple macOS software development kit (SDK) used to build Bitcoin Core from 14.0 to 15.0. It is a routine build-system change needed to support a future Qt GUI library upgrade. There is no indication of a security vulnerability, bug fix, or behavior change in the running software.

Security candidateMerge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditionsby merge-script · 93bd4e1d · Nov 5, 2026 · 68 filesMessage 100 · StrongModerate 59Details
Commit message · merge-script

Merge bitcoin/bitcoin#36747: Update libmultiprocess subtree to add nonunix platform support and fix race conditions

d5f7524897dd5ec638cebf7d61607c561c3b9e2b doc: Bump minimum required Cap'n Proto version to 0.9.2 (Ryan Ofsky)
4898199d8f97cad75cfd54a9caed3ffd3ce2948c build: suppress -Wc++23-lambda-attributes in warn_interface (Ryan Ofsky)
270f5dbe3ddac5191ec6b21ceb17c3dddb79b12f Squashed 'src/ipc/libmultiprocess/' changes from e8de5c7b68e..acded1aafae (Ryan Ofsky)

Pull request description:

The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh).

Changes since last subtree update (#35720):

- Adds support for nonunix platforms, making API changes that are not backwards compatible ([#274](https://github.com/bitcoin-core/libmultiprocess/pull/274)). Follow-ups add a `CurrentThread()` accessor matching compatibility code in [bitcoin/bitcoin#35084](https://github.com/bitcoin/bitcoin/pull/35084) ([#323](https://github.com/bitcoin-core/libmultiprocess/pull/323)) and remove code for Cap'n Proto versions before 0.9 ([#331](https://github.com/bitcoin-core/libmultiprocess/pull/331)).
- Fixes a data race between IPC calls running on worker threads and disconnects, found by Antithesis ([#349](https://github.com/bitcoin-core/libmultiprocess/pull/349)).
- Fixes a use-after-free when a socket disconnects before `ConnectStream` connects, and leaks and hangs when a client `construct()` call throws ([#298](https://github.com/bitcoin-core/libmultiprocess/pull/298)).
- Fixes a race where file descriptors from `SpawnProcess` could leak into processes forked at the same time by other threads, by clearing `FD_CLOEXEC` in the child after forking ([#311](https://github.com/bitcoin-core/libmultiprocess/pull/311)).
- Makes `SpawnProcess` report `exec` failures back to the parent and throw, reaping the child ([#312](https://github.com/bitcoin-core/libmultiprocess/pull/312)).
- Adds support for `std::chrono::time_point` fields ([#303](https://github.com/bitcoin-core/libmultiprocess/pull/303)) and for serializing lists of interface objects that need to be moved from ([#304](https://github.com/bitcoin-core/libmultiprocess/pull/304)), both needed by [bitcoin/bitcoin#10102](https://github.com/bitcoin/bitcoin/pull/10102).
- Accepts container fields and parameters with any comparator, hash, and allocator types, like Bitcoin Core's `GCSFilter::ElementSet`, needed by [bitcoin/bitcoin#29409](https://github.com/bitcoin/bitcoin/pull/29409) ([#379](https://github.com/bitcoin-core/libmultiprocess/pull/379)).
- Finds the `capnp` tool in vcpkg and Windows builds, needed by [bitcoin/bitcoin#32387](https://github.com/bitcoin/bitcoin/pull/32387) ([#317](https://github.com/bitcoin-core/libmultiprocess/pull/317)).
- Adds a `destroy_connection` option to `ServeStream` and `ConnectStream`, lets `ServeStream` take ownership of the init object and return the new server and its connection, and adds an `EventLoop::incomingConnections()` accessor, simplifying test setup in both repositories and needed by [bitcoin/bitcoin#35932](https://github.com/bitcoin/bitcoin/pull/35932) ([#365](https://github.com/bitcoin-core/libmultiprocess/pull/365)).
- Replaces `EventLoop::post()` with `sync()` taking a `kj::FunctionParam`, avoiding a heap allocation per call ([#347](https://github.com/bitcoin-core/libmultiprocess/pull/347)).
- Names threads spawned by the event loop so they can be told apart in tools and logs ([#324](https://github.com/bitcoin-core/libmultiprocess/pull/324)).
- Fixes warnings that Bitcoin Core enables or plans to enable: adds `[[noreturn]]` attributes for `-Wmissing-noreturn` ([#339](https://github.com/bitcoin-core/libmultiprocess/pull/339), for [bitcoin/bitcoin#35911](https://github.com/bitcoin/bitcoin/pull/35911)), and fixes `-Wunused` ([#362](https://github.com/bitcoin-core/libmultiprocess/pull/362), for [bitcoin/bitcoin#36167](https://github.com/bitcoin/bitcoin/pull/36167)), `-Wunused-const-variable` and `-Wundef` ([#370](https://github.com/bitcoin-core/libmultiprocess/pull/370)), and `-Wmissing-prototypes` ([#386](https://github.com/bitcoin-core/libmultiprocess/pull/386), for [bitcoin/bitcoin#36743](https://github.com/bitcoin/bitcoin/pull/36743)) warnings.
- Fails at compile time with a suggested workaround when Cap'n Proto misdetects exception support (`KJ_NO_EXCEPTIONS`), as happens on NetBSD ([#364](https://github.com/bitcoin-core/libmultiprocess/pull/364)).
- Build improvements: fixes stale generated code when the `mpgen` binary changes ([#316](https://github.com/bitcoin-core/libmultiprocess/pull/316)), fixes `mpgen` link order for static Cap'n Proto builds ([#367](https://github.com/bitcoin-core/libmultiprocess/pull/367)), links `mpgen` against `kj-async` instead of `capnp-rpc` ([#327](https://github.com/bitcoin-core/libmultiprocess/pull/327)), shows Cap'n Proto `find_package` diagnostics ([#325](https://github.com/bitcoin-core/libmultiprocess/pull/325)), installs `type-unordered-set.h` and `version.h` ([#350](https://github.com/bitcoin-core/libmultiprocess/pull/350)), and shows include-what-you-use errors instead of failing silently ([#371](https://github.com/bitcoin-core/libmultiprocess/pull/371)).
- Test, CI, documentation, and minor code improvements: fix for a startup race in the example program ([#315](https://github.com/bitcoin-core/libmultiprocess/pull/315)), new test for immediate client disconnects in `ListenConnections` ([#310](https://github.com/bitcoin-core/libmultiprocess/pull/310)), `ReadList` return value check ([#338](https://github.com/bitcoin-core/libmultiprocess/pull/338)), connect test race fix ([#343](https://github.com/bitcoin-core/libmultiprocess/pull/343)) and cleanups ([#344](https://github.com/bitcoin-core/libmultiprocess/pull/344)), `std::ranges::copy` follow-ups ([#307](https://github.com/bitcoin-core/libmultiprocess/pull/307)), trailing whitespace removal ([#345](https://github.com/bitcoin-core/libmultiprocess/pull/345)), Cap'n Proto version documentation fix ([#357](https://github.com/bitcoin-core/libmultiprocess/pull/357)), clang-tidy updates ([#358](https://github.com/bitcoin-core/libmultiprocess/pull/358), [#360](https://github.com/bitcoin-core/libmultiprocess/pull/360), [#380](https://github.com/bitcoin-core/libmultiprocess/pull/380), [#389](https://github.com/bitcoin-core/libmultiprocess/pull/389)), new CI job testing newer cmake and Cap'n Proto versions ([#212](https://github.com/bitcoin-core/libmultiprocess/pull/212), [#359](https://github.com/bitcoin-core/libmultiprocess/pull/359)), CI coverage for the minimum supported g++ ([#330](https://github.com/bitcoin-core/libmultiprocess/pull/330), [#366](https://github.com/bitcoin-core/libmultiprocess/pull/366)), new CI warnings ([#332](https://github.com/bitcoin-core/libmultiprocess/pull/332), [#341](https://github.com/bitcoin-core/libmultiprocess/pull/341)), CI parallelism ([#334](https://github.com/bitcoin-core/libmultiprocess/pull/334), [#356](https://github.com/bitcoin-core/libmultiprocess/pull/356)), CI diagnostics ([#351](https://github.com/bitcoin-core/libmultiprocess/pull/351), [#352](https://github.com/bitcoin-core/libmultiprocess/pull/352)), Nix and LLVM updates ([#296](https://github.com/bitcoin-core/libmultiprocess/pull/296), [#363](https://github.com/bitcoin-core/libmultiprocess/pull/363)), NetBSD and OpenBSD CI fixes ([#321](https://github.com/bitcoin-core/libmultiprocess/pull/321), [#340](https://github.com/bitcoin-core/libmultiprocess/pull/340), [#381](https://github.com/bitcoin-core/libmultiprocess/pull/381)), building Cap'n Proto with GCC in the 32-bit CI job to avoid an ABI mismatch ([#383](https://github.com/bitcoin-core/libmultiprocess/pull/383)), and GitHub Actions updates ([#387](https://github.com/bitcoin-core/libmultiprocess/pull/387)).

The second commit suppresses the clang `-Wc++23-lambda-attributes` warning, which the new `[[noreturn]]` lambda attribute in `mp/proxy-types.h` triggers in C++20 builds. Since #31507 the Windows build uses clang-cl, so the same flag covers it.

The third commit updates the minimum Cap'n Proto version in `doc/dependencies.md` to 0.9.2 (1.0 with Clang). This update raises libmultiprocess's own minimum from 0.7 to 0.9 (bitcoin-core/libmultiprocess#331), and libmultiprocess rejects 0.9.0 and 0.9.1 for CVE-2022-46149 and, with Clang 16 or newer, every version before 1.0.

ACKs for top commit:
fanquake:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b
willcl-ark:
ACK d5f7524897dd5ec638cebf7d61607c561c3b9e2b

Tree-SHA512: 4064944f4d8bb6c1665ddc7d5fae838492235d7dfdafab88b19b687ff6892460a3f450b90a145b287866330c569b862d748c941a70c65abc7f273ef13e490fd7

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languagesigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 59/100

This is a routine subtree update that pulls in a newer version of the libmultiprocess inter-process communication library used by Bitcoin Core. The commit message and code changes explicitly describe several bug fixes for race conditions, use-after-free, and file-descriptor leaks in the IPC layer. It also raises the minimum required Cap'n Proto version because older versions have a known memory-safety vulnerability (CVE-2022-46149). The changes are defensive: they fix bugs rather than introduce new attack surface, but the bugs being fixed are in security-relevant areas (cross-process communication, threading, and process spawning).

Lower-priorityMerge bitcoin/bitcoin#36771: ci: Add missing --error-on=any to apt updateby merge-script · ef7c5a90 · Nov 5, 2026 · 4 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36771: ci: Add missing --error-on=any to apt update

fa294de4c4f62d01b25989bef048456091161849 lint: Allow clang-format to be used in scripted-diff (MarcoFalke)
fa7a154c9f3a7a89b54f99c73765c5a6db41ee33 ci: Add missing --error-on=any to apt update (MarcoFalke)

Pull request description:

The CI can't continue without an apt update, so fail early and properly on any error.

Can be tested with something like: `podman run --rm -it --network none mirror.gcr.io/debian:unstable bash -c 'apt-get update ; echo $?'`

Also, cleanup the lint install script while touching this (and allow clang-format for scripted-diffs in the rare case that they want to use it to e.g. re-sort includes)

ACKs for top commit:
fanquake:
ACK fa294de4c4f62d01b25989bef048456091161849

Tree-SHA512: 9a29b4530b3a8a536f4b2a8564c5ee35f8c55e3c18e70e01613f7776b84a07d3fde73018b9bfafc9518ec46c04ca65a51de77797d28b420119a5126cb4dc0b14

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36470: test: make p2p_eviction actually exercise block-time protectionby merge-script · 42b28c8a · Nov 5, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36470: test: make p2p_eviction actually exercise block-time protection

2fd9be21e28fecf298493e28e90ccb8085aa4ae8 test: make p2p_eviction actually exercise block-time protection (Bruno Garcia)

Pull request description:

`p2p_eviction.py` tests that 4 inbound peers that recently sent us a novel block are protected from eviction. However, the test currently passes even when that protection is not in effect.

The block-sending peers are connected first, so they are the oldest connections. When block-time protection doesn't apply, `CompareNodeBlockTime` falls back to connection time and protects the 4 oldest peers, which are these same peers. Then the youngest remaining peer gets evicted. The check `evicted_peers[0] not in protected_peers` therefore holds whether or not block-time protection works.

This can be shown by deleting the line where the peers send their block (L71 on master):
```py
block_peer.send_blocks_and_test([block], node, success=True)
```

ACKs for top commit:
maflcko:
review ACK 2fd9be21e28fecf298493e28e90ccb8085aa4ae8 🗜
sedited:
ACK 2fd9be21e28fecf298493e28e90ccb8085aa4ae8

Tree-SHA512: 1da546bb8ab724cfe2fbf7061cae055ddf63e97708e89dc6480fe76f4d616b4ed6d69d4bbbf9604d5100789e469553e50971176ad56ba86871db14ec7685972c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36193: guix: introduce a minimal `linux-base-gcc` variantby Hennadii Stepanov · 377c7711 · Nov 5, 2026 · 4 filesMessage 91 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36193: guix: introduce a minimal `linux-base-gcc` variant

5ec877a74dfef51466888bdf4a0abd8993b1e66b guix: pass --disable-libstdcxx-filesystem-ts to libstdc++ (fanquake)
57964dc5bf812f4408cfdf352d4336aaec85e64e guix: pass --enable-clocale=generic to (non-GUI) libstdc++ (fanquake)
6e9ad62323625ca61c8b3e9ccf594753fc4b1b28 guix: pass --with-libstdcxx-zoneinfo=no to (non-GUI) libstdc++ (fanquake)
6cb41040a1093a3c4fccea58c0624467cfa6c66b guix: pass --disable-wchar_t to (non-GUI) libstdc++ (fanquake)
e381e29f9a1bdc74c3092591c75bdd4674cc3fbe depends: patch around Boost Test std::wcrtomb usage (fanquake)

Pull request description:

Introduce a minimal variant of `linux-base-gcc`, and use it for non-GUI builds.

This saves roughly half a megabyte in binary size, in the non-GUI binaries:

| Binary | master (MB) | PR (MB) |
|---|---|---|
| bitcoin | 2.15 | 1.67 |
| bitcoin-cli | 8.20 | 7.72 |
| bitcoin-qt | 43.87 | 43.87 |
| bitcoin-tx | 4.93 | 4.45 |
| bitcoin-util | 4.52 | 4.04 |
| bitcoin-wallet | 9.26 | 8.77 |
| bitcoind | 17.75 | 17.27 |

See https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html:

> `--enable-wchar_t[default]`
> Template specializations for the wchar_t type are required for wide
> character conversion support. Disabling wide character specializations
> may be expedient for initial porting efforts, but builds only a subset
> of what is required by ISO, and is not recommended. By default, this
> option is on. This option can change the library ABI.

ACKs for top commit:
hebasto:
ACK 5ec877a74dfef51466888bdf4a0abd8993b1e66b.
willcl-ark:
ACK 5ec877a74dfef51466888bdf4a0abd8993b1e66b

Tree-SHA512: acea0b54d1ce28ab787b36898212e674b1cb46540cfa038b65983d3ed123fcfe25542650de07363a2b4a94ee91032d04fd6998b68f060752bbc775ace2d55e47

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36458: Test: Add script vectors for interpreter edgesby merge-script · d206226b · Nov 5, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36458: Test: Add script vectors for interpreter edges

5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a Test: Add script vectors for interpreter edges (benthecarman)

Pull request description:

Add script_tests.json and tx_invalid.json vectors for edge cases that
other implementations have gotten wrong, including CSV with -2, IFDUP
on negative zero, ROLL with duplicate values, a taproot output key
that is not a valid x coordinate, and single-flag STRICTENC, LOW_S and
NULLFAIL cases.

Some policy cases were only caught by the tx_valid harness adding
flags back, which implementations copying the JSON don't replicate.

Related: #36455

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

ACKs for top commit:
darosior:
ACK 5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a
sedited:
LGTM ACK 5d2fb8d3098703bc4d23d582eb4987cb2dbeda7a, but waiting on resolution here: https://github.com/bitcoin/bitcoin/pull/36455#pullrequestreview-5616742117

Tree-SHA512: 7c3d1b40fbb4436637ff82d71faa6df7d0349307bb85c37f127be6dee8ec045f46081963a20d8bd03c97c6af02d8c90e1a19123c1bf7bc801dfb8a4843a62af1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36405: test: look for the wtxid in p2p_blocksonlyby merge-script · 7ce16187 · Nov 5, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36405: test: look for the wtxid in p2p_blocksonly

22535b460568be47e57aadfbe50d489becb77577 test: look for the wtxid in p2p_blocksonly (Ferdinando Ametrano)

Pull request description:

In `blocks_relay_conn_tests`, the check that a transaction submitted over RPC is not announced to a block-relay-only peer looks for its txid among the peer's invs. The peer is a `P2PTxInvStore`, which negotiates wtxidrelay, so an announcement would carry the wtxid. The MiniWallet transaction has a witness, so its txid and wtxid differ, and the check passes whether or not the node announces it.

This checks the wtxid instead. To see the difference, open that connection as `outbound-full-relay`: the old check still passes, the new one fails. It also adds an `outbound-full-relay` peer that must receive the wtxid announcement first, so the check cannot pass silently again.

#35920 also edits `blocks_relay_conn_tests`; the two do not conflict.

Found while porting these tests to https://github.com/btclib-org/bitcoin-node-tests.

ACKs for top commit:
maflcko:
lgtm ACK 22535b460568be47e57aadfbe50d489becb77577
AndreaDiazCorreia:
ACK 22535b460568be47e57aadfbe50d489becb77577
sedited:
ACK 22535b460568be47e57aadfbe50d489becb77577

Tree-SHA512: ac425fafbd8f2851dc9d11799d70ffd914ea55bdf9e63087ac8313e55748ca2635c0ae266fae0d51400d1b10b05f3ee622f9fecce6d1360ae5803b8bcadc1638

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36769: doc: Permit snippets at /doc/release-notes-uniq-name.mdby merge-script · 16b31409 · Nov 5, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36769: doc: Permit snippets at /doc/release-notes-uniq-name.md

fa2003a2394993dae1f8c8eb28bef7c60928f098 doc: Permit snippets at /doc/release-notes-uniq-name.md (MarcoFalke)

Pull request description:

This should be fine and is already being done and the Linter does not prevent it. So be honest and permit it.

ACKs for top commit:
l0rinc:
ACK fa2003a2394993dae1f8c8eb28bef7c60928f098
sedited:
ACK fa2003a2394993dae1f8c8eb28bef7c60928f098

Tree-SHA512: 6762b959582427c8558a672b592230ec6c55a6c74ad6fd190a20db7cf593c70752ac9e795bc7573a6ff686378a7d8a55338d3d19e75954572684137076b03c30

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()by merge-script · e0b4592e · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35170: test: Better test coverage for ParseHDKeypath()

3ce364124c09157722781720ee60aabb5a99e133 test: bip32_tests: Add some more tests cases (optout)
72414a709d57308e4fe69d5d96188beeeebb6855 test: bip32_tests: Add round-trip tests (optout)
60bdfdb19e98b7574b0a2c565f81c8dfec514e2f test: bip32_tests: Add expected result checks (optout)
7b5ce9c529bd38f29c1216a93fd44ae62edb56bb test: Refactor in bip32_tests: extract test data in an array (optout)

Pull request description:

Background: The `ParseHDKeypath` method (`src/util/bip32.cpp`) is used directly only in a limited way: when loading legacy wallets. However, it shares internals with parsing within descriptors (`ParseKeyPath`, `ParseKeyPathNum` in `src/script/descriptor.cpp`, c.f. #35069).

Deficiencies: The method has a unit test, but it checks only the bool result, and not the parsed keypath. This can be demonstrated by breaking the implementation by adding a `keypath.clear();` statement just before the final `return true;`. With this obviously broken implementation the tests pass.

Solution proposed: Extend the tests with checks (without modifying the behavior).

Changes:

- Extend the unit tests with checks for the returned parsed keypath. Add the expected parsed numerical keypath as test data. Note: breaking the production code as described above now results in test failure.

- In the unit test also perform round-trip conversion: convert to string, then parse again, and convert to string again. In the last two steps the results should match the input before the round-trip (note: this is not true for the first roundtrip). Additionally, add negative tests for the unsupported 'h' hardened delimiter.

ACKs for top commit:
Sjors:
re-ACK 3ce3641
achow101:
ACK 3ce364124c09157722781720ee60aabb5a99e133

Tree-SHA512: 4b0450da1c5cccf12e15aeb272c927ef3b119466ae14d9fcea3e34c5ef6e02068c43e22d68a4433c9d1a4f3c111c799f8165c13147a7317706b03e056dfb86dd

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds and improves unit tests for the ParseHDKeypath() function. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The change makes the tests verify the actual parsed output and adds round-trip checks, which improves test quality but has no runtime security impact on its own.

Lower-priorityMerge bitcoin/bitcoin#36770: test: Fix log and comment in mempool_reorg.pyby merge-script · 6a45c243 · Nov 5, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36770: test: Fix log and comment in mempool_reorg.py

2438fbcade95e695f5b90043e9694ffc182a7e5c test: Fix log and comment in mempool_reorg.py (Waridi318)

Pull request description:

Follow-up to #36663. These two pre-existing nits came up in review there and were left out of that PR to avoid review churn ([comment](https://github.com/bitcoin/bitcoin/pull/36663#issuecomment-6515191239)).

Remove the "Generate a block" log line in `test_reorg`. It adds nothing and causes confusion. The log line above it already says "Broadcast and mine spend_3_1" and the mining only happens a few lines later in `self.generate(self.nodes[0], FORK_LENGTH - 1)`.

Update the comment "Create a child of that transaction" in `test_reorg_relay`. It sits right below `tx_before_reorg`, so it suggests the child spends `tx_before_reorg`. The child actually spends `tx_disconnected`, so name it explicitly.

Only a log message and a comment change, so test behavior is unchanged. `mempool_reorg.py` passes locally.

ACKs for top commit:
maflcko:
lgtm ACK 2438fbcade95e695f5b90043e9694ffc182a7e5c
mercie-ux:
ACK 2438fbcade95e695f5b90043e9694ffc182a7e5c

Tree-SHA512: 3e123b11e78f9b7672eb38ebfdbe7b79d5144af5666a41290990352a9e5bef1e9ec089fb326a8f38b7c84818cb6799cdfd658d4bace3d88a032eb89e827efbf2

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keysby merge-script · fdd93cbb · Nov 5, 2026 · 3 filesMessage 96 · StrongHigh 70Details
Commit message · merge-script

Merge bitcoin/bitcoin#36142: net: validate Tor onion service replies and cached keys

0a53d12589c3116495a50a694006ce5ee220fb2d torcontrol: reject invalid service IDs (Lőrinc)
d0b447cf7f11d791622c919d2a0731bf33a7d33f torcontrol: validate returned and cached keys (Lőrinc)
3413d17028da5f5658af5637297013f8e396bafa torcontrol: discard replies missing a service ID (Lőrinc)
3601a1d1086b132f11db3b5e969d8fac9203decc test: characterize ADD_ONION reply handling (Lőrinc)
d63a8576d9beef910c54aabc388278897c16a41f refactor: prepare ADD_ONION validation (Lőrinc)

Pull request description:

**Problem:** A node creates its onion service through Tor's control protocol and caches the returned `PrivateKey` value for reconnects.
Tor reply parsing unescapes quoted values, so a control endpoint can return a value containing a line break or space.
On reconnect, the node inserts that value unquoted into an `ADD_ONION` command.
CRLF frames the remainder as a separate command, while a space adds further arguments.
An unprivileged local process can exploit this by impersonating the default loopback endpoint while Tor is unavailable, seeding the cache, and releasing the port before Tor is available again.
A compromised operator-configured endpoint can return the same malicious value.
The reply handler also continues after receiving an invalid service ID, logging it and caching the key before attempting to advertise the invalid address.
A later reply without a service ID can reuse an ID left by an earlier reply.

**Fix:** This PR validates the returned service ID as a Tor v3 onion address before logging it, caching the key, or advertising the service.
Each reply must provide its own service ID, and reply fields stay local until validation succeeds.
Key validation accepts `NEW:ED25519-V3` or an `ED25519-V3` key whose Base64 payload decodes to 64 bytes.
Returned keys are validated before adoption or caching, and cached keys are validated before reuse.
A malformed cached key leaves the onion service unavailable until the operator removes the file and restarts the node. It cannot inject another command or argument.

ACKs for top commit:
jpk68:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
vasild:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d
winterrdog:
tACK 0a53d12589c3116495a50a694006ce5ee220fb2d
sedited:
ACK 0a53d12589c3116495a50a694006ce5ee220fb2d

Tree-SHA512: ce3d75da56d9d2ef52655c15b8c85995cdec38305abc4c7af6baf45e03288e08e8ab13b67925b8f1c0a0734ae062101cb2bb912e962b517b8f99ee0e9911f882

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagedefensive validationcredential or privilege statemerge-commit duplicate discount
AI analysis · High 70/100

This update fixes a weakness in how Bitcoin Core talks to the Tor control port when setting up a hidden onion service. A fake or compromised Tor control endpoint could trick the node into storing a malicious private key. On a later reconnect, that bad key could be inserted into an 'ADD_ONION' command in a way that adds extra commands or arguments for Tor to run. The fix checks that any returned or cached private key has the expected format and that the returned onion address is a valid Tor v3 service ID before using or saving it.

Security candidateMerge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declarativelyby merge-script · 3b1ba022 · Nov 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36750: test: construct multisig_tests inputs/outputs declaratively

c723c37de69fd95e6ec795e848efb03d944999ba test: construct multisig_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in `multisig_tests` with `COutPoint`, `CTxIn` and `CTxOut` constructor calls.

It keeps `CMutableTransaction` as the builder, since a `CTransaction` constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the `vin`/`vout` lists here can be passed to it directly.

This change is test-only and does not change the constructed transactions:

- The funding outputs were previously created by `vout.resize(3)` and only had their `scriptPubKey` assigned, leaving `nValue` at its null value (`-1`). The `-1` is now spelled out explicitly, which makes this previously hidden value visible
- The loop index is changed from `int` to `uint32_t` to match `COutPoint::n`

ACKs for top commit:
purpleKarrot:
ACK c723c37
maflcko:
review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯
alexanderwiederin:
ACK c723c37

Tree-SHA512: 3122762dae1e4fbc1a4ad79ce67128e83d29da965b3c8b6009f075c39310b8f983a96e3c4f30844a57af2faca4c658149808176aa4bb67d940ebeec147031676

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a test-only code cleanup in Bitcoin Core. It changes how fake transactions are built inside unit tests, making the test code more readable without altering the actual transactions being tested. There is no effect on the live Bitcoin network or wallet software.

Lower-priorityMerge bitcoin/bitcoin#36612: doc: Merge all BSD build docs back into build-unix.mdby merge-script · 0e38ad26 · Nov 4, 2026 · 6 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36612: doc: Merge all BSD build docs back into build-unix.md

fa1b829b234a82fb842676af4c94054c5a460253 doc: Merge all BSD build docs back into build-unix.md (MarcoFalke)
fa0cad21858a128f650fab8b988107439df77fee doc: Rework build-unix.md memory limits notes (MarcoFalke)

Pull request description:

The BSD docs are tedious to maintain, because:

* They all include the same redundant boilerplate cmake commands and doc snippets.
* So updating the build system requires identical changes over many files.

Fix all issues by merging everything back into build-unix.md

ACKs for top commit:
hebasto:
re-ACK fa1b829b234a82fb842676af4c94054c5a460253.
sedited:
ACK fa1b829b234a82fb842676af4c94054c5a460253

Tree-SHA512: cb71cecfcd50abec097e96007f7e4fc382cf915929d0e60de99ebc0d2323f17152af4b415079614d4ebab364c3eeb773300ff7f5279734caeb4652aa9b3c00b8

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36406: test: make p2p_orphan_handling's never-requested checks able to failby merge-script · 902190b6 · Nov 4, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36406: test: make p2p_orphan_handling's never-requested checks able to fail

5f22014aca2d071edfea95e8d3d4ba0bebbc57ca test: require an int in PeerTxRelayer.assert_never_requested (Ferdinando Ametrano)
a3c4ad12e92e9d8c0e7c020d49cbdbdef203dfa5 test: make orphan inherit-rejection getdata checks able to fail (Ferdinando Ametrano)

Pull request description:

`assert_never_requested` compares its argument with the hashes in the node's getdata messages, which are ints. `test_orphan_inherit_rejection` passes it hex strings, so its four checks pass whatever the node requests.

This passes ints, which needs two more changes. The rejected parent is now relayed from `peer2`: relaying a transaction makes the node request it from that peer (the parent has no witness, so the request is for its txid), and from `peer1` that request would fail the `peer1` check. Mocktime is bumped before the `peer1` and `peer2` checks, because the node requests an orphan's missing parent only after a delay; without the bump those checks would pass before any request could be sent.

It also fixes a comment: the parent is rejected for its weight (`tx-size`), not its fee.

To see each check fail, change the scenario so that the node does request the hash. The commit message lists the changes I used.

Found while porting these tests to https://github.com/btclib-org/bitcoin-node-tests.

*Made with my usual tools: a computer, the Internet and an LLM. The mistakes, as usual, are all mine.*

ACKs for top commit:
instagibbs:
ACK https://github.com/bitcoin/bitcoin/pull/36406/commits/5f22014aca2d071edfea95e8d3d4ba0bebbc57ca
sedited:
ACK 5f22014aca2d071edfea95e8d3d4ba0bebbc57ca

Tree-SHA512: e589a721d024ca5ca3d241293c4005b34d153f8860f6f16cc14d787cac54fab304279295f63466e8cb6e82ddab0169985bcfff10cad9004e9efe834ae8e7a308

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount