BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 41 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritylint: Require all code in a header to be inside its include guardby Hennadii Stepanov · ca14da90 · Nov 10, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Hennadii Stepanov

lint: Require all code in a header to be inside its include guard

Only empty lines and `//` comments may precede `#ifndef` or follow
`#endif`.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedEnclose all header content in include guardsby Hennadii Stepanov · 00e1f355 · Nov 10, 2026 · 3 filesMessage 45 · ThinInformational 20Details
Commit message · Hennadii Stepanov

Enclose all header content in include guards

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit fixes the placement of include guards in three C++ header files. Include guards prevent the same header from being processed multiple times, which avoids compilation errors and can prevent subtle bugs from duplicate definitions. The changes are purely structural code-quality fixes with no direct security exploit path.

Security candidateMerge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertionsby merge-script · 232cb541 · Nov 10, 2026 · 95 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36074: scripted-diff: [fuzz] Add util/check.h includes for assertions

fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4 scripted-diff: [test] Sort includes (MarcoFalke)
fa3d6b0cf1e37f87b063edc6a159f96b35701884 scripted-diff: [fuzz] Add util/check.h includes for Assert (MarcoFalke)

Pull request description:

In test code, `assert` is used. This is perfectly fine, but sometimes confusion arises, when it is unclear whether `NDEBUG` can disable the assertions, or whether to use `assert` or `Assert`.

Avoid that confusion in test code with a scripted replacement to add the util/check.h include. The changes here will also make it easier to run IWYU.

Scope: This change is only about test code (fuzz), other code can be done later, if there is need to.

ACKs for top commit:
hebasto:
ACK fa6c603af6aeac15a7f49477fcf8dc0353d5e1b4.

Tree-SHA512: ca0d180adc67ddff2e571393dbd35345917137699e44a8b67da653e6b75419593c4b7f78229c4cd46a48973af0cae64887ae5fcb0fdade5d9f1e5415dbe288d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencecryptography-sensitive pathsigning or wallet pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup of Bitcoin Core's fuzz test files. It adds the include for util/check.h (which provides the project's own Assert macro) and removes or reorders some standard C assert includes. The changes only affect test/fuzz code, not the live Bitcoin node software, and the commit message explicitly says the goal is to reduce developer confusion and improve automated include checking. There is no security fix or vulnerability here.

AI review queuedMerge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level commentsby merge-script · 229e7932 · Nov 10, 2026 · 12 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36815: doc: Fix Doxygen attribution of file-level comments

c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5 doc: Attach `subprocess.h` header comment to the file (Hennadii Stepanov)
4cb432772c45e791209d96d893f6f7145096b748 doc: Fix `@file` descriptions that start with the file name (Hennadii Stepanov)
c7ebbbba6c9b81e9d38ec27a79ea57be487d0b59 doc: Fix Doxygen attribution of file-level comments (Hennadii Stepanov)

Pull request description:

Doxygen attaches a comment block that lacks a `@file` command to the next declaration rather than to the file.

For example:
<img width="742" height="265" alt="image" src="https://github.com/user-attachments/assets/eb555197-eb33-41e8-abcb-3a03afa8a5ff" />

This PR fixes that.

Requested in https://github.com/bitcoin/bitcoin/pull/36805#discussion_r4511737767:
> ... they are wrong, ... it may be best to fix them instead of ignoring them?

Required for https://github.com/bitcoin/bitcoin/pull/36805.

ACKs for top commit:
fanquake:
ACK c4a68cc5ceb62ac160b7adc44ebf6388aa803ed5

Tree-SHA512: f2f1402c61c7e114b3ccd502eac90542321892bbe985b95671c3c551b8f227b9c5b07ad57364fee37b61fd7d636545264df7edb4d52acf72b166f30fcf8d568f

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation comments in 12 source-code header files so that the Doxygen documentation generator correctly attributes file-level descriptions. No program logic, compiled code, or security behavior is changed. There is no security risk.

Lower-prioritydoc: Attach `subprocess.h` header comment to the fileby Hennadii Stepanov · c4a68cc5 · Nov 9, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Hennadii Stepanov

doc: Attach `subprocess.h` header comment to the file

Add `@file` and `@brief` so Doxygen documents the file rather than the
`subprocess_close` macro.

Also move the whole comment block inside the include guard. This
simplifies upcoming changes to the include guard linter.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queueddoc: Fix `@file` descriptions that start with the file nameby Hennadii Stepanov · 4cb43277 · Nov 9, 2026 · 7 filesMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Fix `@file` descriptions that start with the file name

Doxygen treats the word after `@file` as the name of the documented
file and drops it from the text. Use a bare `@file` and `@brief`
instead.

Co-Authored-By: fanquake <fanquake@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a pure documentation fix. It changes how Doxygen (a tool that generates documentation from source code comments) interprets file descriptions in seven header files. There is no change to actual program code, behavior, or security.

Lower-prioritydoc: Fix Doxygen attribution of file-level commentsby Hennadii Stepanov · c7ebbbba · Nov 9, 2026 · 4 filesMessage 65 · AdequateTriage 0Details
Commit message · Hennadii Stepanov

doc: Fix Doxygen attribution of file-level comments

Without an explicit @file command, Doxygen attached these comments to
the next declaration.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityMerge bitcoin/bitcoin#36798: test: spend an existing output in `TestBasicMining` double spend caseby merge-script · 44901d8f · Nov 9, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36798: test: spend an existing output in `TestBasicMining` double spend case

b2c7f2545e9a902cb820311e4ff401091a9d620e test: spend an existing output in TestBasicMining double spend case (yuvicc)

Pull request description:

The double spend case in `TestBasicMining` is meant to check that block template creation fails when two mempool transactions spend the same coin. It reuses the transaction from the preceding coinbase case, whose prevout was cleared with `SetNull()`, and only overwrites the prevout hash. The output index therefore stays `COutPoint::NULL_INDEX`, so both transactions spend an output of `txFirst[0]` that does not exist.

Set the output index to 0, so the first transaction is a valid spend and only the second one makes template creation fail.

Found while working on #36692 and https://github.com/yuvicc/bitcoin/pull/19.

ACKs for top commit:
jpk68:
ACK b2c7f2545e9a902cb820311e4ff401091a9d620e
alexanderwiederin:
ACK b2c7f2545e9a902cb820311e4ff401091a9d620e
maflcko:
lgtm ACK b2c7f2545e9a902cb820311e4ff401091a9d620e

Tree-SHA512: 3cf6f42f57a076cae340fb418296e815458251366a1b914015b779cafb063bb78db86efddafa704cc26e58efacdff37f424301214de662569500256da5918991

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh testsby merge-script · 4ef7904c · Nov 8, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36788: test, bench: construct inputs/outputs declaratively in txpackage, duplicate_inputs and p2sh tests

a4a2647834ad0cc4576b2eb38bddf02c42081173 test: construct script_p2sh_tests inputs/outputs declaratively (yuvicc)
7fc7d26e7507ad753cbcab2698404debcf63ca71 bench: construct duplicate_inputs inputs/outputs declaratively (yuvicc)
5336eaa7fa70c55fe4a137df721e691e61b80131 test: construct txpackage_tests inputs/outputs declaratively (yuvicc)

Pull request description:

Part of #36692. Follow-up to #36750

Replaces field-by-field construction of inputs and outputs with `COutPoint`, `CTxIn` and `CTxOut` ctor calls in `txpackage_tests`, `bench/duplicate_inputs` and `script_p2sh_tests`.

`CMutableTransaction` is kept as the builder while a `CTransaction` constructor is discussed in #36696. Witnesses are still assigned after `vin`, since `CTxIn` has no witness argument yet.

Test-only; the constructed transactions are unchanged.

- `script_p2sh_tests`: two outputs created by `vout.resize(1)` never had a value, so their null `nValue` (`-1`) is now explicit.
- Intentional mutations are left as they are: the `scriptSig` swap in `sign`, the dummy signing in `ValidateInputsStandardness`, and the witness-only copies in `txpackage_tests` (`mtx_child2`, `mtx_parent2_v2`).

ACKs for top commit:
alexanderwiederin:
ACK a4a2647834a
purpleKarrot:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
maflcko:
review ACK a4a2647834ad0cc4576b2eb38bddf02c42081173 👒
janb84:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173
jpk68:
ACK a4a2647834ad0cc4576b2eb38bddf02c42081173

Tree-SHA512: ca452697a5bcccfbed2778785906f75c22e95fea04a1e79fb2d6fdae80ebe4badf5d8cb49a8b6add6e80a480b4826436caaee43ec534d4e6aae22f6584935b86

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a cleanup of Bitcoin Core's internal test and benchmark code only. It changes how dummy transactions are built in three test files, making the code more readable without changing what the transactions actually are. There is no change to the live Bitcoin network code, no security fix, and no vulnerability introduced.

Lower-priorityMerge bitcoin/bitcoin#36252: ci, iwyu: skip subtrees in compilation databaseby Hennadii Stepanov · 49c3c7fe · Nov 7, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36252: ci, iwyu: skip subtrees in compilation database

01e3eca2d8ee755eed4488a44093759f0eddcb34 ci, iwyu: skip subtrees in compilation database (Ryan Ofsky)

Pull request description:

**Problem:** The IWYU CI job analyzes `src/ipc/libmultiprocess/` even though its results are thrown away. Every run prints IWYU suggestions for 14 libmultiprocess files in the non-enforced pass, applies them, and then reverts them with the `git restore` from #36112. The suggestions also disagree with what libmultiprocess's own IWYU CI reports (it runs with `-Xiwyu --error` and passes), because the two jobs use different IWYU versions and mapping files. libmultiprocess is the only subtree in this situation; leveldb, crc32c, minisketch and secp256k1 are already excluded from `compile_commands.json` with `EXPORT_COMPILE_COMMANDS OFF`. #35361 reported this output and said IWYU shouldn't be running on subtrees.

**Solution:** Filter `SHARED_EXCLUDED_SUBTREES` (from `test/lint/lint_ignore_dirs.py`) out of `compile_commands.json` at the start of the IWYU section of `ci/test/03_test_script.sh`, so subtree sources are neither analyzed nor edited. This is done in the CI script rather than in cmake so that only IWYU is affected: clang-tidy keeps running on libmultiprocess, and no list of subtree targets has to be maintained in `cmake/libmultiprocess.cmake` (that approach broke `-DBUILD_TESTS=OFF` in #35418 and was reverted in #35523). The change is three lines in `ci/test/03_test_script.sh`; the rest of the diff is comments.

**Testing note:** You can confirm this works by checking the IWYU CI logs and confirming that output like `/home/runner/work/_temp/src/ipc/libmultiprocess/src/mp/gen.cpp should add these lines:` no longer appears.

ACKs for top commit:
David-Uka:
Code-review ACK 01e3eca2d8ee755eed4488a44093759f0eddcb34
hebasto:
ACK 01e3eca2d8ee755eed4488a44093759f0eddcb34.

Tree-SHA512: dcec5bce3e26aad0bbc52d6f91aa1cadb3fc92e241cc6f31e938b9facd66c1f8d1c9f3cc1b6360fc1fa1e4beba180c1244a229e997bee764630e80d49b97fd50

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarationsby Hennadii Stepanov · c6dcda33 · Nov 7, 2026 · 7 filesMessage 81 · StrongInformational 16Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36744: refactor: fix mismatched and undefined declarations

5f972485ffd139852d5d64a38079ab500f8a4c7c http: use MockableSteadyClock::time_point in ShouldDisconnect declaration (fanquake)
bad11ff68ec276c8c1415331e4b0d67ec84766a4 qt: remove undefined BanTableModel::{start,stop}AutoRefresh (fanquake)
0ae65892445d00e9cbaebf220cc70f63140a52fb rpc: remove undefined RPCResult::ToStringObj and ToDescriptionString (fanquake)
3fa42941d16fc76e346152d690cdf96fa031d60d common: make FeeModeInfo static, remove mismatched declaration (fanquake)
410843a684d8258c57aa55d7bc2b4e53a67de9ca rpc: make AddInputs static, remove mismatched declaration (fanquake)

Pull request description:

Remove or fix function declarations that don't match any definition.

Split out of #36743. Ideally we can have the compiler enforce/flag this in future.

ACKs for top commit:
maflcko:
review ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c 🏈
sedited:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c
hebasto:
ACK 5f972485ffd139852d5d64a38079ab500f8a4c7c, I have reviewed the code and it looks OK.

Tree-SHA512: aaab43a8c79834b8a55a3c40e3f6a1f07a7454dcac9e00c3a09e3d95ab26dfd93290a3f62e2f84e79ccb917b0b1bedd2f9fd04bc9c736f76430fee33174f4175

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This is a routine code cleanup that removes or fixes function declarations which did not match any actual function definition. It does not change program behavior, fix a bug, or close a security hole. Two helper functions were made 'static' (only usable inside their own source file), two unused declarations were removed from headers, and one declaration was updated to use the exact same type as its definition. There is no security impact.

Lower-priorityMerge bitcoin/bitcoin#36772: test: Remove `BOOST_FAIL` and add info in descriptor_testsby merge-script · 5bf3bc5e · Nov 6, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36772: test: Remove `BOOST_FAIL` and add info in descriptor_tests

f5a887c199613be9ddc8a13fbb7934af614fa579 test: Remove `BOOST_FAIL` and add info in descriptor_tests (rustaceanrob)

Pull request description:

The `BOOST_FAIL` here is used to exit the test based on a condition, but we can use `REQUIRE` directly. The context string is only printed on failure to my knowledge and this is not called on a child thread so there is no behavior change.

The `descriptor_tests` uses `BOOST_TEST_INFO` to add the descriptor if the next condition fails, but there are some other places that also print the public or private descriptor. Seems useful throughout this whole funciton body to attach the private and public descriptor as context.

Found in #35713 as low usage macros

ref:
- https://www.boost.org/doc/libs/latest/libs/test/doc/html/boost_test/utf_reference/testout_reference/test_output_macro_info.html
- https://www.boost.org/doc/libs/latest/libs/test/doc/html/boost_test/utf_reference/testout_reference/test_output_macro_context_sticky.html
- https://www.boost.org/doc/libs/latest/libs/test/doc/html/boost_test/utf_reference/testing_tool_ref/assertion_boost_fail.html

ACKs for top commit:
l0rinc:
ACK f5a887c199613be9ddc8a13fbb7934af614fa579
maflcko:
review ACK f5a887c199613be9ddc8a13fbb7934af614fa579 🎲
sedited:
ACK f5a887c1996

Tree-SHA512: 176ffa1d4cc337bb9082091ac6bca9779c7ad2ac6ec6196227d61bc89d813579dfe76dcba336c5ec0fec6d0e493178230997353ea338940b53db4b51838acdce

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36613: test: add getblockfilter test coverage for header-only blocksby merge-script · 411c971e · Nov 6, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36613: test: add getblockfilter test coverage for header-only blocks

64cf455b481d36182957bdcfcae7c411a7879897 test: add getblockfilter test coverage for header-only blocks (Aaron Leeb)

Pull request description:

Add functional coverage for the `getblockfilter` error raised when a node has a known block header, but the block has never been connected.

This gap in test coverage was identified by a coverage report generated while exploring BIP 157/158. The branch in `src/rpc/blockchain.cpp` was never executed in the measured tests:
https://github.com/bitcoin/bitcoin/blob/64cf455b481d36182957bdcfcae7c411a7879897/src/rpc/blockchain.cpp#L3054-L3056

The existing `getblockfilter` functional test checks unknown block hashes and filter retrieval for active and stale blocks, but doesn’t check a known header whose block has never been connected.

This change submits only the block header of a newly mined block to a node using `submitheader` and verifies that in this expected state, `getblockfilter` returns error `-5` with `"Filter not found. Block was not connected to active chain."` This adds coverage for the RPC’s distinction between an unknown block and a known block for which no filter has been constructed.

`rpc_getblockfilter.py` passes, and changing the error message makes the new assertion fail as expected.

ACKs for top commit:
Zippo76:
tACK 64cf455b48
sedited:
ACK 64cf455b481d36182957bdcfcae7c411a7879897

Tree-SHA512: b7af1c5d528e831f86c20c5fc3516ccb70a324714d31f4cb175c6cbb22a3ae0d3069c6fa9a039f1e69f17084edc1324c5276b2877b26aaf5ac1e277c3bb03cfe

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36623: build: enable `-Wunreachable-code-aggressive`by merge-script · 050982c5 · Nov 6, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36623: build: enable `-Wunreachable-code-aggressive`

1f69c5cfdd9a21e03bedcb4edd14c4fb13954b7c build: swap -Wunreachable-code for aggressive variant (fanquake)
27da2de66fbf2eb88e5a7d5ba40ac597ccfd6ee9 refactor: fix -Wunreachable-code-aggressive warnings (fanquake)

Pull request description:

Swap `-Wunreachable-code` for `-Wunreachable-code-aggressive`, which also enables `-Wunreachable-code-return` and `-Wunreachable-code-break`.

ACKs for top commit:
maflcko:
review ACK 1f69c5cfdd9a21e03bedcb4edd14c4fb13954b7c 🐟
willcl-ark:
ACK 1f69c5cfdd9a21e03bedcb4edd14c4fb13954b7c
sedited:
ACK 1f69c5cfdd9a21e03bedcb4edd14c4fb13954b7c
hodlinator:
crACK 1f69c5cfdd9a21e03bedcb4edd14c4fb13954b7c

Tree-SHA512: 88070969c48ccce15359d8b0946b2332cb0abe75616681972b9647258708ce94c26abfa25bc8d0b8ed0c16b8e2071bafc593a61bf606f05e38795932dcafe0b9

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startupby merge-script · cabee965 · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36378: test: Add SKIP_WRITE edge case to wallet_startup

774dd9b034b3930dd1b5eba350558acc1d9da03c test: Add SKIP_WRITE edge case to wallet_startup (Aaron Leeb)

Pull request description:

Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.

This improves test coverage for the dynamic settings logic introduced in [#36176](https://github.com/bitcoin/bitcoin/pull/36176) by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.

This specific edge case was suggested by contributor jeanpablojp [here](https://github.com/bitcoin/bitcoin/pull/36176#discussion_r3944837660).

ACKs for top commit:
mercie-ux:
ACK 774dd9b
sedited:
ACK 774dd9b034b3930dd1b5eba350558acc1d9da03c

Tree-SHA512: 01cde53303e94dbecc9c0f69bb2c816f7faac08f4218dc81e8f37ed1b276104a7e12d212714751d60b998a3a6ca20837ef64e296932b2b7c7f23b4ab534dfd00

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new test case to Bitcoin Core's functional test suite. It checks that reloading a wallet already marked to start automatically does not trigger an unnecessary settings write or warning when settings are disabled. There is no change to production code, no bug fix, and no security-relevant behavior change.

Lower-priorityMerge bitcoin/bitcoin#36713: test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg`by merge-script · b8b38ef7 · Nov 6, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36713: test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg`

e172eb69df92b5ef9cd5f4234de28430c1f7b7b8 test: remove unused DynSock::Pipe::GetNetMsg and PushNetMsg (fanquake)

Pull request description:

With these removed, `WaitForDataOrEof` and the condition variable are also removed.

This was merged as part of #30205, in advance of #26812, which never landed.

ACKs for top commit:
jpk68:
ACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8
willcl-ark:
utACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8
sedited:
Reproduced ACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8

Tree-SHA512: 6530c82a43877c2106a49051854e3bbf072dc57c28b7dd8a16ef171683db23f9b81016b6d4ac476ff03bc1b557d74ba14451459ae1d3ec4159aaf1d0b8870eff

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`by merge-script · 654d74cc · Nov 6, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36591: test: deduplicate PSBT unknown-field coverage in `rpc_psbt.py`

ef4310097bd651497a98a9d1bb59560a7055ae01 test: combine redundant PSBT unknown field merge cases into `test_combinepsbt_preserves_unknown_fields` (nebula-21)
40eba5eb20ba0041a6328ba3482fcc26ddbe0185 test: extract unknown fields passthrough to its own method (nebula-21)

Pull request description:

I've tested some mutations related to test coverage for PSBT unknown field merging and discovered an inconsistency.
<details>

If line 71 of `psbt.cpp` "`unknown.insert(psbt.unknown.begin(), psbt.unknown.end());`" (inside `bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)` function) is removed then, the expected test fails: *"Test that combining PSBTs preserves unknown fields with the same and with distinct values per map."*

If line 434 of `psbt.cpp` "`unknown.insert(input.unknown.begin(), input.unknown.end());`" (inside `bool PSBTInput::Merge(const PSBTInput& input)` function), is removed, a different unexpected test fails: "*Test that unknown values are just passed through*".

If line 537 of `psbt.cpp` "`unknown.insert(output.unknown.begin(), output.unknown.end());`" (inside `bool PSBTOutput::Merge(const PSBTOutput& output)` function), is removed, the expected test fails: "*Test that combining PSBTs preserves unknown fields with the same and with distinct values per map.*".
</details>

This PR solves this inconsistency.
The old code did 3 different things:
1. Test the pass-through of unknown values for `walletprocesspsbt`.
2. Combine two v0 PSBTs with different unknown input keys and check that both keys survive.
3. Combine implicit v0 PSBT with explicit v0 and check that both keys survive.

Case 2 is already fully covered by the existing `test_combinepsbt_preseves_unknown_fields` so keeping it is redundant and misleading.

Commit 40eba5eb20ba0041a6328ba3482fcc26ddbe0185 moves the old code into a new method called `test_unknown_fields_passthrough` and commit ef4310097bd651497a98a9d1bb59560a7055ae01 removes the redundant code of Case 2 and moves Case 3 inside `test_combinepsbt_preserves_unknown_fields`.

ACKs for top commit:
Naomi-Gift:
tACK ef4310097bd651497a98a9d1bb59560a7055ae01
polespinasa:
ACK ef4310097bd651497a98a9d1bb59560a7055ae01

Tree-SHA512: 14476cffc28a8548fe58e42d8862d4fdb300c36d81679551fa8f9af83b49da3c65c2fe3283e9a4ec3e5c45abe3f34b8270dc2208a4f0534ff1f6062948bfcae9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only reorganizes existing test code in Bitcoin Core's functional test suite. It moves and deduplicates tests that check how unknown PSBT fields are preserved when PSBTs are combined or processed by the wallet. No production code was changed, and no security bug was fixed or introduced.

Lower-priorityMerge bitcoin/bitcoin#36779: Update leveldb subtree to latest masterby Hennadii Stepanov · b6ccaaef · Nov 6, 2026 · 12 filesMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36779: Update leveldb subtree to latest master

9449723960887c6091a12a7a32c7509df5e23d81 Squashed 'src/leveldb/' changes from 24a446f834..e267773191 (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/leveldb-subtree/pull/67
* https://github.com/bitcoin-core/leveldb-subtree/pull/69

67 could be used in #36167. There's a followup to 67 in https://github.com/bitcoin-core/leveldb-subtree/pull/68, which could be used in #36743.

ACKs for top commit:
sedited:
ACK 7580a91fe0695c98afce8919ef3fe510969255ef
hebasto:
ACK 7580a91fe0695c98afce8919ef3fe510969255ef.

Tree-SHA512: 3d626180789566c7288c084c396dd4610d0cadd1b0a427a725d463e0792bb90ed80bde0f8796793e461003590190cc77933649fd9fd8ab1d17f7060c2c2ae9ca

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36475: bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case)by merge-script · 589fca48 · Nov 6, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36475: bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case)

56c0f168d1a81b19e4cd71ef81e7ce2d9c1624e3 bench: add worst-case P2PKH benchmark for BIP-352 pubkey extraction (Sebastian Falbesoner)
d71bc7127f0ce06da96476456160799e817f0a14 bench: add benchmarks for BIP-352 pubkey extraction (standard inputs) (Sebastian Falbesoner)

Pull request description:

As there are ongoing changes to the Silent Payments public key extraction function `GetPubKeyFromInput` (see recently merged #36338), it seems reasonable to add benchmarks for it. The first commit covers the standard shape of each eligible input type (P2PKH, P2SH-P2WPKH, P2WPKH and P2TR script-path spend; see [BIP-352](https://github.com/bitcoin/bips/blob/master/bip-0352.mediawiki#user-content-Inputs_For_Shared_Secret_Derivation)). The second adds a worst-case P2PKH input with a maximally malleated scriptSig, where every push has to be hashed during the scan.

Results on my arm64 machine (as per `$ ./build/bin/bench_bitcoin -filter='BIP352_.*'`):

| ns/input | input/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 3,034.12 | 329,584.35 | 0.2% | 0.01 | `BIP352_GetPubKey_P2PKH`
| 69,868.20 | 14,312.66 | 0.1% | 0.01 | `BIP352_GetPubKey_P2PKH_WorstCase`
| 2,841.35 | 351,945.44 | 0.1% | 0.01 | `BIP352_GetPubKey_P2SH_P2WPKH`
| 2,768.00 | 361,272.01 | 0.1% | 0.01 | `BIP352_GetPubKey_P2TR`
| 2,757.57 | 362,637.66 | 0.0% | 0.01 | `BIP352_GetPubKey_P2WPKH`

ACKs for top commit:
Yudis-bit:
re-tACK 56c0f168d1
fametrano:
tACK 56c0f168d1
Eunovo:
ACK https://github.com/bitcoin/bitcoin/pull/36475/commits/56c0f168d1a81b19e4cd71ef81e7ce2d9c1624e3

Tree-SHA512: 86ab61570fe2cec16afbab007d4a4d443ca18ff963797971a39ce75993a837562245a21c3daeb9ced9d88ca9a2eff037e8bc4353e159ae0bf4b5610007ac1dab

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36694: test: construct `mempool_tests` inputs/outputs declarativelyby merge-script · e71cebc0 · Nov 6, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36694: test: construct `mempool_tests` inputs/outputs declaratively

b7abd88f0f2838b26a09a30e4aa23f18806b962f test: construct mempool_tests inputs/outputs declaratively (Alexander Wiederin)

Pull request description:

Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in `mempool_tests` with `COutPoint`, `CTxIn` and `CTxOut` constructor calls.

It keeps `CMutableTransaction` as the builder, since a `CTransaction` constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the `vin`/`vout` lists here can be passed to it directly. Either way, the declarative form makes the constructed transactions easier to read.

This change is test-only and does not change the constructed transactions.

The `mempool_eviction` bench and `rbf_tests` changes from the earlier version of this PR have been dropped, as they conflict with #36521. They can follow once that is resolved.

ACKs for top commit:
sedited:
ACK b7abd88f0f2838b26a09a30e4aa23f18806b962f
yuvicc:
lgtm ACK b7abd88f0f2838b26a09a30e4aa23f18806b962f
janb84:
tACK b7abd88f0f2838b26a09a30e4aa23f18806b962f

Tree-SHA512: 5d1ebdad6d5029a310434415cb0bcbe0bdaddfcee0fd3381eb03b9189a851187e302e794e74b81b7bb193ab14425a40dd531f0eea14baf774171fc168748eec5

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36783: Update minisketch subtree to latest masterby merge-script · f12cc4ae · Nov 6, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36783: Update minisketch subtree to latest master

be064af99df3870d3d01d9969da7268cc3881375 Squashed 'src/minisketch/' changes from a12f5de1c9..d44dca4e3f (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/minisketch/pull/106

Used in #36623.

ACKs for top commit:
willcl-ark:
utACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3
sedited:
ACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3

Tree-SHA512: 8464382c5bab000ce347136b67e0966aa97f388af0d864ee0c38306aab9ba7c7a91fb96d6e4b14dee3b58a99501c62ec52d596a392857afac07deb9ada32fa84

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 19/100

This is a routine update of an internal math library (minisketch) used by Bitcoin Core. The visible code change removes an unreachable 'break' statement that followed a 'return' inside a switch case. That kind of cleanup is cosmetic and does not change program behavior. There is no indication in the commit message or diff that this fixes a security vulnerability.

Lower-priorityMerge bitcoin/bitcoin#36752: net_processing: always disconnect for SENDTXRCNCL after VERACKby merge-script · d531a37c · Nov 6, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36752: net_processing: always disconnect for SENDTXRCNCL after VERACK

87310779af88aec0233c704350df875284d40f34 net_processing: always disconnect for SENDTXRCNCL after VERACK (Vasil Dimov)

Pull request description:

As mandated by BIP 330:
> If "sendtxrcncl" was sent after "verack", the sender should be disconnected.

So, always disconnect such a peer, regardless of the value of `-txreconciliation`. Previously the code would ignore and not disconnect such a peer if `-txreconciliation=0`.

ACKs for top commit:
maflcko:
review ACK 87310779af88aec0233c704350df875284d40f34 👈
w0xlt:
ACK 87310779af88aec0233c704350df875284d40f34

Tree-SHA512: 8593fd09f19cb66ef7dc38f0fa4ac39f8ad67f15854f87177e02b6f62d77e85808a7abe20ff77cc38d99faef7119798ccefa2e86cfa3542086bc8719d332bd29

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36765: fuzz: push messages to one of m_nodes in connman targetby merge-script · 4e3b0a44 · Nov 6, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36765: fuzz: push messages to one of m_nodes in connman target

ad51e87ecfd8f4b27e703b5c6116e6d75dcb9787 fuzz: push a message to an actually connected node in connman target (Antoine Poinsot)

Pull request description:

The connman fuzz target never exercised `m_nodes` peers with queued messages, as their message queue is always empty. The most they ever had to send was handshake bytes in the case of v2 peers, so the socket handler only ever waited for SendEvent, and sent data, during a v2 handshake.

Fix this by pushing messages to one of the `m_nodes` peers instead of `random_node`, which is never added to connman.

ACKs for top commit:
marcofleon:
ACK ad51e87ecfd8f4b27e703b5c6116e6d75dcb9787

Tree-SHA512: 4239b2eb8a12c0f58fce76fb9477abd37082af6ab2b1331ee627e166fb4ab3f0271f3e2f546bb281603900f67558bf5e1e3b8cc21063d256f262007ce2d2ff0b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interfaceby merge-script · 521bbaf4 · Nov 6, 2026 · 6 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36731: test: use monotonic clock for durations in test framework and http_interface

a7d3a4297321274ced64294e0bbd3252167e8879 test: use monotonic clock in interface_http (ViniciusCestarii)
eccca10e6460507e553e61a1cdaf664fa7738375 test: use monotonic clock for durations in test framework (ViniciusCestarii)

Pull request description:

Replace `time.time()` used to measure durations by `time.monotonic()` in test framework and http_interface.

This helps preventing future clock jump flakiness (same class of bug as #36529) on tests and fix:

```
faketime --exclude-monotonic -f "+0 x0.5" build/test/functional/feature_torcontrol.py
faketime --exclude-monotonic -f "+0 x0.1" build/test/functional/interface_http.py
```

ACKs for top commit:
nervana21:
tACK a7d3a4297321274ced64294e0bbd3252167e8879
maflcko:
review ACK a7d3a4297321274ced64294e0bbd3252167e8879 🕐
sedited:
ACK a7d3a4297321274ced64294e0bbd3252167e8879

Tree-SHA512: d1c6b98ceab4c4bf5b97a44b4a4577b0868292d2aaa359aa67a807be469700737f0d330da83e8b6f85403635db6809c41dcd4041a84f3ab6dad9ef16e50a44d1

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit only changes the test code that runs Bitcoin Core's automated tests. It swaps the clock used to measure how long things take from the regular system clock (which can jump forward or backward, for example when the system time is adjusted) to a monotonic clock (which only ever moves forward steadily). This makes the tests more reliable and less likely to fail randomly due to clock jumps, but it does not change the actual Bitcoin Core software that users run, nor does it fix any security vulnerability in the live network or node software.

AI review queuedMerge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19by Hennadii Stepanov · f22abab4 · Nov 6, 2026 · 10 filesMessage 81 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19

fa8c3c014d1eb17c69a7a286b121134a1c310e54 refactor: Remove unused include for clang-cl on Windows (MarcoFalke)
faffaeb2b66ea3573b8a37bda0154822a216c1d7 build: Drop unused clang-17 -Wno-c++23-extensions workaround (MarcoFalke)
fa31e2595569ad2c6f0f61401917ca6b42a3b45b refactor: Drop unused libc++-16 workarounds (MarcoFalke)
fa6299f87a27853a170be49b67e6e319d244928e clang-format: Use Standard: Latest (MarcoFalke)
fa909de36f3b44d3fd531a3f2f68662b0a37c718 build: Bump clang minimum supported version to 19 (MarcoFalke)

Pull request description:

Most supported operating systems ship with clang-19 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.

(For this bump, only C++20 CTAD will become available.)

This patch will only be released in version 33.x, next year (2027).

For reference:

* https://packages.debian.org/bookworm/clang-22
* https://packages.ubuntu.com/noble/clang-20
* CentOS-like 8/9/10 ship clang-21 via Stream
* Free/Open/Net*BSD ship clang-19
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang22); leap:latest with clang-19
* macOS 14: depends/release cross-builds are unaffected and use clang-19
* macOS 14: Native builds use llvm-19-ish via XCode CLT 26.3 since https://github.com/bitcoin/bitcoin/pull/36287
* Windows: VS ships Clang 22

On operating systems where the minimum Clang version is not shipped by default, the user would have to use GCC, or install Clang in a different way. For example:

* https://packages.debian.org/bookworm/g++ (g++-12)
* https://packages.ubuntu.com/jammy/g++-12
* https://apt.llvm.org/, brew, nix, guix, or compile clang from source, ...

ACKs for top commit:
fanquake:
utACK fa8c3c014d1eb17c69a7a286b121134a1c310e54
hebasto:
re-ACK fa8c3c014d1eb17c69a7a286b121134a1c310e54, rebased and removed `-Wno-c++23-extensions` since my last [review](https://github.com/bitcoin/bitcoin/pull/36036#pullrequestreview-5777417373).

Tree-SHA512: 519f018f6b7f7f1a50e72f0f0ba53f60209ebd8a613a973cf0b91638e1bc732c1084b3a6c63cc30c4f0b8b5991d76adde24752e20cd4aead942450a1a8879c68

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit raises the minimum supported version of the Clang compiler used to build Bitcoin Core from version 17 to version 19. It also removes some old workarounds that were only needed for older compiler versions. There is no change to how Bitcoin Core processes transactions, network messages, wallets, or consensus rules. It is a routine build-system maintenance change.