Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…
Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…
New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …
Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…
Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…
This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …
Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…
No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…
Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …
New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…
Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…
No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …
Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …
This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…
This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…
No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…
OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…
No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…
Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…
No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…
Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 17/100
This commit adds a patch to Bitcoin Core's build system that fixes a missing C++ header include in the ZeroMQ library. The missing include can cause compilation to fail on some systems because the compiler cannot find 'std::nothrow'. It is a build-compatibility fix, not a security vulnerability fix, and it does not change how Bitcoin Core handles transactions, wallets, or network data.
Lower-priorityci: Put space and non-ASCII char in `BASE_BUILD_DIR`by Hennadii Stepanov · f3f30215 · Jul 21, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Hennadii Stepanov
ci: Put space and non-ASCII char in `BASE_BUILD_DIR`
The GHA workflows override `BASE_BUILD_DIR`, so the build tree no longer lives under `BASE_SCRATCH_DIR` and its word-splitting and UTF-8 coverage is bypassed on CI. Restore it by putting a space and a non-ASCII symbol in the externally defined path as well.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This is a harmless CI (continuous integration) configuration change for Bitcoin Core. It adds a space and a non-ASCII character to a build directory path used only in automated testing, so the test environment exercises how the code handles unusual directory names. There is no security issue here.
build: Quote host paths in NSIS installer template
The `File` instructions embed the build and source directories unquoted, so `makensis` fails for the `deploy` target when either path contains spaces.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 16/100
This commit fixes a Windows installer build script so that directory paths containing spaces are properly quoted. It is a build-system reliability fix, not a security vulnerability. There is no indication it can be exploited to attack users or the software.
fuzz: [refactor] Use 100'000 digit separator in __AFL_LOOP
This makes it easier to glance the exact value.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100
This commit is a purely cosmetic code cleanup. It changes the number 100000 to 100'000 in a fuzz-testing helper, using a C++ digit separator to make the value easier to read. It does not alter program behavior, logic, or security.
Security candidatep2p: Assume v2transport for addresses from seedsby Martin Zumsande · cf0f2aea · Jul 21, 2026 · 2 filesMessage 68 · AdequateInformational 19Details
Commit message · Martin Zumsande
p2p: Assume v2transport for addresses from seeds
By now, the vast majority of nodes in the network supports BIP324. Even if the optimistic guess would turn out to be wrong for a given node, we would just reconnect with v1. This is better than making v1 connections with peers when both nodes support v2.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
secret or key materialparser or protocol path
AI analysis · Informational 19/100
This change makes Bitcoin Core assume that hard-coded and DNS seed nodes support the newer BIP324 encrypted transport (v2) when first connecting. If the guess is wrong, the software falls back to the older v1 protocol automatically. It is a network-hardening/performance tweak, not a fix for an exploitable vulnerability.
fuzz: Avoid dangling prevoutfetch threads after AFL fork
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 21/100
This commit fixes a fuzz-testing-only issue. When Bitcoin Core runs under AFL (a fuzzing tool), it forks the process after setup. Previously, worker threads created during initialization could become 'dangling' after the fork, causing crashes or unreliable fuzz results. The fix disables those extra threads during fuzzing, making tests more stable and deterministic. This does not affect normal Bitcoin node operation or end-user wallets.
guix, refactor: Use `target` variable instead of hardcoded value
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100
This is a tiny build-script cleanup. It replaces a hardcoded Windows build target string with a variable that already holds the same value. There is no security issue visible in the change itself.
AI review queuedqt, test: Enable tests on macOS with `minimal` QPA pluginby Hennadii Stepanov · fd59d68c · Jul 20, 2026 · 3 filesMessage 75 · AdequateInformational 16Details
Commit message · Hennadii Stepanov
qt, test: Enable tests on macOS with `minimal` QPA plugin
The crash source, implicit `NSApplication` instantiation with a non-Cocoa QPA plugin, was fixed in the previous commit.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 16/100
This commit removes workarounds that skipped three Bitcoin Core Qt test suites on macOS when using the 'minimal' Qt platform plugin. The previous commit fixed the underlying crash cause, so these tests can now run. It is a test-infrastructure cleanup, not a security patch for end-user software.
`[NSApplication sharedApplication]` creates the shared application object if it does not yet exist. When running with the `minimal` or `offscreen` QPA plugins, which is common for testing purposes, the Cocoa platform plugin never creates it, so these call sites were instantiating `NSApplication` as a side effect.
Use the `NSApp` global instead and return early when it is `nil`.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Low 26/100
This commit fixes a macOS-specific behavior in Bitcoin Core's Qt interface. Previously, two pieces of code called [NSApplication sharedApplication], which has the side effect of creating the macOS application object if it didn't already exist. When running Bitcoin Core's GUI in headless/minimal test modes on macOS, this unintended creation could cause subtle state problems. The fix uses the NSApp global instead and skips the calls if no application object exists. It is a defensive bug fix rather than a clear-cut security vulnerability.
Lower-priorityqt: Fix `-Wsfinae-incomplete` warnings when building with GCC 16.xby Hennadii Stepanov · 51d36dfd · Jul 20, 2026 · 5 filesMessage 95 · StrongInformational 15Details
Commit message · Hennadii Stepanov
qt: Fix `-Wsfinae-incomplete` warnings when building with GCC 16.x
According to the CMake documentation for `AUTOMOC`, all `moc` output files that are not included in a source file are aggregated into the CMake-generated `<AUTOGEN_BUILD_DIR>/mocs_compilation.cpp`, which is added to the target's sources.
Within that single translation unit, `moc`-generated code checks the completeness of a signal or slot parameter type while it is still only forward-declared, and the type is completed later, when a subsequently included `moc_*.cpp` file pulls in the header that defines it. GCC 16.x diagnoses this pattern with the `-Wsfinae-incomplete` warning, which is enabled by default.
Including the `moc` output files at the end of the corresponding source files excludes them from `mocs_compilation.cpp`, so each one is compiled in a translation unit where the relevant types are complete.
Additionally: 1. Some of the `BitcoinGUI` class's private members are gated with `#ifdef ENABLE_WALLET` to prevent `-Wunused-private-field` warnings when building with `-DENABLE_WALLET=OFF`. 2. `test/lint/lint-includes.py` is adjusted to allow new `#include` statements.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a build-system cleanup for the Bitcoin Core graphical wallet. It silences new compiler warnings that appear with GCC 16.x by changing how Qt's meta-object compiler output is included, and it hides some wallet-only user-interface fields when the wallet is disabled at compile time. There is no security bug being fixed and no behavior change for end users.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100
This commit reorganizes how Bitcoin Core's official macOS and Windows release binaries are built using the Guix reproducible-build system. It splits one big build script into smaller, platform-specific scripts for non-GUI and GUI parts. There is no indication this fixes a security vulnerability; it is a build-system refactoring.
guix: split builds into Linux(gui) and macOS/Windows
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit reorganizes how Bitcoin Core's official release builds are produced using the Guix build system. It splits Linux builds into two separate steps—one for command-line/daemon programs and one for the graphical wallet interface—and moves some build tools into a separate manifest file. There is no indication this fixes a security vulnerability or introduces a security-relevant bug; it is a build-system refactoring.
Kernel can create a `ChainstateManager` without a mempool. Deleting an AssumeUTXO chainstate then dereferences the previous chainstate's null mempool pointer.
Allow the previous chainstate to have no mempool, matching `AddChainstate()`. Cover the reindex/wipe lifecycle.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 32/100
This commit fixes a crash bug in Bitcoin Core's chainstate manager. When deleting a temporary chainstate used for AssumeUTXO loading, the code assumed every chainstate had a memory pool (mempool) attached. In the 'kernel' library mode, a ChainstateManager can be created without a mempool, so deleting a chainstate dereferenced a null pointer and crashed. The fix simply checks whether the mempool exists before checking its size, and adds a test for this lifecycle.
The new script is parameterized by paths to executables. It can be used to generate the installer from the install tree rather than the build tree. This capability will be used by the Guix scripts in subsequent commits.
This commit is a build-system refactor for creating the Windows installer. It moves the NSIS installer generation logic into a separate, reusable CMake script and changes the template to use configurable directories instead of hardcoded build-tree paths. There is no indication this changes what gets installed, how user data is handled, or any runtime behavior of Bitcoin Core itself.
Use `SaltedCoinsCacheHasher` for the temporary set of earlier txids in `CoinsViewOverlay`, and in existing overlay tests to exercise the new `Txid` overload. Every entry is a computed transaction hash, and the set is limited to a few thousand elements per block, satisfying the SipHash-1-3-UJ jumbo-input requirements.
Co-authored-by: Andrew Toth <andrewstoth@gmail.com>
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 18/100
This is a small internal cleanup in Bitcoin Core's coin-cache code. It makes a temporary set of transaction IDs use the same hash function as the main coins cache, instead of a separate one. The change is described by the authors as a performance/consistency improvement, not a security fix. There is no evidence in the commit that it repairs an exploitable vulnerability.
Lower-prioritycoins: use SipHash-1-3-UJ for `CCoinsMap`by Lőrinc · 2beab948 · Jul 18, 2026 · 5 filesMessage 68 · AdequateLow 26Details
Commit message · Lőrinc
coins: use SipHash-1-3-UJ for `CCoinsMap`
Use the fixed-width `SipHasher13UJ::Hash` path for `CCoinsMap`, while keeping other `SaltedOutpointHasher` users on SipHash-2-4. The salted outputs are process-local and must not be persisted, serialized, or compared across processes.
Retained cache entries identify real transaction outputs and therefore contain computed txids. Missing-input validation may probe arbitrary claimed prevouts, but `FetchCoin()` erases each temporary entry immediately when the backend lookup fails, so non-hash keys cannot accumulate. The assumeutxo loader assumes snapshot txids are valid while loading and verifies the complete snapshot content hash before activation.
Co-authored-by: Pieter Wuille <pieter@wuille.net>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 26/100
This commit changes the hash function used inside Bitcoin Core's in-memory coin cache (the UTXO cache) from SipHash-2-4 to a faster SipHash-1-3 variant. The change is framed as a performance optimization. The commit message and code comments explicitly argue that the weaker hash is still safe here because the keys are real transaction IDs, attackers cannot inject arbitrary long-lived keys into this cache, and the hash values are never saved to disk or shared between processes. There is no direct evidence in the commit of an exploitable vulnerability, but it is a deliberate relaxation of a cryptographic primitive in a security-sensitive data structure, which warrants scrutiny.
Move the SipHash round, compression, and finalization operations shared by `CSipHasher` and `PresaltedSipHasher` into inline `SipHashState` methods. This centralizes state mutation, preserves the existing byte-path code generation, and keeps the security-sensitive follow-up focused on its changed block compression, round counts, and finalizer.
Co-authored-by: Pieter Wuille <pieter@wuille.net>
85/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This is a code cleanup (refactor) that moves the internal SipHash mixing steps into shared helper methods. It does not change how Bitcoin hashes data, how many rounds are run, or any user-visible behavior. There is no security bug being fixed here.
Add `SipHasher13UJ`, a block-oriented implementation accepting arbitrarily mixed 64-bit normal blocks and 256-bit jumbo blocks. For hash-table use, cryptographic hash outputs must make up all but a small bounded number of retained jumbo blocks.
The generic interface serves as the executable specification for the fixed-width overloads added next.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 21/100
This commit adds a new, weaker variant of the SipHash algorithm inside Bitcoin Core's cryptography module. It is explicitly designed for low-security uses such as internal hash tables, not for protecting funds or network messages. The code itself appears to be a clean, intentional addition with extensive comments explaining the trade-offs. There is no indication in the commit that this fixes a vulnerability or introduces an exploitable bug.
Add SipHash-1-3-UJ outputs to the shared vectors for sequences of 8- and 32-byte blocks. Check generic writes and applicable fixed-width `Hash` overloads against those outputs, and fuzz their equivalence including mixed normal/jumbo encodings.
The outputs were generated by an independent implementation that Claude Opus 4.8 produced using only the `SipHasher13UJ` class comment as its prompt.
Co-authored-by: Lőrinc <pap.lorinc@gmail.com>
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100
This commit only adds new test cases and fuzzing coverage for an existing SipHash variant called SipHash-1-3-UJ. It does not change any production code, so it cannot introduce a security vulnerability or fix one. The change makes the software's test suite more thorough by verifying that the existing hash implementation produces expected outputs.
Benchmark 32-byte hashes and inputs consisting of a 32-byte hash plus a 32-bit index with SipHash-2-4 and SipHash-1-3-UJ. The UJ benchmark zero-extends the index into one 64-bit normal block. Keep all four measurements together after shared correctness coverage and before changing `CCoinsMap`'s hasher.
Co-authored-by: Pieter Wuille <pieter@wuille.net>
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds new performance benchmark tests for a hash function called SipHash. It does not change any production code that handles Bitcoin transactions, networking, or wallet data. There is no security issue here.
Add const `SipHasher13UJ::Hash` overloads for one `uint256` jumbo block, optionally followed by one 64-bit normal block. Reuse the generic hasher's initialized state and define these short paths in the header because the new hasher benefits from inlining.
Co-authored-by: Lőrinc <pap.lorinc@gmail.com>
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit adds two new shortcut methods for computing a specific SipHash variant on fixed-size inputs. It is a pure performance/ergonomics addition: the new methods copy the hasher's internal state before operating, so they do not alter the original object. There is no indication of a security bug or fix.
Lock SipHash-2-4 behavior into shared vectors before refactoring its round and finalization code. Store inputs as ordered hex byte blocks so `CSipHasher` and the independent Python implementation hash the same byte sequence, with applicable `PresaltedSipHasher` overloads checked against the same vectors. Add the 64 official SipHash-2-4 vectors alongside block-partition and empty-block cases for the generic path. Move randomized generic/fixed comparisons to the integer fuzzer.
SipHash-1-3-UJ coverage can add expected outputs for compatible 8- and 32-byte block sequences. The Python test reads a build-tree copy so functional-test staging behaves consistently when files are symlinked or copied.
Co-authored-by: Pieter Wuille <pieter@wuille.net>
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencecryptography-sensitive path
AI analysis · Informational 15/100
This commit only adds new test data and test code for the SipHash hashing function used in Bitcoin Core. It does not change any production code that handles transactions, networking, or wallets. The goal is to make sure the existing SipHash implementation behaves correctly and stays correct during future cleanups.
uint256: Workaround GCC-14 stringop-overread bug in Compare
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100
This is a compiler-specific workaround, not a fix for a security vulnerability in Bitcoin Core itself. The change swaps a low-level memory comparison for a C++ standard-library comparison in a 256-bit integer class, solely to silence a false-positive warning produced by GCC 14. There is no indication it changes runtime behavior or fixes an exploitable bug.
test: Move cluster_linearize.h contents into cluster_linearize namespace
This change: 1. Avoids Clang's `-Wunused-template` warnings when building the `bench_bitcoin` or `fuzz` targets. 2. Follows C++ Core Guidelines: "SF.21: Don't use an unnamed (anonymous) namespace in a header". 3. Drops `[[maybe_unused]]` annotations, which are no longer needed after changing the linkage from internal to external.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100
This commit is a minor code cleanup in a test-only header file. It moves helper functions from an anonymous namespace into a named namespace and removes some compiler-hint annotations. There is no change to how Bitcoin Core validates transactions, handles money, or protects user data.
AI review queuedtest: wallet: BnB incomplete result on attempt-limit successby Bruno Garcia · 6ee05c4b · Jul 17, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Bruno Garcia
test: wallet: BnB incomplete result on attempt-limit success
BnB can return a valid selection before exhausting the search tree, then hit TOTAL_TRIES while continuing to look for a better one. Add a unit test for that path using a known exhaustion fixture plus an exact-match coin, and assert the result is marked incomplete via GetAlgoCompleted() == false.
Co-authored-by: Murch <murch@murch.one>
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds a new unit test for Bitcoin Core's coin selection algorithm. It checks that when the Branch-and-Bound (BnB) search finds a usable coin selection early but then keeps searching for a better one until it hits the attempt limit, the result is correctly marked as 'incomplete' (the algorithm did not fully finish exploring all possibilities). There is no code change to the actual wallet behavior—only a new test.