BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 53 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36535: policy: sum package weight in int64_tby merge-script · c50817fe · Oct 16, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36535: policy: sum package weight in int64_t

faaabe4454c14537e9f23bd349d43d7233df14fe policy: sum package weight in int64_t (Ferdinando Ametrano)

Pull request description:

`IsWellFormedPackage` sums the package weight with `std::accumulate` starting from a plain `0`, so the running total is an `int`. A package heavier than `INT_MAX` would wrap and could pass the `MAX_PACKAGE_WEIGHT` check. No package that large reaches this check today, since RPC request bodies are capped at 32 MiB and P2P messages at 4 MB, so this is defense in depth. It picks up the one-line fix from #35473, which was closed with an invitation to do so.

I start the sum from `int64_t{0}`, as the vsize sum in `validation.cpp` already does. I did not add a test, since the one on #35473 was turned down. I checked the fix locally with a throwaway test that puts one transaction of 88M weight into a package 25 times: before the fix the package is rejected as `package-contains-duplicates`, after it as `package-too-large`.

ACKs for top commit:
maflcko:
lgtm ACK faaabe4454c14537e9f23bd349d43d7233df14fe
instagibbs:
ACK faaabe4454c14537e9f23bd349d43d7233df14fe

Tree-SHA512: 0a975de2dab72917276eb90633f938847c49c9946212c68b4e513b671d5bdbb2fba1a0358633ee309b1830dae6da353a53df1f6019d6ccc9a371d4997d840ec4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36379: fuzz: fix stale comments in http_requestby merge-script · cce32b16 · Oct 15, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36379: fuzz: fix stale comments in http_request

3f7f845cf51c1060ee577f0df8869a4efd5ea033 fuzz: fix stale comments in http_request (frankomosh)

Pull request description:

Follow-up to https://github.com/bitcoin/bitcoin/pull/36135#discussion_r4030189935, fixing a false comment flagged in review.

The comment says a completed request is always handed back to a worker. Since #36174 it stays in `m_req` when the send buffer is over MAX_BODY_SIZE.

ACKs for top commit:
pinheadmz:
ACK 3f7f845cf51c1060ee577f0df8869a4efd5ea033
hodlinator:
ACK 3f7f845cf51c1060ee577f0df8869a4efd5ea033

Tree-SHA512: 6f499c394f8e933ba8b5eccd8228f3a7f5e77f41b7e998712c67af004d23c557b7191ace1ad47980920fde802debc73efb9e9b7163db564d3f35086dfeb46b37

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36511: test: Small mempool_compatibility.py cleanupsby merge-script · 649bc0a6 · Oct 15, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36511: test: Small mempool_compatibility.py cleanups

fae8a8fd3cc5c511191a18665a731195a9ac228d test: Small mempool_compatibility.py cleanups (MarcoFalke)

Pull request description:

After https://github.com/bitcoin/bitcoin/pull/36294:

* The MiniWallet mode can be dropped (using the default), now that all nodes support taproot.
* The `sync_fun=self.no_op` can be dropped (using the default sync), if the node connection is done earlier.
* A check for the unbroadcast set can be added, now that all nodes support persisting the set.

ACKs for top commit:
mercie-ux:
tACK fae8a8fd3cc5c511191a18665a731195a9ac228d
fjahr:
Code review ACK fae8a8fd3cc5c511191a18665a731195a9ac228d

Tree-SHA512: abb4415cb83e92cae4dd42d281cd933d6b64a28f817480f0d36cc034729a9e6e30a8adb3614c5d074e319153bb60ccc154ee5c9096ae222eeb17ca01f06532da

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36446: test: remove some avoidable test waitsby merge-script · 3c30b8ae · Oct 15, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36446: test: remove some avoidable test waits

ce1d88b2632cc3950f47d8b191bdd74b806eb3ae test: avoid unused wallet test chains (will)
40619d068741ec609ddd3148f13234cbdc54161c bench: honor configured wallet epochs (will)
79bb94f09244ef5745d3c83a8839eec3fcbf2f74 test: cap expected IPC timeouts (will)
06cb869112da6bb1c43f938b2e5a9794f825ff92 test: shorten network limited negative wait (will)

Pull request description:

A few of our longer-running tests have some unnecessary waits and timeouts in them. Reduce or replace them to shorten test times:

- in `p2p_node_network_limited` replace the expected sync timeout with header/ping barriers and a bounded negative check. At CI timeout factor 40, saves roughly 195 seconds per transport.
- in `interface_ipc_mining` cap three expected no-event waits at five seconds, saving roughly 105 seconds at factor 40 in CI.
- in `WalletLoadingDescriptors` honor sanity mode’s single epoch, avoiding four unnecessary wallet unload/load cycles.
- two wallet unit tests switch to `BasicTestingSetup` avoiding construction of two unused 100-block chains.

The timeout changes alone save approximately eight minutes of accumulated test-worker time on CI jobs running both transports and IPC mining. Wall-clock savings depend on parallel scheduling, CPU etc.

ACKs for top commit:
Ayoazeez26:
tACK ce1d88b263
maflcko:
review ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae 🐠
ViniciusCestarii:
ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae

Tree-SHA512: 77a78ff05327cf08273618ed3f1601d60a0d8533459e3beecd56ed36f0f743ee4cdb6c227d9eee2a48c46831f92b0ab64e74faa536e56a28c5281c7e1eacdae2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's test and benchmark code to remove unnecessary waiting periods and honor existing test settings. It does not alter the production Bitcoin node software that users run, so it cannot directly affect live network security, wallets, or consensus behavior. The changes make CI tests run faster and avoid some redundant setup work.

Lower-priorityMerge bitcoin/bitcoin#36469: refactor: deduplicate block validation state catcherby merge-script · f13ae519 · Oct 14, 2026 · 4 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36469: refactor: deduplicate block validation state catcher

c9cccf6d68c682e533876b4450f5ad7044a79f10 refactor: deduplicate block validation state catcher (Enoch Azariah)

Pull request description:

As mentioned in https://github.com/bitcoin/bitcoin/pull/34644#discussion_r2889315162 and https://github.com/bitcoin/bitcoin/pull/35675#discussion_r360301816, the validation state catchers were defined in the block template manager, `submitblock` rpc and mining test helpers, even though they do the same thing.

Moved this helper into `node/block_validation_state_catcher.h` and reuse it across all three callers. An optional validation state replaces the separate `found` flag where used, preserving each caller's registration and result handling

Replaces #36389 with the same commit on a dedicated branch.

ACKs for top commit:
maflcko:
review ACK c9cccf6d68c682e533876b4450f5ad7044a79f1 🖋
ismaelsadeeq:
ACK c9cccf6d68c682e533876b4450f5ad7044a79f10
sedited:
ACK c9cccf6d68c682e533876b4450f5ad7044a79f10
w0xlt:
ACK c9cccf6d68c682e533876b4450f5ad7044a79f10

Tree-SHA512: ae4bea2f2da9df4350099e5787e7743d07d86acf2c6e6150a9d7b9b659c14c217a07bfd3a0c8c6ee9a75043ff458aec0ea1d01ca86f89f6818866cca377e2318

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36425: guix: declare python-setuptools in codesign manifestby merge-script · 60ebd98c · Oct 14, 2026 · 1 fileMessage 91 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36425: guix: declare python-setuptools in codesign manifest

c04e968b2b8b7c8778910f907ed8c26ba59edd85 guix: update certvalidator for Python 3.12 (will)
11977b42acc54e2abcd8e06272a8f44865cf40a4 guix: declare python-setuptools (will)

Pull request description:

Since we bumped to python 3.12, `setuptools` is no longer provided by default: https://docs.python.org/3.12/whatsnew/3.12.html#ensurepip Declare this explicitly.

Also bypass `certvalidator`'s custom test loader using `unittest`, until [this upstream patch](https://github.com/LRGH/elfesteem/commit/000d6bbcd3a4b3d132ad6d932eedb3158b3313e9) makes it into our Guix time machine commit.

Commits split to allow easy reversion of only the `imp` test loader patch.

Fixes: #36421

ACKs for top commit:
hebasto:
ACK c04e968b2b8b7c8778910f907ed8c26ba59edd85.
pinheadmz:
ACK c04e968b2b8b7c8778910f907ed8c26ba59edd85

Tree-SHA512: 8068f62e403ced160aa9fedf673f65c43327e58d148e2cf14332e2e563a99ac649b3b337be5dc4c1b46b414d3dc1c865f57b619f9e195393d0ba7ebc6377454c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This is a build-system maintenance patch for Bitcoin Core's Guix codesigning environment. It explicitly adds python-setuptools (which Python 3.12 no longer includes by default) and updates a certificate-validation library used during the release signing process. There is no direct vulnerability in the shipped Bitcoin Core software; the change prevents release-build failures and keeps the signing toolchain working.

Lower-priorityMerge bitcoin/bitcoin#36517: Update crc32c subtree to latest masterby Hennadii Stepanov · 173ec9a0 · Oct 14, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36517: Update crc32c subtree to latest master

55f7dd00213dfaa2d39cf0e9b316627e935a0424 Squashed 'src/crc32c/' changes from 60bcf13edf..5bd2a6bcf9 (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/crc32c-subtree/pull/11

Used in #36509.

ACKs for top commit:
instagibbs:
clACK 2958dda39084db4f78eacd66133caae9a3be488b
hebasto:
ACK 2958dda39084db4f78eacd66133caae9a3be488b.

Tree-SHA512: 93f2ea8def8421ab8d500449107b288dba3e9fe10b60ae45596de0500d8d3485f048b70e896d1f3bfd8fb576187ddcff1788752544d7448c6798333d992488c2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritytest: measure rpcwaittimeout floor with monotonic timeby nervana21 · dc27539d · Oct 14, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · nervana21

test: measure rpcwaittimeout floor with monotonic time

Require the `-rpcwait` command to wait at least the configured timeout
period before raising a process error. Measure the wait using
`time.monotonic()` so that wall-clock discrepancies do not cause
intermittent test failures.

Also, lower the timeout from 5 to 1 second.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Security candidateMerge bitcoin/bitcoin#36504: test: Add missing timeouts for HTTPConnectionby merge-script · 4b4cdde0 · Oct 14, 2026 · 5 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36504: test: Add missing timeouts for HTTPConnection

fa4308dfbf3a59f95deac382fa955570f814e8ca test: make wait_until timing arguments keyword-only (MarcoFalke)
fad441867c9baa8c4ae9a755f09948efa1b23447 test: Add missing timeouts for HTTPConnection (MarcoFalke)

Pull request description:

Without a timeout, the test can hang forever on broken systems. This is fine, but it would be nice if the test instead failed with a nicer error message, indicating the timeout.

ACKs for top commit:
mercie-ux:
tACK fa4308dfbf
hebasto:
ACK fa4308dfbf3a59f95deac382fa955570f814e8ca, I have reviewed the code and it looks OK.
pinheadmz:
ACK fa4308dfbf3a59f95deac382fa955570f814e8ca

Tree-SHA512: 8aaf9b78828cfbfa44f63b350edc7667ef5bd02c2d5f9011affc98625ecd8f37c80be980dc7c953de58840f48bfe50d23051b83cda2aca18a09d9920c8c77b1f

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal test scripts. It adds timeout values to test-only HTTP connections and makes timeout arguments keyword-only in a helper function. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.

Security candidateMerge bitcoin/bitcoin#36485: ci: refactor BUILD_TARGETS useby Hennadii Stepanov · badc9574 · Oct 13, 2026 · 12 filesMessage 93 · StrongInformational 15Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36485: ci: refactor BUILD_TARGETS use

fa5643ff99af95227abb7a0b031e1dfbe4019dd7 ci: refactor BUILD_TARGETS use (MarcoFalke)

Pull request description:

* "all" is added to the build targets unless GOAL is "all" or contains "codegen". This implicit translation can be confusing, so explicitly spell out the targets as "all", "all deploy", etc., where needed.

* Also, use the eval-based string-to-argv conversion for BUILD_TARGETS to avoid disabling shellcheck SC2086.

ACKs for top commit:
fanquake:
ACK fa5643ff99af95227abb7a0b031e1dfbe4019dd7
hebasto:
ACK fa5643ff99af95227abb7a0b031e1dfbe4019dd7.

Tree-SHA512: 7785359d35e73586ea74a71f2ff78c0e72fa7fef897b1dedb18c9f168ba291e699f9cd199c62b315c98dffaae6843f94e3b233290c1755d2659189edaba8ecc5

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This change is a cleanup of Bitcoin Core's continuous integration (CI) scripts. It replaces an implicit rule that automatically added 'all' to build targets with an explicit list of build targets in each CI configuration. There is no security vulnerability here; it is purely a maintainability and shell-script linting improvement.

Security candidateMerge bitcoin/bitcoin#36294: mempool: Remove -persistmempoolv1 optionby merge-script · 3b07eeea · Oct 13, 2026 · 7 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36294: mempool: Remove -persistmempoolv1 option

731b89c09bbc286801eebf5061b161c3d5091150 test: Check that importmempool fails on a malformed mempool.dat (Fabian Jahr)
4c01625f798b4017ab83f86ab8815d56b4d18042 doc: Add release note for -persistmempoolv1 removal (Fabian Jahr)
d1dfdf827619bd06ff9c52e42f2c370e6e70504f mempool: Remove -persistmempoolv1 option (Fabian Jahr)
86a31b93d0db7f01e5c1a61fb014b89b2506fe54 test: Use v31.0 as old node in mempool_compatibility.py (Fabian Jahr)

Pull request description:

`-persistmempoolv1` was added in #28207 as a temporary option to allow downgrading to v26 and earlier, which can't read the XOR'ed `mempool.dat`. v26 has now been EOL for a while. So any version this option could help downgrade to is unsupported now. It seems ready for removal. I don't think this requires an additional deprecation cycle since the feature is useless for any maintained version and docs have always stated that this was a "temporary option that will be removed in the future".

Reading v1 files is still supported, so upgrading directly from an old version keeps the persisted mempool.

`mempool_compatibility.py` now uses v28.2 as the old node, the oldest release in `get_previous_releases.py` that writes the current format.

ACKs for top commit:
maflcko:
review ACK 731b89c09bbc286801eebf5061b161c3d5091150 🐋
ismaelsadeeq:
ACK 731b89c09bbc286801eebf5061b161c3d5091150

Tree-SHA512: 6a61812ef722033f883143a2e9f456bd5c1b348d6e90376220ca13799a1545a5210803dd33f7d6a3da1dac77361f6961f07f5c55cb4a972ddecf80578e0394f0

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
update trustmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit removes an old command-line option called -persistmempoolv1 that let users write the mempool file in a legacy format. The option was always documented as temporary, and the only versions it helped downgrade to are no longer supported. Reading the old format is still supported, so users upgrading from old versions are not affected. A new test was added to check that importing a corrupted mempool file is rejected safely. There is no direct security vulnerability here; it is a cleanup of obsolete functionality.

AI review queuedMerge bitcoin/bitcoin#36440: test: speed up functional tests by removing avoidable waitsby merge-script · 1605d887 · Oct 13, 2026 · 8 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36440: test: speed up functional tests by removing avoidable waits

8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef test: wake p2p wait_until on message delivery instead of polling (ViniciusCestarii)
10cfeb33357c937ddd9f588a35e0f8f33abd6ece test: set noban_tx_relay to speed up slow tx relay tests (ViniciusCestarii)

Pull request description:

Reduce functional test runtime:

- set noban_tx_relay = True for tests that can benefit from it.
- wake P2PInterface.wait_until as soon as a message is delivered or the connection state changes, instead of polling every 50ms.

Tested on my x86-64 machine:

Wall time (-j=18): 110.8s to 99.1s (-11%)
Accumulated: 1715s to 1411s (-17.5%)

Tests that were most affected:

| test | before | after |
|---|---|---|
| feature_maxuploadtarget | 57.9s | 6.2s |
| wallet_conflicts | 49.2s | 7.0s |
| p2p_sendheaders | 31.1s | 6.8s |
| p2p_compactblocks | 11.1s | 1.7s |
| wallet_orphanedreward | 9.3s | 5.2s |
| wallet_importprunedfunds | 4.9s | 2.9s |

ACKs for top commit:
maflcko:
review ACK 8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef 🏏
w0xlt:
ACK 8dc80cafa2ee5932c9ff499c02d6ab8e3cf2f5ef

Tree-SHA512: e01654de189d33957e5c9794c3be0aad08a1628480af11ab2365bd6c8b5d6e1130e561fa85380e2b23daad21248993a5658f1740d9d03d1fe5485eef0a9c3851

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's functional test framework to make tests run faster. It replaces a slow polling wait with an event-driven notification and enables a test-only peer-whitelist flag for transaction relay. There is no change to production node code, no user-facing behavior change, and no security issue.

Lower-priorityMerge bitcoin/bitcoin#36441: doc: fix How to Upgrade section for bitcoin wrapper and libexecby merge-script · 60afa0b8 · Oct 12, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36441: doc: fix How to Upgrade section for bitcoin wrapper and libexec

2870608661149b0a97ff7ec5b0bd25cc0c010f4d doc: fix How to Upgrade section for bitcoin wrapper and libexec (spidey279)

Pull request description:

Since #31375, Linux installs ship a bitcoin wrapper in bin/ that dispatches to multiprocess binaries in libexec/. Copying only bitcoind/bitcoin-qt leaves those stale. Tell users to copy over bin/ and libexec/ instead.

Fixes #36431.

ACKs for top commit:
Naomi-Gift:
ACK 2870608661149b0a97ff7ec5b0bd25cc0c010f4d
tumutech:
ACK 2870608661149b0a97ff7ec5b0bd25cc0c010f4d
hebasto:
ACK 2870608661149b0a97ff7ec5b0bd25cc0c010f4d.

Tree-SHA512: 401f757882a0784dfefda88a03516bd8d7be8e3c9afbff800c27eee5c0786119dada679db3231c38ce0dceb940b89cd5d77b0d46cd7747386ee156c12090e0e7

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36271: Revert #36057 & document mingw-w64 requirementby Hennadii Stepanov · a8b69bde · Oct 11, 2026 · 6 filesMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36271: Revert #36057 & document mingw-w64 requirement

1c96b08cb60bee930ed390de019a2cf943445ef5 nix: drop MSVCRT build (fanquake)
cd7605a6b782c174994b0e9ce50fe0256217b780 doc: document mingw-w64 requirement in Windows build docs (fanquake)
8073ff101f57f243244fcfefda0786280d9adbd0 Revert "build: check for SetThreadDescription() at configure time" (fanquake)

Pull request description:

A follow-up reverting #36057, now that we've branched off for `33.x`.
Also documents `mingw-w64` requirements (#32380).

ACKs for top commit:
willcl-ark:
utACK 1c96b08cb60bee930ed390de019a2cf943445ef5
hebasto:
re-ACK 1c96b08cb60bee930ed390de019a2cf943445ef5.

Tree-SHA512: 338a1cd4f3d0d203ff4e7e36c4f4d6e3d918594791e76bc3f7c019fe42bc6e51cc6eeda3979019226969b4b4ea6a126c8d7e74c58aa6215b34f8caa588515e8d

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36467: test: Set socket timeout in interface_http.pyby merge-script · 228877d7 · Oct 10, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36467: test: Set socket timeout in interface_http.py

fa5551cc6de1629ef800d8b1f7697af923a953bb test: Rework 413 Too Large tests in interface_http.py (MarcoFalke)
fab1529ebc7c5618525afa2462135147974fc38e test: Set socket timeout in interface_http.py (MarcoFalke)

Pull request description:

This should help to debug/fix https://github.com/hebasto/bitcoin-core-nightly/issues/368, but seems independently useful to avoid unbounded-time test runs.

Also rework the `413`-code tests where a pre-existing issue was made more likely by the first commit.

ACKs for top commit:
trakshan-mishra:
tACK fa5551cc6de1629ef800d8b1f7697af923a953bb
pinheadmz:
ACK fa5551cc6de1629ef800d8b1f7697af923a953bb

Tree-SHA512: a891fac6a56db46da3653e17c0869b78df7bd571e73a0bcc882c26d8822081aad958a86115a696dde1a4f5a208f9c0ba6157a224aafa90c2a33f3c028a97de13

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36337: fuzz: Cover block filter P2P messagesby merge-script · c067aa71 · Oct 9, 2026 · 5 filesMessage 96 · StrongInformational 23Details
Commit message · merge-script

Merge bitcoin/bitcoin#36337: fuzz: Cover block filter P2P messages

fab64c032c1a0c997c6ec398cc5578df36b33b7d test: DestroyAllBlockFilterIndexes in ~ChainTestingSetup() (MarcoFalke)
fadc2c93d3dd46344f660c83005cdfe505d21efc fuzz: Cover block filter P2P messages (MarcoFalke)

Pull request description:

The BIP157 P2P messages are not covered by any fuzz targets at all.

Fix this to cover them via the P2P targets.

Should be possible to test by verifying the integer sanitizer is triggered (https://github.com/bitcoin/bitcoin/pull/36321#issuecomment-5810977529):

```
$ echo 'FwAAAAEAAABcX2dldGNmY2hlY2twdAAftOvdD0sFqXEx6US5VIknlsOJqZ5goMwtmwZBPdCxQVxf
AfkGKP39/f0v/Q/9E1AP/f2ybAT1Af39A/399wEAuXEAAAAAAAAAAAB1z3QAbgAAQAHm/f39/f39
/f39/S8/D/0B/f3IAAcBBWNmaf8DAAAA' | base64 --decode > /tmp/msg.bin

$ UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=0:halt_on_error=0:report_error_type=1" FUZZ=process_messages ./bld-cmake/bin/fuzz /tmp/msg.bin

./bld-cmake/bin/fuzz: Running 1 inputs 1 time(s) each.
/src/net_processing.cpp:3662:33: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_type' (aka 'unsigned long')
/src/net_processing.cpp:3662:18: runtime error: implicit conversion from type 'size_type' (aka 'unsigned long') of value 18446744073709551615 (64-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)

ACKs for top commit:
marcofleon:
re-ACK fab64c032c1a0c997c6ec398cc5578df36b33b7d
Crypt-iQ:
re-ACK fab64c032c1a0c997c6ec398cc5578df36b33b7d

Tree-SHA512: 23275c73a53f53b12ddf4466f9cb28fbab109fadcf1280d17c8fb293091958e957922f1abe979948407395e9e8ee2d4b3bd100571dadc049734bf2b0e3f5c155

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validationfuzzing or regression evidencemerge-commit duplicate discount
AI analysis · Informational 23/100

This commit adds fuzz-test coverage for BIP157 block-filter P2P messages and fixes a test-only cleanup issue. The fuzz target found an unsigned-integer overflow in net_processing.cpp when handling these messages, but the overflow appears to be in a debug/test code path and is not described as a remotely exploitable network vulnerability. The main code change is test infrastructure: initializing a basic block-filter index during fuzz setup and destroying it on teardown to avoid deadlocks.

Lower-priorityMerge bitcoin/bitcoin#36474: ci: Run valgrind --exclude tests againby merge-script · 4bacf21a · Oct 9, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36474: ci: Run valgrind --exclude tests again

fa486a4843226681442c1bed9d51a836bad7c4c9 ci: Run valgrind --exclude tests again (MarcoFalke)

Pull request description:

Also, clarify why s390x has the exclude list, since the issue it refers to has no details or a debug trace.

Neither config is run by the CI, because they are slow, but I've run them locally.

If the valgrind exclusion is needed somewhere, an exact debug trace should be provided.

ACKs for top commit:
fanquake:
ACK fa486a4843226681442c1bed9d51a836bad7c4c9

Tree-SHA512: be9f7b7c71e6d6dae720e445cff608d740d0e4fa381de79e08ed2bab3e36cfb92df31d74dcaafb24b9aed03bdc5feb6acf43513e5a164729e9b78d8dc9a7557a

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35989: wallet: fix crash on importdescriptors with a range ending at 2^31-1by Ava Chow · acdb3269 · Oct 8, 2026 · 7 filesMessage 96 · StrongModerate 66Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35989: wallet: fix crash on importdescriptors with a range ending at 2^31-1

93c8aec3fbc8c5a2fcc834c4acc1b7d96bffa9a0 doc: add release note for #35989 (Shuvam Pandey)
457c9e8999fbee1d37f41eaede681f787e657395 script: avoid overflow when checking descriptor range bounds (Shuvam Pandey)
ab3bb55a67cced3551e8ebb658c4d962a10d3715 test: add coverage for descriptor range end bounds (Shuvam Pandey)
867ad9bffbd3ab26c9899207ddd11380e0c1a1bd wallet: fix integer overflow in descriptor keypool top up (Shuvam Pandey)
1889440f821d6bf8394050c96cc8e06a2f18d9c2 wallet: reject unrepresentable descriptor import ranges (Shuvam Pandey)

Pull request description:

`WalletDescriptor` stores an exclusive range end in `int32_t`. Importing
`[2147483647, 2147483647]` produces an end of `2^31`, which narrows to a negative
value and aborts the node during keypool top-up. An import without a range can
hit the same issue with an oversized `-keypool`.

Check the exclusive end before constructing the wallet descriptor, covering
both explicit and default ranges. The bound stays wallet-specific: scanning
RPCs still accept `INT32_MAX` as an inclusive endpoint.

Also calculate the keypool top-up endpoint in `int64_t` before checking its
bound, and reject reversed ranges before computing `high - low` in
`CheckDescriptorRangeBounds`. These fix the overflows reached by
`keypoolrefill INT32_MAX` after advancing a descriptor, and by `[INT64_MAX, 0]`,
respectively. Regression tests cover all three fixes.

I tested on macOS arm64 with Clang 22 and UBSan passed: 34 targeted unit
cases and the importdescriptors, keypool, deriveaddresses (RPC and CLI),
scantxoutset, and scanblocks functional tests.

ACKs for top commit:
achow101:
ACK 93c8aec3fbc8c5a2fcc834c4acc1b7d96bffa9a0
polespinasa:
ACK 93c8aec3fbc8c5a2fcc834c4acc1b7d96bffa9a0

Tree-SHA512: aec09a6e8d71ff1f57f8db6927fd93469e47f3549357dde4fceb3ef77f9c3be802c720d6856578149f78e5a277be8605477dbe9df7fd88555b4db355624cad0f

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetyfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 66/100

This update fixes a crash in Bitcoin Core's wallet that could be triggered when importing a descriptor with a range ending at the largest 32-bit signed integer (2,147,483,647). Because the wallet stores the range end as an exclusive value in a 32-bit signed integer, that endpoint becomes 2^31 and wraps around to a negative number, causing the node to abort during keypool top-up. The patch rejects such unrepresentable ranges before they are stored, and also hardens related arithmetic to avoid similar overflows.

Lower-priorityMerge bitcoin/bitcoin#36450: test: Use timeout_factor for drain timeout in check_slow_read_throttleby merge-script · f739c787 · Oct 8, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36450: test: Use timeout_factor for drain timeout in check_slow_read_throttle

fa845f76d5c6d9c4aba46e03eb9b77a6e1f5ddce test: Use timeout_factor for drain timeout in check_slow_read_throttle (MarcoFalke)

Pull request description:

The `check_slow_read_throttle` functional test may intermittently fail on slow build configs (like sanitizers+debug+no-opt). This is fine, but it would be nice if it passed.

To reproduce the failure, add a long sleep for the big json requests:

```diff
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
index 0c25ebbba5..42c54c2cdf 100644
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -614,2 +614,3 @@ void HTTPRemoteClient::Send(const HTTPResponse& res, std::span<const std::byte>
bool send_buffer_was_empty{false};
+ bool send_buffer_over_limit{false};
// Fill the send buffer with the complete serialized response headers + body
@@ -634,2 +635,4 @@ void HTTPRemoteClient::Send(const HTTPResponse& res, std::span<const std::byte>
if (!send_buffer_was_empty) m_send_ready = true;
+
+ send_buffer_over_limit = m_send_buffer.size() > MAX_BODY_SIZE;
}
@@ -652,2 +655,11 @@ void HTTPRemoteClient::Send(const HTTPResponse& res, std::span<const std::byte>

+ // TEST-ONLY: Widen the interval between queueing a throttling-sized response
+ // and allowing the next pipelined request to be dispatched. This reproduces
+ // the slow-worker scheduling window exercised by interface_http.py.
+ if (send_buffer_over_limit) {
+ // The functional test waits twice for five seconds before it starts
+ // its own ten-second recv() timeout, so this must cover both phases.
+ std::this_thread::sleep_for(30s);
+ }
+
// Signal to the I/O loop that we are ready to handle the next request.
```

Then, on master (or on this pull with `--timeout-factor=1`), it will fail and with `--timeout-factor=3` it will pass:

```
./bld-cmake/test/functional/interface_http.py --test_methods check_slow_read_throttle --loglevel=DEBUG --timeout-factor 3
```

ACKs for top commit:
pinheadmz:
untested, LGTM ACK fa845f76d5c6d9c4aba46e03eb9b77a6e1f5ddce
l0rinc:
code review ACK fa845f76d5c6d9c4aba46e03eb9b77a6e1f5ddce

Tree-SHA512: a4ca656d6329d16ac0459aec7ce03cd1e06ee05c7f868d9f3764fbe187d86e343b1d3c23da949d09f90dbb4cc7e05286ce27e1d3a6f0cd7f0b5b21f5492d339a

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#34374: kernel: use struct-based logging and simplify logging interfaceby merge-script · 8ad7e25d · Oct 8, 2026 · 8 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#34374: kernel: use struct-based logging and simplify logging interface

eb086540b680cfed42ab7f9498c1ade459828808 kernel: make logging struct-based and simplify configuration (stickies-v)
0c327a34748a3d882d88fe0034187ddee0c7d59a kernel: add KernelLogger (stickies-v)
3d976f464d5a5dbb0b867783c472b31ba871900a kernel: remove API to format and disable logging (stickies-v)
4ec80a5d4fa3ff567356d946d45699a3c407c77f kernel: add log level and category name helpers to wrapper (stickies-v)
2ce6cd3d906da00c2b12c00a9437ed68dc5c4f14 kernel: expose btck_LogEntry (stickies-v)
694eaad2eb287ca8c862d766cde22cb39667fed8 kernel: add missing log levels and categories (stickies-v)

Pull request description:

tl;dr: kernel logging is cumbersome. This PR delivers log entries as a struct instead of a formatted string, and simplifies the kernel logging interface. Closes #34062.

## Motivation

The `bitcoinkernel` library (#27587) [exposes](https://github.com/bitcoin/bitcoin/blob/b26762bdcb941096ccc6f53c3fb5a7786ad735e7/src/kernel/bitcoinkernel.h#L698-L778) functionality to interface with the kernel logging. This includes registering callbacks for log statements, level/category filtering, string formatting options, and more.

Kernel logging has a few problems:
- [callbacks](https://github.com/bitcoin/bitcoin/blob/b26762bdcb941096ccc6f53c3fb5a7786ad735e7/src/kernel/bitcoinkernel.h#L304) operate on formatted strings, so users need to parse the string to get the timestamp, category, level, ... based on which options are set. This is cumbersome, brittle, and inefficient.
- the [filtering interface](https://github.com/bitcoin/bitcoin/blob/b26762bdcb941096ccc6f53c3fb5a7786ad735e7/src/kernel/bitcoinkernel.h#L737) is not really intuitive, requiring users to call combinations of `btck_logging_set_level_category` and `btck_logging_enable_category` when they want to produce `debug` or `trace` logs. The level/category system makes sense for node, because it directly controls what gets written to disk and stdout, and there are quite a lot more categories producing logs. Kernel doesn't really need this - users control what happens to the logs, and can do any filtering/manipulation in the callback they provide.
- the node logging infrastructure has quite a bit more functionality than is necessary for a library, including ratelimiting, log formatting, outputting, buffering, ... This introduces unnecessary code and interface complexity.

## Approach

Log generation (`util/log.h`: macros, `util::log::Entry`, and the `ShouldDebugLog`/`ShouldTraceLog`/`Log` hooks an application must provide) was already separated from log handling (`logging.h`) in #34465 and subsequent PRs. This PR gives `bitcoinkernel` its own implementation of those hooks, so it no longer depends on `logging.cpp`, and upgrades the C API to deliver struct-based entries. Node logging is not changed.

1. **Preparatory work**: expose the missing levels and categories (`WARNING`, `ERROR`, `TXPACKAGES`, `LOCK`) and the `btck_LogEntry` struct, add `Name()` helpers to the C++ wrapper, and remove `btck_logging_set_options` and `btck_logging_disable` (with struct-based entries there is no kernel-side format to configure, and without buffering there is nothing to disable).
2. **Add `KernelLogger`**: a kernel-owned backend that holds the registered callbacks and the minimum level, and converts each `util::log::Entry` into a `btck_LogEntry`. Introduced in a separate commit to keep the scope of the behaviour-changing commit smaller.
3. **Update the bitcoinkernel C API**: `btck_LogCallback` receives a `btck_LogEntry` instead of a string, the `util::log` hooks are implemented on `KernelLogger`, `logging.cpp` is dropped from the kernel build, and the logging configuration interface is reduced to `btck_logging_set_min_level()`.

Behaviour changes for consumers (also described in each commit message):
- Logging callbacks deliver structs instead of formatted strings, and the entire logging interface is simplified.
- Filtering is levels-based only and can also filter `Info` and above. `Debug`/`Trace` apply to all categories, consumers can filter on `btck_LogEntry::category` (but string formatting is done for the entire level, instead of per enabled category).
- Entries logged before the first connection are dropped instead of buffered.
- Messages are delivered unescaped and without a trailing newline.

## Appendix

### `bitcoinkernel` C logging interface

```c
typedef struct {
const char* message; //! Log message text.
size_t message_len;
const char* thread_name; //! Name of the thread that produced the log message.
size_t thread_name_len;
int64_t timestamp_ns; //! Wall-clock time when the entry was logged, in nanoseconds since the Unix epoch.
int64_t mocktime_s; //! Mock time in effect when the entry was logged, in seconds since the Unix epoch, or 0 if no mock time is set (see btck_set_mock_time).
const char* file_name; //! Name of the source file that produced the log statement.
size_t file_name_len;
const char* function_name; //! Name of the function that produced the log message.
size_t function_name_len;
uint32_t line; //! Line number of the source code that produced the log statement.
btck_LogLevel level; //! Log severity level.
btck_LogCategory category; //! Log category.
} btck_LogEntry;

typedef void (*btck_LogCallback)(void* user_data, const btck_LogEntry* entry);

BITCOINKERNEL_API void btck_logging_set_min_level(btck_LogLevel level);

BITCOINKERNEL_API btck_LoggingConnection* BITCOINKERNEL_WARN_UNUSED_RESULT btck_logging_connection_create(
btck_LogCallback log_callback,
void* user_data,
btck_DestroyCallback user_data_destroy_callback) BITCOINKERNEL_ARG_NONNULL(1);

BITCOINKERNEL_API void btck_logging_connection_destroy(btck_LoggingConnection* logging_connection);
```

ACKs for top commit:
w0xlt:
ACK eb086540b680cfed42ab7f9498c1ade459828808
musaHaruna:
Code Review ACK [eb08654](https://github.com/bitcoin/bitcoin/commit/eb086540b680cfed42ab7f9498c1ade459828808)
sedited:
Nice, ACK eb086540b680cfed42ab7f9498c1ade459828808

Tree-SHA512: 301a388253ead2176d75cb69935839a103bc125cac064eba787a643449047bd1f2d32d9dd11828f4ab59ce66976827ab61490b0533705a80b5c86316a1cfadae

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35037: ipc: support per-address max-connections options on -ipcbindby merge-script · 442884f5 · Oct 8, 2026 · 12 filesMessage 91 · StrongInformational 22Details
Commit message · merge-script

Merge bitcoin/bitcoin#35037: ipc: support per-address max-connections options on -ipcbind

856f9ea158055460764883dfca01491951554d2e doc: add ipcbind max-connections release note (Enoch Azariah)
bdd381b8ed475b114d6a8ac25bb448515a2a42f9 ipc: test per-address connection limiting over unix sockets (Enoch Azariah)
8761d53b250e9bb81e59a21d48598c1b62fa0e65 ipc: support per-address max-connections on ipcbind (Enoch Azariah)
3d2b65d050962a35b071618a3f32f7a78831e8e3 ipc: add default connection limit for ipcbind listeners (Enoch Azariah)

Pull request description:

The branch extends `-ipcbind` to accept `,max-connections=<n>` options, for example `-ipcbind=unix:,max-connections=8` or `-ipcbind=unix:/custom/path,max-connections=8`, instead of introducing a separate global `-ipcmaxconnections` option.

This keeps the connection limit attached to each IPC listener instead of introducing a global `-ipcmaxconnections` option (https://github.com/bitcoin/bitcoin/pull/34978). A global option would not allow different limits for different `-ipcbind` addresses, and the inline option format can be extended in the future with additional options.

ACKs for top commit:
ryanofsky:
Code review ACK 856f9ea158055460764883dfca01491951554d2e. Only change since last review is wrapping the `-ipcbind` help text in `strprintf` so the default and maximum values are shown. Thanks for all the updates!
sedited:
ACK 856f9ea158055460764883dfca01491951554d2e
ViniciusCestarii:
re-ACK 856f9ea158055460764883dfca01491951554d2e

Tree-SHA512: dd39479372bb5e30d6faedcc3c5f82ba03dbce3a8e082c03c3baf79bca66979554826fab001ca208cefd25955b02f22e6c9cd5bcea7aca1b784f93187f12ab7e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 22/100

This change adds a per-listener connection limit for Bitcoin Core's local inter-process communication (IPC) socket option `-ipcbind`. Previously, IPC listeners had no enforced cap on simultaneous connections. The patch lets users specify `,max-connections=<n>` (default 16, maximum 256) and reserves matching file descriptors at startup. It is a hardening improvement rather than a fix for an active vulnerability, and it includes tests and release notes.

Security candidateMerge bitcoin/bitcoin#36436: ci: Derive CONTAINER_NAME from the ci config file nameby merge-script · 8406af1c · Oct 8, 2026 · 29 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36436: ci: Derive CONTAINER_NAME from the ci config file name

fa2cdb6a3c183b621b48966a9dc77842bb935d0c ci: [refactor] remove redundant GOAL=install (MarcoFalke)
fa547e8204cb6d3e9c8c2e56a973ca635e29cfdc ci: [refactor] Remove redundant set -o errexit (MarcoFalke)
fa8fd9164fb49d7ed21fc004b1dea62cffd14721 ci: Derive CONTAINER_NAME from the ci config file name (MarcoFalke)

Pull request description:

Some misc CI config cleanups:

* Mainly, to derive the unique CONTAINER_NAME from the unique file name.
* Two refactors, to remove redundant stuff.

ACKs for top commit:
willcl-ark:
ACK fa2cdb6a3c183b621b48966a9dc77842bb935d0c
sedited:
ACK fa2cdb6a3c183b621b48966a9dc77842bb935d0c

Tree-SHA512: 35a94c594165fc7010edbe76197a7dd96480b992ef141947924561c2f274d7cbe560775b5c587d2466db0caa0800414ae0ea923454db5aa8c6dd95cf4ab0fde0

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathauthentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup of Bitcoin Core's continuous integration (CI) configuration. It removes duplicated container names from many CI config files and instead derives the container name automatically from each file's name. It also removes a few redundant script settings. There is no change to the Bitcoin software that users run, no change to wallets, networking, consensus, or cryptography, and no security fix or vulnerability introduced.

AI review queuedMerge bitcoin/bitcoin#36471: bitcoin-util: print genesis hash in display orderby merge-script · 6b937883 · Oct 8, 2026 · 7 filesMessage 93 · StrongInformational 17Details
Commit message · merge-script

Merge bitcoin/bitcoin#36471: bitcoin-util: print genesis hash in display order

cc8285e8c98ac91a380eec899bab2aed5863a458 bitcoin-util: print genesis hash in display order (ViniciusCestarii)

Pull request description:

`bitcoin-util getchainparams` prints the genesis hash byte-reversed compared to `getblockhash 0`:
```
bitcoin-util getchainparams | grep genesis
```
"genesis": "6fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d6190000000000",
```
bitcoin-cli getblockhash 0
```
000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f

Use `GetHex()` instead of `HexStr()`, consistent with `pow.limit` in the same output and with the RPCs.

The command is new in v32.0 (#35736), so I believe this should be backported before final release to avoid changing the output format afterwards.

ACKs for top commit:
maflcko:
lgtm ACK cc8285e8c98ac91a380eec899bab2aed5863a458
sedited:
ACK cc8285e8c98ac91a380eec899bab2aed5863a458
brunoerg:
code review ACK cc8285e8c98ac91a380eec899bab2aed5863a458

Tree-SHA512: dc45152dfbcb92f32e19088c303953468cce3e9f4dbdb942cc730903ae6824e2edad7c10a65ea363531a7e8b8b7d90277d297f6f1ee37db58455992ddb2da4a2

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit fixes a display bug in the new bitcoin-util getchainparams command. The genesis block hash was being printed backwards (byte-reversed) compared to how it is normally shown elsewhere in Bitcoin. The change makes the output consistent with bitcoin-cli getblockhash 0 and other RPC commands. This is a cosmetic/output-format fix, not a security issue.

Lower-priorityMerge bitcoin/bitcoin#36416: test: use ipaddress in addr_to_hexby merge-script · f60450e9 · Oct 8, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36416: test: use ipaddress in addr_to_hex

0cd0789c86b39ba0ae4670068d5be351cdcf92ae test: use ipaddress in addr_to_hex (fanquake)

Pull request description:

Replace our hand-rolled IPv4/IPv6 parser, with `ipaddress.ip_address(addr).packed.hex()`.

See https://docs.python.org/3/library/ipaddress.html.

ACKs for top commit:
sedited:
ACK 0cd0789c86b39ba0ae4670068d5be351cdcf92ae
winterrdog:
tACK 0cd0789c86b39ba0ae4670068d5be351cdcf92ae
StephenChi-hi:
tACK 0cd0789c86

Tree-SHA512: c0da5b5c5248695d9d21f467f326d9b9072d904737c96531fe02dd7669a42886c78b35893cf4e278e03982baa1f89c412fb260dec47e070fe43ffb03daa85273

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedbitcoin-util: print genesis hash in display orderby ViniciusCestarii · cc8285e8 · Oct 8, 2026 · 7 filesMessage 45 · ThinInformational 15Details
Commit message · ViniciusCestarii

bitcoin-util: print genesis hash in display order

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a display bug in a command-line utility so that the Bitcoin genesis block hash is printed in the same byte order humans normally see it (big-endian), instead of the reversed internal storage order. It only changes output formatting and matching test data; it does not affect money, transactions, consensus rules, or network security.