Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…
Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…
Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.
This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …
This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…
NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…
Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
This commit only updates test data. It corrects the capitalization (checksum) of Ethereum addresses used in automated tests and refreshes the expected screen-shot hashes those tests compare against. There are no changes to the actual Trezo…
This commit changes the Trezor Python library so that, when setting up a Trezor Model One (the original Trezor 1 device), it now performs an entropy check by default if the device runs firmware 1.13.1 or newer. Previously, the library only…
Enables a previously disabled security/validation feature (entropy check) for a specific device modelAdds version-gated behavior to avoid errors on older firmwareDefensive hardening of wallet setup randomness verification
This commit is a routine cleanup that removes the old SCons build system files from the Trezor Core firmware repository. It deletes Makefiles, SConscripts, and related Python helper scripts, but does not change any firmware source code, cr…
This commit updates Trezor's embedded MicroPython interpreter from an older version to 1.28.0. It pulls in several upstream MicroPython bug fixes, including stricter buffer-size checks for converting integers to bytes, a new stack-safety A…
Synchronizes upstream MicroPython fixes that include buffer-size and stack-safety hardeningPrevents Ctrl+C interruption of frozen boot code, reducing denial-of-service/control-flow risk during bootFixes sys.stdout.buffer.write() return value, which could affect code relying on correct I/O semantics
This commit is a simple code cleanup that replaces a common MicroPython string-creation pattern with a new helper function. It does not change what the code does, only how it is written. There is no security issue visible in the change.
This is a large but straightforward internal cleanup: the project switched from using the MicroPython `ubinascii` module's `hexlify`/`unhexlify` functions to the standard Python `bytes.hex()` and `bytes.fromhex()` methods. The change remov…
This commit is a routine code cleanup in the Trezor firmware's embedded MicroPython modules. It replaces an older, two-step object allocation pattern with a newer helper that allocates memory and sets the object type in one step. The chang…
No security-relevant logic changes observedNo input validation changesNo memory safety bug fixes (e.g., no overflow, use-after-free, or uninitialized memory fixes)
This is a code cleanup change in Trezor's firmware that swaps one MicroPython internal helper for another. It replaces calls that create byte or string objects from a vstr buffer with newer, purpose-built helpers. The commit message says t…
Refactor only: helper function renames with equivalent semanticsNew str helper adds UTF-8 validation; bytes helper does not validateNo input validation, length, or error-handling changes observed
This commit is a routine internal cleanup that switches how Trezor's firmware defines built-in MicroPython object types. It replaces older, manually-written type structures with a newer macro provided by the upstream MicroPython project. T…
This commit is a large but purely mechanical code cleanup: it replaces the custom STATIC macro with the standard C keyword static across many MicroPython module files. There is no change to program logic, security boundaries, or behavior. …
This commit is a routine code cleanup that updates Trezor firmware to match a newer MicroPython version where built-in module names dropped the 'u' prefix (for example, 'uos' became 'os' and 'ustruct' became 'struct'). It renames imports, …
This commit only updates the firmware version number from 2.12.4 to 2.12.5 in the source code and translation files. It does not change any security-related logic, fix any bug, or alter any cryptographic behavior. It is a routine release b…
This is a routine build-system cleanup for the Trezor firmware. It switches the internal 'trezor_lib' Rust crate to be built with the project's own 'xbuild' tool, removes transitional feature flags, and reorganizes Cargo.toml files. There …
This commit adds Bluetooth Low Energy (BLE) support for the Trezor T3T2 hardware model. It introduces new board configuration files, pin mappings, build scripts, and firmware binaries for the Nordic nRF54LS05A BLE radio used in T3T2. There…
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
fix(tests): make `verify_cert_chain()` accept longer certificate chains
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
There is no need for calling `confirm_tx_data` and then `confirm_data_and_summary`, since we can do calldata streaming (while hashing and confirming) in `confirm_tx_data`.
[no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedfeat(nordic): add support for different NCS sdk versionsby tychovrahe · 253c4f87 · Jul 16, 2026 · 10 filesMessage 62 · AdequateTriage 12Details
Commit message · tychovrahe
feat(nordic): add support for different NCS sdk versions
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedrefactor(core/ethereum): handle staking/yielding in `confirm_tx_data()`by Roman Zeyde · 6c158b50 · Jul 15, 2026 · 4 filesMessage 85 · StrongTriage 12Details
Commit message · Roman Zeyde
refactor(core/ethereum): handle staking/yielding in `confirm_tx_data()`
This way, we don't need to call `get_progress_indicator()`, since all the data has been already loaded and hashed.
[no changelog]
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Currently, the length of all bounded strings is checked using len(str). This returns the number of Unicode code points. However, the XDR spec defines string object<m> as a sequence of at most m bytes, see https://datatracker.ietf.org/doc/html/rfc4506#section-4.11. A single Unicode code point can consist of multiple bytes.
[no changelog]
88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedrefactor(core/rust): don't panic if Rust layout is unavailableby Roman Zeyde · 3c4c5ae1 · Jul 15, 2026 · 1 fileMessage 93 · StrongTriage 0Details
Commit message · Roman Zeyde
refactor(core/rust): don't panic if Rust layout is unavailable
Following https://github.com/trezor/trezor-firmware/pull/7282, let's raise `RuntimeError` if the layout has been dropped too early (instead of panicking).
[no changelog]
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI review queuedrefactor(core/ethereum): rename and move keccak-related helper functionsby Roman Zeyde · dc2aadf6 · Jul 15, 2026 · 7 filesMessage 62 · AdequateTriage 12Details
Commit message · Roman Zeyde
refactor(core/ethereum): rename and move keccak-related helper functions
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedrefactor(core/ethereum): simplify `confirm_data_and_summary()`by Roman Zeyde · 814203e1 · Jul 14, 2026 · 2 filesMessage 77 · AdequateTriage 12Details
Note that `(confirm_data_chunk is None) == (confirm_summary is None)`.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedtest(core): wait for `Cancel` response before sending `Ping`by Roman Zeyde · a6bffbca · Jul 14, 2026 · 1 fileMessage 100 · StrongTriage 7Details
Commit message · Roman Zeyde
test(core): wait for `Cancel` response before sending `Ping`
Otherwise, we may get stuck when using USB transport: if the device is stuck sending, and not reading new messages from the host, the first write may get stuck - and the test will deadlock.
[no changelog]
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
tests: replace repeated xfail/suppresion by decorators
- Replaced repeated "optiga xfail" in `evolu/test_sign_registration` by a decorator. - Replaced repeated ephemeral key warning suppression in `thp/test-pairing` by marker alias.
[no changelog]
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedtest(core): try to avoid old emulators' crashing during upgrade testsby Roman Zeyde · 468b7d75 · Jul 10, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · Roman Zeyde
test(core): try to avoid old emulators' crashing during upgrade tests
Should help with https://github.com/trezor/trezor-firmware/issues/7052.
IIUC, #1725 was introduced to save memory, but it may crash the emulator if debuglink and wirelink are used at the same time.
[no changelog]
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI review queuedchore(python): remove remaining TrezorClientDebugLink references [no changelog]by Arnold K · 64601614 · Jul 8, 2026 · 3 filesMessage 93 · StrongTriage 12Details
- Remove stale docstring reference in debuglink.py - Drop obsolete snippet scripts sign_tx.py and unify_test_files.py - No changelog entry per trezor-firmware changelog guidelines
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedtest(core): don't fail codec_v1 `sync_responses()` on unexpected magicby Roman Zeyde · ddcea46b · Jul 7, 2026 · 2 filesMessage 99 · StrongTriage 7Details
Commit message · Roman Zeyde
test(core): don't fail codec_v1 `sync_responses()` on unexpected magic
Otherwise, pytest's session will be unnecessarily stopped.
Also, log the exception's traceback.
[no changelog]
99/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI review queuedchore(translations): sync Crowdin fixing French failing testsby Michal Kazda · 1c84feca · Jul 2, 2026 · 3 filesMessage 72 · AdequateTriage 0Details
Commit message · Michal Kazda
chore(translations): sync Crowdin fixing French failing tests
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI review queuedchore(translations): sync Crowdin fixing more French failing testsby Michal Kazda · 13b41359 · Jul 2, 2026 · 2 filesMessage 72 · AdequateTriage 0Details
Commit message · Michal Kazda
chore(translations): sync Crowdin fixing more French failing tests
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI review queuedfeat(core): set tropic configurationby Martin Pastyřík · 4a93242c · Jul 2, 2026 · 28 filesMessage 80 · StrongTriage 0Details
Commit message · Martin Pastyřík
feat(core): set tropic configuration
Set the configuration of Tropic to the value excpected by the firmware.
The current version of tropic configuration is stored in slot 6 of Tropic R memory data. During the setting process, slot 7 is temporarily used to store a backup of the configuration version.
Also refactor tropic configuration from prodtest into firmware and enable sensors setting in model_server.
[no changelog]
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context