Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…
Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…
Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.
This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …
This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…
NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…
Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
This commit is a simple rename from 'ProjectProfile' to 'ProjectConfig' in two Rust source files. It only changes variable names, struct names, and error messages. There is no change to program logic, security behavior, or how data is hand…
This commit is a straightforward internal code refactor in Trezor's build tooling. It introduces a new ResolvedBuildArgs structure that centralizes default values for command-line build options before they are used. There is no change to u…
This commit is a straightforward internal refactor of the Trezor firmware build tool's command-line argument handling. It changes many on/off flags from plain booleans to optional booleans so they can explicitly be set to true, false, or l…
This commit is a straightforward internal code reorganization in Trezor's build tooling. It moves build-option definitions from one Rust source file to a new module and adds the ability to load those options from a configuration file. Ther…
This commit is a developer tooling change for the Trezor firmware build system. It introduces 'build presets'—named configuration bundles stored in TOML files—so developers can select common build settings with a single command-line flag i…
This commit is a routine update to a build-system manifest file used by Trezor's internal tooling. It reorganizes and re-labels feature flags (for example, moving options between 'Features', 'Debugging', and 'Signing' groups and simplifyin…
This commit adds a single configuration file for a Trezor developer tool (a VS Code extension). It only points the tool to existing folders in the repository and contains no executable code, no secrets, and no changes to firmware behavior.…
This commit is a simple internal code cleanup: it renames a Rust data structure called ResolvedBuild to ResolvedBuildFeatures and updates the places that use it. There are no functional changes, no security fixes, and no changes to how the…
This is a tiny code cleanup commit that replaces two calls to `ptr::null()` with Rust's `unwrap_or_default()` to silence automated Clippy lint warnings. It does not change what value is produced (still a null pointer when no salt is provid…
This commit is a straightforward internal code cleanup in Trezor's build tooling. It moves a data structure and two helper methods from one Rust source file to another and updates callers accordingly. There is no change to user-facing beha…
This commit only adds documentation. It updates the table of contents and adds a new markdown page plus a diagram explaining the project's 'xtask' build helper. No code, build scripts, or firmware logic was changed, so it cannot introduce …
This commit is a build-system refactoring for Trezor firmware. It moves the mapping of command-line build options to Rust/cargo features out of hard-coded Rust logic and into per-project TOML files. It also adds a small change so debug bui…
Build-option mapping now lives in project.toml files, increasing the attack surface for supply-chain/build-configuration tamperingMakefile change automatically enables debug-link for PYOPT=0 debug buildsValidation added to reject storage_insecure_testing_mode in production builds
This commit fixes a filename-renaming step in the project's automated nightly build pipeline. It ensures ARM64 emulator files get the correct name expected by another testing tool. There is no change to the actual Trezor firmware code, dev…
This is a routine housekeeping change to reduce clutter in Git's status output for a third-party component (the MicroPython submodule). There is no indication it changes any code that runs on the Trezor device or affects security.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 16/100
This commit fixes a logging bug in Trezor firmware's debug console output. Previously, the code used a width specifier to print a log source name, which could read past the end of a string that isn't null-terminated. The fix switches to a precision specifier that respects the known length. This is a defensive correctness fix in debug-only logging code; there is no direct evidence it is exploitable as a security vulnerability.
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply updates the project's protobuf dependency from an old version (3.19) to a newer one (6.32) and pins the Python package version to match. There are no code changes, no bug fixes, and no security patches visible in the diff. It is a routine build/dependency maintenance change.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update pathauthentication path
AI analysis · Informational 15/100
This commit only regenerates Rust source files from protobuf definitions using a newer version of the protoc compiler (31.1 instead of 3.19.6). The only visible changes are updated version comments and a few reordered bytes inside generated metadata. There is no change to message logic, security behavior, or how the Trezor device handles data.
- Closed PRs (without merge) moved directly to "Done (no QA)" state. - Merged PRs with "no-QA" label moved to "Done (no QA)" state. - Merged PRs without "no-QA" label moved to "Needs QA" state.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit adds a GitHub Actions bot that automatically moves closed pull requests to the correct column on a project board. It is purely a workflow automation change for project management and has nothing to do with the Trezor firmware code, device security, or user funds.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 41/100
This commit adds memory-protection reconfiguration around the NFC interrupt handler in Trezor hardware wallets. The change ensures the interrupt handler runs with default memory permissions, then restores the previous protection state afterward. It is a hardening fix rather than a clear-cut patch for an actively exploitable vulnerability, but missing MPU setup in an interrupt handler could theoretically allow memory-access bugs or privilege issues during NFC operations.
Lower-priorityrefactor(core): improve NFC driver for better compatibility across various ST chipsby tychovrahe · c46fa9b9 · Apr 21, 2026 · 1 fileMessage 62 · AdequateInformational 16Details
Commit message · tychovrahe
refactor(core): improve NFC driver for better compatibility across various ST chips
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 16/100
This commit renames an NFC driver to be chip-agnostic and reorders its startup steps so the interrupt line is configured before the NFC controller is initialized, then cleared again after. It also swaps a flag-clearing macro for a more correct interrupt-clearing macro. These are defensive housekeeping changes that reduce the chance of a stale interrupt firing at the wrong moment during startup. There is no direct evidence this fixes an exploitable security bug.
fix(core/prodtest): handle return values in NFC test
[no changelog]
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 19/100
This commit fixes a small coding issue in Trezor's factory production-test tool for NFC hardware. Previously, two NFC setup functions were called without checking whether they succeeded. Now the code checks their return values and reports a fatal error if they fail, then jumps to cleanup. This is a defensive quality improvement in a diagnostic/testing utility, not a fix for an exploitable security vulnerability in the wallet firmware itself.
AI review queuedrefactor(core): refactor NFC driver to allow easier support for different ST chipsby tychovrahe · e0132169 · Apr 21, 2026 · 76 filesMessage 62 · AdequateInformational 15Details
Commit message · tychovrahe
refactor(core): refactor NFC driver to allow easier support for different ST chips
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100
This commit is a large code reorganization of the NFC (Near Field Communication) driver inside Trezor firmware. It moves the ST25R3916 RFAL library from one directory to another and updates build paths and board configuration files accordingly. There is no indication in the commit message or diff that this fixes a security vulnerability; it is described as a refactoring to make it easier to support different STMicroelectronics chips in the future. The change is mostly a directory rename plus path updates, with no functional security fix visible in the diff.
feat(core): allow disabling button on Eckhart `show_info()` layout
It will be used for N4W1 I/O layouts.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 19/100
This commit is a routine user-interface feature change for Trezor hardware wallets. It lets the new 'Eckhart' screen layout optionally show an information screen with a disabled button (for example, a grayed-out 'Continue' that becomes active only after a timer or condition). Older layouts keep their previous behavior. There is no direct evidence in the commit that this fixes a security vulnerability; it reads as a product/usability feature.
Security candidatefeat(core): allow external menu on Eckhart `show_info()` layoutby Roman Zeyde · bdf29e95 · Apr 21, 2026 · 7 filesMessage 77 · AdequateInformational 15Details
Commit message · Roman Zeyde
feat(core): allow external menu on Eckhart `show_info()` layout
It will be used for N4W1 I/O layouts.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 15/100
This commit is a routine user-interface feature addition for the Trezor hardware wallet firmware. It adds an optional 'external menu' flag to the 'show_info' screen layout, primarily for a new device design (Eckhart/N4W1). On older layouts, the flag is rejected with a 'not implemented' error. There is no security-relevant change visible in the code.
refactor(core): scope `LayoutObj` lifetime at `request_word()`
Previously it was done using an explicit call to `LayoutObj.__del__()`.
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100
This commit is a small code cleanup in the Trezor hardware wallet firmware. It changes how on-screen keyboards are managed during wallet recovery (when users type in their backup seed words). Previously, the code explicitly called a destructor-like method `keyboard.__del__()` inside a try/finally block to ensure cleanup. Now it uses Python's `with keyboard:` context manager, which is a more standard and safer way to guarantee cleanup happens. There is no direct evidence this fixes a security vulnerability.
Fixes #6780 (OOM on T3T1 during large input data confirmation).
Explicitly drop internal Rust layout object, in order to avoid https://github.com/trezor/trezor-firmware/issues/5472#issuecomment-3262594686
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 60/100
This update fixes a memory issue in Trezor hardware wallets that could crash the device (out-of-memory) when confirming very large pieces of on-screen data. The fix ensures a temporary screen-layout object is explicitly released after use, rather than lingering in memory. It is a reliability/availability fix rather than a direct theft-of-funds vulnerability.
Lower-priorityrefactor(core): use `HomescreenBase` as a context managerby Roman Zeyde · f72da9e8 · Apr 20, 2026 · 4 filesMessage 77 · AdequateInformational 18Details
Commit message · Roman Zeyde
refactor(core): use `HomescreenBase` as a context manager
Instead of explicitly invoking `__del__()` to drop its `LayoutObj`.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 18/100
This commit is a code cleanup: it replaces explicit calls to a destructor-like method with Python's standard 'with' context-manager pattern for homescreen objects. It does not add or remove security behavior; it only makes the cleanup more reliable and idiomatic. There is no indication this fixes an exploitable vulnerability.
It enables waking the T3W1 device up by display touch from suspend mode: - Adding display suspend/resume functionality because, until now, the display driver has controlled the PWREN MOSFET and RESET signals, which are shared with the touch driver logic. - Since it's not possible to switch the display off, it's put into deep standby mode, from which only an external HW reset can wake it up. - The touch controller is being used in "monitor" mode, which can detect a touch event and generate an INT signal to wake the MCU. Once touched, the controller switches to active mode. - Adding the "TOUCH_WAKEUP_ENABLED" macro and preprocessor-based conditional compilation for controlling whether this feature is enabled/disabled in the build (it's preparation for "checkbox"-based enabling/disabling control).
[no changelog]
92/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 13/100
This commit adds a new hardware feature for the Trezor T3W1 device that lets the user wake the device from suspend mode by touching the screen. It changes how the display and touch drivers are turned off and back on, and adds a new wake-up flag for touch events. The feature is currently disabled by default in the build configuration (TOUCH_WAKEUP_ENABLED is set to 0). There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a normal feature addition.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit is a straightforward code cleanup. It removes a header file include in a C file and replaces it with a direct declaration of a Rust-implemented function, while removing that same declaration from a shared header. The change breaks a circular dependency between the low-level graphics code and the Rust UI layer. There is no functional change to how errors are displayed, no bug fix, and no security-relevant behavior change.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Moderate 59/100
This commit fixes the TrustZone security configuration on the STM32U5 chip used in Trezor hardware wallets. TrustZone splits the processor into a secure world (for secrets like the seed and PIN) and a non-secure world (for the main user interface). The patch makes three changes: it temporarily disables the Security Attribution Unit (SAU) while reprogramming it, adds memory barriers so the new rules take effect correctly, and marks one DMA channel's interrupt as secure. Without these fixes, secure memory regions could potentially be reachable from non-secure code, or security settings might not be applied reliably during boot.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only changes how the software development library SDL is included in source files for the Unix emulator build. It replaces generic include paths like <SDL.h> with versioned paths like <SDL2/SDL.h> and moves some includes outside a conditional block. There is no security-relevant change to the actual code logic, and no indication this fixes a vulnerability.
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 16/100
This is a routine cleanup commit in Trezor's embedded firmware. It mostly adds or tightens conditional compilation guards (so certain security-related code only compiles in secure/kernel builds), removes unused header includes, fixes a minor function declaration, and replaces a traditional header include guard with a simpler pragma. There is no direct evidence of an exploitable vulnerability being patched, and the commit message explicitly calls these 'minor fixes' with no changelog entry.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 21/100
This commit adjusts how the production-test firmware for three Trezor hardware models calculates the length of the code image stored in flash memory. The old calculation added up the sizes of individual sections, which could become inaccurate if the linker layout changed. The new calculation uses a single marker placed at the actual end of the code/data in flash. This is a hardening improvement rather than a fix for an active attack, but an incorrect code-length value could theoretically cause a mis-sized firmware image to be written or verified during manufacturing tests.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 26/100
This commit fixes a small but real bug in the Trezor emulator (the desktop/Unix version used for testing, not the real hardware wallet). When the emulator tries to shut down a MicroPython task, it previously ignored whether the internal 'push call' operation succeeded. If that operation failed, the code would still try to switch to the task, potentially leaving the emulator in an inconsistent or hung state. The fix adds an explicit error shutdown if the push fails. It is a hardening fix rather than a clear exploitable vulnerability, and it only affects the Unix emulator build.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 17/100
This is a code cleanup change in Trezor's embedded firmware. It moves display de-initialization logic into a new compatibility helper file and renames a clock-setting function to make the code clearer. There is no direct evidence in the commit that this fixes an active security vulnerability; it appears to be a refactoring to remove a circular dependency between system startup code and the display driver.
Lower-priorityfix(prodtest): remove st hal calls from prodtest emulatorby cepetr · 1f4e6f0d · Apr 20, 2026 · 1 fileMessage 62 · AdequateInformational 18Details
Commit message · cepetr
fix(prodtest): remove st hal calls from prodtest emulator
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 18/100
This commit fixes a build or runtime problem in the Trezor hardware wallet's production-test firmware when it is compiled for the software emulator. It wraps real hardware calls (deinitializing the Bluetooth module and UART, resetting the NRF chip, and entering direct test mode) inside a check that skips them on the emulator. There is no direct user security impact; it is a build/test-harness fix.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only adds Rust compiler directives to silence warnings about unused macros and imports. It does not change any program behavior, fix a bug, or address a security issue.
feat(core): add core/build-xtask folder into .gitgnore
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply adds a new build output folder named 'build-xtask' to the .gitignore file in the Trezor firmware repository. A .gitignore file tells Git which files and folders to ignore and not track in version control. This change has no effect on the actual firmware code, device behavior, or security of the product. It is a routine housekeeping change for developers.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 18/100
This commit fixes a type mismatch in the Trezor firmware emulator's bootloader code. The FIRMWARE_START symbol was declared as a pointer to bytes (uint8_t*) but was being assigned a raw memory address value. On 64-bit emulator builds this could lead to incorrect memory handling or crashes because the sizes and interpretations of the two types differ. The fix changes the symbol to a plain integer address type (uintptr_t), which is the correct way to store raw memory addresses in portable C code. This change only affects the emulator (software simulation), not real Trezor hardware.