← Watch feed
test(rust/trezor-thp): crc32 vectors from test_trezor.wire.thp.checksum
Public commit record
72/100 · Adequate
What the developer wrote
Authored by Martin Milata
test(rust/trezor-thp): crc32 vectors from test_trezor.wire.thp.checksum
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
What changed, and why it matters
This commit only adds more test cases and removes two unused helper functions for verifying CRC32 checksums. It does not change the actual CRC32 calculation logic, nor does it fix any security issue. There is nothing here that would allow an attacker to exploit a Trezor device.
Recommended action
No security action required; this is a routine test-only commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff expands unit tests in rust/trezor-thp/src/crc32.rs with additional CRC32 test vectors borrowed from test_trezor.wire.thp.checksum and adds a chunked-update test. It also deletes verify_payload and verify helpers, which appear unused. The core digest and Crc32 implementation are untouched. No security patch is present.
Changed components
rust/trezor-thp/src/crc32.rsInspect captured patch +102 / −10
diff --git a/rust/trezor-thp/src/crc32.rs b/rust/trezor-thp/src/crc32.rs
index 27219a40..d1a990e7 100644
--- a/rust/trezor-thp/src/crc32.rs
+++ b/rust/trezor-thp/src/crc32.rs
@@ -36,24 +36,16 @@ pub fn digest(data: &[u8]) -> [u8; CHECKSUM_LEN] {
crc.finalize()
}
-pub fn verify_payload(buffer: &[u8]) -> Option<&[u8]> {
- let (payload, digest_in) = buffer.split_last_chunk::<CHECKSUM_LEN>()?;
- let digest_computed = digest(payload);
- (digest_computed == *digest_in).then_some(payload)
-}
-
-pub fn verify(data: &[u8]) -> bool {
- verify_payload(data).is_some()
-}
-
#[cfg(test)]
mod test {
use super::*;
const CRC32_VECTORS: &[(&[u8], &str)] = &[
(b"", "00000000"),
+ (&[0; 32], "190a55ad"),
(b"a", "e8b7be43"),
(b"abc", "352441c2"),
+ (b"123456789", "cbf43926"),
(b"message digest", "20159d7f"),
(b"abcdefghijklmnopqrstuvwxyz", "4c2750bd"),
(
@@ -64,6 +56,94 @@ mod test {
b"12345678901234567890123456789012345678901234567890123456789012345678901234567890",
"7ca94a72",
),
+ (
+ &[
+ 0x76, 0x61, 0x72, 0x69, 0x6f, 0x75, 0x73, 0x20, 0x43, 0x52, 0x43, 0x20, 0x61, 0x6c,
+ 0x67, 0x6f, 0x72, 0x69, 0x74, 0x68, 0x6d, 0x73, 0x20, 0x69, 0x6e, 0x70, 0x75, 0x74,
+ 0x20, 0x64, 0x61, 0x74, 0x61,
+ ],
+ "9bd366ae",
+ ),
+ (
+ &[
+ 0x67, 0x3a, 0x5f, 0x0e, 0x39, 0xc0, 0x3c, 0x79, 0x58, 0x22, 0x74, 0x76, 0x64, 0x9e,
+ 0x36, 0xe9, 0x0b, 0x04, 0x8c, 0xd2, 0xc0, 0x4d, 0x76, 0x63, 0x1a, 0xa2, 0x17, 0x85,
+ 0xe8, 0x50, 0xa7, 0x14, 0x18, 0xfb, 0x86, 0xed, 0xa3, 0x59, 0x2d, 0x62, 0x62, 0x49,
+ 0x64, 0x62, 0x26, 0x12, 0xdb, 0x95, 0x3d, 0xd6, 0xb5, 0xca, 0x4b, 0x22, 0x0d, 0xc5,
+ 0x78, 0xb2, 0x12, 0x97, 0x8e, 0x54, 0x4e, 0x06, 0xb7, 0x9c, 0x90, 0xf5, 0xa0, 0x21,
+ 0xa6, 0xc7, 0xd8, 0x39, 0xfd, 0xea, 0x3a, 0xf1, 0x7b, 0xa2, 0xe8, 0x71, 0x41, 0xd6,
+ 0xcb, 0x1e, 0x5b, 0x0e, 0x29, 0xf7, 0x0c, 0xc7, 0x57, 0x8b, 0x53, 0x20, 0x1d, 0x2b,
+ 0x41, 0x1c, 0x25, 0xf9, 0x07, 0xbb, 0xb4, 0x37, 0x79, 0x6a, 0x13, 0x1f, 0x6c, 0x43,
+ 0x71, 0xc1, 0x1e, 0x70, 0xe6, 0x74, 0xd3, 0x9c, 0xbf, 0x32, 0x15, 0xee, 0xf2, 0xa7,
+ 0x86, 0xbe, 0x59, 0x99, 0xc4, 0x10, 0x09, 0x8a, 0x6a, 0xaa, 0xd4, 0xd1, 0xd0, 0x71,
+ 0xd2, 0x06, 0x1a, 0xdd, 0x2a, 0xa0, 0x08, 0xeb, 0x08, 0x6c, 0xfb, 0xd2, 0x2d, 0xfb,
+ 0xaa, 0x72, 0x56, 0xeb, 0xd1, 0x92, 0x92, 0xe5, 0x0e, 0x95, 0x67, 0xf8, 0x38, 0xc3,
+ 0xab, 0x59, 0x37, 0xe6, 0xfd, 0x42, 0xb0, 0xd0, 0x31, 0xd0, 0xcb, 0x8a, 0x66, 0xce,
+ 0x2d, 0x53, 0x72, 0x1e, 0x72, 0xd3, 0x84, 0x25, 0xb0, 0xb8, 0x93, 0xd2, 0x61, 0x5b,
+ 0x32, 0xd5, 0xe7, 0xe4, 0x0e, 0x31, 0x11, 0xaf, 0xdc, 0xb4, 0xb8, 0xee, 0xa4, 0x55,
+ 0x16, 0x5f, 0x78, 0x86, 0x8b, 0x50, 0x4d, 0xc5, 0x6d, 0x6e, 0xfc, 0xe1, 0x6b, 0x06,
+ 0x5b, 0x37, 0x84, 0x2a, 0x67, 0x95, 0x28, 0x00, 0xa4, 0xd1, 0x32, 0x9f, 0xbf, 0xe1,
+ 0x64, 0xf8, 0x17, 0x47, 0xe1, 0xad, 0x8b, 0x72, 0xd2, 0xd9, 0x45, 0x5b, 0x73, 0x43,
+ 0x3c, 0xe6, 0x21, 0xf7, 0x53, 0xa3, 0x73, 0xf9, 0x2a, 0xb0, 0xe9, 0x75, 0x5e, 0xa6,
+ 0xbe, 0x9a, 0xad, 0xfc, 0xed, 0xb5, 0x46, 0x5b, 0x9f, 0xa9, 0x5a, 0x4f, 0xcb, 0xb6,
+ 0x60, 0x96, 0x31, 0x91, 0x42, 0xca, 0xaf, 0xee, 0xa5, 0x0c, 0xe0, 0xab, 0x3e, 0x83,
+ 0xb8, 0xac, 0x88, 0x10, 0x2c, 0x63, 0xd3, 0xc9, 0xd2, 0xf2, 0x44, 0xef, 0xea, 0x3d,
+ 0x19, 0x24, 0x3c, 0x5b, 0xe7, 0x0c, 0x52, 0xfd, 0xfe, 0x47, 0x41, 0x14, 0xd5, 0x4c,
+ 0x67, 0x8d, 0xdb, 0xe5, 0xd9, 0xfa, 0x67, 0x9c, 0x06, 0x31, 0x01, 0x92, 0xba, 0x96,
+ 0xc4, 0x0d, 0xef, 0xf7, 0xc1, 0xe9, 0x23, 0x28, 0x0f, 0xae, 0x27, 0x9b, 0xff, 0x28,
+ 0x0b, 0x3e, 0x85, 0x0c, 0xae, 0x02, 0xda, 0x27, 0xb6, 0x04, 0x51, 0x04, 0x43, 0x04,
+ 0x99, 0x8c, 0xa3, 0x97, 0x1d, 0x84, 0xec, 0x55, 0x59, 0xfb, 0xf3, 0x84, 0xe5, 0xf8,
+ 0x40, 0xf8, 0x5f, 0x81, 0x65, 0x92, 0x4c, 0x92, 0x7a, 0x07, 0x51, 0x8d, 0x6f, 0xff,
+ 0x8d, 0x15, 0x36, 0x5c, 0x57, 0x7a, 0x5b, 0x3a, 0x63, 0x1c, 0x87, 0x65, 0xee, 0x54,
+ 0xd5, 0x96, 0x50, 0x73, 0x1a, 0x9c, 0xff, 0x59, 0xe5, 0xea, 0x6f, 0x89, 0xd2, 0xbb,
+ 0xa9, 0x6a, 0x12, 0x21, 0xf5, 0x08, 0x8e, 0x8a, 0xc0, 0xd8, 0xf5, 0x14, 0xe9, 0x9d,
+ 0x7e, 0x99, 0x13, 0x88, 0x29, 0xa8, 0xb4, 0x22, 0x2a, 0x41, 0x7c, 0xc5, 0x10, 0xdf,
+ 0x11, 0x5e, 0xf8, 0x8d, 0x0e, 0xd9, 0x98, 0xd5, 0xaf, 0xa8, 0xf9, 0x55, 0x1e, 0xe3,
+ 0x29, 0xcd, 0x2c, 0x51, 0x7b, 0x8a, 0x8d, 0x52, 0xaa, 0x8b, 0x87, 0xae, 0x8e, 0xb2,
+ 0xfa, 0x31, 0x27, 0x60, 0x90, 0xcb, 0x01, 0x6f, 0x7a, 0x79, 0x38, 0x04, 0x05, 0x7c,
+ 0x11, 0x79, 0x10, 0x40, 0x33, 0x70, 0x75, 0xfd, 0x0b, 0x88, 0xa5, 0xcd, 0x35, 0xd8,
+ 0xa6, 0x3b, 0xb0, 0x45, 0x82, 0x64, 0xd1, 0xb5, 0xdc, 0x06, 0xc9, 0x89, 0xf4, 0x16,
+ 0x3e, 0xc7, 0xb3, 0xf1, 0x9d, 0xd3, 0xc5, 0xe3, 0xaf, 0xe8, 0x25, 0x86, 0x7a, 0x4a,
+ 0xfd, 0x10, 0x5d, 0x20, 0xe5, 0x76, 0x5a, 0x22, 0x5f, 0x8f, 0xbc, 0xaa, 0x97, 0xee,
+ 0xf2, 0xc2, 0x4c, 0x0e, 0xdc, 0x7b, 0xc4, 0xee, 0x53, 0xa3, 0xe0, 0xfa, 0xcd, 0x1e,
+ 0x4e, 0x54, 0x1d, 0x5e, 0xe1, 0x51, 0x17, 0x1f, 0x1a, 0x75, 0x7f, 0xed, 0x12, 0xd7,
+ 0xf7, 0xe3, 0x18, 0x56, 0x24, 0xcf, 0xc6, 0x96, 0x30, 0x77, 0x0d, 0x73, 0x98, 0x9c,
+ 0x09, 0x69, 0xa3, 0xbc, 0x96, 0x5e, 0xaf, 0xde, 0x76, 0xa4, 0x66, 0x04, 0x6b, 0x36,
+ 0x2a, 0xac, 0x6d, 0x37, 0xf8, 0x1e, 0xe1, 0x2a, 0x3e, 0x42, 0x2d, 0x1d, 0xe6, 0x46,
+ 0xdd, 0x28, 0xb9, 0x08, 0x44, 0xa1, 0x9e, 0xb2, 0x22, 0x7a, 0x45, 0x8a, 0x37, 0x39,
+ 0x74, 0xb4, 0xae, 0xc8, 0x3b, 0x40, 0xf7, 0xec, 0xbf, 0xfd, 0xe5, 0xde, 0xb2, 0x83,
+ 0x5e, 0xa4, 0x46, 0x19, 0xa6, 0x9d, 0xb0, 0xe8, 0x76, 0x80, 0xbd, 0xc1, 0x80, 0x7a,
+ 0xd9, 0xeb, 0xe7, 0x90, 0x5b, 0x81, 0x25, 0x21, 0xd9, 0x5b, 0x4a, 0x80, 0x48, 0x92,
+ 0x71, 0x77, 0x04, 0xb2, 0xac, 0x05, 0xc9, 0xdf, 0x5e, 0x44, 0x5a, 0xae, 0x6e, 0xb3,
+ 0xd8, 0x30, 0x5e, 0xdc, 0x77, 0x2f, 0x79, 0xc2, 0x8e, 0x8b, 0x28, 0x24, 0x06, 0x1b,
+ 0x6f, 0x8d, 0x88, 0x53, 0x80, 0x55, 0x0c, 0x3a, 0x7b, 0x85, 0xb8, 0x96, 0x85, 0xe9,
+ 0xf0, 0x57, 0x63, 0xfe, 0x32, 0x80, 0xff, 0x57, 0xc9, 0x3c, 0xdb, 0xf6, 0xcd, 0x67,
+ 0x14, 0x47, 0x6c, 0x43, 0x3d, 0x6d, 0x48, 0x3f, 0x9c, 0x00, 0x60, 0x0e, 0xf5, 0x94,
+ 0xe4, 0x52, 0x97, 0x86, 0xcd, 0xac, 0xbc, 0xe4, 0xe3, 0xe7, 0xee, 0xa2, 0x91, 0x6e,
+ 0x92, 0xbb, 0xd1, 0x55, 0x0c, 0x5c, 0x0d, 0x63, 0xdb, 0x6b, 0xb8, 0x6e, 0x45, 0x48,
+ 0x0f, 0xdf, 0x44, 0x48, 0xd2, 0xf5, 0xf7, 0x4d, 0x7b, 0xd4, 0x4d, 0xd3, 0xcd, 0xcd,
+ 0x5b, 0x40, 0x60, 0xb1, 0xb2, 0x8e, 0xc9, 0x9a, 0x65, 0xc5, 0x06, 0x24, 0xcf, 0xe9,
+ 0xcc, 0x5e, 0x2c, 0x49, 0x47, 0x38, 0x45, 0x5d, 0xc5, 0xc0, 0x0d, 0x8a, 0x07, 0x1c,
+ 0xb3, 0xbb, 0xb1, 0x69, 0xf5, 0x6d, 0x0e, 0x9c, 0x96, 0x14, 0x93, 0x58, 0x0c, 0xc9,
+ 0x48, 0x74, 0xfc, 0x35, 0xda, 0x7d, 0x4e, 0x32, 0x73, 0xa3, 0x77, 0x4a, 0x9e, 0xc5,
+ 0xd1, 0x08, 0xfe, 0xa6, 0xa0, 0xf1, 0x66, 0x72, 0xea, 0xc7, 0xae, 0x21, 0x81, 0x0e,
+ 0x8a, 0xba, 0x99, 0x06, 0x97, 0xfc, 0xc6, 0x2b, 0x69, 0x53, 0xc6, 0x67, 0xec, 0x5d,
+ 0xa1, 0xfc, 0xa1, 0x3b, 0xdd, 0x2a, 0xd6, 0x8f, 0x31, 0xa7, 0x8d, 0xec, 0xfe, 0x0a,
+ 0x3b, 0x6b, 0x39, 0x70, 0x70, 0x09, 0x72, 0x12, 0xbc, 0x84, 0x67, 0xca, 0xd2, 0x4a,
+ 0x17, 0x33, 0x94, 0x45, 0x25, 0xc7, 0xfd, 0x1e, 0xa2, 0x4a, 0x9e, 0x27, 0x9d, 0xfb,
+ 0x87, 0xea, 0xe4, 0xfd, 0xb0, 0x11, 0x06, 0x9d, 0x72, 0xb9, 0x1d, 0xea, 0x9b, 0x81,
+ 0x2e, 0x6a, 0x36, 0x76, 0x62, 0xfa, 0xbe, 0x96, 0x67, 0x7d, 0x35, 0xdd, 0x5e, 0x5c,
+ 0x4f, 0x41, 0x0d, 0xce, 0xdb, 0x13, 0xb0, 0x46, 0x89, 0x92, 0x45, 0x02, 0x39, 0x0f,
+ 0xe6, 0xd1, 0x20, 0x96, 0x1c, 0x34, 0x00, 0x8c, 0xc9, 0xdf, 0xe3, 0xf0, 0xb6, 0x92,
+ 0x3a, 0xda, 0x5c, 0x96, 0xd9, 0x0b, 0x7d, 0x57, 0xf5, 0x78, 0x11, 0xc0, 0xcf, 0xbf,
+ 0xb0, 0x92, 0x3d, 0xe5, 0x6a, 0x67, 0x34, 0xce, 0xd9, 0x16, 0x08, 0xa0, 0x09, 0x42,
+ 0x0b, 0x07, 0x13, 0x7c, 0x73, 0x0c, 0xc6, 0x50, 0x17, 0x42, 0xcf, 0xd9, 0x85, 0xd9,
+ 0x23, 0x3c, 0xb1, 0x40, 0x40, 0x0f, 0x94, 0x20, 0xed, 0x2d, 0xbf, 0x10, 0x44, 0x6e,
+ 0x64, 0x65, 0xe5, 0x1d, 0x5f, 0xec, 0x24, 0xd8, 0x4b, 0xe8, 0xc2, 0xfb, 0x06, 0x11,
+ 0x24, 0x3f, 0xdf, 0x54, 0x2d, 0xe8, 0x4d, 0xc2, 0x1c, 0x27, 0x11, 0xb8, 0xb3, 0xd4,
+ ],
+ "6ba4ec92",
+ ),
];
#[test]
@@ -80,4 +160,16 @@ mod test {
assert_eq!(out_hex, *expected);
}
}
+
+ #[test]
+ fn test_chunks() {
+ for chunk_size in [1, 2, 3, 4] {
+ for (data, expected) in CRC32_VECTORS {
+ let mut crc = Crc32::new();
+ data.chunks(chunk_size).for_each(|c| crc.update(c));
+ let out_hex = hex::encode(crc.finalize());
+ assert_eq!(out_hex, *expected);
+ }
+ }
+ }
}
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.