Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…
Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…
Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.
This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …
This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…
NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…
Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
This commit is a simple rename from 'ProjectProfile' to 'ProjectConfig' in two Rust source files. It only changes variable names, struct names, and error messages. There is no change to program logic, security behavior, or how data is hand…
This commit is a straightforward internal code refactor in Trezor's build tooling. It introduces a new ResolvedBuildArgs structure that centralizes default values for command-line build options before they are used. There is no change to u…
This commit is a straightforward internal refactor of the Trezor firmware build tool's command-line argument handling. It changes many on/off flags from plain booleans to optional booleans so they can explicitly be set to true, false, or l…
This commit is a straightforward internal code reorganization in Trezor's build tooling. It moves build-option definitions from one Rust source file to a new module and adds the ability to load those options from a configuration file. Ther…
This commit is a developer tooling change for the Trezor firmware build system. It introduces 'build presets'—named configuration bundles stored in TOML files—so developers can select common build settings with a single command-line flag i…
This commit is a routine update to a build-system manifest file used by Trezor's internal tooling. It reorganizes and re-labels feature flags (for example, moving options between 'Features', 'Debugging', and 'Signing' groups and simplifyin…
This commit adds a single configuration file for a Trezor developer tool (a VS Code extension). It only points the tool to existing folders in the repository and contains no executable code, no secrets, and no changes to firmware behavior.…
This commit is a simple internal code cleanup: it renames a Rust data structure called ResolvedBuild to ResolvedBuildFeatures and updates the places that use it. There are no functional changes, no security fixes, and no changes to how the…
This is a tiny code cleanup commit that replaces two calls to `ptr::null()` with Rust's `unwrap_or_default()` to silence automated Clippy lint warnings. It does not change what value is produced (still a null pointer when no salt is provid…
This commit is a straightforward internal code cleanup in Trezor's build tooling. It moves a data structure and two helper methods from one Rust source file to another and updates callers accordingly. There is no change to user-facing beha…
This commit only adds documentation. It updates the table of contents and adds a new markdown page plus a diagram explaining the project's 'xtask' build helper. No code, build scripts, or firmware logic was changed, so it cannot introduce …
This commit is a build-system refactoring for Trezor firmware. It moves the mapping of command-line build options to Rust/cargo features out of hard-coded Rust logic and into per-project TOML files. It also adds a small change so debug bui…
Build-option mapping now lives in project.toml files, increasing the attack surface for supply-chain/build-configuration tamperingMakefile change automatically enables debug-link for PYOPT=0 debug buildsValidation added to reject storage_insecure_testing_mode in production builds
This commit fixes a filename-renaming step in the project's automated nightly build pipeline. It ensures ARM64 emulator files get the correct name expected by another testing tool. There is no change to the actual Trezor firmware code, dev…
This is a routine housekeeping change to reduce clutter in Git's status output for a third-party component (the MicroPython submodule). There is no indication it changes any code that runs on the Trezor device or affects security.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 37/100
This commit adds support for ERC-4626 vault reward claims and changes how Trezor handles Ethereum transactions with extra trailing bytes (calldata suffix). Previously, vault transactions with any trailing bytes were rejected as errors. Now, the device accepts them but shows the extra bytes to the user as a 'Calldata suffix' screen. The change also introduces a new 'claim' function path, but the actual claim UI is stubbed out and returns None (disabled) for now. The commit is a feature addition, not a documented security fix, but it touches transaction parsing and user confirmation flows.
AI review queuedfix(l10n): various en strings improvements [no changelog]by Michal Kazda · 7c014e24 · Apr 27, 2026 · 12 filesMessage 77 · AdequateInformational 15Details
Commit message · Michal Kazda
fix(l10n): various en strings improvements [no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a routine language and translation update for the Trezor hardware wallet firmware. It changes English wording (for example, 'Input data' becomes 'Data', 'Access passphrase wallet' becomes 'Access Passphrase wallet'), removes some trailing colons from prompts, and updates the generated translation tables and test fixtures accordingly. There is no code behavior change, no security fix, and no vulnerability.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 12/100
This commit is a code cleanup in the Trezor firmware's bootloader startup system. It replaces a fixed-size on-stack certificate buffer with a new 'reserve/commit/discard' API that lets the bootloader allocate space for the MCU attestation certificate directly in the shared startup-arguments buffer. There is no indication in the commit or supplied references that this fixes a security bug; it appears to be a defensive refactor to avoid large stack buffers and make the API more flexible.
chore(core): add `{0} / {1} bytes` to translation strings
Also, move streaming blob confirmation into universal FW.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is a routine user-interface cleanup. It adds new translation strings for showing Ethereum transaction data size (for example, "Input data: 12 / 100 bytes") and moves the code that displays streaming data chunks so it can be shared across all Trezor firmware variants. There is no security-relevant change visible in the code.
refactor(core): enforce layout scoping for `flow_get_address`
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 11/100
This is a small internal code cleanup in the Trezor firmware's user-interface layer. It changes how the 'show address' screen is wrapped so that the layout object is managed within a scoped context manager rather than passed directly to a helper function. There is no indication this fixes a security bug or changes user-visible behavior.
Security candidaterefactor(core): enforce layout scoping for keyboards and select_menuby Roman Zeyde · 49194736 · Apr 24, 2026 · 6 filesMessage 97 · StrongInformational 23Details
Commit message · Roman Zeyde
refactor(core): enforce layout scoping for keyboards and select_menu
Introduce `LayoutContext` type, which will be returned by some Rust layout factory functions. In order to get a `LayoutObj`, it has to be used as a context manager - thus enforcing proper layout scoping.
The change will be gradually introduced, since some UI flows require more refactoring.
[no changelog]
97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 23/100
This is a code cleanup change in the Trezor hardware wallet's user-interface layer. It introduces a new 'LayoutContext' wrapper so that on-screen keyboards and menus are always used inside a 'with' block, ensuring their memory is released promptly. The commit itself does not claim to fix a security bug, but it references an internal issue (#6811) about lifetime management, suggesting it is a defensive step against possible UI object lifetime problems.
AI review queuedchore(deps): bump protobuf from 6.32 to 6.33.5by dependabot[bot] · a15a0f63 · Apr 24, 2026 · 2 filesMessage 88 · StrongInformational 15Details
Commit message · dependabot[bot]
chore(deps): bump protobuf from 6.32 to 6.33.5
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 6.32 to 6.33.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
This is a routine automated dependency update by Dependabot, bumping the pinned Python protobuf package from version 6.32 to 6.33.5. The change only edits two version pins in project configuration files and contains no code changes. There is no indication in the commit that this fixes or introduces a security issue.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Moderate 59/100
This commit fixes a bug in how the Trezor hardware wallet's secure chip (Optiga) handles masked digital signatures. The fix changes two things: it now uses the actual returned signature length rather than the maximum buffer size when parsing the signature, and it explicitly uses the NIST P-256 curve instead of a variable curve parameter when removing the masking. The bug could potentially cause signature parsing to fail or behave incorrectly, especially if the returned signature was shorter than the maximum expected size. There is no public statement linking this to an active security vulnerability or attack.
feat(core): Add MCU device attestation with ML-DSA-44.
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trustcryptography-sensitive pathboot or update pathauthentication path
AI analysis · Informational 21/100
This commit adds a new hardware-based device authentication feature for the Trezor T3W1 model. It lets the device prove its identity using a cryptographic certificate and signing key stored in the microcontroller (MCU). The change is a feature addition, not a fix for a known vulnerability. There is no evidence in the commit or supplied references that this resolves an active security issue or introduces a new attack path.
feat(core): Add MCU signature to AuthenticityProof
[no changelog]
67/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 19/100
This commit only adds two new optional data fields to an existing device-authentication proof message used in Trezor hardware wallets. It extends the protocol definition and the matching generated code in Python, Rust, and the core firmware so that future firmware can include an MCU (microcontroller) certificate and signature alongside the already-present Optiga and Tropic proofs. The change is additive and does not by itself alter any verification logic, cryptographic checks, or access controls visible in the diff.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 22/100
This commit adds a new debug-only protocol message called DebugLinkSetBatteryState. It lets developers or test tools tell the Trezor emulator (a software version of the device used for testing) what battery and charging state to simulate. The change only touches protocol definitions and generated code; it does not add any logic that runs on a real device or handles secrets. It is marked for debug use only and is skipped in the legacy firmware build.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 21/100
This commit adds a debug-only feature to the Trezor firmware emulator that lets software tests fake the device's battery and charging state. It does not change real hardware behavior. The new function is only compiled into emulator builds and only when Python optimization is disabled (debug builds). It is intended for automated testing, not for end-user devices.
build(core): exclude haptic & led code if possible
- also sort the features in the relevant function for better readability
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
boot or update path
AI analysis · Informational 15/100
This is a harmless build-system cleanup. It teaches the firmware build scripts to remove haptic (vibration) and RGB LED code from devices that do not have those hardware features, and it sorts the list of feature flags alphabetically for easier reading. There is no security bug being fixed here.
Security candidaterefactor(rust/trezor-thp): channel ids are allocated by applicationby Martin Milata · f36c2eab · Apr 23, 2026 · 8 filesMessage 62 · AdequateLow 28Details
Commit message · Martin Milata
refactor(rust/trezor-thp): channel ids are allocated by application
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 28/100
This commit is a code refactor in Trezor's Rust THP (Trezor Host Protocol) library. It moves responsibility for assigning channel IDs from the internal library mux to the application using the library. The change also removes the requirement that credential stores/cloners implement the Clone trait, and adds a helper allocator for consecutive channel IDs. There is no direct evidence in the commit or supplied references that this fixes an active security vulnerability; it appears to be an architectural cleanup that may make misuse harder but also places more correctness burden on the application.
AI review queuedchore(core): sign translationsby Ioan Bizău · 39c051b7 · Apr 23, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Ioan Bizău
chore(core): sign translations
[no changelog]
(cherry picked from commit cbc91cf723769ed45c2390265f3aebdf6c932028)
62/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathtranslation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply adds a new digital signature entry to a JSON file that records approved translation bundles for the Trezor hardware wallet. There is no code change, no bug fix, and no visible security issue. It appears to be routine release housekeeping: signing the translation data for firmware version 2.11.1.0.
AI review queuedchore(ethereum): Move stablecoin yielding from debug to production.by PrisionMike · 59c8a6b6 · Apr 23, 2026 · 4 filesMessage 62 · AdequateInformational 18Details
Commit message · PrisionMike
chore(ethereum): Move stablecoin yielding from debug to production.
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit moves an Ethereum feature called "stablecoin yielding" from debug-only mode into production. It adds user-interface flows for certain ERC-4626 vault interactions, such as depositing USDC into a yield-bearing vault. The change itself is a feature promotion, not a fix for a known security flaw. There is no evidence in the commit that it addresses an active vulnerability or that it introduces one.
Security candidatefeat(ethereum): add support for erc-4626 withdraw and redeem flowby PrisionMike · b30022e5 · Apr 22, 2026 · 10 filesMessage 95 · StrongLow 41Details
Commit message · PrisionMike
feat(ethereum): add support for erc-4626 withdraw and redeem flow
- Updates vault with latest test - Adds concept of safe_tx - blind sign unsafe transaction with unkown vaults - clear sign safe transaction everywhere - refactor
[no changelog]
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 41/100
This commit expands Trezor's Ethereum 'clear signing' support to include ERC-4626 vault withdraw and redeem transactions, not just deposits. For transactions where the receiver or owner differs from the signer on an unknown vault, the device now falls back to blind signing instead of refusing outright. For known Trezor-listed vaults, mismatches still trigger a hard error. The change is a feature addition with intentional security trade-offs rather than a clear-cut vulnerability patch.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes user-facing text strings and their translation metadata for Ethereum vault (ERC-4626) screens. It adds labels like 'Redeem', 'Claim to', 'Withdraw amount', and removes unused strings like 'Your address'. There is no code logic change, no security fix, and no vulnerability introduced.
refactor(core): scope payment request text confirmation layouts
May be related to the following OOM: https://github.com/trezor/trezor-firmware/actions/runs/24751684853/job/72416000050
[no changelog]
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Informational 18/100
This commit is a small code cleanup in the Trezor hardware wallet's user-interface code. It changes how on-screen payment-request confirmation dialogs are created and destroyed, wrapping them in a 'with' block so they are cleaned up promptly. The developer notes this may be related to an out-of-memory (OOM) issue seen in automated tests, but the commit does not claim to fix a security vulnerability and no independent security references are provided.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update pathauthentication path
AI analysis · Informational 15/100
This commit only regenerates Rust source files from protobuf definitions using a newer version of the protoc compiler (31.1 instead of 3.19.6). The only visible changes are updated version comments and a few reordered bytes inside generated metadata. There is no change to message logic, security behavior, or how the Trezor device handles data.
AI review queuedrefactor(core): refactor NFC driver to allow easier support for different ST chipsby tychovrahe · e0132169 · Apr 21, 2026 · 76 filesMessage 62 · AdequateInformational 15Details
Commit message · tychovrahe
refactor(core): refactor NFC driver to allow easier support for different ST chips
[no changelog]
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100
This commit is a large code reorganization of the NFC (Near Field Communication) driver inside Trezor firmware. It moves the ST25R3916 RFAL library from one directory to another and updates build paths and board configuration files accordingly. There is no indication in the commit message or diff that this fixes a security vulnerability; it is described as a refactoring to make it easier to support different STMicroelectronics chips in the future. The change is mostly a directory rename plus path updates, with no functional security fix visible in the diff.
feat(core): allow disabling button on Eckhart `show_info()` layout
It will be used for N4W1 I/O layouts.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 19/100
This commit is a routine user-interface feature change for Trezor hardware wallets. It lets the new 'Eckhart' screen layout optionally show an information screen with a disabled button (for example, a grayed-out 'Continue' that becomes active only after a timer or condition). Older layouts keep their previous behavior. There is no direct evidence in the commit that this fixes a security vulnerability; it reads as a product/usability feature.
Security candidatefeat(core): allow external menu on Eckhart `show_info()` layoutby Roman Zeyde · bdf29e95 · Apr 21, 2026 · 7 filesMessage 77 · AdequateInformational 15Details
Commit message · Roman Zeyde
feat(core): allow external menu on Eckhart `show_info()` layout
It will be used for N4W1 I/O layouts.
[no changelog]
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Informational 15/100
This commit is a routine user-interface feature addition for the Trezor hardware wallet firmware. It adds an optional 'external menu' flag to the 'show_info' screen layout, primarily for a new device design (Eckhart/N4W1). On older layouts, the flag is rejected with a 'not implemented' error. There is no security-relevant change visible in the code.
Fixes #6780 (OOM on T3T1 during large input data confirmation).
Explicitly drop internal Rust layout object, in order to avoid https://github.com/trezor/trezor-firmware/issues/5472#issuecomment-3262594686
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 60/100
This update fixes a memory issue in Trezor hardware wallets that could crash the device (out-of-memory) when confirming very large pieces of on-screen data. The fix ensures a temporary screen-layout object is explicitly released after use, rather than lingering in memory. It is a reliability/availability fix rather than a direct theft-of-funds vulnerability.
refactor(core): scope `LayoutObj` lifetime at `request_word()`
Previously it was done using an explicit call to `LayoutObj.__del__()`.
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100
This commit is a small code cleanup in the Trezor hardware wallet firmware. It changes how on-screen keyboards are managed during wallet recovery (when users type in their backup seed words). Previously, the code explicitly called a destructor-like method `keyboard.__del__()` inside a try/finally block to ensure cleanup. Now it uses Python's `with keyboard:` context manager, which is a more standard and safer way to guarantee cleanup happens. There is no direct evidence this fixes a security vulnerability.