TZ
← All projectsTrezor

Trezor firmware

Firmware monorepo for Trezor One, Model T, and Safe devices.

BitcoinHardware walletsNormal
Repository coverage

3768 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

1328security candidates435second-pass queue3191AI analyses
201commits · 30 days
450commits · 60 days
1754commits · 180 days
2832commits · 365 days
Backfill bands
Aug 5 → Feb 61298 seen115 candidatesComplete
Feb 6 → Jun 6775 seen58 candidatesComplete
Jun 6 → Jul 6217 seen13 candidatesComplete
Jul 6 → Aug 5360 seen54 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

68/100 average clarity
841Strong · 80–100
1731Adequate · 60–79
1189Thin · 40–59
7Opaque · 0–39
1security candidate with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
tychovrahe394164355667
Jakub Janků1023067681
Roman Zeyde721230639372
obrusvit333135281364
cepetr301111228259
PrisionMike153101149271
Andrew Kozlik893885267
Petr Susil1159286
Martin Pastyřík291025175
M1nd3r292106248071
Ioan Bizău23076230059
Lukas Bielesch1067592066
Analysis record

Published AI watches

Last scanned 33 minutes ago

Informational 15 AI analysisMessage 90 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

ci(core): reuse HW tests Slack webhook

This is a routine GitHub Actions workflow fix. It changes which Slack webhook secret is used for nightly test failure notifications and removes a now-unnecessary safety check. There is no security vulnerability in the change itself.

abfe74f9by Michal Kazda+1−51 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

test(clear_signing): name the skipped cases

This commit only improves a test report for Trezor's clear-signing feature. It changes how skipped test cases are listed in a nightly summary, showing each skipped case's source file and calldata size instead of just counting them by reaso…

98deb5b0by PrisionMike+25−92 files
No security note in commit
Informational 15 AI analysisMessage 95 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

test(clear_signing): run the cases without display format

This commit only changes test scripts and documentation for the Trezor firmware clear-signing test suite. It makes the tests run more registry cases—specifically those where the developer definitions do not yet have a display format—so the…

05c1f4efby PrisionMike+63−225 files
No security note in commit
Informational 15 AI analysisMessage 72 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(translations): fix failing tutorial test in FR and small update to PT

This commit updates French and Portuguese translation strings in the Trezor firmware and refreshes the translation signature metadata. The changes are purely wording adjustments (for example, replacing abbreviations like 'nº' with the full…

29cbc419by Michal Kazda+19−193 files
No security note in commit
Informational 10 AI analysisMessage 95 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core/rust): reduce coverage map size

This commit changes a code-coverage tracking map inside the Trezor firmware from a claimed capacity of 1,048,576 entries down to 65,536 entries. The commit message says the old capacity was never truly that large because the heapless libra…

No cryptographic or secret-handling code changedNo input parsing, deserialization, or memory allocator changesChange is in a debug/test instrumentation module (coverage)
9bf2fc3aby M1nd3r+1−11 file
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(translations): sync Crowdin translations

This commit is a routine update of translated user-interface text strings for the Trezor hardware wallet. It adds new translations (for example, warnings about exporting public keys and Solana blind-signing prompts), updates existing wordi…

b2e8b5e6by Thalarion+141−1837 files
No security note in commit
Informational 12 AI analysisMessage 67 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

test(clear_signing): edge cases for arrays

This commit only adds new test cases for Ethereum clear-signing array parsing. It does not change any production code, so it cannot introduce a new security vulnerability on its own. The tests verify that malformed arrays (out-of-bounds of…

test-only changeno production code modifiedadds defensive test coverage for ABI decoding edge cases
dcdf3068by PrisionMike+169−01 file
No security note in commit
High 70 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): harden task switching against fault injections

This commit hardens the Trezor firmware's task scheduler against fault-injection attacks. These attacks use physical techniques like voltage glitches or laser pulses to trick the device into executing code with higher privileges than inten…

Fault-injection hardening (FIH) explicitly mentioned in commit title and code commentsPrivilege-level transition split into multiple guarded stepsAdded runtime invariant check that only the kernel task may run privileged
2f159c6bby cepetr+16−51 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 67 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(tests): removed unused is_dynamic

This commit only removes an unused parameter called `is_dynamic` from test helper functions and from test data in three test files. It does not change any production firmware code, wallet behavior, or security logic. It is a cleanup of the…

2ada2691by PrisionMike+6−323 files
No security note in commit
Informational 21 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(clear_signing): update proto defs for features to be supported.

This commit updates the data-format definitions used by Trezor devices for Ethereum 'clear signing' (showing human-readable details of smart-contract interactions). It adds support for more numeric types, new path-step structures, and extr…

Schema expansion increases attack surface for future clear-signing parser logic, but no new parser logic is present in this commit.Replacement of NotImplementedError with InvalidFormatDefinition is a defensive change that turns unimplemented paths into a handled error rather than a crash/DoS vector.New optional fields and deprecated old fields (is_dynamic, lookup_address) are backward-compatible changes.
84cb6a4bby PrisionMike+1207−979 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(python): fix protocol_v1 probe for bridge transport

This is a bug-fix patch in the Python Trezor client library. It changes how the software probes whether a connected device uses the older protocol v1. Previously, the probe tried to read and throw away leftover data, but that read could ac…

No security-relevant signal in commit message or diffFix is described as a connectivity/functional bug, not a vulnerabilityNo mention of CVE, researcher credit, or security advisory
46492ba4by M1nd3r+18−124 files
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): show language name in change confirm

This commit is a user-interface improvement, not a security fix. It changes the language-change confirmation prompt on Trezor devices so that it shows a human-readable language name (for example, 'French') instead of a raw code like 'fr-FR…

5ff5cba0by Michal Kazda+295−67 files
No security note in commit
Informational 15 AI analysisMessage 67 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(translations): fix failing tests in ES and FR

This commit updates Spanish and French translation strings in the Trezor firmware and refreshes the translation signature file. The changes are purely textual wording adjustments (for example, changing 'Mostrar palab.' to 'Mostrar palabras…

9a12ab12by Michal Kazda+15−103 files
No security note in commit
Low 47 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(crypto): hardening against potential side-channel leakage

This commit hardens cryptographic code in Trezor firmware against two potential side-channel leaks. First, it simplifies how a secret condition value is checked inside an assert statement so the compiler produces only one branch instead of…

Side-channel hardening in constant-time cryptographic primitivesReplacement of double-evaluation volatile assert with single-branch assertElimination of secret-dependent memory access in elliptic-curve scalar multiplication
7829d7c7by M1nd3r+27−93 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 72 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(ci, clear_signing): add clear signing device tests as a nightly run.

This commit adds a new nightly automated testing workflow for Ethereum 'clear signing' on Trezor hardware wallets. It does not change any wallet firmware code that users run; it only adds test scripts, CI configuration, documentation, and …

fea125baby PrisionMike+2986−2117 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): move `keccak_32` to unittests

This commit is a routine code cleanup. It removes a small helper function called keccak_32 from a shared crypto utility file and places an equivalent helper directly inside the only test file that still uses it. There is no change to how t…

f3225451by Roman Zeyde+8−122 files
No security note in commit
Informational 15 AI analysisMessage 63 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore: remove SmartCash

This commit removes support for a cryptocurrency called SmartCash from Trezor hardware wallets. It deletes coin definitions, support entries, and a custom cryptographic curve used only by SmartCash. There is no security vulnerability being…

No security-relevant signals detectedPure feature removal / code cleanup
b6d65c00by Roman Zeyde+5−52916 files
No security note in commit
Informational 15 AI analysisMessage 77 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(common,core,legacy,crypto): remove Groestlcoin

This commit removes all support for the Groestlcoin cryptocurrency from Trezor firmware. It deletes coin definitions, the custom Groestl hash algorithm code, related address/transaction handling, and tests. There is no security vulnerabili…

No security-relevant change: pure feature removalNo new attack surface introducedNo vulnerability patched or created
e22d597dby Roman Zeyde+41−446845 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove Tezos

This commit removes all support for the Tezos cryptocurrency from Trezor firmware, software libraries, and documentation. It is a feature-removal change, not a security fix or vulnerability patch. There is no indication in the commit that …

433075c0by obrusvit+9531−1751964 files
No security note in commit
Informational 24 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(legacy): lower maximum auto-lock delay to 149 hours

This update reduces the longest allowed screen-lock timeout on older Trezor devices from about 6 days down to 149 hours (just over 6 days). It makes the legacy firmware behave the same as newer Trezor firmware and prevents users from setti…

Bounds enforcement added for a configurable security-relevant timeoutAlignment of security policy between legacy and core firmware variantsTest coverage added for boundary values above and below new maximum
c108f275by Ondřej Vejpustek+16−64 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityfeat(core/sys): add Rust bindings for ipc and syseventby Lukas Bielesch · 96331cc6 · Sep 21, 2026 · 5 filesMessage 62 · AdequateTriage 0Details
Commit message · Lukas Bielesch

feat(core/sys): add Rust bindings for ipc and sysevent

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-priorityrefactor(core): return IpcMessage as attr tupleby Lukas Bielesch · 5db30119 · Sep 21, 2026 · 3 filesMessage 57 · ThinTriage 0Details
Commit message · Lukas Bielesch

refactor(core): return IpcMessage as attr tuple

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Security candidatefeat(core): register IPC buffer for extapp remoteby Lukas Bielesch · 6f8de32a · Sep 21, 2026 · 3 filesMessage 80 · StrongLow 32Details
Commit message · Lukas Bielesch

feat(core): register IPC buffer for extapp remote

Registered once at coreapp startup rather than by run.py, since run.py can
be invoked multiple times per boot and a re-registration would reset the
kernel queue out from under a running extapp.

[no changelog]

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update path
AI analysis · Low 32/100

This change moves the registration of an inter-process communication (IPC) buffer for the coreapp from a script that can run multiple times (run.py) to the firmware's startup code, which runs only once per boot. The goal is to prevent re-registration from resetting the message queue while an external app is still using it. The change itself is defensive and appears to fix a stability or potential security issue caused by repeated registration.

Lower-priorityfix(core): fix -Wsign-compare warningsby cepetr · 0b65239c · Sep 21, 2026 · 5 filesMessage 57 · ThinTriage 0Details
Commit message · cepetr

fix(core): fix -Wsign-compare warnings

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritychore(core): update fixturesby Michal Kazda · f18067ca · Sep 21, 2026 · 1 fileMessage 47 · ThinTriage 0Details
Commit message · Michal Kazda

chore(core): update fixtures
[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Security candidatefeat(core): app root packet downgrade protectionby cepetr · 4a9cf168 · Sep 21, 2026 · 12 filesMessage 57 · ThinModerate 59Details
Commit message · cepetr

feat(core): app root packet downgrade protection

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trust
AI analysis · Moderate 59/100

This commit adds downgrade protection for a new 'app root packet' system in Trezor firmware. Previously, the code had a TODO note saying downgrade protection needed to be considered. The change makes the device remember the timestamps of previously accepted root packets and reject older or inconsistent ones. It also adds a new Python-exposed state object so the wallet software can persist these timestamps. This is a security-hardening feature rather than a fix for a currently exploitable bug, but it closes a design gap that could have allowed an attacker to roll back trusted application lists to older, potentially vulnerable versions.

Lower-priorityfeat(core): use 64-bit app root timestampsby cepetr · 9fb25562 · Sep 21, 2026 · 12 filesMessage 57 · ThinTriage 0Details
Commit message · cepetr

feat(core): use 64-bit app root timestamps

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-priorityfeat(core): expose app_root_min_timestamp()by cepetr · c51e9892 · Sep 21, 2026 · 3 filesMessage 47 · ThinTriage 0Details
Commit message · cepetr

feat(core): expose app_root_min_timestamp()

[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-prioritytest(core): add tests for low-order keys in THP handshakeby M1nd3r · af27703f · Sep 21, 2026 · 4 filesMessage 72 · AdequateTriage 0Details
Commit message · M1nd3r

test(core): add tests for low-order keys in THP handshake

[no changelog]

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Security candidatefix(core/rust): discard low-order keys in THP handshakeby M1nd3r · 429a283d · Sep 21, 2026 · 4 filesMessage 62 · AdequateModerate 67Details
Commit message · M1nd3r

fix(core/rust): discard low-order keys in THP handshake

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 67/100

This commit fixes a cryptographic edge case in Trezor's THP (Trezor Host Protocol) handshake. It now rejects Curve25519 public keys that are all zeros or that produce an all-zero shared secret. A zero public key can cause the Diffie-Hellman exchange to collapse to a predictable value, which could let an attacker on the USB/bus learn or manipulate session keys. The patch also makes the handshake fail more gracefully for that single channel instead of aborting all channels.

Security candidatefeat(core): enable `ward` with `miniscript`by Jakub Janků · d434a636 · Sep 21, 2026 · 1 fileMessage 57 · ThinInformational 11Details
Commit message · Jakub Janků

feat(core): enable `ward` with `miniscript`

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 11/100

This commit changes one line in a build configuration file for the Trezor hardware wallet firmware. It adds the 'ward' feature to the existing 'miniscript' feature set. There is no direct evidence in the commit that this is a security fix; it appears to be a routine feature-enablement change. Without additional context, the security relevance is unclear and likely low.

Security candidatefeat(core): add `ward` feature flagby Jakub Janků · 7b58e75a · Sep 21, 2026 · 18 filesMessage 80 · StrongInformational 15Details
Commit message · Jakub Janků

feat(core): add `ward` feature flag

Will be used to incrementally introduce WARD-related functionality into
the codebase, while excluding it from production FW builds:

- add `ward` feature to the firmware build
- add `trezorward` MicroPython module, backed by a new `ward` module in
`trezor_lib` that depends on the shared `trezor-ward` crate

[no changelog]

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update path
AI analysis · Informational 15/100

This commit adds a new disabled-by-default feature flag called 'ward' to the Trezor firmware build system. It does not change any production firmware behavior; it only wires up a placeholder MicroPython module and build options so that future WARD-related code can be developed safely behind the flag. There is no security vulnerability visible in this change.

Security candidatefeat(core): enable -Wsign-compareby cepetr · 1cc940a4 · Sep 21, 2026 · 47 filesMessage 57 · ThinLow 27Details
Commit message · cepetr

feat(core): enable -Wsign-compare

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathboot or update path
AI analysis · Low 27/100

This commit turns on a compiler warning (-Wsign-compare) that catches places where signed and unsigned numbers are compared, and fixes the resulting warnings across the Trezor firmware. Most changes are clean-up casts and loop-index type changes. A few spots also fix real logic bugs, such as treating a negative I/O return value as a successful byte count, or using the wrong argument index for an optional offset. These are defensive improvements rather than a single obvious exploit, but in embedded security code they can prevent subtle memory or parsing issues.

Lower-prioritychore(core): update generated filesby Michal Kazda · b89e7855 · Sep 21, 2026 · 3 filesMessage 57 · ThinTriage 0Details
Commit message · Michal Kazda

chore(core): update generated files
[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Security candidaterefactor(core): merge passphrase__access_hidden_wallet into passphrase__access_walletby Michal Kazda · 65402aec · Sep 21, 2026 · 3 filesMessage 62 · AdequateInformational 15Details
Commit message · Michal Kazda

refactor(core): merge passphrase__access_hidden_wallet into passphrase__access_wallet
[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
access control
AI analysis · Informational 15/100

This commit is a simple user-interface cleanup. It removes one duplicate translation label ('Access hidden wallet') and makes the device use a single, consistent label ('Access wallet') when asking the user to confirm opening a passphrase-protected wallet. There is no change to security logic, cryptography, or how passphrases are handled.

Security candidaterefactor(core): merge passphrase__hidden_wallet into passphrase__walletby Michal Kazda · 7ce6887f · Sep 21, 2026 · 4 filesMessage 62 · AdequateInformational 15Details
Commit message · Michal Kazda

refactor(core): merge passphrase__hidden_wallet into passphrase__wallet
[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Informational 15/100

This commit is a simple user-interface cleanup. It merges two translation labels that both meant 'Passphrase wallet' into a single label, and updates the screens that used the old duplicate label. There is no security-relevant behavior change.

Security candidatefeat(clear_signing): duration formatterby PrisionMike · ec877547 · Sep 21, 2026 · 2 filesMessage 47 · ThinInformational 15Details
Commit message · PrisionMike

feat(clear_signing): duration formatter

- small refactorings
[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit adds a new feature to the Trezor Ethereum clear-signing system: a formatter that converts a duration in seconds into a human-readable HH:MM:ss display. It is a straightforward feature addition with no apparent security relevance.

Security candidatechore(core): update UI fixturesby Petr Susil · 247390cb · Sep 18, 2026 · 1 fileMessage 72 · AdequateInformational 11Details
Commit message · Petr Susil

chore(core): update UI fixtures

Multisig accounts are now named on screen, which changes the multisig
signing flows for Bitcoin, Bcash and Zcash.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing boundary
AI analysis · Informational 11/100

This commit only updates the expected screenshots (UI fixtures) used in automated tests. The change reflects that multisig account names are now shown on screen during signing for Bitcoin, Bitcoin Cash and Zcash. There is no code change, no security fix, and no vulnerability present in this commit.

Lower-priorityfix(rust/micropython): improve error handling when creating StrBufferby Jakub Janků · bbda5c8c · Sep 18, 2026 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Jakub Janků

fix(rust/micropython): improve error handling when creating StrBuffer

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Security candidatechore(clear_signing): add duration formatterby PrisionMike · f072eea9 · Sep 18, 2026 · 5 filesMessage 57 · ThinInformational 15Details
Commit message · PrisionMike

chore(clear_signing): add duration formatter

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit simply adds a new value called FORMATTER_DURATION to an existing list of field formatter types used for Ethereum clear-signing. It only updates generated enum definitions across the codebase and does not change any actual formatting logic, parsing code, or security behavior. There is no indication this introduces a vulnerability.

Lower-prioritychore(core): update fixturesby Michal Kazda · 44cb9362 · Sep 18, 2026 · 1 fileMessage 47 · ThinTriage 0Details
Commit message · Michal Kazda

chore(core): update fixtures
[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-priorityfeat(core): skip None and [] values in dump_protobufby Jakub Janků · 3893c0b8 · Sep 18, 2026 · 1 fileMessage 85 · StrongTriage 0Details
Commit message · Jakub Janků

feat(core): skip None and [] values in dump_protobuf

This significantly shortens the output for protobuf messages that
model tagged unions (see, e.g., StellarSCVal).

[no changelog]

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-priorityfix(core): do not disguise log errors as decode errorsby Jakub Janků · ae5b1fed · Sep 18, 2026 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Jakub Janků

fix(core): do not disguise log errors as decode errors

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Security candidatefix(core/bootloader): keep the full block length for block-0 retriesby tychovrahe · dc937ba2 · Sep 18, 2026 · 1 fileMessage 85 · StrongLow 45Details
Commit message · tychovrahe

fix(core/bootloader): keep the full block length for block-0 retries

Block 0 is the only block fetched in two requests: an initial
IMAGE_INIT_CHUNK_SIZE prefetch so the headers can be validated, then the
remainder. `chunk_requested` was serving three roles at once -- request size,
expected buffer fill, and the amount still owed on `remaining` -- and after the
header prefetch it holds only the remainder.

A retry then asked for that remainder from offset 0. The size check compared
`chunk_size` against `chunk_requested + read_offset`, i.e. the remainder against
itself, so it passed and `on_chunk` received a truncated block: the first
`chunk_limit - IMAGE_INIT_CHUNK_SIZE` bytes sitting at buffer offset 0. The hash
then necessarily mismatched, so the retry budget burned down and the upload
aborted. Block-0 retries could never succeed -- on T3W1 that is a 256 KB block,
where a transient BLE error is most likely.

Replace `chunk_requested` with `chunk_expected`: the bytes the buffer must hold
for the chunk to be complete, i.e. the whole block. It is the only field of its
kind left -- every request is derived from it, `remaining` is decremented by what
actually arrived, and `read_offset` goes back to being purely a buffer write
offset. The retry re-fetches the whole block from its start, and the size check
compares against what the buffer must actually hold.

No behavioural change on the success path: the bytes asked for at each request
site are the same as before, and what the old check computed is exactly what
`chunk_expected` now holds.

Alongside, in the same code: the image-size validation becomes an early guard in
`run_image_upload`, which is what guarantees a full init chunk to prefetch;
`confirmed` folds into `headers_parsed`, both having been set at the same point;
and the result dispatch becomes a switch.

The same bug is in wf_firmware_update.c on main; this fix is written against the
extracted engine but applies there unchanged.

[no changelog]

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
update trustdefensive validationboot or update path
AI analysis · Low 45/100

This commit fixes a bug in the Trezor bootloader's firmware-update code. When updating firmware, the first block of data is fetched in two pieces: a small initial 'header prefetch,' then the rest. If a communication error happened and the bootloader tried to retry, it accidentally asked for only the leftover remainder but placed it at the start of the buffer. That produced a corrupted block, the hash check failed, every retry failed, and the firmware update aborted. The fix makes retries request the whole first block again from the beginning. There is no evidence this bug was exploitable by an attacker; it appears to be a reliability defect that could brick or stall legitimate updates, especially over Bluetooth on the T3W1 model.

Security candidaterefactor(core/bootloader): separate image upload and image checksby tychovrahe · caab7d9e · Sep 18, 2026 · 4 filesMessage 62 · AdequateInformational 12Details
Commit message · tychovrahe

refactor(core/bootloader): separate image upload and image checks

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
update trustboot or update path
AI analysis · Informational 12/100

This commit is a code cleanup in the Trezor bootloader. It moves the generic, image-type-agnostic parts of firmware upload (chunk receiving, retry logic, flash erasing/writing, timeouts) into a new reusable module called wf_image_upload.c, while keeping the firmware-specific checks (signatures, versions, user confirmation, per-chunk hash checks) in wf_firmware_update.c. There is no direct evidence in the diff that this change fixes or introduces a security vulnerability; it appears to be a structural refactor to make the upload code reusable for other image types in the future.