SW
← All projectsSparrow

Sparrow Wallet

Desktop Bitcoin wallet focused on security, privacy, multisignature, and hardware signers.

BitcoinHardware integrationSoftware walletsNormal
Repository coverage

630 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

102security candidates447second-pass queue606AI analyses
181commits · 30 days
220commits · 60 days
411commits · 180 days
584commits · 365 days
Backfill bands
Aug 5 → Feb 6100 seen9 candidatesComplete
Feb 6 → Jun 6128 seen15 candidatesComplete
Jun 6 → Jul 67 seen1 candidatesComplete
Jul 6 → Aug 546 seen8 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

49/100 average clarity
0Strong · 80–100
55Adequate · 60–79
520Thin · 40–59
55Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Craig Raw61398589949
doblon8313048
Michele Balistreri212048
nzb-tuxxx212060
nroktib111050
Liz Lightning202045
Aaron Leeb101060
PeterXMR101045
craigraw101060
Ian McKenzie101050
Jan Dvořák101050
Kevin Abramczyk101050
Analysis record

Published AI watches

Last scanned 36 minutes ago

Informational 18 AI analysisMessage 60 · Adequate
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

document building v2.5.3 to v2.5.6 with lenient dependency verification, as two pom files were later republished to maven central with additional metadata

This commit only updates documentation. It explains that when building older Sparrow Wallet releases (versions 2.5.3 through 2.5.6), two dependency files on Maven Central were later republished with extra descriptive metadata, causing a ha…

Dependency checksum mismatch in recorded verification metadataPOM-only republication of two Sparrow-published artifacts (hid4java, usb4java)Documentation instructs lenient verification for reproducible builds of older releases
6a83c9a5by Craig Raw+15−01 file
No security note in commit
Low 34 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

warn that a bip353 name resolved to a silent payment address for a different network on the send tab and in send to many, rather than reporting it has no address

This commit improves user-facing error messages in the Sparrow Wallet when a BIP353 human-readable name (like a DNS-based Bitcoin payment alias) resolves to a silent payment address meant for a different Bitcoin network (for example, testn…

BIP353 DNS payment resolutionsilent payment address network mismatchuser-facing warning improvement
08f32515by Craig Raw+6−13 files
No security note in commit
Low 26 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

skip the keepalive ping while another request is awaiting its response

This change stops Sparrow Wallet from sending unnecessary 'are you still there?' keepalive pings when another request is already waiting for an answer. On some Electrum server backends (notably electrs), a ping would queue up behind the pe…

Avoidance of redundant keepalive pings that could delay synchronizationNew transport-level predicate exposing in-flight request stateUnit test added to assert correct pending-request lifecycle
4df18311by Craig Raw+50−13 files
No security note in commit
Low 38 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

wait for a slow electrum server response instead of resending the request, halving batch page sizes only after a request goes unanswered, and retry the keepalive ping once

This commit changes how the Trezor hardware wallet app talks to Bitcoin servers when responses are slow. Previously, the app would quickly resend a request if it didn't get an answer in time, and each timeout would double the wait and halv…

Change to timeout/retry logic that could affect denial-of-service resilienceReduction in retry count for keep-alive pings from 5 to 2Avoidance of duplicate request sending to slow servers, reducing amplification
96d217cfby Craig Raw+84−194 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

reduce the minimum window width to 750, fitting the send tab, transaction diagram and transaction tab views to narrow windows and narrowing the wallet menu and transaction tree below 900

This commit is a user-interface layout tweak for the Sparrow Wallet desktop app. It makes the main window usable at narrower widths by shrinking minimum sizes, wrapping labels, and making diagrams and menus responsive. There is no security…

86e52311by Craig Raw+117−4717 files
No security note in commit
Moderate 61 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

check a proof that does not reconstruct against the server chain before reporting it, as a server can report a transaction on a branch before announcing its tip

This commit fixes a bug in how Sparrow Wallet checks Bitcoin transaction proofs from an Electrum server. Previously, if a server had switched to a different blockchain branch (for example due to a reorganization) but had not yet announced …

Merkle proof verification bypass/relaxation under reorganization windowServer-side blockchain state synchronization before proof validationRisk of false-negative proof rejection leading to incorrect transaction confirmation status
f7357906by Craig Raw+91−22 files
No security note in commit
Low 33 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

decide whether a border wallets grid is hex from all of its cells rather than the selected ones

This commit fixes a bug in Sparrow Wallet's 'Border Wallets' feature. Previously, the app guessed whether a grid of seed-word abbreviations was hexadecimal (base-16) by looking only at the cells the user selected. If a user happened to pic…

Incorrect input classification leading to wrong BIP39 word derivationWallet seed/recovery correctness issueUI dialog parsing bug in mnemonic grid import
0d4f1482by Craig Raw+9−61 file
No security note in commit
Low 43 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

leave qr codes that zbar can only return as transcoded text to the other scanners

This commit fixes a bug in how Sparrow Wallet reads QR codes using the ZBar scanner. ZBar converts binary QR code data into text and silently stops at the first null byte, which can corrupt non-text data. The fix makes Sparrow only trust Z…

Data integrity issue in QR code parsingReliance on lossy text conversion for binary dataSilent truncation at NUL byte
0c28eafeby Craig Raw+25−12 files
No security note in commit
Low 27 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

save the freeze status and labels of nested wallet outputs to the wallet that stores them

This commit fixes a bookkeeping bug in Sparrow Wallet for users who have a main wallet with nested sub-wallets (for example, PayNym-style wallets). Previously, when you froze an unspent coin or changed its label, the change was recorded ag…

State-persistence bug: freeze/label changes for nested-wallet UTXOs were saved to the wrong walletUI/event routing now keyed by owning wallet rather than display walletNew unit tests added to assert correct ownership semantics
5c47c3a4by Craig Raw+116−2611 files
No security note in commit
Moderate 58 AI analysisMessage 62 · Adequate
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

keep the encrypted master secret of imported slip39 shares, so that the wallet decrypts it with any passphrase as the shares do

This commit fixes how Sparrow Wallet stores the backup/recovery seed when a user imports a wallet using SLIP39 shares (a type of multi-share mnemonic backup). Previously, the wallet decrypted the shares with the passphrase entered at impor…

SLIP39 passphrase handling changed from one-time decryption to persistent encrypted master secretStored seed now derives correct keys regardless of which passphrase is later usedNew unit test explicitly checks passphrase-variant key derivation parity
9b998a78by Craig Raw+47−43 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

keep the monospaced font of utxo addresses when the table is refreshed

This is a minor user-interface bug fix. It ensures that Bitcoin addresses in the wallet's UTXO list keep their fixed-width (monospaced) font after the table is refreshed. There is no security issue here.

868fa081by Craig Raw+2−11 file
No security note in commit
Low 46 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse descriptors that do not derive on the standard receive and change chains when importing a wallet or keystore, and warn of them in the descriptor editor

This commit tightens how Sparrow Wallet handles Bitcoin output descriptors imported from files, hardware wallets, QR codes, and the descriptor editor. It now rejects (or warns about) descriptors whose key paths don't follow the standard 'r…

New validation of BIP32 derivation paths on all descriptor import pathsRejection of descriptors with non-standard receive/change chains during wallet/keystore importWarning (but not rejection) retained for descriptor editor where user can amend the descriptor
3d2fbac4by Craig Raw+23−910 files
No security note in commit
Moderate 58 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

apply the child derivations of keys in scanned output descriptors, and refuse those that do not derive on the standard chains

This commit changes how Sparrow Wallet handles QR code and file imports of Bitcoin wallet descriptors. Previously, when scanning a descriptor from a QR code, the wallet might ignore or mishandle 'child derivation' paths that tell it how to…

Input validation added for scanned output descriptor child derivationsRejection of non-standard child derivation chainsConsistent application of child derivations between QR/file import and text descriptor parsing
6a000160by Craig Raw+290−403 files
No security note in commit
Moderate 60 AI analysisMessage 55 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse an extended private key in place of an xpub in imported wallet files, and use the public key of a private hdkey in a scanned output descriptor

This commit fixes a security issue in Sparrow Wallet where wallet import files or QR scans that were supposed to contain only public extended keys (xpubs) could accidentally or maliciously contain private extended keys (xprvs). The wallet …

Rejection of extended private keys where extended public keys are expectedPublic-key derivation from private HD keys in scanned output descriptorsAddition of defensive validation helper across multiple wallet import formats
97742cabby Craig Raw+52−298 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

let the terminal user choose the script type when transactions are found for more than one

This change improves the Sparrow Wallet terminal (command-line) interface. Previously, if the wallet discovery process found transactions matching more than one Bitcoin script type, it would silently pick the first one. Now it shows a menu…

Behavioral fix: prevents silent selection of first discovered wallet script typeUser-choice dialog added in terminal wallet creation flowNo cryptographic, network, or input-validation changes observed
a18db115by Craig Raw+18−41 file
No security note in commit
Low 33 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

use the bip352 derivation for silent payment wallets imported from a mnemonic or device, created in the terminal, scanned from a seedqr or added at another account

This commit changes how Sparrow Wallet picks the derivation path when creating or importing wallets. It makes the wallet choose BIP-352 (silent payments) paths when the wallet policy is a single-key silent-payment wallet, instead of always…

Derivation-path selection now depends on policy type, which can change wallet fingerprint/address generation for silent-payment walletsBroad surface area (12 files) increases risk of an import path being missed or behaving differentlySubmodule bump (drongo) likely contains the actual ScriptType.getDefaultDerivation(PolicyType) implementation, but its diff is not supplied
002b1b58by Craig Raw+41−3012 files
No security note in commit
Low 37 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

replace control characters in cosigner labels of an imported multisig configuration, and size alerts to include blank lines

This commit makes two small UI fixes in Sparrow Wallet. First, it strips hidden control characters from cosigner labels when importing a shared multisig wallet setup, preventing odd or misleading label display. Second, it fixes alert dialo…

Sanitization of user-supplied labels (control/format characters replaced)UI dialog sizing fix to prevent content clippingNo explicit security framing in commit message or diff
c1d4feeaby Craig Raw+3−12 files
No security note in commit
Low 34 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

truncate address, purpose node and keystore labels when updating a wallet, as a full save does

This commit fixes a bug where Sparrow Wallet's database update path failed to shorten (truncate) long labels for wallet addresses, purpose nodes, and keystores before saving them. The full save path already did this truncation, but the inc…

Data-integrity bug: inconsistent truncation between full save and incremental updatePotential denial-of-service against local wallet state via overly long labelsRegression test added to prevent future recurrence
0721ca98by Craig Raw+50−52 files
No security note in commit
Low 32 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse the bwt fallback for bitcoin core over https and ignore the legacy wallet setting for it

This commit changes Sparrow Wallet so that when it connects to a Bitcoin Core node over HTTPS, it no longer falls back to an older 'BWT' connection method and no longer tries to use legacy Bitcoin Core wallets. The change appears to be a h…

Disables legacy wallet handling for HTTPS Bitcoin Core connectionsRemoves BWT fallback for HTTPS Bitcoin Core connectionsForces Bitcoin Core v24+ requirement for HTTPS connections
b935568aby Craig Raw+8−22 files
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

check rsa server certificates against the ca trust store for the key exchange in use

This one-line change fixes how Sparrow Wallet checks a Bitcoin server’s TLS certificate. Previously, when the server used an RSA certificate, the app told Java’s certificate validator to expect an old-style RSA key exchange ("RSA"). That w…

TLS certificate validation logic changedX509TrustManager.checkServerTrusted authType correctedPotential for certificate acceptance/rejection mismatch before fix
1071ed7cby Craig Raw+1−11 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedsync to the announced tip before serving a stored header when a reorg lengthens the chain, so a proof is not checked against a replaced blockby Craig Raw · 40310b05 · Nov 19, 2026 · 2 filesMessage 50 · ThinModerate 69Details
Commit message · Craig Raw

sync to the announced tip before serving a stored header when a reorg lengthens the chain, so a proof is not checked against a replaced block

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 69/100

This commit fixes a bug in how Sparrow Wallet verifies Bitcoin block headers during a blockchain reorganization (reorg). Previously, if a reorg made the chain longer, the wallet could serve an old, replaced block header to check a payment proof, instead of first syncing to the newly announced longer chain. This could let a malicious or mistaken server make a transaction proof look valid against the wrong block. The fix forces a sync to the announced tip before serving any stored header when the announced tip is newer or on a different branch than what is locally stored.

AI review queueddelete backups made before a password was added or changed from the terminal settingsby Craig Raw · 26e6705d · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 42Details
Commit message · Craig Raw

delete backups made before a password was added or changed from the terminal settings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 42/100

This commit changes how Sparrow Wallet's terminal (command-line) version handles wallet backups when a password is added, changed, or removed. Previously, old unencrypted or differently-encrypted backups might have been kept on disk. After this change, the terminal version behaves like the desktop version: when a password is set or changed, backups made under the old password (or no password) are deleted. This reduces the risk that an attacker or another user could find an old, less-protected copy of the wallet and access its data.

AI review queuedfind, rename and delete the backups of a wallet left in a previous wallets folder when its password is added, it is renamed or it is deletedby Craig Raw · 8f4b70e9 · Nov 19, 2026 · 5 filesMessage 50 · ThinLow 36Details
Commit message · Craig Raw

find, rename and delete the backups of a wallet left in a previous wallets folder when its password is added, it is renamed or it is deleted

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 36/100

This commit fixes a cleanup issue in the Sparrow Bitcoin wallet. Previously, if a wallet file was moved out of the default 'wallets' folder, its automatic backups could be left behind in the old folder. When the user later added a password, renamed, or deleted that wallet, Sparrow would not find or remove those leftover backups. The change makes Sparrow look in the wallet's previous folder for any orphaned backups and offers to delete or rename them alongside the main wallet. It is a privacy/data-residue fix rather than a remote hack vulnerability.

AI review queuedencrypt account keystores when a password is set together with a change needing a refresh, and edit an account as a child of the master wallet copyby Craig Raw · 4acaaca2 · Nov 19, 2026 · 2 filesMessage 50 · ThinModerate 57Details
Commit message · Craig Raw

encrypt account keystores when a password is set together with a change needing a refresh, and edit an account as a child of the master wallet copy

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit fixes a bug in Sparrow Wallet's settings form. When a user changed wallet settings that required a full refresh (like the gap limit) at the same time as adding a wallet password, the software could fail to properly encrypt the private key data for child accounts. The fix ensures account 'keystores' are copied and encrypted consistently with the master wallet, and adds tests to confirm the behavior.

AI review queuedkeep the open wallet encrypted while discovering accounts to addby Craig Raw · 0f9d99fc · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 43Details
Commit message · Craig Raw

keep the open wallet encrypted while discovering accounts to add

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 43/100

This change adjusts how Sparrow Wallet handles wallet encryption when adding or discovering new accounts. Previously, the main open wallet was decrypted before deciding what to do next, which could leave it decrypted during a potentially lengthy account-discovery network operation. Now the wallet stays encrypted during discovery; only a temporary copy is decrypted for that task. This reduces the window during which sensitive wallet key material sits unencrypted in memory while the user is not actively interacting with it.

AI review queuedtreat a proxy's reply that it could not reach the server as a server failure, so it no longer turns off the proxyby Craig Raw · ebe83462 · Nov 19, 2026 · 1 fileMessage 50 · ThinModerate 50Details
Commit message · Craig Raw

treat a proxy's reply that it could not reach the server as a server failure, so it no longer turns off the proxy

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 50/100

This change fixes a bug where Sparrow Wallet would disable its Tor/proxy connection whenever the proxy reported it couldn't reach the destination server. Previously, the app misread 'the destination is unreachable' as 'the proxy itself is broken' and turned off the proxy. Now it correctly treats those messages as server-side failures and keeps the proxy running. This is a reliability/privacy fix: users are less likely to accidentally fall back to a direct connection when their proxy is actually working fine.

AI review queuedhold rates, version and currency requests and refuse auth47 and lnurl-auth logins while internal tor is startingby Craig Raw · 71cd1c74 · Nov 19, 2026 · 2 filesMessage 55 · ThinModerate 64Details
Commit message · Craig Raw

hold rates, version and currency requests and refuse auth47 and lnurl-auth logins while internal tor is starting

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 64/100

This commit fixes a privacy and security issue in Sparrow Wallet where certain network requests and authentication actions could run before the built-in Tor proxy was ready. Without the fix, those requests could bypass Tor and expose the user's real IP address or real network identity. The patch pauses exchange-rate checks, version checks, and currency list fetches, and blocks Auth47 and LNURL-auth logins until Tor has finished starting.

AI review queuedcreate the server transport only when connecting, so a call made after disconnecting cannot leave one for the next connectionby Craig Raw · 7b6e8443 · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 48Details
Commit message · Craig Raw

create the server transport only when connecting, so a call made after disconnecting cannot leave one for the next connection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a logic bug in how Sparrow Wallet connects to Bitcoin Electrum servers. Previously, background tasks that ran after a disconnect could accidentally create a new server connection on their own, using stale or mismatched settings, instead of using the proper connection lifecycle. The change ensures that only the official 'connect()' routine can create a transport, and any late-running task simply fails with a 'not connected' error rather than silently opening its own connection.

Security candidatereach an onion host written with a trailing dot over tor, and remove the dot from saved server urlsby Craig Raw · 70f2f51f · Nov 19, 2026 · 4 filesMessage 50 · ThinLow 44Details
Commit message · Craig Raw

reach an onion host written with a trailing dot over tor, and remove the dot from saved server urls

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathauthentication pathparser or protocol path
AI analysis · Low 44/100

This commit fixes a handling quirk for Tor 'onion' web addresses when they are written with a trailing dot (for example, 'example.onion.'). Previously, Sparrow did not recognize these dotted onion addresses as Tor destinations, so it might try to connect over the regular internet instead of through Tor, and could fail to enforce the requirement that a Tor proxy must be configured. The change makes Sparrow strip the trailing dot, recognize the address as an onion address, route it through Tor, and save server URLs without the trailing dot.

AI review queueduse the default port for a proxy given without one in http requests, bwt, tor identity changes and tor status checksby Craig Raw · 921c43be · Nov 19, 2026 · 5 filesMessage 50 · ThinLow 35Details
Commit message · Craig Raw

use the default port for a proxy given without one in http requests, bwt, tor identity changes and tor status checks

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit fixes a bug where Sparrow Wallet would use an invalid port number when a user configured a Tor/proxy server address without explicitly specifying a port. Previously, the code called getPort(), which could return -1 or an undefined value when no port was provided, causing connection failures or possibly connecting to the wrong service. The fix supplies the default SOCKS/Tor proxy port (9050) in those situations across Tor status checks, BWT (Bitcoin Wallet Tracker) startup, HTTP proxy setup, Tor identity rotation, and the terminal UI.

AI review queuedaccept a proxy port given with the host, and keep the saved proxy when the host is invalid, in the desktop and terminal settingsby Craig Raw · 63e19930 · Nov 19, 2026 · 2 filesMessage 50 · ThinInformational 18Details
Commit message · Craig Raw

accept a proxy port given with the host, and keep the saved proxy when the host is invalid, in the desktop and terminal settings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit fixes a small user-experience bug in Sparrow Wallet's proxy settings. Previously, if a user typed a proxy address that included a port (like '127.0.0.1:9050') into the host field, the app rejected it as invalid and could also wipe out the previously saved proxy. The change now accepts host:port combinations and keeps the saved proxy when the host entry is invalid, matching how invalid ports were already handled.

AI review queuedstop a connection waiting to retry while the server settings are open, and reconnect on closingby Craig Raw · 6404bb46 · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 28Details
Commit message · Craig Raw

stop a connection waiting to retry while the server settings are open, and reconnect on closing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit fixes a small timing bug in Sparrow Wallet's server settings screen. Previously, if the wallet was trying to reconnect to a server in the background while the user opened the server settings, the reconnect could read the half-edited settings and behave incorrectly. Now the reconnect is paused while settings are open and resumed when the settings screen closes.

AI review queuedcheck whether a server host is an ip literal as inetaddress reads oneby Craig Raw · 02f8a0c5 · Nov 19, 2026 · 3 filesMessage 50 · ThinModerate 61Details
Commit message · Craig Raw

check whether a server host is an ip literal as inetaddress reads one

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 61/100

This commit tightens how Sparrow Wallet decides whether a server address is a raw IP address (like 192.168.1.1) versus a hostname (like example.com). It replaces a more forgiving Google utility with Java's stricter InetAddress.ofLiteral check. The goal is to prevent hostnames that look like IP addresses from being treated as local network addresses when a proxy is in use, which could otherwise leak those names to local DNS or bypass the proxy. The change also updates warning messages shown to users about whether their Bitcoin Core server is local or remote.

AI review queuedcompare a re-announced chain tip by block when deciding whether to retry or refuse itby Craig Raw · 40724fa8 · Nov 19, 2026 · 3 filesMessage 50 · ThinLow 42Details
Commit message · Craig Raw

compare a re-announced chain tip by block when deciding whether to retry or refuse it

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100

This commit fixes a logic bug in how Sparrow Wallet decides whether to retry or reject a newly announced blockchain tip from an Electrum server. Previously, the code compared tip objects using Java's == operator, which checks whether two variables point to the exact same object in memory rather than whether they represent the same block. Because a re-announced block is a new object with the same height and header hash, the old comparison could treat a repeated announcement of the same block as a different tip. That could cause the wallet to incorrectly retry failed header fetches or wrongly refuse a tip after a transient error, potentially leaving the wallet out of sync or stuck on a bad chain tip. The fix introduces an isSameBlock method that compares height and block hash instead of object identity.

AI review queuedextend the gap limit only for addresses paid by a fetched transactionby Craig Raw · 466b4242 · Nov 19, 2026 · 3 filesMessage 50 · ThinModerate 51Details
Commit message · Craig Raw

extend the gap limit only for addresses paid by a fetched transaction

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 51/100

This commit tightens when Sparrow Wallet extends the 'gap limit'—the number of empty addresses it keeps ready ahead of the last used one. Previously, merely seeing any transaction status reported for an address could push the gap forward. Now the wallet only extends the gap when a fetched transaction actually pays that address. This prevents a malicious or buggy Electrum server from tricking the wallet into generating far more addresses than necessary by reporting unrelated transaction statuses.

AI review queuedcap sparrow.log at 10mb with one rolled backup, and ignore server notifications that match no subscriptionby Craig Raw · ebf04841 · Nov 19, 2026 · 3 filesMessage 50 · ThinLow 47Details
Commit message · Craig Raw

cap sparrow.log at 10mb with one rolled backup, and ignore server notifications that match no subscription

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 47/100

This commit makes two unrelated changes to the Sparrow Wallet desktop app. First, it caps the app's log file at 10 MB and keeps one rolled backup, preventing the log from growing forever and filling up disk space. Second, it tightens how the app handles messages from a Bitcoin Electrum server: instead of treating any message with a 'method' field as a subscription notification, it now checks whether the method name and parameters match one of the subscriptions the app actually registered for. Messages that don't match are classified as unexpected notifications and are ignored, with a warning logged at most once per minute. The change is defensive and reduces the chance that a malicious or misbehaving server could confuse the wallet by sending unexpected notifications.

AI review queuedvalidate every schema in a wallet file in one pass before and after migration, rather than each child wallet schema twiceby Craig Raw · 9779b3e7 · Nov 19, 2026 · 2 filesMessage 50 · ThinLow 44Details
Commit message · Craig Raw

validate every schema in a wallet file in one pass before and after migration, rather than each child wallet schema twice

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a security check in Sparrow Wallet's handling of wallet files. Previously, the app checked each part of a wallet file for tampering one piece at a time, which could let a hidden malicious change slip through between checks. Now it checks the whole wallet file all at once before and after any updates. The change also makes the checks more thorough by looking at the entire file, not just one section. A new test was added to confirm malicious changes in a 'silent payment' or child wallet section are caught.

AI review queuedkeep the label and status of outputs at an address the server briefly reports without historyby Craig Raw · 6bcd4f25 · Nov 19, 2026 · 2 filesMessage 50 · ThinLow 45Details
Commit message · Craig Raw

keep the label and status of outputs at an address the server briefly reports without history

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 45/100

This commit changes how Sparrow Wallet handles a temporary server state where an address appears to have no transaction history. Previously, the wallet would wipe all transaction outputs tied to that address, which could also erase user labels and status markers. The fix uses a gentler update method that preserves labels and status while still clearing stale data. It is a defensive fix against a potential data-loss or UI-confusion bug, not a clear-cut remote exploit.

AI review queuedremove control and format characters from paynym names, and omit directory entries whose payment code has no valid keyby Craig Raw · 4d3acfea · Nov 19, 2026 · 3 filesMessage 50 · ThinModerate 50Details
Commit message · Craig Raw

remove control and format characters from paynym names, and omit directory entries whose payment code has no valid key

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 50/100

This commit hardens how Sparrow Wallet handles PayNym contacts. It strips invisible or display-manipulating characters from contact names, and it drops directory entries whose payment codes contain invalid cryptographic keys instead of keeping them. These changes reduce the risk of a malicious or malformed PayNym entry tricking the user or causing downstream errors.

Security candidaterefuse to sign a paynym authentication token in another formatby Craig Raw · ebd3bdad · Nov 19, 2026 · 2 filesMessage 55 · ThinModerate 61Details
Commit message · Craig Raw

refuse to sign a paynym authentication token in another format

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
access controlsigning or wallet path
AI analysis · Moderate 61/100

This commit adds a safety check so that Sparrow Wallet will refuse to sign a PayNym authentication token if it looks like a web link (for example, starting with 'auth47://' or 'https://'). Before this change, the wallet might have signed such a token, which could potentially let an attacker trick the user into signing a message that authorizes something on a website instead of a simple PayNym token. The change is defensive and includes tests to confirm the new behavior.

AI review queuedkeep stored and followed paynym contacts over directory entries and their names, search the listed contacts, and show the payment code when linkingby Craig Raw · f48f577a · Nov 19, 2026 · 5 filesMessage 50 · ThinInformational 20Details
Commit message · Craig Raw

keep stored and followed paynym contacts over directory entries and their names, search the listed contacts, and show the payment code when linking

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit fixes a user-interface bug in Sparrow Wallet's PayNym contact handling. Previously, the wallet could mix up contacts that had the same display name but different payment codes, and it could overwrite a user's own stored contact names with names from the public PayNym directory. The change makes the wallet prefer contacts you have already saved or followed, lets you search the contact list, and shows the actual payment code when you link to someone so you can confirm it is the right person. It is a usability and correctness improvement rather than a fix for a remote exploit.

AI review queuedask before broadcasting a paynym link transaction at a very high fee rateby Craig Raw · 9b566c15 · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 44Details
Commit message · Craig Raw

ask before broadcasting a paynym link transaction at a very high fee rate

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit adds a confirmation dialog before broadcasting a special Bitcoin transaction used to create a PayNym link. Previously, if the network fee rate was extremely high, the wallet would silently broadcast the transaction and the user could pay unexpectedly large fees. Now the user is warned and must confirm before the broadcast proceeds.

Security candidateremove auth47 soroban callback supportby Craig Raw · 37ea7b97 · Nov 19, 2026 · 2 filesMessage 45 · ThinLow 41Details
Commit message · Craig Raw

remove auth47 soroban callback support

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathauthentication path
AI analysis · Low 41/100

This commit removes support for a special callback protocol called 'srbn://' from Sparrow Wallet's Auth47 authentication feature. Previously, Auth47 could accept callbacks using this protocol, which would be converted to HTTPS and sent through a different response path involving a 'Soroban' directory service. Now, only HTTPS and HTTP-onion callbacks are accepted. The change is defensive: it narrows what callback types are allowed and removes a less common code path, but the commit message does not say it fixes a specific security vulnerability.

Security candidateapply the required all sighash to the inputs of a psbt with silent payment outputs in the transaction tab, and check each input a card will sign before it signs anyby Craig Raw · 418e726a · Nov 19, 2026 · 5 filesMessage 50 · ThinModerate 58Details
Commit message · Craig Raw

apply the required all sighash to the inputs of a psbt with silent payment outputs in the transaction tab, and check each input a card will sign before it signs any

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 58/100

This commit fixes how Sparrow Wallet handles Bitcoin transactions that use silent payments. Silent payments require every input to be signed with SIGHASH_ALL, meaning the signature covers the whole transaction. Previously, the wallet might have let a hardware card sign an input with a weaker signature type, or let the user pick a different one in the transaction tab. The patch forces SIGHASH_ALL on all inputs when silent payment outputs are present, and makes each card check that requirement before signing anything. A wrong sighash could let an attacker alter parts of the transaction after some inputs are signed, potentially redirecting funds or breaking the silent-payment protocol.

Security candidatedisable the locktime controls for a psbt input requiring a locktime, and show the locktime that will be signedby Craig Raw · 1f5993b7 · Nov 19, 2026 · 1 fileMessage 50 · ThinLow 35Details
Commit message · Craig Raw

disable the locktime controls for a psbt input requiring a locktime, and show the locktime that will be signed

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 35/100

This commit changes how Sparrow Wallet handles 'locktime' settings when editing a transaction that came from a PSBT (Partially Signed Bitcoin Transaction). Previously, the user could edit the locktime even when a PSBT input required a specific locktime, which could lead to the wallet displaying or signing a different locktime than the one required by the transaction's inputs. Now, the locktime controls are disabled when any PSBT input requires a locktime, and the displayed locktime is forced to the value that will actually be signed. This is a defensive UI fix to prevent user confusion and potential signing of an unexpected transaction locktime.