hide account discovery on a silent payments wallet
What the developer wrote
Authored by Craig Raw
hide account discovery on a silent payments wallet
What changed, and why it matters
This commit simply hides the 'Discover' button when adding an account to a Silent Payments wallet. It is a UI change, not a fix for a vulnerability. There is no evidence of a security bug being patched.
No security action required; treat as a normal UI/UX change.
Security signals we found
No security signals present in the diff
UI-only change hiding a button for a specific wallet policy type
Evidence from the diff
The change adds a condition masterWallet.getPolicyType() != PolicyType.SINGLE_SP before adding the account-discovery button in AddAccountDialog. This prevents users from running account discovery on a Silent Payments (SINGLE_SP) wallet, likely because discovery is not meaningful or supported for that wallet type. The diff shows no cryptographic, network, or permission changes.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/AddAccountDialog.javaInspect captured patch +2 / −1
### src/main/java/com/sparrowwallet/sparrow/control/AddAccountDialog.java
@@ -68,7 +68,8 @@ public AddAccountDialog(Wallet wallet) {
}
final ButtonType discoverButtonType = new javafx.scene.control.ButtonType("Discover", ButtonBar.ButtonData.LEFT);
- if(!availableAccounts.isEmpty() && (masterWallet.getKeystores().stream().allMatch(ks -> ks.getSource() == KeystoreSource.SW_SEED)
+ if(!availableAccounts.isEmpty() && masterWallet.getPolicyType() != PolicyType.SINGLE_SP
+ && (masterWallet.getKeystores().stream().allMatch(ks -> ks.getSource() == KeystoreSource.SW_SEED)
|| (masterWallet.getPolicyType() == PolicyType.SINGLE_HD && masterWallet.getKeystores().stream().allMatch(ks -> ks.getSource() == KeystoreSource.HW_USB)))) {
dialogPane.getButtonTypes().add(discoverButtonType);
Button discoverButton = (Button)dialogPane.lookupButton(discoverButtonType);Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.