explicitly reject a psbt signed over silent payment outputs that have not been computed
What the developer wrote
Authored by Craig Raw
explicitly reject a psbt signed over silent payment outputs that have not been computed
What changed, and why it matters
This commit updates a submodule called 'drongo' inside the Sparrow Wallet project. The title says it now explicitly rejects a partially-signed Bitcoin transaction (PSBT) if it has been signed over silent payment outputs that were not actually computed. In plain terms, it tries to prevent a wallet from accepting a transaction signature that covers hidden recipient addresses it never verified. We cannot see the actual code change because only the submodule commit hash changed.
Review the actual drongo submodule diff at b89da20bc92c4fceb4d67ff53daaf56d7b29d94e to confirm the validation logic and whether it fully rejects unsafe PSBTs. Users should upgrade to a Sparrow release that includes this submodule bump once available, especially if using silent payments. Developers should avoid relying solely on submodule titles for security assessment.
Security signals we found
Silent payment output validation bypass
PSBT signature over uncomputed outputs
Submodule-only change obscures full patch
Potential funds-loss / incorrect transaction acceptance
Evidence from the diff
The diff is a single submodule pointer bump for ‘drongo’ from commit 924d20a4fac3e144ef7439b10058b01aebb902a8 to b89da20bc92c4fceb4d67ff53daaf56d7b29d94e. The commit title indicates the underlying change in drongo adds an explicit rejection of a PSBT signed over silent payment outputs that have not been computed. Silent Payments (BIP 352) let a sender derive a unique output address from a static recipient scan/spend key; the recipient must compute the actual output script to verify it. Without the explicit rejection, Sparrow/drongo might have accepted or proceeded with a PSBT whose signatures cover outputs the wallet had not derived/validated, potentially leading to loss of funds or incorrect transaction handling. The actual implementation details are not visible in this commit.
Changed components
drongo submodulePSBT handling / signing logicSilent Payments (BIP 352) output computationInspect captured patch +1 / −1
### drongo
@@ -1 +1 @@
-Subproject commit 924d20a4fac3e144ef7439b10058b01aebb902a8
+Subproject commit b89da20bc92c4fceb4d67ff53daaf56d7b29d94eWhy this scored 55/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.