Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…
This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…
State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …
Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.
This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …
This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…
This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…
State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…
API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…
Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…
Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …
Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …
Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…
Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…
Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…
Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…
This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…
Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …
This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…
New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…
State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedMerge PR 'Account for current HTLC fees in dust exposure' (#5690)by Matt Corallo · cc798f60 · Nov 20, 2026 · 2 filesMessage 81 · StrongModerate 63Details
Commit message · Matt Corallo
Merge PR 'Account for current HTLC fees in dust exposure' (#5690)
from tankyleo/leo/2026-11-current-htlc-fee-exposure into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5690 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 63/100
This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when deciding which HTLCs count as dust and how much extra fee exposure they create. The patch now checks both the actual current fee rate and the buffered fee rate, and uses the worse of the two when limiting how much can be sent. This prevents a node from accepting or sending HTLCs that look safe under a buffered estimate but are actually dust at the current fee rate, which could leave the node paying unexpectedly high commitment transaction fees relative to the HTLC value.
AI review queuedMerge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)by Matt Corallo · 17bac68a · Nov 20, 2026 · 2 filesMessage 91 · StrongInformational 12Details
Commit message · Matt Corallo
Merge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)
from bot/5682-ci-broken-5b8d6e into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5684 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 12/100
This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid under recent product changes. There is no change to production code, no vulnerability fix, and no security-relevant behavior change.
AI review queuedMerge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)by Matt Corallo · 56054190 · Nov 19, 2026 · 5 filesMessage 81 · StrongLow 48Details
Commit message · Matt Corallo
Merge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)
from bot/5624-fundingbuilder-leaks-utxo-locks-419042 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5634 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100
This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejection could leave the UTXO locked or unavailable. The fix adds a size check during coin selection so oversized UTXOs are skipped before being selected, keeping them available for other uses. It also updates the public wallet API with a new parameter for this size limit.
AI review queuedRefuse to pay BOLT 12 invoices with records above experimental rangeby auto-pr-bot · 2970372f · Nov 19, 2026 · 7 filesMessage 81 · StrongLow 48Details
Commit message · auto-pr-bot
Refuse to pay BOLT 12 invoices with records above experimental range
@matt asked in #5668:
It seems we shouldn't be rejecting TLVs over 4 billion at all, on the reading side, per the spec. This might require a minor spec change to the payer-proof spec, but that's okay. Still, just to be safe, let's refuse to pay (in the bolt12 flow) any invoices with TLVs above 4 billion, even if we happily deserialize them.
The previous commit made such invoices deserializable again, so a payee can once again send us an invoice containing records we don't understand. An odd record type requires comprehension to be honored, so refuse to initiate a BOLT 12 payment for an invoice containing a record at or above EXPERIMENTAL_INVOICE_TYPES_END, in every path that pays one: invoices received in reply to an invoice request or a refund (whether handled automatically or via send_payment_for_bolt12_invoice), pay_for_bolt12_invoice, and static invoices in the async payments flow.
The payment is failed with PaymentFailureReason::UnknownRequiredFeatures, like other invoices carrying records we don't understand, rather than introducing a new failure reason.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Low 48/100
This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change treats them like unknown required features and aborts payment before funds move. It is a defensive safety fix, not a response to an active exploit.
AI review queuedRead invoice TLV records above the experimental rangeby auto-pr-bot · 9e28db58 · Nov 19, 2026 · 4 filesMessage 81 · StrongModerate 64Details
Commit message · auto-pr-bot
Read invoice TLV records above the experimental range
@matt asked in #5668:
It seems we shouldn't be rejecting TLVs over 4 billion at all, on the reading side, per the spec. This might require a minor spec change to the payer-proof spec, but that's okay.
Commit 5747866a6 ("offers: add BOLT 12 payer proof primitives") narrowed EXPERIMENTAL_INVOICE_TYPES from 3_000_000_000.. to 3_000_000_000..4_000_000_000. The same parser also deserializes invoices LDK persisted itself, via HTLCSource::OutboundRoute's bolt12_invoice field, which ChannelMonitor::read reads for the HTLCs of holder commitments, so a monitor written by LDK 0.2 for a channel that paid an invoice whose payee appended an odd TLV record with a type above 4,000,000,000 fails to load with InvalidValue after upgrading. Since read_channel_monitors fails on the first unreadable monitor, none of the node's channels are watched until the operator intervenes.
The spec places no upper bound on TLV record types, so parse the experimental range as open-ended again, as LDK 0.2 and earlier did. EXPERIMENTAL_INVOICE_TYPES_END keeps the 4,000,000,000 bound where it is still enforced: the payer-proof omitted-marker validation, which takes the bound from the payer-proof spec, and refusing to pay such invoices, added in the following commit.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 64/100
This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices created or stored by LDK 0.2 that contained odd experimental TLVs above 4 billion became unreadable after upgrading. Because these invoices are embedded in channel monitors, a single unreadable monitor could block all of a node's channels from being watched until the operator manually intervened. The patch reopens the parsing range while keeping the 4 billion limit only where it is still meaningful: payer-proof validation and refusing to pay such invoices.
AI review queuedMerge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)by Matt Corallo · ec40e097 · Nov 19, 2026 · 8 filesMessage 81 · StrongHigh 74Details
Commit message · Matt Corallo
Merge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)
from auto-pr-bot/bot/386-lightning-signed-mesages-can-be-43bc68 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5677 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 74/100
This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing key, an attacker could take a legitimate node's signed message and replay it as a forged gossip announcement, potentially impersonating or misrepresenting that node on the network. The patch makes the signing function refuse to sign any message whose prefixed bytes form a valid node_announcement serialization, and updates the API to return a Result so callers can handle the refusal.
AI review queuedMerge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)by wpaulino · 643e8684 · Nov 19, 2026 · 1 fileMessage 81 · StrongLow 37Details
Commit message · wpaulino
Merge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100
This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch was too expensive to fund, the code would shrink the batch and immediately give up when only one HTLC remained, abandoning that last HTLC instead of trying to claim it alone. The patch makes the code retry the final HTLC as a single transaction before giving up, so a user is less likely to lose funds due to an unclaimable HTLC.
AI review queuedMerge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)by Matt Corallo · 6e555fa2 · Nov 17, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Matt Corallo
Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)
from bot/5614-stashed-reads-let-any-peer-panic-d94a61 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5621 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can cause their program to panic (crash) if LDK runs outside a Tokio runtime. It is a documentation-only clarification, not a code patch.
AI review queuedMerge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)by Matt Corallo · 0e3b6d33 · Nov 17, 2026 · 4 filesMessage 91 · StrongHigh 70Details
from bot/5611-funding-tx-broadcast-on-invalid-c2b5de into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5616 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 70/100
This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made verification helper and updates the documentation to make clear that signers must do this check synchronously before returning success, because LDK may immediately broadcast the funding transaction or use the commitment on force-close. It also makes LDK's built-in signer verify that the holder funding key in the channel parameters actually belongs to it before trusting signatures. The commit is defensive: it reduces the chance that a buggy or malicious custom signer accidentally accepts invalid signatures and lets LDK act on them.
AI review queuedMerge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)by Matt Corallo · d68d2235 · Nov 17, 2026 · 2 filesMessage 81 · StrongModerate 64Details
Commit message · Matt Corallo
Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)
from auto-pr-bot/bot/268-channel_ready-before-async-fundi-11838c into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5612 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100
This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node reject such premature messages and close the channel safely, preventing the counterparty's commitment point from advancing underneath an unsigned initial commitment.
AI review queuedMerge PR 'Drop ben and joost from the assign-reviewer pool' (#5498)by Matt Corallo · 6ac2db21 · Nov 16, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo
Merge PR 'Drop ben and joost from the assign-reviewer pool' (#5498)
from bot/5449-drop-stale-reviewers-from-the-as-5e7903 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5498 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply updates an automated workflow that picks who gets asked to review new pull requests. It removes five people from the reviewer rotation and keeps four others. There is no code change to the actual Lightning software and no security relevance.
AI review queuedPass the initial counterparty commit tx to `ChannelMonitor::new`by Matt Corallo · 4a272b62 · Nov 13, 2026 · 2 filesMessage 83 · StrongLow 31Details
Commit message · Matt Corallo
Pass the initial counterparty commit tx to `ChannelMonitor::new`
For some time now we've required the initial counterparty commitment tx to be provided to `ChannelMonitor`s immediately. With a recent change we started panic'ing if we failed to do so before serializing a `ChannelMonitor`, which broke a `--cfg` flag test.
Here we fix this by requiring the initial commitment transaction by API in `ChannelMonitor::new`.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 31/100
This commit fixes an internal consistency problem in how a new Lightning channel's first monitoring data is built. Previously, the code created a ChannelMonitor first and then separately supplied the counterparty's initial commitment transaction. A recent change made the monitor panic if it was saved to disk before that transaction was supplied. The fix requires the transaction to be passed directly into ChannelMonitor::new, eliminating a window where the monitor could be incomplete. It is a robustness/API-cleanup fix rather than an externally exploitable vulnerability.
AI review queuedMerge PR 'Reject RAA before our commitment_signed has been sent' (#5561)by Matt Corallo · 1f1fd3f1 · Nov 11, 2026 · 4 filesMessage 81 · StrongModerate 68Details
Commit message · Matt Corallo
Merge PR 'Reject RAA before our commitment_signed has been sent' (#5561)
from auto-pr-bot/bot/345-raa-before-our-commitment_signed-94d9f9 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5561 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 68/100
This commit fixes a bug in the Lightning Dev Kit where a node could incorrectly accept a 'revoke_and_ack' message from its counterparty before it had actually sent out a new commitment transaction. Under the right timing conditions, this could cause the node to sign a commitment that its own channel monitor had never been told about, potentially leaving it unable to recover funds or claim HTLCs if that commitment later confirmed on-chain. The fix adds extra state checks so the node rejects such premature messages and closes the channel instead.
AI review queuedMerge PR 'Verify 64-byte transaction inclusion via coinbase-anchored Merkle depth' (#5559)by Matt Corallo · aa895b5e · Nov 11, 2026 · 4 filesMessage 91 · StrongModerate 59Details
from auto-pr-bot/bot/203-accept-genuine-mined-64-base-byt-41f97b into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5559 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This change removes a safety check that previously threw away Bitcoin transactions whose stripped-down form is exactly 64 bytes. That check was meant to guard against a rare Merkle-tree trick, but it also accidentally discarded legitimate Lightning HTLC claim transactions of the same size, which could stop a node from learning a payment secret (preimage) needed to settle a forwarded payment. The patch now verifies those 64-byte transactions normally using the block's Merkle root, so real transactions are accepted while fake ones are still rejected.
AI review queuedMerge PR 'Preserve conflicting output watches' (#5557)by Matt Corallo · e68ee7d2 · Nov 11, 2026 · 4 filesMessage 81 · StrongModerate 61Details
from tnull/2026-10-preserve-output-watches into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5557 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 61/100
This change fixes a bug in how the Lightning Dev Kit's transaction-sync clients (Electrum and Esplora) keep track of watched Bitcoin outputs. Previously, if the same output was registered more than once with different script pubkeys (for example, one real and one bogus), the later registration would overwrite the earlier one. This could cause the client to stop monitoring the real output, potentially missing when it is spent on-chain. The fix stores all registered script pubkeys for each output instead of keeping only the last one, so no conflicting watch can hide a legitimate spend.
AI review queuedMerge PR 'Don't panic on splice txs confirming with empty witnesses' (#5536)by Matt Corallo · 088c6840 · Nov 10, 2026 · 1 fileMessage 81 · StrongModerate 57Details
Commit message · Matt Corallo
Merge PR 'Don't panic on splice txs confirming with empty witnesses' (#5536)
This patch fixes a crash (panic) in the Lightning Dev Kit's channel handling code. Previously, the code assumed that any outbound funding transaction was built by the user, and it would panic if the transaction had an empty witness. Splice transactions are also outbound but are built internally, so the old assumption was wrong. The fix adds a check to only panic for user-built funding transactions, and instead return a normal processing error for internally-built splice transactions that don't match expectations.
AI review queuedDon't panic on splice txs confirming with empty witnessesby Matt Corallo · e80e5653 · Nov 10, 2026 · 1 fileMessage 73 · AdequateModerate 60Details
Commit message · Matt Corallo
Don't panic on splice txs confirming with empty witnesses
When a funding transaction of an outbound channel confirms, we do some sanity-checks and panic if it appears the user used an unsafe funding transaction. Sadly, we retained these panics for outbound channels when a splice funding confirms, which is incorrect as our counterparty may have added the inputs we're looking at.
Thanks to Erick Cestari for reporting this issue.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 60/100
This fix stops a Lightning node from crashing when a special type of channel upgrade transaction called a 'splice' confirms on the Bitcoin blockchain. Before the fix, the node would panic and shut down because it wrongly applied a safety check meant for regular outbound channels to splice transactions, where the other party may have supplied inputs. A malicious or buggy counterparty could potentially trigger this panic, causing a denial of service by crashing the victim's node.
AI review queuedMerge PR 'Reject closing_signed while a fee update remains pending' (#5533)by Matt Corallo · dd658f22 · Nov 10, 2026 · 2 filesMessage 81 · StrongModerate 60Details
Commit message · Matt Corallo
Merge PR 'Reject closing_signed while a fee update remains pending' (#5533)
from tankyleo/leo/2026-10-panic-on-closing-signed into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5533 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
This change fixes a bug in the Lightning Dev Kit where a Bitcoin Lightning channel could panic (crash) if a 'closing_signed' message was processed while a fee update was still pending. The fix rejects such messages and closes the channel gracefully instead of crashing. The test names and code confirm the previous behavior could cause a panic.
AI review queuedMerge PR 'Drop accepted closing_signed state on peer disconnection' (#5532)by Matt Corallo · 87c2743c · Nov 10, 2026 · 2 filesMessage 81 · StrongModerate 59Details
Commit message · Matt Corallo
Merge PR 'Drop accepted closing_signed state on peer disconnection' (#5532)
from auto-pr-bot/bot/223-preserve-accepted-closing-signat-87d4ef into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5532 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This patch fixes a state-handling bug during Lightning channel close negotiations. If a user's signing device was slow or offline and the peer disconnected in the middle, the node could later combine an old accepted fee with a freshly proposed fee, potentially broadcasting an unintended closing transaction. The fix clears the stale 'closing_signed' state when the peer reconnects, forcing the negotiation to restart cleanly.
AI review queuedMerge PR 'Return an empty witness for P2A anchor inputs' (#5510)by Matt Corallo · 6a70008b · Nov 6, 2026 · 1 fileMessage 81 · StrongLow 33Details
Commit message · Matt Corallo
Merge PR 'Return an empty witness for P2A anchor inputs' (#5510)
from auto-pr-bot/bot/184-anchordescriptor-returns-non-sta-5472ff into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5510 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100
This commit fixes how a specific type of Bitcoin transaction input (used in fee-bumping anchors) builds its witness data. Previously it created a witness containing a single empty element; now it creates a truly empty witness. The change is subtle but important because Bitcoin consensus rules treat these two forms differently for a new output type (P2A). The included test confirms the witness is now empty.
AI review queuedMerge PR 'Keep a zero-conf splice locked when its funding is unconfirmed' (#5505)by Matt Corallo · f42f24d4 · Nov 5, 2026 · 2 filesMessage 81 · StrongModerate 55Details
Commit message · Matt Corallo
Merge PR 'Keep a zero-conf splice locked when its funding is unconfirmed' (#5505)
from jkczyz/2026-10-0conf-splice-unconfirm-panic into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5505 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
This patch fixes a logic bug in how the Lightning node handles zero-confirmation splice transactions when they are temporarily kicked out of the blockchain by a reorganization. Previously, the code would incorrectly clear the 'splice_locked' state for a zero-conf splice when its funding transaction became unconfirmed, which could cause the node to resend splice_locked messages or panic. The fix keeps zero-conf splices locked even if the funding transaction is unconfirmed, matching the behavior of zero-conf channels. The commit title and test comments explicitly describe this as preventing a panic and incorrect re-signaling.
AI review queuedAbandon claims of irrevocably spent HTLC outputsby SaidAlaoui · f7da7601 · Nov 5, 2026 · 6 filesMessage 80 · StrongModerate 57Details
Commit message · SaidAlaoui
Abandon claims of irrevocably spent HTLC outputs
When a `ChannelMonitor` learns a preimage after a commitment transaction confirms, it builds the claims of all HTLC outputs on that transaction again. It removes duplicates only against the outpoints which it still tracks. Once the spend of an HTLC output has `ANTI_REORG_DELAY` confirmations, the outpoint is no longer tracked, so the claim is registered again. `ChannelManager::read` replays stored preimages on every load, so a restart is enough to create such a claim. The claim can never confirm, but it stays in the monitor and we yield it again on every rebroadcast.
On every block, `ChannelMonitor` now passes the outputs of the confirmed commitment transaction which have an irrevocable spend to `OnchainTxHandler::abandon_spent_outpoints`. A spend is irrevocable when its HTLC is in `htlcs_resolved_on_chain`, or when its `HTLCSpendConfirmation` has `ANTI_REORG_DELAY` confirmations. The second case covers our own HTLC-Success transactions on our commitment transaction, which wait for the CSV delay before their HTLC is in `htlcs_resolved_on_chain`. A claim which only spends such outputs is dropped, along with the `claimable_outpoints` entries of any outpoints split out of it earlier, which would otherwise make us panic if we saw their spends again. A claim which also spends other outputs is split, and its timer is set to the current height, so that we build the claim of the other outputs again in the same block. This also removes such claims from monitors which were persisted with them.
This also drops the HTLC-Timeout claims of non-anchor channels for HTLC outputs which our counterparty claimed with the preimage. Those packages cannot be split, so they stayed in `locktimed_packages`, and we broadcast an HTLC-Timeout transaction which could never confirm at the HTLC expiry. `test_htlc_on_chain_success` and `retry_with_no_persist` expected those broadcasts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 57/100
This commit fixes a bug in the Lightning Dev Kit where the wallet could keep trying to claim bitcoin that was already spent by someone else. After a channel closes on-chain, the code normally tries to grab any HTLC outputs it can. A bug caused it to recreate already-impossible claims every time it learned a new payment secret or restarted, because it only avoided duplicate claims for outputs it was still actively tracking. Once an output's spend was buried under enough confirmations, it was dropped from tracking, so the old claim was added again. These impossible claims could never confirm, but they stayed in the monitor forever and were re-broadcast repeatedly. In rare cases they could also trigger a panic if a previously-split claim later saw its output spent again. The fix detects outputs that are already irreversibly spent and tells the on-chain transaction handler to abandon those claims, splitting or dropping them as needed.
AI review queuedMerge PR 'Verify UTXO output matches previous transaction in coin selection' (#5490)by wpaulino · f23b996c · Nov 5, 2026 · 1 fileMessage 91 · StrongModerate 59Details
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This change tightens a safety check when a Lightning wallet picks which Bitcoin coins (UTXOs) to spend. Previously, the code only confirmed that the referenced transaction had an output at the expected position. Now it also confirms that the actual output amount and script exactly match what the wallet claims. This prevents a class of bugs or attacks where a wallet source provides a UTXO whose details do not match the real previous transaction, which could lead to building invalid or unexpected funding/closing transactions.
AI review queuedMerge PR 'Give keyed-anchor commitments a chance to confirm when funding fails' (#5089)by wpaulino · 871b6dc5 · Oct 28, 2026 · 1 fileMessage 81 · StrongLow 41Details
Commit message · wpaulino
Merge PR 'Give keyed-anchor commitments a chance to confirm when funding fails' (#5089)
from 2026-10-keyed-anchor-commits-can-confirm into main
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100
This change improves how the Lightning node handles a failed funding attempt for a 'bump' transaction used to speed up a channel close. Previously, if funding the child transaction failed, the pre-signed commitment transaction might never be broadcast, potentially leaving funds stuck. Now, for certain modern channel types (keyed-anchor commitments), the node will still broadcast the pre-signed commitment transaction using its own existing fee, giving it a chance to confirm and recover funds. This is a robustness fix rather than a traditional vulnerability patch.
AI review queuedMerge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)by Matt Corallo · ef55ead8 · Oct 26, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Matt Corallo
Merge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)
from bot/5198-bound-p2pkh-input-weight-for-unc-45b6a6 into main
Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5329 Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This change only adds a documentation comment explaining that a helper function for creating old-style P2PKH Bitcoin outputs assumes the public key is compressed (33 bytes). The actual code behavior is unchanged; the patch simply warns callers not to use this helper for uncompressed (65-byte) public keys because the resulting transaction fee estimate would be too low. There is no code fix or behavior change.