AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

Expose the dummy-hop tail constructor publicly

Public commit record

What the developer wrote

Authored by auto-pr-bot

91/100 · Strong
Expose the dummy-hop tail constructor publicly

@matt asked on the diff:

> @auto-pr-bot this and the remining fns in this impl block shouldn't be
> crate-public.

@matt asked on the diff:

> @auto-pr-bot this should be public.

`BlindedPaymentPath::new_with_dummy_hops` is public, but the `DummyTlvs` it
takes could only be built by hand, leaving external callers to rederive the
per-hop constraint chaining themselves. Expose the constructor that does it,
and document what the returned upstream constraints are for.

The entropy source is only unused under `cfg(test)`, so name the parameter
rather than leaving an underscore-prefixed one in the public signature.

Co-Authored-By: Claude <noreply@anthropic.com>

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4501#issuecomment-445043
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4501#issuecomment-445044
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit makes a previously internal helper function public so that outside developers can build dummy-hop tails for blinded payment paths without recreating the logic themselves. It is an API usability change, not a fix for a known security bug. The function's behavior is unchanged; only its visibility and documentation were updated.

Recommended action

No security action required. Treat as a normal API-visibility/documentation change during code review.

Security signals we found

01

No security-relevant behavior change in the diff

02

API visibility broadened from crate-public to public

03

CLTV expiry overflow check already present and unchanged

04

Entropy source usage unchanged except for naming/test suppression

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.