Correct 0.2.5 and 0.1.12 CHANGELOG entries
What the developer wrote
Authored by Matt Corallo
Correct 0.2.5 and 0.1.12 CHANGELOG entries
* The response panic issue is when accepting *onion messages*
which merit a response, not HTLCs,
* 0.1 was not vulnerable to the panic-on-reorg issue Kyle reported
as it did not contain the new package merging logic.
What changed, and why it matters
This commit only edits the project's CHANGELOG text. It corrects earlier release notes: one panic issue actually involved 'onion messages' (not HTLCs), and an older 0.1 release was not actually vulnerable to a reorg-related panic because it lacked the relevant code. No code behavior changes.
No action needed; this is a documentation correction. Treat as informational only.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a documentation-only correction in CHANGELOG.md. It rewords two prior security entries: (1) changes ‘accepting HTLCs which merit a response’ to ‘accepting onion messages which merit a response’ for releases 0.2.5 and 0.1.12, and (2) clarifies that 0.1.12 was not practically affected by the reorg/batching panic because 0.1 did not include the package-merging logic present in 0.2. No source code is modified.
Changed components
CHANGELOG.mdInspect captured patch +9 / −8
### CHANGELOG.md
@@ -8,8 +8,8 @@
## Security
0.2.5 fixes an on-chain funds-theft vulnerability for nodes forwarding HTLCs
which accept channels from untrusted nodes and several denial of service
-vulnerabilities when forwarding HTLCs, accepting HTLCs which merit a response,
-or in rare cases after a reorg when claiming HTLCs on chain.
+vulnerabilities when forwarding HTLCs, accepting onion messages which merit a
+response, or in rare cases after a reorg when claiming HTLCs on chain.
* When processing an un-revoked counterparty's HTLC claim, ChannelMonitor will
no longer confuse two HTLCs with equivalent `payment_hash` and amounts,
leading to incorrect HTLC resolution (#4854).
@@ -42,9 +42,8 @@ in this release.
## Security
0.1.12 fixes an on-chain funds-theft vulnerability for nodes forwarding HTLCs
-which accept channels from untrusted nodes and several denial of service
-vulnerabilities when accepting HTLCs which merit a response, or in rare cases
-after a reorg when claiming HTLCs on chain.
+which accept channels from untrusted nodes and a denial of service vulnerability
+when accepting onion messages which merit a response.
* When processing an un-revoked counterparty's HTLC claim, ChannelMonitor will
no longer confuse two HTLCs with equivalent `payment_hash` and amounts,
leading to incorrect HTLC resolution (#4854).
@@ -53,14 +52,16 @@ after a reorg when claiming HTLCs on chain.
* LDK will no longer panic attempting to send messages which are too large to
fit in the lightning protocol's framing, though no known cases of this exist
in 0.1 (#4852).
- * LDK will no longer panic in rare cases when multiple pending HTLCs which
- expire at different heights are being claimed on-chain and a reorg occurs
- which changes whether we wish to batch our claim (#4849).
* `UntrustedString` and `PrintableString` now filter line- and paragraph-break
characters as well as control characters, providing additional robustness
especially for log parsing (#4848).
* LDK's limit of 50 peers with unfunded channels is now properly enforced when
peers flood us with `open_channel` messages (#4851).
+ * LDK will no longer panic in rare cases when multiple pending HTLCs which
+ expire at different heights are being claimed on-chain and a reorg occurs
+ which changes whether we wish to batch our claim. Note that unlike in 0.2,
+ 0.1 should not ever meet the last criteria, making this fix theoretical
+ (#4849).
Thanks to Project Loupe and Kyle W. Santiago for reporting security issues fixed
in this release.Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.