rust-lightning

This commit is a routine code cleanup in the Lightning Dev Kit's BOLT 11 invoice serialization code. It replaces heap-allocated boxed iterators with Rust's newer 'impl Trait' return type feature, eliminating unnecessary memory allocations. There is no security-relevant change here.

This commit is a minor code cleanup that removes a Rust compiler warning. It changes how a macro handles the `mut` keyword so that one version of the code no longer triggers an 'unused_mut' warning when compiled with a specific configuration flag. There is no functional change and no security impact.

This is a one-line change that adds a Rust compiler feature gate to silence a warning. It does not change program behavior or fix any security issue.

This commit adds a new automated CI workflow that checks whether changes in the rust-lightning project break the public API used by a related project called LDK Node. It does not change any application code, cryptographic logic, network handling, or user-facing behavior. It is purely a testing/infrastructure addition.

This change fixes a Lightning channel splicing behavior where one side would unnecessarily force-close the channel if the counterparty tried to abort a splice before both sides had exchanged their first commitment signatures. Previously, any tx_abort during the signature-waiting phase triggered a force close. The patch makes the protocol more forgiving: aborting is allowed until the counterparty has actually sent its initial commitment_signed, because before that point no dangerous on-chain transaction has been committed to. Once commitment_signed is received, aborting remains unsafe and still triggers a force close. The change also cleans up internal state when aborting early and adds tests for the new behavior.

This commit only changes internal test helper code in the Lightning Dev Kit repository. It extends a test macro and a test reconnection helper so that automated tests can optionally capture and forward a `tx_abort` message during channel re-establishment scenarios. No production code is modified, and there is no indication this fixes or introduces a security issue.

This commit only copies documentation comments from asynchronous Rust traits and structs to their synchronous counterparts. It fixes broken documentation links and adds notes reminding developers to keep both versions in sync. No code behavior changes.

This commit only adds a documentation comment to a Rust trait method. It does not change any code behavior, logic, or security properties. The added text explains that the method returns a script pubkey usable as a change destination and references another function.

This commit is a documentation-only change. It copies the user-facing documentation from the asynchronous OutputSweeper struct to its synchronous wrapper OutputSweeperSync, and fixes a broken doc link. No code behavior changes, no security fix or vulnerability introduced.

This commit only copies documentation comments from the asynchronous version of a key-value storage trait to its synchronous wrapper. It fixes broken documentation links for language bindings but does not change any code behavior, logic, or security properties.

This is a tiny code cleanup change. It swaps one way of importing the same standard `Vec` type for another, purely to help an automated bindings generator understand the code. There is no security issue here.

This commit adds documentation comments (no-export tags) to two new Rust traits so that automated binding generators know not to expose them to users of language bindings. It is a build/tooling metadata fix, not a code behavior change. There is no direct security impact, but missing tags could previously have caused generated bindings to expose low-level streaming-read APIs that are not intended for bindings users.

This commit is a pure code cleanup: it changes where one internal type, ChannelTransactionParameters, is imported from. There is no functional change, no bug fix, and no security relevance visible in the diff or commit message.

This commit is a documentation-only change in the Rust Lightning library. It adds a comment explaining that a generic signing helper trait called SignFn is intentionally not exposed to language bindings (for users of other programming languages), because each specific signing method already has its own trait and the generic wrapper is awkward to map across languages. No code behavior changed, and there is no security fix or vulnerability here.

This commit only adds documentation comments to Rust structs, traits, and type aliases explaining that they are not exported to language bindings because async support is not available outside Rust. There are no code behavior changes, no bug fixes, and no security patches. It is a documentation-only change for bindings generation tooling.

This commit only adds documentation comments to several Rust functions, explaining that they are not exposed to language bindings (such as Java, Swift, or Python wrappers) because the builder-pattern code relies on Rust-specific move semantics. There are no code behavior changes, no bug fixes, and no security-relevant modifications.

This commit only adds documentation comments to two Rust error types explaining that an internal error detail is intentionally not exposed to language bindings users. There are no code behavior changes, no bug fixes, and no security implications.

This change fixes a race condition in a Lightning service's save-to-disk routine. Previously, the code would clean up certain in-flight peer requests right before saving state, which could accidentally drop a valid request and even disconnect a peer. Now, cleanup of those in-flight requests is done only when a peer disconnects, while saving only cleans up truly expired channel state. The fix reduces the chance of legitimate requests being lost or peers being wrongly removed.

This commit fixes a bug in rust-lightning's new async channel-monitor persistence code. When a background write finished, the program failed to ring a bell (notify a 'Notifier') that wakes up the background processor. That could leave the node temporarily unaware that a critical disk write completed, potentially delaying channel-state processing or, in edge cases, affecting safety guarantees. The fix moves the Notifier into a shared Arc so the async persister can ring it directly when writes finish.

This commit changes the project's GitHub Actions CI workflow to save and reuse fuzz testing data between runs. It is a build/test infrastructure improvement with no direct security vulnerability or code change to the Lightning library itself.

This commit changes the project's automated testing pipeline so that fuzz-testing data generated in one CI job is saved and reused in a later coverage-reporting job. It does not change the actual Lightning protocol code, wallet logic, or any code that end users run. There is no indication this introduces a security vulnerability.

This commit is purely a documentation update: it drafts the release notes for rust-lightning version 0.2 and removes the corresponding pending changelog snippets. No source code, logic, or configuration changes are made, so it cannot introduce or fix a security vulnerability on its own.

This commit only adds a missing documentation comment to the splice_channel function. It explains that a FundingTransactionReadyForSigning event will be generated after signatures are exchanged, and that funding_transaction_signed should then be called. There is no code change, bug fix, or security patch.

This commit only updates documentation comments for two existing events in the Lightning Dev Kit Rust library. It adds guidance telling developers that if they store an intercepted onion message when a peer is offline, they should also handle the peer-connected event to forward the stored message. There are no code changes, no behavior changes, and no security fix or vulnerability.

This commit is a routine code cleanup. It replaces unnecessary `vec!` macro calls with plain array literals in test code and internal test modules. There is no functional change, no bug fix, and no security relevance.