Import `ChannelTransactionParameters` from its real path
What the developer wrote
Authored by Matt Corallo
Import `ChannelTransactionParameters` from its real path
Rather than importing `ChannelTransactionParameters` via the `use`
in `lightning::sign`, import it via its real path in
`lightning::sign::ecdsa`. This makes reading the code (incredibly
marginally) simpler, but also makes the bindings generator happy.
What changed, and why it matters
This commit is a pure code cleanup: it changes where one internal type, ChannelTransactionParameters, is imported from. There is no functional change, no bug fix, and no security relevance visible in the diff or commit message.
No action required; this is a non-security refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies lightning/src/sign/ecdsa.rs to import ChannelTransactionParameters directly from crate::ln::chan_utils instead of re-exporting it through crate::sign. The stated motivation is readability and compatibility with the bindings generator. No logic, signatures, or behavior changes.
Changed components
lightning/src/sign/ecdsa.rsInspect captured patch +3 / −2
diff --git a/lightning/src/sign/ecdsa.rs b/lightning/src/sign/ecdsa.rs
index bfa3a27..e132857 100644
--- a/lightning/src/sign/ecdsa.rs
+++ b/lightning/src/sign/ecdsa.rs
@@ -7,7 +7,8 @@ use bitcoin::secp256k1::ecdsa::Signature;
use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey};
use crate::ln::chan_utils::{
- ClosingTransaction, CommitmentTransaction, HTLCOutputInCommitment, HolderCommitmentTransaction,
+ ChannelTransactionParameters, ClosingTransaction, CommitmentTransaction,
+ HTLCOutputInCommitment, HolderCommitmentTransaction,
};
use crate::ln::msgs::UnsignedChannelAnnouncement;
use crate::types::payment::PaymentPreimage;
@@ -15,7 +16,7 @@ use crate::types::payment::PaymentPreimage;
#[allow(unused_imports)]
use crate::prelude::*;
-use crate::sign::{ChannelSigner, ChannelTransactionParameters, HTLCDescriptor};
+use crate::sign::{ChannelSigner, HTLCDescriptor};
/// A trait to sign Lightning channel transactions as described in
/// [BOLT 3](https://github.com/lightning/bolts/blob/master/03-transactions.md).
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.