LDK
← All projectsLightning Dev Kit

rust-lightning

Composable Rust libraries for building Lightning wallets, nodes, and services.

BitcoinCryptographic librariesLightning NetworkNormal
Repository coverage

1924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

300security candidates261second-pass queue1606AI analyses
174commits · 30 days
261commits · 60 days
636commits · 180 days
1314commits · 365 days
Backfill bands
Aug 5 → Feb 6819 seen18 candidatesComplete
Feb 6 → Jun 6468 seen16 candidatesComplete
Jun 6 → Jul 6128 seen8 candidatesComplete
Jul 6 → Aug 561 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
704Strong · 80–100
856Adequate · 60–79
302Thin · 40–59
62Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Matt Corallo58679418876
Elias Rohrer15415153667
auto-pr-bot571823287
Jeffrey Czyz19645182169
Wilmer Paulino15945155169
Valentine Wallace15715145169
Leo Nash11613116162
Vincenzo Palazzo11311183
Joost Jager16324162069
elnosh401434059
shaavan22622069
wpaulino2059082
Analysis record

Published AI watches

Last scanned 18 minutes ago

Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct FeeEstimator docs on the 253 sat/kW lower bound

This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…

ea2051feby auto-pr-bot+9−31 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Track splice confirmation while awaiting tx_signatures' (#5570)

This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…

State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
ca778e61by Matt Corallo+245−32 files
No security note in commit
Moderate 63 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Account for current HTLC fees in dust exposure' (#5690)

This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …

Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
cc798f60by Matt Corallo+108−382 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Replace cloned array literal with slice::from_ref in reload test' (#5689)

This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.

03ca832fby Matt Corallo+1−11 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Replace cloned array literal with slice::from_ref in reload test

This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …

93e0129cby auto-pr-bot+1−11 file
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)

This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…

17bac68aby Matt Corallo+26−202 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Guard pending closing signatures before channel_ready' (#5681)

This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…

State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
a01273a2by Matt Corallo+169−21 file
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)

This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…

API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
56054190by Matt Corallo+148−155 files
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Refuse to pay BOLT 12 invoices with records above experimental range

This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…

Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
2970372fby auto-pr-bot+106−177 files
No security note in commit
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Read invoice TLV records above the experimental range

This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…

Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
9e28db58by auto-pr-bot+133−84 files
No security note in commit
High 74 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)

This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …

Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
ec40e097by Matt Corallo+74−148 files
Vendor flagged security relevance
Low 37 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)

This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …

Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
643e8684by wpaulino+119−21 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)

This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…

Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
3c606c11by Matt Corallo+298−332 files
No security note in commit
Moderate 52 AI analysisMessage 86 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)

This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…

Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
25f8a740by Matt Corallo+42−171 file
No security note in commit
Low 43 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)

This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…

Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
11815ed1by Matt Corallo+334−74 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)

This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…

83a4d243by Matt Corallo+17−91 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)

This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…

Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
2f832195by Matt Corallo+44−62 files
No security note in commit
Informational 19 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)

This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …

Documentation-only changeNo code logic modifiedNo unsafe blocks added
6e555fa2by Matt Corallo+11−01 file
No security note in commit
High 70 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)

This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…

New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
0e3b6d33by Matt Corallo+324−954 files
Vendor flagged security relevance
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…

State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
d68d2235by Matt Corallo+101−12 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge PR 'Verify built invoice signatures and length' (#5306)by benthecarman · 349f4421 · Oct 23, 2026 · 5 filesMessage 91 · StrongModerate 62Details
Commit message · benthecarman

Merge PR 'Verify built invoice signatures and length' (#5306)

from invoice-signing-hardening into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5306
Reviewed-by: joostjager <joostjager@noreply.git.rust-bitcoin.org>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationsigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This commit hardens how Lightning invoices are created and validated in rust-lightning. It now checks that the digital signature on a freshly built invoice actually matches the invoice contents, and it rejects invoices that would become too long once encoded. Previously, a buggy or malicious signer could produce an invoice with an invalid signature or one that exceeded protocol size limits, which could cause parsing failures or denial-of-service issues for other nodes.

Lower-priorityMerge PR 'Use CollectionLength to serialize ScriptBuf lengths' (#5294)by Val Wallace · 612b3cad · Oct 23, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Use CollectionLength to serialize ScriptBuf lengths' (#5294)

from bot/5197-scriptbuf-serialization-silently-0be75c into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5294
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Revalidate payment hash before reading secrets on retry' (#5320)by Val Wallace · e37d406f · Oct 22, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Revalidate payment hash before reading secrets on retry' (#5320)

from bot/5278-bind-in-progress-retries-to-the-25a1c3 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5320
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationmerge-commit duplicate discount
Lower-priorityMerge PR 'Drop debug_assert when decoding async offer payment contexts' (#5318)by Val Wallace · 164f104e · Oct 22, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Drop debug_assert when decoding async offer payment contexts' (#5318)

from bot/5279-reject-async-offer-contexts-with-4f7f4f into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5318
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge PR 'Reject serializing blinded paths with more than 255 hops' (#5254)by Val Wallace · 2f42409d · Oct 22, 2026 · 1 fileMessage 81 · StrongLow 35Details
Commit message · Val Wallace

Merge PR 'Reject serializing blinded paths with more than 255 hops' (#5254)

from bot/5152-reject-overflowing-blinded-path-14a8f7 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5254
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 35/100

This change hardens how Lightning blinded payment paths are saved or sent over the wire. Previously, if a path somehow contained more than 255 hops, the code would silently chop the count to fit in a single byte and then write out all hops, causing the receiver to read the wrong number of entries and likely crash or misparse the data. Now it still caps the count but also stops writing after 255 hops, and adds a debug-only assertion to catch the oversized path during development.

Lower-priorityMerge PR 'Only log channel disconnection for peers with channels' (#5195)by wpaulino · 83f74511 · Oct 21, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · wpaulino

Merge PR 'Only log channel disconnection for peers with channels' (#5195)

from peer-disconnected-log-channels into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5195
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Fix initial debug commitment balances' (#5302)by wpaulino · 45dc0d97 · Oct 21, 2026 · 3 filesMessage 81 · StrongLow 27Details
Commit message · wpaulino

Merge PR 'Fix initial debug commitment balances' (#5302)

from 2026-10-debug-balances into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5302
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit fixes an internal accounting check used only in debug builds. The balances recorded at channel creation did not subtract the small reserved funds used for anchor-style Lightning transactions, so the recorded counterparty balance could be slightly too high. In rare splice scenarios this mismatch could make a later sanity check fail and crash a debug build, but it would not affect production releases or allow an attacker to steal funds.

Lower-priorityMerge PR 'Release the event queue waker mutex before waking consumers' (#5265)by Matt Corallo · 41416272 · Oct 21, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Release the event queue waker mutex before waking consumers' (#5265)

from bot/5165-release-the-event-queue-waker-mu-595fdf into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5265
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Clarify inherited funding reservations in funding_contributed docs' (#5012)by Matt Corallo · febcc622 · Oct 20, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Clarify inherited funding reservations in funding_contributed docs' (#5012)

from bot/5010-4993-followups-972751 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5012
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Use feature bits 80/81 for option_simple_taproot' (#5189)by Matt Corallo · 794705ce · Oct 20, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Use feature bits 80/81 for option_simple_taproot' (#5189)

from fix-simple-taproot-feature-bit into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5189
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Only prune the network graph after a fresh RGS sync' (#5000)by Matt Corallo · 1012e01d · Oct 20, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Only prune the network graph after a fresh RGS sync' (#5000)

from bot/4999-rgs-graph-can-lose-data-if-we-fa-fe67f8 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5000
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Fix `$EXTRA_CLIPPY_ARGS` consistency' (#5301)by Val Wallace · 27f9d920 · Oct 20, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Fix `$EXTRA_CLIPPY_ARGS` consistency' (#5301)

from 2026-10-clippy-extra-args-fix into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5301
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityFix `$EXTRA_CLIPPY_ARGS` consistencyby Matt Corallo · 96f9cc66 · Oct 20, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Matt Corallo

Fix `$EXTRA_CLIPPY_ARGS` consistency

55a48640da8863e625bd00a7dd178476f4dcfeea attempted to add an
`$EXTRA_CLIPPY_ARGS` env variable but passed it inconsistently
between the test-check and main crate check.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityMerge PR 'Add an `$EXTRA_CLIPPY_ARGS` to `ci/check-lint.sh`' (#5300)by Matt Corallo · 5ca687c6 · Oct 20, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Add an `$EXTRA_CLIPPY_ARGS` to `ci/check-lint.sh`' (#5300)

from 2026-10-clippy-extra-args into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5300
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityAdd an `$EXTRA_CLIPPY_ARGS` to `ci/check-lint.sh`by Matt Corallo · 55a48640 · Oct 20, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Matt Corallo

Add an `$EXTRA_CLIPPY_ARGS` to `ci/check-lint.sh`

This is useful for the PR bot so I can run a different version of
clippy with `-A unknown-lints`.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Security candidateMerge PR 'Fix CI: pin tokio; remove 0.0.125 compat tests' (#5299)by Matt Corallo · 243c2f14 · Oct 20, 2026 · 5 filesMessage 91 · StrongInformational 15Details
Commit message · Matt Corallo

Merge PR 'Fix CI: pin tokio; remove 0.0.125 compat tests' (#5299)

from 2026-10-pin-tokio into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5299
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is purely a maintenance patch for the project's continuous integration (CI) system. It pins the tokio dependency to an older version for older Rust compilers and removes compatibility tests for a very old LDK release (0.0.125). There is no change to production code, no security fix, and no vulnerability introduced.

AI review queuedRemove LDK 0.0.125 upgrade testsby Valentine Wallace · 6c0b9da3 · Oct 20, 2026 · 2 filesMessage 78 · AdequateInformational 15Details
Commit message · Valentine Wallace

Remove LDK 0.0.125 upgrade tests

LDK 0.0.125 no longer compiles on recent rustc: `!` is now the
never-type fallback in all editions, and an unused, untyped TLV field
in 0.0.125's `CommitmentTransaction` deserialization now infers as
`!`, which doesn't implement `Readable`. As no fixed 0.0.x release
exists, drop `test_125_dangling_post_update_actions` and the
`lightning_0_0_125` dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit simply removes an old compatibility test that no longer compiles with recent Rust compiler versions. It is a test-suite maintenance change, not a fix to any production code or security vulnerability. No security issue is introduced or patched.

Security candidatePin tokio to 1.53.3 on pre-1.85 rustcby Valentine Wallace · c8c138a9 · Oct 20, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Valentine Wallace

Pin tokio to 1.53.3 on pre-1.85 rustc

Starting with version 1.54.0, tokio has an MSRV of rustc 1.85. As
tokio is a dependency of our downstream-facing crates (e.g.
lightning-net-tokio), pin it in PIN_RELEASE_DEPS so that the
msrv-no-dev-deps-check build is covered as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
access control
AI analysis · Informational 15/100

This is a routine build-script change that pins the tokio dependency to an older version when using older Rust compilers. It is not a security patch and does not change any production code that handles user data or network traffic.

AI review queuedApply MSRV dependency pins in the tor-connect CI jobby Valentine Wallace · 160aca3d · Oct 20, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Valentine Wallace

Apply MSRV dependency pins in the tor-connect CI job

The tor-connect job runs `cargo test` on rustc 1.75 directly rather
than through one of the ci-tests-*.sh scripts, so it never picked up
the MSRV pins from ci-tests-common.sh. Source it before running the
tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This change is a build-system fix for the project's continuous integration (CI) testing. The tor-connect test job was not applying the project's minimum-supported Rust version (MSRV) dependency pins, which could cause CI test failures when newer dependency versions require newer Rust features. It is not a security patch for the Lightning protocol or library code.

Lower-priorityUse CollectionLength to serialize ScriptBuf lengthsby auto-pr-bot · 8cf8e2d8 · Oct 20, 2026 · 1 fileMessage 93 · StrongTriage 0Details
Commit message · auto-pr-bot

Use CollectionLength to serialize ScriptBuf lengths

`ScriptBuf::write` cast the script length to a `u16`, silently wrapping
for scripts longer than 65,535 bytes while still writing the full
payload. On read that framing broke: the remainder of the script was
left in the stream to be misparsed as whatever field came next, so any
persisted or custom-serialized structure containing such a script would
round-trip corrupted.

Serialize the length with `CollectionLength`, which encodes as a plain
u16 below 0xffff -- matching the BOLT wire format, which prefixes script
lengths with u16s -- and falls back to the escape encoding above it, and
read the script back with the chunked `<Vec<u8> as Readable>` impl so
oversized lengths cannot be used to force large allocations.

@val asked in lightningdevkit/rust-lightning#5197:

> @auto-pr-bot This barely seems worth fixing but I guess open a PR to
> fix the below issue? We can use `CollectionLength` on the write side
> and repurpose the `Read` implementation of `Vec<u8>` for the read
> side, i.e. `Ok(ScriptBuf::from(<Vec<u8> as Readable>::read(r)?))`,
> because it's good about reading in chunks.
>
> Switching to CollectionLength doesn't change the wire format in
> practice: it encodes identically to a u16 for every length below
> 0xffff, and a script that long can't fit in a 65,535-byte wire message
> anyway.

The length-prefixing of scripts in wire messages like `shutdown` is done
separately via `(ScriptBuf, WithoutLength)` and is untouched by this.

Fixes #5197

Requested-by: @val
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5197
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Security candidateSerialize experimental TLV records in unsigned invoicesby auto-pr-bot · 10296a82 · Oct 20, 2026 · 1 fileMessage 96 · StrongModerate 60Details
Commit message · auto-pr-bot

Serialize experimental TLV records in unsigned invoices

The `Writeable` implementation for `UnsignedBolt12Invoice` emitted only
`bytes`, omitting `experimental_bytes`, even though construction and
parsing include that buffer in `tagged_hash` and `sign` appends it to
the signed invoice. Experimental records inherited from the payer's
signed invoice request, including unknown odd TLV records, were
therefore missing from the byte representation exposed before signing.

@jkczyz asked in issue #5192:

> @auto-pr-bot please open a PR to fix this issue

> `UnsignedBolt12Invoice` deliberately separates experimental records
> into `experimental_bytes`: construction and parsing include that
> buffer in `tagged_hash`, and `sign` appends it to the final signed
> invoice. However, its public `Writeable` implementation emits only
> `self.bytes`. Experimental records inherited from the payer's signed
> invoice request (including unknown odd TLVs) are therefore omitted
> from the byte representation exposed before signing even though they
> are authenticated by the signature and present in the resulting
> `Bolt12Invoice`.
>
> This breaks the documented policy-signing boundary:
> `NodeSigner::sign_bolt12_invoice` implementations are allowed to
> inspect the `UnsignedBolt12Invoice` and reject unexpected content
> before releasing the node key signature. A remote/HSM adapter or
> policy signer that serializes the public `Writeable` value to parse
> or reject extensions sees an incomplete object.
>
> The serialization should write `self.bytes` followed by
> `self.experimental_bytes`, without adding a length prefix, matching
> the exact unsigned TLV stream later signed.

[...]

The regression test inherits the repository's test-only experimental
invoice request field through `respond_with_no_std` and checks that
serialization exposes every TLV record committed by `tagged_hash` and
round-trips to the same hash.

Fixes #5192

Requested-by: @jkczyz
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5192
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryfuzzing or regression evidence
AI analysis · Moderate 60/100

This commit fixes a bug in how an unsigned BOLT 12 invoice was serialized before being signed. The public serialization accidentally dropped experimental/custom data fields that were inherited from the payer's invoice request. Because those fields are still included in the cryptographic hash that gets signed, a signer that inspected only the public serialized bytes would see an incomplete picture and could not reliably enforce policies against unknown extensions. The fix makes the public serialization include both the standard bytes and the experimental bytes, matching what is actually signed.

Security candidateSerialize experimental TLV records in unsigned invoice requestsby auto-pr-bot · cf18377f · Oct 20, 2026 · 1 fileMessage 86 · StrongHigh 72Details
Commit message · auto-pr-bot

Serialize experimental TLV records in unsigned invoice requests

The `Writeable` implementation for `UnsignedInvoiceRequest` emitted only
`bytes`, omitting `experimental_bytes`, even though construction and
parsing include that buffer in `tagged_hash` and `sign` appends it to
the signed invoice request. A signer reviewing the unsigned
serialization before releasing a signature would therefore not see
records that the signature commits to.

@jkczyz asked in issue #5193:

> @auto-pr-bot please open a PR to fix this issue

> `UnsignedInvoiceRequest` stores normal records in `bytes` and
> experimental offer/invoice-request records in `experimental_bytes`.
> Its signing hash is computed over both buffers, and `sign` inserts
> the signature before appending `experimental_bytes` to the final
> request. However, the public `Writeable` implementation emits only
> `bytes`. A custom/HSM policy signer receiving the
> `&UnsignedInvoiceRequest` through `SignInvoiceRequestFn` and
> serializing it for review therefore sees fewer fields than it is
> being asked to authenticate. A malicious offer can carry an unknown
> odd experimental extension: the policy approves the truncated
> serialization, while the returned `InvoiceRequest` includes the
> hidden extension under the payer's valid signature. [...]

Fixes #5193, superseding #5289, an earlier standalone fix for the same
issue. The analogous fix for `UnsignedBolt12Invoice` follows in the
next commit.

Requested-by: @jkczyz
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5193
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · High 72/100

This commit fixes a bug in how unsigned invoice requests were serialized before being signed. The code previously left out experimental extra data, meaning a signer reviewing the request would not see everything their signature would later cover. A malicious offer could hide data in that experimental space, getting a valid signature on content the signer never reviewed. The fix makes the unsigned serialization include both the normal and experimental bytes.

Lower-priorityMerge PR 'Reject skipped revocation indices before overwriting stored secrets' (#5228)by Matt Corallo · 25cb452c · Oct 18, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Reject skipped revocation indices before overwriting stored secrets' (#5228)

from bot/5143-reject-skipped-revocation-indice-483752 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5228
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Bump CI rustfmt task to 1.85 and re-format the codebase' (#5261)by Matt Corallo · fe490093 · Oct 17, 2026 · 15 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Bump CI rustfmt task to 1.85 and re-format the codebase' (#5261)

from bot/5260-bump-rustfmt-to-1.85-5c14aa into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5261
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityRe-format the codebase with rustfmt 1.85by auto-pr-bot · c6fda8bc · Oct 17, 2026 · 11 filesMessage 98 · StrongTriage 5Details
Commit message · auto-pr-bot

Re-format the codebase with rustfmt 1.85

@matt asked:

> @auto-pr-bot we're planning on bumping MSRV to 1.85 sooner or later
> anyway, and in the mean time you're wasting tokens figuring out why
> there's diff on rustfmt when you run it on the whole tree. Please bump
> the forgejo build.yml rustfmt task to 1.85 and re-format the codebase
> with rustfmt 1.85.

`cargo fmt` with the 1.85 rustfmt touches 11 files, all in the
`lightning` crate; `lightning-tests` and `fuzz` are already 1.85-clean.
The diff is the formatting rules that changed between the 1.75- and
1.85-era rustfmt: binary expressions that no longer fit break one
operand per line, `let x = if` headers lay out differently, over-long
return types push the opening brace onto its own line, `impl Trait for
Type` breaks before the `for`, and trailing comments realign. No code
changes.

Fixes #5260

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5260
Authored-By: unsloth/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

98/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidence