← Watch feed
fuzz: centralize payment send tracking
Public commit record
78/100 · Adequate
What the developer wrote
Authored by Joost Jager
fuzz: centralize payment send tracking
Rename the send-state query and local variables to describe whether LDK
still has pending work. Route the existing pending-payment registration
through one helper without changing which sends are tracked.
Later payment invariants must apply consistently to direct, forwarded,
and MPP sends. Centralizing this lifecycle decision keeps tracking
changes from diverging between send helpers.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
What changed, and why it matters
This is a small internal cleanup in a fuzz-testing file. It renames a helper function and routes a few bookkeeping calls through a single new helper. There is no change to production code, no change to user-facing behavior, and no security fix.
Recommended action
No action needed. This is a non-security refactoring in test/fuzz infrastructure.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors fuzz/src/chanmon_consistency.rs. It renames check_payment_send_events to payment_has_pending_work and introduces record_send_result to centralize adding a pending payment after a send. The same send paths (direct, forwarded, MPP) now call the same helper instead of duplicating the add_pending block. The logic of which sends are tracked is unchanged; only the code structure is unified.
Changed components
fuzz/src/chanmon_consistency.rsInspect captured patch +31 / −43
diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs
index 7c17dc9..11a3ed1 100644
--- a/fuzz/src/chanmon_consistency.rs
+++ b/fuzz/src/chanmon_consistency.rs
@@ -2043,8 +2043,7 @@ impl PaymentTracker {
}
}
- // Returns a bool indicating whether the payment failed.
- fn check_payment_send_events(source: &ChanMan, sent_payment_id: PaymentId) -> bool {
+ fn payment_has_pending_work(source: &ChanMan, sent_payment_id: PaymentId) -> bool {
for payment in source.list_recent_payments() {
match payment {
RecentPaymentDetails::Pending { payment_id, .. }
@@ -2113,6 +2112,19 @@ impl PaymentTracker {
Route { paths, route_params }
}
+ fn record_send_result(
+ &mut self, source_idx: usize, source: &HarnessNode<'_>, payment_id: PaymentId,
+ payment_hash: PaymentHash, has_pending_work: bool,
+ ) {
+ if has_pending_work {
+ self.nodes[source_idx].add_pending(
+ payment_id,
+ payment_hash,
+ source.next_manager_persistence_generation(),
+ );
+ }
+ }
+
fn send(
&mut self, nodes: &[HarnessNode<'_>; 3], source_idx: usize, dest_idx: usize,
dest_chan_id: ChannelId, amt: u64,
@@ -2141,25 +2153,19 @@ impl PaymentTracker {
let route = Self::route_from_payment_paths(&payment_paths, &[dest], route_params);
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
- let succeeded = match res {
+ let has_pending_work = match res {
Err(err) => {
panic!("Errored with {:?} on initial payment send", err);
},
Ok(()) => {
let expect_failure = amt < min_value_sendable || amt > max_value_sendable;
- let succeeded = Self::check_payment_send_events(source, id);
- assert_eq!(succeeded, !expect_failure);
- succeeded
+ let has_pending_work = Self::payment_has_pending_work(source, id);
+ assert_eq!(has_pending_work, !expect_failure);
+ has_pending_work
},
};
- if succeeded {
- self.nodes[source_idx].add_pending(
- id,
- hash,
- source.next_manager_persistence_generation(),
- );
- }
- succeeded
+ self.record_send_result(source_idx, source, id, hash, has_pending_work);
+ has_pending_work
}
fn send_hop(
@@ -2200,25 +2206,19 @@ impl PaymentTracker {
let route = Self::route_from_payment_paths(&payment_paths, &[middle, dest], route_params);
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
- let succeeded = match res {
+ let has_pending_work = match res {
Err(err) => {
panic!("Errored with {:?} on initial payment send", err);
},
Ok(()) => {
let sent_amt = amt + first_hop_fee;
let expect_failure = sent_amt < min_value_sendable || sent_amt > max_value_sendable;
- let succeeded = Self::check_payment_send_events(source, id);
- assert_eq!(succeeded, !expect_failure);
- succeeded
+ let has_pending_work = Self::payment_has_pending_work(source, id);
+ assert_eq!(has_pending_work, !expect_failure);
+ has_pending_work
},
};
- if succeeded {
- self.nodes[source_idx].add_pending(
- id,
- hash,
- source.next_manager_persistence_generation(),
- );
- }
+ self.record_send_result(source_idx, source, id, hash, has_pending_work);
}
fn send_noret(
@@ -2275,17 +2275,11 @@ impl PaymentTracker {
let route = Self::route_from_payment_paths(&payment_paths, &[dest], route_params);
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
- let succeeded = match res {
+ let has_pending_work = match res {
Err(_) => false,
- Ok(()) => Self::check_payment_send_events(source, id),
+ Ok(()) => Self::payment_has_pending_work(source, id),
};
- if succeeded {
- self.nodes[source_idx].add_pending(
- id,
- hash,
- source.next_manager_persistence_generation(),
- );
- }
+ self.record_send_result(source_idx, source, id, hash, has_pending_work);
}
// MPP payment via hop - splits payment across multiple channels on either or both hops
@@ -2359,17 +2353,11 @@ impl PaymentTracker {
let route = Self::route_from_payment_paths(&payment_paths, &[middle, dest], route_params);
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
- let succeeded = match res {
+ let has_pending_work = match res {
Err(_) => false,
- Ok(()) => Self::check_payment_send_events(source, id),
+ Ok(()) => Self::payment_has_pending_work(source, id),
};
- if succeeded {
- self.nodes[source_idx].add_pending(
- id,
- hash,
- source.next_manager_persistence_generation(),
- );
- }
+ self.record_send_result(source_idx, source, id, hash, has_pending_work);
}
fn claim_payment(&mut self, node: &HarnessNode<'_>, payment_hash: PaymentHash, fail: bool) {
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.