LDK
← All projectsLightning Dev Kit

rust-lightning

Composable Rust libraries for building Lightning wallets, nodes, and services.

BitcoinCryptographic librariesLightning NetworkNormal
Repository coverage

1924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

300security candidates261second-pass queue1606AI analyses
175commits · 30 days
261commits · 60 days
636commits · 180 days
1314commits · 365 days
Backfill bands
Aug 5 → Feb 6819 seen18 candidatesComplete
Feb 6 → Jun 6468 seen16 candidatesComplete
Jun 6 → Jul 6128 seen8 candidatesComplete
Jul 6 → Aug 561 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
704Strong · 80–100
856Adequate · 60–79
302Thin · 40–59
62Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Matt Corallo58679418876
Elias Rohrer15415153667
auto-pr-bot571823287
Jeffrey Czyz19645182169
Wilmer Paulino15945155169
Valentine Wallace15715145169
Leo Nash11613116162
Vincenzo Palazzo11311183
Joost Jager16324162069
elnosh401434059
shaavan22622069
wpaulino2059082
Analysis record

Published AI watches

Last scanned 10 minutes ago

Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct FeeEstimator docs on the 253 sat/kW lower bound

This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…

ea2051feby auto-pr-bot+9−31 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Track splice confirmation while awaiting tx_signatures' (#5570)

This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…

State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
ca778e61by Matt Corallo+245−32 files
No security note in commit
Moderate 63 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Account for current HTLC fees in dust exposure' (#5690)

This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …

Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
cc798f60by Matt Corallo+108−382 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Replace cloned array literal with slice::from_ref in reload test' (#5689)

This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.

03ca832fby Matt Corallo+1−11 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Replace cloned array literal with slice::from_ref in reload test

This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …

93e0129cby auto-pr-bot+1−11 file
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)

This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…

17bac68aby Matt Corallo+26−202 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Guard pending closing signatures before channel_ready' (#5681)

This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…

State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
a01273a2by Matt Corallo+169−21 file
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)

This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…

API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
56054190by Matt Corallo+148−155 files
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Refuse to pay BOLT 12 invoices with records above experimental range

This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…

Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
2970372fby auto-pr-bot+106−177 files
No security note in commit
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Read invoice TLV records above the experimental range

This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…

Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
9e28db58by auto-pr-bot+133−84 files
No security note in commit
High 74 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)

This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …

Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
ec40e097by Matt Corallo+74−148 files
Vendor flagged security relevance
Low 37 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)

This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …

Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
643e8684by wpaulino+119−21 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)

This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…

Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
3c606c11by Matt Corallo+298−332 files
No security note in commit
Moderate 52 AI analysisMessage 86 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)

This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…

Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
25f8a740by Matt Corallo+42−171 file
No security note in commit
Low 43 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)

This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…

Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
11815ed1by Matt Corallo+334−74 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)

This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…

83a4d243by Matt Corallo+17−91 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)

This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…

Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
2f832195by Matt Corallo+44−62 files
No security note in commit
Informational 19 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)

This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …

Documentation-only changeNo code logic modifiedNo unsafe blocks added
6e555fa2by Matt Corallo+11−01 file
No security note in commit
High 70 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)

This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…

New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
0e3b6d33by Matt Corallo+324−954 files
Vendor flagged security relevance
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…

State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
d68d2235by Matt Corallo+101−12 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge PR 'Report bare BOLT 11 invoice amounts that overflow pico BTC' (#5338)by Matt Corallo · 36e3da0a · Oct 29, 2026 · 3 filesMessage 86 · StrongLow 48Details
Commit message · Matt Corallo

Merge PR 'Report bare BOLT 11 invoice amounts that overflow pico BTC' (#5338)

from bot/5332-bolt11invoice-reads-an-amount-of-7cfdc8 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5338
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 48/100

This change fixes a bug in how BOLT 11 Lightning invoices handle very large amounts written without a unit suffix (like 'lnbc18446745...'). Previously, such invoices could bypass an overflow check and later cause arithmetic errors or unexpected behavior when the code tried to convert the amount into smaller units. The patch now rejects these oversized amounts both during parsing and when constructing a signed invoice, returning a clear error instead.

Lower-priorityMerge PR 'Restore ChannelManager event processing after handler cancellation' (#5264)by Matt Corallo · caed8b9f · Oct 29, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Restore ChannelManager event processing after handler cancellation' (#5264)

from bot/5164-reset-channelmanager-event-proce-9305a1 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5264
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Serialize experimental TLV records in unsigned BOLT12 messages' (#5291)by jkczyz · 5535fc30 · Oct 29, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · jkczyz

Merge PR 'Serialize experimental TLV records in unsigned BOLT12 messages' (#5291)

from bot/5192-unsigned-invoice-serialization-h-a81bc9 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5291
Reviewed-by: jkczyz <jkczyz@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Don't archive monitors with unhandled pending events' (#5319)by Val Wallace · 0187e474 · Oct 28, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Don't archive monitors with unhandled pending events' (#5319)

from bot/5280-archiving-drops-unhandled-spenda-ca6a7b into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5319
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Give keyed-anchor commitments a chance to confirm when funding fails' (#5089)by wpaulino · 871b6dc5 · Oct 28, 2026 · 1 fileMessage 81 · StrongLow 41Details
Commit message · wpaulino

Merge PR 'Give keyed-anchor commitments a chance to confirm when funding fails' (#5089)

from 2026-10-keyed-anchor-commits-can-confirm into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5089
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100

This change improves how the Lightning node handles a failed funding attempt for a 'bump' transaction used to speed up a channel close. Previously, if funding the child transaction failed, the pre-signed commitment transaction might never be broadcast, potentially leaving funds stuck. Now, for certain modern channel types (keyed-anchor commitments), the node will still broadcast the pre-signed commitment transaction using its own existing fee, giving it a chance to confirm and recover funds. This is a robustness fix rather than a traditional vulnerability patch.

Lower-priorityMerge PR 'Propagate namespace lookup errors in fs_store listing' (#5270)by tnull · 1ae0cf28 · Oct 28, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Propagate namespace lookup errors in fs_store listing' (#5270)

from bot/5169-propagate-namespace-lookup-error-4398bc into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5270
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Wake all pending async event queue consumers' (#5272)by tnull · 435a0f94 · Oct 28, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Wake all pending async event queue consumers' (#5272)

from bot/5175-wake-all-pending-asynchronous-li-e71a2a into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5272
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Carry negotiated client to_self_delay limit in LSPS2 OpenChannel events' (#5274)by tnull · c49a1f34 · Oct 28, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Carry negotiated client to_self_delay limit in LSPS2 OpenChannel events' (#5274)

from bot/5177-expose-negotiated-lsps2-delay-li-266eb9 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5274
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Reject non-canonical SCIDs in scid_from_human_readable_string' (#5404)by tnull · 7be14adb · Oct 28, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Reject non-canonical SCIDs in scid_from_human_readable_string' (#5404)

from bot/5339-reject-non-canonical-strings-in-188ad9 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5404
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'LSPS2: don't count duplicate request IDs towards the total limit' (#5412)by tnull · 8f0b988f · Oct 28, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'LSPS2: don't count duplicate request IDs towards the total limit' (#5412)

from bot/5342-lsps2-don-t-count-duplicate-requ-e1cc41 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5412
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Reject LSPS JSON-RPC request IDs longer than 256 bytes' (#5415)by tnull · 6eddd0b4 · Oct 28, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · tnull

Merge PR 'Reject LSPS JSON-RPC request IDs longer than 256 bytes' (#5415)

from bot/5343-lightning-liquidity-bound-the-le-aa02c2 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5415
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Stop processing peer messages when their outbound buffer grows too large' (#5241)by Matt Corallo · 9923baee · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Stop processing peer messages when their outbound buffer grows too large' (#5241)

from bot/5147-limit-outbound-buffer-size-durin-9b8108 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5241
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Add additional REVIEWERS.md context for security scanners' (#5225)by tankyleo · 10d9c37c · Oct 27, 2026 · 1 fileMessage 86 · StrongTriage 0Details
Commit message · tankyleo

Merge PR 'Add additional REVIEWERS.md context for security scanners' (#5225)

from 2026-10-reviewer-guidelines into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5225
Reviewed-by: tankyleo <tankyleo@noreply.git.rust-bitcoin.org>

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge PR 'Use the Forgejo REST API directly in the CI failure-issue job' (#5224)by Val Wallace · 48e8d474 · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Use the Forgejo REST API directly in the CI failure-issue job' (#5224)

from 2026-10-ci-failure-job into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5224
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Reject empty prev_channel_ids when decoding HTLCHandlingFailed' (#5355)by Val Wallace · 56e3ac8a · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Reject empty prev_channel_ids when decoding HTLCHandlingFailed' (#5355)

from bot/5335-reject-htlchandlingfailed-record-d81464 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5355
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Pin backtrace to 0.3.76 for rustc 1.82 through 1.87' (#5414)by Matt Corallo · 1d97be68 · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Pin backtrace to 0.3.76 for rustc 1.82 through 1.87' (#5414)

from bot/5413-new-msrv-breakage-b133a3 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5414
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidatePin backtrace to 0.3.76 for rustc 1.82 through 1.87by auto-pr-bot · 2c88e722 · Oct 27, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · auto-pr-bot

Pin backtrace to 0.3.76 for rustc 1.82 through 1.87

@matt asked in issue #5413:

> @auto-pr-bot please add appropriate CI pins to fix the new CI breakage
> like this:
>
> ```
> cargo test -p lightning --quiet --color always --features backtrace
> error: rustc 1.85.1 is not supported by the following packages:
> addr2line@0.27.1 requires rustc 1.88
> backtrace@0.3.77 requires rustc 1.88.0
> gimli@0.34.0 requires rustc 1.88
> Either upgrade rustc or select compatible dependency versions with
> cargo update <name>@<current-ver> --precise <compatible-ver>
> where <compatible-ver> is the latest version supporting rustc 1.85.1
> ```

backtrace v0.3.77 raised its MSRV to 1.88, dragging addr2line 0.27 and
gimli 0.34, which also require rustc 1.88, into the resolution of our
`backtrace` feature. Pinning backtrace to 0.3.76 downgrades those
transitively to 0.25.1 and 0.32.3, which still support our 1.85 MSRV.

The new pin only applies from rustc 1.82, backtrace 0.3.76's own MSRV,
so the existing 0.3.74 pin still covers the 1.75 fuzz-sanity job, and it
stops applying once rustc reaches 1.88.

Fixes #5413

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5413
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlupdate trustfuzzing or regression evidence
AI analysis · Informational 15/100

This is a routine build-maintenance change, not a security fix. A newer version of a Rust dependency called 'backtrace' started requiring a newer Rust compiler than the project officially supports, which broke automated tests. The commit pins that dependency to an older compatible version so the test suite can run again. It does not change any code that handles money, network messages, or cryptography.

Lower-priorityReject inbound channel acceptance when its ID is already in useby auto-pr-bot · 2c414fd0 · Oct 26, 2026 · 2 filesMessage 95 · StrongTriage 5Details
Commit message · auto-pr-bot

Reject inbound channel acceptance when its ID is already in use

do_accept_inbound_channel removed a pending request from
`inbound_channel_request_by_id` and inserted the resulting channel into
`channel_by_id` without rechecking whether that ID had become occupied
since the request was queued. Because a peer chooses its
`temporary_channel_id` freely and a v1 channel's final ID is derived
from a funding outpoint the peer knows before we accept a second
request from it, a pending request could be accepted under the final ID
of another channel from the same peer.

@val asked:

> do_accept_inbound_channel inserts an accepted channel into
> channel_by_id without checking whether that ID became occupied after
> the OpenChannelRequest was queued. A channel-opening peer can first
> negotiate channel A, construct its funding transaction and calculate
> its final channel ID C, then send open_channel B with
> temporary_channel_id=C while A is still indexed under its original
> temporary ID. [...] When the application accepts B, this insert
> silently drops A's funded channel state and replaces it with an
> unfunded channel.

Recheck `channel_by_id` after the accepted channel's ID is known, while
still holding the peer-state lock that guards both ID maps. Checking at
acceptance time covers every way the ID can be taken in the meantime,
including `funding_created` inserting a funded channel under its
funding-derived ID, so the message handlers need no changes of their
own. The stale request is dropped and the caller gets
`ChannelUnavailable`; the already-tracked channel is left untouched.

The regression test queues a colliding request, funds and confirms the
first channel, then asserts that accepting the stale request fails and
the funded channel's state is preserved.

Requested-by: @val

Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
Lower-priorityMerge PR 'Reject static invoices with an empty `offer_chains` list' (#5075)by wpaulino · 82c667a3 · Oct 26, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · wpaulino

Merge PR 'Reject static invoices with an empty `offer_chains` list' (#5075)

from 2026-10-static-inv-chains into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5075
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge PR 'Don't process monitor events in `get_and_clear_pending_msg_events`' (#5031)by wpaulino · 42e3eb03 · Oct 26, 2026 · 17 filesMessage 81 · StrongLow 45Details
Commit message · wpaulino

Merge PR 'Don't process monitor events in `get_and_clear_pending_msg_events`' (#5031)

from 2026-09-dont-process-mon-evs-on-msg-evs into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5031
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathboot or update pathmerge-commit duplicate discount
AI analysis · Low 45/100

This change stops one internal function from automatically processing monitor events when the caller only asked for pending message events. It is a cleanup of how background tasks are triggered, not a fix for an externally exploitable bug. Most of the patch is test updates that reorder event checks to match the new behavior.

Lower-priorityMerge PR 'Bound a prior contribution's RBF adjustment by the caller's `max_feerate`' (#5297)by jkczyz · 38bed341 · Oct 26, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · jkczyz

Merge PR 'Bound a prior contribution's RBF adjustment by the caller's `max_feerate`' (#5297)

from 2026-10-prior-contribution-max-feerate into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5297

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)by Matt Corallo · ef55ead8 · Oct 26, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Matt Corallo

Merge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)

from bot/5198-bound-p2pkh-input-weight-for-unc-45b6a6 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5329
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This change only adds a documentation comment explaining that a helper function for creating old-style P2PKH Bitcoin outputs assumes the public key is compressed (33 bytes). The actual code behavior is unchanged; the patch simply warns callers not to use this helper for uncompressed (65-byte) public keys because the resulting transaction fee estimate would be too low. There is no code fix or behavior change.

AI review queuedDocument that P2PKH weight assumes compressed public keysby auto-pr-bot · 041448af · Oct 26, 2026 · 1 fileMessage 81 · StrongInformational 18Details
Commit message · auto-pr-bot

Document that P2PKH weight assumes compressed public keys

@matt asked:

> @auto-pr-bot please "fix" this by simply updating the documentation to
> note that we require compressed public keys.

`Utxo::new_p2pkh` computes `satisfaction_weight` assuming a compressed
33-byte public key is pushed in the scriptSig. A P2PKH output committing
to an uncompressed 65-byte key needs 128 more weight units than budgeted,
which coin selection would not account for. Rather than overpaying 128
WU on every compressed-key input or changing the API to distinguish the
key form, note the compressed-key requirement in the rustdoc.

Fixes #5198

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5198#issuecomment-462100
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit only adds a documentation comment to a Rust helper function. It clarifies that the function's built-in fee estimate assumes a compressed public key, and should not be used with older uncompressed keys because the transaction fee estimate would be too low. No code behavior changes, so there is no direct exploit. The practical risk is that a developer who ignores the new warning could create a transaction with insufficient fees if they spend an uncompressed-key P2PKH output.

Lower-priorityMerge PR 'Reject real private-channel SCIDs when forwarding onion messages' (#5314)by Matt Corallo · 25787506 · Oct 25, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Reject real private-channel SCIDs when forwarding onion messages' (#5314)

from bot/5240-reject-real-private-channel-scid-023a86 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5314
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Log blinded route tails without payload bytes' (#5100)by Val Wallace · 16aa8b51 · Oct 23, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Val Wallace

Merge PR 'Log blinded route tails without payload bytes' (#5100)

from bot/5084-bound-blinded-payloads-in-route-5ea853 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5100
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount