LDK
← All projectsLightning Dev Kit

rust-lightning

Composable Rust libraries for building Lightning wallets, nodes, and services.

BitcoinCryptographic librariesLightning NetworkNormal
Repository coverage

1497 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

225security candidates209second-pass queue1479AI analyses
71commits · 30 days
208commits · 60 days
663commits · 180 days
1488commits · 365 days
Backfill bands
Aug 5 → Feb 6819 seen18 candidatesComplete
Feb 6 → Jun 6468 seen16 candidatesComplete
Jun 6 → Jul 6128 seen8 candidatesComplete
Jul 6 → Aug 561 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

69/100 average clarity
359Strong · 80–100
790Adequate · 60–79
288Thin · 40–59
60Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Elias Rohrer15315153667
Matt Corallo35847356473
Jeffrey Czyz17741177168
Wilmer Paulino14939149169
Leo Nash11613116162
Valentine Wallace13710135169
Vincenzo Palazzo10210184
Joost Jager16224162069
elnosh301330056
shaavan22622069
Carla Kirk-Cohen78366068
benthecarman18318071
Analysis record

Published AI watches

Last scanned 20 minutes ago

Low 32 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Only fetch TXIDs instead of entire block during gossip verification' (#4846)

This commit changes how the Lightning Dev Kit's block-sync module verifies Lightning network gossip announcements. Instead of downloading entire Bitcoin blocks (which can be large), it now downloads only the list of transaction IDs for a b…

API surface change in UtxoSource traitReduced data exposure: no longer fetches full blocks for gossip verificationNew JSON parsing for txid lists and TxOut values
ebe7a447by Matt Corallo+275−1025 files
No security note in commit
Low 35 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Allow filtered block rescans at the current tip' (#4847)

This commit changes how the Lightning Dev Kit (LDK) node software handles receiving the same block twice through its filtered-block interface. Previously, calling filtered_block_connected with the current tip again would trigger an asserti…

Assertion relaxation in block connection pathPotential denial-of-service vector removed: previously a malicious or buggy filter provider could crash the node by replaying the current tipNew test coverage for same-block filtered rescan
54ddbd0bby Matt Corallo+177−486 files
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Add test framework coverage of `Listen` block connection replays

This commit only adds a new test mode to the project's internal testing framework. It lets developers simulate a specific way blocks are delivered to the Lightning node (a 'replay' through the Listen interface) so that behavior is covered …

bf6ad23eby Matt Corallo+18−32 files
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Update functional test block connection to detect block replays

This commit changes only internal test helper code in the Lightning Dev Kit repository. It makes the functional test framework smarter about 'block replays'—situations where the same block is fed to a test node more than once—so the fake b…

No production code modifiedNo cryptographic, consensus, or networking changesCommit message frames change as test-framework correctness, not security
477facb4by Matt Corallo+41−333 files
No security note in commit
Moderate 66 AI analysisMessage 73 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct HTLC confusion on unrevoked counterparty commitment txs

This patch fixes a bug in the Lightning Dev Kit where the software could confuse HTLCs (payment contracts) on live, unrevoked counterparty commitment transactions with ones from old, revoked transactions. Previously, it relied only on whet…

Incorrect revocation state detection for counterparty commitment transactionsHTLC direction not previously checked when matching against pending HTLCsPromotion of debug assertions to full assertions for HTLC claim path consistency
f06a08a6by Matt Corallo+26−192 files
Vendor flagged security relevance
Low 47 AI analysisMessage 85 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Return `Err`s` instead of panicking on oversized messages

This commit changes how the Lightning networking code handles oversized encrypted messages. Previously, certain conditions would cause the program to crash with a panic. Now the code returns errors instead, which is a defensive improvement…

panic-to-error conversion for oversized message encryption/decryptiondenial-of-service hardening against oversized peer messagesdebug_assert retained to preserve test coverage of invariant violations
08f12bc7by Matt Corallo+68−313 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 85 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Avoid panicking when attempting to send an oversized message

This commit fixes a crash bug in the Lightning Dev Kit's peer message handling. Previously, if a message grew too large to be sent over the encrypted peer connection, the code would panic (abruptly terminate the whole program). The patch m…

Replaces a `.expect()` panic path with a fallible `Result` in peer message encryptionAdds graceful peer disconnection when a critical message cannot be sentIncludes a regression test for oversized-message handling
c5fdc3bfby Matt Corallo+148−901 file
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Avoid oversized relayed failure messages

This patch fixes a crash bug in the Lightning Dev Kit's handling of HTLC failure messages. A downstream peer could send a maximally-sized failure message without attribution data. When the node added its own attribution data while relaying…

Denial-of-service via remote-triggered panic in message encryptionOversized message exceeding Noise/Lightning wire framing limitMissing length validation before adding attribution data during relay
6b1dfb1aby Matt Corallo+64−191 file
Vendor flagged security relevance
Moderate 64 AI analysisMessage 83 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Reject attempts to advance one-hop blinded forward paths

This commit fixes a denial-of-service bug in rust-lightning where a maliciously crafted one-hop blinded reply path could cause the node to panic when it tried to respond. The fix rejects paths with too few hops before advancing them, and a…

Denial-of-service vector via malformed blinded pathPanic in onion construction due to zero-hop pathUntrusted reply path input validation gap
969a40cfby Matt Corallo+49−14 files
Vendor flagged security relevance
High 72 AI analysisMessage 96 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

lightning-types: replace Zl/Zp separators in `PrintableString`

This commit fixes a log-forgery risk in a Rust Lightning library helper called PrintableString. That helper is meant to make untrusted text safe to print by replacing dangerous characters with a placeholder. It already caught most control …

log injection / log forgery via U+2028/U+2029 line separatorsincomplete input sanitisation in PrintableStringpeer-controlled strings (node alias, BOLT 12 description/issuer/payer_note, peer_msg) as attack surface
75defa9cby Vincenzo Palazzo+63−83 files
Vendor flagged security relevance
Moderate 69 AI analysisMessage 73 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Apply the unfunded channel peer limit to all unaccepted channels

This commit fixes a rate-limiting bug in the Lightning Dev Kit (LDK) that let a single peer bypass the cap on how many different peers can have unfunded (not-yet-funded) channels open. Previously, if a peer sent multiple channel requests q…

Denial-of-service resource exhaustion via rapid inbound channel open requestsLogic error in rate-limiting conditionRegression test added for the bypass scenario
56a4ee43by Matt Corallo+87−62 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 88 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Allow filtered block rescans at the current tip

This commit fixes a bug where replaying the current blockchain block through a normal listener callback could crash two core Lightning components (ChannelManager and OutputSweeper) with a panic. The fix recognizes a same-block replay as a …

panic in chain listener callbacksame-block replay/rescan mishandlingassertion failure on valid chain input
686f9860by Elias Rohrer+118−123 files
Vendor flagged security relevance
Moderate 57 AI analysisMessage 78 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Avoid panic when reorged claims cannot merge

This commit fixes a crash bug in the Lightning Dev Kit's on-chain transaction handler. During a deep blockchain reorganization, a previously settled HTLC claim could be 'resurrected' at a block height where it could no longer be combined w…

Assertion/panic in reorg handling pathDeep blockchain reorg as trigger conditionHTLC claim resurrection after reorg
f1dc8487by Matt Corallo+219−52 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 45 · Thin
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Update crate repository links to forgejo

This commit simply updates the 'repository' web links in 15 package metadata files from GitHub to a self-hosted Forgejo instance. It does not change any program code, build logic, dependencies, or security behavior. There is no security is…

eb77676dby benthecarman+15−1515 files
No security note in commit
Low 45 AI analysisMessage 73 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Account for message type prefix len in prevtx length enforcement

This commit fixes a small but real accounting bug in how rust-lightning checks whether a previous transaction (prevtx) attached to a funding input will make the resulting Lightning wire message too large. The code previously compared the m…

Off-by-constant length check in protocol message size enforcementPotential acceptance of a prevtx that produces an oversized Lightning wire messageDenial-of-service / protocol-interop risk from peer message rejection
d29e1415by Wilmer Paulino+21−41 file
No security note in commit
Moderate 54 AI analysisMessage 73 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Retransmit splice_locked for 0-conf channels missing tx_signatures

This commit fixes a bug in the Lightning Dev Kit where, after a disconnection, a node could fail to retransmit a 'splice_locked' message to a peer that was still waiting for transaction signatures. Without this retransmission, the two peer…

Protocol state desynchronization between channel peers after reconnectionMissing retransmission of splice_locked for 0-conf splice channelsPotential channel unusability or stuck splice negotiation
5434015bby Wilmer Paulino+266−12 files
No security note in commit
Low 37 AI analysisMessage 83 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

bolt12: add pay_for_bolt12_invoice for externally-sourced invoices

This commit adds a new API, pay_for_bolt12_invoice, that lets users pay a BOLT 12 invoice even if LDK did not originally request it. It is intended for advanced use cases like multi-sender payments and replaces an older, more restrictive A…

New API removes internal invoice-origin verification, shifting trust boundary to callerDocumentation explicitly warns caller to verify invoice via Bolt12Invoice::verify_using_metadata and to ensure unique payment_id to avoid duplicate paymentsInput validation added for zero amount, overpay, and partial-amount-without-MPP
5b80fe9cby Alkamal01+550−156 files
No security note in commit
Low 26 AI analysisMessage 90 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Include to_self_delay size in DelayedPaymentOutput weight calculation

This commit fixes a small accounting bug in how the Lightning wallet estimates the size (and therefore transaction fee) of a special Bitcoin transaction that sweeps funds back to the user after a channel closes. The old code always assumed…

debug assertion failure possible in development/testing buildstransaction weight/fee estimate overestimation up to 3 WUconstant replaced with per-descriptor length computation
e6652237by Matt Morehouse+97−83 files
No security note in commit
Informational 18 AI analysisMessage 65 · Adequate
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct docs on `ChannelSigner::get_per_commitment_point`

This commit only updates documentation comments for a Rust function called get_per_commitment_point. It removes an outdated warning that the method was non-asynchronous and that returning an error could cause a crash, and replaces it with …

Documentation-only changeRemoves outdated panic warningAdds retry/unblock guidance for signer errors
5057809bby Matt Corallo+6−31 file
No security note in commit
Informational 16 AI analysisMessage 35 · Opaque
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

ln/refactor: remove BlindedTrampolineEntrypoint

This commit is a small internal code cleanup in the Lightning Dev Kit's Trampoline routing code. It removes a separate 'BlindedTrampolineEntrypoint' payload variant and folds an optional blinding point into the existing 'Forward' variant. …

Refactor-only change with no added bounds checks or validationNo mention of vulnerability, CVE, security fix, or bug in commit messageTLV field changed from required to optional, but only for a newly unified variant used in internal construction
3e0c2697by Carla Kirk-Cohen+8−263 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityAdd async implementation of FilesystemStoreby Joost Jager · f72a43cb · Sep 2, 2025 · 9 filesMessage 45 · ThinLow 28Details
Commit message · Joost Jager

Add async implementation of FilesystemStore

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 28/100

This commit adds an async version of the FilesystemStore in the Lightning Dev Kit's Rust library. It changes how file locks are managed and introduces version numbers to keep async writes in order. The change is a feature/refactor rather than a clear security fix, but it touches concurrency and persistence code where bugs could affect data integrity. There is no vendor statement or external report saying this is a security issue.

Lower-priorityRemove stray `println` from LSPS2 testsby Elias Rohrer · 907f9f6b · Sep 2, 2025 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Elias Rohrer

Remove stray `println` from LSPS2 tests

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit removes a leftover debug print statement from a test file. It has no security relevance: the println only ran during automated tests, printed non-sensitive JSON test data, and could not be exploited by users or attackers.

Lower-priorityAdd LSPS5 DOS protections.by Martin Saposnic · 4370cffd · Sep 2, 2025 · 7 filesMessage 80 · StrongModerate 52Details
Commit message · Martin Saposnic

Add LSPS5 DOS protections.

When handling an incoming LSPS5 request, the manager will check
if the counterparty is 'engaged' in some way before responding.
`Engaged` meaning = active channel | LSPS2 active operation | LSPS1 active operation.

Logic: `If not engaged then reject request;`

A single test is added only checking for the active channel condition,
because it's not super easy to get LSPS1-2 on the correct state to check this (yet).
Other tangential work is happening that will make this easier and more tests will come in the near future

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Moderate 52/100

This commit adds a new access-control rule to the LSPS5 (webhook) service in rust-lightning. Before accepting a state-allocating LSPS5 request such as 'set webhook', the service now requires proof that the requesting peer is already 'engaged' with the LSP: either an open Lightning channel, an active LSPS2 JIT-channel flow, or an active LSPS1 order flow. If none of those exist, the request is rejected with a new 'NoPriorActivity' protocol error. The change is framed by the authors as a DoS protection, because registering webhooks consumes server-side state and previously any peer could do it without prior relationship.

Lower-priorityCommit to client's node id in bLIP-52/LSPS2 promiseby Elias Rohrer · e4aece25 · Sep 2, 2025 · 4 filesMessage 73 · AdequateModerate 60Details
Commit message · Elias Rohrer

Commit to client's node id in bLIP-52/LSPS2 promise

Previously, the promise HMAC would only commit to the promise secret and
the `OpeningFeeParams` fields, leaving room for other clients to reuse
the same `OpeningFeeParams` in `BuyRequests` if they'd acquire it
somehow out-of-bounds.

While this flexibility also has some benefits, we here have the service
commit to the client's node id, making sure only the original client
can redeem a specific `OpeningFeeParams`.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 60/100

This change fixes a security issue in the LSPS2 (Lightning Service Provider Specification 2) implementation used by Lightning Dev Kit. Previously, a service's fee-quote 'promise' could be reused by any client who obtained it, potentially letting someone else claim another client's reserved channel-opening terms. The patch now includes the client's unique node identifier in the cryptographic promise, so only the originally quoted client can redeem it.

Lower-priorityRustfmt OutboundPayments::send_payment_for_static_invoiceby Valentine Wallace · 3c98cbc6 · Sep 2, 2025 · 1 fileMessage 63 · AdequateInformational 15Details
Commit message · Valentine Wallace

Rustfmt OutboundPayments::send_payment_for_static_invoice

This method will be edited in upcoming commits, and the codebase policy is to
at least consider removing rustfmt::skips when touching a method.

63/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is purely a formatting cleanup. It removes a 'rustfmt::skip' directive and lets the Rust formatter reformat a single method's signature, destructuring pattern, and function call argument list. No logic, behavior, or security properties of the code change.

Lower-priorityClean up rustfmt'd Channel::get_last_revoke_and_ackby Valentine Wallace · ee6d868c · Sep 2, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Valentine Wallace

Clean up rustfmt'd Channel::get_last_revoke_and_ack

This method was rustfmt'd in the previous commit, here we clean up that
formatting.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is purely a code-style cleanup. It renames a local variable and removes line breaks introduced by an automatic formatter in the previous commit. There is no functional change to the program's behavior and no security relevance.

Lower-priorityRustfmt OutboundPayments::static_invoice_receivedby Valentine Wallace · e3db976f · Sep 2, 2025 · 1 fileMessage 58 · ThinInformational 15Details
Commit message · Valentine Wallace

Rustfmt OutboundPayments::static_invoice_received

This method will be edited in upcoming commits, and the codebase policy is to
at least consider removing rustfmt::skips when touching a method.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is purely a formatting cleanup. It removes a `#[rustfmt::skip]` directive and lets Rustfmt reformat the `static_invoice_received` method with standard indentation and trailing commas. No logic, behavior, or security checks were changed.

AI review queuedRustfmt Channel::get_last_revoke_and_ackby Valentine Wallace · 9177f99a · Sep 2, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Valentine Wallace

Rustfmt Channel::get_last_revoke_and_ack

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only reformats a single Rust function using rustfmt. It removes a #[rustfmt::skip] attribute and adjusts line breaks and indentation. No logic, behavior, or security properties of the code are changed.

Lower-priorityAdd a method to update the current `UserConfig` in `ChannelManager`by Matt Corallo · 72fa1849 · Aug 30, 2025 · 5 filesMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo

Add a method to update the current `UserConfig` in `ChannelManager`

The `UserConfig` is used to set the default configuration on new
channels and also controls some global behavior in
`ChannelManager`, so should probably be updatable without
restarting the node. Here we add such a method.

We also take this opportunity to rename the `UserConfig` related
methods and update their docs since `UserConfig` has been more than
just the default configuration for new channels for some time.

Fixes #2420

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit is a routine feature addition and API cleanup. It adds a way to change the user's configuration while the Lightning node is running, and renames an existing getter method to match. There is no indication of a security bug being fixed.

Lower-priorityMove `ChannelManager::default_configuration` behind a `RwLock`by Matt Corallo · 1bae7401 · Aug 30, 2025 · 5 filesMessage 85 · StrongInformational 14Details
Commit message · Matt Corallo

Move `ChannelManager::default_configuration` behind a `RwLock`

In the next commit we'll add the ability to update the default
configuration used for new channels and which controls some global
decisions in the `ChannelManager`. However, first, we have to put
it behind a mutex so that it can be updated at runtime, which we do
here.

We also take this opportunity to rename `default_configuration` to
simply `config`, since it has been more than only the default
configuration for new channels for some time.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 14/100

This commit is a straightforward internal refactor: it wraps a shared configuration object in a read-write lock and renames a field from `default_configuration` to `config`. There is no security fix here and no exploitable weakness introduced in the diff itself. It is preparation for a future feature that will allow runtime updates to the configuration.

Lower-priorityDrop unused variableby Matt Corallo · 5f83e54e · Aug 29, 2025 · 1 fileMessage 51 · ThinInformational 15Details
Commit message · Matt Corallo

Drop unused variable

An earlier version of 92f1961747aa353826c2c61965c0f30e3a3f42b1
required tracking the funding txo when we initialize splicing, but
it is now unused, so can be dropped.

51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit removes an unused internal variable called original_funding_txo from the code that handles Bitcoin Lightning channel splicing. The variable was stored during splicing setup but never actually used afterward. There is no security issue here—it's a straightforward cleanup that reduces code clutter and avoids storing unnecessary data.

Lower-priorityMake connect_with_unknown_server actually connect to unknown serverby benthecarman · 38c5b703 · Aug 29, 2025 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · benthecarman

Make connect_with_unknown_server actually connect to unknown server

This test would fail for me locally because apparently I had apache
running. This changes it so we look for an open port instead of just
assuming that port 80 is unused.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a minor fix to a single automated test. The test previously assumed port 80 was unused, which failed on machines running a web server like Apache. The change finds an unused local port instead. It does not affect production code or user-facing behavior.

Security candidateRandomize order of inputs from `OutputSweeper`by benthecarman · 8a84ed09 · Aug 28, 2025 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · benthecarman

Randomize order of inputs from `OutputSweeper`

For a marginal increase in privacy, we can randomize the inputs from the
`OutputSweeper`. Since we don't depend on `rand` to randomize the order
I just put the elements into a hashset, then back into a Vec. This
should give us enough randomness without having to introduce a new dep
or make the `OutputSweeper` depend on the `EntropySource`.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomness
AI analysis · Informational 19/100

This commit makes a small privacy improvement to how the OutputSweeper selects which funds to spend. Previously, the order of inputs in a sweep transaction was predictable. Now the code puts them into a hash set and back into a list, which shuffles their order. There is no security bug being fixed here; it is a hardening/privacy tweak.

AI review queuedPush splice initiation through the quiescent pipelineby Matt Corallo · 92f19617 · Aug 28, 2025 · 6 filesMessage 73 · AdequateLow 26Details
Commit message · Matt Corallo

Push splice initiation through the quiescent pipeline

Now that we have a `QuiescentAction` to track what we intend to do
once we reach quiescence, we need to use it to initiate splices.

Here we do so, adding a new `SpliceInstructions` to track the
arguments that are currently passed to `splice_channel`. While
these may not be exactly the right arguments to track in the end,
a lot of the splice logic is still in flight, so we can worry about
it later.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 26/100

This commit changes how Lightning channel 'splicing' (a way to resize a payment channel's on-chain funds) is started. Instead of immediately sending a splice request, the code now first enters a 'quiet' (quiescent) state where both sides pause normal updates, then sends the splice request once both sides agree. It also adds serialization support for new internal data structures so node state can be saved and restored. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a protocol-correctness and state-management improvement for an in-development splicing feature.

AI review queuedAdd a quick TODO about merging cp- and locally-initiated splicesby Matt Corallo · 9200308e · Aug 28, 2025 · 1 fileMessage 30 · OpaqueInformational 15Details
Commit message · Matt Corallo

Add a quick TODO about merging cp- and locally-initiated splices

30/100 · OpaqueMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a code comment (a TODO note) suggesting future work on combining two types of channel funding updates. It changes no program logic, no data handling, and no security behavior. There is nothing here that could directly cause a bug or be exploited.

Lower-priorityReject `splice_init`s when we aren't quiescentby Matt Corallo · 73a6d978 · Aug 28, 2025 · 1 fileMessage 45 · ThinModerate 50Details
Commit message · Matt Corallo

Reject `splice_init`s when we aren't quiescent

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 50/100

This commit adds a safety check in the Lightning Dev Kit's channel code to refuse splice-in operations unless the channel is in a quiet, stable state called 'quiescent.' Before this change, the code apparently allowed splice initiation even when the channel was busy with other activity. The patch prevents potential protocol confusion or unsafe splice handling by disconnecting the peer with a warning if a splice is requested at the wrong time.

Lower-priorityAdd quiescence test of disconnecting waiting on the next stepby Matt Corallo · a206b4df · Aug 28, 2025 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · Matt Corallo

Add quiescence test of disconnecting waiting on the next step

While we have a test to disconnect a peer if we're waiting on an
`stfu` message, we also disconnect if we've reached quiescence but
we're waiting on a peer to do "something fundamental" and they take
too long to do so. We test that behavior here.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new automated test to the rust-lightning project. It does not change any production code. The test verifies that a Lightning node will disconnect a peer if the peer fails to send a required follow-up message after both sides have agreed to pause (quiesce) a channel. Because no actual behavior is modified, this commit does not introduce or fix a security vulnerability on its own.

Lower-priorityAdd funding_locked_txid TLVs to channel_reestablishby Jeffrey Czyz · 857432bc · Aug 28, 2025 · 3 filesMessage 73 · AdequateInformational 18Details
Commit message · Jeffrey Czyz

Add funding_locked_txid TLVs to channel_reestablish

The splicing spec extends the channel_reestablish message with two more
TLVs indicating which funding txid the sender has sent/received either
explicitly via splice_locked or implicitly via channel_ready. This
allows peers to detect if a splice_locked was lost during disconnection
and must be retransmitted. This commit updates channel_reestablish with
the TLVs. Subsequent commits will implement the spec requirements.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit adds new optional message fields to the Lightning channel-reestablish protocol so peers can compare which funding transaction each side believes is active after reconnecting. It is a partial implementation of a protocol extension (splicing). The actual logic that uses these new fields to detect or retransmit lost messages is not included in this commit, so the immediate security risk is very low. It mainly prepares the wire format and data structures for future behavior.

Lower-prioritySet funding_locked_txid TLVs in channel_reestablishby Jeffrey Czyz · d8f421ef · Aug 28, 2025 · 1 fileMessage 73 · AdequateLow 33Details
Commit message · Jeffrey Czyz

Set funding_locked_txid TLVs in channel_reestablish

The previous commit extended the channel_reestablish message with
your_last_funding_locked_txid and my_current_funding_locked_txid for use
as described there. This commit sets those fields to the funding txid
most recently sent/received accordingly.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 33/100

This commit fills in two previously-empty fields in a Lightning channel recovery message. These fields tell each side which funding transaction the other side last confirmed as locked. Setting them correctly helps nodes resume a channel after a disconnect without disagreeing about which funds are active. The change is a follow-up to a prior commit that added the message fields but left them unset.

Security candidateRetransmit commitment_signed before tx_signaturesby Jeffrey Czyz · df80eb05 · Aug 28, 2025 · 1 fileMessage 58 · ThinLow 46Details
Commit message · Jeffrey Czyz

Retransmit commitment_signed before tx_signatures

During channel reestablishment, both commitment_signed and tx_signatures
messages may be retransmitted. However, commitment_signed must come
first, so re-arrange the ordering. This moves tx_abort as well to keep
the interactive tx messages together.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Low 46/100

This commit fixes the order in which two Lightning protocol messages are resent when a channel connection is restored after an outage. The 'commitment_signed' message must now be sent before 'tx_signatures'. Sending them out of order could cause a peer to reject or mishandle the channel re-establishment, potentially disrupting dual-funded channels. It is a protocol correctness fix rather than a clear exploit for theft of funds.

Lower-priorityAdd features for splicingby Jeffrey Czyz · 3f4356ac · Aug 28, 2025 · 1 fileMessage 58 · ThinInformational 18Details
Commit message · Jeffrey Czyz

Add features for splicing

While splicing is not yet fully supported, checking if the feature has
been negotiated is needed for changes to the channel_reestablish logic.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit adds support for advertising a new Lightning protocol feature called 'Splicing' in the feature-bit flags that nodes exchange when connecting. It does not implement splicing itself and does not change any security-sensitive logic. It is a routine protocol-compatibility change.

Security candidateSplit out remaining uses of `is_pre_funded_state` and rename itby Matt Corallo · 4cd52cb9 · Aug 28, 2025 · 2 filesMessage 90 · StrongLow 30Details
Commit message · Matt Corallo

Split out remaining uses of `is_pre_funded_state` and rename it

`Channel::is_pre_funded_state` is used to mean several different
things. In the past few commits we stopped using it for a few
conflicting uses, but here we break out the remaining uses and
rename the remnants for clarity.

`is_funding_broadcast` was using `is_pre_funded_state` and was then
later used to decide if the `Channel` could be written to disk
(because it can be resumed on restart), if we should broadcast a
force-close transaction, and when to emit a `ChannelPending` event.

These were also somewhat divergent - we shouldn't generate a
`ChannelReady` event or broadcast a force-closing transaction until
we've actually broadcasted but want to write the `Channel` to disk
once we enter funding signature exchange for dual-funded open.

Thus, the ability to write a `Channel` to disk is provided by a new
`can_resume_on_restart` method. Then, `is_funding_broadcast` is
updated to only consider funding broadcasted after we provide our
funding signatures (i.e. the funding *could* have been
broadcasted). This is still a bit early to generate a
`ChannelPending` event (as the funding may not actually have been
broadcasted yet), but its better than it was.

Finally, the remaining `is_pre_funded_state` is renamed
`can_resume_on_reconnect`, which has slightly different semantics
than on-restart channels in batch opens.

90/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Low 30/100

This commit is a code-cleanup refactor in a Bitcoin Lightning Network library. It splits one overloaded channel-state check into three more precise checks so that saving channels to disk, deciding when to broadcast force-close transactions, and emitting 'channel is opening' events no longer rely on a single ambiguous flag. The change appears aimed at preventing subtle bugs in dual-funded channel opening, but the commit itself does not claim to fix a known security vulnerability and no exploit is described.

Security candidateDon't use `is_pre_funded_state` to provide an FC monitor updateby Matt Corallo · b7ba29cf · Aug 28, 2025 · 1 fileMessage 91 · StrongModerate 57Details
Commit message · Matt Corallo

Don't use `is_pre_funded_state` to provide an FC monitor update

`Channel::is_pre_funded_state` is used to mean several different
things. In this case its used to decide if we should provide a
`ChannelMonitorUpdate` marking a channel as closed when we go to
force-close it.

Here, we want to capture exactly when the original `ChannelMonitor`
is first created, but were doing so indirectly by looking at the
channel's state. Worse, `is_pre_funded_state` got updated to be
false whenever there is an interctive signing session, which isn't
correct for this use - we may have an interactive signing session
but have already persisted the original `ChannelMonitor` when we
received the first `commitment_signed`.

Instead, we just move to examining
`counterparty_next_commitment_transaction_number` which is
decrementing for the first time at exactly the time we create the
original `ChannelMonitor`, so it provides a much simpler test.

Fixes #3880

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundary
AI analysis · Moderate 57/100

This change fixes a logic bug in how the Lightning node decides whether to send a 'channel is being force-closed' update to its on-disk channel monitor. Previously, the code used a broad channel-state check that could incorrectly skip sending the update during some interactive funding flows, or send it too early in other cases. The patch replaces that broad check with a precise counter that tracks when the original monitor was first created, ensuring the close update is only generated when a monitor already exists. The practical effect is more reliable recovery of funds during force-closes involving modern interactive channel-opening protocols.

Security candidateDont use `is_pre_funded_state` to short-circuit `shutdown` handlingby Matt Corallo · 759d7aac · Aug 28, 2025 · 1 fileMessage 73 · AdequateLow 42Details
Commit message · Matt Corallo

Dont use `is_pre_funded_state` to short-circuit `shutdown` handling

`Channel::is_pre_funded_state` is used to mean several different
things. In this case, its used to skip all the `shutdown` logic as
the funding transaction can't possibly have been broadcasted so
there's really no ned to try to sign a transaction spending it.

Here, we really want to capture any channel in `NegotiatingFunding`
or any V1 channel in `FundingNegotiated` or, finally, any V2
channel in `FundingNegotiated` where we haven't yet sent our
signatures (which is not captured in `is_pre_funded_state`).

Instead of a new helper, we just check the states directly in
`shutdown` handling.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Low 42/100

This change fixes a logic bug in how the Lightning node decides whether to accept a 'shutdown' message from a peer. Previously, the code used a broad helper called 'is_pre_funded_state' to skip shutdown handling, but that helper did not correctly cover newer V2-style channels that have negotiated funding but not yet sent the node's own transaction signatures. In those cases, a peer could send shutdown and the node might try to run full shutdown logic (including signing a spending transaction) even though the funding transaction was not actually broadcastable yet. The patch narrows the check to the exact channel states where shutdown should be short-circuited.

Lower-priorityAdd test for dummy hop insertionby shaavan · fdf352b7 · Aug 28, 2025 · 3 filesMessage 78 · AdequateInformational 13Details
Commit message · shaavan

Add test for dummy hop insertion

Introduces a test to verify correct handling of dummy hops
in constructed blinded paths.
Ensures that the added dummy hops are properly included and
do not interfere with the real path.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 13/100

This commit only adds new tests and updates an existing test helper. It does not change production code behavior. The tests verify that dummy hops can be inserted into blinded paths and that padded versus compact path formats behave as expected. There is no security fix or vulnerability patch here.