LDK
← All projectsLightning Dev Kit

rust-lightning

Composable Rust libraries for building Lightning wallets, nodes, and services.

BitcoinCryptographic librariesLightning NetworkNormal
Repository coverage

1924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

300security candidates261second-pass queue1606AI analyses
174commits · 30 days
261commits · 60 days
636commits · 180 days
1314commits · 365 days
Backfill bands
Aug 5 → Feb 6819 seen18 candidatesComplete
Feb 6 → Jun 6468 seen16 candidatesComplete
Jun 6 → Jul 6128 seen8 candidatesComplete
Jul 6 → Aug 561 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
704Strong · 80–100
856Adequate · 60–79
302Thin · 40–59
62Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Matt Corallo58679418876
Elias Rohrer15415153667
auto-pr-bot571823287
Jeffrey Czyz19645182169
Wilmer Paulino15945155169
Valentine Wallace15715145169
Leo Nash11613116162
Vincenzo Palazzo11311183
Joost Jager16324162069
elnosh401434059
shaavan22622069
wpaulino2059082
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Correct FeeEstimator docs on the 253 sat/kW lower bound

This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimu…

ea2051feby auto-pr-bot+9−31 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Track splice confirmation while awaiting tx_signatures' (#5570)

This change fixes a bug in Lightning Dev Kit's splicing logic. During a splice, one side can broadcast the new funding transaction as soon as it has the other side's signatures. Previously, if that transaction confirmed on-chain before the…

State-machine inconsistency in channel funding lifecycleMissing chain-source watch for in-flight splice funding transactionPotential failure to send splice_locked after splice confirms during signature exchange
ca778e61by Matt Corallo+245−32 files
No security note in commit
Moderate 63 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Account for current HTLC fees in dust exposure' (#5690)

This change fixes how Lightning nodes calculate the financial risk from tiny ('dust') HTLCs when the current on-chain fee rate is higher than the node's own local fee estimate. Previously, the code only considered a buffered fee rate when …

Incorrect fee exposure accounting for dust HTLCsPotential to accept HTLCs whose commitment/HTLC-success fees exceed their value under current feerateEconomic griefing / forced-channel-closure cost manipulation
cc798f60by Matt Corallo+108−382 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Replace cloned array literal with slice::from_ref in reload test' (#5689)

This is a one-line code cleanup in a test file. It replaces a cloned array literal with a slice reference to silence a Rust compiler lint. There is no change to production code, no security fix, and no functional behavior change.

03ca832fby Matt Corallo+1−11 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Replace cloned array literal with slice::from_ref in reload test

This is a one-line change in a test file to satisfy a Rust linter warning. It replaces a needless clone of a funding transaction with a reference-based slice construction. There is no functional change, no user-facing behavior change, and …

93e0129cby auto-pr-bot+1−11 file
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix CI: rebuild test coin-selection impl and rework reused-ID balance test' (#5684)

This commit is a test-only fix for a broken continuous integration (CI) build. It updates a test mock to match a new function signature and rewrites an existing test to use three nodes instead of two so the test scenario remains valid unde…

17bac68aby Matt Corallo+26−202 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Guard pending closing signatures before channel_ready' (#5681)

This change fixes a Lightning channel bug where a malicious peer could renegotiate the closing transaction fee while the local node was still waiting for its own signer to produce the final signature. If allowed, the local node might combi…

State-machine guard expansion to prevent fee renegotiation while a closing signature is pendingRisk of combining mismatched signatures across different closing feesRegression test demonstrates malicious peer renegotiation attempt and expected warning rejection
a01273a2by Matt Corallo+169−21 file
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Release wallet UTXOs when FundingBuilder rejects a coin selection' (#5634)

This change fixes a wallet bug in rust-lightning where a UTXO could be selected for a Lightning funding transaction, then rejected because its previous transaction was too large to fit in a Lightning peer message. Previously, that rejectio…

API change to CoinSelectionSource::select_confirmed_utxos adding max_input_prevtx_serialized_lenWalletSync filters UTXOs by prevtx serialized length before selectionFundingBuilder enforces Lightning tx_add_input message-size limit at selection time
56054190by Matt Corallo+148−155 files
No security note in commit
Low 48 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Refuse to pay BOLT 12 invoices with records above experimental range

This commit hardens LDK's BOLT 12 payment logic so it refuses to pay invoices containing very large unknown record types (4 billion and up). These records are legal under the Lightning spec, but LDK doesn't understand them, so the change t…

Defensive refusal to pay invoices with unknown high-numbered TLV recordsReuses existing UnknownRequiredFeatures failure path instead of adding a new oneAdds explicit checks before payment state insertion and route construction
2970372fby auto-pr-bot+106−177 files
No security note in commit
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Read invoice TLV records above the experimental range

This commit fixes a backward-compatibility bug in LDK's BOLT 12 invoice parser. A previous change had capped the range of 'experimental' TLV record types at 4 billion, but the Lightning spec imposes no upper bound. As a result, invoices cr…

Backward-compatibility regression in deserialization of persisted channel monitorsDenial-of-service via unreadable monitor blocking all channel monitoringSpec compliance fix: TLV record types have no upper bound
9e28db58by auto-pr-bot+133−84 files
No security note in commit
High 74 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to sign messages that collide with gossip serializations' (#5677)

This change fixes a security issue where a signed text message could be crafted so that its prefixed form looks exactly like a Lightning 'node_announcement' gossip message. Because both use the same double-SHA256 hash and the same signing …

Signature replay / message confusion between signed messages and gossip announcementsForged `node_announcement` signatures via chosen-prefix message constructionNew validation rejects prefixed messages that deserialize as `UnsignedNodeAnnouncement`
ec40e097by Matt Corallo+74−148 files
Vendor flagged security relevance
Low 37 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Retry a single HTLC before abandoning an unfundable batch' (#5406)

This change fixes a corner case in how the Lightning node tries to claim multiple pending HTLCs (small Bitcoin payments locked in a channel) when the wallet cannot fund a single large batch transaction. Previously, if the multi-HTLC batch …

Funds-recovery robustness improvement: prevents premature abandonment of a single unbatched HTLCChange in error-handling arithmetic from checked_sub/saturating_sub with max(1)New unit tests covering both failed and successful singleton HTLC funding paths
643e8684by wpaulino+119−21 file
No security note in commit
Moderate 54 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse to persist fresh monitors that alias archived monitors' (#5645)

This change prevents a Lightning node from accidentally overwriting an archived copy of a channel's security monitor with a brand-new one that happens to use the same identifier. In the old code, if a new channel reused the same identifier…

Data-loss prevention: stops archived ChannelMonitor from being overwritten by a later channel with the same keySafety guard added to both sync and async persistence pathsPersistence refusal surfaces as InProgress/UnrecoverableError rather than silent overwrite
3c606c11by Matt Corallo+298−332 files
No security note in commit
Moderate 52 AI analysisMessage 86 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Handle fee multiplication overflow when merging MPP paths' (#5288)

This change fixes a place in the Lightning payment routing code where adding up fees could overflow the maximum number a computer can store in a 64-bit integer. Previously, the code assumed this could never happen and would crash (panic) i…

Integer overflow in fee computationPreviously unreachable!() panic path reachableMPP path merge could trigger overflow
25f8a740by Matt Corallo+42−171 file
No security note in commit
Low 43 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Resume channels stuck awaiting a completed monitor persistence on reload' (#5610)

This commit fixes a bug where a Lightning node could get stuck after restarting. If the node crashed or restarted while it was still saving the initial channel monitor to disk, and that save later finished in another process, the restarted…

Fixes a state-machine stall on node reload that could leave channels non-functionalRemoves an overstrict assertion that would panic on a legitimate post-reload stateAdds explicit detection of monitor persistence completed in a prior process
11815ed1by Matt Corallo+334−74 files
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Correct KeysManager docs on spliced channels' remote_key derivation' (#5609)

This change only updates documentation and code comments in the Lightning Dev Kit library. It clarifies that a particular key-derivation setting is fixed when a channel is first opened and is not changed by splicing. No code behavior was a…

83a4d243by Matt Corallo+17−91 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Fix DelayedPaymentKey/HtlcKey from_basepoint docs and document justice tx witness script' (#5596)

This commit only changes documentation comments in two source files. It corrects the wording of how certain public keys are derived in the Lightning protocol and adds details about which witness script a signer must use when creating justi…

Documentation-only changeClarifies key derivation semantics for Lightning commitment transactionsClarifies justice transaction witness script requirements for signers
2f832195by Matt Corallo+44−62 files
No security note in commit
Informational 19 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Document that TokioSpawner requires all of LDK in a tokio context' (#5621)

This change only adds documentation comments to a Rust struct. It does not modify any executable code, so it cannot by itself introduce or fix a security vulnerability. The new text warns developers that using TokioSpawner incorrectly can …

Documentation-only changeNo code logic modifiedNo unsafe blocks added
6e555fa2by Matt Corallo+11−01 file
No security note in commit
High 70 AI analysisMessage 91 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Make custom signers verify holder commitment sigs synchronously' (#5616)

This commit hardens how Lightning Dev Kit handles custom signing modules. Previously, LDK relied on each custom signer to check that the other party's signatures on a holder commitment transaction were valid. The change adds a ready-made v…

New synchronous signature-verification helper for holder commitment transactionsTrait documentation now mandates verification before Ok(()) because LDK acts immediatelyInMemorySigner now validates that holder funding key belongs to signer before signature checks
0e3b6d33by Matt Corallo+324−954 files
Vendor flagged security relevance
Moderate 64 AI analysisMessage 81 · Strong
LDK Lightning Dev Kitrust-lightning BitcoinCryptographic librariesLightning Network

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node re…

State-machine confusion between funding_signed and channel_ready in async signer flowPremature channel_ready could advance counterparty_next_commitment_point before initial commitment is signedPatch closes channel rather than allowing inconsistent commitment state
d68d2235by Matt Corallo+101−12 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityExpose what a contribution reserved for itselfby Jeffrey Czyz · 31af7812 · Sep 15, 2026 · 7 filesMessage 68 · AdequateTriage 0Details
Commit message · Jeffrey Czyz

Expose what a contribution reserved for itself

A wallet retrying a failed splice contribution must reserve again the
inputs and outputs the failure released. The `DiscardFunding` event
that released them is handled by the wallet, while the retry is decided
by whoever handles `SpliceNegotiationFailed`, and that event exposed
only the full contribution, inherited parts included. So the retry
handler could not tell which parts to reserve.

`FundingContribution::reserved_inputs` and `reserved_outputs` return
the parts the contribution reserved for itself, which are exactly what
a failure releases. They live on the contribution rather than on
`FailedSpliceContribution`, so they remain once that type is replaced
by the contribution itself when downgrading to 0.2 is no longer
supported.

Co-Authored-By: Claude <noreply@anthropic.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityMerge PR 'Clean up the transient-event serialization nits from #4791' (#4996)by Matt Corallo · be7232f1 · Sep 15, 2026 · 5 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Clean up the transient-event serialization nits from #4791' (#4996)

from bot/4791-serialize-transient-event-varian-9095a3 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4996
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'tx-sync: Parallelize esplora status queries' (#4913)by Matt Corallo · c303f515 · Sep 15, 2026 · 1 fileMessage 81 · StrongInformational 19Details
Commit message · Matt Corallo

Merge PR 'tx-sync: Parallelize esplora status queries' (#4913)

from max/2026-08-20-upstream-parallelize-esplora into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4913
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit rewrites how a Lightning wallet talks to Esplora block-explorer servers so that many status checks happen in parallel instead of one at a time. It is a performance/refactoring change. There is no direct evidence in the commit that it fixes a security vulnerability, but it does add a small amount of new error-handling logic and changes timing/ordering assumptions that could affect correctness if the server returns inconsistent data.

Lower-priorityTest a stale template from a round dropped when an earlier one locksby Jeffrey Czyz · 5eb0a2b9 · Sep 14, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Jeffrey Czyz

Test a stale template from a round dropped when an earlier one locks

A template taken while an RBF chain is pending starts from the latest
round's contribution and is tied to it. If an earlier candidate locks
instead, the latest round is dropped, releasing the input it reserved
itself, and a contribution built from the template is rejected as
stale. Its refusal must release only what it added on top of the
inherited parts: the promoted transaction spent one of them, and the
other was released with the dropped round.

Add a test with a two-round chain whose earliest candidate locks after a
template was taken from the second round. It asserts that promotion
releases the second round's own input, that a contribution amending the
template is refused with ContributionInvalid releasing only its fresh
input, and that the released inputs are accepted from a fresh template.

Co-Authored-By: Claude <noreply@anthropic.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityTest a queued contribution owning its parts once an earlier round locksby Jeffrey Czyz · 6a486bb4 · Sep 14, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Jeffrey Czyz

Test a queued contribution owning its parts once an earlier round locks

Across an RBF chain, each round's contribution inherits the inputs and
outputs of the round it replaces and reserves only what it adds, and a
contribution queued behind the chain inherits from the latest round the
same way. When the earliest candidate locks, every later round is
dropped at once and the queued contribution survives if it shares
nothing with the promoted transaction. From then on it owns everything
it holds: the rounds it inherited from are gone, so nothing else will
release what it inherited.

Add a test with a three-round chain whose earliest candidate locks while
a contribution inheriting from the last round is queued. It asserts that
promotion releases only the middle round's own input, withholding the
input the queued contribution inherited, and that canceling the queued
contribution afterwards releases that input along with its own.

Co-Authored-By: Claude <noreply@anthropic.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityReturn a dedicated error from funding_contributedby Jeffrey Czyz · 60178e58 · Sep 14, 2026 · 5 filesMessage 68 · AdequateTriage 0Details
Commit message · Jeffrey Czyz

Return a dedicated error from funding_contributed

`funding_contributed` reported every refusal as an `APIError`, whose
variants were chosen for other `ChannelManager` methods. A stale
template, a splice-out above the channel's maximum, an RBF attempt below
the minimum feerate, a pending splice that can no longer be replaced,
and a channel that is shutting down all surfaced as `APIMisuseError`
with the same message, and the `NegotiationFailureReason` the channel
refused with was dropped. No `SpliceNegotiationFailed` is emitted for a
refused contribution, so the error is the only report the caller gets,
yet it could not tell a refusal that calls for building a new
contribution from a fresh template apart from one where retrying is
pointless.

Return a `SpliceContributionError` instead. `ChannelUnavailable` means
no funded channel matches the given ids, `ContributionPending` means a
contribution of ours is already queued or under negotiation, and
`NegotiationFailed` carries the reason the channel refused with, the
same `NegotiationFailureReason` that `SpliceNegotiationFailed` reports
for an attempt failing later, so its `is_retriable` applies to both.

Co-Authored-By: Claude <noreply@anthropic.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityTest contributions amended from a template whose attempt resolvedby Jeffrey Czyz · 958c3d6a · Sep 14, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Jeffrey Czyz

Test contributions amended from a template whose attempt resolved

A FundingTemplate taken while a splice attempt is pending starts from
that attempt's contribution, so the builder is seeded with its inputs
and outputs and the built contribution records them as inherited. The
application may swap every inherited part for a fresh input it has never
used, leaving a contribution that shares nothing with the attempt. Once
the attempt resolves, whether the candidate locks or the
counterparty-initiated round the contribution had merged into is
aborted, the record still names parts no longer committed anywhere, so
submitting that contribution is rejected as stale although it spends
nothing the attempt held: the channel's splice state changed since the
template was obtained, and the client restarts from a fresh template.

Add two tests asserting that such a contribution is refused, that the
DiscardFunding releasing it lists only the fresh input, and that the
same input is accepted once resubmitted from a fresh template, each
paired with a control that builds the same parts without the prior
contribution and is accepted right away. The helpers are compiled only
for unit tests, as they read the channel's splice candidates through a
test-only accessor while the file is also built with `_test_utils`.

Co-Authored-By: Claude <noreply@anthropic.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI review queuedMerge PR 'Skip Electrum creator transaction downloads' (#4992)by Matt Corallo · c36e50cb · Sep 14, 2026 · 2 filesMessage 81 · StrongLow 30Details
Commit message · Matt Corallo

Merge PR 'Skip Electrum creator transaction downloads' (#4992)

from 2026-09-electrum-skip-creator-download into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4992
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 30/100

This change stops the Electrum-based transaction sync client from downloading the very transaction that created an output it is watching. Previously, the client could request that transaction from Electrum, even though a transaction can never spend its own output. This wasted bandwidth and could leak slightly more information to the Electrum server than necessary. The patch adds a simple skip and a test that verifies no such download happens.

AI review queuedMerge PR 'Use preferred sPK of watched txn in electrum, not rand ones' (#4867)by tnull · bfe5ca89 · Sep 14, 2026 · 3 filesMessage 81 · StrongLow 44Details
Commit message · tnull

Merge PR 'Use preferred sPK of watched txn in electrum, not rand ones' (#4867)

from 2026-08-spk-electrum into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4867
Reviewed-by: tnull <tnull@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This change improves how the Lightning Dev Kit's Electrum and Esplora transaction-sync clients track watched Bitcoin transactions. Previously, the code ignored the script pubkey (the 'address' associated with a transaction) supplied when registering a transaction, and instead picked an arbitrary output from the transaction when querying Electrum servers. The patch now records and prefers the script pubkey(s) the caller actually registered, falling back to an arbitrary non-OP_RETURN output only when needed. This makes the wallet more robust against Electrum servers that may not index certain script types (like OP_RETURN), and against callers that register a transaction with an incorrect script pubkey. It is a hardening fix rather than a clear-cut vulnerability patch, because the commit message and diff do not describe a specific exploitable bug.

Lower-priorityMerge PR 'Abort unknown RBF funding on reconnect' (#4995)by Matt Corallo · 054c95ae · Sep 11, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Abort unknown RBF funding on reconnect' (#4995)

from abort-unknown-rbf-on-reconnect into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4995
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge PR 'Serialize transient Event variants; move persist decision into ChannelManager' (#4791)by Matt Corallo · a0d4632e · Sep 11, 2026 · 8 filesMessage 81 · StrongLow 33Details
Commit message · Matt Corallo

Merge PR 'Serialize transient Event variants; move persist decision into ChannelManager' (#4791)

from 4741-serialize-all-events into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4791
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100

This commit changes how LDK stores pending event notifications. It adds serialization support for several event types that previously were not fully saved to disk, and introduces a helper method so the code can decide which events are worth keeping across restarts. The commit is a defensive correctness improvement: it makes event persistence more consistent and prevents stale or meaningless events from being replayed after a node restarts. It does not appear to fix an active exploit, but it removes a class of bugs where an event could be silently lost or mishandled around restarts.

Lower-priorityReport DiscardFunding from per-contribution records, not channel stateby Jeffrey Czyz · 3cf77e4a · Sep 10, 2026 · 10 filesMessage 81 · StrongTriage 0Details
Commit message · Jeffrey Czyz

Report DiscardFunding from per-contribution records, not channel state

A wallet managing UTXO locks through `Event::DiscardFunding` needs each
input and output it hands to a `FundingContribution` released exactly
once, and never while a splice transaction that can still confirm uses
it. Deriving the event from channel state at failure time cannot do
that. Once the channel is force closed there is no state left, so
refusing a fee bump built from a `FundingTemplate` reported the pending
splice's inputs as discardable, inviting the wallet to double-spend its
own splice. While the channel is open, RBF rounds share inputs and
outputs, so a part could be reported by several failures or by none.

Each contribution instead records what it inherited from the template's
prior contribution, and every failure reports its inputs and outputs
minus that record: exactly what it reserved itself. A part removed by
one round and added back by a later one is reserved by the round that
added it back. When a splice locks, the rounds it replaces release what
they reserved themselves, except that a round negotiated before the
locked one withholds what the locked transaction uses, as the locked
round may have inherited it from there. A surviving queued contribution
takes ownership of what it inherited.

The application must reserve a contribution's parts for it alone, other
than what it inherited, and a retry must reserve the released parts
again first, as a failure's `DiscardFunding` precedes its
`SpliceNegotiationFailed`. As defense in depth, `funding_contributed`
rejects a contribution whose record names funding no longer committed
anywhere, including one built from a template that outlived its
attempt, so misuse strands a lock rather than releasing funding a
confirmable transaction uses.

The refusal's `DiscardFunding` marks the `ChannelManager` as needing
persistence, as it is the only unlock signal the caller will get.

Fixes #4986

Co-Authored-By: Matt Corallo <git+claude@bluematt.me>
Co-Authored-By: Claude <noreply@anthropic.com>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Lower-priorityMerge PR 'Drop the `claimable_payment` entry if the first HTLC is rejected' (#4982)by Matt Corallo · 83bb21dd · Sep 9, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Drop the `claimable_payment` entry if the first HTLC is rejected' (#4982)

from 2026-09-bad-claimable-0.3 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4982
Reviewed-by: Val Wallace <val@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Fix linting CI' (#4984)by Matt Corallo · d9f73d7c · Sep 9, 2026 · 1 fileMessage 76 · AdequateTriage 0Details
Commit message · Matt Corallo

Merge PR 'Fix linting CI' (#4984)

from 2026-09-ci-fix into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4984
Reviewed-by: wpaulino <wpaulino@noreply.git.rust-bitcoin.org>

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge PR 'Document that funding signing events can go stale' (#4960)by Matt Corallo · 26eecf2d · Sep 9, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · Matt Corallo

Merge PR 'Document that funding signing events can go stale' (#4960)

from bot/4951-fundingtransactionreadyforsignin-fa0568 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4960
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds documentation comments to two source files. It explains that certain funding-signing events can become stale if the underlying negotiation fails, and that callers may see specific harmless errors as a result. No code behavior was changed.

Lower-priorityFix linting CIby Matt Corallo · 0a2651f5 · Sep 9, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Matt Corallo

Fix linting CI

due to unused test fn

50/100 · ThinMessage clarity
✓ Subject identifies a change✓ Explains rationale or failure mode✓ Mentions testing or verification! No meaningful explanatory body
Lower-priorityMerge PR 'Abandon queued quiescent action on incoming shutdown after sending stfu' (#4974)by Matt Corallo · 474bc32c · Sep 9, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Abandon queued quiescent action on incoming shutdown after sending stfu' (#4974)

from stfu-shutdown-reconnect-loop into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4974
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Don't archive un-advanced monitors with pending events' (#4983)by Matt Corallo · 1a122fd1 · Sep 9, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Don't archive un-advanced monitors with pending events' (#4983)

from 2026-09-dont-archive-mon-w-evs into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4983
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityAdd release notes for 0.2.6by Matt Corallo · 17bf9ef5 · Sep 9, 2026 · 2 filesMessage 60 · AdequateTriage 0Details
Commit message · Matt Corallo

Add release notes for 0.2.6

Forward port of 1a987b4e93ec01558cabf41ba8177a298734f009

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
Lower-priorityMerge PR 'fuzz resource manager' (#4962)by Matt Corallo · bf158576 · Sep 9, 2026 · 8 filesMessage 86 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'fuzz resource manager' (#4962)

from resource-mgr-fuzz-test into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4962
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

86/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Lower-priorityMerge PR 'reject open_channel with both anchors and zero fee set' (#4976)by Matt Corallo · c41dd894 · Sep 9, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'reject open_channel with both anchors and zero fee set' (#4976)

from reject-invalid-open-channel into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4976
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge PR 'Pin honggfuzz on a stable-toolchain fuzz CI job' (#4978)by Matt Corallo · 512a7269 · Sep 8, 2026 · 6 filesMessage 91 · StrongTriage 0Details
Commit message · Matt Corallo

Merge PR 'Pin honggfuzz on a stable-toolchain fuzz CI job' (#4978)

from bot/4968-fuzz-is-failing-again-a9f6b5 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4978
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Lower-priorityFix test callsites left broken by the dummy-hop mergeby auto-pr-bot · 828336d4 · Sep 8, 2026 · 3 filesMessage 100 · StrongTriage 5Details
Commit message · auto-pr-bot

Fix test callsites left broken by the dummy-hop merge

@matt asked:

> Failing to build this time.
>
> ```
> error: cannot install package `honggfuzz 0.5.62`, it requires rustc 1.85 or newer, while the currently active rustc version is 1.75.0
> `honggfuzz 0.5.61` supports rustc 1.70
> ```
>
> @auto-pr-bot please fix.

The dummy-hop merge (ac8b6b99c, #4501) resolved textually but not
semantically. While that branch was open, main gained the
`Bolt12RefundContext::invoice_request` field and two more callers of
`claim_bolt12_payment`, and the branch meanwhile added refund contexts
without that field and dropped the no-fee `claim_bolt12_payment` wrapper in
favour of the fee-aware one. The result is that `lightning`'s test build does
not compile at that merge, so nothing in the crate can be tested.

Fill in the missing field and pass the extra-fee expectation at the two new
`claim_bolt12_payment` callsites, which pay a single-hop offer over the same
realistic dummy hops the sibling offer tests already charge 50 msat for.

`pay_for_bolt12_invoice_partial_amount{,_multi_payer}` are in the same
position: they predate dummy hops charging anything, so their expected HTLC
and claimable amounts are now short by the dummy-hop fees. Fold those fees
into the expected amounts, as the surrounding tests do.

This is unrelated to the rest of the branch; it is here only so that every
commit builds and tests on its own.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/4968

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidence
AI review queuedAdd `Wallet::release_utxos` to free UTXOs from abandoned transactionsby elnosh · 52ab13fd · Sep 8, 2026 · 3 filesMessage 73 · AdequateModerate 58Details
Commit message · elnosh

Add `Wallet::release_utxos` to free UTXOs from abandoned transactions

`Wallet` reserves every UTXO it selects and, for selections made without
a `ClaimId` such as splice contributions, refuses to offer them to any
later selection. Since a reservation is never dropped, inputs from a
splice that failed to negotiate stayed reserved for the life of the
process, and repeated failures could leave no UTXOs available for anchor
or HTLC claims.

Add `release_utxos` to `Wallet` and `WalletSync` so users can free the
inputs reported in `Event::DiscardFunding`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100

This commit fixes a design flaw in LDK's built-in wallet helper where coins selected for a splice-in (or other unclaimed funding) were permanently reserved in memory if the transaction was abandoned. Over repeated failed splices, all spendable coins could become locked, preventing the node from paying on-chain fees for time-critical Lightning transactions such as HTLC or anchor claims. The patch adds a new release_utxos method that callers must invoke using the inputs reported by Event::DiscardFunding.

Security candidateDrop the honggfuzz version pin from the CI fuzz jobby auto-pr-bot · 4a1635ef · Sep 8, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · auto-pr-bot

Drop the honggfuzz version pin from the CI fuzz job

The pin only ever existed because the job ran on our MSRV toolchain while
honggfuzz's own MSRV had moved past it, so each honggfuzz release broke
the job until someone picked an older version to install. With the job on
stable there is nothing left for the pin to guard: `cargo install
honggfuzz` and the `honggfuzz` 0.5 dependency the fuzz targets link
against both resolve to the current release, which is what we want to be
fuzzing with anyway.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Fixes #4968

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/4968#issuecomment-445091

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlfuzzing or regression evidence
AI analysis · Informational 15/100

This commit removes a fixed-version pin for the honggfuzz fuzzing tool in a continuous-integration script. The project now uses the current release of honggfuzz instead of an older pinned version. There is no change to the actual Lightning protocol code, wallet logic, or any code that end users run in production.