Fuzz: remove unnecessary route_params clones
What the developer wrote
Authored by Valentine Wallace
Fuzz: remove unnecessary route_params clones
What changed, and why it matters
This commit removes two unnecessary .clone() calls on route_params inside a fuzz test file. It is a code cleanup change in test-only code and does not affect production behavior, security, or user funds.
No action required. This is a non-security cleanup in test-only fuzz code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In fuzz/src/chanmon_consistency.rs, two Route structs were constructed with route_params: route_params.clone(). The commit changes both to route_params, moving the already-owned value into the struct instead of cloning it. This is a minor optimization/refactoring in fuzzing harness code; no logic changes.
Changed components
fuzz/src/chanmon_consistency.rsInspect captured patch +2 / −2
diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs
index b0703d8..273af2a 100644
--- a/fuzz/src/chanmon_consistency.rs
+++ b/fuzz/src/chanmon_consistency.rs
@@ -1866,7 +1866,7 @@ impl PaymentTracker {
}],
blinded_tail: None,
}],
- route_params: route_params.clone(),
+ route_params,
};
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
@@ -1946,7 +1946,7 @@ impl PaymentTracker {
],
blinded_tail: None,
}],
- route_params: route_params.clone(),
+ route_params,
};
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.