MJ
← All projectsmonero-java

monero-java

Java SDK for Monero daemon, wallet RPC, and native client-side wallets.

Cryptographic librariesMoneroSoftware walletsNormal
Repository coverage

151 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

10security candidates64second-pass queue74AI analyses
13commits · 30 days
46commits · 60 days
124commits · 180 days
141commits · 365 days
Backfill bands
Sep 27 → Mar 3127 seen2 candidatesComplete
Mar 31 → Jul 2949 seen3 candidatesComplete
Jul 29 → Aug 2815 seen0 candidatesComplete
Aug 28 → Sep 2719 seen1 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

58/100 average clarity
21Strong · 80–100
44Adequate · 60–79
70Thin · 40–59
16Opaque · 0–39
1security candidate with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
woodser148972059
everoddandeven312053
Analysis record

Published AI watches

Last scanned 47 minutes ago

Informational 15 AI analysisMessage 88 · Strong
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

ci: pin openssl 3 and unbound on windows (#185)

This is a routine continuous-integration (CI) build fix for the Windows build pipeline. The project pinned older versions of OpenSSL and Unbound because the MSYS2 package repository upgraded to newer versions that the underlying Monero C++…

320fe570by woodser+11−21 file
No security note in commit
Informational 24 AI analysisMessage 58 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet rpc: fix isClosed() error number code (#183)

This commit fixes a bug in a Java library that talks to a Monero cryptocurrency wallet. The library checks whether the wallet connection is closed by looking for a specific error code returned by the wallet software. The old code looked fo…

Error-code mismatch in liveness/state detectionPotential false-negative closed-state reportingDownstream state-dependent logic could be misled
c6e23efbby everoddandeven+1−11 file
No security note in commit
Low 34 AI analysisMessage 80 · Strong
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

build: pin jackson to 2.21.7

This commit updates the Jackson JSON library and removes its default limit on how long a single string in JSON can be. The stated reason is that Monero's large hexadecimal fields (like transaction data) can exceed Jackson's new default cap…

Disables a built-in Jackson DoS protection (maxStringLength)Library version bump crosses the Jackson 2.15 StreamReadConstraints introduction boundaryChange touches JSON parsing paths used for RPC and general JSON utilities
aba72b2aby woodser+5−13 files
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: cut over to regtest and run the marked tests in CI

This commit is a test-infrastructure change. It switches the project's automated tests from relying on an external Monero testnet/stagenet network to using a self-contained local 'regtest' (fakechain) network that the tests start and manag…

5ad9e79cby woodser+858−22624 files
No security note in commit
Informational 18 AI analysisMessage 55 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet: normalize the empty tx proof signature error from linux wallet rpc

This is a tiny error-message cleanup in a Java Monero wallet library. The code that detects an empty transaction proof signature from the Linux wallet RPC now accepts messages that start with 'basic_string' rather than only the exact strin…

Error normalization only; no validation bypass introducedNo change to signature verification or proof checking logicNo change to RPC method parameters or call semantics
3a0f4862by woodser+1−11 file
No security note in commit
Informational 13 AI analysisMessage 83 · Strong
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: compare the wallet reserve proof with the balance deterministically

This commit only changes a test file. It makes a wallet reserve-proof test more deterministic by waiting for pending transactions to clear and comparing the wallet balance against the proof's total minus unconfirmed spent amount. There is …

40b54625by woodser+6−81 file
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: compare the wallet reserve proof with the balance deterministically

This is a test-only change that makes a wallet reserve proof test more deterministic. It waits for pending transactions to clear and adjusts the balance comparison to account for spent outputs. There is no change to production code or any …

088d6703by woodser+6−81 file
No security note in commit
Low 27 AI analysisMessage 50 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet: handle null tx notes consistently across backends

This commit fixes two consistency problems when saving notes attached to Monero transactions. First, the Java RPC wallet now turns Java `null` notes into empty strings before sending them to the wallet RPC, because the RPC server rejects J…

Null-pointer handling gap between RPC and full wallet backendsPotential JVM crash in JNI string release path for null transaction notesBehavioral normalization of null values to empty strings to match backend expectations
76ab6ec2by woodser+32−34 files
No security note in commit
Informational 24 AI analysisMessage 50 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet: handle null tx notes consistently across backends

This commit fixes two consistency bugs in how transaction notes are saved in a Monero wallet library. First, when using the local JNI wallet backend, passing a null note could cause a crash because the code tried to release a non-existent …

Null-pointer/crash hardening in JNI string handlingInput normalization prevents RPC rejection of null valuesBehavioral consistency between wallet backends
a80720aeby woodser+32−34 files
No security note in commit
Low 30 AI analysisMessage 70 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

utils: enforce MoneroError contract in validateAddress

This commit fixes a bug in a Monero Java library where checking whether an address is valid could accidentally throw a raw, confusing error (such as 'Overflow 2') instead of cleanly returning false. The change makes sure malformed addresse…

Unchecked exception leak from address validationAPI contract violation in input validation routinePotential denial-of-service vector if callers do not handle raw RuntimeException from validation
39af4b7aby woodser+4−12 files
No security note in commit
Informational 24 AI analysisMessage 50 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet: send amounts to wallet rpc as json numbers for v0.18.5.3

This commit changes how the Java wallet library sends monetary amounts to the Monero wallet RPC server. Previously, amounts were converted to strings before being sent; now they are sent as JSON numbers. This is a compatibility fix for Mon…

Data type mismatch between client and RPC server could lead to failed or misinterpreted transactionsAmount handling changes in transaction creation and reserve proof generation pathsNo input validation or bounds checks added in the patch
6d0cd696by woodser+3−31 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

docs: update api docs

This commit only updates generated Java API documentation (Javadoc HTML files). It adds descriptions explaining how SSL/TLS certificate verification works when connecting to a Monero daemon. No actual program code was changed, so this comm…

f93bae8eby woodser+17−45 files
No security note in commit
Informational 15 AI analysisMessage 67 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

ci: run TLS regression tests

This commit only changes the project's automated build configuration to run a few extra tests during continuous integration. It does not modify any application code, libraries, or user-facing behavior. There is no security fix or vulnerabi…

8c6f97c0by woodser+3−31 file
No security note in commit
Moderate 59 AI analysisMessage 60 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet: propagate TLS verification to native and RPC wallets

This commit fixes how Java wallet code passes TLS/SSL certificate verification settings down to the underlying native Monero wallet and to RPC wallets. Previously, the Java layer could request 'verify the certificate' or 'allow any certifi…

TLS/SSL verification preference now propagated across JNI to native walletRPC wallet now translates connection sslVerify into ssl_allow_any_cert and ssl_support parametersConnection equality/hashCode now includes sslVerify, preventing silent mismatches
43c2a9ecby woodser+240−4010 files
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

docs: update api docs

This commit only updates generated API documentation (Javadoc HTML files). It does not change any actual program code, so it cannot introduce or fix a security vulnerability on its own.

bf0ac8c3by woodser+278−2317 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: isolate key image import test

This commit only changes a test file. It rewrites one wallet test so that it uses a separate offline wallet instead of importing outputs back into the same wallet. There is no change to production code and no security fix or vulnerability …

86567073by woodser+16−151 file
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: sync balances before multi-destination sends

This commit only changes a test file. It makes a wallet test wait for mining to stop and sync balances before checking send results. There is no change to production wallet code, no user-facing behavior change, and no security fix.

e6fd994cby woodser+4−01 file
No security note in commit
Informational 23 AI analysisMessage 65 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet rpc: retain unlock notifications after long polling gaps

This change fixes a bug in a Monero wallet's long-polling notification system. Previously, if there was a long gap between polls, the wallet could use a height bound that was too recent and miss transactions that had since unlocked. The fi…

Functional bug in wallet notification logicPotential missed unlock notifications after polling gapsNo cryptographic, authentication, or input-validation changes
7a1a3af4by woodser+6−21 file
No security note in commit
Informational 14 AI analysisMessage 75 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

tests: synchronize notification balances before sending

This commit only changes a test file. It makes the wallet notification tests more reliable by syncing balances before sending and ensuring mining, listeners, and temporary wallets are cleaned up even if the test fails. There is no change t…

555c973bby woodser+237−2071 file
No security note in commit
Low 35 AI analysisMessage 65 · Adequate
MJ monero-javamonero-java Cryptographic librariesMoneroSoftware wallets

wallet rpc: reset snapshots when switching wallets

This commit fixes a lifecycle bug in the Monero Java wallet library. When a user switches from one wallet to another, background polling and notification threads could keep running with stale data from the previous wallet. The patch adds g…

stale callback invalidation across wallet lifecycle changesgeneration-counter pattern to prevent use of stale snapshotsbackground poller and ZMQ listener reset on wallet clear/switch
2bdc3fc8by woodser+105−322 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateci: pin openssl 3 and unbound on windows (#185)by woodser · 320fe570 · Nov 22, 2026 · 1 fileMessage 88 · StrongInformational 15Details
Commit message · woodser

ci: pin openssl 3 and unbound on windows (#185)

mingw64 moved to openssl 4, which monero does not compile against,
and removed unbound, so install the archived openssl 3 builds.

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controldocumentation-only discount
AI analysis · Informational 15/100

This is a routine continuous-integration (CI) build fix for the Windows build pipeline. The project pinned older versions of OpenSSL and Unbound because the MSYS2 package repository upgraded to newer versions that the underlying Monero C++ code cannot currently compile against. There is no security vulnerability being fixed here; it is purely a compatibility/workflow maintenance change.

AI review queuedwallet rpc: fix isClosed() error number code (#183)by everoddandeven · c6e23efb · Nov 18, 2026 · 1 fileMessage 58 · ThinInformational 24Details
Commit message · everoddandeven

wallet rpc: fix isClosed() error number code (#183)

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit fixes a bug in a Java library that talks to a Monero cryptocurrency wallet. The library checks whether the wallet connection is closed by looking for a specific error code returned by the wallet software. The old code looked for error code -8, but the wallet actually returns error code -13 in this situation, so the library could wrongly think an open wallet was closed. This is mostly a reliability/correctness issue rather than a direct security vulnerability, but it could cause applications to behave incorrectly or make wrong decisions about wallet state.

Security candidatebuild: pin jackson to 2.21.7by woodser · aba72b2a · Nov 4, 2026 · 3 filesMessage 80 · StrongLow 34Details
Commit message · woodser

build: pin jackson to 2.21.7

Replace the 2.13 version range so dependabot can bump it, and lift
jackson's default string length cap which large hex fields can exceed.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
access controlautomated dependency-update discount
AI analysis · Low 34/100

This commit updates the Jackson JSON library and removes its default limit on how long a single string in JSON can be. The stated reason is that Monero's large hexadecimal fields (like transaction data) can exceed Jackson's new default cap. Removing the cap could, in principle, allow a malicious JSON response to force the library to allocate very large amounts of memory, leading to a denial-of-service crash. However, the commit itself is framed as a build/compat fix, not a security patch, and no exploit or incident is described.

AI review queuedtests: cut over to regtest and run the marked tests in CIby woodser · 5ad9e79c · Nov 3, 2026 · 24 filesMessage 75 · AdequateInformational 15Details
Commit message · woodser

tests: cut over to regtest and run the marked tests in CI

Add a regtest fixture and isRegtest flag; tag tests for fresh chains,
and run them in CI alongside offline tests.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a test-infrastructure change. It switches the project's automated tests from relying on an external Monero testnet/stagenet network to using a self-contained local 'regtest' (fakechain) network that the tests start and manage themselves. It also tags tests so they can run in CI. There is no user-facing security fix or vulnerability patch here.

Security candidatewallet: normalize the empty tx proof signature error from linux wallet rpcby woodser · 3a0f4862 · Nov 2, 2026 · 1 fileMessage 55 · ThinInformational 18Details
Commit message · woodser

wallet: normalize the empty tx proof signature error from linux wallet rpc

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100

This is a tiny error-message cleanup in a Java Monero wallet library. The code that detects an empty transaction proof signature from the Linux wallet RPC now accepts messages that start with 'basic_string' rather than only the exact string 'basic_string'. This makes the user-facing error message more reliable but does not change what the wallet allows or rejects.

AI review queuedtests: compare the wallet reserve proof with the balance deterministicallyby woodser · 40b54625 · Oct 23, 2026 · 1 fileMessage 83 · StrongInformational 13Details
Commit message · woodser

tests: compare the wallet reserve proof with the balance deterministically

Wait for pending wallet txs to clear and compare the balance with the proof
total minus spent, which tolerates outputs spent at an unknown height.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This commit only changes a test file. It makes a wallet reserve-proof test more deterministic by waiting for pending transactions to clear and comparing the wallet balance against the proof's total minus unconfirmed spent amount. There is no change to production code, no fix for a security flaw, and no disclosed security relevance.

AI review queuedtests: compare the wallet reserve proof with the balance deterministicallyby woodser · 088d6703 · Oct 23, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · woodser

tests: compare the wallet reserve proof with the balance deterministically

Wait for pending wallet txs to clear and compare the balance with the proof
total minus spent, which tolerates outputs spent at an unknown height.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a test-only change that makes a wallet reserve proof test more deterministic. It waits for pending transactions to clear and adjusts the balance comparison to account for spent outputs. There is no change to production code or any security fix.

AI review queuedwallet: handle null tx notes consistently across backendsby woodser · 76ab6ec2 · Oct 22, 2026 · 4 filesMessage 50 · ThinLow 27Details
Commit message · woodser

wallet: handle null tx notes consistently across backends

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit fixes two consistency problems when saving notes attached to Monero transactions. First, the Java RPC wallet now turns Java `null` notes into empty strings before sending them to the wallet RPC, because the RPC server rejects JSON null values while the local full wallet treats null as 'clear the note.' Second, the native JNI bridge now only releases the string memory when a string actually exists, avoiding a possible crash when a null note is passed from Java to the native C++ wallet. Tests were added to confirm that null clears a note and that the caller's list is not modified.

AI review queuedwallet: handle null tx notes consistently across backendsby woodser · a80720ae · Oct 22, 2026 · 4 filesMessage 50 · ThinInformational 24Details
Commit message · woodser

wallet: handle null tx notes consistently across backends

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit fixes two consistency bugs in how transaction notes are saved in a Monero wallet library. First, when using the local JNI wallet backend, passing a null note could cause a crash because the code tried to release a non-existent Java string. Second, when using the remote RPC wallet backend, null notes were sent as JSON null, which the RPC server rejects, while the local backend treats null as 'clear the note.' The patch makes both backends treat null notes as empty strings, and adds tests to confirm the behavior. It is a reliability fix rather than an active security vulnerability.

Security candidateutils: enforce MoneroError contract in validateAddressby woodser · 39af4b7a · Oct 18, 2026 · 2 filesMessage 70 · AdequateLow 30Details
Commit message · woodser

utils: enforce MoneroError contract in validateAddress

isValidAddress threw raw exceptions like Overflow 2 instead of returning false for malformed input.

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validation
AI analysis · Low 30/100

This commit fixes a bug in a Monero Java library where checking whether an address is valid could accidentally throw a raw, confusing error (such as 'Overflow 2') instead of cleanly returning false. The change makes sure malformed addresses are wrapped in the library's standard MoneroError so callers get predictable behavior.

AI review queuedwallet: send amounts to wallet rpc as json numbers for v0.18.5.3by woodser · 6d0cd696 · Oct 4, 2026 · 1 fileMessage 50 · ThinInformational 24Details
Commit message · woodser

wallet: send amounts to wallet rpc as json numbers for v0.18.5.3

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit changes how the Java wallet library sends monetary amounts to the Monero wallet RPC server. Previously, amounts were converted to strings before being sent; now they are sent as JSON numbers. This is a compatibility fix for Monero daemon version 0.18.5.3, which expects numeric values rather than strings. There is no direct evidence in the commit that this is a security vulnerability, but sending the wrong data type could cause transaction creation or proof generation to fail or behave unexpectedly.

AI review queueddocs: update api docsby woodser · f93bae8e · Oct 3, 2026 · 5 filesMessage 40 · ThinInformational 15Details
Commit message · woodser

docs: update api docs

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates generated Java API documentation (Javadoc HTML files). It adds descriptions explaining how SSL/TLS certificate verification works when connecting to a Monero daemon. No actual program code was changed, so this commit cannot by itself introduce or fix a security vulnerability.

AI review queuedci: run TLS regression testsby woodser · 8c6f97c0 · Oct 3, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · woodser

ci: run TLS regression tests

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencedocumentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only changes the project's automated build configuration to run a few extra tests during continuous integration. It does not modify any application code, libraries, or user-facing behavior. There is no security fix or vulnerability being introduced.

AI review queuedwallet: propagate TLS verification to native and RPC walletsby woodser · 43c2a9ec · Oct 1, 2026 · 10 filesMessage 60 · AdequateModerate 59Details
Commit message · woodser

wallet: propagate TLS verification to native and RPC wallets

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes how Java wallet code passes TLS/SSL certificate verification settings down to the underlying native Monero wallet and to RPC wallets. Previously, the Java layer could request 'verify the certificate' or 'allow any certificate,' but that setting was not reliably forwarded across the JNI bridge or translated into the correct RPC parameters. The patch renames several native methods, adds an ssl_verify flag through the bridge, and makes the RPC wallet honor the connection's verification preference. It also fixes a related bug where changing a connection's SSL setting changed its hash code, which could break connection-manager tracking.

AI review queueddocs: update api docsby woodser · bf0ac8c3 · Sep 24, 2026 · 7 filesMessage 40 · ThinInformational 15Details
Commit message · woodser

docs: update api docs

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates generated API documentation (Javadoc HTML files). It does not change any actual program code, so it cannot introduce or fix a security vulnerability on its own.

Security candidatetests: isolate key image import testby woodser · 86567073 · Sep 23, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · woodser

tests: isolate key image import test

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Informational 15/100

This commit only changes a test file. It rewrites one wallet test so that it uses a separate offline wallet instead of importing outputs back into the same wallet. There is no change to production code and no security fix or vulnerability is visible in the diff.

AI review queuedtests: sync balances before multi-destination sendsby woodser · e6fd994c · Sep 23, 2026 · 1 fileMessage 75 · AdequateInformational 15Details
Commit message · woodser

tests: sync balances before multi-destination sends

Stop mining and sync before capturing balances used by send assertions.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a test file. It makes a wallet test wait for mining to stop and sync balances before checking send results. There is no change to production wallet code, no user-facing behavior change, and no security fix.

AI review queuedwallet rpc: retain unlock notifications after long polling gapsby woodser · 7a1a3af4 · Sep 23, 2026 · 1 fileMessage 65 · AdequateInformational 23Details
Commit message · woodser

wallet rpc: retain unlock notifications after long polling gaps

Use the previous snapshot height bound when looking up tracked txs.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This change fixes a bug in a Monero wallet's long-polling notification system. Previously, if there was a long gap between polls, the wallet could use a height bound that was too recent and miss transactions that had since unlocked. The fix remembers the earlier height bound so notifications about unlocked funds are not lost. It is a reliability/functional bug fix rather than a clear security vulnerability.

AI review queuedtests: synchronize notification balances before sendingby woodser · 555c973b · Sep 23, 2026 · 1 fileMessage 75 · AdequateInformational 14Details
Commit message · woodser

tests: synchronize notification balances before sending

Clean up mining, listeners, and temporary receivers on every exit.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 14/100

This commit only changes a test file. It makes the wallet notification tests more reliable by syncing balances before sending and ensuring mining, listeners, and temporary wallets are cleaned up even if the test fails. There is no change to production code or user-facing behavior, and no security vulnerability is present.

AI review queuedwallet rpc: reset snapshots when switching walletsby woodser · 2bdc3fc8 · Sep 22, 2026 · 2 filesMessage 65 · AdequateLow 35Details
Commit message · woodser

wallet rpc: reset snapshots when switching wallets

Invalidate stale polls and callbacks across wallet lifecycle changes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit fixes a lifecycle bug in the Monero Java wallet library. When a user switches from one wallet to another, background polling and notification threads could keep running with stale data from the previous wallet. The patch adds generation counters so old callbacks are cancelled and snapshots are reset when a wallet is switched or cleared. The main risk is that, without the fix, an application might briefly report wrong balances, transactions, or events from a previous wallet after switching wallets, which could confuse users or trick downstream code. There is no direct evidence in the commit of remote code execution or theft of funds.

AI review queuedwallet rpc: restore callbacks when reopening walletsby woodser · e6a5b8d5 · Sep 22, 2026 · 1 fileMessage 65 · AdequateLow 26Details
Commit message · woodser

wallet rpc: restore callbacks when reopening wallets

Reset closed state after successful opening or creation in reused clients.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 26/100

This commit fixes a state-tracking bug in a Monero wallet library. When a wallet client object was reused to open or create another wallet, an internal 'closed' flag was not reset. This could leave event/callback listeners disabled on the reopened wallet, causing the application to miss important notifications such as incoming transactions or sync updates.

AI review queuedtests: wait for wallet pending state before equalityby woodser · eb72c61c · Sep 22, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · woodser

tests: wait for wallet pending state before equality

Wait for pending records to clear before rescanning spent outputs.
Use wallet-state waits in the shared on-chain equality checks.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes test code. It makes wallet equality tests wait for pending transactions to fully clear from the wallets' own state before comparing balances and rescanning spent outputs. There is no change to production wallet logic, no fix for a runtime security bug, and no user-facing behavior change.

AI review queuedtests: mine to height before checking sync notificationsby woodser · 4f38f454 · Sep 22, 2026 · 2 filesMessage 60 · AdequateInformational 14Details
Commit message · woodser

tests: mine to height before checking sync notifications

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 14/100

This commit only changes test code. It refactors how a Monero wallet test waits for a new block by introducing a helper that mines until a specific blockchain height is reached, instead of starting mining and waiting for the next block in the test itself. There is no change to production wallet or daemon code, and no security fix or vulnerability is visible in the diff.

AI review queuedwallet full: cancel native calls before closingby woodser · e949b9e1 · Sep 13, 2026 · 6 filesMessage 68 · AdequateLow 43Details
Commit message · woodser

wallet full: cancel native calls before closing

Cancel native I/O before draining calls and callbacks; allow close retries.
Keep listener cleanup safe across concurrent notifications and shutdown.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 43/100

This commit hardens how the Java Monero wallet shuts down. It makes sure background native (C++) calls are cancelled and finish before the wallet is freed, and it protects listener cleanup from running at the same time as notifications. The main risk being fixed is crashes, memory corruption, or use-after-free bugs that can happen if the wallet is closed while native code or Java callbacks are still active.

AI review queuedwallet: announce missed confirm transition when tx unlocks between pollsby woodser · 37bfe4a5 · Aug 29, 2026 · 1 fileMessage 73 · AdequateInformational 22Details
Commit message · woodser

wallet: announce missed confirm transition when tx unlocks between polls

The confirm notification was silently skipped when a tx confirmed and
unlocked within one poll period, such as during fast mining.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit fixes a notification bug in a Monero wallet library. Previously, if a transaction both confirmed and became unlocked between two polling checks (which can happen during fast block times), the wallet would only announce the 'unlocked' state and skip the 'confirmed' state notification. The patch adds logic to detect this skipped transition and emit the missed 'confirmed' notification before announcing the 'unlocked' state. It is a functional/event-ordering fix, not a security vulnerability fix.