wallet: normalize the empty tx proof signature error from linux wallet rpc
What changed, and why it matters
This is a tiny error-message cleanup in a Java Monero wallet library. The code that detects an empty transaction proof signature from the Linux wallet RPC now accepts messages that start with 'basic_string' rather than only the exact string 'basic_string'. This makes the user-facing error message more reliable but does not change what the wallet allows or rejects.
No security action required; treat as routine code-quality fix.
Security signals we found
Error normalization only; no validation bypass introduced
No change to signature verification or proof checking logic
No change to RPC method parameters or call semantics
Evidence from the diff
The patch changes an equality check to a prefix check in MoneroWalletRpc.java’s checkTxProof error handler. Previously the RPC error message had to equal ‘basic_string’ exactly to be normalized to ‘Must provide signature to check tx proof’; now any message beginning with ‘basic_string’ is normalized. No logic governing signature validation, authorization, or cryptographic checks is altered.
Changed components
src/main/java/monero/wallet/MoneroWalletRpc.javacheckTxProof error handling pathInspect captured patch +1 / −1
### src/main/java/monero/wallet/MoneroWalletRpc.java
@@ -1571,7 +1571,7 @@ public MoneroCheckTx checkTxProof(String txHash, String address, String message,
}
return check;
} catch (MoneroRpcError e) {
- if (Integer.valueOf(-1).equals(e.getCode()) && e.getMessage().equals("basic_string")) e = new MoneroRpcError("Must provide signature to check tx proof", -1, null, null);
+ if (Integer.valueOf(-1).equals(e.getCode()) && e.getMessage().startsWith("basic_string")) e = new MoneroRpcError("Must provide signature to check tx proof", -1, null, null);
if (Integer.valueOf(-8).equals(e.getCode()) && e.getMessage().indexOf("TX ID has invalid format") != -1) e = new MoneroRpcError("TX hash has invalid format", e.getCode(), e.getRpcMethod(), e.getRpcParams());
throw e;
}Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.