AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Cryptographic libraries

wallet: handle null tx notes consistently across backends

Public commit record

What the developer wrote

Authored by woodser

50/100 · Thin
wallet: handle null tx notes consistently across backends
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes two consistency problems when saving notes attached to Monero transactions. First, the Java RPC wallet now turns Java `null` notes into empty strings before sending them to the wallet RPC, because the RPC server rejects JSON null values while the local full wallet treats null as 'clear the note.' Second, the native JNI bridge now only releases the string memory when a string actually exists, avoiding a possible crash when a null note is passed from Java to the native C++ wallet. Tests were added to confirm that null clears a note and that the caller's list is not modified.

Recommended action

Treat as a low-severity reliability/defensive fix. Reviewers should verify that no other JNI string-release sites pass null jstring values and that the RPC mapping does not inadvertently change legitimate empty-string semantics elsewhere. No urgent security response is indicated, but the fix should be included in the next release.

Security signals we found

01

Null-pointer handling gap between RPC and full wallet backends

02

Potential JVM crash in JNI string release path for null transaction notes

03

Behavioral normalization of null values to empty strings to match backend expectations

04

Addition of regression tests for null note handling and sync-callback note access

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.