KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

562 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

125security candidates296second-pass queue559AI analyses
5commits · 30 days
9commits · 60 days
185commits · 180 days
402commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

43/100 average clarity
39Strong · 80–100
75Adequate · 60–79
213Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit11711154
ww351268717652176026
github-actions[bot]656074
willwang15215025
John Boyd626088
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil616074
Analysis record

Published AI watches

Last scanned 38 minutes ago

Moderate 56 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Stop the wallet-prep countdown when its label goes (#2324)

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, cau…

Use-after-free/dangling reference in UI timer callbackOrphaned timer leak causing accelerated countdown behaviorFirmware crash triggered by user timing (quick unlock → scan)
7da0b941by Greg Pfeil+0−00 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix(zcash): Fix regression in 3.2.2, improve performance by 15-18%, reduce firmware size by 4.4% (#2330)

This commit updates a Zcash cryptography dependency and changes compiler hints to fix a firmware performance regression and reduce firmware size. There is no security-relevant change visible in the diff.

36859d27by Jack Grigg+4−22 files
No security note in commit
Low 28 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Send the whole `g_checkResult` to the UI task (#2323)

A firmware fix for a data-passing bug between internal tasks. The code was accidentally sending only the memory address size of a result structure, not the full result. Right now this only affects the rarely-used error_message field, but i…

Incorrect size passed in inter-task message (sizeof pointer instead of sizeof structure)Structure member truncation could leak partial or stale data to UI taskCrash observed by developer when accessing the omitted error_message field
6f0fb82bby Greg Pfeil+0−00 files
No security note in commit
Low 45 AI analysisMessage 61 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.2.2 (#2327)

This is a routine firmware release (version 3.2.2) for the Keystone 3 hardware wallet. The main user-visible change is adding support for the Zcash NU7 network upgrade. The code changes mostly update Zcash-related Rust libraries to newer v…

Zcash dependency major-version upgrades and API migration for NU7 compatibilityLock-screen countdown timer now initialized to NULL and explicitly stopped on label deletion, reducing dangling-timer riskTransaction-check-fail signal fixed to pass correct struct size instead of pointer size
08150faeby github-actions[bot]+1032−90129 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore(release): 3.2.0 (#2315)

This commit is a routine version-bump release (3.2.0) for the Keystone 3 firmware. The visible changes are almost entirely code formatting/indentation, removal of unused imports and dead code, adding 'deprecated' annotations to legacy Bitc…

No security-relevant signals detected in the diff.No mention of CVE, security fix, vulnerability, audit, or bug bounty in commit message or changelog.Changes are cosmetic, dead-code removal, feature gating, and version bump.
3690bf1fby Soralit+674−51576 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: release 3.1.4 (#2311)

This is a large routine firmware release (version 3.1.4) for the Keystone 3 hardware wallet. The visible changes add support for signing Bitcoin Cash, Dash and Dogecoin PSBTs, improve Solana and Tron transaction parsing, add Zcash shielded…

FreeRTOS MPU peripheral region narrowed to PSRAM-only and unprivileged peripheral access now disallowed by compile-time errorNew PSBT signing paths for BCH/DASH/DOGE with custom validation and sighash rulesSolana parser changes and addition of an overflow test fixture (squads-overflow.hex)
d2987b99by github-actions[bot]+18413−6376240 files
No security note in commit
Informational 23 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.1.2 (#2306)

This is a routine firmware release merge (version 3.1.2). The only functional code change visible in the diff adds one more allowed cryptocurrency derivation path prefix, 'm/44'/9000'', for Avalanche (AVAX) X/P-chain addresses when the dev…

Additive change to a path-prefix allowlistNo input validation, parsing, or memory-safety changes visibleNo vendor statement of security relevance in commit or references
f95101fbby github-actions[bot]+23−25 files
No security note in commit
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2302)

This commit only updates a Git submodule pointer (a reference to another repository) in a release-related file. There are no code changes visible in the diff, no description of any security issue, and no references provided. It appears to …

6ef9ddd3by Soralit+1−11 file
No security note in commit
Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedfix ton crashby ww3512687 · 3364d9be · Dec 11, 2025 · 1 fileMessage 28 · OpaqueModerate 59Details
Commit message · ww3512687

fix ton crash

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Moderate 59/100

This commit fixes a crash in the TON (The Open Network) signing code for the Keystone 3 hardware wallet. Previously, if a user had not set a custom derivation path, the code would blindly copy the seed bytes into a fixed 32-byte secret key buffer. If the seed was shorter than 32 bytes, this would read past the end of the seed data, causing a crash or undefined behavior. The fix checks the seed length first and returns a controlled error if it is too short.

AI review queuedOptimize the link between the BTC wallet and the wallet.by ww3512687 · 62a75868 · Dec 10, 2025 · 11 filesMessage 50 · ThinInformational 15Details
Commit message · ww3512687

Optimize the link between the BTC wallet and the wallet.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine user-interface update for the Keystone 3 hardware wallet firmware. It swaps in a larger Zeus wallet icon, adds a new Bitcoin wallet-list icon, updates the corresponding image asset files, refreshes an image-hash file, and adjusts a few UI labels and status-bar resources. There is no change to cryptographic code, transaction signing, key handling, parsing of untrusted data, or any other security-sensitive logic.

AI review queuedmodify 2.3.0 changelogby bianminyan · f73e351f · Dec 2, 2025 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

modify 2.3.0 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes one line in a Chinese-language changelog, correcting the heading 'Bug Fixes' to 'Bug 修复' (Chinese for 'Bug Fixes'). No code, configuration, or documentation with security implications was modified.

AI review queuedmodify 2.3.0 changelogby bianminyan · 4cbe1211 · Dec 1, 2025 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

modify 2.3.0 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only edits the formatting and wording of a product changelog. It adds blank lines and changes headings like 'BTC-ONLY' to 'BTC Only' and 'CYPHERPUNK' to 'Cypherpunk'. No code, configuration, or security-related content was changed.

AI review queuedadd 2.3.0 cahngelogby bianminyan · 67d1bf9e · Nov 28, 2025 · 3 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

add 2.3.0 cahngelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a new version entry to the changelog files and bumps the firmware version number from 2.2.20 to 2.3.0. It does not change any executable code, cryptographic logic, or security-sensitive behavior. There is no security issue in this commit itself.

AI review queuedchore: optimize test and lintsby soralit · 33cf6275 · Nov 28, 2025 · 47 filesMessage 67 · AdequateInformational 15Details
Commit message · soralit

chore: optimize test and lints

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine maintenance change titled 'chore: optimize test and lints'. It updates code-coverage thresholds in CI workflows, adds Rust lint configuration for a nightly coverage feature, removes an obsolete nightly Rust feature flag, and adjusts some test data and test cases. There is no indication of a security fix or vulnerability being addressed.

AI review queuedconnect wallet crashby ww3512687 · 39fb015c · Nov 28, 2025 · 1 fileMessage 28 · OpaqueLow 36Details
Commit message · ww3512687

connect wallet crash

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Low 36/100

This commit fixes a software crash in the wallet connection screen of the Keystone 3 hardware wallet firmware. The code now checks whether a selected coin/wallet type was found before continuing. Without this check, the device could crash when connecting to a wallet it does not recognize, likely causing a denial of service rather than theft of funds.

AI review queuedfmtby ww3512687 · caaca11d · Nov 27, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · ww3512687

fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only reformats two lines of Rust source code. It does not change what the code does, only how it is visually laid out. There is no security relevance.

AI review queuedfix btc sign messageby ww3512687 · c5f8986c · Nov 27, 2025 · 13 filesMessage 28 · OpaqueLow 27Details
Commit message · ww3512687

fix btc sign message

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit fixes how the Keystone hardware wallet handles Bitcoin 'sign message' QR codes. Previously, many malformed or unsupported message formats were reported as 'unsupported transaction,' which could mislead users. The change introduces a clearer 'Invalid Message' error and adds a new Japanese font glyph. It is primarily a user-experience and error-handling improvement, not a fix for a known exploit.

AI review queuedfix multisigby ww3512687 · 737d1a7c · Nov 27, 2025 · 1 fileMessage 18 · OpaqueLow 42Details
Commit message · ww3512687

fix multisig

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 42/100

This commit fixes a Bitcoin multisig signing flow in the Keystone 3 hardware wallet firmware. Previously, when a transaction did not need a signature, the code exported the PSBT but did not properly handle the result object; when it did need a signature, it signed but skipped updating the UI status and freeing the result. The patch unifies both branches so the result is always processed and cleaned up. It also wraps some legacy Keystone transaction code in a WEB3_VERSION compile guard, likely preventing it from running on Bitcoin-only firmware builds where it could behave incorrectly.

AI review queuedbluewallet add taprootby ww3512687 · fc22294d · Nov 27, 2025 · 9 filesMessage 28 · OpaqueInformational 20Details
Commit message · ww3512687

bluewallet add taproot

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit refactors how the Keystone hardware wallet exports Bitcoin account data (extended public keys) when pairing with BlueWallet and other apps. Previously BlueWallet received only three key types (Native SegWit, SegWit, Legacy). Now it uses the same function as Sparrow/Zeus/UniSat, which also includes the Taproot key type. This is a feature addition, not a vulnerability fix, and does not change how secrets are handled.

AI review queuedfix zcash unwrapby ww3512687 · 7cee191e · Nov 27, 2025 · 1 fileMessage 28 · OpaqueModerate 57Details
Commit message · ww3512687

fix zcash unwrap

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 57/100

This commit changes two Zcash-related functions in the Keystone hardware wallet firmware so that the wallet seed is no longer treated as a mutable buffer and is no longer explicitly wiped (zeroized) from memory after use. The title says 'fix zcash unwrap,' suggesting the change was made to resolve a Rust panic caused by calling .unwrap() or by a mutability mismatch. Removing zeroize reduces memory cleanup of the secret seed, which could leave sensitive material in memory longer than intended. However, the diff alone does not prove an exploitable vulnerability; it may simply trade one bug for another.

AI review queuedfix buildby ww3512687 · 32fdbb2c · Nov 27, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · ww3512687

fix build

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a single missing function declaration (PreparePublicKeys) in a Bitcoin UI source file. It is a straightforward build fix with no visible security relevance.

AI review queuedfmtby ww3512687 · f88d5173 · Nov 26, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · ww3512687

fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is purely a code-formatting change. It only rewrites two test assertions in a Rust file so they fit on single lines instead of being split across multiple lines. No logic, behavior, or security checks were changed.

AI review queuedfix ada slip39 addressby ww3512687 · dc204578 · Nov 19, 2025 · 1 fileMessage 28 · OpaqueModerate 54Details
Commit message · ww3512687

fix ada slip39 address

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 54/100

This commit changes how Cardano public keys are derived for SLIP39 wallets. It switches from a mutable, zeroed-out copy of the wallet seed to a non-mutable, non-zeroed copy. The change removes a safety feature that normally wipes the seed from memory after use, which could leave sensitive seed material in memory longer than intended. However, the commit message only says 'fix ada slip39 address' and gives no security explanation, so the exact risk is unclear from the diff alone.

AI review queuedfix slip39 error noticeby ww3512687 · 1cc7a23e · Nov 18, 2025 · 1 fileMessage 28 · OpaqueLow 48Details
Commit message · ww3512687

fix slip39 error notice

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 48/100

This commit fixes a logic bug in the Keystone hardware wallet's SLIP39 backup phrase handling. The original code used 'OR' instead of 'AND' when checking word counts, which made the validation always fail for valid 20-word and 33-word SLIP39 phrases. This would have shown users an incorrect error notice and blocked legitimate wallet recovery or setup operations. It is a bug fix that improves reliability, but it does not appear to allow theft of funds on its own.

AI review queueddelete unused codeby ww3512687 · b21c5306 · Nov 18, 2025 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · ww3512687

delete unused code

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply removes four unused helper functions for handling JSON data from a utility file. There is no change to active behavior, no bug fix, and no security-relevant change.

AI review queuedfix assertby ww3512687 · 8d0dcc32 · Nov 18, 2025 · 1 fileMessage 0 · OpaqueLow 39Details
Commit message · ww3512687

fix assert

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 39/100

This commit changes a password-length check from 'greater than' to 'greater than or equal to' the minimum allowed length. In the original code, a password exactly equal to the minimum length would trigger an assertion failure, which could crash the firmware or block wallet operations. The fix allows passwords of exactly the minimum length to be accepted. This is a correctness fix for an input-validation boundary condition, but the commit message gives no indication it was treated as a security issue by the vendor.

AI review queuedfix crashby ww3512687 · be46a2db · Nov 17, 2025 · 1 fileMessage 0 · OpaqueLow 30Details
Commit message · ww3512687

fix crash

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Low 30/100

This commit fixes a memory-freeing mismatch in the Keystone 3 hardware wallet firmware. The code was freeing a memory block using the wrong allocator (EXT_FREE instead of SRAM_FREE). Such mismatches can corrupt memory and cause the device to crash or behave unpredictably. The commit title says 'fix crash,' but no further details are provided, and there is no independent evidence that this is exploitable for security harm rather than just a stability bug.

AI review queuedreivew connect walletby ww3512687 · 5da7efe7 · Nov 17, 2025 · 30 filesMessage 28 · OpaqueLow 27Details
Commit message · ww3512687

reivew connect wallet

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit is a large code cleanup and refactoring of the wallet connection feature in the Keystone 3 firmware. It removes many duplicated Rust modules and C functions that generated QR-code sync data for specific wallets (Aptos, Solana, Sui, XBull, Keystone companion app, etc.) and replaces them with a single generic function. It also fixes some memory leaks by adding SRAM_FREE calls and removes unused/commented-out code. There is no direct evidence in the commit of a security vulnerability being fixed; it appears to be a maintenance refactor.

AI review queuedseed clearby ww3512687 · 7f3983f3 · Nov 17, 2025 · 1 fileMessage 0 · OpaqueModerate 59Details
Commit message · ww3512687

seed clear

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Moderate 59/100

This commit updates Ethereum signing code in a cryptocurrency hardware wallet firmware so that the secret seed (master key) is wiped from memory immediately after use. It also replaces several 'unwrap' crash points with proper error handling. The main security improvement is reducing the window where the seed sits in memory after signing, which could lower the risk of an attacker reading it from device RAM. However, the patch is partial: it only covers three Ethereum signing functions and does not appear to add zeroize to all signing paths in the firmware.

AI review queuedrefactor: wallet connectionby soralit · be07cbe3 · Nov 17, 2025 · 4 filesMessage 47 · ThinInformational 11Details
Commit message · soralit

refactor: wallet connection

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 11/100

This commit is a code cleanup that removes a dedicated imToken wallet connection module and routes imToken through the existing MetaMask-style connection code. It also adds the ability to include the wallet name when generating connection data for MetaMask-compatible wallets. There is no direct evidence in the commit that this fixes a security vulnerability.

AI review queuedreview forget passwordby ww3512687 · fa406a81 · Nov 17, 2025 · 1 fileMessage 28 · OpaqueLow 46Details
Commit message · ww3512687

review forget password

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: broader security terminologysecond-pass: opaque commit message
AI analysis · Low 46/100

This commit adds cleanup steps when the 'forget password' screen is closed. It now wipes a PIN buffer from memory and clears a secret cache. The change is defensive: it reduces the chance that a leftover PIN or secret remains in memory after the user leaves the password-recovery flow. The commit message does not say this fixes a specific vulnerability, and no public references were supplied.

AI review queuedfmtby ww3512687 · 6837ece1 · Nov 17, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · ww3512687

fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only reformats whitespace in test code and updates one test's expected value for a contract-creation transaction's destination address from an empty '0x' to the zero address. It does not change any production code or fix a security issue.

AI review queuedreview ethby ww3512687 · e053c1f1 · Nov 17, 2025 · 16 filesMessage 0 · OpaqueLow 35Details
Commit message · ww3512687

review eth

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit is a code review and cleanup of Ethereum-related code in the Keystone 3 hardware wallet firmware. It adds many unit tests, fixes a typo in a function name (sign_fee_markey_tx → sign_fee_market_tx), replaces some static variables with constants, and fixes a few minor logic issues. The most user-visible change is adding a check for an SD card before trying to load external contract data, and fixing memory leaks where global pointers could be overwritten without freeing the old data. There is no clear evidence of an active security vulnerability being patched, but the memory management and contract-data-loading changes are defensive improvements.