KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

562 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

125security candidates296second-pass queue559AI analyses
5commits · 30 days
9commits · 60 days
185commits · 180 days
402commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

43/100 average clarity
39Strong · 80–100
75Adequate · 60–79
213Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit11711154
ww351268717652176026
github-actions[bot]656074
willwang15215025
John Boyd626088
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil616074
Analysis record

Published AI watches

Last scanned 13 minutes ago

Moderate 56 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Stop the wallet-prep countdown when its label goes (#2324)

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, cau…

Use-after-free/dangling reference in UI timer callbackOrphaned timer leak causing accelerated countdown behaviorFirmware crash triggered by user timing (quick unlock → scan)
7da0b941by Greg Pfeil+0−00 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix(zcash): Fix regression in 3.2.2, improve performance by 15-18%, reduce firmware size by 4.4% (#2330)

This commit updates a Zcash cryptography dependency and changes compiler hints to fix a firmware performance regression and reduce firmware size. There is no security-relevant change visible in the diff.

36859d27by Jack Grigg+4−22 files
No security note in commit
Low 28 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Send the whole `g_checkResult` to the UI task (#2323)

A firmware fix for a data-passing bug between internal tasks. The code was accidentally sending only the memory address size of a result structure, not the full result. Right now this only affects the rarely-used error_message field, but i…

Incorrect size passed in inter-task message (sizeof pointer instead of sizeof structure)Structure member truncation could leak partial or stale data to UI taskCrash observed by developer when accessing the omitted error_message field
6f0fb82bby Greg Pfeil+0−00 files
No security note in commit
Low 45 AI analysisMessage 61 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.2.2 (#2327)

This is a routine firmware release (version 3.2.2) for the Keystone 3 hardware wallet. The main user-visible change is adding support for the Zcash NU7 network upgrade. The code changes mostly update Zcash-related Rust libraries to newer v…

Zcash dependency major-version upgrades and API migration for NU7 compatibilityLock-screen countdown timer now initialized to NULL and explicitly stopped on label deletion, reducing dangling-timer riskTransaction-check-fail signal fixed to pass correct struct size instead of pointer size
08150faeby github-actions[bot]+1032−90129 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore(release): 3.2.0 (#2315)

This commit is a routine version-bump release (3.2.0) for the Keystone 3 firmware. The visible changes are almost entirely code formatting/indentation, removal of unused imports and dead code, adding 'deprecated' annotations to legacy Bitc…

No security-relevant signals detected in the diff.No mention of CVE, security fix, vulnerability, audit, or bug bounty in commit message or changelog.Changes are cosmetic, dead-code removal, feature gating, and version bump.
3690bf1fby Soralit+674−51576 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: release 3.1.4 (#2311)

This is a large routine firmware release (version 3.1.4) for the Keystone 3 hardware wallet. The visible changes add support for signing Bitcoin Cash, Dash and Dogecoin PSBTs, improve Solana and Tron transaction parsing, add Zcash shielded…

FreeRTOS MPU peripheral region narrowed to PSRAM-only and unprivileged peripheral access now disallowed by compile-time errorNew PSBT signing paths for BCH/DASH/DOGE with custom validation and sighash rulesSolana parser changes and addition of an overflow test fixture (squads-overflow.hex)
d2987b99by github-actions[bot]+18413−6376240 files
No security note in commit
Informational 23 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.1.2 (#2306)

This is a routine firmware release merge (version 3.1.2). The only functional code change visible in the diff adds one more allowed cryptocurrency derivation path prefix, 'm/44'/9000'', for Avalanche (AVAX) X/P-chain addresses when the dev…

Additive change to a path-prefix allowlistNo input validation, parsing, or memory-safety changes visibleNo vendor statement of security relevance in commit or references
f95101fbby github-actions[bot]+23−25 files
No security note in commit
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2302)

This commit only updates a Git submodule pointer (a reference to another repository) in a release-related file. There are no code changes visible in the diff, no description of any security issue, and no references provided. It appears to …

6ef9ddd3by Soralit+1−11 file
No security note in commit
Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedFix the translationby ww3512687 · ded314aa · Nov 3, 2025 · 4 filesMessage 28 · OpaqueInformational 15Details
Commit message · ww3512687

Fix the translation

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit fixes a Korean translation error and removes two stray trailing whitespace characters. The Korean text for a Permit signing setting previously said the device would 'enable or enable' the feature; it now correctly says 'enable or disable.' There are no code behavior changes.

AI review queuedfix: ton amount too large crashby soralit · f71d8b1e · Oct 30, 2025 · 1 fileMessage 57 · ThinLow 42Details
Commit message · soralit

fix: ton amount too large crash

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Low 42/100

This commit fixes a crash in the TON (The Open Network) jetton token display code on Keystone 3 hardware wallets. Previously, when a token amount was too large to fit in a 64-bit integer, the firmware would panic and crash. The fix switches to a larger 128-bit integer and formats the amount more carefully. A crafted transaction with an oversized amount could have caused the device to crash, potentially disrupting transaction signing or user experience.

AI review queuedfix: buildby soralit · e6bb3c0a · Oct 30, 2025 · 1 fileMessage 2 · OpaqueInformational 15Details
Commit message · soralit

fix: build

2/100 · OpaqueMessage clarity
✓ Uses a recognizable type or scope! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This is a one-line build fix in a simulator-only header file. It adds a missing function declaration (random_buffer) so the simulator code compiles. There is no indication of a security bug, vulnerability, or runtime behavior change in the actual hardware firmware.

AI review queuedupdate verify docby ww3512687 · a5aec37d · Oct 29, 2025 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · ww3512687

update verify doc

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a documentation file (docs/verify.md) that explains how users can build and verify the firmware. It adds instructions for a new 'Cypherpunk' firmware variant and corrects the filename used in verification steps from 'mh1903.bin' to 'mh1903_full.bin'. There are no code changes and no security fix or vulnerability introduced.

AI review queuedFix duplicate trait importby Greg Pfeil · f87ff609 · Oct 27, 2025 · 1 fileMessage 58 · ThinInformational 15Details
Commit message · Greg Pfeil

Fix duplicate trait import

```
error[E0252]: the name `Cb58Encodable` is defined multiple times
--> apps/avalanche/src/transactions/P_chain/validator.rs:41:9
|
38 | use crate::encode::cb58::Cb58Encodable;
| ---------------------------------- previous import of the trait `Cb58Encodable` here
...
41 | use crate::encode::cb58::Cb58Encodable;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `Cb58Encodable` reimported here
|
= note: `Cb58Encodable` must be defined only once in the type namespace of this module
```

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes a single duplicate Rust import statement that caused a compiler error. It is a routine build fix with no security relevance.

Lower-priorityDon’t use `random_buffer` in the simulatorby Greg Pfeil · 34d8a98e · Oct 27, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Greg Pfeil

Don’t use `random_buffer` in the simulator

The implementation isn’t compiled for the simulator, so trying to call
it breaks compilation.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a minor build-fix change for the software simulator. It wraps a call to a hardware-specific random-number function so the simulator can compile. It does not change real-device behavior or introduce a security vulnerability.

Security candidateUse string literals for format stringsby Greg Pfeil · b79e31e3 · Oct 27, 2025 · 6 filesMessage 85 · StrongLow 32Details
Commit message · Greg Pfeil

Use string literals for format strings

I couldn’t get the simulator to compile without making these changes.

This is on macOS Tahoe with Clang 19.1.7.

```
/…/src/ui/gui_widgets/gui_firmware_update_widgets.c:119:51: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
119 | lv_label_set_text_fmt(g_calCheckSumLabel, _("firmware_update_sd_checksum_desc"));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/…/src/ui/gui_widgets/gui_firmware_update_widgets.c:119:51: note: treat the string as an argument to avoid this
119 | lv_label_set_text_fmt(g_calCheckSumLabel, _("firmware_update_sd_checksum_desc"));
| ^
| "%s",
```

Alternatively, the warning could be disabled, but I don’t like doing
that and this change seemed trivial.

85/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
boot or update path
AI analysis · Low 32/100

This commit fixes compile errors triggered by a stricter compiler setting that treats non-literal format strings as potentially insecure. The changes wrap translated UI text strings with a safe "%s" placeholder so they are treated as plain text rather than format strings. In theory, the old code could have allowed a malicious or malformed translation string to be interpreted as a format specifier, possibly causing crashes or information leaks, but there is no evidence that any such attack was possible or exploited in practice. The commit message frames the change as a build fix, not a security fix.

Lower-prioritySpecify `build.target-dir` in Cargo configby Greg Pfeil · 28176e4b · Oct 27, 2025 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Greg Pfeil

Specify `build.target-dir` in Cargo config

The relative path `target` is hardcoded in some Makefiles. This
correspondingly sets the `build.target-dir` to the same value (which is
the default) to ensure that it isn’t overridden by a contributor’s
config.

```
cp: cannot stat '/…/rust/target/release/librust_c.a': No such file or directory
```

Here is where they’re hardcoded – rust/CMakeLists.text:54–56
``` cmake
set(COPY_BUILD_TARGET cp ${RUST_DIR}/target/${CARGO_ARM_TARGET}/release/${LIB_NAME} ${TARGET_PATH})
else()
set(COPY_BUILD_TARGET cp ${RUST_DIR}/target/release/${LIB_NAME} ${TARGET_PATH})
```

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit is a build-system hardening change, not a security fix. It pins the Rust build output directory to the default 'target' folder so that individual developer settings cannot accidentally break the firmware build. There is no indication it addresses a vulnerability or malicious behavior.

AI review queuedmodify 2.2.18 changelogby bianminyan · 2ad9001a · Oct 27, 2025 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

modify 2.2.18 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only edits the release changelog text. It updates the release date and adds bug-fix descriptions for version 2.2.18. No source code, build scripts, or firmware logic were changed, so it cannot introduce or fix a security vulnerability by itself.

AI review queuedchore: run rust fmtby soralit · 9a093e5e · Oct 23, 2025 · 32 filesMessage 40 · ThinInformational 15Details
Commit message · soralit

chore: run rust fmt

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code-style cleanup: it runs the Rust formatter (rustfmt) across 32 files. The changes only reformat whitespace, line breaks, import ordering, and similar stylistic details. No program logic, security checks, or behavior were changed.

Lower-priorityfix: seed signer messages are wrongly splitedby soralit · 181baf42 · Oct 23, 2025 · 1 fileMessage 57 · ThinLow 46Details
Commit message · soralit

fix: seed signer messages are wrongly splited

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 46/100

This commit fixes how the Keystone hardware wallet parses 'signmessage' QR code requests from SeedSigner. Previously, the code split the message at every colon, so a message containing colons would be cut off and only the first part would be signed. Now it splits only at the first colon and rejects empty messages. A truncated or altered message could lead to signing something different from what the user intended, which is a security concern for message signing workflows.

Lower-prioritytest: fix unit testby soralit · 1b7b79e3 · Oct 23, 2025 · 8 filesMessage 50 · ThinInformational 12Details
Commit message · soralit

test: fix unit test

50/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit is a test-only refactor that makes random number generation injectable so unit tests can use a fixed seed and produce deterministic results. It does not change the production code path: the firmware still uses the hardware random number generator (OsRng) when signing real Monero transactions. The expected test output was updated because the deterministic test RNG now produces different, predictable values.

Security candidatefix mod testsby ww3512687 · ce786c85 · Oct 23, 2025 · 12 filesMessage 38 · OpaqueInformational 15Details
Commit message · ww3512687

fix mod tests

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit only updates unit tests for the Avalanche transaction parser. It swaps test blockchain IDs from mainnet to testnet values, removes debug print statements, fixes an import order warning, and replaces placeholder assertions with real ones. There is no change to production code that handles user funds or device security.

Lower-priorityFix the scenario where there are errors in the UI during importby ww3512687 · bf40b2b6 · Oct 23, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ww3512687

Fix the scenario where there are errors in the UI during import

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit fixes a minor user-interface navigation bug during the wallet recovery phrase import flow. When a user is importing a single recovery phrase and reaches the step for writing it to the secure element, the back/previous button could skip the wrong screen or behave oddly if no passphrase is needed. The fix adjusts which screen the user is sent back to. There is no direct evidence this is a security vulnerability.

Security candidatechore: fix warningby soralit · 57a020c9 · Oct 22, 2025 · 49 filesMessage 40 · ThinLow 26Details
Commit message · soralit

chore: fix warning

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Low 26/100

This is a large cleanup commit titled 'chore: fix warning'. It removes compiler warnings across many Rust modules by deleting unused imports, switching to modern Rust syntax, and fixing minor style issues. The most notable functional change is in the Monero code, where randomness for key-image generation and encryption now comes from the operating system's secure random source (OsRng) instead of a deterministic seed derived from the request data. That change is a security improvement, not a vulnerability. There is no clear evidence in the commit of an exploitable security bug.

AI review queuedadd 2.2.18 changelogby bianminyan · bd567633 · Oct 20, 2025 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

add 2.2.18 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a changelog entry for firmware version 2.2.18. It describes two new features (DOGE transaction/PSBT parsing) and one bug fix (XMR Key Image generation error), but it does not modify any source code, cryptographic logic, or configuration. There is nothing in the diff that introduces or fixes a security vulnerability.

Security candidatechore: fix clippy build errorby soralit · 8323dddb · Oct 17, 2025 · 91 filesMessage 57 · ThinInformational 15Details
Commit message · soralit

chore: fix clippy build error

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is a routine cleanup of Rust compiler warnings (Clippy lints). It removes unused imports, rewrites idiomatically cleaner code, fixes variable naming, and updates a few function signatures. There is no indication it fixes a security vulnerability or changes security-critical behavior.

AI review queuedfix testby ww3512687 · 2631f587 · Oct 15, 2025 · 1 fileMessage 0 · OpaqueInformational 12Details
Commit message · ww3512687

fix test

0/100 · OpaqueMessage clarity
✓ Mentions testing or verification! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100

This commit simply comments out a single automated test for Monero transaction signing. It does not change any production code, so it cannot directly introduce or fix a security vulnerability in the firmware that users run. The test is disabled, which means the code it exercises is no longer automatically verified, but the commit itself does not alter how Monero transactions are signed.

AI review queuedUpdate versionby bianminyan · 12deddfa · Oct 15, 2025 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · bianminyan

Update version

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply bumps a build number in a version header from 16 to 18. There are no code changes, no bug fixes, and no security-related modifications visible in the diff.

AI review queuedupdate cargo tomlby ww3512687 · df01afd5 · Oct 15, 2025 · 2 filesMessage 28 · OpaqueInformational 10Details
Commit message · ww3512687

update cargo toml

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 10/100

This commit simply switches two internal Rust library dependencies from a development branch to a numbered release tag (0.0.52). It is a routine dependency pinning change with no visible security fix or vulnerability in the diff itself.

AI review queueddelete debug codeby ww3512687 · 38dac58f · Oct 15, 2025 · 5 filesMessage 28 · OpaqueLow 47Details
Commit message · ww3512687

delete debug code

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 47/100

This commit removes leftover debugging code from the Keystone 3 firmware. The most notable change is that in production builds, the device's debug UART output is now replaced with harmless '-' characters instead of potentially leaking real data. Other changes remove hard-coded test values and re-enable a normal boot-version check that had been bypassed. These are cleanup fixes that reduce the chance of sensitive information leaking through debug interfaces or test code being active in production.

Security candidateclippy & fmtby ww3512687 · 6a3e5092 · Oct 15, 2025 · 24 filesMessage 18 · OpaqueInformational 15Details
Commit message · ww3512687

clippy & fmt

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing or wallet pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is purely a code cleanup: it runs the Rust formatter (fmt) and applies Clippy lint suggestions. The changes are cosmetic—reformatting lines, reordering imports, removing unused imports, and adding 'unsafe' markers to functions that already contained unsafe operations. There is no functional change to how the firmware handles keys, transactions, or user data, and no security vulnerability is introduced or fixed.

AI review queuedcargo fmtby ww3512687 · d0eaae1a · Oct 15, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · ww3512687

cargo fmt

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code-formatting change ('cargo fmt') in a Monero signing utility. It rewraps a single function call onto one line instead of multiple lines without changing any logic, values, or behavior. There is no security relevance.

AI review queuedcargo clippyby ww3512687 · cc295b0c · Oct 15, 2025 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · ww3512687

cargo clippy

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine code cleanup. It removes two blank lines and replaces a length check (`len() == 0`) with the idiomatic Rust method `is_empty()`. These changes do not alter how the Monero app works and do not fix or introduce any security issue.

Security candidateClear the passphrase status when returningby ww3512687 · b6a0fb37 · Oct 13, 2025 · 8 filesMessage 45 · ThinLow 47Details
Commit message · ww3512687

Clear the passphrase status when returning

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Low 47/100

This commit adds code that clears the optional passphrase text from the screen and resets its visibility to hidden (password mode) whenever the user navigates back from passphrase entry during wallet creation, import, or settings. It also refactors how the 'show/hide' eye icon is controlled. The change looks like a cleanup fix to prevent a sensitive passphrase from lingering on screen or staying visible after a user leaves the page, which could reduce the risk of shoulder-surfing or accidental disclosure.