FD
← All projectsFoundation

Passport firmware

Firmware for Foundation Passport Bitcoin signing devices.

BitcoinHardware walletsNormal
Repository coverage

263 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

102security candidates79second-pass queue215AI analyses
42commits · 30 days
128commits · 60 days
194commits · 180 days
256commits · 365 days
Backfill bands
Aug 5 → Feb 612 seen0 candidatesComplete
Feb 6 → Jun 659 seen3 candidatesComplete
Jun 6 → Jul 64 seen0 candidatesComplete
Jul 6 → Aug 52 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

61/100 average clarity
16Strong · 80–100
116Adequate · 60–79
118Thin · 40–59
13Opaque · 0–39
4security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jacksper13321424466
Matt Gleason841868351
Jack603454261
mjg-foundation693251269
Jean-Pierre De Jesus DIAZ828061
Ken Carpenter313048
QnA111060
dependabot[bot]505076
BitcoinQnA101045
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 12 AI analysisMessage 78 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8696: remove the Security Check from onboarding

This commit removes the 'Security Check' step from the initial device setup (onboarding) for the Passport hardware wallet. To avoid breaking devices that were mid-setup during a firmware update, the old step is kept as a harmless pass-thro…

8d77ba38by Jack+153−124 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #753 from Foundation-Devices/sft-8680-fail-to-sign-dynamic-taproot-qr-message

This commit adds support for signing BIP-322 message requests that wallets like Sparrow send as a PSBT (a Bitcoin transaction-like data format). It is a feature addition, not a reported vulnerability fix. The code includes careful validati…

New input parser for externally supplied PSBT data with explicit structural validationRejects non-Taproot BIP-322 requests and unsafe sighash typesBinds the user-reviewed message and address to the transaction being signed
5e98b6abby mjg-foundation+722−3011 files
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8680: check derivation path length before indexing into it

This commit fixes a bug in the Passport hardware wallet's BIP-322 message signing code. Previously, when parsing a PSBT (a Bitcoin data format), the code could read past the end of an empty or too-short 'derivation path' field because it c…

Out-of-bounds read / index error on untrusted PSBT inputValidation order bug: first-byte check before length checkBIP-322 signing request parsing hardened
cec3925bby Matt Gleason+8−43 files
No security note in commit
Informational 22 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #754 from Foundation-Devices/sft-8681-passport-core-sign-taproot-messages-with

This commit changes how the Passport hardware wallet signs Bitcoin Taproot text messages. Previously it used SIGHASH_DEFAULT (the Taproot default), but now it uses SIGHASH_ALL. The change is for compatibility: the commit message says Sparr…

Change in cryptographic signature hash type (SIGHASH_DEFAULT -> SIGHASH_ALL)Comment explicitly references verifier compatibility and Sparrow wallet acceptanceUnit test asserts new signature encoding and verifies against an external test vector
87f43de1by mjg-foundation+22−172 files
No security note in commit
Low 41 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #752 from Foundation-Devices/sft-8674-passport-core-signing-flow-does-not-show-a-non

This commit adds on-screen warnings to the Passport hardware wallet when a user is reviewing a Bitcoin transaction that contains timelocks. Timelocks can prevent a transaction from confirming until a future date or until certain inputs hav…

UI warning for absolute time-based nLockTimeUI warning for BIP68 relative timelocks on version-2 transactionsHeight-based nLockTime intentionally not flagged to avoid false positives
5defe2c5by mjg-foundation+176−16 files
No security note in commit
Moderate 52 AI analysisMessage 85 · Strong
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8674: warned about timelocks when reviewing a transaction

This commit adds on-screen warnings to the Passport hardware wallet when a Bitcoin transaction being reviewed includes a timelock that could delay confirmation. Before this change, a user could unknowingly sign a transaction that is blocke…

UI now warns users about transaction timelocks that delay confirmationPreviously undisclosed to the signer: absolute date locks and BIP68 relative locksHeight-based nLockTime intentionally not flagged to avoid warning fatigue
7cba5349by Jack+176−16 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #747 from Foundation-Devices/sft-8653-passport-core-recheck-the-firmware-image-while

This update tightens the firmware update process on the Passport hardware wallet. Previously, the device verified the firmware file once, then copied it to internal flash memory without re-checking. A malicious or tampered file swapped in …

Time-of-check/time-of-use (TOCTOU) hardening in firmware update pathNew digest parameter threaded from verification task to staging taskStaging task now re-hashes firmware image and compares against expected digest
3449381fby mjg-foundation+68−264 files
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #736 from Foundation-Devices/sft-8554-bootloader-setup-checks

This commit hardens how Passport's bootloader handles a sensitive factory key during initial device setup. Previously, the code trusted that erasing the key from SPI flash succeeded without checking, and it left a temporary copy of the key…

Sensitive key material (supply-chain validation key) is now explicitly zeroed from stack memory after useSPI flash erase of the SCV key is now verified by read-back instead of assumed successfulBootloader setup now aborts if the SCV key cannot be confirmed erased from SPI flash
ed62d448by mjg-foundation+245−55 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #735 from Foundation-Devices/sft-8555-update-restore-checks

This commit adds security checks when restoring a backup file to a Passport hardware wallet. Previously, multisig wallet configurations stored in a backup were restored without verifying that they actually belong to the seed being restored…

Validation of multisig backup records against restored seedDerivation verification for xpubs claiming backup root fingerprintDropping malformed records instead of failing entire restore
8dbae7e1by mjg-foundation+242−75 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #748 from Foundation-Devices/sft-8654-passport-core-bounded-text-building-in-the

This commit replaces unsafe string-copying functions in the Passport hardware wallet's bootloader with a bounded helper that prevents text fields from overflowing their buffers. The change is defensive: it stops malicious or malformed firm…

Replacement of strcpy/strcat with bounded append_text helperHandling of non-NUL-terminated firmware header text fieldsBuffer overflow mitigation in bootloader UI message construction
e2d735f0by mjg-foundation+89−222 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #732 from Foundation-Devices/sft-8545-native-taproot-key-signing

This commit adds a new, dedicated way for the Passport hardware wallet to sign Bitcoin Taproot transactions. It moves the cryptographic 'tweak' calculation from Python code into a Rust library and adds unit tests. There is nothing in the c…

5e3ed701by mjg-foundation+234−185 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #742 from Foundation-Devices/sft-8530-distinct-cosigners

This update to the Passport hardware wallet firmware adds a safety check when importing multi-signature wallet configurations. Previously, the same cosigner public key could be listed more than once under different fingerprints or address …

Adds duplicate-key detection during multisig wallet importCompares raw public-key x-coordinates rather than fingerprints or encoded xpub stringsPrevents a single key from being counted as multiple independent cosigners
92c68c63by mjg-foundation+69−03 files
Vendor flagged security relevance
Low 48 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #739 from Foundation-Devices/sft-8559-psbt-file-errors

This update fixes a bug where the Passport hardware wallet could freeze (hang) when reading a malformed or unreadable PSBT transaction file from a microSD card. Now the device reports a clear error instead of getting stuck, so users know s…

Denial-of-service / UI hang on malformed input now returns an errorUnhandled exception path now caught and reported instead of leaving task unresolvedMissing microSD card case explicitly reported
6a461136by mjg-foundation+144−62 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #740 from Foundation-Devices/sft-4482-update-card-missing

This commit fixes a user-experience bug in the Passport hardware wallet's firmware update flow. Previously, if the user removed the microSD card while the device was reading a firmware update file, the process would crash with an unhandled…

Adds exception handling for a removable-media failure during a privileged operation (firmware update)Prevents unhandled CardMissingError from aborting the update flow abruptlyDoes not alter firmware signature, timestamp, or header validation logic
06ec8d6aby mjg-foundation+109−23 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #741 from Foundation-Devices/sft-737-multisig-match-n

This firmware update fixes a bug in how the Passport hardware wallet matches multisignature (multisig) wallets. Previously, when looking for a saved wallet that matches the cosigners in a transaction, the device only checked that the cosig…

Incorrect multisig wallet matching could lead to signing with the wrong wallet policySubset-only cosigner matching allowed a smaller wallet to be conflated with a larger oneFix adds N filter to wallet candidate enumeration
d2d30a58by mjg-foundation+59−23 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #746 from Foundation-Devices/sft-8260-evaluate-miniscript-no-compatible-path

This commit only changes the wording of an on-screen warning message shown to users when a Bitcoin transaction's timelock conditions are not yet met. It does not change any security logic, validation, or behavior. The old message said no s…

f6ab63ceby Jacksper13+5−42 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
FD FoundationPassport firmware BitcoinHardware wallets

SFT-8260: Update the policy no-compatible-path warning copy

This commit only changes the wording of an on-screen warning message shown to users when a Bitcoin transaction cannot be signed because no spending path's time-lock conditions are currently satisfied. It does not change any security logic,…

e024471eby Jack+5−42 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

Merge pull request #731 from Foundation-Devices/SFT-974-miniscript-ui-followup

This commit is a follow-up to the miniscript wallet-policy user interface. It mostly fixes UI wording, memory cleanup, and policy display logic. The only potentially security-relevant change is that wallet policy IDs are now computed with …

Incremental SHA-256 digest used for policy ID computationRemoval of explicit `validate(miniscript, context)` call before compilationNew default-name derivation from descriptor checksum
83d1d576by mjg-foundation+415−5312 files
No security note in commit
Low 32 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-974: unwrapped miniscript parsing recursion, added default policy

This firmware update changes how the Passport hardware wallet handles complex Bitcoin wallet policies. The main visible change is replacing a recursive parser walk with an iterative one, which prevents the device from crashing due to exces…

Recursion in miniscript parsing replaced with explicit stack to avoid RecursionError on deeply nested templatesPolicy validation path changed: explicit `validate()` call removed, safety now enforced via `compile_miniscript()` during registrationDefault empty policy name now auto-populated from descriptor checksum to avoid unnamed policies
96b2aa9fby Matt Gleason+160−216 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
FD FoundationPassport firmware BitcoinHardware wallets

SFT-974: improved miniscript UI, working on OOM issues

This commit is a routine feature and stability patch for the Passport hardware wallet's miniscript wallet-policy support. It improves on-screen descriptions of wallet policies, adds explicit memory cleanup (garbage collection) during polic…

Memory pressure mitigation via explicit garbage collection during policy operationsNew verify-address flow for registered wallet policiesUI clarity improvements for timelock and signer-role descriptions
cb7478a5by Matt Gleason+255−3210 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge pull request #641 from Foundation-Devices/SFT-7112-single-line-signmessageby mjg-foundation · fb5bc630 · Oct 6, 2026 · 4 filesMessage 73 · AdequateLow 36Details
Commit message · mjg-foundation

Merge pull request #641 from Foundation-Devices/SFT-7112-single-line-signmessage

SFT-7112: handled signing the single-line message format

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Low 36/100

This commit adds support for a new single-line message-signing format used by Foundation's Envoy app. It also tightens parsing so that multi-line files split on all line endings (not just '\n') and so that embedded newlines in the single-line format are rejected rather than silently dropped. The change is a feature addition with defensive hardening, not a clear fix for an active vulnerability.

Security candidateMerge pull request #712 from Foundation-Devices/sft-8229-replace-every-mp_check_self-guard-in-extmodfoundation-withby Jacksper13 · b86f53be · Oct 6, 2026 · 5 filesMessage 73 · AdequateLow 36Details
Commit message · Jacksper13

Merge pull request #712 from Foundation-Devices/sft-8229-replace-every-mp_check_self-guard-in-extmodfoundation-with

SFT-8229: validate arguments explicitly in the foundation bindings

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 36/100

This commit is a hardening and code-quality improvement for Foundation's Passport firmware. It replaces a low-level MicroPython self-check macro with explicit, user-friendly error messages when Python code passes the wrong type of value into certain firmware functions. It also adds automated tests and a lint rule to keep the old pattern from coming back. The change makes bugs easier to diagnose and reduces the chance that a wrong argument is silently accepted or crashes the device, but it does not by itself fix a known exploitable vulnerability.

Security candidateSFT-8229: validate arguments explicitly in the foundation bindingsby Jack · 988a5b85 · Oct 6, 2026 · 5 filesMessage 91 · StrongLow 34Details
Commit message · Jack

SFT-8229: validate arguments explicitly in the foundation bindings

TypeError for an argument that is not a string, ValueError for a UR
unwrapped as the wrong variant or an optional field that is absent,
following the precedent #711 set for unwrap_bytes.

Add a lint job keeping mp_check_self out of extmod/foundation/, which
addresses a different case that the interpreter already covers for us.
Scoped to our own bindings; uses under extmod/trezor-firmware/ are
upstream's and are correct for what they do.

Unit tests pin each raise and its type, with the valid call beside it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controldefensive validationcryptography-sensitive path
AI analysis · Low 34/100

This commit hardens the firmware's low-level Python bindings by replacing a generic internal check with explicit, user-friendly error messages when a function receives the wrong type of input or tries to access a missing field. It also adds automated tests and a lint rule to keep the old pattern from returning. The change is defensive: it does not fix a known exploit, but it reduces the chance that a confused or malformed input could lead to an unexpected crash or be misused.

AI review queuedSFT-8212: ur type checkingby Matt Gleason · 18f2bb28 · Oct 5, 2026 · 5 filesMessage 45 · ThinLow 47Details
Commit message · Matt Gleason

SFT-8212: ur type checking

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 47/100

This commit tightens how Passport handles QR codes when importing a multi-signature wallet configuration. Previously, the code could accept an unexpected type of Uniform Resource (UR) object and try to treat it as plain bytes, which could cause a crash or confuse the wallet import process. Now the firmware explicitly checks that the UR type is 'bytes' before unwrapping it, and the multisig import flow only allows plain QR data or bytes-type UR data. A new unit test confirms that wrong UR types are rejected with a user-facing error.

Security candidateMerge pull request #710 from Foundation-Devices/SFT-8207-bound-provisioning-rngby mjg-foundation · 0b1e97c2 · Oct 5, 2026 · 2 filesMessage 73 · AdequateLow 38Details
Commit message · mjg-foundation

Merge pull request #710 from Foundation-Devices/SFT-8207-bound-provisioning-rng

SFT-8207: bounded pairing secret retries

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
boot or update pathmerge-commit duplicate discount
AI analysis · Low 38/100

This commit adds a safety cap to how many times the Passport bootloader can retry picking a random pairing secret if the first word keeps looking like erased flash. It also adds tests that simulate hardware random-number-generator failures. The change is defensive: it prevents an unlucky or faulty RNG from causing an infinite loop during factory provisioning, and makes the bootloader call a fatal error handler instead of hanging or continuing with bad entropy. The commit notes this only affects future provisioning/source reuse, not bootloaders already deployed in the field.

AI review queuedMerge pull request #640 from Foundation-Devices/SFT-4502-fix-p2wpkh-nested-in-p2sh-hash-change-validationby mjg-foundation · 5842b65c · Oct 5, 2026 · 7 filesMessage 73 · AdequateHigh 76Details
Commit message · mjg-foundation

Merge pull request #640 from Foundation-Devices/SFT-4502-fix-p2wpkh-nested-in-p2sh-hash-change-validation

SFT-4502: fix p2wpkh nested in p2sh hash change validation

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 76/100

This firmware update fixes a bug in how Passport hardware wallets decide whether a Bitcoin transaction's 'change' output really belongs to your wallet. Before the fix, a malicious or buggy companion app could trick the device into treating a payment to an attacker's address as mere change, or into hiding a change output that doesn't match your account type. The patch tightens the checks for nested SegWit (P2SH-wrapped P2WPKH), native SegWit, Taproot, and multisig change outputs, and makes sure outputs with unusual or incomplete derivation paths stay visible for user review instead of being silently accepted as change.

Security candidateMerge pull request #707 from Foundation-Devices/SFT-7360-supply-chain-boundary-hardeningby mjg-foundation · b1e160c6 · Oct 5, 2026 · 7 filesMessage 58 · ThinModerate 62Details
Commit message · mjg-foundation

Merge pull request #707 from Foundation-Devices/SFT-7360-supply-chain-boundary-hardening

SFT-7360: supply chain check hardening

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathauthentication pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This commit hardens the Passport hardware wallet's supply-chain verification feature by adding strict length checks before passing buffers to cryptographic functions. Without these checks, a malformed or short challenge could be silently padded with zeros, potentially allowing an attacker to bypass the security check that proves the device is genuine. The patch also removes an unused random-hex helper and adds automated tests that exercise the boundary conditions.

Security candidateMerge pull request #642 from Foundation-Devices/SFT-7110-message-signing-display-mismatchby mjg-foundation · 53deb8b6 · Oct 5, 2026 · 7 filesMessage 73 · AdequateHigh 72Details
Commit message · mjg-foundation

Merge pull request #642 from Foundation-Devices/SFT-7110-message-signing-display-mismatch

SFT-7110: message signing display mismatch

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · High 72/100

This update fixes a display-mismatch bug when signing messages on the Passport hardware wallet. Before the fix, special characters in a message could change how the message looked on the device screen without changing the bytes that would actually be signed. That could trick a user into approving a different message than the one shown. The patch escapes display markup and blocks control characters so the screen now accurately reflects what will be signed.

Security candidateMerge pull request #678 from Foundation-Devices/SFT-8071-psbt-parsing-rejects-unknown-fieldsby mjg-foundation · 0d5e86c8 · Oct 5, 2026 · 5 filesMessage 58 · ThinModerate 63Details
Commit message · mjg-foundation

Merge pull request #678 from Foundation-Devices/SFT-8071-psbt-parsing-rejects-unknown-fields

SFT-8071: fixed unknown unknowns

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 63/100

This firmware update fixes how Passport handles partially-signed Bitcoin transactions (PSBTs) that contain fields the device does not recognize. Previously, unknown fields could accidentally be interpreted as known Taproot key-derivation data, which could corrupt the transaction or leak path information. The patch makes all unrecognized fields pass through unchanged, adds support for the standard PSBT version field, and rejects unsupported PSBT versions. It also adds unit tests to verify the behavior.

AI review queuedMerge pull request #681 from Foundation-Devices/SFT-7377-harden-utxo-historyby mjg-foundation · 9447547a · Oct 5, 2026 · 11 filesMessage 58 · ThinModerate 64Details
Commit message · mjg-foundation

Merge pull request #681 from Foundation-Devices/SFT-7377-harden-utxo-history

SFT-7377: harden utxo history

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100

This commit hardens how Passport remembers past Bitcoin input amounts. Previously, the device could record an unverified amount from a rejected or malicious transaction, then later compare a real transaction against that poisoned value and wrongly reject it. The fix only saves amounts after a signature succeeds, rejects duplicate inputs earlier, and adds a user menu to clear the saved amounts. It is a defensive hardening patch rather than a remote exploit fix.

AI review queuedMerge pull request #704 from Foundation-Devices/SFT-7937-warn-one-of-n-multisigby mjg-foundation · 47dbac8c · Oct 5, 2026 · 3 filesMessage 73 · AdequateInformational 20Details
Commit message · mjg-foundation

Merge pull request #704 from Foundation-Devices/SFT-7937-warn-one-of-n-multisig

SFT-7937: showed a warning when importing a 1-of-N multisig

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit adds a user-interface warning when a Passport hardware wallet is used with a 1-of-N multisig wallet. In such wallets, any single cosigner can move funds without the Passport's approval, so the device now displays a notice before signing. It is a transparency/usability improvement, not a fix for a code vulnerability.

Lower-priorityMerge pull request #709 from Foundation-Devices/sft-8206-dispatchc-require_out-reports-success-when-it-rejects-aby Jacksper13 · 000d4d73 · Oct 2, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Jacksper13

Merge pull request #709 from Foundation-Devices/sft-8206-dispatchc-require_out-reports-success-when-it-rejects-a

SFT-8206: make REQUIRE_OUT report the rejection it performs

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge pull request #686 from Foundation-Devices/fix/ecdsa-binding-length-checksby mjg-foundation · 5e4d39ba · Oct 1, 2026 · 3 filesMessage 73 · AdequateModerate 62Details
Commit message · mjg-foundation

Merge pull request #686 from Foundation-Devices/fix/ecdsa-binding-length-checks

SFT-8173: argument validation in the ecdsa bindings

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This update fixes a buffer-length bug in the firmware's cryptographic code. Two low-level functions that perform elliptic-curve math were reading exactly 32 bytes from caller-supplied buffers without first checking whether the buffers were actually that long. A too-short buffer could cause the code to read beyond its bounds, which can lead to crashes or, in some cases, leak memory contents or be exploited for more serious attacks. The patch now rejects any input that is not exactly 32 bytes and adds tests to confirm the behavior.

Lower-priorityMerge pull request #687 from Foundation-Devices/fix/ur-null-optional-argsby mjg-foundation · 2451b742 · Oct 1, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · mjg-foundation

Merge pull request #687 from Foundation-Devices/fix/ur-null-optional-args

SFT-8172: optional argument handling in the UR derived key binding

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge pull request #689 from Foundation-Devices/fix/psbt-witness-iterby mjg-foundation · 7f170402 · Oct 1, 2026 · 3 filesMessage 73 · AdequateLow 47Details
Commit message · mjg-foundation

Merge pull request #689 from Foundation-Devices/fix/psbt-witness-iter

SFT-8169: remove an unreachable branch in the PSBT witness iterator

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 47/100

This firmware update tightens how Passport handles Bitcoin transaction files (PSBTs). It now rejects unsigned transactions that incorrectly include 'witness' data—extra proof data that belongs only in signed transactions. Before, such malformed files caused a confusing internal error instead of a clean user-facing rejection. The change also removes dead code that tried to preserve witness data that should never have been present. This is a defensive hardening fix: it prevents a malformed PSBT from reaching deeper transaction logic and gives the user a clearer error message.

Security candidateMerge pull request #693 from Foundation-Devices/fix/hdnode-blankby mjg-foundation · 2719f20a · Oct 1, 2026 · 5 filesMessage 73 · AdequateModerate 60Details
Commit message · mjg-foundation

Merge pull request #693 from Foundation-Devices/fix/hdnode-blank

SFT-981: expose HDNode.blank() again and call it where it was commented out

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a security hygiene issue in the Passport hardware wallet firmware. It restores an on-demand 'blank' method for wiping sensitive key data from BIP32 HDNode objects, and starts calling it in places where the code previously only had a TODO comment. It also ensures a 64-byte master seed buffer is wiped after use and that deserialized nodes are allocated with a finalizer so they get wiped when garbage collected. The practical risk is that private key material could remain in device memory longer than intended, but the commit is a defensive cleanup rather than a fix for an active exploit.

Security candidateMerge pull request #697 from Foundation-Devices/SFT-8171-bip39-prefix-boundsby mjg-foundation · 735a0d79 · Oct 1, 2026 · 4 filesMessage 73 · AdequateModerate 59Details
Commit message · mjg-foundation

Merge pull request #697 from Foundation-Devices/SFT-8171-bip39-prefix-bounds

SFT-8171: bounds accounting in BIP39 prefix matching

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Moderate 59/100

This commit fixes two related bugs in the BIP39 word lookup feature used when entering seed words on the Passport hardware wallet. First, the code could write past the end of its result buffer when many words matched a short prefix, because it did not reserve space for the comma separator and string terminator. Second, a negative 'max matches' value from the Python side would be treated as a huge positive number, potentially causing an out-of-bounds write. The patch adds proper bounds checks, rejects negative counts, and adds unit tests to verify safe behavior.

AI review queuedMerge pull request #698 from Foundation-Devices/SFT-8167-sighash-per-input-typeby mjg-foundation · a872cc7f · Oct 1, 2026 · 4 filesMessage 73 · AdequateModerate 59Details
Commit message · mjg-foundation

Merge pull request #698 from Foundation-Devices/SFT-8167-sighash-per-input-type

SFT-8167 SFT-8168: validate sighash types per input type

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit tightens how the Passport hardware wallet checks the 'sighash' flag for each transaction input based on the input type (old-style, SegWit, or Taproot). It also fixes a crash where a bare assertion with no message would make signing fail silently. The change is defensive: it rejects unsupported sighash combinations earlier and makes sure the digest the device signs matches the type recorded in the signature. This reduces the chance that a malicious or malformed PSBT could trick the wallet into signing something different from what it displays.

Security candidateMerge pull request #700 from Foundation-Devices/SFT-8162-dev-pubkey-confirmby mjg-foundation · 0a49b380 · Oct 1, 2026 · 4 filesMessage 73 · AdequateModerate 62Details
Commit message · mjg-foundation

Merge pull request #700 from Foundation-Devices/SFT-8162-dev-pubkey-confirm

SFT-8162: validate and confirm a developer pubkey before installing it

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationboot or update pathmerge-commit duplicate discount
AI analysis · Moderate 62/100

This commit hardens the way Passport hardware wallets install a 'developer public key' used to authorize custom firmware. Previously, any 64-byte blob read from a microSD card could be written straight into the secure element. Now the device checks that the blob is a mathematically valid point on the Bitcoin curve (secp256k1) and shows the user a confirmation screen before storing it. The change prevents installing a malformed or all-zero key that could never verify firmware signatures, and it adds a user approval step so a key cannot be silently swapped.

Security candidateMerge pull request #701 from Foundation-Devices/SFT-8161-use-bip39-generateby mjg-foundation · fe0e08b3 · Oct 1, 2026 · 4 filesMessage 58 · ThinLow 28Details
Commit message · mjg-foundation

Merge pull request #701 from Foundation-Devices/SFT-8161-use-bip39-generate

SFT-8161: honour USE_BIP39_GENERATE

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive pathboot or update pathmerge-commit duplicate discount
AI analysis · Low 28/100

This commit removes the `bip39.generate()` function from the firmware's exposed programming interface when a build flag called `USE_BIP39_GENERATE` is set to 0. Passport already creates wallet seed phrases through a different internal path that uses its own noise/randomness source, so this change simply hides an unused function and adds a test to make sure it stays hidden. It is a defensive hardening change, not a fix for an active bug or exploit.

Lower-prioritySFT-7112: reject missing derivation components before address detectionby Matt Gleason · 6327c369 · Oct 1, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Matt Gleason

SFT-7112: reject missing derivation components before address detection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateMerge pull request #705 from Foundation-Devices/SFT-7322-pairing-secret-erased-wordby mjg-foundation · 74581cff · Oct 1, 2026 · 2 filesMessage 58 · ThinInformational 24Details
Commit message · mjg-foundation

Merge pull request #705 from Foundation-Devices/SFT-7322-pairing-secret-erased-word

SFT-7322: sanity check fix

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
boot or update pathmerge-commit duplicate discount
AI analysis · Informational 24/100

This commit fixes a minor sanity check in the bootloader that generates a device pairing secret. The original code compared only the lowest 8 bits of a 32-bit word against 0xff, when it intended to check the entire 32-bit word against 0xffffffff. Because the value comes from a random number generator, the practical effect is tiny: a valid-but-unintended value could slip through the 'not erased flash' check, but it does not create a security hole an attacker can exploit. The change also adds a regression test to ensure the check works correctly in the future.

AI review queuedMerge pull request #706 from Foundation-Devices/SFT-8178-core-urtypes-migrationby mjg-foundation · bbcf8e93 · Oct 1, 2026 · 3 filesMessage 73 · AdequateInformational 24Details
Commit message · mjg-foundation

Merge pull request #706 from Foundation-Devices/SFT-8178-core-urtypes-migration

SFT-8178: updated foundation urtypes with arena fixes

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit updates a Rust library dependency (foundation-urtypes) used in the Passport hardware wallet firmware to a newer version that includes 'arena fixes.' The code changes rename some data types to use borrowed references (e.g., HDKeyRef instead of HDKey) and add a test to verify that optional key metadata round-trips correctly. The commit message and diff do not describe a specific security vulnerability, exploit, or attack scenario. It appears to be a routine maintenance/migration change that may incidentally improve memory safety, but there is no direct evidence that it fixes an actively exploitable security flaw.

AI review queuedMerge pull request #659 from Foundation-Devices/fix/unicode-settings-saveby Jacksper13 · 273e2d99 · Oct 1, 2026 · 6 filesMessage 58 · ThinModerate 55Details
Commit message · Jacksper13

Merge pull request #659 from Foundation-Devices/fix/unicode-settings-save

Fix Unicode values in external settings

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 55/100

This update fixes a bug in how the Passport hardware wallet saves user settings that contain non-English characters (Unicode). Previously, the code measured text size in characters instead of encoded bytes, so a setting that looked small could actually exceed the storage slot and either be written past its boundary or silently truncated. The patch now encodes the data to UTF-8 bytes before checking size, rejects oversized saves cleanly, and reports a proper error instead of silently failing. It also adds tests for these edge cases.

Lower-priorityMerge pull request #699 from Foundation-Devices/SFT-7321-noise-mixing-loopsby Jacksper13 · 808fb67b · Oct 1, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Jacksper13

Merge pull request #699 from Foundation-Devices/SFT-7321-noise-mixing-loops

SFT-7321: rework the mixing loops in noise_get_random_bytes()

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount