EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 34 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityFix: SIGINT was ignored by the cln docker containerby Nicolas Dorier · 02e06fc6 · Jul 20, 2026 · 1 fileMessage 77 · AdequateInformational 19Details
Commit message · Nicolas Dorier

Fix: SIGINT was ignored by the cln docker container

Changelog-Fixed: Fix: SIGINT was ignored by the cln docker container

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 19/100

This commit fixes a Docker startup script so that when a user or system sends a shutdown signal (SIGINT/SIGTERM) to the container, Core Lightning actually receives it and shuts down cleanly. Previously the signal was ignored, which could force unclean shutdowns. This is a reliability/operational fix, not an exploitable security vulnerability.

Lower-prioritytests: fix flaky test_sql blockheight raceby Ken Sedgwick · 4323207c · Jul 20, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · Ken Sedgwick

tests: fix flaky test_sql blockheight race

The test mines ~106 blocks (channel close, replacement channel
funding, then generate_block(99)) immediately before making three
payments, without waiting for the nodes to process those blocks.
Under valgrind the paying node can lag far behind bitcoind when the
payments start, so it builds onions whose cltv expiries the caught-up
peers reject. Two CI failures showed both shapes of the race:

In one run l1 was ~40 blocks behind (l2/l3 at block 210, l1 still
catching up), so l2 failed the forward: "Expiry cltv 181 too close to
current 210" (expiry_too_soon). Since the error came from the
invoice's route-hint channel, xpay disabled it and the payment failed
hard: "All 1 channels to the destination are disabled."

In the other run l1 was only a few blocks behind, so l3 failed the
final hop: "Expiry cltv too soon 211 < 210 + 5". xpay's
waitblockheight retry then succeeded, but the failed first attempt
left status 'failed' in the forwards row the test later asserts is
'settled'.

The test paid with pay until 7f6a33394 ("pytest: use xpay, not pay in
misc tests."); pay took its start height from bitcoind's headercount
and tracked the node's chainlag, so a lagging node still built onions
valid at the true chain tip. xpay uses its own notification-fed
blockheight plus one block of slack, which is why this only started
flaking recently.

Sync the nodes' blockheights before paying, as other tests do after
mining bursts.

Changelog-None

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit fixes a flaky test, not a security vulnerability. The test sometimes failed because one node was slower to process newly mined blocks than the others, causing payment route expiry values to be rejected. The fix simply waits for all test nodes to catch up to the same block height before making payments. There is no product bug being patched and no security relevance.

Lower-prioritytests: fix flaky listchannels doc example by waiting for l3 to disable its l4 channelby Ken Sedgwick · fc82dc25 · Jul 20, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Ken Sedgwick

tests: fix flaky listchannels doc example by waiting for l3 to disable its l4 channel

The Update examples in doc schemas CI job intermittently fails with the
l3->l4 direction of their channel flipping between disabled and enabled
in the regenerated listchannels example (channel_flags 3 vs 1, active
false vs true).

l4's database is deleted to generate the recoverchannel example, after
which l3 disables its side of the l3-l4 channel. That disabling
channel_update is emitted lazily (via an error reply or the gossip
refresh timer), so whether it lands in l3's gossip store before the
listchannels snapshot is a race; the committed example captured the
post-disable state. Wait for the disable explicitly, as the script
already does for the post-close listchannels races.

Fixes: #9327
Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit fixes a flaky automated test that generates documentation examples. It adds a wait so that a channel disabled by one node is consistently reflected before taking a snapshot. There is no security vulnerability or user-facing bug being fixed.

AI review queueddocs: fixing Fedora installationby enaples · 563b21e4 · Jul 19, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · enaples

docs: fixing Fedora installation

- `dnf`: switched from `groupinstall` to `group install` which is supported both by `dnf4`and `dnf5` which is used starting from fedora41
- added `openssl` and `openssl-devel` dependency
- `uv` install added, which the build now requires
- bumped latest version
- use `uv` to tun the `make`

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only updates the Fedora installation instructions in the documentation. It changes command syntax, adds required build dependencies (openssl, openssl-devel, uv), bumps the example release tag, and switches the build instructions to use the uv Python package manager. There is no code change and no security issue.

Lower-prioritypyln-proto: temporarily switch to coincurve-cp314-fixby daywalker90 · a9c99fe2 · Jul 18, 2026 · 2 filesMessage 73 · AdequateLow 32Details
Commit message · daywalker90

pyln-proto: temporarily switch to coincurve-cp314-fix

Using `uv.sources` / `uv.index` does not work when publishing to pypi.

Instead i forked coincurve master, published all the wheels as coincurve-cp314-fix
v22 with fixes to make it work on python 3.14

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 32/100

This change swaps the project's Python cryptography dependency from the well-known 'coincurve' package to a temporary fork called 'coincurve-cp314-fix' published by an individual contributor (daywalker90). The stated reason is to fix Python 3.14 compatibility while still being publishable to PyPI. Because the new package is a fork maintained outside the original project, users now depend on a less-trusted supply chain. There is no direct evidence of malicious code in the commit, but the change increases supply-chain risk.

Lower-priorityrenepay: add test to check for wrong CLTV computationby Lagrang3 · 40a74a7f · Jul 18, 2026 · 1 fileMessage 75 · AdequateInformational 12Details
Commit message · Lagrang3

renepay: add test to check for wrong CLTV computation

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit only adds a new test case to the Core Lightning test suite. The test is marked as expected to fail (xfail) and checks whether the renepay plugin computes the CLTV (a timeout value used in Lightning payments) correctly. It does not change any production code, fix a bug, or introduce a vulnerability. It is a regression test that documents a suspected miscalculation.

Lower-priorityrenepay: fix CLTV value for the first hopby Lagrang3 · 9181505e · Jul 18, 2026 · 4 filesMessage 68 · AdequateModerate 60Details
Commit message · Lagrang3

renepay: fix CLTV value for the first hop

Changelog-Fixed: renepay: fix the computation of the CLTV for the first hop, it was double counting the current blockheight leading to too 900k blocks into the future.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 60/100

This commit fixes a bug in Core Lightning's renepay plugin where the time-lock expiry (CLTV) for the first hop of a payment was incorrectly calculated by adding the current block height twice. This caused HTLCs to be created with expiry values roughly 900,000 blocks too far in the future. Such far-future expiries could make payments fail or behave unexpectedly, and in edge cases could affect fund safety by making HTLCs resolve very slowly.

Lower-prioritytests: fix flaky reckless tests by waiting for the canned github serverby Ken Sedgwick · d4a960ba · Jul 17, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Ken Sedgwick

tests: fix flaky reckless tests by waiting for the canned github server

The canned_github_server fixture Popens a Flask server and never
waits for it to start listening; the git repository setup between the
Popen and the yield usually gives it enough time. Under CI load it
can lose that race: a valgrind-shard failure shows test_search's
first reckless invocation getting connection refused within a second
of the test starting, while Flask's "Running on http://127.0.0.1:..."
banner only appears in the log after the test had already failed.

Wait for the port to accept connections before yielding, and fail
loudly if the server process dies instead of coming up.

Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit fixes a flaky automated test, not a security bug. The test harness previously started a fake GitHub server and sometimes tried to use it before it was ready, causing random test failures. The patch simply waits for the server to be ready before continuing. There is no vulnerability in production code and no user impact.

Lower-prioritymsggen: new rust types for `sat` and `sat_or_all`by daywalker90 · 8405796b · Jul 17, 2026 · 14 filesMessage 68 · AdequateLow 34Details
Commit message · daywalker90

msggen: new rust types for `sat` and `sat_or_all`

Also stop serializing amounts as string with msat suffix in cln-rpc
and serialize them as a raw number instead, like CLN does it

Changelog-None

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 34/100

This commit changes how the Core Lightning (CLN) Rust RPC and gRPC libraries represent and serialize amounts. It introduces separate types for satoshi-denominated amounts (AmountSat) versus millisatoshi-denominated amounts (Amount), and changes serialization from strings like "10000msat" to raw numbers like 10000. This is a breaking API and wire-format change for generated Rust/gRPC clients, but it is intentional cleanup rather than a clear security fix. There is no vendor statement that this resolves a security issue, and no independent researcher is credited.

Lower-prioritylightningd: reject a channel that reuses an existing funding outpointby Níckolas Goline · 7def3af0 · Jul 16, 2026 · 3 filesMessage 73 · AdequateModerate 59Details
Commit message · Níckolas Goline

lightningd: reject a channel that reuses an existing funding outpoint

A v1 channel_id is derived solely from the funding outpoint, so two
channels funded by the same outpoint would share a channel_id. When a
peer completes a second funding using an outpoint we already have a
channel for, refuse it and drop the connection instead of committing a
second channel with a colliding channel_id.

Add find_channel_by_funding_outpoint() to look up an existing channel by
its funding outpoint.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 59/100

This change prevents a peer from accidentally or maliciously opening a second Lightning channel using the exact same Bitcoin transaction output as an existing channel. Because channel IDs are derived from that funding output, reusing it would create two channels with the same ID, which could confuse the node and potentially lead to incorrect routing or state handling. The fix detects the duplicate and disconnects the peer before the second channel is committed.

Lower-priorityconnectd: handle an already-connected subd gracefullyby Níckolas Goline · c7a013c8 · Jul 16, 2026 · 1 fileMessage 73 · AdequateLow 42Details
Commit message · Níckolas Goline

connectd: handle an already-connected subd gracefully

peer_connect_subd asserted that the subd had no connection yet. Replace
that assertion with defensive handling: if a connection is already
attached for this channel_id, keep it and close the incoming fd. This
avoids aborting connectd in the unexpected case where a second fd
arrives for a subd that already has one.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 42/100

This change fixes a crash in the part of Core Lightning that handles peer connections. Previously, if the same internal connection was unexpectedly set up twice, the program would abort with an assertion failure. Now it logs a debug message and closes the duplicate connection instead. This makes the node more stable against unusual or possibly malicious connection patterns, but the patch is defensive and does not by itself prove an attacker could reliably trigger the crash.

Lower-prioritytests: test RBF stops after closed tx is confirmedby enaples · 3e0f48e1 · Jul 16, 2026 · 1 fileMessage 60 · AdequateModerate 61Details
Commit message · enaples

tests: test RBF stops after closed tx is confirmed

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Moderate 61/100

This commit adds a test that checks whether Core Lightning stops trying to replace (RBF) a penalty transaction once a replacement version has already been confirmed on the blockchain. The test documents a bug where the node would keep firing replacement attempts indefinitely because it looked up the wrong (stale) transaction ID and thought the original was still unconfirmed. The commit itself only adds a regression test, not the fix, so the actual vulnerability is in the pre-existing code being tested.

Lower-prioritychaintopology: fix RBF loop that never stops after replacement tx confirmsby enaples · 15a66cbc · Jul 16, 2026 · 1 fileMessage 85 · StrongModerate 59Details
Commit message · enaples

chaintopology: fix RBF loop that never stops after replacement tx confirms

After consider_onchain_rebroadcast() creates a higher-fee replacement,
rebroadcast_txs() calls refresh() which updates otx->tx in-place, but
the confirmation guard still queries the original otx->txid (the map key):

if (wallet_transaction_height(topo->ld->wallet, &otx->txid))
continue;

Because the original tx was never mined (only the replacement was),
wallet_transaction_height always returns 0 and the RBF loop fires on
every subsequent block forever, even after the channel is fully resolved.

Fix: compute cur_txid from the current otx->tx before the guard. This
naturally reflects any replacement made by a prior refresh() call, so
wallet_transaction_height finds the confirmed txid and skips the entry.

otx->txid (the hash-map key) is intentionally left unchanged: mutating
the key in-place while the entry lives in the map would corrupt the table.

Changelog-Fixed: chaintopology: stop the on-chain RBF rebroadcast loop once a fee-bumped replacement transaction confirms; previously the loop kept firing on every new block forever.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Moderate 59/100

This fix resolves a bug where Core Lightning would keep trying to replace a transaction with a higher-fee version forever, even after the replacement had already been confirmed on the Bitcoin blockchain. The loop happened because the code checked the old transaction ID instead of the current one. This wasted resources, created unnecessary transactions, and could bloat the wallet or leak funds through repeated fees.

Lower-prioritytests: test bookkeeper correctly accounts for splice in/outby enaples · f5965b3a · Jul 15, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · enaples

tests: test bookkeeper correctly accounts for splice in/out

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated tests for the bookkeeper feature, checking that it correctly records accounting events when Lightning channels are spliced in (adding funds) or spliced out (removing funds). It does not change any production code, so it cannot introduce a security vulnerability or directly fix one in the shipped software.

Lower-prioritytests: fixing flake8 + fixed fees in spliceoutby enaples · 906663a0 · Jul 15, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · enaples

tests: fixing flake8 + fixed fees in spliceout

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates a single test file (tests/test_bookkeeper.py). It removes an experimental feature flag that is no longer needed, fixes Python style issues flagged by flake8, and replaces a hardcoded 5000-satoshi splice-out fee estimate with a dynamic fee calculation based on the node's feerate. There is no change to production code, no security fix, and no vulnerability being patched.

Lower-prioritydocs: updated Arch linux source installation instructionsby daywalker90 · 58863ab6 · Jul 15, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · daywalker90

docs: updated Arch linux source installation instructions

Also removed python plugin instructions, they can not be generalized and this repo no
longer has any python plugins that need extra dependencies in production.
Python plugins from the plugins repo have their own documentation.

Changelog-None

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates the Arch Linux installation instructions in the project's documentation. It replaces the older Poetry-based Python setup with the newer 'uv' tool, adds some system dependencies, and removes a section about Python plugins. There are no code changes and no security implications.

Lower-prioritybuild-release: fix VERSION build-arg and add --no-push for the docker targetby ShahanaFarooqui · 92fbf33d · Jul 15, 2026 · 1 fileMessage 83 · StrongInformational 18Details
Commit message · ShahanaFarooqui

build-release: fix VERSION build-arg and add --no-push for the docker target

Pass the computed VERSION as a build-arg, mirroring the docker-release workflow. Without it the container's VERSION is set-but-empty, `VERSION ?=` in the Makefile won't overwrite it, the git-describe fallback never runs, and `make install-program` fails with "git is required for generating version information".

Also add --no-push, so a release captain can do a full test build without publishing elementsproject/lightningd:$VERSION and :latest (the target always runs `docker buildx build --push`, since multi-arch images cannot be --load'ed into the classic docker store). The build only populates the builder's cache; a subsequent run without the flag pushes from cache quickly.

Co-Authored-By: Claude <claude@users.noreply.github.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 18/100

This is a build-script bug fix, not a security vulnerability. The release script for Core Lightning was failing to pass the version number into Docker builds, which caused the build to fail with a confusing git-related error. The patch also adds a --no-push option so release builders can test the Docker build without accidentally publishing images. There is no attacker-controlled behavior or code execution risk.

AI review queuedpyln-proto: use coincurve 21 for python <=3.13 and add self-compiled wheels for python 3.14by daywalker90 · eb42ca93 · Jul 15, 2026 · 2 filesMessage 85 · StrongInformational 16Details
Commit message · daywalker90

pyln-proto: use coincurve 21 for python <=3.13 and add self-compiled wheels for python 3.14

coincurve 20 is broken for all python versions since it now pulls in a transient dependency that turned
a warning into an error:

```
× Failed to build `coincurve==20.0.0`
├─▶ The build backend returned an error
╰─▶ Call to `hatchling.build.build_wheel` failed (exit status: 7)

[stderr]
ERROR: Use build.verbose instead of cmake.verbose for scikit-build-core >= 0.10

hint: This usually indicates a problem with the package or the build environment.
help: `coincurve` (v20.0.0) was included because `cln-meta-project` (v0.1.0) depends on `pyln-proto` (v26.6.2) which depends on `coincurve`
```

coincurve 21 does not have this issue but it does have another issue with python 3.14:

```
Resolved 1 package in 289ms
× Failed to build `coincurve==21.0.0`
├─▶ The build backend returned an error
╰─▶ Call to `hatchling.build.build_wheel` failed (exit status: 1)

[stderr]
Traceback (most recent call last):
File "<string>", line 11, in <module>
wheel_filename = backend.build_wheel("/home/user/.cache/uv/builds-v0/.tmpfcwWrQ", {}, None)
File "/home/user/.cache/uv/builds-v0/.tmpNmyA8G/lib/python3.14/site-packages/hatchling/build.py", line 58, in build_wheel
return os.path.basename(next(builder.build(directory=wheel_directory, versions=["standard"])))
~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/.cache/uv/builds-v0/.tmpNmyA8G/lib/python3.14/site-packages/hatchling/builders/plugin/interface.py", line 149, in build
build_hook.initialize(version, build_data)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
File "/home/user/.cache/uv/sdists-v9/pypi/coincurve/21.0.0/sA4L50tQMHeL37XJdHnME/src/hatch_build.py", line 34, in initialize
raise RuntimeError(message)
RuntimeError: Expected exactly one LICENSE file in cffi distribution, got 0

hint: This usually indicates a problem with the package or the build environment.
```

coincurve for python 3.14 is fixed upstream but there is no release yet, so we use self-compiled wheels just for python 3.14

Changelog-None

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 16/100

This change updates how the project installs a cryptographic helper library called coincurve. The old pinned version was failing to build, so the team switched to a newer official version for most Python releases and, only for Python 3.14, to pre-built wheels hosted by an individual contributor (daywalker90) while waiting for an official fix. The main risk is that Python 3.14 users now trust a third-party package index and compiled binaries instead of the official PyPI release.

Lower-priorityImprove reliability of wait_and_check_bitcoindby Nicolas Dorier · cfb877a3 · Jul 15, 2026 · 1 fileMessage 58 · ThinInformational 17Details
Commit message · Nicolas Dorier

Improve reliability of wait_and_check_bitcoind

Changelog-Fixed: Fixed spurious bitcoind startup failures by retrying bitcoin-cli -rpcwait checks when RPC briefly fails.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 17/100

This change is a reliability fix for how Core Lightning waits for the Bitcoin node (bitcoind) to be ready during startup. It replaces one long 30-second wait with 30 shorter 1-second retries to avoid cases where the connection check would hang even though bitcoind was already available. There is no direct security vulnerability being patched; it is a bug-fix for startup failures.

Lower-priorityCODEOWNERS: remove @devrandomby daywalker90 · 12790264 · Jul 14, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · daywalker90

CODEOWNERS: remove @devrandom

without write access CODEOWNER does not work

Changelog-None

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply removes a GitHub user from the CODEOWNERS file for one file. CODEOWNERS controls who is automatically asked to review changes. The user was removed because they no longer have write access, which is required for CODEOWNERS to work. There is no code change and no security issue in the commit itself.

AI review queuedecdh_hsmd: ensure HSM fd is blocking on setupby Níckolas Goline · f40be192 · Jul 14, 2026 · 1 fileMessage 68 · AdequateLow 47Details
Commit message · Níckolas Goline

ecdh_hsmd: ensure HSM fd is blocking on setup

On macOS under load, socketpair fds sent via SCM_RIGHTS can have
O_NONBLOCK set (from the sender's io_new_conn call in hsmd's
pass_client_hsmfd). This causes wire_sync_read to return NULL
with EAGAIN, killing connectd or channeld with "No hsmd ECDH response".

The fix mirrors the "Don't trust subd to set it blocking" pattern
already used in lightningd/subd.c:read_fds(): explicitly call
io_fd_block(hsm_fd, true) in ecdh_hsmd_setup.

Changelog-Fixed: connectd: fix intermittent "No hsmd ECDH response" crash on macOS under load.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 47/100

This commit fixes a bug where a special internal communication channel (file descriptor) used by Core Lightning could accidentally be left in non-blocking mode on macOS under heavy load. When that happened, a part of the program expecting a blocking read would get an unexpected 'try again' error and crash with 'No hsmd ECDH response.' The fix explicitly forces the channel to blocking mode when it is set up, matching a safety pattern already used elsewhere in the codebase. It is a reliability fix rather than a security vulnerability in the usual attacker-vs-system sense.

Lower-prioritycrates: update dependencies and upgrade quick-xml, tower-http, and tokio-tungsteniteby daywalker90 · 678ff47d · Jul 14, 2026 · 3 filesMessage 73 · AdequateLow 25Details
Commit message · daywalker90

crates: update dependencies and upgrade quick-xml, tower-http, and tokio-tungstenite

```
cargo update
Updating crates.io index
Locking 62 packages to latest Rust 1.85.0 compatible versions
Updating anyhow v1.0.102 -> v1.0.103
Updating arc-swap v1.9.1 -> v1.9.2
Updating arrayvec v0.7.6 -> v0.7.8
Updating base58ck v0.1.100 -> v0.1.101
Updating bitcoin v0.32.100 -> v0.32.101
Adding bitcoin-consensus-encoding v1.0.0
Adding bitcoin-internals v0.5.0
Updating bitcoin-io v0.1.100 -> v0.1.101
Updating bitcoin-units v0.1.100 -> v0.1.101
Updating bitcoin_hashes v0.14.100 -> v0.14.101
Adding block-buffer v0.12.1
Updating bytes v1.11.1 -> v1.12.1
Updating cc v1.2.64 -> v1.2.67
Updating chacha20 v0.10.0 -> v0.10.1
Adding const-oid v0.10.2
Adding crypto-common v0.2.2
Adding defmt v1.1.1
Adding defmt-macros v1.1.1
Adding defmt-parser v1.0.0
Adding digest v0.11.3
Updating env_filter v1.0.1 -> v2.0.0
Updating env_logger v0.11.10 -> v0.11.11
Updating fs-err v3.3.0 -> v3.3.1
Updating getrandom v0.4.2 -> v0.4.3
Adding hex-conservative v0.3.2
Adding hybrid-array v0.4.13
Removing id-arena v2.3.0
Updating jiff v0.2.28 -> v0.2.32
Updating jiff-static v0.2.28 -> v0.2.32
Updating js-sys v0.3.102 -> v0.3.103
Removing leb128fmt v0.1.0
Updating lightning v0.1.8 -> v0.1.11
Updating lightning-invoice v0.33.2 -> v0.33.3
Updating lightning-types v0.2.0 -> v0.2.1
Updating log v0.4.32 -> v0.4.33
Updating memchr v2.8.2 -> v2.8.3
Updating num-bigint v0.4.6 -> v0.4.8
Updating possiblyrandom v0.2.0 -> v0.2.1
Updating quote v1.0.45 -> v1.0.46
Removing rand v0.9.4
Removing rand v0.10.1
Adding rand v0.9.5
Adding rand v0.10.2
Updating regex v1.12.4 -> v1.13.0
Updating regex-automata v0.4.14 -> v0.4.15
Updating rust-embed v8.11.0 -> v8.12.0
Updating rust-embed-impl v8.11.0 -> v8.12.0
Updating rust-embed-utils v8.11.0 -> v8.12.0
Updating rustls v0.23.40 -> v0.23.41
Updating rustls-pki-types v1.14.1 -> v1.15.0
Updating rustversion v1.0.22 -> v1.0.23
Updating sha1 v0.10.6 -> v0.10.7
Updating sha2 v0.10.9 -> v0.11.0
Updating syn v2.0.117 -> v2.0.118
Updating thread_local v1.1.9 -> v1.1.10
Removing unicode-xid v0.2.6
Removing wasip3 v0.4.0+wasi-0.3.0-rc-2026-01-06
Updating wasm-bindgen v0.2.125 -> v0.2.126
Updating wasm-bindgen-futures v0.4.75 -> v0.4.76
Updating wasm-bindgen-macro v0.2.125 -> v0.2.126
Updating wasm-bindgen-macro-support v0.2.125 -> v0.2.126
Updating wasm-bindgen-shared v0.2.125 -> v0.2.126
Removing wasm-encoder v0.244.0
Removing wasm-metadata v0.244.0
Removing wasmparser v0.244.0
Updating web-sys v0.3.102 -> v0.3.103
Updating webpki-root-certs v1.0.7 -> v1.0.8
Removing wit-bindgen v0.51.0
Removing wit-bindgen-core v0.51.0
Removing wit-bindgen-rust v0.51.0
Removing wit-bindgen-rust-macro v0.51.0
Removing wit-component v0.244.0
Removing wit-parser v0.244.0
Updating zerocopy v0.8.52 -> v0.8.54
Updating zerocopy-derive v0.8.52 -> v0.8.54
Updating zlib-rs v0.6.3 -> v0.6.6
Updating zmij v1.0.21 -> v1.0.22
```

quick-xml upgraded to 0.41
tower-http upgraded to 0.7
tokio-tungstenite upgraded to 0.30

No code changes needed.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 25/100

This commit is a routine update of third-party Rust libraries used by Core Lightning's REST and WebSocket proxy plugins. The author says no code changes were needed. It is not a security patch itself, but keeping dependencies current can prevent future security issues from known vulnerabilities in older library versions.

Security candidateautogenerate-rpc-examples.py: disable entropy for generation.by Rusty Russell · 81443075 · Jul 14, 2026 · 2 filesMessage 70 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: disable entropy for generation.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomness
AI analysis · Informational 15/100

This commit changes Core Lightning's internal test tooling so that automatically generated RPC documentation examples use predictable randomness and a fixed clock time. It only affects test/example generation code, not the production Lightning node software that users run. There is no security issue here; it is a developer convenience change to make generated documentation reproducible.

Lower-priorityautogenerate-rpc-examples.py: remove example mangling.by Rusty Russell · 145edea5 · Jul 14, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: remove example mangling.

We temporarily add a flake8 exception so it doesn't complain about all
the now-unused variables.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a cleanup of a test script that generates example outputs for documentation. It removes a large amount of code that was manually replacing real test values with fake placeholder values in the generated examples. The script now stores the real test values directly instead of mangling them. There is no change to the actual Core Lightning node software, its RPC behavior, or its security.

Lower-priorityautogenerate-rpc-examples.py: remove unused varsby Rusty Russell · 68507fe2 · Jul 14, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Rusty Russell

autogenerate-rpc-examples.py: remove unused vars

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a routine cleanup of a test script. It removes variables that were assigned but never used, and deletes a couple of unused example data structures. There is no change to the actual Core Lightning node software, no change to how it handles money or network messages, and no security relevance.