Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit simply adds a new person's PGP public-key fingerprint to the list of trusted release signers in two documentation files. It does not change any code, fix any bug, or alter any security behavior of the software itself.
This is a tiny internal fix to make a bookkeeping migration produce stable event ordering. It changes the timestamp used when creating historical 'deposit' records during a one-time database migration, so the records sort consistently with…
This commit is a documentation-only cleanup of the JSON-RPC command help files. It corrects which numeric error codes are listed for each command so the published schemas match what the software actually returns. No program logic, validati…
Documentation-only change with no executable code modificationsCorrects RPC schema error-code metadata to match actual handler behaviorNo change to input parsing, authorization, cryptography, or network behavior
This commit fixes a bug where a setting that controls whether unexpected transaction signatures are allowed was not initialized when the channel daemon starts. If a peer sent such signatures before the channel was fully ready, the program …
use of uninitialized variableundefined behavior (invalid bool load)network-triggered code path
This commit fixes the project's internal nightly code-coverage CI workflow. It changes how test coverage files are collected, ensures the same LLVM compiler version is used to generate and merge coverage data, and uploads a Codecov-compati…
This commit is a large cleanup of Core Lightning's API schemas, generated RPC bindings, and related plugin code. The stated goal is to make the documented 'required' fields match what the C code actually always produces or expects. In prac…
Large schema-only change with no accompanying security advisory or CVEOne semantic change to plugin hook response: invoice_payment hook can now reject with only failure_message and no resultMany fields change from optional to required in public RPC/protobuf interfaces
This commit only updates documentation. It adds error code 313 to the documented error lists for several Core Lightning commands (fundpsbt, utxopsbt, txprepare, multiwithdraw, and upgradewallet). The error code already existed in the code …
This commit fixes a release-script check that verifies the cryptographic signature on a file of checksums. Previously, the script only told GPG to verify the signature file itself. If someone replaced that signature file with an inline-sig…
Incorrect cryptographic verification logic in release toolingPotential false-positive signature verification with inline-signed .asc substitutionRelease-integrity hardening
This commit updates Core Lightning's release documentation to tell users and release managers to run gpg --verify with both the signature file and the manifest file named explicitly. The old one-argument form can silently succeed even if t…
Verification bypass risk in release artifact validationgpg --verify single-argument form can exit 0 without reading the intended manifestDocumentation-only hardening of release process
This commit is a routine update to the Rust dependency lock file (Cargo.lock), bumping many third-party libraries to newer patch or minor versions. The commit message gives no security reason for the update, and no verified references link…
Routine dependency refresh with no stated security rationaleUpdates to security-sensitive transitive crates (rustls, hyper, h2, tokio, webpki-roots) but no evidence these versions fix known vulnerabilitiesNo source-code changes or patch-specific fixes visible in the diff
This commit fixes a stack-overflow risk in Core Lightning's JSON parser. Before the fix, an attacker could send a valid JSON-RPC message containing thousands of nested brackets or braces. The parser's own helper functions used recursion fo…
Stack-overflow via deeply nested JSONRecursive JSON traversal without depth boundDenial-of-service vector in JSON-RPC input parsing
This commit only fixes typos and comment style. It changes two C-style comments from // to /* */ and corrects a grammar error in a documentation comment ('element' to 'elements'). There are no code behavior changes, no bug fixes, and no se…
This change fixes a test-infrastructure bug in Core Lightning's Python testing helpers. When running tests against a PostgreSQL database, very long test names could be silently shortened by PostgreSQL, causing different test runs or nodes …
No security-relevant signal: change is in test framework code onlyFixes a test reliability issue, not a runtime vulnerabilityNo input sanitization, authentication, cryptography, or network changes
This fix prevents Core Lightning from trying to use freshly created bitcoins (immature coinbase rewards) as emergency funds for fee-bump transactions. Such a transaction would be invalid under Bitcoin's rules and would be rejected by the n…
This commit fixes a bug in Core Lightning's askrene plugin that could prevent a node from restarting. When a saved routing layer contained a node bias with a description, the plugin accidentally freed the description's memory while using i…
Use-after-free / double-take of a tal-allocated string during plugin startupDenial-of-service-like symptom: lightningd aborts before replying to init, node cannot restartFixes publicly reported issue #9433 by endothermicdev
This commit only fixes a test case so it actually exercises the intended code path. It does not change any production code, so it cannot introduce or fix a real-world security vulnerability by itself. The test change is a reproducer for a …
This commit fixes a bug in Core Lightning's experimental dual-funded channel feature. When another node tried to open a channel, Core Lightning was not checking whether the proposed transaction fees were reasonable. A peer could request a …
Missing input validation on wire-parsed feerate fieldsPeer could induce signing and storage of feerate == 0RBF remote path allowed unbounded upward feerate walks
This commit adds regression tests for three related bugs where wildly wrong Bitcoin transaction feerates could enter Core Lightning. In the worst case, a malicious or broken fee source could make the node think a feerate was zero (due to a…
Integer overflow in feerate conversion (u32 wrap from 0xFFFFFFFF perkb to 0 perkw)Absurd feerate from external fee source bypassing sanity ceilingDatabase-stored out-of-range feerate causing startup abort/crash loop
This update fixes a crash bug in Core Lightning. When the software tried to list details of a channel opening in progress, it could crash if a stored fee rate was extremely large or zero. The crash happened because the code used an interna…
Integer overflow in RBF escalation (u32 * 25 / 24) leading to assertion failureAssertion failure in read-only introspection RPC (listpeerchannels) causing crash-loop at startupDatabase value treated as invariant despite originating from external fee estimator
This commit fixes a bug where Core Lightning nodes could get stuck in a crash loop. If a node had previously stored an extremely high or zero fee rate for an in-progress channel funding operation (a 'splice' or dual-funded channel RBF), a …
Integer overflow in fee-rate calculation (u32 overflow when multiplying by 25/24)Assertion failure leading to daemon crash loop at startupDatabase migration clamps out-of-range stored funding feerates
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-priorityaskrene: add timestamp to biasesby Lagrang3 · 5769beb1 · Nov 13, 2025 · 14 filesMessage 68 · AdequateInformational 19Details
Commit message · Lagrang3
askrene: add timestamp to biases
We add one more field to biases: "timestamp". With the timestamp variable old biases can be removed with the askrene-age command.
Changelog-Added: Plugins: askrene channel biases now have an associated timestamp, and are timed out by askrene-age
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100
This commit adds a creation timestamp to the 'channel biases' used by the askrene routing plugin and lets old biases be cleaned up by the existing askrene-age command. It is a feature enhancement, not a security fix. There is no indication it addresses a vulnerability or that the prior lack of timestamps was exploitable.
Lower-prioritydocs: Update rpc commands sync script as per readme API v2by ShahanaFarooqui · bd3b3ca9 · Nov 13, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · ShahanaFarooqui
docs: Update rpc commands sync script as per readme API v2
Changelog-None.
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit updates a GitHub Actions script that publishes Core Lightning's RPC command documentation to the ReadMe documentation platform. It changes API endpoints and authentication format to match ReadMe's newer API version. There is no security-relevant change to the Core Lightning node software, wallet funds, network protocol, or user data.
Lower-prioritydocs: Updated `getting-started` docs for v10by ShahanaFarooqui · 4a6a667c · Nov 13, 2025 · 10 filesMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui
docs: Updated `getting-started` docs for v10
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only updates the formatting and metadata of the 'getting started' documentation files for a new documentation platform version. It does not change any software code, configuration defaults, or security behavior of Core Lightning.
Lower-prioritydocs: Updated `beginners-guide` docs for v10by ShahanaFarooqui · 5d907ca7 · Nov 13, 2025 · 8 filesMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui
docs: Updated `beginners-guide` docs for v10
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only updates documentation metadata in the beginner's guide. It changes front-matter formatting (title quoting, excerpt placement, privacy/view settings) and removes some timestamp fields. No code, configuration, or security behavior is changed.
Lower-prioritydocs: Upgrade rdme from v8 to v10by ShahanaFarooqui · 06118287 · Nov 13, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui
docs: Upgrade rdme from v8 to v10
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit updates the documentation publishing workflow from version 8 to version 10 of a ReadMe.io tool called 'rdme'. It only changes how project documentation is uploaded to an external docs site and does not touch the Core Lightning software itself, user funds, network code, or any secrets storage. The API key is still stored as a GitHub secret and is still passed to the tool in essentially the same way.
Lower-prioritydocs: Updated `node-operators-guide` docs for v10by ShahanaFarooqui · 6bba927f · Nov 13, 2025 · 4 filesMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui
docs: Updated `node-operators-guide` docs for v10
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only updates documentation metadata (front-matter formatting, visibility settings, and timestamps) in the Core Lightning node operator guide. No code, configuration, or security behavior is changed.
Lower-prioritydocs: Updated `contribute-to-core-lightning` docs for v10by ShahanaFarooqui · 529cc7d4 · Nov 13, 2025 · 9 filesMessage 62 · AdequateInformational 15Details
Commit message · ShahanaFarooqui
docs: Updated `contribute-to-core-lightning` docs for v10
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only updates documentation metadata in Core Lightning's contributor guide. It changes front-matter formatting (title quoting, timestamps, privacy settings) across nine markdown files. There are no code, configuration, or behavior changes that could affect security.
AI review queueddocs: Updated `developers-guide` docs for v10by ShahanaFarooqui · 367efcf6 · Nov 13, 2025 · 20 filesMessage 57 · ThinInformational 15Details
Commit message · ShahanaFarooqui
docs: Updated `developers-guide` docs for v10
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
This commit only updates documentation metadata in the Core Lightning developers guide. It changes front-matter formatting (title, slug, excerpt, privacy settings) across 20 markdown files but does not modify any code, configuration, or security-relevant behavior. There is no security issue here.
Lower-priorityautoclean: don't increment num_cleaned when record wasn't even a candidate.by Rusty Russell · 41e21d1d · Nov 13, 2025 · 4 filesMessage 81 · StrongInformational 21Details
Commit message · Rusty Russell
autoclean: don't increment num_cleaned when record wasn't even a candidate.
For example, `autoclean-once failedforwards` would count every non-failed forwards as "uncleaned".
This is both technically correct and completely useless.
Changelog-Fixed: JSON-RPC: `autoclean-once` returns "uncleaned" number reflecting number of candidates which were too new to be cleaned, not all records we didn't delete. Fixes: https://github.com/ElementsProject/lightning/issues/8632 Reported-by: @grubles and several other sharp-eyed users. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 21/100
This commit fixes a bookkeeping bug in the autoclean-once feature. Previously, when you asked to clean up failed payment forwards, the tool counted every forward that wasn't deleted—including successful forwards that were never supposed to be deleted—as 'uncleaned'. Now it only counts records that were actually candidates for cleanup but were too new to be removed. This is a user-interface/reporting fix, not a security vulnerability.
docs: fix htlc states description regarding direction
Changelog-None
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit is a documentation and generated-code cleanup. It corrects a comment that incorrectly described which HTLC (payment routing slot) states correspond to outgoing versus incoming payments, and removes a duplicate enum definition in favor of a shared one. There is no change to how the software actually processes payments or secures funds.
Lower-prioritydocker: Fix missing CLN version in docker imageby ShahanaFarooqui · 57330466 · Nov 13, 2025 · 5 filesMessage 60 · AdequateInformational 15Details
Commit message · ShahanaFarooqui
docker: Fix missing CLN version in docker image
Changelog-Fixed: Core lightning version in Docker image will not be missing.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100
This commit fixes a build issue where Core Lightning Docker images were missing their version label. It changes how the VERSION value is passed from GitHub Actions into the Docker build and how the Makefile accepts an externally provided version. There is no security problem here—just a packaging/metadata fix.
Lower-priorityci: Fix `Release` action failure due to change in `.asc` suffixby ShahanaFarooqui · 31035077 · Nov 13, 2025 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · ShahanaFarooqui
ci: Fix `Release` action failure due to change in `.asc` suffix
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This is a one-line change to the project's GitHub release automation. It removes a command that renamed a checksum signature file. The change fixes a release-script failure caused by an earlier commit that already changed the output filename. There is no indication this affects running Lightning nodes, user funds, network security, or introduces any vulnerability.
Lower-prioritylsp_plugin: add sane error to listprotocolsby Peter Neuroth · 511e61d7 · Nov 13, 2025 · 1 fileMessage 60 · AdequateInformational 18Details
Commit message · Peter Neuroth
lsp_plugin: add sane error to listprotocols
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 18/100
This commit improves error handling in a Core Lightning plugin's list-protocols feature. It replaces a programming panic (an abrupt crash) with proper error messages when something goes wrong, and adds clearer logging. There is no direct evidence this fixes an exploitable security vulnerability, but it does make the plugin more robust and easier to diagnose.
Lower-prioritylsp_plugin: change extra_fee value type to u64by Peter Neuroth · a8d122ba · Nov 13, 2025 · 1 fileMessage 76 · AdequateInformational 12Details
Commit message · Peter Neuroth
lsp_plugin: change extra_fee value type to u64
Blip25 https://github.com/lightning/blips/blob/master/blip-0025.md uses u64 for the `amount_msat` in the `extra_fee`
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 12/100
This is a one-line type correction in a Lightning plugin. The code now reads an unsigned 64-bit integer (u64) instead of a truncated unsigned 64-bit integer (tu64) when fetching the optional 'extra_fee' amount from custom TLV data. The change aligns the implementation with BLIP-25's specification and is best understood as a protocol-compliance fix, not a security patch. There is no direct evidence in the commit or supplied references that this fixes an exploitable vulnerability.
Lower-prioritylsp_plugin: add lsps-jitchannel handlerby Peter Neuroth · ffc0e42f · Nov 13, 2025 · 2 filesMessage 76 · AdequateLow 35Details
Commit message · Peter Neuroth
lsp_plugin: add lsps-jitchannel handler
Adds the full roundtrip to request a jit channel from the LSP. It approves the jit scid returned by the LSP and returns the invoice with the corresponding route-hint.
Changelog-Added Experimental support for LSPS2 no-MPP, Lsps-trusts-client mode. See https://github.com/lightning/blips/blob/master/blip-0052.md for further details.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Low 35/100
This commit adds experimental support for a new Lightning protocol feature called LSPS2 'just-in-time' (JIT) channels. It lets a user request a payment invoice that, when paid, causes a Lightning Service Provider (LSP) to open a new channel on the fly and forward the payment. The code is marked experimental and contains several TODO/FIXME comments noting that important safety checks are not yet implemented, such as verifying the payment is not a forwarded payment, preventing double payment for the same channel, and checking that the LSP is trusted before accepting a zero-confirmation channel.
Lower-prioritylsp_plugin: add basic lsps2 mpp support to clientby Peter Neuroth · be015898 · Nov 13, 2025 · 4 filesMessage 78 · AdequateInformational 11Details
Commit message · Peter Neuroth
lsp_plugin: add basic lsps2 mpp support to client
This includes a mocked lsps2 service plugin, tests and some changes on the client side. The client now can accept mpp payments for a jit-channel opening from a connected LSP.
Changelog-Added: Lsps2 `fixed-invoice-mpp` mode for the lsps2 client
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 11/100
This commit adds experimental support for multi-part payments (MPP) in a new Lightning Service Provider (LSP) feature called LSPS2. It is a feature addition with test code, not a security fix. There is no indication in the commit that it patches a vulnerability or that the project treats it as a security-relevant change.
Lower-prioritytests: use fundwallet instead of manually funding the lspby Peter Neuroth · 9436d52b · Nov 13, 2025 · 1 fileMessage 75 · AdequateInformational 15Details
Commit message · Peter Neuroth
tests: use fundwallet instead of manually funding the lsp
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100
This commit is a minor cleanup of test code only. It replaces a manual three-step process for adding money to a test Lightning node with a single helper call. No production code was changed, and there is no security relevance.
Lower-prioritylsp_plugin: use concrete type to avoid unwrapby Peter Neuroth · ab06508b · Nov 13, 2025 · 2 filesMessage 80 · StrongLow 34Details
Commit message · Peter Neuroth
lsp_plugin: use concrete type to avoid unwrap
This commit adds a custom request type for the on_openchannel hook to avoid calling unwrap() during runtime. We now return cleanly from the hook in any case.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 34/100
This commit removes a runtime call to unwrap() in a Core Lightning plugin that handles incoming channel requests. Previously, if the JSON payload did not contain an 'openchannel' field, the plugin would panic and crash. The fix introduces a proper typed request structure so the plugin can gracefully handle malformed or unexpected input instead of crashing. It is a defensive hardening change rather than a fix for an active exploit.
Lower-prioritylsp_plugin: remove anchor-type from jit channelby Peter Neuroth · 33cd11cb · Nov 13, 2025 · 1 fileMessage 68 · AdequateLow 26Details
Commit message · Peter Neuroth
lsp_plugin: remove anchor-type from jit channel
We use non-anchor channels for now and make this configurable in the future. The reason for this decission is that elements does not support anchors.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 26/100
This commit changes a single number in the code that creates 'just-in-time' (JIT) channels for Lightning Service Providers (LSPs). The old number enabled 'anchor' channels, which are a newer channel type. The new number disables anchors and falls back to a more basic channel type. The stated reason is that the Elements sidechain does not support anchor channels yet. This is a compatibility/configurability change, not a fix for an active security flaw.
Lower-prioritylsp_plugin: remove feature flag temporarily to ...by Peter Neuroth · c40f6ee9 · Nov 13, 2025 · 1 fileMessage 95 · StrongInformational 16Details
Commit message · Peter Neuroth
lsp_plugin: remove feature flag temporarily to ...
please `connect` tests. We need to fix this in the future. Connectd should not tell peers about features of disabled plugins. We need to ensure that connectd only starts once the plugins have returned from init.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 16/100
This commit temporarily stops an experimental Lightning Service Provider (LSP) plugin from advertising a specific protocol feature to other nodes. The change is described by the developer as a short-term workaround to make automated tests pass, not as a security fix. It removes the public announcement of a feature bit while leaving the rest of the plugin's code in place, with a note that the underlying startup-order problem should be fixed later.
Lower-prioritylsp_plugin: remove reserve from hook responseby Peter Neuroth · 9cd041a6 · Nov 13, 2025 · 1 fileMessage 68 · AdequateLow 35Details
Commit message · Peter Neuroth
lsp_plugin: remove reserve from hook response
This slipped in during development but actually, we don't want to mess with the channel reservere here.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 35/100
This commit removes a line that forced a channel reserve to zero in a Lightning plugin's response. A zero reserve could let one side drain a payment channel without keeping the usual safety buffer, potentially making it easier to cheat or destabilize the channel. The change is small and self-described as a development mistake, but the security implications depend on how the plugin is used and whether other protections remain in place.
Lower-prioritylsp_plugin: relax LSP feateture bit handlingby Peter Neuroth · fa8d90f3 · Nov 13, 2025 · 1 fileMessage 68 · AdequateLow 30Details
Commit message · Peter Neuroth
lsp_plugin: relax LSP feateture bit handling
Replace ensure_lsp_connected() by check_peer_lsp_status() which only returns the status of the peer (connected, has_lsp_feature). This allows us to be more tolearant about the LSP feature bit since it is only optional according to the spec.
We still check for the feature but only return a warning in the logs.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 30/100
This change makes a Core Lightning plugin less strict about a peer advertising a specific optional feature flag (the 'LSP feature bit'). Previously, if a peer didn't advertise that bit, the plugin would refuse to talk to it. Now it logs a warning and continues. This is a spec-compliance/usability improvement, not a clear security fix, but it slightly increases the chance of connecting to a peer that doesn't truthfully advertise its capabilities.
Lower-prioritylsp_plugin: add u64 getter and setter to tlvsby Peter Neuroth · d398c7fd · Nov 13, 2025 · 1 fileMessage 68 · AdequateInformational 16Details
Commit message · Peter Neuroth
lsp_plugin: add u64 getter and setter to tlvs
We found a situation where we need to set and get u64s rather than tu64s
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 16/100
This commit adds ordinary helper functions for reading and writing 64-bit unsigned integers inside a type-length-value (TLV) data structure used by a Lightning Network plugin. It is a straightforward feature addition with no visible security bug or fix.
Lower-prioritylsp_plugin: add reversed feature-bit checkby Peter Neuroth · 722c19ae · Nov 13, 2025 · 2 filesMessage 80 · StrongLow 30Details
Commit message · Peter Neuroth
lsp_plugin: add reversed feature-bit check
Core-Lightning returns the feature-bits in reversed order but we don't want to rely on the caller to reverse the u8 slice themselfs. This commit adds a convenience function that reverses the bitmap to avoid hard to debug mistakes.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 30/100
This commit is a small cleanup in a Core Lightning plugin. It moves the logic for reversing a list of feature bits into a shared helper function so callers don't have to remember to reverse the bytes themselves. The change is defensive: it reduces the chance of future mistakes when checking whether a peer supports a particular Lightning feature. There is no direct evidence in the commit of an active security bug being fixed, but the change is security-relevant because incorrect feature-bit checks could cause the plugin to misidentify peer capabilities.
Lower-prioritylsp_plugin: add documentation for optionsby Peter Neuroth · 22269eb6 · Nov 13, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Peter Neuroth
lsp_plugin: add documentation for options
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only adds user-facing documentation describing three already-existing experimental configuration options for a Lightning Service Provider (LSP) plugin. There are no code changes, no behavior changes, and no security fixes.