Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.
This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…
This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…
Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…
This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…
Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…
panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…
This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.
This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…
This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…
No security-relevant signals presentFix is a routine correctness/robustness improvement
This commit is a trivial formatting cleanup (removing an extra blank line and adding one) in a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.
This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…
Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …
Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …
This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…
Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…
Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …
NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…
Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…
This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidatedoc: bring lightning-downgrade's version list up to v26.12.by Ken Sedgwick · 2e7a9f5a · Nov 18, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Ken Sedgwick
doc: bring lightning-downgrade's version list up to v26.12.
The VERSIONS section of lightning-downgrade(8) ended at v25.12. Add v26.04, v26.06 and v26.12. Each goes back one release. The v26.12 tool also removes askrene impressions from the stored layers, because v26.06 cannot read them.
The upgrade guide said that downgrades are not generally possible and did not mention the tool. Name it there.
Changelog-None
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
update trustdocumentation-only discount
AI analysis · Informational 15/100
This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.
Security candidateMakefile: install lightning-downgrade.by Ken Sedgwick · 06ea9ba0 · Nov 18, 2026 · 1 fileMessage 66 · AdequateInformational 23Details
Commit message · Ken Sedgwick
Makefile: install lightning-downgrade.
lightning-downgrade is built with the other tools but is not in BIN_PROGRAMS, so "make install" does not copy it to bindir. The release archives are made from that install, so they have the manual page and not the program: a node upgraded from the release binaries cannot go back without building the tool from source.
Add it to BIN_PROGRAMS, next to lightning-hsmtool. Install and uninstall both work from that list.
Changelog-Fixed: Tools: `lightning-downgrade` is now installed by `make install` and included in the release archives. Fixes: #9746
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
update trust
AI analysis · Informational 23/100
This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contained the tool's manual page but not the tool itself, meaning users who installed from a release binary could not easily downgrade their node without compiling the tool from source. The patch adds the missing program to the install list so it ships with releases. There is no exploit or code flaw in the software's runtime behavior.
AI review queuedwallet: create bwatch tables before backfilling themby daywalker90 · ce2a6836 · Nov 17, 2026 · 2 filesMessage 83 · StrongLow 27Details
Commit message · daywalker90
wallet: create bwatch tables before backfilling them
Databases from v26.06.10 are at migration version 284 and never ran the our_outputs/our_txs CREATE TABLE migrations, which master placed at indices 283/284. On upgrade, migrate_backfill_bwatch_tables (index 285) then inserts into our_outputs and fails with "no such table".
Create both tables with IF NOT EXISTS at the start of the backfill, so it works whether or not the earlier CREATEs ran. Existing databases already have the tables, so this is a no-op for them.
Add a unit test that starts from a v26.06.10-shaped database without the bwatch tables.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a follow-up migration tried to insert data into those non-existent tables and crashed. The fix simply creates the tables if they don't already exist right before filling them, and adds a test that simulates the problematic v26.06.10 database state. It is a reliability/data-integrity fix, not an exploitable security vulnerability.
AI review queuedv26.12rc1by Níckolas Goline · 4002c4e9 · Nov 16, 2026 · 10 filesMessage 5 · OpaqueInformational 15Details
Commit message · Níckolas Goline
v26.12rc1
Changelog-None
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5/100 · OpaqueMessage clarity
✓ Provides an explanatory body! Very short subject! Too few words to establish purpose
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-sensitive behavior in this specific commit.
AI review queuedwallet: store payment failure details per groupidby daywalker90 · 24082c6d · Nov 12, 2026 · 4 filesMessage 68 · AdequateLow 30Details
Commit message · daywalker90
wallet: store payment failure details per groupid
wallet_payment_set_failinfo() matched rows on payment_hash and partid only, a leftover from before groupid became part of the payments key. Every failed retry in a new group therefore overwrote the failure details of all earlier failed groups with the same partid, so waitsendpay (and erroronion in listsendpays/listpays) for an earlier group reported the latest group's error.
Match on groupid too, like wallet_payment_set_status() and wallet_payment_get_failinfo() already do.
Changelog-Fixed: JSON-RPC: `waitsendpay` for an earlier `groupid` now reports that attempt's failure, not the failure of a later retry.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100
This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an additional 'groupid' field, so each retry group's error is stored separately. It is a correctness bug, not a security vulnerability: no funds are at risk and no attacker can exploit it.
AI review queuedcln-plugin: do not panic when the log writer task is goneby cdecker · 8661ffab · Nov 12, 2026 · 1 fileMessage 83 · StrongLow 43Details
Commit message · cdecker
cln-plugin: do not panic when the log writer task is gone
LoggingLayer::on_event forwarded events to the log writer task with sender.send(...).unwrap(). Once that task is gone -- the runtime is shutting down, or the task was dropped or panicked -- the receiver has been dropped, send returns Err(SendError(entry)) and the unwrap panics in whichever code emitted the log event. This usually showed up during node shutdown, after "Lost connection to the RPC socket."
Take the entry back out of the SendError and write it to stderr instead: logging must never panic, and we must not drop the entry either. stderr and not stdout, since stdout is the JSON-RPC channel to lightningd.
Add a unit test that drives the LoggingLayer with a dropped receiver via a local subscriber; it panics without the fallback.
Changelog-Fixed: cln-plugin: a plugin no longer panics when it logs after its log writer task has exited (e.g., during shutdown); the message is written to stderr instead.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 43/100
This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin print the message to stderr instead of crashing. It is a reliability fix rather than an active remote exploit.
Document the recovery bundle, where each input comes from, the point-only peer workflow, transaction timing, and operator verification steps.
Co-authored-by: Cursor <cursoragent@cursor.com>
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no new behavior, and no security fix or vulnerability introduced.
AI review queuedtests: make test_delpay_works deterministicby daywalker90 · a224ca81 · Nov 11, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · daywalker90
tests: make test_delpay_works deterministic
The test relied on force-disconnecting l2 from l3 to make the cheap route fail. Whether that failure happened depended on timing: the disable channel_update for l2<->l3 could reach l1 before it computed the route, in which case l1 never tried the cheap route and only one payment was recorded. This was seen as a CI flake.
Instead, run l2 with the fail_htlcs plugin so it rejects the forward on purpose. The first attempt always fails and the retry via l4 always succeeds.
Also rename the variable that holds the successful payment from `failed` to `success`.
This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.
AI review queueddoc: say that listtransactions gives blockheight 0 for a tx not in a blockby Peter Neuroth · bc281be3 · Nov 7, 2026 · 2 filesMessage 73 · AdequateInformational 20Details
Commit message · Peter Neuroth
doc: say that listtransactions gives blockheight 0 for a tx not in a block
listtransactions also lists transactions that are not in a block: ones we sent that aren't mined yet, and ones a reorg took out of the chain. For those, blockheight and txindex are 0, which the schema didn't say.
Changelog-None
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100
This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was removed by a blockchain reorganization). No code behavior was changed.
AI review queuedfixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 02612ed5 · Nov 5, 2026 · 1 fileMessage 50 · ThinInformational 20Details
Commit message · Amartya Singh
fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 20/100
This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "0btc" instead of raising an exception. It is a correctness fix, not a security vulnerability.
AI review queuedfixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 081ca6c1 · Nov 5, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Amartya Singh
fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit is a trivial formatting cleanup (removing an extra blank line and adding one) in a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.
Check the flags up front and return an error instead.
Changelog-Fixed: JSON-RPC: `addpsbtoutput` and `addpsbtinput` no longer crash when given a v2 PSBT that does not allow modification.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 62/100
This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 'modifiable' flags forbade such changes, the underlying library refused the operation and the lightning daemon crashed with an assertion failure. The patch now checks those flags beforehand and returns a clean error instead of crashing.
Security candidatetests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBTby daywalker90 · 42e268ab · Nov 5, 2026 · 1 fileMessage 83 · StrongModerate 59Details
Commit message · daywalker90
tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT
A v2 PSBT without PSBT_GLOBAL_TX_MODIFIABLE (e.g. one signed by a BIP-370 signer) makes libwally refuse new inputs and outputs, and both commands then hit an assertion:
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100
This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as expected to fail for now, so the underlying crash is not fixed in this commit. A remote or local user who can call these RPC commands with a crafted PSBT could cause the lightning daemon to abort.
AI review queuedpyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 5ebe365d · Nov 5, 2026 · 2 filesMessage 73 · AdequateInformational 20Details
Commit message · Amartya Singh
pyln-client: don't crash Millisatoshi.to_approx_str() on zero
round_to_n() took log10() of the amount to find its magnitude, which fails for 0. Zero needs no rounding, so return it as is; the shortest unit then comes out as "0btc", the same way 1 BTC prints as "1btc".
Changelog-Fixed: pyln-client: `Millisatoshi(0).to_approx_str()` no longer raises a ValueError.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 20/100
This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is no way to exploit it to steal funds, bypass security, or attack a node.
Security candidatedualopen and splicing: add minimal verification of tx_signaturesby Lagrang3 · c6be4f71 · Oct 30, 2026 · 7 filesMessage 83 · StrongModerate 59Details
Commit message · Lagrang3
dualopen and splicing: add minimal verification of tx_signatures
Adding minimal verification of tx_signatures to get closer to the specification on dual funded channels and splice. We check that the witnesses are not empty and do a minimal standardness policy check. The sighash flag must be set to SIGHASH_ALL.
Changelog-Fixed: dualopen and splicing: added tx_signatures verification according to BOLT-2
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100
This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying that they were non-empty, properly formatted, or using the required SIGHASH_ALL signature mode. It also ignored extra witness stacks that did not correspond to any input. The fix makes the node reject malformed or suspicious signatures, which helps prevent invalid or malicious transactions from being finalized and broadcast.
Security candidatechanneld: abort_channels no longer fails a channel with a signed spliceby Andezion · c87f5573 · Oct 29, 2026 · 1 fileMessage 85 · StrongModerate 54Details
Commit message · Andezion
channeld: abort_channels no longer fails a channel with a signed splice
abort_channels passed the last inflight to splice_abort() even once we had sent tx_signatures for it, which failed the channel.
If a negotiation is in progress, that inflight is the splice it is RBFing: abort the negotiation and keep the inflight. If we're quiescent (after stfu_channels), tx_abort is still how we leave, and the inflight is kept too. Otherwise there is nothing to abort, so don't send tx_abort at all: BOLT 2 forbids it after tx_signatures, we're no longer quiescent, and splice_abort() would throw away whatever the peer sends while it waits for the ack.
Changelog-Fixed: abort_channels no longer fails the channel when a splice we already signed is pending. Co-authored-by: Cursor <cursoragent@cursor.com>
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundary
AI analysis · Moderate 54/100
This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts it, even after signatures were exchanged, which caused the channel to fail. Now the code checks whether there is an active splice negotiation or quiescent state, and if the splice is already signed it aborts only the negotiation while keeping the signed splice intact.
AI review queuedlightningd: fix crash on mutual close of an unconfirmed dual-funded channelby Sangbida Chaudhuri · 555143be · Oct 29, 2026 · 1 fileMessage 73 · AdequateModerate 51Details
Commit message · Sangbida Chaudhuri
lightningd: fix crash on mutual close of an unconfirmed dual-funded channel
After an RBF the channel has more than one candidate funding tx. After a mutual close we watch the ones we didn't close on, in case they confirm. To build that watch we need the peer's funding key, and we were reading it from a field that only splices fill in. For RBF it is NULL, and we crashed on it:
RBF never changes the funding keys, so use the channel's own copy of the peer's key instead.
Changelog-Fixed: lightningd: fix a crash on cooperative close of an unconfirmed dual-funded channel.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 51/100
This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump (RBF). The crash is due to the software looking in the wrong place for a needed public key. The fix makes it use the correct copy of that key.
AI review queuedcln-grpc: reject malformed request values instead of panickingby daywalker90 · b2703436 · Oct 28, 2026 · 5 filesMessage 73 · AdequateHigh 74Details
Commit message · daywalker90
cln-grpc: reject malformed request values instead of panicking
The msggen-generated inbound conversions parsed client-controlled pubkeys, hashes, secrets, short channel ids and enum values with unwrap(), so malformed requests could panic the tonic worker task. The hand-written ProofField conversion called std::process::exit(1) when its oneof was missing, killing the plugin, and narrowing u16 fields were silently truncated by `as` casts.
Generate TryFrom impls that return tonic::Status, map parse failures, missing required fields and out-of-range numbers to INVALID_ARGUMENT, and propagate the errors from the server handlers.
Changelog-Fixed: cln-grpc no longer panics on malformed request values.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · High 74/100
This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()' panics, a missing 'oneof' field caused the plugin to call process::exit(1) and shut down, and large numbers were silently truncated when stored as smaller integer types. The patch replaces these crash-prone conversions with fallible TryFrom implementations that return a proper INVALID_ARGUMENT error to the client instead of crashing or killing the plugin.
AI review queuednix: drop protobuf againby Peter Neuroth · a0459eee · Oct 28, 2026 · 1 fileMessage 51 · ThinInformational 15Details
Commit message · Peter Neuroth
nix: drop protobuf again
cln-grpc stopped looking for protoc on PATH in 608f6952e ("cln-grpc: vendor protoc as a build-dependency"): its build script now uses the statically linked protoc from protoc-bin-vendored, which also runs on NixOS. Nothing else in the build calls protoc; the Python bindings use grpc_tools.protoc.
Changelog-None
51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bindings already used a different tool. There is no security-relevant change here.
AI review queuedmake: check gRPC protos for breaking changes against the last releaseby daywalker90 · db5fea70 · Oct 27, 2026 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · daywalker90
make: check gRPC protos for breaking changes against the last release
Add check-grpc-breaking to check-source. It finds the newest release tag reachable from GRPC_BREAKING_BASE_REF and runs buf breaking against the protos at that tag, using the WIRE_JSON rules. The buf CLI is installed as a dev dependency via buf-bin.
Changelog-None
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce a vulnerability. It is purely a development tooling and quality-assurance improvement.
Security candidatemsggen: keep the generated proto wire format stableby daywalker90 · db31e286 · Oct 27, 2026 · 9 filesMessage 73 · AdequateLow 34Details
Commit message · daywalker90
msggen: keep the generated proto wire format stable
Every field number that msggen emits is recorded in .msggen.json (grpc-wire-contract) together with its proto3 label and type. When a JSON schema change later implies a different label or type for a number that was already released, msggen keeps emitting the released one and records the difference so the Rust conversions adapt the value instead of changing the wire format. A change that cannot be bridged that way aborts generation.
This pins down:
- A field released as optional stays optional, so 0/""/false is never silently reinterpreted as "absent". Adding optional is allowed and does not change the encoding. - uint64 released fields that the schema now types as uint32 stay uint64 on the wire and are range-checked in the Rust conversion. - A double released field that the schema now types as an integer stays double. - A string released field that the schema now types as bytes/pubkey stays a string and is hex-decoded/encoded in the conversion. - Sat-denominated request fields (AmountSat/AmountSatOrAll) keep their released number as a deprecated msat field and move the sat value to a fresh *_sat field number. Setting both is rejected, and the old msat field must hold a whole number of satoshis. - Numbers that are no longer emitted are marked reserved.
The cln-rpc Rust types follow the schema as before; only the gRPC wire format is frozen.
Changelog-Deprecated: cln-grpc only: deprecate amount fields for onchain methods, use *_sat fields instead. Old msat fields still work, but must be whole satoshis. Affected messages: AddpsbtoutputRequest, WithdrawRequest, FundpsbtRequest, UtxopsbtRequest, FundchannelRequest, FundchannelStartRequest, MultifundchannelDestinations, OpenchannelBumpRequest, and OpenchannelInitRequest
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Low 34/100
This commit is a large, intentional change to the gRPC code generator used by Core Lightning. Its purpose is to keep the binary wire format of the project's gRPC API stable across future schema changes, so old clients and new servers can still talk to each other. It does this by recording every released field number and type, then adapting mismatches in generated Rust conversion code instead of changing the wire layout. The patch also deprecates several amount fields in on-chain RPCs and introduces new *_sat replacements. There is no obvious security bug in the diff, but the size and complexity of the generator changes create a real risk that future generated conversions could mishandle values, reject valid requests, or silently reinterpret amounts.
AI review queuedlightningd: store the revocation secret before acting on its HTLCsby Christian Decker · 1d9bd904 · Oct 26, 2026 · 1 fileMessage 73 · AdequateModerate 63Details
Commit message · Christian Decker
lightningd: store the revocation secret before acting on its HTLCs
peer_got_revoke() applied the HTLC changes which a revoke_and_ack locks in -- forwarding the final accepts, settling updates and failing fails -- before it had checked the revocation secret. If wallet_shachain_add_hash() rejects that secret we fail the channel anyway, so it must not act on them first.
Run the shachain and revokenum checks before acting on the HTLCs. Nothing in between touches HTLC state, and crash-consistency is unchanged: sd_msg_read() wraps every channeld message in a single DB transaction, so a crash replays the whole message or nothing.
Reported-by: Erick C (@erickcestari)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 63/100
This commit fixes an ordering bug in Core Lightning's handling of 'revoke_and_ack' messages from a peer. Previously, the node would apply pending HTLC (payment channel) changes—such as forwarding payments or settling/failing them—before verifying and storing the peer's revocation secret. If that secret was invalid, the channel would be closed anyway, but only after the HTLC state had already been altered. The fix moves the revocation-secret verification and storage to happen before any HTLC state changes, preventing a potentially inconsistent or exploitable state.
AI review queuedlightningd: record why a local forward failed in listforwardsby Andezion · 03d51eea · Oct 26, 2026 · 34 filesMessage 85 · StrongInformational 19Details
Commit message · Andezion
lightningd: record why a local forward failed in listforwards
Changelog-Added: JSON-RPC: 'listforwards' and the 'forward_event' notification have a new 'failure_reason' field with the root cause of a local forward failure ('insufficient_outgoing_liquidity', 'too_many_htlcs', 'max_htlc_value_in_flight')
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit adds a new 'failure_reason' field to the listforwards RPC output and forward_event notification. It records why a local HTLC forward failed (for example, not enough outgoing liquidity, too many HTLCs, or the peer cannot afford the commitment fee). It is primarily an observability and diagnostics improvement, not a security fix or vulnerability.
AI review queuedlightningd: remove deprecations due in v26.12by daywalker90 · d2a278b4 · Oct 23, 2026 · 20 filesMessage 78 · AdequateLow 29Details
Commit message · daywalker90
lightningd: remove deprecations due in v26.12
These were deprecated in v25.05 or v25.09 and last supported in v26.06 or v26.09:
- `coin_movement` notification: `tags`, `txid`, `utxo_txid` and `vout`. - `channel_state_changed` notification: `short_channel_id` was `null` when unconfirmed. It is now omitted. - Plugin notifications: the legacy `payload` object and flat unwrapped fields. - `pay_notifications.raw_fields`: `channel_hint_update`, `pay_failure` and `pay_success` already wrap their members in an object of the same name. - `wait.details`: the subsystem-specific object is used instead.
The shared coin movement serializer no longer takes the legacy flags. The Python plugin client no longer recreates `payload` for old plugins. The Rust plugin client sends custom notifications in the modern shape only, without the deprecated flat copy of the fields.
The test harness still skips `channel_state_changed` when `message` is `null`: it is deprecated since v25.12 and still supported until v26.12, unlike the removed `short_channel_id` null.
Changelog-Removed: Plugins: `coin_movement` notification `tags`, `txid`, `utxo_txid` and `vout` fields (use `primary_tag`, `extra_tags`, `spending_txid` and `utxo`). Changelog-Removed: Plugins: `channel_state_changed` notification omits `short_channel_id` when the channel is unconfirmed, instead of `null`. Changelog-Removed: Plugins: notifications no longer include the legacy `payload` object or flat unwrapped fields; use the object named after the method instead. Changelog-Removed: JSON-RPC: `wait` no longer returns the `details` object for `invoices`, `forwards` and `sendpays`; use the subsystem-specific object instead.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: unusually broad change
AI analysis · Low 29/100
This commit removes old, previously-announced deprecated API fields and shapes from Core Lightning. It is a planned cleanup, not a security fix. Plugins or clients that still relied on the old fields will break or need to be updated, but there is no new vulnerability introduced.
AI review queueddocs: relabel v26.09 feature markers as v26.12by daywalker90 · b55aca37 · Oct 23, 2026 · 11 filesMessage 80 · StrongInformational 15Details
Commit message · daywalker90
docs: relabel v26.09 feature markers as v26.12
Features added in the v26.09 cycle are now marked for v26.12, the next release. The 26.09 release was skipped, so the version-based `added` markers move to v26.12. Deprecation end markers keep their time-based values.
Changelog-None
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is purely a documentation and metadata relabeling change. It updates version markers from 'v26.09' to 'v26.12' because the v26.09 release was skipped. No code logic, security behavior, or runtime functionality was changed.