EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 47 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritynix: use nixpkgs' lowdown-unsandboxed instead of patching lowdownby Peter Neuroth · 6ad1825c · Oct 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Peter Neuroth

nix: use nixpkgs' lowdown-unsandboxed instead of patching lowdown

nixpkgs already ships lowdown built without its darwin sandbox
(enableDarwinSandbox = false) as lowdown-unsandboxed, and its own nix
package uses it on darwin for the same reason. It's in cache.nixos.org,
so darwin builds no longer compile lowdown locally, and the
--replace-fail on lowdown's main.c can't break on a future lowdown
update. On Linux it's the same package as lowdown.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritybuild: ask brew for Homebrew's prefix instead of hardcoding itby Peter Neuroth · b3c99415 · Oct 28, 2026 · 2 filesMessage 97 · StrongTriage 0Details
Commit message · Peter Neuroth

build: ask brew for Homebrew's prefix instead of hardcoding it

On macOS, configure and the Makefile used /opt/homebrew on arm64 (and
/usr/local otherwise) whether or not Homebrew is installed. The nix dev
shell skips them through IN_NIX_SHELL, but `nix build` doesn't set it.
Darwin builds run without the nix sandbox by default, so on a Mac with
Homebrew the package compiled with -I/opt/homebrew/include ahead of
nix's -isystem paths: it used Homebrew's sodium.h and gmp.h while
linking nix's libsodium.

Ask `brew --prefix` instead, and use nothing from Homebrew when brew
isn't found. A nix build's PATH only holds the build's inputs, so it
gets no Homebrew paths, and neither does a Mac without Homebrew.

Changelog-Fixed: build: on macOS, Homebrew's headers and libraries are only used when Homebrew is installed, and no longer leak into `nix build`.

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-prioritytests: add gRPC request validation regression testsby daywalker90 · a3981e41 · Oct 28, 2026 · 2 filesMessage 83 · StrongTriage 5Details
Commit message · daywalker90

tests: add gRPC request validation regression tests

Regression tests for previous commit: malformed client-supplied pubkeys, hashes, secrets, short channel ids, short-channel-id directions, enum values, out-of-range numbers and incomplete ProofFields must be rejected with INVALID_ARGUMENT instead of panicking or exiting the cln-grpc plugin.

The unit tests exercise the generated conversions directly; the pytest drives a live cln-grpc server, checks that the error names the offending field, and confirms the plugin keeps serving.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI review queuedcln-grpc: reject malformed request values instead of panickingby daywalker90 · b2703436 · Oct 28, 2026 · 5 filesMessage 73 · AdequateHigh 74Details
Commit message · daywalker90

cln-grpc: reject malformed request values instead of panicking

The msggen-generated inbound conversions parsed client-controlled pubkeys, hashes, secrets, short channel ids and enum values with unwrap(), so malformed requests could panic the tonic worker task. The hand-written ProofField conversion called std::process::exit(1) when its oneof was missing, killing the plugin, and narrowing u16 fields were silently truncated by `as` casts.

Generate TryFrom impls that return tonic::Status, map parse failures, missing required fields and out-of-range numbers to INVALID_ARGUMENT, and propagate the errors from the server handlers.

Changelog-Fixed: cln-grpc no longer panics on malformed request values.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · High 74/100

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()' panics, a missing 'oneof' field caused the plugin to call process::exit(1) and shut down, and large numbers were silently truncated when stored as smaller integer types. The patch replaces these crash-prone conversions with fallible TryFrom implementations that return a proper INVALID_ARGUMENT error to the client instead of crashing or killing the plugin.

Lower-priorityplugin-currencyrate: replace reqwest with bitreqby daywalker90 · c44b6620 · Oct 28, 2026 · 5 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

plugin-currencyrate: replace reqwest with bitreq

Port the HTTP client to bitreq, keeping the 10-second request timeout and the 10-redirect limit. Build the SOCKS proxy once at startup and reject IPv6 proxy addresses, which bitreq does not support.

Changelog-Changed: currencyrate: IPv6 proxy addresses are rejected because bitreq does not support them

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityplugin-bip353: update bitcoin-payment-instructions to 0.8by daywalker90 · e51cbf92 · Oct 28, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

plugin-bip353: update bitcoin-payment-instructions to 0.8

bitcoin-payment-instructions 0.8 uses bitreq internally and exposes a proxied HTTP resolver, so drop reqwest and use the new resolver. The outer 30-second timeout on the whole fetch remains.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritynix: make uv use nixpkgs' Python in the dev shell on Linuxby Peter Neuroth · 6b42a832 · Oct 28, 2026 · 1 fileMessage 85 · StrongTriage 0Details
Commit message · Peter Neuroth

nix: make uv use nixpkgs' Python in the dev shell on Linux

On NixOS, uv can't run the Python it downloads, because that binary
expects an FHS dynamic loader:

error: Python interpreter not found at `~/.local/share/uv/python/cpython-3.13.7-.../bin/python3.13`

Point uv at nixpkgs' Python and stop it from downloading one. This
also keeps the Python, glibc and the libstdc++ on LD_LIBRARY_PATH from
the same nixpkgs.

Changelog-None

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-prioritynix: only set LD_LIBRARY_PATH in the dev shell on Linuxby Peter Neuroth · 9b6f6879 · Oct 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Peter Neuroth

nix: only set LD_LIBRARY_PATH in the dev shell on Linux

The libstdc++ that wheels such as grpcio need is a Linux problem. On
darwin, stdenv.cc.cc is clang, so the hook put clang's lib directory on
the library path for no reason. The shellHook already refers to
stdenv.cc.cc.lib, which pulls it into the shell, so it doesn't need to
be in buildInputs as well.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritynix: move openssl from the package to the dev shellsby Peter Neuroth · 4ec6163a · Oct 28, 2026 · 2 filesMessage 83 · StrongTriage 5Details
Commit message · Peter Neuroth

nix: move openssl from the package to the dev shells

Only the fuzz targets include OpenSSL headers, and make compiles them
only when `openssl version` reports 3 or later. A package in
buildInputs also puts its binary on PATH, so with openssl in the
package, `nix build` would compile the fuzz targets as well. Keep it in
the dev shells, where they're wanted. The package derivation is then the
same as on master.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI review queuednix: drop protobuf againby Peter Neuroth · a0459eee · Oct 28, 2026 · 1 fileMessage 51 · ThinInformational 15Details
Commit message · Peter Neuroth

nix: drop protobuf again

cln-grpc stopped looking for protoc on PATH in 608f6952e ("cln-grpc:
vendor protoc as a build-dependency"): its build script now uses the
statically linked protoc from protoc-bin-vendored, which also runs on
NixOS. Nothing else in the build calls protoc; the Python bindings use
grpc_tools.protoc.

Changelog-None

51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bindings already used a different tool. There is no security-relevant change here.

Lower-priorityonchaind: give an HTLC output to a live HTLC, not a removed look-alike.by Sangbida Chaudhuri · 41ec0d5d · Oct 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

onchaind: give an HTLC output to a live HTLC, not a removed look-alike.

When two HTLCs on the list matched the same output, onchaind took the
first one in cltv order. If a removed HTLC had the same payment hash,
amount and cltv as a live one, it could win, and the live HTLC was
reported missing. lightningd then failed it upstream right away, while
the peer could still claim the output onchain with the preimage. A
forwarding node loses the whole HTLC.

Same bug as 027e97eb9 (trimmed HTLC as the look-alike), different decoy.

Fix: when HTLCs tie on cltv, sort the ones lightningd says are present
first. Matching is still one output to one HTLC, so a commitment that
really does have two identical HTLCs works as before.

Changelog-Fixed: onchaind: an HTLC removed just before a unilateral close, with the same payment hash, amount and cltv as a live one, could be mistaken for it onchain, causing us to fail the live HTLC upstream while the peer could still claim it.

Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritylightningd: tell onchaind which HTLCs are actually in the closing tx.by Sangbida Chaudhuri · 086bc092 · Oct 28, 2026 · 4 filesMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

lightningd: tell onchaind which HTLCs are actually in the closing tx.

When a channel closes, lightningd gives onchaind a list of HTLCs that
might be in the commitment tx. The list is a bit too generous: an HTLC
removed just before the close is still on it.

That's harmless until two of those HTLCs share a payment hash, amount
and cltv: onchaind can't tell them apart, and the commitment tx may
contain only one of them. We still track each live HTLC's state, which
says whether it's in the latest commitment on each side, or in the
peer's previous commitment while that one is not yet revoked. Send
that as a `present` flag with each HTLC.

onchaind stores the flag but doesn't act on it yet.

Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityonchaind: tell lightningd whether the closing tx is our commitment or theirs.by Sangbida Chaudhuri · 35154be8 · Oct 28, 2026 · 4 filesMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

onchaind: tell lightningd whether the closing tx is our commitment or theirs.

onchaind works this out when it starts (it compares the txid to the one
lightningd told it we broadcast). lightningd only gets the commitment
number back, which doesn't say whose commitment it is. Add a flag to
init_reply so it knows.

lightningd reads the flag but doesn't use it yet.

Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritylsps-plugin: don't let a JIT invoice outlive valid_untilby Peter Neuroth · 9d62d546 · Oct 27, 2026 · 1 fileMessage 85 · StrongTriage 0Details
Commit message · Peter Neuroth

lsps-plugin: don't let a JIT invoice outlive valid_until

For a fixed amount the client creates the invoice twice: the public one
and, after deleting it, a copy for the amount minus the opening fee,
which the reduced HTLCs pay. Both used an expiry computed before the
first call, so the copy expired later than the public invoice by however
long creating and deleting that took, which can be past the params'
valid_until. Compute the copy's expiry from valid_until when creating
it.

lightningd adds the expiry to its own clock when it creates the invoice,
so the time the `invoice` call itself takes counts as well. Take a few
seconds off both expiries so that a slow call doesn't push either
invoice past valid_until.

Changelog-Fixed: lsps-plugin: `lsps-lsps2-invoice` no longer creates an invoice that stays valid past the opening fee params' `valid_until`.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityci: run buf breaking in the prebuild jobby daywalker90 · 3d350b44 · Oct 27, 2026 · 1 fileMessage 80 · StrongTriage 0Details
Commit message · daywalker90

ci: run buf breaking in the prebuild job

Pass GRPC_BREAKING_BASE_REF so the check compares against the newest
release reachable from the PR base.

Changelog-None

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI review queuedmake: check gRPC protos for breaking changes against the last releaseby daywalker90 · db5fea70 · Oct 27, 2026 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · daywalker90

make: check gRPC protos for breaking changes against the last release

Add check-grpc-breaking to check-source. It finds the newest release tag
reachable from GRPC_BREAKING_BASE_REF and runs buf breaking against the
protos at that tag, using the WIRE_JSON rules. The buf CLI is installed as
a dev dependency via buf-bin.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce a vulnerability. It is purely a development tooling and quality-assurance improvement.

Lower-priorityCI: update github actionsby daywalker90 · 41362d38 · Oct 27, 2026 · 17 filesMessage 47 · ThinTriage 0Details
Commit message · daywalker90

CI: update github actions

Changelog-None

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
Lower-prioritycommon/test: don't start a non-quote comment with BOLTby Níckolas Goline · 5d763116 · Oct 27, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Níckolas Goline

common/test: don't start a non-quote comment with BOLT

check-source-bolt reads any "BOLT #4" comment as a spec quote, and this
one isn't.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 893ec0f55d77825def0b805536e5693d65bff2f4)

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritymsggen: require fields added up to v26.06by daywalker90 · 633c0075 · Oct 27, 2026 · 7 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

msggen: require fields added up to v26.06

OptionalPatch.supported() moves from v24.11 to v26.06, so schema
fields marked required and added up to v26.06 become non-optional.
A field added after v26.06 stays optional.

Changelog-Changed: cln-rpc: No longer parse messages from nodes older than v26.06, because fields marked required in the schema and added up to v26.06 are now required in the Rust types, e.g. `openchannel` hook `channel_type` and onion message `first_path_key`. `Option<T>` is now `T`.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Security candidatemsggen: keep the generated proto wire format stableby daywalker90 · db31e286 · Oct 27, 2026 · 9 filesMessage 73 · AdequateLow 34Details
Commit message · daywalker90

msggen: keep the generated proto wire format stable

Every field number that msggen emits is recorded in .msggen.json
(grpc-wire-contract) together with its proto3 label and type. When a
JSON schema change later implies a different label or type for a number
that was already released, msggen keeps emitting the released one and
records the difference so the Rust conversions adapt the value instead
of changing the wire format. A change that cannot be bridged that way
aborts generation.

This pins down:

- A field released as optional stays optional, so 0/""/false is never
silently reinterpreted as "absent". Adding optional is allowed and
does not change the encoding.
- uint64 released fields that the schema now types as uint32 stay
uint64 on the wire and are range-checked in the Rust conversion.
- A double released field that the schema now types as an integer
stays double.
- A string released field that the schema now types as bytes/pubkey
stays a string and is hex-decoded/encoded in the conversion.
- Sat-denominated request fields (AmountSat/AmountSatOrAll) keep their
released number as a deprecated msat field and move the sat value to
a fresh *_sat field number. Setting both is rejected, and the old
msat field must hold a whole number of satoshis.
- Numbers that are no longer emitted are marked reserved.

The cln-rpc Rust types follow the schema as before; only the gRPC wire
format is frozen.

Changelog-Deprecated: cln-grpc only: deprecate amount fields for onchain methods, use *_sat fields instead. Old msat fields still work, but must be whole satoshis. Affected messages: AddpsbtoutputRequest, WithdrawRequest, FundpsbtRequest, UtxopsbtRequest, FundchannelRequest, FundchannelStartRequest, MultifundchannelDestinations, OpenchannelBumpRequest, and OpenchannelInitRequest

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Low 34/100

This commit is a large, intentional change to the gRPC code generator used by Core Lightning. Its purpose is to keep the binary wire format of the project's gRPC API stable across future schema changes, so old clients and new servers can still talk to each other. It does this by recording every released field number and type, then adapting mismatches in generated Rust conversion code instead of changing the wire layout. The patch also deprecates several amount fields in on-chain RPCs and introduces new *_sat replacements. There is no obvious security bug in the diff, but the size and complexity of the generator changes create a real risk that future generated conversions could mishandle values, reject valid requests, or silently reinterpret amounts.

AI review queuedlightningd: store the revocation secret before acting on its HTLCsby Christian Decker · 1d9bd904 · Oct 26, 2026 · 1 fileMessage 73 · AdequateModerate 63Details
Commit message · Christian Decker

lightningd: store the revocation secret before acting on its HTLCs

peer_got_revoke() applied the HTLC changes which a revoke_and_ack
locks in -- forwarding the final accepts, settling updates and
failing fails -- before it had checked the revocation secret. If
wallet_shachain_add_hash() rejects that secret we fail the channel
anyway, so it must not act on them first.

Run the shachain and revokenum checks before acting on the HTLCs.
Nothing in between touches HTLC state, and crash-consistency is
unchanged: sd_msg_read() wraps every channeld message in a single DB
transaction, so a crash replays the whole message or nothing.

Reported-by: Erick C (@erickcestari)

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 63/100

This commit fixes an ordering bug in Core Lightning's handling of 'revoke_and_ack' messages from a peer. Previously, the node would apply pending HTLC (payment channel) changes—such as forwarding payments or settling/failing them—before verifying and storing the peer's revocation secret. If that secret was invalid, the channel would be closed anyway, but only after the HTLC state had already been altered. The fix moves the revocation-secret verification and storage to happen before any HTLC state changes, preventing a potentially inconsistent or exploitable state.

AI review queuedlightningd: record why a local forward failed in listforwardsby Andezion · 03d51eea · Oct 26, 2026 · 34 filesMessage 85 · StrongInformational 19Details
Commit message · Andezion

lightningd: record why a local forward failed in listforwards

Changelog-Added: JSON-RPC: 'listforwards' and the 'forward_event' notification have a new 'failure_reason' field with the root cause of a local forward failure ('insufficient_outgoing_liquidity', 'too_many_htlcs', 'max_htlc_value_in_flight')

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds a new 'failure_reason' field to the listforwards RPC output and forward_event notification. It records why a local HTLC forward failed (for example, not enough outgoing liquidity, too many HTLCs, or the peer cannot afford the commitment fee). It is primarily an observability and diagnostics improvement, not a security fix or vulnerability.

Lower-prioritytests: explain why the LSPS2 oracles have their own unit testsby Peter Neuroth · c0e8d891 · Oct 26, 2026 · 1 fileMessage 72 · AdequateTriage 0Details
Commit message · Peter Neuroth

tests: explain why the LSPS2 oracles have their own unit tests

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode✓ Mentions testing or verification! No meaningful explanatory body
Lower-priorityMakefile: don't print errors when openssl or git are missingby Peter Neuroth · 19b9abd7 · Oct 26, 2026 · 1 fileMessage 83 · StrongTriage 5Details
Commit message · Peter Neuroth

Makefile: don't print errors when openssl or git are missing

The Makefile runs `openssl version` and `git ls-files` while it is being
parsed. Where they are missing, as in a nix build, every make invocation
printed "openssl: command not found", "test: -ge: unary operator
expected" and "not a git repository" errors. Silence them; the fuzz
targets are still only included with OpenSSL >= 3.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
Lower-prioritytests: bound test_gossip_throttle by what the throttle guaranteesby Ken Sedgwick · d78749c8 · Oct 23, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Ken Sedgwick

tests: bound test_gossip_throttle by what the throttle guarantees

The test required the throttled peer to take more than three seconds
for 17 messages. That bound came from the 500 bytes per second
--dev-throttle-gossip allowed when the test was written. 5134ee4d5
raised the test rate to 1000 bytes per second and made the delay
proportional with a one-second floor, so the 3,582 bytes now need
two or three waits of a little over a second, and which it is depends
on how the messages pack into the one-second windows. Two waits take
2.4 to 2.9 s and fail the bound.

What the throttle guarantees is one wait of at least a second once a
window is over budget, which these messages always are. Assert that,
and check the throttle engaged through connectd's log line, which is
written once per peer connection.

Fixes: #9659
Changelog-None

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference