EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 43 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritypytest: don't rely on -txindex in test_onchain_all_dustby Níckolas Goline · c4de972e · Nov 3, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Níckolas Goline

pytest: don't rely on -txindex in test_onchain_all_dust

The test elementsd runs without -txindex, so getrawtransaction on the
mined HTLC spend failed on liquid:

No such mempool transaction. Use -txindex or provide a block hash
to enable blockchain transaction queries.

Pass the hash of the block that mined it.

Changelog-None
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019hbJ3AeummizNQSXoHKhYo

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritypyln-client: strip the NUL padding from a Gossmap node aliasby Amartya Singh · 3d16a994 · Nov 3, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Amartya Singh

pyln-client: strip the NUL padding from a Gossmap node alias

Aliases are NUL padded to 32 bytes in node_announcement, and Gossmap
kept the padding, so `node.alias` didn't compare equal to the name the
node set, or to what listnodes returns. Cut it at the first NUL, as
listnodes does with tal_strndup().

Changelog-Fixed: pyln-client: `GossmapNode.alias` no longer includes the NUL padding from the node_announcement.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritypyln-client: test that Gossmap strips the NUL padding from an aliasby Amartya Singh · 2642995e · Nov 3, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Amartya Singh

pyln-client: test that Gossmap strips the NUL padding from an alias

A node_announcement alias is always 32 bytes, NUL padded, so a node
called "bob" shows up in Gossmap as 'bob\x00\x00...' (29 NULs), while
listnodes, which copies it with tal_strndup(), says "bob". Mark the
test xfail until the fix.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritypyln-client: don't fail to load gossip on a non-UTF-8 node aliasby Amartya Singh · 6cb198b1 · Nov 3, 2026 · 2 filesMessage 73 · AdequateTriage 8Details
Commit message · Amartya Singh

pyln-client: don't fail to load gossip on a non-UTF-8 node alias

Gossmap decoded every node alias with a strict .decode('utf-8'), so
one node announcing invalid UTF-8 made Gossmap() and refresh() raise
UnicodeDecodeError for the whole gossip_store. Decode with
errors='replace' instead: listnodes doesn't validate aliases either.

Changelog-Fixed: pyln-client: `Gossmap` no longer fails to load the gossip store when a node announces an alias that is not valid UTF-8.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validation
Lower-prioritypyln-client: test Gossmap with a node alias that isn't UTF-8by Amartya Singh · 1bd3bb79 · Nov 3, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Amartya Singh

pyln-client: test Gossmap with a node alias that isn't UTF-8

A node_announcement alias is 32 arbitrary bytes and gossipd doesn't
check it, so any node on the network can announce one that isn't valid
UTF-8, e.g. an emoji cut short at the 32 byte limit. Gossmap then
fails to load the whole store:

UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 29-30: invalid continuation byte

Patch one alias in gossip_store.simple and mark the test xfail until
the fix.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: refuse a splice RBF feerate above the most we'll payby Sangbida Chaudhuri · 87952e13 · Nov 3, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

lightningd: refuse a splice RBF feerate above the most we'll pay

splice_feerate() is already capped at our_feerate_max(), so raising it to
25/24 of a splice that is pending near that cap goes over. channeld
refuses that too, but only after setting peer->splicing, which it does
not clear on that error: every later splice_init then failed with "Can't
start two splices on the same channel at once" until channeld restarted.
An explicit feerate above the cap did the same.

Refuse it in json_splice_init instead, as openchannel_bump does.

Changelog-Fixed: splice_init: a feerate above the most we'll pay no longer leaves the channel unable to splice until channeld restarts.
Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityaskrene: clamp the accumulation of biasby Lagrang3 · 47b3f0ba · Nov 2, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3

askrene: clamp the accumulation of bias

Node and channel bias add up but they never should exceed the [-100, 100] range

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityhsmd: sign our HTLC tx input with SIGHASH_ALLby Vladyslav Doronchenkov · efdfcc6d · Nov 2, 2026 · 2 filesMessage 45 · ThinTriage 0Details
Commit message · Vladyslav Doronchenkov

hsmd: sign our HTLC tx input with SIGHASH_ALL

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritypytest: rewind to an absolute DB version in the feerate clamp upgrade testby Andezion · 9400561d · Oct 31, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Andezion

pytest: rewind to an absolute DB version in the feerate clamp upgrade test

Changelog-None

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Lower-prioritymake: generate Rust and gRPC sources without Rustby daywalker90 · cbfd29f9 · Oct 30, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · daywalker90

make: generate Rust and gRPC sources without Rust

cln-rpc and cln-grpc were included only when RUST is enabled, so with
--disable-rust their generated sources (cln-rpc/src/{model,notifications,
hooks}.rs and cln-grpc/proto/node.proto, convert.rs, server.rs) were
never listed in MSGGEN_GENALL and make gen silently skipped them. A
schema change could then be committed without its generated output.

Include both sub-Makefiles unconditionally, and keep only the cargo
example and lsps-types build behind RUST.

Changelog-None

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidatedualopen and splicing: add minimal verification of tx_signaturesby Lagrang3 · c6be4f71 · Oct 30, 2026 · 7 filesMessage 83 · StrongModerate 59Details
Commit message · Lagrang3

dualopen and splicing: add minimal verification of tx_signatures

Adding minimal verification of tx_signatures to get closer to the
specification on dual funded channels and splice. We check that the
witnesses are not empty and do a minimal standardness policy check. The
sighash flag must be set to SIGHASH_ALL.

Changelog-Fixed: dualopen and splicing: added tx_signatures verification according to BOLT-2

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying that they were non-empty, properly formatted, or using the required SIGHASH_ALL signature mode. It also ignored extra witness stacks that did not correspond to any input. The fix makes the node reject malformed or suspicious signatures, which helps prevent invalid or malicious transactions from being finalized and broadcast.

Lower-prioritypyln-testing: validate plugin-io hook payloads against doc/schemas/hookby daywalker90 · 37de94d1 · Oct 30, 2026 · 1 fileMessage 83 · StrongTriage 8Details
Commit message · daywalker90

pyln-testing: validate plugin-io hook payloads against doc/schemas/hook

checkPluginJSON only validated notifications. Load the hook schemas too,
so hook_in and hook_out payloads recorded in plugin-io are checked.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validation
Lower-prioritylightningd: an RBF splice_init must meet the 25/24 feerate floorby Andezion · ebe247cc · Oct 29, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Andezion

lightningd: an RBF splice_init must meet the 25/24 feerate floor

With a splice pending, channeld sends splice_init as tx_init_rbf, and
BOLT 2 requires that feerate to be at least 25/24 of the previous one.
We didn't check, so we proposed RBFs a peer such as Eclair rejects.

Refuse a lower feerate at the RPC, and raise the default up to the
floor. test_splice_rbf_duplicate_inflight's RBF now has to clear it.

Changelog-Fixed: splice_init: RBF of a pending splice now uses at least 25/24 of its feerate, which peers such as Eclair require.
Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidatechanneld: abort_channels no longer fails a channel with a signed spliceby Andezion · c87f5573 · Oct 29, 2026 · 1 fileMessage 85 · StrongModerate 54Details
Commit message · Andezion

channeld: abort_channels no longer fails a channel with a signed splice

abort_channels passed the last inflight to splice_abort() even once we
had sent tx_signatures for it, which failed the channel.

If a negotiation is in progress, that inflight is the splice it is
RBFing: abort the negotiation and keep the inflight. If we're quiescent
(after stfu_channels), tx_abort is still how we leave, and the inflight
is kept too. Otherwise there is nothing to abort, so don't send
tx_abort at all: BOLT 2 forbids it after tx_signatures, we're no longer
quiescent, and splice_abort() would throw away whatever the peer sends
while it waits for the ack.

Changelog-Fixed: abort_channels no longer fails the channel when a splice we already signed is pending.
Co-authored-by: Cursor <cursoragent@cursor.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundary
AI analysis · Moderate 54/100

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts it, even after signatures were exchanged, which caused the channel to fail. Now the code checks whether there is an active splice negotiation or quiescent state, and if the splice is already signed it aborts only the negotiation while keeping the signed splice intact.

Lower-prioritylightningd: sign inflight commitments with the splice's remote funding keyby Andezion · 3ac8f3b6 · Oct 29, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Andezion

lightningd: sign inflight commitments with the splice's remote funding key

The peer may use a new funding_pubkey for a splice, so the splice output
is a 2-of-2 of our key and that one. We signed an inflight's commitment
with the channel's current remote funding key, which doesn't match it.

Use the inflight's splice_remote_funding, the key we already watch the
splice output with, in drop_to_chain() and dev-sign-last-tx.

Changelog-Fixed: lightningd: unilateral close of a channel with a pending splice now works when the peer used a new funding key for it.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritymsggen: key notification field numbers by their protobuf messageby daywalker90 · bc8a9453 · Oct 29, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

msggen: key notification field numbers by their protobuf message

Notifications are generated under a renamed protobuf message
(notification_typename_overrides), but their field numbers were looked
up in grpc-field-map under the unrenamed name. A type shared by an RPC
response and a notification (ConnectAddress) therefore got one number
space: a field only the notification has was reserved on the response.

Key grpc-field-map by the protobuf message name, the same name the
contract uses, and move the connect notification entries to match.
Generated output is unchanged.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritydocs: connect can report an unresolved addressby daywalker90 · 4aac36f0 · Oct 29, 2026 · 10 filesMessage 80 · StrongTriage 0Details
Commit message · daywalker90

docs: connect can report an unresolved address

When a peer is dialed through a proxy (or with DNS disabled) the
address is ADDR_INTERNAL_FORPROXY, and json_add_address_internal()
serializes it as type "unresolved" with name and port:

common/json_stream.c:582-587
case ADDR_INTERNAL_FORPROXY:
json_add_string(response, "type", "unresolved");
json_add_string(response, "name", addr->u.unresolved.name);
json_add_num(response, "port", addr->u.unresolved.port);

The connect RPC (lightningd/connect_control.c:66) and the connect
notification (lightningd/notification.c:69) both use that serializer. Add the "unresolved" enum value
and its required name/port fields to the connect response schema, and
to the notification schema. The notification already documents
"websocket", so only "unresolved" is new there.

Changelog-Fixed: cln-rpc and cln-grpc: connect responses and connect notifications with an unresolved address no longer fail to parse.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Lower-prioritytests: send the sat value of WithdrawRequest in satoshi_satby daywalker90 · 730233fe · Oct 29, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: send the sat value of WithdrawRequest in satoshi_sat

WithdrawRequest.satoshi is the released msat field, and the sat value
moved to satoshi_sat (see msggen: keep the generated proto wire format
stable). Sending AmountSatOrAll to satoshi no longer type-checks, so the
amount_sat_or_all validation case must target satoshi_sat.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: watch the funding output on restart while awaiting a spliceby cdecker · d0cec777 · Oct 29, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · cdecker

lightningd: watch the funding output on restart while awaiting a splice

setup_peer() re-arms the chain watches for every channel on startup. For
a channel in CHANNELD_AWAITING_SPLICE it only watched the splice
inflights, so after a restart nothing was watching the channel's current
funding output. That output stays live until a splice confirms, and if
it is spent by a commitment instead we never noticed: onchaind was not
started and the channel was stuck in CHANNELD_AWAITING_SPLICE.

Watch the funding as we do in every other state, so the channel has the
same watches it had before the restart.

Changelog-Fixed: lightningd: a channel with an unconfirmed splice now notices if its funding output gets spent after a restart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityxpay: add xpay-failing-node-toleranceby Lagrang3 · d424451e · Oct 29, 2026 · 5 filesMessage 80 · StrongTriage 0Details
Commit message · Lagrang3

xpay: add xpay-failing-node-tolerance

We disable a node for the current payment session if the number of weird
failures is equal to the xpay-failing-node-tolerance. For repeated
failing nodes we also apply a global negative bias to avoid that node on
other payments. The bias is by default applied after the first 2
failures and it accumulates. If xpay-failing-node-tolerance is less
than 2 we apply the bias the moment we disable the node.

Changelog-Added: xpay: add xpay-failing-node-tolerance option to set the number of weird failures that trigger a node to be disabled during the current payment session.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityxpay: avoid bad nodesby Lagrang3 · ff375b52 · Oct 29, 2026 · 3 filesMessage 51 · ThinTriage 0Details
Commit message · Lagrang3

xpay: avoid bad nodes

We have had reports of payment failures by xpay timeout after multiple
routes have been tried over the same node with weird errors like
unknown_next_peer and fee_insufficient.
These nodes are usually well connected hubs with hundreds of channels
and they tend to be preferred by getroutes even after the first erring
channels are disabled. Naturally, we only disable channels for the
current payment session, so next time a second payment prefers that
route it will fail as well.
To fix this we add a negative bias on the failing channels that persist
across payments and if we detect a pattern in the failing node we
disable it completely on the current session and add a persistent bias
to it.

When receiving one of the three payment errors invalid_onion_version,
invalid_onion_key or invalid_onion_hmac we do not penalize the node
sending the error, since it is sent on behalf of the next peer,
we just disable the channel.

Changelog-Fixed: xpay: avoid channel and nodes that fail too often with weird errors

Reported-by: @blockdyor and @ErikDeSmedt
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
AI review queuedlightningd: fix crash on mutual close of an unconfirmed dual-funded channelby Sangbida Chaudhuri · 555143be · Oct 29, 2026 · 1 fileMessage 73 · AdequateModerate 51Details
Commit message · Sangbida Chaudhuri

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

After an RBF the channel has more than one candidate funding tx. After
a mutual close we watch the ones we didn't close on, in case they
confirm. To build that watch we need the peer's funding key, and we
were reading it from a field that only splices fill in. For RBF it is
NULL, and we crashed on it:

lightningd: FATAL SIGNAL 6
bitcoin/pubkey.c:88 (pubkey_cmp)
bitcoin/script.c:155 (bitcoin_redeem_2of2)
lightningd/peer_control.c:530 (drop_to_chain)
lightningd/closing_control.c (peer_closing_complete)

RBF never changes the funding keys, so use the channel's own copy of
the peer's key instead.

Changelog-Fixed: lightningd: fix a crash on cooperative close of an unconfirmed dual-funded channel.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 51/100

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump (RBF). The crash is due to the software looking in the wrong place for a needed public key. The fix makes it use the correct copy of that key.

Lower-priorityconnectd: don't forward oversized gossip messages to gossipdby Sangbida Chaudhuri · 17bedfe6 · Oct 29, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

connectd: don't forward oversized gossip messages to gossipd

gossipd ignores gossip messages far larger than any valid one, but
connectd was still queueing them for gossipd. Apply the same bounds
in connectd, before the message is queued.

Changelog-Fixed: connectd: gossip messages far larger than any valid one are dropped before they are queued for gossipd.
Signed-off-by: Sangbida Chaudhuri <101164840+sangbida@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritygossipd: also compact gossip_store based on its sizeby Sangbida Chaudhuri · 20a71c13 · Oct 29, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

gossipd: also compact gossip_store based on its size

We compact the gossip_store when dead records outnumber live ones
4:1. That only works if records are similar in size, and they are
not: a node_announcement can be 2048 bytes, a channel_update ~140.

So remember the store size after the last compaction (at startup,
file size minus deleted records) and also compact once the store is
5x that. A failed compaction resets the baseline so we don't retry
on every message.

Changelog-Fixed: gossipd: the gossip_store is also compacted based on its size, not just its record count.
Signed-off-by: Sangbida Chaudhuri <101164840+sangbida@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritygossipd: ignore gossip messages far larger than any valid oneby Sangbida Chaudhuri · 57fe2713 · Oct 29, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

gossipd: ignore gossip messages far larger than any valid one

A channel_announcement, channel_update or node_announcement is a
few hundred bytes. Add generous upper bounds (1024, 1024 and 2048
bytes) and ignore anything larger, before we do any work on it.

Changelog-Fixed: gossipd: ignore gossip messages far larger than any valid one.
Signed-off-by: Sangbida Chaudhuri <101164840+sangbida@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context