Core Lightning

lightningd: use scriptpubkey and blockdepth watches instead of tx watches for dual funding.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

CCAN: import version with htable_lock.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

lightningd: use scriptpubkey watch and block depth watch for splicing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

splice: Add easy spliceout command

Adds a RPC command for easily splicing out. Built on top of the splice script framework.

Changelog-Added: New command `spliceout` for easily splicing out of channels

splice: Add test for easy spliceout command

splice: Add docs for easy spliceout command

Add splicein command

splicein is the convience method for splicing in using the splice script system.

Changelog-Added: New command `splicein` allows for convenient splicing funds into a channel

splice: Add documentation for splicein

splice: Add splicein test

Tests the splicein command

splice script: Switch to splice feerate

channeld: Inform channeld about opening feerate

Since channeld handles splicing, it makes sense that it knows the opening feerate now. This is needed for rounding out splice script errors and logging.

splice: Add and improve logging

Add lots of logging to help debug and develop splice related work

splice script: Helper functions for dynamic calcs

Implement some helper functions to make implemetning dynamic wallet and fee amounts easier.

splice: test mutli-channel splice script and fees

Adds tests for multi channel wallet scripts and complex situations involving difficult fee calculations.

gossip: Don’t reset channel on stale annoncement

Splicing can create stale announcements where the original funding output gets spent creating spruious “channel_announcement: no unspent txout” warnings.

This happens particuarlly often with agressive splice tests in CI, so we downgrade this from a warning to a log message.

amount: Add decimal format for msats

In splicing logs we’re often outputting msat values next to sat values, making understanding the logs difficult.

Adding a way to output msats as sats with a decimal makes these logs much easier to read.

splice script: Improve weight guess calculation

splice: multi channel stfu bugfix

When executing splices with many channels at once the `channel_ids` and `results` arrays could be reallocted via `tal_arr_remove` and `tal_arr_expand`.

Since these values are shared across multiple `splice_command` objects, when these functions reallocated the arrays the other `splice_command` would be referencing an invalid pointer.

The solution is to make an explicit shared object `stfu_req_info` that is shared amoung the `splice_command`s and holds pointers to the arrays so they can mutate.

splice script: Zero out wallet fund requests

To prepare for dynamic wallet funding abilities, we pre-process the wallet withdrawls and move them to `needed_funds`. These wallet withdrawl amounts are zero’d out and will have their total withdrawl amount caluclated later on.

splice: Update `tx_abort` for mulitple splices

If the channel has multiple splice candidates pending at once, `tx_abort` needs to know which candidate is being aborted.

splice script: Turn “wallet -> *” into “wallet -> 100%”

Treat the `*` as if it were `100%` for wallets.

100% is a special case that means “100% of needed funds” not “100% of wallet funds.” since taking out all of the wallet’s inputs is wasteful.

amount: Can add sat convenience method

Just a convenient method for checking if a given signed sat value can be subtracted from an msat value.

splice script: Allow `out_ppm` for wallet

To help manage state around dynamic wallets, we allow `out_ppm` to stay on even after its result is calculated.

splice: Fix weight calculations & use opening feerate

Here we update `psbt_input_get_weight` to allow the caller to specify what kind of input size estimation they would like. Before it was just “zero witness bytes” which we now move to the default behavior and add an assumption option for P2WSH -> 2of2 multisig which is what we typically see in splicing.

At the same time we move channeld over to using the opening feerate estimation instead of the less useful “max feerate.” We make splice script use this same feerate.

After auditing the feerates for these two places against each other and the actually created transaction, we implement some fixes making them all match.

While we’re here, we add relevant debug log messages.

channeld: Add new feerate type ‘splice’

This new feerate gives us more careful control of what feerate splices should be at.