EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkActive incident
Repository coverage

2330 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

228security candidates319second-pass queue1977AI analyses
99commits · 30 days
229commits · 60 days
709commits · 180 days
1578commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
628Strong · 80–100
1399Adequate · 60–79
272Thin · 40–59
31Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
cdecker331217581
daywalker9019315113471
Níckolas Goline961252376
Amperstrand322278
Rusty Russell96977961173
Sangbida Chaudhuri18537157167
Vincenzo Palazzo19714185
Lagrang3115679170
dovgopoly18016165
Dusty Daemon821378066
ShahanaFarooqui931093063
Peter Neuroth1469110074
Analysis record

Published AI watches

Last scanned 43 minutes ago

Informational 15 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: bring lightning-downgrade's version list up to v26.12.

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

2e7a9f5aby Ken Sedgwick+9−12 files
No security note in commit
Informational 23 AI analysisMessage 66 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Makefile: install lightning-downgrade.

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…

06ea9ba0by Ken Sedgwick+1−01 file
No security note in commit
Low 27 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: create bwatch tables before backfilling them

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…

Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
ce2a6836by daywalker90+105−02 files
No security note in commit
Informational 15 AI analysisMessage 5 · Opaque
EP Elements ProjectCore Lightning BitcoinLightning Network

v26.12rc1

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…

4002c4e9by Níckolas Goline+164−1110 files
No security note in commit
Low 30 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: store payment failure details per groupid

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…

Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
24082c6dby daywalker90+6−34 files
No security note in commit
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-plugin: do not panic when the log writer task is gone

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…

panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
8661ffabby cdecker+29−11 file
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

docs: explain hsmtool HTLC recovery

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…

f90c140dby Sangbida Chaudhuri+85−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: make test_delpay_works deterministic

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

a224ca81by daywalker90+16−161 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: say that listtransactions gives blockheight 0 for a tx not in a block

This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…

bc281be3by Peter Neuroth+4−42 files
No security note in commit
Informational 20 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…

No security-relevant signals presentFix is a routine correctness/robustness improvement
02612ed5by Amartya Singh+4−31 file
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

wallet: reject unmodifiable PSBTs in addpsbtoutput/addpsbtinput

This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…

Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
42472816by daywalker90+14−12 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: show addpsbtoutput/addpsbtinput crash on an unmodifiable v2 PSBT

This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …

Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
42e268abby daywalker90+60−01 file
No security note in commit
Informational 20 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pyln-client: don't crash Millisatoshi.to_approx_str() on zero

This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …

5ebe365dby Amartya Singh+3−12 files
No security note in commit
Moderate 59 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

dualopen and splicing: add minimal verification of tx_signatures

This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…

Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
c6be4f71by Lagrang3+633−97 files
Vendor flagged security relevance
Moderate 54 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: abort_channels no longer fails a channel with a signed splice

This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…

Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
c87f5573by Andezion+22−11 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: fix crash on mutual close of an unconfirmed dual-funded channel

This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …

NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
555143beby Sangbida Chaudhuri+9−31 file
Vendor flagged security relevance
High 74 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

cln-grpc: reject malformed request values instead of panicking

This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…

Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
b2703436by daywalker90+1558−12135 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 51 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

nix: drop protobuf again

This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…

a0459eeeby Peter Neuroth+0−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

make: check gRPC protos for breaking changes against the last release

This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…

db5fea70by daywalker90+43−84 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatedoc: bring lightning-downgrade's version list up to v26.12.by Ken Sedgwick · 2e7a9f5a · Nov 18, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Ken Sedgwick

doc: bring lightning-downgrade's version list up to v26.12.

The VERSIONS section of lightning-downgrade(8) ended at v25.12. Add
v26.04, v26.06 and v26.12. Each goes back one release. The v26.12
tool also removes askrene impressions from the stored layers, because
v26.06 cannot read them.

The upgrade guide said that downgrades are not generally possible and
did not mention the tool. Name it there.

Changelog-None

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
update trustdocumentation-only discount
AI analysis · Informational 15/100

This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.

Security candidateMakefile: install lightning-downgrade.by Ken Sedgwick · 06ea9ba0 · Nov 18, 2026 · 1 fileMessage 66 · AdequateInformational 23Details
Commit message · Ken Sedgwick

Makefile: install lightning-downgrade.

lightning-downgrade is built with the other tools but is not in
BIN_PROGRAMS, so "make install" does not copy it to bindir. The
release archives are made from that install, so they have the manual
page and not the program: a node upgraded from the release binaries
cannot go back without building the tool from source.

Add it to BIN_PROGRAMS, next to lightning-hsmtool. Install and
uninstall both work from that list.

Changelog-Fixed: Tools: `lightning-downgrade` is now installed by `make install` and included in the release archives.
Fixes: #9746

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
update trust
AI analysis · Informational 23/100

This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contained the tool's manual page but not the tool itself, meaning users who installed from a release binary could not easily downgrade their node without compiling the tool from source. The patch adds the missing program to the install list so it ships with releases. There is no exploit or code flaw in the software's runtime behavior.

AI review queuedwallet: create bwatch tables before backfilling themby daywalker90 · ce2a6836 · Nov 17, 2026 · 2 filesMessage 83 · StrongLow 27Details
Commit message · daywalker90

wallet: create bwatch tables before backfilling them

Databases from v26.06.10 are at migration version 284 and never ran the
our_outputs/our_txs CREATE TABLE migrations, which master placed at
indices 283/284. On upgrade, migrate_backfill_bwatch_tables (index 285)
then inserts into our_outputs and fails with "no such table".

Create both tables with IF NOT EXISTS at the start of the backfill, so it
works whether or not the earlier CREATEs ran. Existing databases already
have the tables, so this is a no-op for them.

Add a unit test that starts from a v26.06.10-shaped database without the
bwatch tables.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a follow-up migration tried to insert data into those non-existent tables and crashed. The fix simply creates the tables if they don't already exist right before filling them, and adds a test that simulates the problematic v26.06.10 database state. It is a reliability/data-integrity fix, not an exploitable security vulnerability.

Lower-prioritywally: update libwally to v1.6.1by Sangbida Chaudhuri · e718d6d9 · Nov 17, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

wally: update libwally to v1.6.1

Changelog-Changed: Update libwally to v1.6.1
Co-authored-by: Cursor <cursoragent@cursor.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedv26.12rc1by Níckolas Goline · 4002c4e9 · Nov 16, 2026 · 10 filesMessage 5 · OpaqueInformational 15Details
Commit message · Níckolas Goline

v26.12rc1

Changelog-None

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

5/100 · OpaqueMessage clarity
✓ Provides an explanatory body! Very short subject! Too few words to establish purpose
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-sensitive behavior in this specific commit.

Lower-prioritytests: accept any spacing in InvalidChainFound log regexby daywalker90 · aebb3aa5 · Nov 16, 2026 · 3 filesMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: accept any spacing in InvalidChainFound log regex

Bitcoin Core commit 736b17c0f0f2 ("log: fix minor formatting in debug
logs") changed the InvalidChainFound line from "invalid block=%s height=%d"
to "invalid block=%s height=%d". The tests waited for the old two-space
form, so reorg tests timed out on bitcoind 32.1.

Match one or more spaces so both the old and new formats work.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI review queuedwallet: store payment failure details per groupidby daywalker90 · 24082c6d · Nov 12, 2026 · 4 filesMessage 68 · AdequateLow 30Details
Commit message · daywalker90

wallet: store payment failure details per groupid

wallet_payment_set_failinfo() matched rows on payment_hash and partid
only, a leftover from before groupid became part of the payments key.
Every failed retry in a new group therefore overwrote the failure
details of all earlier failed groups with the same partid, so
waitsendpay (and erroronion in listsendpays/listpays) for an earlier
group reported the latest group's error.

Match on groupid too, like wallet_payment_set_status() and
wallet_payment_get_failinfo() already do.

Changelog-Fixed: JSON-RPC: `waitsendpay` for an earlier `groupid` now reports that attempt's failure, not the failure of a later retry.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100

This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an additional 'groupid' field, so each retry group's error is stored separately. It is a correctness bug, not a security vulnerability: no funds are at risk and no attacker can exploit it.

Lower-prioritytests: failed retry overwrites failure details of earlier groupsby daywalker90 · fa0f398b · Nov 12, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: failed retry overwrites failure details of earlier groups

wallet_payment_set_failinfo() matches on payment_hash and partid but
not groupid, so when a retry in a new group fails, its failure details
overwrite those of every earlier failed group with the same partid.
A waitsendpay for the earlier group then reports the newer error.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylsps-plugin: connect the client to lightningd through State::rpc()by Peter Neuroth · 89cb15ca · Nov 12, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Peter Neuroth

lsps-plugin: connect the client to lightningd through State::rpc()

Every handler of the LSPS client rebuilt the RPC path from the plugin's
configuration and connected to it, eight copies of the same three
lines. Keep the RPC path in the client's State, which already gets it
at startup, and connect through State::rpc().

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedcln-plugin: do not panic when the log writer task is goneby cdecker · 8661ffab · Nov 12, 2026 · 1 fileMessage 83 · StrongLow 43Details
Commit message · cdecker

cln-plugin: do not panic when the log writer task is gone

LoggingLayer::on_event forwarded events to the log writer task with
sender.send(...).unwrap(). Once that task is gone -- the runtime is
shutting down, or the task was dropped or panicked -- the receiver
has been dropped, send returns Err(SendError(entry)) and the unwrap
panics in whichever code emitted the log event. This usually showed
up during node shutdown, after "Lost connection to the RPC socket."

Take the entry back out of the SendError and write it to stderr
instead: logging must never panic, and we must not drop the entry
either. stderr and not stdout, since stdout is the JSON-RPC channel
to lightningd.

Add a unit test that drives the LoggingLayer with a dropped receiver
via a local subscriber; it panics without the fallback.

Changelog-Fixed: cln-plugin: a plugin no longer panics when it logs after its log writer task has exited (e.g., during shutdown); the message is written to stderr instead.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 43/100

This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin print the message to stderr instead of crashing. It is a reliability fix rather than an active remote exploit.

Lower-prioritytests: check the sat amount that reaches the destinationby daywalker90 · 03d74459 · Nov 12, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: check the sat amount that reaches the destination

Withdraw and FundChannel accept the sat amount in the deprecated msat
field and in the sat field. Assert on the decoded transaction outputs and
the wallet and channel state, so a sat/msat mix-up (a 1000x error) would
fail the test rather than pass on the RPC reply.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritytests: cover the deprecated sat fields in gRPC requestsby daywalker90 · 993304ab · Nov 12, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

tests: cover the deprecated sat fields in gRPC requests

The deprecated msat fields (Withdraw.satoshi, FundChannel.amount and
reserve) still have to accept whole-sat amounts, reject amounts with a
msat remainder, and refuse a request that also sets the sat field that
replaces them.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritylightningd: report the final state in sendpay_failure and waitsendpayby daywalker90 · 71076cb7 · Nov 12, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · daywalker90

lightningd: report the final state in sendpay_failure and waitsendpay

payment_failed() loads the payment, marks it failed in the database,
then passes the copy it loaded beforehand to the waiters and the
sendpay_failure notification. So they saw "status": "pending" and no
completed_at or updated_index, unlike a later waitsendpay or listsendpays.

Reload the payment after updating it, as payment_succeeded() does; the
self-payment failure path had the same problem.

This also fixes the test_sendpay_notifications flake, where the
notification was compared against a waitsendpay that read the database.

Rusty proposed setting payment->status locally in 2024, but that never
landed and would still leave completed_at and updated_index out.

Fixes: https://github.com/ElementsProject/lightning/issues/7561
Changelog-Fixed: Plugins: `sendpay_failure` notifications and `waitsendpay` errors now report `status` `failed` (with `completed_at` and `updated_index`), not `pending`.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Lower-prioritytests: sendpay_failure and waitsendpay report a stale pending statusby daywalker90 · bc2f23b9 · Nov 12, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · daywalker90

tests: sendpay_failure and waitsendpay report a stale pending status

When an HTLC fails, payment_failed() reads the payment before marking
it failed, then hands that stale copy to the sendpay_failure notification
and to any waitsendpay already waiting. Both report "status": "pending"
without completed_at or updated_index, while a waitsendpay issued
afterwards reads the database and says "failed".

This is the cause of the test_sendpay_notifications flake: whether its
waitsendpay lands before or after the failure decides which version it
gets, and the notification never matches the fresh one.

Reported-in: https://github.com/ElementsProject/lightning/issues/7561

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Lower-prioritytests: exercise hsmtool HTLC recoveryby Sangbida Chaudhuri · 059b5df2 · Nov 11, 2026 · 1 fileMessage 78 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

tests: exercise hsmtool HTLC recovery

Reproduce stale channel state with pending HTLCs and prove recoverhtlc signs broadcastable anchor and non-anchor spends. Cover identical MPP outputs, same-hash opposite directions, strict JSON validation, and skipped unmatched claims.

Co-authored-by: Cursor <cursoragent@cursor.com>

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI review queueddocs: explain hsmtool HTLC recoveryby Sangbida Chaudhuri · f90c140d · Nov 11, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · Sangbida Chaudhuri

docs: explain hsmtool HTLC recovery

Document the recovery bundle, where each input comes from, the point-only peer workflow, transaction timing, and operator verification steps.

Co-authored-by: Cursor <cursoragent@cursor.com>

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationdocumentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no new behavior, and no security fix or vulnerability introduced.

Lower-prioritytests: make test_htlc_rexmit_while_closing deterministicby daywalker90 · dc040294 · Nov 11, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · daywalker90

tests: make test_htlc_rexmit_while_closing deterministic

The test failed in CI on every rerun with:

assert only_one(l1.rpc.listpeerchannels()['channels'])['state'] == 'CHANNELD_SHUTTING_DOWN'
AssertionError: assert 'CLOSINGD_SIGEXCHANGE' == 'CHANNELD_SHUTTING_DOWN'

It used xWIRE_SHUTDOWN on l1 to stop l1 reading l2's revoke_and_ack.
Since dev_disconnect moved into connectd, that only takes effect in
the write path: incoming messages are forwarded to channeld
independently, so l2's revoke_and_ack often reached l1's channeld
anyway and l1 moved to closingd too.

Instead have l2 drop its own outgoing revoke_and_ack, which does not
race: l1 waits for it, a reconnect gets l2 into closingd while the
retransmitted revoke_and_ack is dropped again, and the final reconnect
requires l2 to retransmit it from closingd.

Changelog-None

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityxpay: disable intermediate nodes that give final errorsby Lagrang3 · 1271f9b6 · Nov 11, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · Lagrang3

xpay: disable intermediate nodes that give final errors

Changelog-Fixed: xpay: instantly disable nodes that return plain wrong or impossible to recover error codes, eg. incorrect_or_unknown_payment_details from an intermediate node or permanent_node_failure, the disable operation applies to the current payment session and in addition a negative bias is applied to this node for all subsequent payments.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityxpay: add helpers to bias nodes and channelsby Lagrang3 · cb7075b1 · Nov 11, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Lagrang3

xpay: add helpers to bias nodes and channels

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedtests: make test_delpay_works deterministicby daywalker90 · a224ca81 · Nov 11, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · daywalker90

tests: make test_delpay_works deterministic

The test relied on force-disconnecting l2 from l3 to make the cheap
route fail. Whether that failure happened depended on timing: the
disable channel_update for l2<->l3 could reach l1 before it computed
the route, in which case l1 never tried the cheap route and only one
payment was recorded. This was seen as a CI flake.

Instead, run l2 with the fail_htlcs plugin so it rejects the forward
on purpose. The first attempt always fails and the retry via l4
always succeeds.

Also rename the variable that holds the successful payment from
`failed` to `success`.

Changelog-None

Signed-off-by: daywalker90 <daywalker990@gmx.de>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

Lower-priorityhsmtool: explain HTLC recovery transactionsby Sangbida Chaudhuri · 907de9f7 · Nov 11, 2026 · 1 fileMessage 78 · AdequateTriage 8Details
Commit message · Sangbida Chaudhuri

hsmtool: explain HTLC recovery transactions

Show the recovered inputs, output amount, fee, transaction ID, and verification and broadcast instructions.

Co-authored-by: Cursor <cursoragent@cursor.com>

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validation
Lower-priorityhsmtool: add recoverhtlc commandby Sangbida Chaudhuri · f8aaa1c6 · Nov 11, 2026 · 3 filesMessage 58 · ThinTriage 8Details
Commit message · Sangbida Chaudhuri

hsmtool: add recoverhtlc command

Read a recovery bundle, validate its external inputs, and print signed transactions for each matching HTLC claim.

Changelog-Added: tools: lightning-hsmtool can recover HTLC outputs after channel state loss.

Co-authored-by: Cursor <cursoragent@cursor.com>

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
defensive validation
Lower-priorityhsmtool: parse HTLC recovery bundlesby Sangbida Chaudhuri · 09c22d7f · Nov 11, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

hsmtool: parse HTLC recovery bundles

Read versioned recovery data from JSON so the command line only needs operational inputs such as the destination and fee rate.

Co-authored-by: Cursor <cursoragent@cursor.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityhsmtool: calculate HTLC recovery feesby Sangbida Chaudhuri · 0ca469a0 · Nov 11, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri

hsmtool: calculate HTLC recovery fees

Sum the matched HTLC outputs and calculate the fee and destination amount from the estimated signed transaction weight.

Co-authored-by: Cursor <cursoragent@cursor.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritypyln-testing: never reserve the cln-grpc default portby daywalker90 · 0598ccb9 · Nov 10, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · daywalker90

pyln-testing: never reserve the cln-grpc default port

test_grpc_default_port_auto_starts starts a node on the hardcoded
cln-grpc default port 9736 without reserving it. reserve_unused_port()
could hand out 9736 to another test in the same run, so the node
failed with "Address already in use".

Add a _PORT_BLACKLIST set that reserve_unused_port() skips. It holds
9736 for now and can take more ports later.

Changelog-None

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification