BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 41 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding optionsby merge-script · 0fe899d0 · Nov 5, 2026 · 7 filesMessage 91 · StrongLow 33Details
Commit message · merge-script

Merge bitcoin/bitcoin#36489: wallet: rpc: Add snake_case aliases for wallet funding options

faeb073ca68348bc663c80b3f2b70d7014466b07 test: Use new named arg aliases in tests (MarcoFalke)
fac8ef10f4c618136dd318f642fd7ccb4587d509 wallet: rpc: Add snake_case aliases for wallet funding options (MarcoFalke)

Pull request description:

The options for wallet funding RPCs have several issues:

* snake_case aliases are accepted by the server, but unsupported by bitcoin-cli, not mentioned in the docs and rejected by the schema.
* If both the snake_case and camelCase are provided, the camelCase is silently ignored.
* The server silently ignores `subtract_fee_from_outputs`. (reported by stutxo in https://github.com/bitcoin/bitcoin/pull/35317)

Fix all issues, by:

* Adding the snake_case aliases to the CLI, docs and the schema.
* Rejecting if both are supplied.
* Reading `subtract_fee_from_outputs` instead of silently ignoring it.

ACKs for top commit:
Conradgabe:
tACK faeb073ca68348bc663c80b3f2b70d7014466b07
sedited:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07
willcl-ark:
ACK faeb073ca68348bc663c80b3f2b70d7014466b07

Tree-SHA512: d434c98d9a2aacf3d547d727f7d31a052beea7079f6ca32ed08877523f28231ae0bc7f1ff9a909856b7b14f7e89560058ec723918277d259b2810bcb90982804

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100

This update fixes a quirk in Bitcoin Core's wallet commands where some option names using underscores (like subtract_fee_from_outputs) were accepted by the server but not properly handled by the command-line tool or documentation. More importantly, the server was silently ignoring subtract_fee_from_outputs, meaning a user who thought they had told the wallet to deduct the transaction fee from a recipient's payment would actually end up paying the fee themselves. The patch also now rejects supplying both the old camelCase name and the new snake_case name at the same time, preventing confusion. It is a bug fix with a mild financial-impact risk rather than a direct theft or remote-code-execution vulnerability.

AI review queuedMerge bitcoin/bitcoin#35492: wallet: fail dump on incomplete writesby merge-script · 2e06f371 · Nov 4, 2026 · 2 filesMessage 81 · StrongLow 43Details
Commit message · merge-script

Merge bitcoin/bitcoin#35492: wallet: fail dump on incomplete writes

385a001f66ad23b3963d5c0acf960b94359c4e21 wallet: commit dump output before success (Velarde)
bb2a207d08782b93f77c003287d9b6bf4ea17fa1 wallet: fail dump on incomplete writes (Velarde)

Pull request description:

This makes `bitcoin-wallet dump` fail if writing the dump file does not complete successfully.

Previously, `DumpWallet()` only checked whether the dump file could be opened. If later writes or close failed, the tool could still return success and print the private-key warning, leaving a truncated dump file behind.

The change adds write/close checks while dumping wallet records. If writing fails, the partial dump file is removed and `bitcoin-wallet` returns an error.

ACKs for top commit:
maflcko:
review with --function-context --ignore-all-space ACK 385a001f66ad23b3963d5c0acf960b94359c4e21 🍵
pablomartin4btc:
ACK 385a001f66ad23b3963d5c0acf960b94359c4e21

Tree-SHA512: 89c8901ac8f22057ed970427418b339c59313511c40860e2d48f88d49758dc6d300d5861d4d9a54e0b30b2f2070f4adce5544d2e847870ae23a68a738251e654

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 43/100

This change fixes a bug in the `bitcoin-wallet dump` command. Previously, if writing the dump file failed partway through (for example, because the disk was full), the tool could still report success and leave behind an incomplete, misleading file. Now the tool checks every write and close operation, reports failure, and deletes the partial file. This is a reliability and data-integrity improvement rather than a remote attack vector.

AI review queuedMerge bitcoin/bitcoin#31507: build: Use clang-cl to build on Windows nativelyby merge-script · cfe5ccea · Nov 4, 2026 · 20 filesMessage 91 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#31507: build: Use clang-cl to build on Windows natively

331902f1dda63b5b8e5e9296f9871c358bf5d2b3 doc: Rename `build-windows-msvc.md` to `build-windows-native.md` (Hennadii Stepanov)
fe2ffef6bc786e515b9fc99a4bf10792b45c6a91 doc: Add clang-cl release notes (Hennadii Stepanov)
4f1e6de6c44790c3abbaf83dfe09947610520e1e cmake: Drop support for the MSVC compiler (cl.exe) (Hennadii Stepanov)
720f381a264f8a136689bd50b29a78482e3b19f7 Couple `BSWAP_CONSTEXPR` definition to bswap implementation (Hennadii Stepanov)
4d7e07035dfd82730b8b1dcb17bee059e6102800 cmake: Adjust diagnostic flags for clang-cl (Hennadii Stepanov)
c4111989e47654db4325fbf3935228bd9385b392 cmake: Link to clang-cl builtins library on Windows (Hennadii Stepanov)
d2645f7ed486718d2af39cf5fc50f46bb8503be9 cmake: Always link `bitcoinqt` to `shlwapi` when building on Windows (Hennadii Stepanov)

Pull request description:

Building on Windows using Clang instead of the MS compiler may be beneficial, considering the issues with the latter, as outlined in https://github.com/bitcoin/bitcoin/issues/31456:

> * non-optimized codegen: [build: remove need to test for endianness #29852 (comment)](https://github.com/bitcoin/bitcoin/pull/29852#issuecomment-2049803970)
>
> * compile failure: [MSVC 17.12.0 internal compiler error #31303](https://github.com/bitcoin/bitcoin/issues/31303)
>
> * ~legal, but brittle stdlib: [util: Drop boost posix_time in ParseISO8601DateTime #31391 (comment)](https://github.com/bitcoin/bitcoin/pull/31391#issuecomment-2510762011)~
>
> * unspecified issue: [refactor: Check translatable format strings at compile-time #31061 (comment)](https://github.com/bitcoin/bitcoin/pull/31061#issuecomment-2531244463)

Additionally, MSVC does not [support](https://learn.microsoft.com/en-us/cpp/assembler/inline/inline-assembler) inline assembly on the ARM and x64 processors.

So this PR:
1. Closes https://github.com/bitcoin/bitcoin/issues/31456 (and addresses https://github.com/bitcoin/bitcoin/issues/14118).
2. Could be an alternative to https://github.com/bitcoin/bitcoin/pull/24773.
3. Closes https://github.com/bitcoin/bitcoin/issues/36153.
---

Additionally, clang-cl:
1. Produces binaries with [better](https://github.com/bitcoin-core/secp256k1/pull/1681) performance. For example:

| MSVC, block/s | clang-cl, block/s | benchmark |
|--------------:|------------------:|:----------|
| 7.40 | 11.52 | `ConnectBlockAllEcdsa`
| 7.32 | 11.81 | `ConnectBlockAllSchnorr`
| 7.38 | 11.45 | `ConnectBlockMixedEcdsaSchnorr`
| 91.86 | 143.12 | `DeserializeAndCheckBlockTest`
| 121.46 | 189.04 | `DeserializeBlockTest`

2. Builds faster on the CI:
- [MSVC](https://github.com/bitcoin/bitcoin/actions/runs/13792522864/job/38575846787) - 20m 35s
- [clang-cl](https://github.com/bitcoin/bitcoin/actions/runs/13792522864/job/38575849680) - 12m 43s

ACKs for top commit:
maflcko:
review ACK 331902f1dda63b5b8e5e9296f9871c358bf5d2b3 😈
hodlinator:
re-ACK 331902f1dda63b5b8e5e9296f9871c358bf5d2b3

Tree-SHA512: f6bad9c98db19952424f7a8789cea74bc5e5e56fe85de151da8c77295d312f98081d88e4e2709603288721a622ccbdc99de0b19044cc955dd5008c9b75943b3d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: unusually broad change
AI analysis · Informational 18/100

This commit changes Bitcoin Core's Windows build system to use the Clang compiler (clang-cl) instead of Microsoft's own C++ compiler (MSVC/cl.exe). It is a build-toolchain change, not a fix for a security vulnerability in running code. The pull request mentions that MSVC had bugs and missing features, but those are described as development/maintenance problems, not as remotely exploitable flaws. There is no indication this patch fixes an active security issue.

AI review queuedMerge bitcoin/bitcoin#36748: test: Small test sync fixupsby merge-script · 3b5ba5d3 · Nov 4, 2026 · 3 filesMessage 96 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36748: test: Small test sync fixups

fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa test: Use send_self_transfer_chain (MarcoFalke)
fa2986921cd53146fb8a1fc9585714a064a137d9 test: Use generateblock with submit=False over manual create_block from tmpl (MarcoFalke)
facf4a0ea98ef52f505e4f72eab1b6183df3832f test: Remove redundant sync_blocks (MarcoFalke)

Pull request description:

Just a few random sync style-only test-only fixups. See the commit msgs for the rationales.

ACKs for top commit:
musaHaruna:
ACK [fa6f1c0](https://github.com/bitcoin/bitcoin/pull/36748/changes/fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa)
sedited:
ACK fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa

Tree-SHA512: 3f411f8221f7804ca4f2e17963e165560b7fee7e9576e1a1d849e5a9c527a3de272b7b739bd9ba958adfcb487b3b1a43ce5c399b5c2f5234f4760dc201123fa5

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal test scripts. It simplifies how tests create transactions and blocks, and removes a couple of unnecessary synchronization steps. There is no change to the actual Bitcoin node software that users run, so it cannot affect live networks, wallets, or funds.

AI review queuedMerge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSizeby merge-script · ed3d34ba · Nov 3, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSize

3e2cf63da5090d59218c66dcc9a54c0f8c67e648 policy: remove unused GetVirtualTransactionInputSize (fanquake)

Pull request description:

The last non-test caller was removed in 9b7ec393b8 (#26567). Since then it has only been used by the `tx_in` fuzz target and a helper in `wallet_tests`.

ACKs for top commit:
jpk68:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
l0rinc:
lightly tested code review ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
ismaelsadeeq:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
sedited:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648

Tree-SHA512: 5d59717d0e6cc900817854c35275f9009a07fc45bbaa3fda7c73e726c6f12108a789e2d35723df5b96c68865aec55a57dba95bdc6d940faf442bcb78570202b9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes an unused helper function called GetVirtualTransactionInputSize and updates the few remaining callers to use an equivalent calculation directly. It is a routine code cleanup with no security relevance.

AI review queuedMerge bitcoin/bitcoin#36618: test: Wait for index sync in all testsby merge-script · e310efb2 · Nov 2, 2026 · 18 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36618: test: Wait for index sync in all tests

fa74dc72d942e1628cea3c143bb56eed1457bbce test: refactor: Wait for index sync by default (MarcoFalke)
fa8009ba2997a0eb3e6e1a657db507e5a8b8b529 test: Wait for index sync in wallet_fast_rescan.py (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/36564 by adding the missing wait on the index sync.

Diff to reproduce:

```diff
diff --git a/src/util/thread.cpp b/src/util/thread.cpp
index 5b20e807b4..2e988c9eea 100644
--- a/src/util/thread.cpp
+++ b/src/util/thread.cpp
@@ -8,2 +8,3 @@
#include <util/log.h>
+#include <util/time.h>
#include <util/threadnames.h>
@@ -17,2 +18,3 @@ void util::TraceThread(std::string_view thread_name, std::function<void()> threa
util::ThreadRename(std::string{thread_name});
+ UninterruptibleSleep(999ms);
try {
```

Command to reproduce (run twice to create the cache the first time, and reproduce on the second):

```
./bld-cmake/test/functional/wallet_fast_rescan.py | grep WARNING
```

On failure, the log will say something like:

```
- 2026-10-18T05:06:44.451973Z [http.01] [wallet/scan.cpp:142] [ShouldFetchBlock] [scan] Fast rescan: inspect block 200 [4c063a93914ec0cb1604297f2f601dab9b9342bf073e6b80e1c11efd71714e2e] (WARNING: block filter not found!)

ACKs for top commit:
ViniciusCestarii:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce
hebasto:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce, the changes are correct.

Tree-SHA512: 750ca9c666f0195fd7781800abf43aea9465af722230ed01e12c3fbd98d795be985a558d061d73446d9ffddd10fa67172d1f1bbc9b9cac87a2899682ff95418b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal functional test framework. It makes the test harness automatically wait for optional indexes (like transaction index, block filter index, and coin stats index) to finish syncing before continuing tests. It does not change the production Bitcoin node software that users run, so it cannot directly affect real wallets, funds, or network security.

AI review queuedMerge bitcoin/bitcoin#36011: btcsignals: destroy callbacks on disconnectby merge-script · 862f6038 · Oct 31, 2026 · 2 filesMessage 100 · StrongLow 29Details
Commit message · merge-script

Merge bitcoin/bitcoin#36011: btcsignals: destroy callbacks on disconnect

a318b23131e6df2c64e8fe79cebc8e5babdf8b7f btcsignals: fall back to atomic_load/store without __cpp_lib_atomic_shared_ptr (Ryan Ofsky)
f1d786c1ef5d813f61e405370a67df4cc6323885 btcsignals: destroy callbacks eagerly on disconnect (Ryan Ofsky)
7c5571adc46857cfcf77d81b6fc135dee5369749 test: characterize btcsignals callback destruction timing (Ryan Ofsky)

Pull request description:

Currently callback functions connected to signals do not get freed when their `connection::disconnect` method is called or when their associated `scoped_connection` is destroyed. They live as long as the signal does, even if they will never be called, and can only get [garbage collected](https://github.com/bitcoin/bitcoin/blob/0fd515bbb7070a502dd2fe6d16f5f3cbac591283/src/util/btcsignals.h#L240-L241) if new connections are added.

This behavior is different that previous boost signals behavior and causes a [deadlock](https://github.com/bitcoin/bitcoin/actions/runs/31848571315/job/94919834743) on GUI shutdown in #10102 because when the node registers signal callbacks (`handleInitMessage`, etc) that get forwarded to the GUI, the callbacks own `mp::EventLoopRef` references, and if the callbacks aren't freed, the node process can't shut down.

This change restores boost signals behavior freeing callbacks when they are disconnected or when `scoped_connection` objects are destroyed to avoid this problem and make callback lifetimes more predictable.

ACKs for top commit:
hodlinator:
re-ACK a318b23131e6df2c64e8fe79cebc8e5babdf8b7f
sedited:
Re-ACK a318b23131e6df2c64e8fe79cebc8e5babdf8b7f

Tree-SHA512: 41be63f7adbb1d1556698624a1aaaf62b4c574a29c3f3a8f35505b3c70fda472b6c8d6009a7f13eabe5670657197d7c471720cbf0eb9474d76cf9e2b5852ce44

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 29/100

This change fixes a bug in Bitcoin Core's internal signal/callback system where callback functions and the resources they own were not released when disconnected. Previously, disconnected callbacks lingered until the signal itself was destroyed or new connections triggered garbage collection. This caused a real-world deadlock during GUI shutdown because node-to-GUI callbacks held references that prevented the node process from exiting. The patch makes callbacks get destroyed immediately on disconnect (or after any in-flight call finishes), matching the behavior of the older Boost signals library.

AI review queuedMerge bitcoin/bitcoin#36611: test: consolidate mempool constantsby Ryan Ofsky · ab7e668c · Oct 31, 2026 · 10 filesMessage 91 · StrongInformational 15Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36611: test: consolidate mempool constants

d8cca0c110b264be0cca69fb4c55ebee0e8152a7 test: use MAX_FUTURE_BLOCK_TIME from blocktools (fanquake)
9ee579b6cba087f2cdd74968b8098806e7510092 test: move DEFAULT_ANCESTOR_LIMIT to mempool_util (fanquake)
8f4caec89590b5bd8804c8f9e01d547f9e51533a test: consolidate DEFAULT_CLUSTER_LIMIT to mempool_util (fanquake)
75a611998e35508b5f90e94f8a77ab6d266e84ab test: add MAX_REPLACEMENT_CANDIDATES to mempool_util (fanquake)
aa7d0a5b582f92cc5be9544be7a0f395646e53c3 test: use TRUC constants from mempool_util (fanquake)

Pull request description:

Consolidate usage of mempool constants in the functional tests.
As well as one instance of `MAX_FUTURE_BLOCK_TIME`.

ACKs for top commit:
stickies-v:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7
mercie-ux:
re-ACK https://github.com/bitcoin/bitcoin/commit/d8cca0c110b264be0cca69fb4c55ebee0e8152a7
hodlinator:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7

Tree-SHA512: 8399f61e3fcc375863842a6ebae23ef48d38e7a6fc264888b671cc57401277c66f7f31a4aa414619b64e8bafceeb4dd2e3d9585113b221d0a3fe8c44589f8ce9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a test-only cleanup. It moves several hard-coded numbers used in Bitcoin Core's functional tests into a shared helper file so they are defined in one place. No production code, consensus rules, or network behavior were changed.

AI review queuedMerge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details windowby Hennadii Stepanov · 43a33e51 · Oct 30, 2026 · 2 filesMessage 91 · StrongInformational 19Details
Commit message · Hennadii Stepanov

Merge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details window

fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962 Remove legacy BIP70 merchant name from tx details window (MarcoFalke)

Pull request description:

BIP70 is now dead for roughly half a decade. There is no need to print the merchant name in the tx details window, so remove that feature.

The parser has no tests, nor fuzzing, so removing it will likely also fix some parsing issues with corrupt data.

ACKs for top commit:
l0rinc:
lightweight code review ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962
fanquake:
ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962

Tree-SHA512: 082f8ae958f616f5b344c0da4800ceaafb7bbcf44180eb3f0915b9d4cfb3834e39e943186e383026b90ad3245ce4f61d529c568e2477be6f5b28e7fd9b6a55fe

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes an old feature in the Bitcoin Core wallet's transaction details window that displayed a merchant name for BIP70 payment requests. BIP70 is an outdated payment protocol that is no longer used. The removed code parsed certificate data in a simple, untested way. The change is described as a cleanup, but it also eliminates a small bit of code that handled untrusted data without proper validation.

AI review queueddoc: use doxygen comments for blocks containing @paramby fanquake · 0e9ac2cb · Oct 30, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · fanquake

doc: use doxygen comments for blocks containing @param

Plain /* comments are ignored by Doxygen and by clang's -Wdocumentation,
so mistakes in them go unnoticed. Also wrap the CoinGrinder ASCII trees
in @verbatim so Doxygen keeps their layout.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes code comments. It converts plain block comments into Doxygen-style documentation comments (starting with /** instead of /*) so that developer documentation tools can read them. It also wraps ASCII art diagrams in special tags so they keep their formatting. There are no changes to actual program behavior, and no security impact.

AI review queueddoc: fix incorrect @param annotationsby fanquake · 68e8429b · Oct 30, 2026 · 7 filesMessage 45 · ThinInformational 15Details
Commit message · fanquake

doc: fix incorrect @param annotations

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation comments that describe whether function parameters are inputs, outputs, or both. No actual code logic was changed, so it cannot affect program behavior or introduce a security vulnerability.

AI review queuedMerge bitcoin/bitcoin#36071: refactor: fuzz: remove cost_of_change from coin-grinder fuzz targetby merge-script · d1fb1ba3 · Oct 30, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36071: refactor: fuzz: remove cost_of_change from coin-grinder fuzz target

5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc refactor: fuzz: remove cost_of_change from coin-grinder fuzz target (yancy)

Pull request description:

coin-grinder selection algorithm does not take cost_of_change as a parameter.

> CoinGrinder doesn’t use coin_params.m_cost_of_change and the comparison of selection results from CoinGrinder, SRD, and Knapsack does not need it either as only the weight of the selections is relevant. So, [line 96](https://github.com/bitcoin/bitcoin/blob/2990bd773551c835ab0b6b59d85730adab2fd428/src/wallet/test/fuzz/coinselection.cpp#L96) in that fuzz test is both incorrect and dead code. It should be removed.

cite: [stackexchange](https://bitcoin.stackexchange.com/questions/130861/difference-between-long-term-fee-rate-and-discard-fee-rate)

verified `coin_grinder` fuzz target still works after removal

ACKs for top commit:
brunoerg:
ACK 5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc
frankomosh:
ACK 5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc

Tree-SHA512: 46c4d5e22e342fdac918e52348b346a18b41478b0a8859675ee38819b45c57cc8a617bad507f3e810d346534d6875175f44ae1599533b3acc8123dafc1f69f14

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes one unused line from a fuzz test (a type of automated test that throws random data at code to find bugs). The removed line set a 'cost of change' value that the CoinGrinder coin-selection algorithm never actually reads. The change only affects test code, not the real Bitcoin wallet, and does not fix or introduce any security issue.

AI review queuedMerge bitcoin/bitcoin#36606: test, bench: construct inputs/outputs declaratively in context-dependent casesby merge-script · 18953bd0 · Oct 29, 2026 · 5 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36606: test, bench: construct inputs/outputs declaratively in context-dependent cases

bdf58dd89cc2fe2f0be5ac63755e821661022be6 test: construct transaction_tests test_Get inputs/outputs declaratively (Alexander Wiederin)
24d00c4539479415207d3b912ec3648b4020c4e0 bench: construct ccoins_caching inputs/outputs declaratively (Alexander Wiederin)
a45478aa27553d28479cb288bb2d33f917bc544b test: construct sigopcount_tests BuildTxs inputs/outputs declaratively (Alexander Wiederin)
524d554e2bf952082f7e621145ca1b3a4b81d6c7 test: construct CreateBlockChain coinbase declaratively (Alexander Wiederin)
60be0930ca92eeee960ef6a2d7e2c61ef03c93dd test: construct transaction_utils inputs/outputs declaratively (Alexander Wiederin)

Pull request description:

Part of https://github.com/bitcoin/bitcoin/issues/36692 (previously discussed in https://github.com/bitcoin/bitcoin/pull/35994): replace procedural, field-by-field construction of `COutPoint`, `CTxIn` and `CTxOut` in test code with constructor calls.

This PR covers cases that are context-dependent and need manual changes, independent of a scripted-diff for the trivial bulk:
- `test/util/transaction_utils`: in `BuildSpendingTransaction`, the `scriptWitness` assignment has to be moved after `vin` is replaced, otherwise the witness is dropped.
- `test/util/mining`: in `CreateBlockChain`, the coinbase input's fields were split by the output assignments, with comments that are now kept next to the constructor arguments.
- `sigopcount_tests`: `BuildTxs` has the same witness ordering issue as `BuildSpendingTransaction`.
- `bench/ccoins_caching`: The `scriptSig`s are built with `<<` appends, and the second output was created by `vout.resize(2)` but never assigned, so it is kept as a null `CTxOut{}`.
- `transaction_tests`: `test_Get` builds the same transaction as `bench/ccoins_caching`, with the same `<<` appends and null second output.

**This change is test- and bench-only and does not change the constructed transactions.**

Notes for reviewers:
- `CTxIn` has no witness constructor argument, so `scriptWitness` is assigned after `vin` is replaced.
- `BuildTxs` is called repeatedly on the same transaction objects. Previously, `resize(1)` kept the existing inputs and only overwrote some of their fields; now they are replaced entirely. The fields that were left untouched by `BuildTxs` are never modified by the test, so the transactions are unchanged.
- The null second output in `ccoins_caching` is copied from `test_Get` in `transaction_tests` and looks like an oversight. It is kept here to avoid behaviour changes.

ACKs for top commit:
maflcko:
review ACK bdf58dd89cc2fe2f0be5ac63755e821661022be6 🍠
purpleKarrot:
But even when the approach does not follow the steps 1 and 2, it is a step in the right direction, hence ACK bdf58dd89cc2fe2f0be5ac63755e821661022be6

Tree-SHA512: af4c7489ddc553eda466b7ac4ca33cff400a495264b8cb2d869929e108fab8dac08f3cc164be79a3505b7c8b461514fc6f87f5afd42919f0712dd1d325d824b7

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code cleanup inside Bitcoin Core's tests and benchmarks. It replaces a manual, field-by-field way of building fake transactions with a more direct constructor style. The author explicitly states that the actual transaction data being built is unchanged, and the diff confirms the values and structure stay the same. There is no security issue here.

AI review queuedMerge bitcoin/bitcoin#36682: refactor: Use std::erase and std::erase_ifby merge-script · 363d9e9d · Oct 29, 2026 · 13 filesMessage 93 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36682: refactor: Use std::erase and std::erase_if

fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e refactor: Use std::erase and std::erase_if over iterator-based erase (MarcoFalke)
fa93a02563145aca3f96badaabe302b2dfa331d5 refactor: Use std::erase and std::erase_if over list removal or vector erase-remove (MarcoFalke)

Pull request description:

Convert `remove` and `remove_if` to the C++20 `std::erase` and `std::erase_if` overloads.

The legacy ones can be confusing, because:

* Array-based containers (like vector) must use the erase-remove idiom. Forgetting the erase, or forgetting to pass the end iterator (`bugprone-inaccurate-erase`) can be a bug, see also https://github.com/bitcoin/bitcoin/pull/36588#discussion_r4345799022. So a call only to "remove" will not erase.
* Node-based containers (like list or set) must not use the idiom. Using it will be a pessimization or won't compile. And correctly not using the idiom reads confusing, because a call to "remove" will actually erase.
* They are more verbose.

Also convert simple iterator-erase (which is verbose, but fine) to the std overload.

ACKs for top commit:
jpk68:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e
hodlinator:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e
w0xlt:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e

Tree-SHA512: 08fca3ecb73a5c45371a2e65339d9e35911f89dc717568cc29564f1a1395a44d84e939b9d38a21cadf5f2cbd64463c2564b1f7239ca75f53cf0bb30ae724dafd

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code cleanup that replaces older, more verbose ways of removing items from lists and vectors with newer C++20 standard helpers called std::erase and std::erase_if. It does not change what the program does, only how the source code expresses it. There is no security bug being fixed here.

AI review queuedMerge bitcoin/bitcoin#36588: refactor: Enable more tidy bugprone checksby merge-script · 23288073 · Oct 27, 2026 · 5 filesMessage 100 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36588: refactor: Enable more tidy bugprone checks

facb2209061ce40f558d9e1feaaf8e9a627117e5 refactor: Enable bugprone-return-const-ref-from-parameter to find missing LIFETIMEBOUND annotations (MarcoFalke)
fa211896e55bba672646c9f7bcf7b18c408b8ced refactor: Enable some useful bugprone checks, which are clean right now (MarcoFalke)
faa76b44c6e4efa08179919e0c0cf68d32fe0b0e refactor: Enable bugprone-inaccurate-erase (MarcoFalke)
fafce023b3d006d1cc36369eb71e434a9147b56e refactor: Enable bugprone-string-literal-with-embedded-nul (MarcoFalke)
fab3062590eab577e0b3ab8b93d642c7026c0775 refactor: Enable bugprone-unused-raii (MarcoFalke)

Pull request description:

Enable some bugprone clang-tidy checks, which seem useful.

Apart from a test-only bug, they didn't find anything severe, but I think it still makes sense to enable them, so that it is easier to read the resulting code. Also, it is trivial to disable them, if they turn out annoying.

ACKs for top commit:
stickies-v:
re-ACK facb2209061ce40f558d9e1feaaf8e9a627117e5
hebasto:
ACK facb2209061ce40f558d9e1feaaf8e9a627117e5.

Tree-SHA512: 660e06ad581c662eeb23d35c729ca6f9dc5cae31f30b212cf543f1e4d59147f4ccf467fbeb4dbfbbbe47ed2acb4abac543a558a98dcf1ef1d4445847100846b2

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit turns on additional automated code-quality checks in Bitcoin Core's clang-tidy configuration and makes a handful of small, matching cleanups. It is a refactoring/tooling change, not a fix for an active security bug. The only runtime code changes are switching one Qt container erase call to a safer modern form and adding a lifetime annotation to a D-Bus operator. The rest are test-only adjustments to satisfy new static-analysis rules.

AI review queuedtest: construct transaction_tests test_Get inputs/outputs declarativelyby Alexander Wiederin · bdf58dd8 · Oct 23, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Alexander Wiederin

test: construct transaction_tests test_Get inputs/outputs declaratively

Replace the field-by-field construction of the inputs and outputs with
COutPoint, CTxIn and CTxOut constructor calls.

The second output was previously only created by vout.resize(2) and
never assigned, leaving it null (nValue = -1). It is kept as a
default-constructed CTxOut so the transaction is unchanged.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor cleanup of a unit test file in Bitcoin Core. It replaces verbose, field-by-field construction of test transaction inputs and outputs with shorter declarative constructor calls. The behavior of the test is intentionally unchanged: the second transaction output remains default-constructed, just as it was before when it was created by resize(2) but never assigned. There is no change to production code, network behavior, or wallet handling.

AI review queuedMerge bitcoin/bitcoin#35395: doc: Improve test suite dependencies documentationby merge-script · 152a5539 · Oct 22, 2026 · 7 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35395: doc: Improve test suite dependencies documentation

22230f49f02b99be7077d6c52a775c322049903c doc: Unify Python optional module and test dependency documentation (Hennadii Stepanov)
39502b49b27ace1ffd27e9c5a28c8a97673b69c7 doc: Improve Python UTF-8 mode note (Hennadii Stepanov)
b51979ea7f6f39c0e22ef722557da7a35657f26f doc: Fix header formatting in `test/README.md` (Hennadii Stepanov)

Pull request description:

The current documentation has multiple issues:
1. OS-specific notes are missing for the `pycapnp` module.
2. `python3-zmq` is a package name in some Linux distros, rather than a Unix-wide convention.
3. Installing `pyzmq` from PyPI works in general, not only on macOS.

This PR resolves these issues. Additionally, two minor improvements have been added (see commit messages).

ACKs for top commit:
maflcko:
review ACK 22230f49f02b99be7077d6c52a775c322049903c 🎙
sedited:
ACK 22230f49f02b99be7077d6c52a775c322049903c

Tree-SHA512: 5c4eb3bde40594cddaa1ca4983f9c04de87d11c4ea7d3978eeeceec279cd45a2b689b4b2f163eb3592f14f22db128592fee84e126026e30ecff7299820227650

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only updates documentation. It reorganizes instructions for installing Python test-suite dependencies across operating systems and consolidates them into a single README file. No program code was changed, so it cannot directly affect security or introduce vulnerabilities.

AI review queuedMerge bitcoin/bitcoin#36456: Test: Cover malformed and truncated tx encodingsby merge-script · 2034d307 · Oct 22, 2026 · 2 filesMessage 91 · StrongInformational 12Details
Commit message · merge-script

Merge bitcoin/bitcoin#36456: Test: Cover malformed and truncated tx encodings

10f7cf848792b040bb3d1393598250c71c5700e0 Test: Cover malformed and truncated tx encodings (benthecarman)

Pull request description:

Check that every strict prefix of a witness transaction fails to deserialize, and that a witness flag of 0x02, which skips the witness section, is rejected as unknown optional data. Also check that CompactSize prefixes missing some of the bytes they announce fail to read.

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

ACKs for top commit:
darosior:
ACK 10f7cf848792b040bb3d1393598250c71c5700e0

Tree-SHA512: 997ccb4b04269d991035bb71ca2e3cbe7cfad1481b399d5456e99521eb10f064762533fbc9afa98a7aaecf6364b25f09931b58de7a413f07638a63f29d722c85

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot directly introduce or fix a security vulnerability in running software. The tests verify that malformed and truncated transaction data is rejected properly, which helps ensure existing protections keep working.

AI review queuedMerge bitcoin/bitcoin#35919: p2p: cap maxconnections at 2,000 to reduce crash riskby merge-script · f86c614e · Oct 21, 2026 · 5 filesMessage 81 · StrongLow 39Details
Commit message · merge-script

Merge bitcoin/bitcoin#35919: p2p: cap maxconnections at 2,000 to reduce crash risk

b30f750de56c4e510f8af5a4dbba4e821b71a9b1 p2p: cap maxconnections at 2000 (Lőrinc)

Pull request description:

**Problem:** The orphanage can abort when more than 3,000 peers have orphan announcements.
The `-maxconnections` setting currently has no explicit upper bound.

**Fix:** Cap `-maxconnections` at 2,000 with a warning before reserving file descriptors, while retaining the default of 200.

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/35919/commits/b30f750de56c4e510f8af5a4dbba4e821b71a9b1
optout21:
reACK b30f750de56c4e510f8af5a4dbba4e821b71a9b1
sedited:
ACK b30f750de56c4e510f8af5a4dbba4e821b71a9b1

Tree-SHA512: 06b892a67d9031f60427d04862fb0b96b30015c93904e544b4ec083c5713e56ab8b58c8747cb14b6bbd7ee52ca6a0d1ab5c4d9607789a19987bbda89a0689afd

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 39/100

This update limits how many peer connections Bitcoin Core will allow a user to request. Previously, a user could set an extremely high number of connections, which could trigger a crash when the orphan transaction cache (used for unconfirmed transactions) was shared across too many peers. Now, values above 2,000 are automatically reduced to 2,000 with a warning. It is a hardening fix, not a remote exploit.

AI review queuedMerge bitcoin/bitcoin#36579: refactor: Enable some string performance tidy rulesby merge-script · a2d42ce8 · Oct 21, 2026 · 21 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36579: refactor: Enable some string performance tidy rules

fabb6bbe53e9cba85b62da2416287c41975d71dd refactor: Use single-char overload in execute_process WIN32 block (MarcoFalke)
bbbb9c6d73a3750185c62bcb520b6ba74ac34be9 refactor: Enable performance-faster-string-find (MarcoFalke)
faae016796ed64da493cb175e40fca042fe386e6 refactor: Enable performance-prefer-single-char-overloads (MarcoFalke)
fa7973e1138aea8f1584205f4a5391a06447e2b9 refactor: Enable performance-string-view-conversions (MarcoFalke)

Pull request description:

Enabling the string performance clang-tidy rules should be fine and easy.

E.g. on aarch64, when running the `BlockToJsonVerboseWrite` bench, I can see a minimal 0.3% drop in instructions and 0.6% drop in branches.

ACKs for top commit:
stickies-v:
re-ACK fabb6bbe53e9cba85b62da2416287c41975d71dd
hebasto:
ACK fabb6bbe53e9cba85b62da2416287c41975d71dd.
l0rinc:
ACK fabb6bbe53e9cba85b62da2416287c41975d71dd

Tree-SHA512: 5917732c61960021d423fe8da5ada6eab986ab87e15f328ac74f5e31d0a1f1ea9d448b2dadad70418471b833da994bc3708c73e6e210fd5f2b2d08e88ce01bff

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup that turns on three clang-tidy style checks and applies the resulting mechanical fixes. It replaces multi-character string literals like " " and "\n" with single characters where a single character is enough, and removes a few unnecessary std::string conversions. The changes are purely about code style and tiny performance gains (the author reports roughly 0.3% fewer CPU instructions in one benchmark). There is no security bug being fixed and no new attack surface introduced.

AI review queuedMerge bitcoin/bitcoin#36397: scripted-diff: [wallet] Remove trailing newlines from one-line log messagesby merge-script · 6799119c · Oct 20, 2026 · 14 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36397: scripted-diff: [wallet] Remove trailing newlines from one-line log messages

fa0c552cc5abdd0a7e7f2c9cfc1491240494f352 wallet: Reject trailing newline in format strings (MarcoFalke)
fada75ccb05575e01c18bd4b6b28d41a3c2cd87c util: Add option to reject trailing newline in format strings (MarcoFalke)
fa57d5244b3cdc151e01d7dd02a5e363bf801bcb scripted-diff: [wallet] Remove trailing newlines from one-line log messages (MarcoFalke)
fa6c7942ad8e159f240194d2d290e9d64812761a wallet: Remove inconsistent and redundant trailing error newlines (MarcoFalke)
fa89aeec855b774e8ef37b31ac2b6b83c1d263e8 test: [move-only] Move test_LogEscapeMessage to logging tests (MarcoFalke)

Pull request description:

This is a low-prio style cleanup for years, but:

* It is tedious and possibly distracting to do it manually when touching the line for other reasons.
* The topic recently came up again when discussing log injection (https://github.com/bitcoin/bitcoin/pull/35833#issuecomment-5113804332)

So I wonder if a simple scripted-diff can cover the bulk of the changes now, with hopefully little conflicts with reviewed pull requests.

(Removing the trailing newlines from the remaining log messages is trivial and can be done in a later pull)

ACKs for top commit:
l0rinc:
ACK fa0c552cc5abdd0a7e7f2c9cfc1491240494f352
sedited:
ACK fa0c552cc5abdd0a7e7f2c9cfc1491240494f352

Tree-SHA512: 48b5fa1f25797052e4a0e66efe7c59085309ba56524d001ac35089a579cf08a7b8a0908de54290f3b4867a012f097c00f2f8d57723d15c9da6e09eb902bd8ed3

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 19/100

This is a code-cleanup change for Bitcoin Core's wallet logging. It removes manual newline characters from the end of one-line log messages and adds a compile-time check that prevents wallet log format strings from ending in a newline. The change is defensive: it reduces the chance that a future log message could accidentally inject fake log lines or confuse log parsing, but it does not by itself fix an active security bug.

AI review queuedMerge bitcoin/bitcoin#36553: test: Add missing sync_mempools in wallet_conflicts.pyby merge-script · 020fcb28 · Oct 20, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36553: test: Add missing sync_mempools in wallet_conflicts.py

fa1061481bb1cb6bb7d5ca7ea6674f349f2baed8 test: Add missing sync_mempools in wallet_conflicts.py (MarcoFalke)
fa3986f5c1d512f5e8a320ccbbd84bde3c9e2575 test: Remove redundant sync call after self.generate called sync_all (MarcoFalke)

Pull request description:

Fix https://github.com/bitcoin/bitcoin/actions/runs/38882212577/job/116911393791?pr=36545#step:11:3700:

```
2026-10-16T09:48:01.724540Z TestFramework (INFO): Test a scenario where a transaction has a mempool conflict
2026-10-16T09:48:02.100649Z TestFramework (INFO): Test scenario where a mempool conflict is removed
2026-10-16T10:28:02.397150Z TestFramework (ERROR): Unexpected exception:
Traceback (most recent call last):
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 146, in main
self.run_test()
~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 38, in run_test
self.test_mempool_conflict()
~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 202, in test_mempool_conflict
self.generate(self.nodes[2], 1)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 668, in generate
sync_fun() if sync_fun else self.sync_all()
~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 750, in sync_all
self.sync_mempools(nodes)
~~~~~~~~~~~~~~~~~~^^^^^^^
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 743, in sync_mempools
raise AssertionError("Mempool sync timed out after {}s:{}".format(
...<2 lines>...
))
AssertionError: Mempool sync timed out after 2400s:
{'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
{'47de6fdef43b22320dc0114c2104e3dee58de9591799ff5e48ff29efaa5cf88f', 'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
{'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
```

by adding the missing `sync_mempools`.

ACKs for top commit:
fanquake:
ACK fa1061481bb1cb6bb7d5ca7ea6674f349f2baed8

Tree-SHA512: 526a216228f87976c5a41b8fffb8eab0728d23c70c642a54ed2f2cc58c93875119c5c294b151bab5ff70994f657091a6db879f4aae63b0cde356466685fcd084

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a flaky automated test in Bitcoin Core. It adds missing mempool synchronization calls in a wallet-conflict test and removes a couple of redundant block-sync calls. There is no change to production code, no security vulnerability, and no risk to users' funds or node safety.

AI review queuedMerge bitcoin/bitcoin#36341: wallet: return error from bitcoin-wallet createby merge-script · ebb53105 · Oct 19, 2026 · 2 filesMessage 81 · StrongInformational 24Details
Commit message · merge-script

Merge bitcoin/bitcoin#36341: wallet: return error from bitcoin-wallet create

f64d33672fe1488b49254a634cbecfd9ce4ca179 wallet: return error from bitcoin-wallet create (Kanan)

Pull request description:

`bitcoin-wallet create` exits with status 0 even when the wallet couldn't be created:

```
$ bitcoin-wallet -regtest -wallet=w1 create # first time, ok
$ bitcoin-wallet -regtest -wallet=w1 create
Failed to create database path '.../regtest/wallets/w1'. Database already exists.
$ echo $?
0
```

In `ExecuteWalletToolFunc` the `create` branch only does something when `MakeWallet` succeeds and then falls through to `return true`. The other commands (`info`, `dump`, `createfromdump`) all return false on failure. So scripts that check the exit code think the wallet was created.

This returns false when `MakeWallet` fails, the same way `info` does. The added check in `tool_wallet.py` runs `create` on the existing wallet `foo` and expects exit code 1. It fails on master (`not(0 == 1)`) and passes with the fix.

ACKs for top commit:
maflcko:
lgtm ACK f64d33672fe1488b49254a634cbecfd9ce4ca179
sedited:
ACK f64d33672fe1488b49254a634cbecfd9ce4ca179

Tree-SHA512: aa2404a4bea38ca53da989d0b09e13a6b48dccfd49fa0e70a268c325241226693a8ca6ef94fb35cc0cca2cc66a066dcf90adfc254e972e4b9b23c047adefaf3f

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This is a small reliability fix for the bitcoin-wallet command-line tool. Previously, when you tried to create a wallet that already existed, the tool printed an error message but still exited with status 0, which is the code normally used for success. Scripts and automated tools checking the exit code would therefore incorrectly think the command succeeded. The patch makes the tool return a non-zero exit code on failure, matching the behavior of other wallet tool commands. There is no security vulnerability allowing theft, remote attack, or code execution.

AI review queuedMerge bitcoin/bitcoin#36545: test: Fix intermittent issue in p2p_initial_headers_sync.pyby merge-script · 71fa0439 · Oct 19, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36545: test: Fix intermittent issue in p2p_initial_headers_sync.py

fad7637529426f058a3c2409dd137009b14622a4 test: Fix intermittent issue in p2p_initial_headers_sync.py (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/actions/runs/38697071260/job/116296055487?pr=36537#step:11:5104:

```
test 2026-10-15T07:19:58.731108Z TestFramework (INFO): Check that noban peer1 is not disconnected
test 2026-10-15T07:19:58.731159Z TestFramework.p2p (DEBUG): Send message to 127.0.0.1:12392: msg_ping(nonce=00000000)
test 2026-10-15T07:19:58.731184Z TestFramework.p2p (DEBUG): Send message to 127.0.0.1:12392: msg_ping(nonce=00000002)
node0 2026-10-15T07:19:58.731236Z (mocktime: 2026-10-15T07:48:45Z) [http.01] [httpserver.cpp:1318] [MaybeSendBytesFromBuffer] [http] Sent 148 bytes to client 127.0.0.1:57508 (id=0)
node0 2026-10-15T07:19:58.731307Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [logging/timer.h:58] [Log] [lock] ContendedLock: lock contention connman.m_nodes_mutex, ./net.h:1876 started
node0 2026-10-15T07:19:58.731317Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [logging/timer.h:58] [Log] [lock] ContendedLock: lock contention connman.m_nodes_mutex, ./net.h:1876 completed (0μs)
node0 2026-10-15T07:19:58.731332Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net_processing.cpp:3836] [ProcessMessage] [net] received: ping (8 bytes) peer=0
node0 2026-10-15T07:19:58.731338Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net.cpp:4220] [PushMessage] [net] sending pong (8 bytes) peer=0
node0 2026-10-15T07:19:58.731365Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net.cpp:4220] [PushMessage] [net] sending ping (8 bytes) peer=0
test 2026-10-15T07:19:58.731377Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:12392: msg_pong(nonce=00000000)
node0 2026-10-15T07:19:58.731388Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net_processing.cpp:6499] [SendMessages] Timeout downloading headers from noban peer, not disconnecting peer=0
node0 2026-10-15T07:19:58.731402Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net.cpp:4220] [PushMessage] [net] sending ping (8 bytes) peer=1
node0 2026-10-15T07:19:58.731421Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net.cpp:4220] [PushMessage] [net] sending getheaders (69 bytes) peer=1
node0 2026-10-15T07:19:58.731441Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net_processing.cpp:6151] [SendMessages] [net] initial getheaders (0) to peer=1
node0 2026-10-15T07:19:58.731461Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net_processing.cpp:3836] [ProcessMessage] [net] received: ping (8 bytes) peer=0
node0 2026-10-15T07:19:58.731466Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net.cpp:4220] [PushMessage] [net] sending pong (8 bytes) peer=0
test 2026-10-15T07:19:58.731579Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:12392: msg_ping(nonce=a011607af5f6e69c)
test 2026-10-15T07:19:58.731607Z TestFramework.p2p (DEBUG): Send message to 127.0.0.1:12392: msg_pong(nonce=a011607af5f6e69c)
test 2026-10-15T07:19:58.731633Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:12392: msg_pong(nonce=00000002)
node0 2026-10-15T07:19:58.731777Z (mocktime: 2026-10-15T07:48:45Z) [http] [httpserver.cpp:971] [Receive] [http] Received 339 bytes from 127.0.0.1:57508 (id=0): total=3476 buffered=339
node0 2026-10-15T07:19:58.731798Z (mocktime: 2026-10-15T07:48:45Z) [http] [httpserver.cpp:1135] [TryReadRequest] [http] Received a POST request for / from 127.0.0.1:57508 (id=0)
node0 2026-10-15T07:19:58.731833Z (mocktime: 2026-10-15T07:48:45Z) [http.00] [rpc/request.cpp:246] [parse] [rpc] ThreadRPCServer method=getpeerinfo user=__cookie__ id=32
node0 2026-10-15T07:19:58.732118Z (mocktime: 2026-10-15T07:48:45Z) [http.00] [httpserver.cpp:637] [Send] [http] HTTPResponse (status code: 200 size: 2260) added to send buffer for client 127.0.0.1:57508 (id=0)
test 2026-10-15T07:19:58.732309Z TestFramework (INFO): Check that exactly 1 of {peer1, peer2} receives a getheaders
test 2026-10-15T07:19:58.732370Z TestFramework (ERROR): Unexpected exception:
Traceback (most recent call last):
File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 146, in main
self.run_test()
~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/p2p_initial_headers_sync.py", line 182, in run_test
self.test_noban_peer_timeout()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/p2p_initial_headers_sync.py", line 177, in test_noban_peer_timeout
self.assert_single_getheaders_recipient([peer1, peer2])
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/p2p_initial_headers_sync.py", line 66, in assert_single_getheaders_recipient
assert_equal(count, 1)
~~~~~~~~~~~~^^^^^^^^^^
File "/home/runner/work/_temp/test/functional/test_framework/util.py", line 95, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(0 == 1)
test 2026-10-15T07:19:58.733190Z TestFramework (DEBUG): Closing down network thread
node0 2026-10-15T07:19:58.733256Z (mocktime: 2026-10-15T07:48:45Z) [http.00] [httpserver.cpp:1318] [MaybeSendBytesFromBuffer] [http] Sent 2260 bytes to client 127.0.0.1:57508 (id=0)
test 2026-10-15T07:19:58.733311Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:58180: msg_ping(nonce=39768d79544b5e40)
test 2026-10-15T07:19:58.733337Z TestFramework.p2p (DEBUG): Send message to 127.0.0.1:58180: msg_pong(nonce=39768d79544b5e40)
test 2026-10-15T07:19:58.733367Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:58180: msg_getheaders(locator=CBlockLocator(vHave=[7041830694386478471858881810674310864173988660927928131397671070347943617030]), stop=0000000000000000000000000000000000000000000000000000000000000000)
node0 2026-10-15T07:19:58.733447Z (mocktime: 2026-10-15T07:48:45Z) [msghand] [net_processing.cpp:3836] [ProcessMessage] [net] received: pong (8 bytes) peer=0
test 2026-10-15T07:19:58.733502Z TestFramework.p2p (DEBUG): Closed connection to: 127.0.0.1:58180
node0 2026-10-15T07:19:58.733536Z (mocktime: 2026-10-15T07:48:45Z) [net] [net.cpp:2236] [SocketHandlerConnected] [net] socket closed, disconnecting peer=1
node0 2026-10-15T07:19:58.733546Z (mocktime: 2026-10-15T07:48:45Z) [net] [net.cpp:567] [CloseSocketDisconnect] [net] Resetting socket for peer=1
node0 2026-10-15T07:19:58.733596Z (mocktime: 2026-10-15T07:48:45Z) [net] [net_processing.cpp:1859] [FinalizeNode] [net] Cleared nodestate for peer=1
test 2026-10-15T07:19:58.783870Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
```

Diff to reproduce:

```diff
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index beec44f55d..85b1e88161 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -87,2 +87,3 @@
#include <span>
+#include <thread>
#include <typeinfo>
@@ -5233,2 +5234,7 @@ void PeerManagerImpl::ProcessMessage(Peer& peer, CNode& pfrom, const std::string
MakeAndPushMessage(pfrom, NetMsgType::PONG, nonce);
+ // TEMPORARY: widen the p2p_initial_headers_sync race window after
+ // its second, nonzero ping has been sent but before SendMessages().
+ if (nonce != 0) {
+ std::this_thread::sleep_for(std::chrono::milliseconds{90});
+ }
}
```

Cmd to reproduce:

```
./bld-cmake/test/functional/test_runner.py $(for i in {1..20}; do echo -n "p2p_initial_headers_sync.py ";done) -j $( nproc )
```

(fails before this pull and passes after)

ACKs for top commit:
Crypt-iQ:
tACK fad7637529426f058a3c2409dd137009b14622a4
l0rinc:
lightly tested ACK fad7637529426f058a3c2409dd137009b14622a4

Tree-SHA512: 701c9d75ed68e806f95ddef34b59abbd943288be8f957708d112f9e02e7b370f10f267c1a22946dc38dc6ff20665fdd0ceda19ebfed18660ae6ebbcc779fc90b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit fixes a flaky automated test in Bitcoin Core. The test sometimes failed because it checked too quickly whether a network message had been sent. The fix makes the test wait until exactly one peer has received the expected message. There is no change to the actual Bitcoin node software that users run, so this has no security impact on real networks or wallets.

AI review queuedMerge bitcoin/bitcoin#36446: test: remove some avoidable test waitsby merge-script · 3c30b8ae · Oct 15, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36446: test: remove some avoidable test waits

ce1d88b2632cc3950f47d8b191bdd74b806eb3ae test: avoid unused wallet test chains (will)
40619d068741ec609ddd3148f13234cbdc54161c bench: honor configured wallet epochs (will)
79bb94f09244ef5745d3c83a8839eec3fcbf2f74 test: cap expected IPC timeouts (will)
06cb869112da6bb1c43f938b2e5a9794f825ff92 test: shorten network limited negative wait (will)

Pull request description:

A few of our longer-running tests have some unnecessary waits and timeouts in them. Reduce or replace them to shorten test times:

- in `p2p_node_network_limited` replace the expected sync timeout with header/ping barriers and a bounded negative check. At CI timeout factor 40, saves roughly 195 seconds per transport.
- in `interface_ipc_mining` cap three expected no-event waits at five seconds, saving roughly 105 seconds at factor 40 in CI.
- in `WalletLoadingDescriptors` honor sanity mode’s single epoch, avoiding four unnecessary wallet unload/load cycles.
- two wallet unit tests switch to `BasicTestingSetup` avoiding construction of two unused 100-block chains.

The timeout changes alone save approximately eight minutes of accumulated test-worker time on CI jobs running both transports and IPC mining. Wall-clock savings depend on parallel scheduling, CPU etc.

ACKs for top commit:
Ayoazeez26:
tACK ce1d88b263
maflcko:
review ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae 🐠
ViniciusCestarii:
ACK ce1d88b2632cc3950f47d8b191bdd74b806eb3ae

Tree-SHA512: 77a78ff05327cf08273618ed3f1601d60a0d8533459e3beecd56ed36f0f743ee4cdb6c227d9eee2a48c46831f92b0ab64e74faa536e56a28c5281c7e1eacdae2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's test and benchmark code to remove unnecessary waiting periods and honor existing test settings. It does not alter the production Bitcoin node software that users run, so it cannot directly affect live network security, wallets, or consensus behavior. The changes make CI tests run faster and avoid some redundant setup work.