BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 41 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge bitcoin/bitcoin#36686: test: cover cumulative input value range in CheckTxInput tests.by merge-script · a0ebf34b · Nov 4, 2026 · 1 fileMessage 96 · StrongInformational 14Details
Commit message · merge-script

Merge bitcoin/bitcoin#36686: test: cover cumulative input value range in CheckTxInput tests.

98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 test: cover negative input in CheckTxInputs (KY-U)
133714d1695bc40277b213afd252c3e320cac73e test: cover cumulative input value range in CheckTxInputs (KY-U)
f8c6cd84e08043f206ca338d0ba7e4dc8bef5214 test: support multiple inputs in CheckTxInputs test helper (KY-U)

Pull request description:

In `Consensus::CheckTxInputs`, the inputs are invalid if, for every input coin, either `coin.out.nValue` or `nValueIn` is out of range. However, the current `checktxinputs_invalid_transactions_test` only covers cases with one input, so the sum `nValueIn` is always equal to `coin.out.nValue`, leaving the [following mutant](https://mutanthub.space/mutants/275) alive.
```diff
--- a/src/consensus/tx_verify.cpp
+++ b/src/consensus/tx_verify.cpp
@@ -189,7 +189,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, TxValidationState& state,

// Check for negative or overflow input values
nValueIn += coin.out.nValue;
- if (!MoneyRange(coin.out.nValue) || !MoneyRange(nValueIn)) {
+ if (!MoneyRange(coin.out.nValue) && !MoneyRange(nValueIn)) {
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-inputvalues-outofrange");
}
}
```
https://github.com/bitcoin/bitcoin/pull/36686/commits/f8c6cd84e08043f206ca338d0ba7e4dc8bef5214 adds support for multiple inputs in the test helper.

https://github.com/bitcoin/bitcoin/pull/36686/commits/133714d1695bc40277b213afd252c3e320cac73e adds a test case with multiple valid inputs, whose sum exceed `MAX_MONEY`, while also having `nValueIn` != `coin.out.nValue`, killing the mutant.

https://github.com/bitcoin/bitcoin/pull/36686/commits/98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 adds a test for uncovered negative input case.

ACKs for top commit:
mercie-ux:
reACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1
ViniciusCestarii:
ACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 nice!
sedited:
ACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1

Tree-SHA512: 1199a03bcc85ee56317f0d3089c03a3dd3116868630174c0ee26523c9e6d86370065e830a476e1c573b2504e5c45487c77d50e25e64f2e20e7c1dadaa12eb2b4

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetyconsensus or confidential-proof validationsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 14/100

This commit only adds new test cases to Bitcoin Core's test suite. It does not change any production consensus, validation, or networking code. The tests verify that an existing check in the transaction validation logic correctly rejects transactions with out-of-range input values, including cases with multiple inputs. There is no security vulnerability being fixed here—only test coverage is being improved.

Security candidateMerge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txidby merge-script · fef06b86 · Nov 4, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txid

bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0 wallet: export replaces_txid and replaced_by_txid (Vasil Dimov)

Pull request description:

Export the fields `replaces_txid` and `replaced_by_txid` from `wallet::CWalletTx` to `interfaces::WalletTx`.

In May 2026 https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c hooked a usage of `interfaces::WalletTx::value_map["replaces_txid"]` and `interfaces::WalletTx::value_map["replaced_by_txid"]` into the QML GUI.

Then, in June 2026 https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497 removed the map entirely from the main repository, but the `replaces_txid` and `replaced_by_txid` fields were not exposed in `interfaces::WalletTx`. Thus the QML GUI has no access to them.

Export the fields to solve this.

The QT5 GUI never used those.

ACKs for top commit:
pseudoramdom:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
johnny9:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
sedited:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0

Tree-SHA512: 2dcfd67ef2cca6bef778911d3e8039a91d3eca5d26d4ca7a83c31ebba71aced8b3b7add825baa001f2466ba6e4e7180764fe5d0a8ff99ebe98eb7c80635d385e

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit simply exposes two existing transaction-replacement identifiers (replaces_txid and replaced_by_txid) through an internal wallet interface so that a future QML-based user interface can read them. It is a straightforward data plumbing change with no security implications.

Security candidateMerge bitcoin/bitcoin#36615: guix: add --no-same-owner to codesign.sh TAR_OPTIONSby merge-script · eb1b70d8 · Nov 4, 2026 · 1 fileMessage 93 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36615: guix: add --no-same-owner to codesign.sh TAR_OPTIONS

d2e5108ea2ddce1952d4db8b42d39a40e3d9f521 guix: add --no-same-owner to codesign.sh TAR_OPTIONS (marcofleon)

Pull request description:

Just ran `guix-codesign` for v32.0 as root, in fanquake's container image ([option 3](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/INSTALL.md#option-3-using-fanquakes-container-image) in INSTALL.md) and got this error while unpacking the codesigning tarball:

```bash
tar: ./detached-sig-create.sh: Cannot change ownership to uid 0, gid 0: Invalid argument
tar: ./unsigned/bitcoin-32.0: Cannot change ownership to uid 0, gid 0: Invalid argument
tar: ./unsigned/bitcoin-32.0-win64-setup-unsigned.exe: Cannot change ownership to uid 0, gid 0: Invalid argument
...
tar: Exiting with failure status due to previous errors
```
Same happens for the macOS files.

When updating guix in https://github.com/bitcoin/bitcoin/pull/34550, `--no-same-owner` was added in `build.sh` (now in `setup.sh`) in 0f323e10759aba4429677d0e1e202bf575b6d664, but not in `codesign.sh`. This PR adds it to `TAR_OPTIONS` in `codesign.sh`. This fixed the issue for me and my hashes match the other attestations for v32.0.

ACKs for top commit:
fanquake:
ACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521
willcl-ark:
utACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521

Tree-SHA512: e0a10053839144f7042590ad8d46b762099983fd9eca55a9c5b7aecc9aa3b61ac833f1e1f1fd36dfe0a6b17d111215e0b56faa188b6e5c286618a15013e3ee24

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundaryupdate trustsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 18/100

This is a one-line fix for the Bitcoin Core release-codesigning script used in reproducible builds. When a release signer ran the signing tool as root inside a container, tar failed because it tried to preserve file ownership from the original tarball (root-owned files) but could not assign those owners in the container environment. The patch tells tar not to try to keep the original owners, which lets the signing process finish and lets the signer produce matching release signatures. It is a build-tool reliability fix, not a vulnerability in the Bitcoin network or wallet software.

Security candidateMerge bitcoin/bitcoin#36494: wallet: reject unknown options in sendallby merge-script · f3cd4e4b · Nov 3, 2026 · 3 filesMessage 81 · StrongModerate 64Details
Commit message · merge-script

Merge bitcoin/bitcoin#36494: wallet: reject unknown options in sendall

702ec9d40f84dfd0ca9bf73e37052c36f3802702 wallet: reject unknown options in sendall (Thomas)

Pull request description:

`sendall` silently ignores unknown keys in its `options` object, including misspelled ones: `input` instead of `inputs` spends all available UTXOs rather than the given ones, and a misspelled `add_to_wallet` or `psbt` can broadcast a transaction the caller asked not to broadcast.

Reject unknown options, like `send`, `fundrawtransaction`, `walletcreatefundedpsbt` and `bumpfee` already do.

ACKs for top commit:
maflcko:
review ACK 702ec9d40f84dfd0ca9bf73e37052c36f3802702 🐀
Zippo76:
tACK 702ec9d40f
polespinasa:
ACK 702ec9d40f84dfd0ca9bf73e37052c36f3802702

Tree-SHA512: b6a4b9c87014ddc4782f20c7053617cb7d52971a511e344ba9b35bd2cb2145a06489648802455f421fe712802b5ba8665d0aab77390df82bc3ebbc5661e78ed7

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This change fixes a bug in Bitcoin Core's `sendall` wallet command where misspelled or unknown options in the options object were silently ignored. For example, typing `input` instead of `inputs` would spend all coins instead of only the chosen ones, and misspelling `add_to_wallet` or `psbt` could broadcast a transaction the user did not want broadcast. The fix makes `sendall` reject unknown or wrongly typed options, matching other wallet commands.

Security candidateMerge bitcoin/bitcoin#35728: rpc: Properly throw on internal I/O errors in GetTransactionby Ryan Ofsky · fb19fed3 · Nov 3, 2026 · 7 filesMessage 91 · StrongLow 43Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#35728: rpc: Properly throw on internal I/O errors in GetTransaction

fad49fd81fcffd1dd9f40320a239881a0881be25 Add doc/release-notes-35728.md (MarcoFalke)
fa7d278aad832250e2c1e07ef10afdffee36da4e refactor: Use GetTransaction in ProcessPSBT (MarcoFalke)
fa32e607531c712dab33a712127e473086e32f9f rpc: Properly throw on internal FindTx IO errors in ProcessPSBT and GetTransaction (MarcoFalke)
faaf4a751c68d57ea21d40fbd66dcbbc69abbbac test: Add test to check RPCs throw on IO errors (MarcoFalke)
fad44f18b88fddae160bffb672e12c01c92d6a7f rpc: Return proper error messages from getrawtransaction (MarcoFalke)
fa5ad60c32860786251afc9b764deeb9b5fdcf62 test: Add test for getrawtransaction block read errors (MarcoFalke)

Pull request description:

Currently the GetTransaction return value is a nullable transaction
pointer, where nullptr represents two different outcomes: I/O error and
missing tx.

Reporting a confirmed transaction as missing is wrong, so properly
return an error instead.

ACKs for top commit:
furszy:
ACK fad49fd81fcffd1dd9f40320a239881a0881be25
l0rinc:
ACK fad49fd81fcffd1dd9f40320a239881a0881be25
musaHaruna:
re-ACK [fad49fd](https://github.com/bitcoin/bitcoin/commit/fad49fd81fcffd1dd9f40320a239881a0881be25)
ryanofsky:
Code review ACK fad49fd81fcffd1dd9f40320a239881a0881be25. Since last review, `WarnAndThrowErr` takes the format string and arguments directly, and the release note wording is updated. Thanks!

Tree-SHA512: 6ed11f58a05c46e300412c8db18ae49308af386449fe417a1c3c7de61b3ad85341747b5b4af331d6fa956d55fe039c8fffd9da8f080090f514df11acdcfbcb66

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 43/100

This Bitcoin Core update fixes a bug where several RPC commands and one REST endpoint would incorrectly tell users a confirmed transaction was missing, when in fact the software had hit a disk-read or index corruption problem. After the patch, these interfaces return a clear internal error instead of a misleading 'not found' result. It is a correctness/reliability fix rather than a remote-code-execution style vulnerability.

Security candidateMerge bitcoin/bitcoin#36344: wallet: reject duplicate inputs in sendallby merge-script · 67d9d7fe · Nov 3, 2026 · 2 filesMessage 100 · StrongLow 37Details
Commit message · merge-script

Merge bitcoin/bitcoin#36344: wallet: reject duplicate inputs in sendall

654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be wallet: reject duplicate inputs in sendall (Bruce0X)

Pull request description:

`sendall` with the `inputs` option doesn't check for duplicates. Each listed input is added to `total_input_value` in the loop at spend.cpp:1472, so passing the same UTXO twice counts its value twice.

On regtest, with a wallet that has a single 1 BTC UTXO:

```
sendall '["<addr>"]' '{"inputs": [<utxo>, <utxo>]}'
```

- the RPC returns `complete: true`
- the committed tx has 2 inputs (the same outpoint twice) and one output of 1.99998230 BTC
- it isn't in the mempool, and `testmempoolaccept` rejects it with `bad-txns-inputs-duplicate`
- after that, `listunspent` is empty and `getbalances` shows `nonmempool: -1.0` until the tx is abandoned

`send` and `walletcreatefundedpsbt` aren't affected, because `CCoinControl::Select` removes duplicates.

This rejects a duplicated input with `Invalid parameter, duplicated input: <txid>:<vout>` (RPC_INVALID_PARAMETER). The message matches what `createrawtransaction` says for duplicated addresses. The new `sendall_fails_on_duplicate_input` test fails on master ("No exception raised") and passes with the fix. `wallet_send.py` still passes.

ACKs for top commit:
l0rinc:
ACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be
maflcko:
review ACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be 🚪
molnard:
tACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be

Tree-SHA512: ae8541f9458a12e97d6c516cd2327519d2be8cf0e7501622c7a9d295ecbfd61290d7f874e205cf1e8fc8bcc147edc55e4d773fbe700b6a20db4a7071a9a97b19

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 37/100

This patch fixes a bug in Bitcoin Core's `sendall` wallet RPC command. Previously, if a user accidentally listed the same coin (UTXO) twice in the `inputs` option, the command would create an invalid transaction that counted the coin's value twice. The transaction would be rejected by the network, but it would temporarily confuse the wallet's balance display. The fix now rejects duplicate inputs immediately with a clear error message.

Security candidateMerge bitcoin/bitcoin#36707: net_processing: remove redundant `peer` check in `MaybePunishNodeForBlock`by merge-script · 35195e66 · Nov 3, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36707: net_processing: remove redundant `peer` check in `MaybePunishNodeForBlock`

66292fa4b575ef193ab2363391399cec29bf3503 net_processing: remove redundant peer check in MaybePunishNodeForBlock (fanquake)

Pull request description:

The `Misbehaving()` call is already inside an `if (peer && ...)` block.

ACKs for top commit:
Crypt-iQ:
crACK 66292fa4b575ef193ab2363391399cec29bf3503
jpk68:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
ViniciusCestarii:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
l0rinc:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
brunoerg:
ACK 66292fa4b575ef193ab2363391399cec29bf3503

Tree-SHA512: 6fe9aef26937711965a96107a8d57a1dd12e31592f38485ece3836c0afd72592a7adf40a542caa953211bd29c91dc2c6439b17d4a4263352fe5f6667d63f74dc

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a tiny code cleanup in Bitcoin Core's network handling. It removes an unnecessary second check that 'peer' exists, because the surrounding code already confirmed it exists. There is no functional change and no security risk.

Security candidateMerge bitcoin/bitcoin#36712: fees: prevent divide by zero in CFeeRateby merge-script · 38ece2a9 · Nov 2, 2026 · 3 filesMessage 91 · StrongModerate 60Details
Commit message · merge-script

Merge bitcoin/bitcoin#36712: fees: prevent divide by zero in CFeeRate

f442fa20d437f02518c327736206185bd6f6a1a1 fees: prevent divide by zero in CFeeRate (ismaelsadeeq)

Pull request description:

A CFeeRate with size 0 `GetFeePerK()` and `CFeeRate+=` evaluated `EvaluateFeeDown(1000)` unconditionally, dividing by that zero size and crashing.

Return 0 for an empty fee rate, matching `GetFee()` behaviour, and add minimal unit test coverage.

This was reported by Jacob F Cudney (aragondragon)

ACKs for top commit:
pablomartin4btc:
re-ACK f442fa20d437f02518c327736206185bd6f6a1a1
polespinasa:
re-ACK f442fa20d437f02518c327736206185bd6f6a1a1
musaHaruna:
Code review ACK [f442fa2](https://github.com/bitcoin/bitcoin/pull/36712/changes/f442fa20d437f02518c327736206185bd6f6a1a1)

Tree-SHA512: c3792271819814272a78845ce6f2782aa9ec629f2d67a1505c195bc340ea55e326b686b928b3958bd1cc807ca577747bd6ebe2e2cd3dc367e5cca1316a6b721d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a divide-by-zero crash in Bitcoin Core's fee-rate calculation. When a transaction fee rate was created with a size of zero, calling certain methods would try to divide by zero and crash the program. The fix makes these methods safely return zero instead, matching the behavior of related code, and adds tests to prevent the crash from coming back.

Security candidateMerge bitcoin/bitcoin#36305: net: Use exclusive P2P listen sockets on Windowsby Hennadii Stepanov · 3581d56b · Nov 2, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36305: net: Use exclusive P2P listen sockets on Windows

db31a3ad1f75538d07707d373adbfbe90ba8e328 test: check P2P listen port exclusivity (winterrdog)
0dbd271eb4a3263b8b81ccf22876429076bae574 net: use exclusive P2P listen sockets on Windows (winterrdog)

Pull request description:

on Windows, `SO_REUSEADDR` does not carry over the same semantics as on
POSIX systems. a second socket can set `SO_REUSEADDR` and bind to a
port that is _already in use_ by another process running under
the _same_ user account. this means another local process could bind to
the P2P listen port and receive incoming connections intended for
`bitcoind`.

this matters because the P2P listener is expected to have exclusive
ownership of its address and port. allowing another process to bind to
it could let that process _intercept_ incoming P2P connections. this is
in a similar spirit to #36169, which made the RPC listener exclusive on
Windows.

to fix this, we use `SO_EXCLUSIVEADDRUSE` for the P2P listen socket on
Windows instead of `SO_REUSEADDR`, while retaining `SO_REUSEADDR` on
other platforms. the added test verifies the expected behaviour by
attempting to bind a second socket to the same port. on Windows, this
fails with `WSAEACCES` (`10013`), which Python exposes as
`PermissionError` (an `OSError` subclass).

references:

- https://learn.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse
- https://stackoverflow.com/questions/14388706/how-do-so-reuseaddr-and-so-reuseport-differ/14388707#14388707

ACKs for top commit:
jpk68:
ACK db31a3ad1f75538d07707d373adbfbe90ba8e328
hodlinator:
re-ACK db31a3ad1f75538d07707d373adbfbe90ba8e328
hebasto:
ACK db31a3ad1f75538d07707d373adbfbe90ba8e328.

Tree-SHA512: cc73358bb4f1ecaf7246a8803e50ef8b5139bb348094a55dd2d5deb7d4a8d9082a028f342d6dc63d731a441c393739ed41c1039022a7463080830d83e978d34b

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetycredential or privilege statemerge-commit duplicate discount
AI analysis · Moderate 62/100

This change fixes a Windows-specific networking issue in Bitcoin Core. Previously, another program running on the same Windows computer under the same user account could hijack Bitcoin's peer-to-peer network port, potentially intercepting incoming connections meant for the Bitcoin node. The fix makes the listening socket exclusive on Windows, similar to a change already made for the RPC port. Other operating systems are unaffected because their behavior was already safe.

Security candidateMerge bitcoin/bitcoin#36091: test: Add debug output to common tested typesby merge-script · d54844ea · Nov 2, 2026 · 18 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36091: test: Add debug output to common tested types

722d08e03980c359bae4e3b65551d6b8ba615a7a test: Convert `BOOST_CHECK` macros with known debug string (rustaceanrob)
d735b94803a6d6e1ae8a3716a2ca7b1a63e1ca1e test: Add display `operator<<` overloads to `common.{h,cpp}` (rustaceanrob)

Pull request description:

If the `<<` operator exists, boost can use this as a debug output when a check fails (besides `BOOST_CHECK`). This adds `<<` for types commonly used across the unit tests that do not yet have a display output. Each callsite that uses these types are then updated to use macros that will print the debug output on failure. All of these display strings would be used as part of #35713, but we can also use them with boost today.

What this PR does:
- Adds debug output for types used across multiple files, or types that have a clear debug string, and migrates the `BOOST_CHECK` calls. This covers the majority of custom types that did not yet have a debug string.

What this PR does _not_ do:
- Migrate `BOOST_CHECK` callsites for types that already _do_ have a debug output (all primitive type comparisons, `CFeeRate`, etc). This would be a much larger refactor and could perhaps be done after.
- Add debug output for `std::vector<T>` where `T` is streamable. These can be migrated to `BOOST_CHECK_EQUAL_COLLECTIONS`, but is a similar refactor to the one above.
- Add debug output for `std::vector<unsigned char>` and related. Also a large refactor, and could use discussion.
- Add debug output for types that would require a `friend` method in the source code (`ByRatio`)

ACKs for top commit:
maflcko:
review ACK 722d08e03980c359bae4e3b65551d6b8ba615a7a 🍟
ismaelsadeeq:
reACK 722d08e03980c359bae4e3b65551d6b8ba615a7a

Tree-SHA512: 0ee1fdfa354195c87b428705758568843eee16fe72b42263adb2855045a1fe2163f62b8bf62734b0a1ba16411aca0df2348c29f9163e9b004f315fe90b3905b4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's test code. It adds pretty-printing helpers for common data types and updates test assertions to use macros that print more helpful failure messages. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network behavior.

Security candidateMerge bitcoin/bitcoin#36687: test: wait for the node to finish the last block in p2p_ping_ibdby merge-script · 6c01bd0b · Oct 31, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36687: test: wait for the node to finish the last block in p2p_ping_ibd

9af82f9872ca1a9e8d4645c537b23af4bc861ed2 test: wait for the node to finish the last block in p2p_ping_ibd (Greg Sanders)

Pull request description:

ProcessBlock() stamps m_last_block_time only after ProcessNewBlock() returns, so getblockcount can show the new height, with nothing in flight, before the stamp is taken. A bumpmocktime in that gap stamps the block with the bumped time, and the final bump then leaves the ping timeout exactly at its boundary, where it never fires. Sync with a ping after the last block, so the node has finished processing it before the clock moves.

The race has been present since the test was added in #36080.

Faling job:
https://github.com/bitcoin/bitcoin/actions/runs/40589303246/job/122489039018

ACKs for top commit:
mzumsande:
Code Review ACK 9af82f9872ca1a9e8d4645c537b23af4bc861ed2
sedited:
ACK 9af82f9872ca1a9e8d4645c537b23af4bc861ed2

Tree-SHA512: b4f98b6a43ff2f8be2e9fc42be9ab1610bf9e87a93f7edd0fc06b67df096c774021e681c3f7d56730e8c987aaf130ae831347c17dcce1c8a88f35df8cc9a0ba0

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a fix for a flaky automated test, not a security fix for the Bitcoin Core software itself. The test sometimes failed because it moved the simulated clock forward before the test node had fully finished recording the time of the last downloaded block. The patch adds a small synchronization step so the test waits for the node to finish processing before advancing the clock. It does not change production code or fix any vulnerability that could affect real users.

Security candidateMerge bitcoin/bitcoin#35818: bloom: avoid undefined sizing calculationsby merge-script · 71133aec · Oct 31, 2026 · 4 filesMessage 91 · StrongLow 35Details
Commit message · merge-script

Merge bitcoin/bitcoin#35818: bloom: avoid undefined sizing calculations

c4302ddf806094fcc2b1e21593e25b2038191a07 fuzz: cover bloom sizing boundaries (Lőrinc)
3acd9ae9016e6c66783bec002435a49c04050db2 test: cover bloom sizing boundaries (Lőrinc)
77055771169dc44f832083f46468ea75421a009b bloom: avoid undefined sizing calculations (Lőrinc)
3614b38e33cb98528b0c3dc337060f7448bb8e6e test: characterize bloom filter sizing (Lőrinc)

Pull request description:

**Problem:** The four-argument `CBloomFilter` constructor is used by unit tests and the fuzz target to exercise Bloom filter sizing directly.
Zero elements make the hash-function calculation divide by zero.
The size calculation converts its floating-point result to `unsigned int` before applying the protocol limit, which is undefined for zero or invalid false-positive rates and for valid parameters whose calculated size exceeds the integer range.

**Fix:** Require false-positive rates in `[0, 1]`, construct the existing empty match-all state for zero elements, and use the largest permitted filter for a zero rate with positive elements.
Clamp the calculated size before its integer conversion so large valid inputs remain within the protocol limit.

ACKs for top commit:
rustaceanrob:
Code review ACK c4302ddf806094fcc2b1e21593e25b2038191a07
sedited:
ACK c4302ddf806094fcc2b1e21593e25b2038191a07
instagibbs:
ACK c4302ddf806094fcc2b1e21593e25b2038191a07

Tree-SHA512: 836d7a7602b4e508b57bc62fa93bff460a076155ca3973cdde9f0a5bcfc021573a72e8bf2e7477f2c6939074f0b959b6306ab55e929c8e704fab0d0b77734e12

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlfuzzing or regression evidencemerge-commit duplicate discount
AI analysis · Low 35/100

This commit fixes a bug in Bitcoin Core's Bloom filter constructor that could perform undefined math when given unusual inputs, such as zero elements or a zero/invalid false-positive rate. The fix adds input checks and special-case handling so the constructor no longer divides by zero, takes the logarithm of zero, or converts an out-of-range floating-point size to an integer. The affected constructor is used only in tests and fuzzing, not in normal peer-to-peer network code, so the practical risk to live Bitcoin nodes is low.

Security candidateMerge bitcoin/bitcoin#29843: policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)by merge-script · 05187ec2 · Oct 29, 2026 · 8 filesMessage 100 · StrongInformational 22Details
Commit message · merge-script

Merge bitcoin/bitcoin#29843: policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)

1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a doc: add release note for -acceptnonstdtxn changes (Anthony Towns)
1df5910720495eb2e8e453fb40da222dd794424a validation: Add compile-time checks for consensus flags (Anthony Towns)
425115713c5e37e78c9051b1b0a997ad62067ec8 validation: Check only (potential) block script flags when -acceptnonstdtxn is set (Anthony Towns)
703ebdf9de87ffb6010d89e3f0bd49e3c6cdb030 validation: Be explicit about whether CheckInputScripts is for block/mempool (Anthony Towns)
81ef18236fc74913344bd9e28b1e27a50a4e3ae7 tests: test tx rejection for both -acceptnonstdtxn=0 and 1 (Anthony Towns)
9b6342e5d295e337791984af2d42681d9c8e08bb tests: in p2p_segwit, check non-mandatory errors with -acceptnonstdtxn=0 node (Anthony Towns)

Pull request description:

This PR changes `-acceptnonstdtxn=1` so that it also skips the non-mandatory script checks, allowing txs that (eg) use OP_NOPx or OP_SUCCESS into the mempool. This remains only available on test nets.

ACKs for top commit:
fjahr:
reACK 1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a
instagibbs:
reACK 1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a

Tree-SHA512: 6157072c98369d06642bd7383bfabe82a4054a1f204b7a669a90b01429a2104e8815bd20785b11910f1b4d578db11e8a5a71f7f043d1aad083ec120233c9690c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 22/100

This change loosens transaction acceptance rules only on Bitcoin test networks when a special command-line option (-acceptnonstdtxn=1) is used. It lets developers test unusual or experimental scripts in the mempool, while still enforcing all consensus rules that protect real money. Main network behavior is unchanged, and the option is not available there.

Security candidateMerge bitcoin/bitcoin#36676: cli: respect -rpcclienttimeout even when sendingby merge-script · 0f27bed5 · Oct 28, 2026 · 1 fileMessage 91 · StrongLow 34Details
Commit message · merge-script

Merge bitcoin/bitcoin#36676: cli: respect -rpcclienttimeout even when sending

e5d9a7e04b50c723aeb65984e5048ffd098f6737 cli: fail to send a request when the socket does not become writable (Antoine Poinsot)

Pull request description:

The move away from libevent introduced a small regression in this regard. In #36299, we switched the timeout to apply per socket wait, but continued on to another socket wait in case of timeout, instead of returning. See commit message for details.

In general, we also shouldn't ignore `Sock::Wait`'s errors and timeouts by silently retrying forever.

Fix these issues by returning instead when `Sock::Wait` times out or returns an error. ~~Tentative bot functional test for this in second commit that appears to be robust enough.~~

ACKs for top commit:
jpk68:
ACK e5d9a7e04b50c723aeb65984e5048ffd098f6737
l0rinc:
tested ACK e5d9a7e04b50c723aeb65984e5048ffd098f6737
pinheadmz:
ACK e5d9a7e04b50c723aeb65984e5048ffd098f6737

Tree-SHA512: f662e911fbba2d2a97e9d9ba559e8cfd8fd163a08ba8ff812f969c9ea42f0d24d5e013a558a2b488c346f9d5611a2faba0e2ade780ba9b290124fb441ac771ff

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 34/100

This patch fixes a bug in bitcoin-cli (the command-line tool used to talk to a Bitcoin node) where the -rpcclienttimeout setting was not being respected while sending a request. Previously, if the network socket was not ready to send data, the tool would wait, time out, then silently try again in an infinite loop. Now it correctly gives up and reports failure. This is primarily a reliability and user-expectation bug rather than a direct theft-of-funds vulnerability.

Security candidateMerge bitcoin/bitcoin#36678: doc: adapt release notes template to security disclosure policy updateby merge-script · f8c9f2b5 · Oct 28, 2026 · 1 fileMessage 86 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36678: doc: adapt release notes template to security disclosure policy update

ad68edfb92fba7603607a25d21de72c9f3b26fec doc: link to security disclosure policy in release notes template (Antoine Poinsot)
ae658dd8061b7b653cadaf5101fce1b9b2869ce3 doc: adapt release notes template to security disclosure policy update (Antoine Poinsot)

Pull request description:

Following the update to our security disclosure policy in https://github.com/bitcoin-core/bitcoincore.org/pull/1281, adapt the text related to vulnerability disclosures in the release notes empty template.

ACKs for top commit:
instagibbs:
reACK ad68edfb92fba7603607a25d21de72c9f3b26fec

Tree-SHA512: 75237d8c879a839568eda6100282fb76dbe43b94e9740b94850af70558dae9f451f7d60ca7aa5e8bebb42aa7f605376a563d4eb7440bf91a5a0446b8fadb7f63

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagedocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a documentation-only change to the empty release notes template. It updates the wording that describes how Bitcoin Core discloses security vulnerabilities, linking to the project's security policy. No code, no bug fix, no vulnerability is present in this commit.

Security candidateMerge bitcoin/bitcoin#36529: test: measure rpcwaittimeout floor with monotonic timeby merge-script · aa76bd26 · Oct 27, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36529: test: measure rpcwaittimeout floor with monotonic time

dc27539d42bbfc04705d9ae1ea00cf70b046d8fa test: measure rpcwaittimeout floor with monotonic time (nervana21)

Pull request description:

Previously, `interface_bitcoin_cli.py` measured the `-rpcwaittimeout` wait floor with `time.time()`. `bitcoin-cli` arms that deadline with `std::chrono::steady_clock`, so a CI wall-clock step backward can make the elapsed time look short and cause the assert to fail.

Fix this by using `time.monotonic()` instead and using `-rpcwaittimeout=1`. The log line also now says "at least" so it matches the floor assert.

h/t ViniciusCestarii for suggesting `time.monotonic()` here.

ACKs for top commit:
maflcko:
lgtm ACK dc27539d42bbfc04705d9ae1ea00cf70b046d8fa
ViniciusCestarii:
ACK dc27539d42bbfc04705d9ae1ea00cf70b046d8fa

Tree-SHA512: 1213f786d21ce2fa0eb8f08a7c3c381a65dbfec3c4b534516b545e90ca661b0cda84de1482fb41cfe0e53b2a4dabc587f42701e8686b27455591859290c3a855

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit fixes a flaky automated test in Bitcoin Core. The test checks that bitcoin-cli waits at least the requested timeout before giving up when it cannot connect to the server. Previously the test used wall-clock time (time.time()), which can jump backwards if the computer's clock is adjusted, causing the test to fail even though nothing was wrong. The fix switches to monotonic time (time.monotonic()), which only moves forward, and shortens the timeout from 5 seconds to 1 second. There is no change to the actual Bitcoin Core software that users run, only to the test suite.

Security candidateMerge bitcoin-core/gui#955: qt: filter addhdkey from RPC console historyby Hennadii Stepanov · 631b0065 · Oct 27, 2026 · 2 filesMessage 96 · StrongModerate 51Details
Commit message · Hennadii Stepanov

Merge bitcoin-core/gui#955: qt: filter addhdkey from RPC console history

31467d59a5a8e6721af1dc5d6592fad31339bcb9 qt: filter addhdkey from RPC console history (Mateusz Klatt)

Pull request description:

Filters `addhdkey` arguments from RPC console history, consistent with other RPCs that handle private key material.

This prevents extended private keys from being retained in history. It also covers the mnemonic and passphrase inputs proposed in bitcoin/bitcoin#35857.

Adds a parser test verifying that the arguments are redacted.

## Motivation

`addhdkey` accepts a BIP 32 extended private key, but its arguments are currently retained in RPC console history, unlike other RPCs that handle private key material.

The same filter would also protect the mnemonic and passphrase inputs proposed in bitcoin/bitcoin#35857.

## Changes

- Add `addhdkey` to the RPC console sensitive-command filter.
- Add a parser test verifying that its arguments are redacted as `addhdkey(…)`.

## Tests

- `./build_gui/bin/test_bitcoin-qt` — all tests passed, including `RPCNestedTests::rpcNestedTests()`.

ACKs for top commit:
jpk68:
ACK 31467d59a5a8e6721af1dc5d6592fad31339bcb9
hebasto:
ACK 31467d59a5a8e6721af1dc5d6592fad31339bcb9, I have reviewed the code and it looks OK.

Tree-SHA512: e837f2ab0c3073266922fee8a72ab450830a4aa6193996ab7e72222738c8755bc3f073d155fddb827a5271821c3ac11e51053da422e6f09cac91b438d97b5f5e

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialaccess controlmerge-commit duplicate discount
AI analysis · Moderate 51/100

This update stops the Bitcoin Core graphical wallet from remembering the command-line arguments of a sensitive command called addhdkey. Previously, if a user typed addhdkey followed by their extended private key or recovery phrase into the built-in RPC console, that secret material would be saved in the console's command history. Other secret-handling commands were already filtered, but addhdkey was missed. The fix adds it to the same filter and includes a test that confirms the arguments are replaced with a redacted placeholder.

Security candidateMerge bitcoin/bitcoin#36674: Update leveldb subtree to latest masterby Hennadii Stepanov · 15ba4229 · Oct 27, 2026 · 1 fileMessage 81 · StrongInformational 23Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36674: Update leveldb subtree to latest master

e1dfb04fcf21649097b4c2d5cc651f83b9531fd3 Squashed 'src/leveldb/' changes from 53a1914e00..24a446f834 (fanquake)

Pull request description:

Includes:
* https://github.com/bitcoin-core/leveldb-subtree/pull/66

Used in #36623.

ACKs for top commit:
hodlinator:
ACK 8d3d929e4d77532faf25dd0ae3bcfa666e581e89
hebasto:
ACK 8d3d929e4d77532faf25dd0ae3bcfa666e581e89

Tree-SHA512: 829791aaf651787f2b7109ff51704971e30832738337a71705d6ff81c2d99037e2ba1670b3dad25077e3d14e10609a36206521fd773839189cef3f92a0e166ae

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 23/100

This commit removes an unreachable 'return false;' statement from a LevelDB log-reading function. In some build configurations, compilers warn about code that can never execute; removing it silences those warnings and makes the function's actual control flow clearer. The change itself does not alter program behavior in normal operation.

Security candidateMerge bitcoin/bitcoin#36624: test: Enable noban_tx_relay in a few more testsby merge-script · a773e1e3 · Oct 23, 2026 · 43 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36624: test: Enable noban_tx_relay in a few more tests

fa704c5d3cafcd768982a02c48c7c7d96d667fa1 test: Use faster noban_tx_relay in mempool tests (MarcoFalke)
fa6f7e36a8c27d8d4824c4dbec45abd405388abe test: [doc] Clarify noban_tx_relay comment (MarcoFalke)
faf2e3aba59b8023d84f09a68cc946f1ed3f526a test: Use proper noban permission for faster tx relay (MarcoFalke)

Pull request description:

For https://github.com/bitcoin/bitcoin/issues/19732 (see commit msgs for details)

ACKs for top commit:
ViniciusCestarii:
ACK fa704c5d3cafcd768982a02c48c7c7d96d667fa1
brunoerg:
ACK fa704c5d3cafcd768982a02c48c7c7d96d667fa1

Tree-SHA512: fa6906b4ef0a921fc321db6784173c2c0461e90b19d3a058cd5ac93e6ac953bfc75131740c534b18c133dd815a2d80f8846f3feed721457c30995bcfc0157472

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
credential or privilege statesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal functional test suite. It replaces manual '-whitelist=noban@127.0.0.1' settings and verbose comments with a shared test flag called 'noban_tx_relay' to make automated tests run faster. There is no change to the actual Bitcoin node software that users run, and no security vulnerability is introduced or fixed.

Security candidatetest: [doc] Clarify noban_tx_relay commentby MarcoFalke · fa6f7e36 · Oct 23, 2026 · 39 filesMessage 90 · StrongInformational 15Details
Commit message · MarcoFalke

test: [doc] Clarify noban_tx_relay comment

The comment is verbose and there are many whitelist permissions like
`relay` or `mempool`, but this applies `noban` to in- and out-
connections.

A brief `self.noban_tx_relay = True # faster tx relay` covers the same
meaning with less confusion.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
credential or privilege statesigning or wallet path
AI analysis · Informational 15/100

This commit only rewrites comments in Bitcoin Core's test suite. It replaces longer explanations about whitelisting peers with a shorter note that the setting is used for faster transaction relay. No actual code behavior changes, so it has no security impact.

Security candidatetest: Use proper noban permission for faster tx relayby MarcoFalke · faf2e3ab · Oct 23, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · MarcoFalke

test: Use proper noban permission for faster tx relay

A plain -whitelist=noban@127.0.0.1 misses the out connections.

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
credential or privilege statesigning or wallet path
AI analysis · Informational 15/100

This is a minor test-only change in Bitcoin Core's functional test suite. It replaces a manual whitelist flag with a built-in test framework option that achieves the same goal for both incoming and outgoing peer connections. There is no change to production code, no security fix, and no vulnerability.

Security candidateMerge bitcoin/bitcoin#36581: subprocess: fix command line memory leak on Windowsby merge-script · 2cd1db40 · Oct 22, 2026 · 1 fileMessage 93 · StrongInformational 24Details
Commit message · merge-script

Merge bitcoin/bitcoin#36581: subprocess: fix command line memory leak on Windows

cf30d0a4123bb4237495f04e723ce9f706c2edf2 subprocess: fix command line memory leak on Windows (stickies-v)

Pull request description:

`Popen::execute_process()` copied the command line into a buffer from `new[]`, but did not delete it. This leaked memory each time a process started on Windows.

`CreateProcessA` [needs](https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa#:~:text=characters%2E-,The,violation) a writable command line buffer. Since C++17, `std::string::data()` supplies one, so give the `std::string` buffer directly and remove the copy.

This only affects Windows. It is only reachable if `-signer=<cmd>` is set, through authenticated RPC or the GUI. Each call leaks only the startup-defined `<cmd>`, and the rate is limited by process spawn time, so the impact is limited.

_edit: this was fixed upstream in https://github.com/arun11299/cpp-subprocess/pull/131, but since this codebase is C++20 it seems better to avoid the copy (and the const cast). A direct backport isn't possible anyway, since #35704 switched us to CreateProcessA._

ACKs for top commit:
jpk68:
ACK cf30d0a4123bb4237495f04e723ce9f706c2edf2
hebasto:
re-ACK cf30d0a4123bb4237495f04e723ce9f706c2edf2.
winterrdog:
reACK cf30d0a4123bb4237495f04e723ce9f706c2edf2

Tree-SHA512: 873a5b69e4094dfc1cba0f822af1e431f7d6e29f2fac58e0712ffa060296022db0cbff55ab6f7a4416168e4958bcaa1567ad568f2a3a662e3cb4603bbb786816

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 24/100

This commit fixes a small memory leak in Bitcoin Core on Windows. When starting an external signer program, the code previously copied the command string into a freshly allocated buffer but never freed it. The fix passes the string's own buffer directly to Windows, eliminating both the copy and the leak. The leak only occurs when an optional external signer is configured, and each leak is tiny (just the command string), so the practical security impact is very low.

Security candidateMerge bitcoin/bitcoin#36457: Test: Cover malformed merkle trees and nBitsby merge-script · 316ea328 · Oct 21, 2026 · 2 filesMessage 91 · StrongInformational 14Details
Commit message · merge-script

Merge bitcoin/bitcoin#36457: Test: Cover malformed merkle trees and nBits

0c0e6ba0167e9397e521ba3cbc7a4779ad7518b7 Test: Cover malformed merkle trees and nBits (benthecarman)

Pull request description:

Add tests for malformed partial merkle trees, including the transaction count limit at its 16666 boundary, and for `GetBitsProof` returning zero for zero, negative and overflowing targets.

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/36457/commits/0c0e6ba0167e9397e521ba3cbc7a4779ad7518b7

Tree-SHA512: 5d44cef07d121e92e298c23fbda283a48ed92b460c557cf789fa5e6f7c67534f6f99109a6b31c8fdecc5db6851fee5a85c78af5ad9a487b788b37821ebb335a4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 14/100

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot introduce a runtime vulnerability or directly fix one. The tests exercise how the software rejects malformed partial Merkle trees and how it handles unusual proof-of-work target values. The pull request description says the test ideas came from comparing against another implementation (bitcoin-s), but the commit itself is purely additional test coverage.

Security candidateMerge bitcoin/bitcoin#36509: refactor: remove more dead codeby merge-script · d3c3871b · Oct 21, 2026 · 35 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36509: refactor: remove more dead code

570c4a184f49b6d71bc581ae694b969a91cf2510 build: enable -Wunused-macros & -Wunused-template (fanquake)
7981e61764474d914ad7808cac939b821c854495 test: remove unused equal from check_equal() (fanquake)
e8a70c0c68874b153cf02f0b49269ad40302f850 qt: remove unused WalletController::m_options_model (fanquake)
2e23a5b1f1602fb9ff5f6cf659cf1d30c5576dab qt: remove unused AddressBookPage::sendCoins signal (fanquake)
18a5e90179dd0b70b73bef82c0a7aca8c7770f23 qt: remove unused ClientModel::getNumBlocks and its cache (fanquake)
3a3e0ced8c1618f21b662b79902c05df4dc3297a qt: remove unused BitcoinAmountField::setReadOnly (fanquake)
f226197c0015108b3d0f3fd6a3d068275aacefd5 qt: remove unused BitcoinAmountField::SetMaxValue (fanquake)
92ad4ad4042f6ed8b20abe408e713d5e6eea7230 qt: remove unused removeAllWallets (fanquake)
4881802c3f6088f284923003d57ecc7c8a409c41 qt: remove stale PeerTablePriv forward declaration (fanquake)
3f40af467271177abad96426092c03cbb2e231d2 fuzz: remove unused FuzzedWallet::GetScriptPubKey (fanquake)
fc21d18741130aacca21289304da9b6a22eca768 qt: remove unused COLOR_BLACK (fanquake)
830a95548a444a3f1fe86bc26881b290382a5a23 refactor: remove unused ScriptHash(const CScriptID&) constructor (fanquake)
d6ffa22e287a593aec0669860f0b61a9bdaa9262 fuzz: remove unused MockedDescriptorConverter::IdIsXpub (fanquake)
664c2f4600d87cd94100ff03a29cf8178704a678 logging: remove unused Logger::AddCategoryLogLevel (fanquake)
fb7a3aef1bc89cf26af7fee6d5425c3d0689a059 addrman: remove unused AddrMan::Unserialize(AutoFile&) instantiation (fanquake)
54fe34c6b32def9d94692e8f74d56ed12f1acd9d policy: remove unused EXTRA_DESCENDANT_TX_SIZE_LIMIT (fanquake)
71f598018bc8101aaa9f7f496289e43437ea9266 refactor: remove unused BinarySemaphoreGrant alias (fanquake)
a781e4828983b4038fe8c5d98a097d8ade2853dc qt: remove unused TrafficGraphWidget::getGraphRange (fanquake)
8a8a46d7b6164981363dbb185db3a895f4193078 qt: remove unused OptionsDialog::proxyIpChecks signal (fanquake)
2fecbfd1e159f2a5eae6ec8a97da3684ef617110 qt: remove unused QValueComboBox::setRole (fanquake)
50fb338f94e46686d16cc36bfd55fb57d5f116c7 qt: remove unused ClientModel::isReleaseVersion (fanquake)
101345feaa0043caeb79b55f5a6354d85a7b0183 script: remove unused FillableSigningProvider::GetCScripts (fanquake)
5eddbb45c2ad9a293ea0cb796189b794293bc887 ipc: remove unused FooImplementation::passBlockState (fanquake)
159596418166e397fafdbf1e1a090ef0578afd18 test: remove unused GetMockableDatabase declaration (fanquake)
98136193f6b75b82facfda90b46c9d99e0e82932 kernel: remove unused MemPoolLimits::NoLimits (fanquake)
d7c16aa057ecce0743ce2cd79bebf74f757b2dba netbase: remove unused Proxy::GetFamily (fanquake)
d28d1a980999f346eb1994e361c0ecc0dd081d06 span: remove unused MakeWritableUCharSpan (fanquake)

Pull request description:

Part of #36167.

ACKs for top commit:
stickies-v:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510
sedited:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510

Tree-SHA512: 2249fe91098006228006b30e4c18b204fb5d6dfefea8d175a2d8ea45409220df5c62c6618125b69e8af3b4f775269c11cf424a429cc3fe93629e961420f8eeec

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundaryaccess controlfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup that removes unused code, unused compiler warning flags, and stale declarations from Bitcoin Core. None of the changes alter active behavior, fix bugs, or introduce security-sensitive logic. It is purely a refactoring and build-hygiene change.

Security candidateMerge bitcoin/bitcoin#36339: wallet: avoid int overflow in listtransactionsby merge-script · 3983b582 · Oct 19, 2026 · 2 filesMessage 96 · StrongHigh 74Details
Commit message · merge-script

Merge bitcoin/bitcoin#36339: wallet: avoid int overflow in listtransactions

9cff82fd5b15bc2aa2c7778b61212876433a8219 wallet: avoid int overflow in listtransactions (Kanan)

Pull request description:

`listtransactions` adds `count` and `skip` as `int`. Each one is checked to be non-negative, but their sum can still go past INT_MAX:

```
bitcoin-cli -regtest listtransactions "*" 2147483647 1
```

On master this crashes the node. The overflowed sum is negative, so the loop stops after the first entry. The clamp after the loop overflows the same way and doesn't fix `nCount`, so `push_backV` gets an iterator range about 2^31 elements before `rend()`. UBSan reports `signed integer overflow: 1 + 2147483647` at transactions.cpp:584, and ASan then reports a BUS error in `UniValue::push_backV`.

This parses `count` and `skip` as `uint32_t` through `self.Arg` (which also handles the defaults and rejects negative values, so the manual checks go away) and adds them up in 64 bits, where the sum can't overflow. The functional test calls `listtransactions` with count + skip above INT_MAX and up to UINT32_MAX and checks the results match a normal-sized request. It times out on master (the node crashes) and passes with the fix. I also ran it on an ASan/UBSan build.

`listrawtransactions` counts differently and isn't affected.

ACKs for top commit:
maflcko:
lgtm ACK 9cff82fd5b15bc2aa2c7778b61212876433a8219
sedited:
ACK 9cff82fd5b15bc2aa2c7778b61212876433a8219

Tree-SHA512: 0068951efb724cf5551238de1c6b5d254b66594f9fe8878cf5bb49026e1624a8db6dc87eee23dfed38fc7620cef2933817e82ceb7f8072f8f89911f50af2e607

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetysigning or wallet pathmerge-commit duplicate discount
AI analysis · High 74/100

This patch fixes a bug in Bitcoin Core's `listtransactions` RPC command. When a user asked for a very large number of transactions plus a large skip value, the wallet code added two integers together and overflowed, producing a negative number. That negative number was then used as a memory range, causing the node to crash. The fix reads the values as unsigned 32-bit integers and adds them in 64-bit arithmetic so the sum cannot overflow, and removes the now-redundant manual negative checks.