Bitcoin Core

This is a test-only cleanup in Bitcoin Core's functional test suite. It fixes how temporary 'block template' objects are cleaned up during an automated test by using Python context managers. The old code called destroy routines but forgot to 'await' them, so cleanup happened later by garbage collection instead of immediately. There is no change to the actual Bitcoin node software, no security vulnerability in production code, and no attacker-accessible behavior changed.

This commit fixes a bug in a Bitcoin Core functional test, not in the actual Bitcoin network code. The test was accidentally creating the same transaction twice and putting fees on the wrong transaction, so it wasn't really testing what it was supposed to test. The fix makes the test exercise the intended cluster-size-limit enforcement behavior correctly. There is no security issue in production software here.

This commit is a code cleanup that replaces old-style 'count the number of matching entries' checks with newer, clearer 'does this container contain the key' checks. It does not change program behavior, fix a bug, or address a security issue. It is purely a readability and maintainability improvement.

This commit is a pure code cleanup: it replaces older-style container lookups like `m.count(k)` with the newer, clearer `m.contains(k)` across many files. The behavior is identical, so there is no security impact.

This commit is a pure code cleanup: it replaces verbose 'find ... == end()' checks with the simpler 'contains()' method on C++ containers. There is no change in behavior, no bug fix, and no security impact.

This is a small fix to a developer helper script that generates manual pages for Bitcoin Core command-line programs. A previous change caused the script to grab the wrong word from the program's version output, so it could not build the man pages. The patch uses a regular expression to reliably find the version string. It does not change any network, wallet, or consensus code and has no security relevance.

This Bitcoin Core commit changes when and how the node warns users about a potentially serious problem: an invalid blockchain that has more work than the node's own best chain. Previously, the warning was skipped while the node was still downloading the blockchain for the first time (Initial Block Download, or IBD). Now it also runs at startup and during IBD. The wording is also made more neutral, mentioning both database corruption and consensus incompatibility as possible causes, instead of assuming corruption. This is a diagnostic/logging improvement, not a fix for an exploitable vulnerability.

This commit only adds a clearer warning message in the log when Bitcoin Core receives block headers for blocks it has already marked as invalid. It does not change how blocks are validated, accepted, or rejected. The goal is to help users diagnose database corruption or consensus incompatibility that can cause an endless 'headers sync' loop, not to fix a security vulnerability.

This commit simply removes an unused dependency import. A previous change added the Tcl programming language package to the Guix build manifest, but it turned out SQLite did not actually need it. This revert cleans up the build configuration with no effect on Bitcoin Core's runtime security.

This commit fixes a build-system issue in Bitcoin Core's dependency packaging for SQLite. It ensures the correct native C compiler is passed through when SQLite's build tool (autosetup) needs to compile a small local helper program called jimsh0. It also quotes that compiler variable so paths with spaces or multiple flags don't get split incorrectly. This is a build reliability fix, not a vulnerability in Bitcoin's network code or wallet cryptography.

This commit only updates documentation. It adds a warning to Bitcoin Core's JSON-RPC guide explaining that anyone with valid RPC credentials effectively has significant control over the node and the underlying machine, and that RPC whitelists should not be treated as a strong security boundary. No code behavior was changed.

This commit only adds a new automated test to Bitcoin Core. It checks that wallet backups can (or cannot) be loaded on pruned nodes that are using the assumeutxo snapshot feature. There is no change to production wallet, consensus, or networking code, so it does not introduce or fix a live security issue on its own.

This commit is a minor cleanup of a Bitcoin Core test file. It moves existing snapshot-import and background-validation checks into new helper functions without changing what the test actually verifies. There is no change to production code, no security fix, and no vulnerability.

This change adds a warning when users import a Bitcoin wallet descriptor containing an 'older()' time or block lock that looks safe but actually has no consensus effect. Because of how Bitcoin encodes relative locktimes, values above 65535 silently wrap around: older(65536) behaves like older(1). Someone could accidentally create a wallet that unlocks far sooner than they think. The patch does not block the import; it only warns.

This commit adds extra internal consistency checks to Bitcoin Core's memory pool validation routine and turns some soft 'Assume' warnings into hard 'assert' failures. It does not change network rules or how transactions are accepted; it only makes the program crash more reliably if its own bookkeeping about transaction fees and weights becomes internally inconsistent. That helps developers catch bugs during testing but is not a fix for an externally exploitable vulnerability.

This commit only adds a code comment explaining that a function returns results in a deterministic order. No code behavior was changed, so it cannot introduce or fix a security issue on its own.

This commit only changes two comment lines in a header file. It renames 'descendants' to 'cluster_count' in documentation to match what the code actually calculates. No executable code, logic, or behavior was changed, so there is no security impact.

This commit changes a single word in a code comment, replacing 'chain' with 'cluster count' to accurately describe what the following code checks. It does not alter any program logic, behavior, or security properties.

This commit changes two Bitcoin Core functions that enforce special rules for a new type of transaction called TRUC. Previously, one function locked the memory pool (mempool) itself. Now both functions require their callers to already hold the mempool lock. This is a defensive coding change that makes it explicit who is responsible for thread safety, but it does not by itself fix a known exploitable bug.

This is a one-word documentation fix in a Bitcoin Core RPC help message. The error message shown when a user provides an invalid transaction ID now says 'txid' instead of 'parameter 1'. There is no security impact.

This commit renames a single field in a Bitcoin Core RPC output from 'weight' to 'clusterweight' and adds documentation explaining mempool fee/size terminology. It is a user-facing clarity/documentation change with no security-relevant code behavior change.

This commit changes the format of a Bitcoin Core RPC command called getmempoolcluster so it groups transactions into 'chunks' rather than listing each transaction separately. It also adds a clearer error message when the requested transaction is not in the memory pool. The change is a user-facing output improvement, not a fix for a security vulnerability.

This is a small internal cleanup in Bitcoin Core's memory pool (mempool) code. It changes how transaction fee adjustments are updated, removing an unnecessary wrapper and making a fee field directly mutable. There is no indication this fixes a security bug; it appears to be a refactoring or simplification after an earlier data structure change removed fee-based indexes.

This commit only adds a release notes document describing a previously implemented mempool redesign called 'cluster mempool.' It contains no code changes, no bug fixes, and no security-related disclosures. It is purely documentation.

This commit only changes documentation. It adds a new design document explaining Bitcoin Core's cluster mempool concept, renames a link in the policy README, and deletes an older document about mempool limits. No code, configuration, or behavior is modified. There is no security issue in this change.