What the developer wrote
Authored by Hennadii Stepanov
qa: Fix Windows logging bug
The regex `(.*)` was capturing `\r` from subprocess output on Windows,
causing the closing parenthesis in logs to wrap to the next line.
Stripping whitespace from the regex match fixes the formatting.
What changed, and why it matters
This is a tiny formatting fix in Bitcoin Core's test runner. On Windows, the test output includes a hidden carriage-return character ('\r') that was making the closing parenthesis in log messages appear on a new line. The patch simply trims whitespace from the captured text so the log looks tidy. It does not change any network, wallet, consensus, or node behavior.
No security action needed. Treat as a normal QA/test-harness cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In test/functional/test_runner.py, the TestHandler parses a skipped test’s stdout with the regex Test Skipped: (.*). On Windows, stdout lines end with CRLF (\r\n), so group(1) captured the skip reason plus a trailing \r. That \r caused the subsequent closing parenthesis in the formatted log to wrap to the next line. The fix appends .strip() to remove surrounding whitespace, including \r and \n. This is purely a test-logging cosmetic change.
Changed components
test/functional/test_runner.pyInspect captured patch +1 / −1
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 425205b3..3a2ad7dd 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -809,7 +809,7 @@ class TestHandler:
status = "Passed"
elif proc.returncode == TEST_EXIT_SKIPPED:
status = "Skipped"
- skip_reason = re.search(r"Test Skipped: (.*)", stdout).group(1)
+ skip_reason = re.search(r"Test Skipped: (.*)", stdout).group(1).strip()
else:
status = "Failed"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.