Bitcoin Core

This commit fixes a long-standing mistake in how Bitcoin Core reports an error when an OP_IF command is used without enough values on the script stack. In one specific spot, the wrong error code was returned for 11 years. The fix makes the error code consistent with every other similar case. This is a minor correctness/observability fix, not a vulnerability that lets an attacker steal funds or crash nodes.

This is a small performance cleanup, not a security fix. Bitcoin Core was doing unnecessary work—calculating a block hash and adding up transaction byte sizes—every time it reconstructed a compact block, even when the relevant debug logging was turned off. The change simply skips that work when debug logging is disabled. The log output is unchanged when logging is on, and no network behavior or consensus rules change.

This is a performance cleanup, not a security fix. A Bitcoin Core network function was doing unnecessary serialization work to calculate transaction byte sizes for a debug log line, even when debug logging was turned off. The change wraps that work in a check so it only runs when the relevant debug log category is actually enabled. There is no behavior change for users and no vulnerability is described or evident in the diff.

This commit is a simple rename-only code cleanup. It changes the name of a transaction size method from GetTotalSize to ComputeTotalSize to make it clear the size is recalculated each time rather than stored. No behavior, logic, or security properties change.

This commit tightens the bitcoin-wallet command-line tool so it can no longer create a wallet without an explicit name. Previously, the tool allowed creating an unnamed wallet in some situations, which could lead to confusion or accidental wallet files being placed in unexpected locations. The change adds clear error messages and tests to ensure the tool refuses to create unnamed wallets for both regular creation and creation from a dump file.

This Bitcoin Core change stops users from creating or restoring wallets with an empty name through the normal RPC commands. Empty wallet names could cause confusion or unexpected behavior, so the patch now rejects them with a clear error. The only exception is during wallet migration, where an existing unnamed wallet is allowed to be restored. The change is a hardening fix, not a response to an active exploit.

This is a purely cosmetic change to the project's code formatting configuration file. It tells the clang-format tool to treat project header files included with angle brackets (like <signet.h>) as 'main headers' so they stay at the top of include lists. There is no functional code change and no security impact.

This commit only adds a comment explaining why a particular code header must be kept. It does not change any program logic, data handling, or security behavior. There is no security issue here.

This commit only updates the project's developer documentation. It adds a new section explaining how to use a code-quality tool called 'include-what-you-use' (IWYU) and links it from an existing style rule. No program code was changed, so it cannot introduce a security vulnerability or fix one.

This is a code cleanup change about which C++ header files include other header files. It removes an 'export' annotation from an internal header so that tools checking include correctness no longer treat it as publicly re-exported. There is no functional change to Bitcoin's behavior and no security relevance.

This is a code-cleanup change that removes 'export' markers from two C++ header files. It tells the compiler's include-what-you-use tool not to force other files to automatically pull in <string> and <string_view> just because they include these utility headers. There is no security impact.

This commit simply bumps three GitHub Actions dependencies to newer major versions in the project's automated CI workflow file. There is no code change to Bitcoin Core itself, no bug fix, and no security patch. It is a routine maintenance update to keep CI tooling current.

This commit fixes the `uptime` RPC command in Bitcoin Core so it no longer jumps around when the system clock or mock time is changed. Previously, uptime was calculated by subtracting the startup wall-clock time from the current wall-clock time, so a large NTP adjustment or `setmocktime` call could make the node appear to have been running for thousands of seconds instantly, or even report a negative uptime. The change uses a monotonic clock that only counts real elapsed time. It is a correctness/reliability fix, not a direct theft-of-funds vulnerability.

This commit fixes a typo in a code comment. It changes 'contains' to 'contain' and the comment marker from two slashes to three slashes. There is no change to actual program code, so it cannot affect security or functionality.

This commit is a pure code reorganization: it merges the contents of two source files (core_read.cpp and core_write.cpp) into a single new file (core_io.cpp) and updates build scripts accordingly. No program behavior changes, no security fixes, and no vulnerability is introduced.

This commit simply removes three source files from the list used to build the Bitcoin Core kernel library, because they are no longer needed there. It is a routine cleanup change with no security relevance.

This commit adds a small helper function called TicksSeconds that converts a time duration into whole seconds, along with a few unit tests. It is a routine code cleanup/refactoring change with no security relevance.

This commit only adds new test cases to an existing Bitcoin Core functional test file. It checks that sending multiple transactions to the same address correctly sums the received amount, and that an invalid address string produces a proper error. There is no change to production wallet code, no bug fix, and no security-relevant behavior change.

This commit is a straightforward code cleanup in Bitcoin Core's wallet loading logic. It replaces a long chain of 'if/else if' checks with a 'switch' statement that handles the same set of wallet database error codes. No behavior changes are visible in the diff, and no security issue is introduced or fixed.

This is a simple code cleanup change. It moves where a wallet setting called -walletbroadcast is read from the command-line/config into the wallet object. Previously it happened inside a locked section; now it happens earlier with other similar settings. The commit message explicitly says this does not require locks and is just relocating initialization. There is no security issue visible in the change.

This commit is a straightforward internal code cleanup in Bitcoin Core's wallet module. It moves the code that translates database load errors into user-facing error and warning messages from two separate callers into the single function that actually loads the wallet data. There is no change to what errors are detected, what messages are shown, or how the wallet behaves when problems occur.

This commit is a routine code-quality cleanup. It adjusts which C++ header files are included in several source files under src/kernel and tells the continuous-integration system to treat missing-header warnings in that directory as errors. There is no change to program logic, no bug fix, and no security-relevant behavior.

This is a minor code cleanup in a helper script that checks Git commit signatures. It replaces several verbose file-reading instructions with shorter, equivalent ones using Python's pathlib module. There is no security-relevant change.

This commit removes a special exception list that let one specific old commit be verified using the older, weaker SHA-1 algorithm. The exception is no longer needed, so the code now treats all commits consistently under the stronger SHA-512 verification rules. By itself, this is a cleanup that slightly tightens the project's commit-verification script; it is not a fix for an active security bug in Bitcoin Core's network code or wallet.

This commit is a minor code cleanup inside a fuzz test (automated randomized testing) for Bitcoin's header synchronization logic. It replaces a manual check that skipped invalid mock times with a built-in minimum-time option in the test helper. There is no change to production Bitcoin node code, no user-facing behavior change, and no security fix.