BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 35 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36616: test: keep noban_tx_relay config after node is restartedby merge-script · df0dc1e2 · Oct 23, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36616: test: keep noban_tx_relay config after node is restarted

b469ff8fddb6594b69d564cca436b7baa8ed99bb test: keep noban_tx_relay config after node is restarted (ViniciusCestarii)

Pull request description:

When a node restarts with extra_args it loses its original extra_args, so the `-whitelist=noban,in,out@127.0.0.1` set by `noban_tx_relay` is lost and the node falls back to the normal tx relay delays.

This changes `noban_tx_relay` to set `whitelist=noban,in,out@127.0.0.1` in `extra_confs` instead, so it is kept across restarts.

This speeds up some tests (running locally `build/test/functional/test_runner.py -j=18 --randomseed=1`):

mempool_ephemeral_dust.py 49s -> 18s
mempool_accept_wtxid.py 17s -> 6s
wallet_fundrawtransaction.py 11s -> 7s

Accumulated 1152s -> 1110s
Wall 80s -> 75s

ACKs for top commit:
maflcko:
lgtm ACK b469ff8fddb6594b69d564cca436b7baa8ed99bb
brunoerg:
code review ACK b469ff8fddb6594b69d564cca436b7baa8ed99bb

Tree-SHA512: 7a8a3e165eab181f85ed91dde4e1648553783b293ebc42bc0135e0f206cffb41d1a533e32000b0dfcb771fa75677705b515d3f3fe0537248c06a43aead6d92e2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedtest: construct transaction_tests test_Get inputs/outputs declarativelyby Alexander Wiederin · bdf58dd8 · Oct 23, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Alexander Wiederin

test: construct transaction_tests test_Get inputs/outputs declaratively

Replace the field-by-field construction of the inputs and outputs with
COutPoint, CTxIn and CTxOut constructor calls.

The second output was previously only created by vout.resize(2) and
never assigned, leaving it null (nValue = -1). It is kept as a
default-constructed CTxOut so the transaction is unchanged.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor cleanup of a unit test file in Bitcoin Core. It replaces verbose, field-by-field construction of test transaction inputs and outputs with shorter declarative constructor calls. The behavior of the test is intentionally unchanged: the second transaction output remains default-constructed, just as it was before when it was created by resize(2) but never assigned. There is no change to production code, network behavior, or wallet handling.

Lower-prioritybench: construct ccoins_caching inputs/outputs declarativelyby Alexander Wiederin · 24d00c45 · Oct 22, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Alexander Wiederin

bench: construct ccoins_caching inputs/outputs declaratively

Replace the field-by-field construction of the inputs and outputs in
CCoinsCaching with COutPoint, CTxIn and CTxOut constructor calls.

The second output was previously only created by vout.resize(2) and
never assigned, leaving it null (nValue = -1). It is kept as a
default-constructed CTxOut so the transaction is unchanged.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritytest: keep noban_tx_relay config after node is restartedby ViniciusCestarii · b469ff8f · Oct 22, 2026 · 1 fileMessage 72 · AdequateTriage 0Details
Commit message · ViniciusCestarii

test: keep noban_tx_relay config after node is restarted

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI review queuedMerge bitcoin/bitcoin#35395: doc: Improve test suite dependencies documentationby merge-script · 152a5539 · Oct 22, 2026 · 7 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35395: doc: Improve test suite dependencies documentation

22230f49f02b99be7077d6c52a775c322049903c doc: Unify Python optional module and test dependency documentation (Hennadii Stepanov)
39502b49b27ace1ffd27e9c5a28c8a97673b69c7 doc: Improve Python UTF-8 mode note (Hennadii Stepanov)
b51979ea7f6f39c0e22ef722557da7a35657f26f doc: Fix header formatting in `test/README.md` (Hennadii Stepanov)

Pull request description:

The current documentation has multiple issues:
1. OS-specific notes are missing for the `pycapnp` module.
2. `python3-zmq` is a package name in some Linux distros, rather than a Unix-wide convention.
3. Installing `pyzmq` from PyPI works in general, not only on macOS.

This PR resolves these issues. Additionally, two minor improvements have been added (see commit messages).

ACKs for top commit:
maflcko:
review ACK 22230f49f02b99be7077d6c52a775c322049903c 🎙
sedited:
ACK 22230f49f02b99be7077d6c52a775c322049903c

Tree-SHA512: 5c4eb3bde40594cddaa1ca4983f9c04de87d11c4ea7d3978eeeceec279cd45a2b689b4b2f163eb3592f14f22db128592fee84e126026e30ecff7299820227650

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only updates documentation. It reorganizes instructions for installing Python test-suite dependencies across operating systems and consolidates them into a single README file. No program code was changed, so it cannot directly affect security or introduce vulnerabilities.

Security candidateMerge bitcoin/bitcoin#36581: subprocess: fix command line memory leak on Windowsby merge-script · 2cd1db40 · Oct 22, 2026 · 1 fileMessage 93 · StrongInformational 24Details
Commit message · merge-script

Merge bitcoin/bitcoin#36581: subprocess: fix command line memory leak on Windows

cf30d0a4123bb4237495f04e723ce9f706c2edf2 subprocess: fix command line memory leak on Windows (stickies-v)

Pull request description:

`Popen::execute_process()` copied the command line into a buffer from `new[]`, but did not delete it. This leaked memory each time a process started on Windows.

`CreateProcessA` [needs](https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa#:~:text=characters%2E-,The,violation) a writable command line buffer. Since C++17, `std::string::data()` supplies one, so give the `std::string` buffer directly and remove the copy.

This only affects Windows. It is only reachable if `-signer=<cmd>` is set, through authenticated RPC or the GUI. Each call leaks only the startup-defined `<cmd>`, and the rate is limited by process spawn time, so the impact is limited.

_edit: this was fixed upstream in https://github.com/arun11299/cpp-subprocess/pull/131, but since this codebase is C++20 it seems better to avoid the copy (and the const cast). A direct backport isn't possible anyway, since #35704 switched us to CreateProcessA._

ACKs for top commit:
jpk68:
ACK cf30d0a4123bb4237495f04e723ce9f706c2edf2
hebasto:
re-ACK cf30d0a4123bb4237495f04e723ce9f706c2edf2.
winterrdog:
reACK cf30d0a4123bb4237495f04e723ce9f706c2edf2

Tree-SHA512: 873a5b69e4094dfc1cba0f822af1e431f7d6e29f2fac58e0712ffa060296022db0cbff55ab6f7a4416168e4958bcaa1567ad568f2a3a662e3cb4603bbb786816

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 24/100

This commit fixes a small memory leak in Bitcoin Core on Windows. When starting an external signer program, the code previously copied the command string into a freshly allocated buffer but never freed it. The fix passes the string's own buffer directly to Windows, eliminating both the copy and the leak. The leak only occurs when an optional external signer is configured, and each leak is tiny (just the command string), so the practical security impact is very low.

Lower-priorityMerge bitcoin/bitcoin#36599: test: Fix intermittent timeout waiting for ibd_wtxid getdataby merge-script · f655a8df · Oct 22, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36599: test: Fix intermittent timeout waiting for ibd_wtxid getdata

7777598f87ea524721cf7dcc61517ca988df61aa test: Fix intermittent timeout waiting for ibd_wtxid getdata (MarcoFalke)

Pull request description:

Fix https://github.com/bitcoin/bitcoin/issues/36595

diff to repro:

```diff
diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
index 128f14a6d5..92e1fad22e 100644
--- a/src/validationinterface.cpp
+++ b/src/validationinterface.cpp
@@ -168,2 +168,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
LOG_EVENT("%s", local_log_msg); \
+ UninterruptibleSleep(99ms);\
local_event(); \
```

ACKs for top commit:
Naomi-Gift:
tACK 7777598f87ea524721cf7dcc61517ca988df61aa
mercie-ux:
ACK 7777598f87ea524721cf7dcc61517ca988df61aa

Tree-SHA512: ff790d7efdf083a1e7b46989869b62b5bbf0da76f0c7d4b3640eec790eb5bf2defdbb9a4ecd085d9d95029b45a59189ca08d22ebfa7714fc529ec056614e491a

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36456: Test: Cover malformed and truncated tx encodingsby merge-script · 2034d307 · Oct 22, 2026 · 2 filesMessage 91 · StrongInformational 12Details
Commit message · merge-script

Merge bitcoin/bitcoin#36456: Test: Cover malformed and truncated tx encodings

10f7cf848792b040bb3d1393598250c71c5700e0 Test: Cover malformed and truncated tx encodings (benthecarman)

Pull request description:

Check that every strict prefix of a witness transaction fails to deserialize, and that a witness flag of 0x02, which skips the witness section, is rejected as unknown optional data. Also check that CompactSize prefixes missing some of the bytes they announce fail to read.

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

ACKs for top commit:
darosior:
ACK 10f7cf848792b040bb3d1393598250c71c5700e0

Tree-SHA512: 997ccb4b04269d991035bb71ca2e3cbe7cfad1481b399d5456e99521eb10f064762533fbc9afa98a7aaecf6364b25f09931b58de7a413f07638a63f29d722c85

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot directly introduce or fix a security vulnerability in running software. The tests verify that malformed and truncated transaction data is rejected properly, which helps ensure existing protections keep working.

Lower-priorityMerge bitcoin/bitcoin#36590: doc: archive release notes for v32.0by merge-script · 3eca8982 · Oct 22, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36590: doc: archive release notes for v32.0

be322f6f50a06f048086e52aaf7a189673faa99c doc: archive release notes for v32.0 (fanquake)

Pull request description:

ACKs for top commit:
willcl-ark:
ACK be322f6f50a06f048086e52aaf7a189673faa99c

Tree-SHA512: 8db476bd2b686d0d6d05a5a92e74cc18ee409c6403607f0a9a1bcc11f47327205a701fdab467ae92e5206ff765b6c92ebcde19b10f426ba2e7514ebace22f59c

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36465: Test: Add P2SH scriptSig stack-size boundary testsby merge-script · de96f3ae · Oct 21, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36465: Test: Add P2SH scriptSig stack-size boundary tests

5a4cd70547096af6247167d8dde6145a1b548642 Test: Add P2SH scriptSig stack-size boundary tests (benthecarman)

Pull request description:

VerifyScript runs a P2SH scriptPubKey on the stack the scriptSig leaves before handling the redeemScript. The 20-byte push in HASH160 <20> EQUAL adds one item, so a scriptSig that leaves 1,000 items fails with STACK_SIZE, while 999 items is valid.

An implementation that checks the redeemScript hash without running the scriptPubKey accepts the 1,000-item spend. No existing vector leaves the scriptSig at this boundary, so such an implementation can pass every row.

Add 999 and 1,000 item cases with P2SH and WITNESS, and the 1,000 item case with no flags, which fails the same way because the scriptPubKey always runs. Also add the same boundary during redeemScript evaluation, where the restored stack plus the redeemScript's pushes reach 1,000 and 1,001 items.

The same case is added as a feature_taproot spender in #36455, so its dump can be added to the script assets (bitcoin-core/qa-assets#297).

These were discovered by finding gaps in an alternate implementation (rbitcoin)

ACKs for top commit:
ekzyis:
ACK 5a4cd70547
instagibbs:
ACK 5a4cd70547096af6247167d8dde6145a1b548642

Tree-SHA512: 05a8dc547e109daf346a63ad450a26870a4ee158a251eb2c08ba643d48225373e4744ab3dc5c5debfa112e94516d505c563807a8381224b98a0dc348adf389f8

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36457: Test: Cover malformed merkle trees and nBitsby merge-script · 316ea328 · Oct 21, 2026 · 2 filesMessage 91 · StrongInformational 14Details
Commit message · merge-script

Merge bitcoin/bitcoin#36457: Test: Cover malformed merkle trees and nBits

0c0e6ba0167e9397e521ba3cbc7a4779ad7518b7 Test: Cover malformed merkle trees and nBits (benthecarman)

Pull request description:

Add tests for malformed partial merkle trees, including the transaction count limit at its 16666 boundary, and for `GetBitsProof` returning zero for zero, negative and overflowing targets.

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/36457/commits/0c0e6ba0167e9397e521ba3cbc7a4779ad7518b7

Tree-SHA512: 5d44cef07d121e92e298c23fbda283a48ed92b460c557cf789fa5e6f7c67534f6f99109a6b31c8fdecc5db6851fee5a85c78af5ad9a487b788b37821ebb335a4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 14/100

This commit only adds new test cases to Bitcoin Core. It does not change any production code, so it cannot introduce a runtime vulnerability or directly fix one. The tests exercise how the software rejects malformed partial Merkle trees and how it handles unusual proof-of-work target values. The pull request description says the test ideas came from comparing against another implementation (bitcoin-s), but the commit itself is purely additional test coverage.

Lower-priorityMerge bitcoin/bitcoin#36287: build: Bump Xcode CLT minimum supported version to 26.3by merge-script · 7efbdb64 · Oct 21, 2026 · 4 filesMessage 86 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36287: build: Bump Xcode CLT minimum supported version to 26.3

fa0df9d336e80d37eab5f08b170a3255f287060c build: Bump Xcode CLT minimum supported version to 26.3 (MarcoFalke)

Pull request description:

Now that macOS 14 is EOL (https://en.wikipedia.org/wiki/MacOS_Sonoma), it seems odd to still support native Xcode CLT builds on it.

(macOS Sonoma 14.8.9 received its final security update on 06 Aug 2026: https://support.apple.com/en-us/100100)

This patch will only be released in version 33.x, another 6 months out from now. Also, depends builds (and thus release builds) are unaffected. Affected devs or users are free to build via brew, nix, etc...

This is mostly needed to get an equivalent of llvm-19-ish via CLT, see https://en.wikipedia.org/wiki/Xcode#Toolchain_versions. Specifically, it will allow to use C++20 CTAD and also allow switching the project to C++23.

ACKs for top commit:
l0rinc:
ACK fa0df9d336e80d37eab5f08b170a3255f287060c
hebasto:
ACK fa0df9d336e80d37eab5f08b170a3255f287060c.

Tree-SHA512: abd03b866f3f99f26b6b8fe5562e7f0f100adc7f4ea8962a8af6baa902f24a11deab821eb6b667e8e0844d544a6155cdd990172c08ae9e4ad3f735211599b2d7

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#35919: p2p: cap maxconnections at 2,000 to reduce crash riskby merge-script · f86c614e · Oct 21, 2026 · 5 filesMessage 81 · StrongLow 39Details
Commit message · merge-script

Merge bitcoin/bitcoin#35919: p2p: cap maxconnections at 2,000 to reduce crash risk

b30f750de56c4e510f8af5a4dbba4e821b71a9b1 p2p: cap maxconnections at 2000 (Lőrinc)

Pull request description:

**Problem:** The orphanage can abort when more than 3,000 peers have orphan announcements.
The `-maxconnections` setting currently has no explicit upper bound.

**Fix:** Cap `-maxconnections` at 2,000 with a warning before reserving file descriptors, while retaining the default of 200.

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/35919/commits/b30f750de56c4e510f8af5a4dbba4e821b71a9b1
optout21:
reACK b30f750de56c4e510f8af5a4dbba4e821b71a9b1
sedited:
ACK b30f750de56c4e510f8af5a4dbba4e821b71a9b1

Tree-SHA512: 06b892a67d9031f60427d04862fb0b96b30015c93904e544b4ec083c5713e56ab8b58c8747cb14b6bbd7ee52ca6a0d1ab5c4d9607789a19987bbda89a0689afd

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 39/100

This update limits how many peer connections Bitcoin Core will allow a user to request. Previously, a user could set an extremely high number of connections, which could trigger a crash when the orphan transaction cache (used for unconfirmed transactions) was shared across too many peers. Now, values above 2,000 are automatically reduced to 2,000 with a warning. It is a hardening fix, not a remote exploit.

Lower-priorityMerge bitcoin/bitcoin#36279: test: non-inbound version message promotes address to tried tableby merge-script · 9878e2a5 · Oct 21, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36279: test: non-inbound version message promotes address to tried table

3b88ebaea4935a305d5e4c2cf158f75ea9118359 test: only non-inbound version message promotes address to tried table (naiyoma)

Pull request description:

A `VERSION` message from a non-inbound peer calls `AddrMan::Good()`,
which moves the address from the new table to the tried table. This was previously untested.

This PR kills the mutant at https://bitcoincore.space/src/net_processing.cpp#3475

ACKs for top commit:
brunoerg:
ACK 3b88ebaea4935a305d5e4c2cf158f75ea9118359
sedited:
ACK 3b88ebaea4935a305d5e4c2cf158f75ea9118359

Tree-SHA512: 623a83e6672e19b14697c4a53951b05e7314509b505ab1904b98e6ba720867ccc0756bf94a9d7a915fbf132aa0d256d6cd370a359d690de3d5848b7c4d1f7ff5

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36579: refactor: Enable some string performance tidy rulesby merge-script · a2d42ce8 · Oct 21, 2026 · 21 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36579: refactor: Enable some string performance tidy rules

fabb6bbe53e9cba85b62da2416287c41975d71dd refactor: Use single-char overload in execute_process WIN32 block (MarcoFalke)
bbbb9c6d73a3750185c62bcb520b6ba74ac34be9 refactor: Enable performance-faster-string-find (MarcoFalke)
faae016796ed64da493cb175e40fca042fe386e6 refactor: Enable performance-prefer-single-char-overloads (MarcoFalke)
fa7973e1138aea8f1584205f4a5391a06447e2b9 refactor: Enable performance-string-view-conversions (MarcoFalke)

Pull request description:

Enabling the string performance clang-tidy rules should be fine and easy.

E.g. on aarch64, when running the `BlockToJsonVerboseWrite` bench, I can see a minimal 0.3% drop in instructions and 0.6% drop in branches.

ACKs for top commit:
stickies-v:
re-ACK fabb6bbe53e9cba85b62da2416287c41975d71dd
hebasto:
ACK fabb6bbe53e9cba85b62da2416287c41975d71dd.
l0rinc:
ACK fabb6bbe53e9cba85b62da2416287c41975d71dd

Tree-SHA512: 5917732c61960021d423fe8da5ada6eab986ab87e15f328ac74f5e31d0a1f1ea9d448b2dadad70418471b833da994bc3708c73e6e210fd5f2b2d08e88ce01bff

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup that turns on three clang-tidy style checks and applies the resulting mechanical fixes. It replaces multi-character string literals like " " and "\n" with single characters where a single character is enough, and removes a few unnecessary std::string conversions. The changes are purely about code style and tiny performance gains (the author reports roughly 0.3% fewer CPU instructions in one benchmark). There is no security bug being fixed and no new attack surface introduced.

Lower-priorityMerge bitcoin/bitcoin#36453: util, cli: name the Sock wait timeout cap and use it for -rpcclienttimeout=0by merge-script · 4fe28722 · Oct 21, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36453: util, cli: name the Sock wait timeout cap and use it for -rpcclienttimeout=0

d22d3565128828e158c6684a1b5bf1a7f2454c80 util, cli: name the Sock wait timeout cap and use it for -rpcclienttimeout=0 (Kanan)

Pull request description:

Follow-up to #36340, addressing the review comments from pinheadmz and winterrdog there.

#36340 capped the `Sock::Wait`/`WaitMany` timeout at `INT_MAX` milliseconds (about 24.8 days) inside `WaitMany`. This moves that value to a named constant, `Sock::MAX_WAIT_TIMEOUT`, and mentions the cap in the doxygen comments of `Wait()` and `WaitMany()`, since it applies to every caller and not only to `bitcoin-cli`. The constant is a whole number of seconds (2147483 s), so `bitcoin-cli`, which works in seconds, uses exactly the same value as `Sock`.

`bitcoin-cli` still turned `-rpcclienttimeout=0` into a 5 year timeout. The timeout is applied to each wait for the socket, and each wait is now capped, so in practice `0` already means "give up after about 24.8 days without data". The 5 year value is replaced with `Sock::MAX_WAIT_TIMEOUT`, and the help text now says that 0 is the longest supported timeout (about 24 days) instead of no timeout.

There is no behaviour change. `sock_tests`, `interface_bitcoin_cli.py` (including the `-rpcclienttimeout=0` call added in #36340) and `interface_rpc.py` pass on macOS.

(Changes prepared with AI tools.)

ACKs for top commit:
winterrdog:
reACK d22d3565128828e158c6684a1b5bf1a7f2454c80
pinheadmz:
ACK d22d3565128828e158c6684a1b5bf1a7f2454c80
sedited:
ACK d22d3565128828e158c6684a1b5bf1a7f2454c80

Tree-SHA512: 03d6e3b0587fddcdaadcf2d8b997ccd0b92db62abeeafc02895739a1984dbf4231b854b3b430d84d3bca4970020f043c9ea8b32bc1022d372440e36d0d5b1ad7

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36509: refactor: remove more dead codeby merge-script · d3c3871b · Oct 21, 2026 · 35 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36509: refactor: remove more dead code

570c4a184f49b6d71bc581ae694b969a91cf2510 build: enable -Wunused-macros & -Wunused-template (fanquake)
7981e61764474d914ad7808cac939b821c854495 test: remove unused equal from check_equal() (fanquake)
e8a70c0c68874b153cf02f0b49269ad40302f850 qt: remove unused WalletController::m_options_model (fanquake)
2e23a5b1f1602fb9ff5f6cf659cf1d30c5576dab qt: remove unused AddressBookPage::sendCoins signal (fanquake)
18a5e90179dd0b70b73bef82c0a7aca8c7770f23 qt: remove unused ClientModel::getNumBlocks and its cache (fanquake)
3a3e0ced8c1618f21b662b79902c05df4dc3297a qt: remove unused BitcoinAmountField::setReadOnly (fanquake)
f226197c0015108b3d0f3fd6a3d068275aacefd5 qt: remove unused BitcoinAmountField::SetMaxValue (fanquake)
92ad4ad4042f6ed8b20abe408e713d5e6eea7230 qt: remove unused removeAllWallets (fanquake)
4881802c3f6088f284923003d57ecc7c8a409c41 qt: remove stale PeerTablePriv forward declaration (fanquake)
3f40af467271177abad96426092c03cbb2e231d2 fuzz: remove unused FuzzedWallet::GetScriptPubKey (fanquake)
fc21d18741130aacca21289304da9b6a22eca768 qt: remove unused COLOR_BLACK (fanquake)
830a95548a444a3f1fe86bc26881b290382a5a23 refactor: remove unused ScriptHash(const CScriptID&) constructor (fanquake)
d6ffa22e287a593aec0669860f0b61a9bdaa9262 fuzz: remove unused MockedDescriptorConverter::IdIsXpub (fanquake)
664c2f4600d87cd94100ff03a29cf8178704a678 logging: remove unused Logger::AddCategoryLogLevel (fanquake)
fb7a3aef1bc89cf26af7fee6d5425c3d0689a059 addrman: remove unused AddrMan::Unserialize(AutoFile&) instantiation (fanquake)
54fe34c6b32def9d94692e8f74d56ed12f1acd9d policy: remove unused EXTRA_DESCENDANT_TX_SIZE_LIMIT (fanquake)
71f598018bc8101aaa9f7f496289e43437ea9266 refactor: remove unused BinarySemaphoreGrant alias (fanquake)
a781e4828983b4038fe8c5d98a097d8ade2853dc qt: remove unused TrafficGraphWidget::getGraphRange (fanquake)
8a8a46d7b6164981363dbb185db3a895f4193078 qt: remove unused OptionsDialog::proxyIpChecks signal (fanquake)
2fecbfd1e159f2a5eae6ec8a97da3684ef617110 qt: remove unused QValueComboBox::setRole (fanquake)
50fb338f94e46686d16cc36bfd55fb57d5f116c7 qt: remove unused ClientModel::isReleaseVersion (fanquake)
101345feaa0043caeb79b55f5a6354d85a7b0183 script: remove unused FillableSigningProvider::GetCScripts (fanquake)
5eddbb45c2ad9a293ea0cb796189b794293bc887 ipc: remove unused FooImplementation::passBlockState (fanquake)
159596418166e397fafdbf1e1a090ef0578afd18 test: remove unused GetMockableDatabase declaration (fanquake)
98136193f6b75b82facfda90b46c9d99e0e82932 kernel: remove unused MemPoolLimits::NoLimits (fanquake)
d7c16aa057ecce0743ce2cd79bebf74f757b2dba netbase: remove unused Proxy::GetFamily (fanquake)
d28d1a980999f346eb1994e361c0ecc0dd081d06 span: remove unused MakeWritableUCharSpan (fanquake)

Pull request description:

Part of #36167.

ACKs for top commit:
stickies-v:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510
sedited:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510

Tree-SHA512: 2249fe91098006228006b30e4c18b204fb5d6dfefea8d175a2d8ea45409220df5c62c6618125b69e8af3b4f775269c11cf424a429cc3fe93629e961420f8eeec

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundaryaccess controlfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine cleanup that removes unused code, unused compiler warning flags, and stale declarations from Bitcoin Core. None of the changes alter active behavior, fix bugs, or introduce security-sensitive logic. It is purely a refactoring and build-hygiene change.

Lower-priorityMerge bitcoin/bitcoin#36449: addrman: use uniform sampling inside bucketsby merge-script · 355d998d · Oct 21, 2026 · 3 filesMessage 96 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36449: addrman: use uniform sampling inside buckets

5aaaf7b8d1ed72b7ab9eee117204f4c4346eb235 test: check network filtering and uniformity of addrman Select (Pieter Wuille)
9a0e095c687d7e139a9571883296cd9321e5beeb addrman: use uniform sampling inside buckets (Pieter Wuille)

Pull request description:

The current way we sample from addresses within a bucket in addrman is randomized, but not perfectly random. It uses a linear scan, starting at a random position (out of the 64 positions in a bucket). This means that if for example only position 17 and 20 contain an address, 17 will be picked with probability 95.3% (whenever the initial position is 21..63 or 0..17) and 20 will be picked with probability 4.7% (whenever the initial position is 18..20).

Make this search perfectly uniform, regardless of distribution of addresses within the bucket, by first copying all non-empty positions to a temporary array, and then selecting uniformly randomly from that array.

Suggested by Crypt-iQ. Also pointed out earlier by mzumsande in https://github.com/bitcoin/bitcoin/pull/23140#discussion_r733084509.

ACKs for top commit:
Crypt-iQ:
crACK 5aaaf7b8d1ed72b7ab9eee117204f4c4346eb235
darosior:
reACK 5aaaf7b8d1ed72b7ab9eee117204f4c4346eb235

Tree-SHA512: aed7a921b236e61b13f55438b227407a1c478b1b8bf623febbc6bda864f4902bb052555d835901a1a4228d1e9c5e2156f6e348ae803b8154ae3ef5592f213e45

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36531: guix: use `--load-path` for local modulesby merge-script · 61f1e2a5 · Oct 21, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36531: guix: use `--load-path` for local modules

48eed2fc2770264c4137a89a7631fead11acaad5 guix: use --load-path for local modules (fanquake)

Pull request description:

Rather than exporting via `GUIX_PACKAGE_PATH`.

Fixes #36530.

ACKs for top commit:
hebasto:
ACK 48eed2fc2770264c4137a89a7631fead11acaad5.
willcl-ark:
ACK 48eed2fc2770264c4137a89a7631fead11acaad5

Tree-SHA512: 1fe3b81f351742a40e957e9a4d9173b220436449a11dd4fb870e8756f729af12c145a06c7739b5456a61690ab4f9ee2a86d552301fdfc73816d2b9325a45e549

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#35461: util: Clarify the assertion message in assertion failures (Assert, Assume, etc.)by merge-script · 4510d3db · Oct 21, 2026 · 5 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#35461: util: Clarify the assertion message in assertion failures (Assert, Assume, etc.)

81fde00cc7ff2c5ae85e8601d8b780ddde7dc2a6 util: Unify assertion and unreachable handling (optout)
aa64d77ce8f16030c3740f9f78eca741ab1cb74f util: Rename assertion_fail() -> internal_abort_helper() (optout)
2e3a53464d397f7dcdd171413812b42dbd1bb8d4 util: In Assert clarify the failing condition in the message (optout)

Pull request description:

Clarify the message in case of assertion failures. Additionally unify the behavior of `NONFATAL_UNREACHABLE` w.r.t. abort handling.

Motivation: This was discussed in https://github.com/bitcoin/bitcoin/pull/34844#discussion_r3303436384

The error message generated by `Assert`, `Assume`, and `CHECK_NONFATAL` contains the failing assertion condition text, but it's unclear whether that's the failed expectation or the actual case.

For example,
`"Internal bug detected: pindex != nullptr"`
in fact means that what happened was `pindex == nullptr`.

Clarify the situation, by inserting "\`%s\` check failed".

The above example is now:
``"Internal bug detected: `pindex != nullptr` check failed"``
which is more unambiguous.

Additionally, change `NONFATAL_UNREACHABLE` to behave like `CHECK_NONFATAL`, and honor the special abort setting (`G_ABORT_ON_FAILED_ASSUME`).

ACKs for top commit:
l0rinc:
ACK 81fde00cc7ff2c5ae85e8601d8b780ddde7dc2a6
maflcko:
review ACK 81fde00cc7ff2c5ae85e8601d8b780ddde7dc2a6 🎷
sedited:
ACK 81fde00cc7ff2c5ae85e8601d8b780ddde7dc2a6

Tree-SHA512: 8ce7f201c7940527085e4e183be425b0754ae257df3d9950301a8e248db9008955ddf94061475d01c75a57febd9be80855b2b42dc7029ca486b4bc74151d177e

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36582: test: reorder functional tests by current runtimesby Hennadii Stepanov · 4303f3b7 · Oct 20, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36582: test: reorder functional tests by current runtimes

649e075655c653f0581ba7a28f7bda2b347fad80 test: move slow tests to run earlier (ViniciusCestarii)
6a59afd317d31e844631ec8b031feb94399e1196 test: move fast tests to run later (ViniciusCestarii)

Pull request description:

After #36439, #36440 and #36446 some tests got much faster.

Move tests that finish faster to run later and move tests that are slow to run earlier.

Timings from master CI run [39389906008](https://github.com/bitcoin/bitcoin/actions/runs/39389906008):

| Test | Bucket (before → after) | CI median | CI max |
|---|---|---|---|
| `interface_http.py` | <30s (late) → <60s (first) | 53s | 60s (TSan) |
| `feature_maxuploadtarget.py` | <2m → <30s (first) | 10s | 44s (Windows native, VS) |
| `feature_torcontrol.py` | <30s (late) → <30s (early) | 17s | 20s (macOS native) |
| `wallet_conflicts.py` | <5m → <30s | 4s | 11s (TSan) |
| `p2p_node_network_limited.py --v1transport` | <5m → <30s | 6s | 18s (TSan) |
| `p2p_node_network_limited.py --v2transport` | <5m → <30s | 6s | 17s (TSan) |
| `wallet_backup.py` | <60s → <30s | 8s | 17s (TSan) |
| `wallet_address_types.py` | <60s → <30s | 7s | 20s (TSan) |
| `p2p_sendheaders.py` | <60s → <30s | 3s | 8s (TSan) |
| `feature_maxtipage.py` | <60s → <30s | 5s | 11s (TSan) |
| `feature_csv_activation.py` | <60s → <30s | 6s | 13s (TSan) |
| `feature_segwit.py --v1transport` | <60s → <30s | 4s | 12s (TSan) |
| `feature_segwit.py --v2transport` | <60s → <30s | 4s | 14s (TSan) |

Locally (`test_runner.py -j=18 --randomseed=1`) with these changes I got: 84s -> 78s (median of 3 runs)

ACKs for top commit:
maflcko:
review ACK 649e075655c653f0581ba7a28f7bda2b347fad80 🦃
hebasto:
ACK 649e075655c653f0581ba7a28f7bda2b347fad80.

Tree-SHA512: 2337d585ead5cea3c35f57683b8649a6068417ba3f7782b8c7b147688365518c7e806af11d962ca05dd14a42c5446901791367f579d5fedf9080dff9c149b062

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritytest: move slow tests to run earlierby ViniciusCestarii · 649e0756 · Oct 20, 2026 · 1 fileMessage 67 · AdequateTriage 0Details
Commit message · ViniciusCestarii

test: move slow tests to run earlier

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Lower-prioritytest: move fast tests to run laterby ViniciusCestarii · 6a59afd3 · Oct 20, 2026 · 1 fileMessage 67 · AdequateTriage 0Details
Commit message · ViniciusCestarii

test: move fast tests to run later

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Lower-prioritysubprocess: fix command line memory leak on Windowsby stickies-v · cf30d0a4 · Oct 20, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · stickies-v

subprocess: fix command line memory leak on Windows

Popen::execute_process() copied the command line into a buffer from
new[], but did not delete it. This leaked memory each time a process
started on Windows.

CreateProcessA needs a writable command line buffer. Since C++17,
std::string::data() supplies one, so give the std::string buffer
directly and remove the copy.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedMerge bitcoin/bitcoin#36397: scripted-diff: [wallet] Remove trailing newlines from one-line log messagesby merge-script · 6799119c · Oct 20, 2026 · 14 filesMessage 91 · StrongInformational 19Details
Commit message · merge-script

Merge bitcoin/bitcoin#36397: scripted-diff: [wallet] Remove trailing newlines from one-line log messages

fa0c552cc5abdd0a7e7f2c9cfc1491240494f352 wallet: Reject trailing newline in format strings (MarcoFalke)
fada75ccb05575e01c18bd4b6b28d41a3c2cd87c util: Add option to reject trailing newline in format strings (MarcoFalke)
fa57d5244b3cdc151e01d7dd02a5e363bf801bcb scripted-diff: [wallet] Remove trailing newlines from one-line log messages (MarcoFalke)
fa6c7942ad8e159f240194d2d290e9d64812761a wallet: Remove inconsistent and redundant trailing error newlines (MarcoFalke)
fa89aeec855b774e8ef37b31ac2b6b83c1d263e8 test: [move-only] Move test_LogEscapeMessage to logging tests (MarcoFalke)

Pull request description:

This is a low-prio style cleanup for years, but:

* It is tedious and possibly distracting to do it manually when touching the line for other reasons.
* The topic recently came up again when discussing log injection (https://github.com/bitcoin/bitcoin/pull/35833#issuecomment-5113804332)

So I wonder if a simple scripted-diff can cover the bulk of the changes now, with hopefully little conflicts with reviewed pull requests.

(Removing the trailing newlines from the remaining log messages is trivial and can be done in a later pull)

ACKs for top commit:
l0rinc:
ACK fa0c552cc5abdd0a7e7f2c9cfc1491240494f352
sedited:
ACK fa0c552cc5abdd0a7e7f2c9cfc1491240494f352

Tree-SHA512: 48b5fa1f25797052e4a0e66efe7c59085309ba56524d001ac35089a579cf08a7b8a0908de54290f3b4867a012f097c00f2f8d57723d15c9da6e09eb902bd8ed3

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 19/100

This is a code-cleanup change for Bitcoin Core's wallet logging. It removes manual newline characters from the end of one-line log messages and adds a compile-time check that prevents wallet log format strings from ending in a newline. The change is defensive: it reduces the chance that a future log message could accidentally inject fake log lines or confuse log parsing, but it does not by itself fix an active security bug.