BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 9 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge bitcoin/bitcoin#36707: net_processing: remove redundant `peer` check in `MaybePunishNodeForBlock`by merge-script · 35195e66 · Nov 3, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36707: net_processing: remove redundant `peer` check in `MaybePunishNodeForBlock`

66292fa4b575ef193ab2363391399cec29bf3503 net_processing: remove redundant peer check in MaybePunishNodeForBlock (fanquake)

Pull request description:

The `Misbehaving()` call is already inside an `if (peer && ...)` block.

ACKs for top commit:
Crypt-iQ:
crACK 66292fa4b575ef193ab2363391399cec29bf3503
jpk68:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
ViniciusCestarii:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
l0rinc:
ACK 66292fa4b575ef193ab2363391399cec29bf3503
brunoerg:
ACK 66292fa4b575ef193ab2363391399cec29bf3503

Tree-SHA512: 6fe9aef26937711965a96107a8d57a1dd12e31592f38485ece3836c0afd72592a7adf40a542caa953211bd29c91dc2c6439b17d4a4263352fe5f6667d63f74dc

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a tiny code cleanup in Bitcoin Core's network handling. It removes an unnecessary second check that 'peer' exists, because the surrounding code already confirmed it exists. There is no functional change and no security risk.

Lower-priorityMerge bitcoin/bitcoin#36554: cmake: Reject warnings in `check_cxx_source_compiles_with_flags()`, use `-msse4.1` for SHA-NIby merge-script · ddea9196 · Nov 2, 2026 · 6 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36554: cmake: Reject warnings in `check_cxx_source_compiles_with_flags()`, use `-msse4.1` for SHA-NI

5bb7c5646a7f11e910c620107ba873bb4ecb3f3f cmake, crypto: Use `-msse4.1` instead of `-msse4` for x86 SHA-NI (Hennadii Stepanov)
9ab42235c1567442c73c3c0316a309c7d7a10283 cmake: Treat warnings as errors in `CheckSourceCompilesWithFlags` (Hennadii Stepanov)
c4763b716db175fa106c47a1cd68abf07e762e6b cmake: Make sanitizer and fuzzer checks warning-free (Hennadii Stepanov)
8ba6cb08dfafaa0dc5ee5f95f20ee4124bb518f2 cmake, minisketch: Make CLMUL check warning-free (Hennadii Stepanov)
89bc05fe832d597c72f175e8a473555c963d5a7d cmake, crc32c: Make SSE4.2 check warning-free (Hennadii Stepanov)
53865a0addc240cb6db3ad03b2d578420990a243 cmake: Initialize variables in ARMv8 SHA-NI check (Hennadii Stepanov)
cd3353c6892e3c85bf6dc52b0e6bd98c493532b3 cmake: Add `[[maybe_unused]]` annotation to atomic library check (Hennadii Stepanov)

Pull request description:

This is a prerequisite for #31507.

1. The first commit fixes a bug in the C++ atomic library check:
```console
$ git rev-parse HEAD
01b51c0f1fa8af242fc37891d666c3d940045d80
$ cmake -B build -DAPPEND_CXXFLAGS="-Wall -Werror" 2>&1 | grep -A 8 STD_ATOMIC
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC - Failed
-- Performing Test STD_ATOMIC_NEEDS_LINK_TO_LIBATOMIC
-- Performing Test STD_ATOMIC_NEEDS_LINK_TO_LIBATOMIC - Failed
CMake Error at cmake/module/TestAppendRequiredLibraries.cmake:91 (message):
Cannot figure out how to use std::atomic.
Call Stack (most recent call first):
cmake/introspection.cmake:23 (test_append_atomic_library)
CMakeLists.txt:453 (include)

-- Configuring incomplete, errors occurred!
```

2. The second commit fixes a bug in the ARMv8 SHA-NI check:
```console
$ git rev-parse HEAD
cd3353c6892e3c85bf6dc52b0e6bd98c493532b3
$ cmake -B build -DAPPEND_CXXFLAGS="-Wall -Werror" 2>&1 | grep HAVE_ARM_SHANI
-- Performing Test HAVE_ARM_SHANI
-- Performing Test HAVE_ARM_SHANI - Failed
$ grep -A25 'HAVE_ARM_SHANI' build/CMakeFiles/CMakeConfigureLog.yaml
- "Performing Test HAVE_ARM_SHANI"
directories:
source: "/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE"
binary: "/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE"
cmakeVariables:
CMAKE_CXX_COMPILE_OBJECT: "<CMAKE_CXX_COMPILER> <DEFINES> <INCLUDES> <FLAGS> -o <OBJECT> -c <SOURCE> -Wall -Werror"
CMAKE_CXX_FLAGS: ""
CMAKE_CXX_FLAGS_RELWITHDEBINFO: "-O2 -g"
CMAKE_CXX_LINK_EXECUTABLE: "<CMAKE_CXX_COMPILER> <FLAGS> <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES> "
CMAKE_CXX_LINK_NO_PIE_SUPPORTED: "1"
CMAKE_EXE_LINKER_FLAGS: ""
CMAKE_MODULE_PATH: "/home/hebasto/dev/bitcoin/cmake/module"
CMAKE_POSITION_INDEPENDENT_CODE: "ON"
buildResult:
variable: "HAVE_ARM_SHANI"
cached: true
stdout: |
Change Dir: '/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE'

Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f Makefile cmTC_b4026/fast
/usr/bin/gmake -f CMakeFiles/cmTC_b4026.dir/build.make CMakeFiles/cmTC_b4026.dir/build
gmake[1]: Entering directory '/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE'
Building CXX object CMakeFiles/cmTC_b4026.dir/src.cxx.o
/usr/bin/c++ -DHAVE_ARM_SHANI -march=armv8-a+crypto -O2 -g -std=c++20 -fPIE -o CMakeFiles/cmTC_b4026.dir/src.cxx.o -c /home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx -Wall -Werror
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx: In function ‘int main()’:
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:7:21: error: ‘a’ is used uninitialized [-Werror=uninitialized]
7 | vsha256h2q_u32(a, b, c);
| ~~~~~~~~~~~~~~^~~~~~~~~
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:6:18: note: ‘a’ was declared here
6 | uint32x4_t a, b, c;
| ^
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:7:21: error: ‘b’ is used uninitialized [-Werror=uninitialized]
7 | vsha256h2q_u32(a, b, c);
| ~~~~~~~~~~~~~~^~~~~~~~~
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:6:21: note: ‘b’ was declared here
6 | uint32x4_t a, b, c;
| ^
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:7:21: error: ‘c’ is used uninitialized [-Werror=uninitialized]
7 | vsha256h2q_u32(a, b, c);
| ~~~~~~~~~~~~~~^~~~~~~~~
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE/src.cxx:6:24: note: ‘c’ was declared here
6 | uint32x4_t a, b, c;
| ^
cc1plus: all warnings being treated as errors
gmake[1]: *** [CMakeFiles/cmTC_b4026.dir/build.make:78: CMakeFiles/cmTC_b4026.dir/src.cxx.o] Error 1
gmake[1]: Leaving directory '/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-35fxFE'
gmake: *** [Makefile:127: cmTC_b4026/fast] Error 2

exitCode: 2
```

3. Fixed bugs in the SSE4.2 check:
```console
$ cmake -B build -DAPPEND_CXXFLAGS="-Wconversion -Werror" 2>&1 | grep HAVE_SSE42
-- Performing Test HAVE_SSE42
-- Performing Test HAVE_SSE42 - Failed
$ grep -A14 'HAVE_SSE42' build/CMakeFiles/CMakeConfigureLog.yaml
- "Performing Test HAVE_SSE42"
directories:
source: "/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI"
binary: "/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI"
cmakeVariables:
CMAKE_CXX_COMPILE_OBJECT: "<CMAKE_CXX_COMPILER> <DEFINES> <INCLUDES> <FLAGS> -o <OBJECT> -c <SOURCE> -Wconversion -Werror"
CMAKE_CXX_FLAGS: ""
CMAKE_CXX_FLAGS_RELWITHDEBINFO: "-O2 -g"
CMAKE_CXX_LINK_EXECUTABLE: "<CMAKE_CXX_COMPILER> <FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES> "
CMAKE_CXX_LINK_NO_PIE_SUPPORTED: "1"
CMAKE_CXX_LINK_PIE_SUPPORTED: "1"
CMAKE_CXX_STDLIB_MODULES_JSON: ""
CMAKE_EXE_LINKER_FLAGS: ""
CMAKE_MODULE_PATH: "/home/hebasto/dev/bitcoin/cmake/module"
CMAKE_POSITION_INDEPENDENT_CODE: "ON"
--
variable: "HAVE_SSE42"
cached: true
stdout: |
Change Dir: '/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI'

Run Build Command(s): /usr/bin/ninja-build -v cmTC_88170
[1/2] /usr/lib64/ccache/c++ -DHAVE_SSE42 -msse4.2 -O2 -g -std=c++20 -fPIE -o CMakeFiles/cmTC_88170.dir/src.cxx.o -c /home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx -Wconversion -Werror
FAILED: [code=1] CMakeFiles/cmTC_88170.dir/src.cxx.o
/usr/lib64/ccache/c++ -DHAVE_SSE42 -msse4.2 -O2 -g -std=c++20 -fPIE -o CMakeFiles/cmTC_88170.dir/src.cxx.o -c /home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx -Wconversion -Werror
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx: In function ‘int main()’:
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx:11:22: error: conversion from ‘uint64_t’ {aka ‘long unsigned int’} to ‘unsigned int’ may change value [-Werror=conversion]
11 | l = _mm_crc32_u8(l, 0);
| ^
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx:12:23: error: conversion from ‘uint64_t’ {aka ‘long unsigned int’} to ‘unsigned int’ may change value [-Werror=conversion]
12 | l = _mm_crc32_u32(l, 0);
| ^
/home/hebasto/dev/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-fn8wHI/src.cxx:14:12: error: conversion from ‘uint64_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Werror=conversion]
14 | return l;
| ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

exitCode: 1
```

4. Similarly, the CLMUL check in minisketch was made warning-free.

5. The sanitizer and fuzzer checks was made warning-free.

6. We expect that neither the compiler flags nor the test source triggers any warnings, such as `-Wunknown-argument`. Therefore, append `working_compiler_werror_flag`, as done in [`try_append_cxx_flags()`](https://github.com/bitcoin/bitcoin/blob/master/cmake/module/TryAppendCXXFlags.cmake).

7. `-msse4` is merely a synonym for `-msse4.2` in both GCC and Clang, but it is not accepted by the clang-cl frontend. Furthermore, the x86 SHA-NI code uses only SSE4.1 intrinsics and no SSE4.2 ones.

Replace `-msse4` with `-msse4.1` to resolve both issues.

The absence of SSE4.2 usage can be verified by building with `-DAPPEND_CXXFLAGS=-mno-sse4.2`.

ACKs for top commit:
fanquake:
ACK 5bb7c5646a7f11e910c620107ba873bb4ecb3f3f
hodlinator:
re-ACK 5bb7c5646a7f11e910c620107ba873bb4ecb3f3f

Tree-SHA512: b4d0029411e93dce297025cb257933f3e865f6d6b2243bdf5f3a2ecbc9b4bb0f79087842b50b9a2de3944b2707f18eb4bd68fa29adb2180787a9088c4054e28b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationfuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36712: fees: prevent divide by zero in CFeeRateby merge-script · 38ece2a9 · Nov 2, 2026 · 3 filesMessage 91 · StrongModerate 60Details
Commit message · merge-script

Merge bitcoin/bitcoin#36712: fees: prevent divide by zero in CFeeRate

f442fa20d437f02518c327736206185bd6f6a1a1 fees: prevent divide by zero in CFeeRate (ismaelsadeeq)

Pull request description:

A CFeeRate with size 0 `GetFeePerK()` and `CFeeRate+=` evaluated `EvaluateFeeDown(1000)` unconditionally, dividing by that zero size and crashing.

Return 0 for an empty fee rate, matching `GetFee()` behaviour, and add minimal unit test coverage.

This was reported by Jacob F Cudney (aragondragon)

ACKs for top commit:
pablomartin4btc:
re-ACK f442fa20d437f02518c327736206185bd6f6a1a1
polespinasa:
re-ACK f442fa20d437f02518c327736206185bd6f6a1a1
musaHaruna:
Code review ACK [f442fa2](https://github.com/bitcoin/bitcoin/pull/36712/changes/f442fa20d437f02518c327736206185bd6f6a1a1)

Tree-SHA512: c3792271819814272a78845ce6f2782aa9ec629f2d67a1505c195bc340ea55e326b686b928b3958bd1cc807ca577747bd6ebe2e2cd3dc367e5cca1316a6b721d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a divide-by-zero crash in Bitcoin Core's fee-rate calculation. When a transaction fee rate was created with a size of zero, calling certain methods would try to divide by zero and crash the program. The fix makes these methods safely return zero instead, matching the behavior of related code, and adds tests to prevent the crash from coming back.

Security candidateMerge bitcoin/bitcoin#36305: net: Use exclusive P2P listen sockets on Windowsby Hennadii Stepanov · 3581d56b · Nov 2, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36305: net: Use exclusive P2P listen sockets on Windows

db31a3ad1f75538d07707d373adbfbe90ba8e328 test: check P2P listen port exclusivity (winterrdog)
0dbd271eb4a3263b8b81ccf22876429076bae574 net: use exclusive P2P listen sockets on Windows (winterrdog)

Pull request description:

on Windows, `SO_REUSEADDR` does not carry over the same semantics as on
POSIX systems. a second socket can set `SO_REUSEADDR` and bind to a
port that is _already in use_ by another process running under
the _same_ user account. this means another local process could bind to
the P2P listen port and receive incoming connections intended for
`bitcoind`.

this matters because the P2P listener is expected to have exclusive
ownership of its address and port. allowing another process to bind to
it could let that process _intercept_ incoming P2P connections. this is
in a similar spirit to #36169, which made the RPC listener exclusive on
Windows.

to fix this, we use `SO_EXCLUSIVEADDRUSE` for the P2P listen socket on
Windows instead of `SO_REUSEADDR`, while retaining `SO_REUSEADDR` on
other platforms. the added test verifies the expected behaviour by
attempting to bind a second socket to the same port. on Windows, this
fails with `WSAEACCES` (`10013`), which Python exposes as
`PermissionError` (an `OSError` subclass).

references:

- https://learn.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse
- https://stackoverflow.com/questions/14388706/how-do-so-reuseaddr-and-so-reuseport-differ/14388707#14388707

ACKs for top commit:
jpk68:
ACK db31a3ad1f75538d07707d373adbfbe90ba8e328
hodlinator:
re-ACK db31a3ad1f75538d07707d373adbfbe90ba8e328
hebasto:
ACK db31a3ad1f75538d07707d373adbfbe90ba8e328.

Tree-SHA512: cc73358bb4f1ecaf7246a8803e50ef8b5139bb348094a55dd2d5deb7d4a8d9082a028f342d6dc63d731a441c393739ed41c1039022a7463080830d83e978d34b

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetycredential or privilege statemerge-commit duplicate discount
AI analysis · Moderate 62/100

This change fixes a Windows-specific networking issue in Bitcoin Core. Previously, another program running on the same Windows computer under the same user account could hijack Bitcoin's peer-to-peer network port, potentially intercepting incoming connections meant for the Bitcoin node. The fix makes the listening socket exclusive on Windows, similar to a change already made for the RPC port. Other operating systems are unaffected because their behavior was already safe.

AI review queuedMerge bitcoin/bitcoin#36618: test: Wait for index sync in all testsby merge-script · e310efb2 · Nov 2, 2026 · 18 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36618: test: Wait for index sync in all tests

fa74dc72d942e1628cea3c143bb56eed1457bbce test: refactor: Wait for index sync by default (MarcoFalke)
fa8009ba2997a0eb3e6e1a657db507e5a8b8b529 test: Wait for index sync in wallet_fast_rescan.py (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/36564 by adding the missing wait on the index sync.

Diff to reproduce:

```diff
diff --git a/src/util/thread.cpp b/src/util/thread.cpp
index 5b20e807b4..2e988c9eea 100644
--- a/src/util/thread.cpp
+++ b/src/util/thread.cpp
@@ -8,2 +8,3 @@
#include <util/log.h>
+#include <util/time.h>
#include <util/threadnames.h>
@@ -17,2 +18,3 @@ void util::TraceThread(std::string_view thread_name, std::function<void()> threa
util::ThreadRename(std::string{thread_name});
+ UninterruptibleSleep(999ms);
try {
```

Command to reproduce (run twice to create the cache the first time, and reproduce on the second):

```
./bld-cmake/test/functional/wallet_fast_rescan.py | grep WARNING
```

On failure, the log will say something like:

```
- 2026-10-18T05:06:44.451973Z [http.01] [wallet/scan.cpp:142] [ShouldFetchBlock] [scan] Fast rescan: inspect block 200 [4c063a93914ec0cb1604297f2f601dab9b9342bf073e6b80e1c11efd71714e2e] (WARNING: block filter not found!)

ACKs for top commit:
ViniciusCestarii:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce
hebasto:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce, the changes are correct.

Tree-SHA512: 750ca9c666f0195fd7781800abf43aea9465af722230ed01e12c3fbd98d795be985a558d061d73446d9ffddd10fa67172d1f1bbc9b9cac87a2899682ff95418b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal functional test framework. It makes the test harness automatically wait for optional indexes (like transaction index, block filter index, and coin stats index) to finish syncing before continuing tests. It does not change the production Bitcoin node software that users run, so it cannot directly affect real wallets, funds, or network security.

Security candidateMerge bitcoin/bitcoin#36091: test: Add debug output to common tested typesby merge-script · d54844ea · Nov 2, 2026 · 18 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36091: test: Add debug output to common tested types

722d08e03980c359bae4e3b65551d6b8ba615a7a test: Convert `BOOST_CHECK` macros with known debug string (rustaceanrob)
d735b94803a6d6e1ae8a3716a2ca7b1a63e1ca1e test: Add display `operator<<` overloads to `common.{h,cpp}` (rustaceanrob)

Pull request description:

If the `<<` operator exists, boost can use this as a debug output when a check fails (besides `BOOST_CHECK`). This adds `<<` for types commonly used across the unit tests that do not yet have a display output. Each callsite that uses these types are then updated to use macros that will print the debug output on failure. All of these display strings would be used as part of #35713, but we can also use them with boost today.

What this PR does:
- Adds debug output for types used across multiple files, or types that have a clear debug string, and migrates the `BOOST_CHECK` calls. This covers the majority of custom types that did not yet have a debug string.

What this PR does _not_ do:
- Migrate `BOOST_CHECK` callsites for types that already _do_ have a debug output (all primitive type comparisons, `CFeeRate`, etc). This would be a much larger refactor and could perhaps be done after.
- Add debug output for `std::vector<T>` where `T` is streamable. These can be migrated to `BOOST_CHECK_EQUAL_COLLECTIONS`, but is a similar refactor to the one above.
- Add debug output for `std::vector<unsigned char>` and related. Also a large refactor, and could use discussion.
- Add debug output for types that would require a `friend` method in the source code (`ByRatio`)

ACKs for top commit:
maflcko:
review ACK 722d08e03980c359bae4e3b65551d6b8ba615a7a 🍟
ismaelsadeeq:
reACK 722d08e03980c359bae4e3b65551d6b8ba615a7a

Tree-SHA512: 0ee1fdfa354195c87b428705758568843eee16fe72b42263adb2855045a1fe2163f62b8bf62734b0a1ba16411aca0df2348c29f9163e9b004f315fe90b3905b4

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's test code. It adds pretty-printing helpers for common data types and updates test assertions to use macros that print more helpful failure messages. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network behavior.

Lower-priorityMerge bitcoin/bitcoin#36715: refactor: Enable bugprone-signed-char-misuseby merge-script · cd74d965 · Nov 2, 2026 · 4 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36715: refactor: Enable bugprone-signed-char-misuse

fa6efa5da55c4b1acda336fb875e94b020c023a6 refactor: Enable bugprone-signed-char-misuse (MarcoFalke)

Pull request description:

This can help to prevent out-of-bounds reads such as the one removed in 43a33e513c4044dc01d92e77da76f2e98faaedb5, or prevent other bugs.

There is some code that correctly uses signed chars, but this can be trivially made "tidy" by using C++11 narrowing init to `int` (or whatever type you want).

ACKs for top commit:
jpk68:
ACK fa6efa5da55c4b1acda336fb875e94b020c023a6

Tree-SHA512: afe2e27152fb4197b2eaa772dc12c385df306477848aa3db2013abe79736420fd5d08f368b1ba721aa58c6b97499d75b40e822ba93da5de776faf342ee2b8fdc

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36687: test: wait for the node to finish the last block in p2p_ping_ibdby merge-script · 6c01bd0b · Oct 31, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36687: test: wait for the node to finish the last block in p2p_ping_ibd

9af82f9872ca1a9e8d4645c537b23af4bc861ed2 test: wait for the node to finish the last block in p2p_ping_ibd (Greg Sanders)

Pull request description:

ProcessBlock() stamps m_last_block_time only after ProcessNewBlock() returns, so getblockcount can show the new height, with nothing in flight, before the stamp is taken. A bumpmocktime in that gap stamps the block with the bumped time, and the final bump then leaves the ping timeout exactly at its boundary, where it never fires. Sync with a ping after the last block, so the node has finished processing it before the clock moves.

The race has been present since the test was added in #36080.

Faling job:
https://github.com/bitcoin/bitcoin/actions/runs/40589303246/job/122489039018

ACKs for top commit:
mzumsande:
Code Review ACK 9af82f9872ca1a9e8d4645c537b23af4bc861ed2
sedited:
ACK 9af82f9872ca1a9e8d4645c537b23af4bc861ed2

Tree-SHA512: b4f98b6a43ff2f8be2e9fc42be9ab1610bf9e87a93f7edd0fc06b67df096c774021e681c3f7d56730e8c987aaf130ae831347c17dcce1c8a88f35df8cc9a0ba0

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
authentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a fix for a flaky automated test, not a security fix for the Bitcoin Core software itself. The test sometimes failed because it moved the simulated clock forward before the test node had fully finished recording the time of the last downloaded block. The patch adds a small synchronization step so the test waits for the node to finish processing before advancing the clock. It does not change production code or fix any vulnerability that could affect real users.

Security candidateMerge bitcoin/bitcoin#35818: bloom: avoid undefined sizing calculationsby merge-script · 71133aec · Oct 31, 2026 · 4 filesMessage 91 · StrongLow 35Details
Commit message · merge-script

Merge bitcoin/bitcoin#35818: bloom: avoid undefined sizing calculations

c4302ddf806094fcc2b1e21593e25b2038191a07 fuzz: cover bloom sizing boundaries (Lőrinc)
3acd9ae9016e6c66783bec002435a49c04050db2 test: cover bloom sizing boundaries (Lőrinc)
77055771169dc44f832083f46468ea75421a009b bloom: avoid undefined sizing calculations (Lőrinc)
3614b38e33cb98528b0c3dc337060f7448bb8e6e test: characterize bloom filter sizing (Lőrinc)

Pull request description:

**Problem:** The four-argument `CBloomFilter` constructor is used by unit tests and the fuzz target to exercise Bloom filter sizing directly.
Zero elements make the hash-function calculation divide by zero.
The size calculation converts its floating-point result to `unsigned int` before applying the protocol limit, which is undefined for zero or invalid false-positive rates and for valid parameters whose calculated size exceeds the integer range.

**Fix:** Require false-positive rates in `[0, 1]`, construct the existing empty match-all state for zero elements, and use the largest permitted filter for a zero rate with positive elements.
Clamp the calculated size before its integer conversion so large valid inputs remain within the protocol limit.

ACKs for top commit:
rustaceanrob:
Code review ACK c4302ddf806094fcc2b1e21593e25b2038191a07
sedited:
ACK c4302ddf806094fcc2b1e21593e25b2038191a07
instagibbs:
ACK c4302ddf806094fcc2b1e21593e25b2038191a07

Tree-SHA512: 836d7a7602b4e508b57bc62fa93bff460a076155ca3973cdde9f0a5bcfc021573a72e8bf2e7477f2c6939074f0b959b6306ab55e929c8e704fab0d0b77734e12

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlfuzzing or regression evidencemerge-commit duplicate discount
AI analysis · Low 35/100

This commit fixes a bug in Bitcoin Core's Bloom filter constructor that could perform undefined math when given unusual inputs, such as zero elements or a zero/invalid false-positive rate. The fix adds input checks and special-case handling so the constructor no longer divides by zero, takes the logarithm of zero, or converts an out-of-range floating-point size to an integer. The affected constructor is used only in tests and fuzzing, not in normal peer-to-peer network code, so the practical risk to live Bitcoin nodes is low.

Lower-priorityMerge bitcoin/bitcoin#36714: net_processing: remove m_wtxid_relay_peersby merge-script · 40689f98 · Oct 31, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36714: net_processing: remove m_wtxid_relay_peers

7a840e29205e1383af33c4f51693e0dc44c2a9c7 net_processing: remove m_wtxid_relay_peers (fanquake)

Pull request description:

Replaced by `TxDownloadManagerImpl::m_num_wtxid_peers` in #30110.

ACKs for top commit:
Crypt-iQ:
crACK 7a840e29205e1383af33c4f51693e0dc44c2a9c7
jpk68:
ACK 7a840e29205e1383af33c4f51693e0dc44c2a9c7
darosior:
utACK 7a840e29205e1383af33c4f51693e0dc44c2a9c7
mzumsande:
Code Review ACK 7a840e29205e1383af33c4f51693e0dc44c2a9c7

Tree-SHA512: 588c7205b3c789ab024ad18adfc1f320e2a8542c640fd1ae546e7c5a9496f18ef0d70926a6dc1035f16a0ca82649999c86ec62b169261864bf43908531848ca2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36011: btcsignals: destroy callbacks on disconnectby merge-script · 862f6038 · Oct 31, 2026 · 2 filesMessage 100 · StrongLow 29Details
Commit message · merge-script

Merge bitcoin/bitcoin#36011: btcsignals: destroy callbacks on disconnect

a318b23131e6df2c64e8fe79cebc8e5babdf8b7f btcsignals: fall back to atomic_load/store without __cpp_lib_atomic_shared_ptr (Ryan Ofsky)
f1d786c1ef5d813f61e405370a67df4cc6323885 btcsignals: destroy callbacks eagerly on disconnect (Ryan Ofsky)
7c5571adc46857cfcf77d81b6fc135dee5369749 test: characterize btcsignals callback destruction timing (Ryan Ofsky)

Pull request description:

Currently callback functions connected to signals do not get freed when their `connection::disconnect` method is called or when their associated `scoped_connection` is destroyed. They live as long as the signal does, even if they will never be called, and can only get [garbage collected](https://github.com/bitcoin/bitcoin/blob/0fd515bbb7070a502dd2fe6d16f5f3cbac591283/src/util/btcsignals.h#L240-L241) if new connections are added.

This behavior is different that previous boost signals behavior and causes a [deadlock](https://github.com/bitcoin/bitcoin/actions/runs/31848571315/job/94919834743) on GUI shutdown in #10102 because when the node registers signal callbacks (`handleInitMessage`, etc) that get forwarded to the GUI, the callbacks own `mp::EventLoopRef` references, and if the callbacks aren't freed, the node process can't shut down.

This change restores boost signals behavior freeing callbacks when they are disconnected or when `scoped_connection` objects are destroyed to avoid this problem and make callback lifetimes more predictable.

ACKs for top commit:
hodlinator:
re-ACK a318b23131e6df2c64e8fe79cebc8e5babdf8b7f
sedited:
Re-ACK a318b23131e6df2c64e8fe79cebc8e5babdf8b7f

Tree-SHA512: 41be63f7adbb1d1556698624a1aaaf62b4c574a29c3f3a8f35505b3c70fda472b6c8d6009a7f13eabe5670657197d7c471720cbf0eb9474d76cf9e2b5852ce44

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 29/100

This change fixes a bug in Bitcoin Core's internal signal/callback system where callback functions and the resources they own were not released when disconnected. Previously, disconnected callbacks lingered until the signal itself was destroyed or new connections triggered garbage collection. This caused a real-world deadlock during GUI shutdown because node-to-GUI callbacks held references that prevented the node process from exiting. The patch makes callbacks get destroyed immediately on disconnect (or after any in-flight call finishes), matching the behavior of the older Boost signals library.

AI review queuedMerge bitcoin/bitcoin#36611: test: consolidate mempool constantsby Ryan Ofsky · ab7e668c · Oct 31, 2026 · 10 filesMessage 91 · StrongInformational 15Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36611: test: consolidate mempool constants

d8cca0c110b264be0cca69fb4c55ebee0e8152a7 test: use MAX_FUTURE_BLOCK_TIME from blocktools (fanquake)
9ee579b6cba087f2cdd74968b8098806e7510092 test: move DEFAULT_ANCESTOR_LIMIT to mempool_util (fanquake)
8f4caec89590b5bd8804c8f9e01d547f9e51533a test: consolidate DEFAULT_CLUSTER_LIMIT to mempool_util (fanquake)
75a611998e35508b5f90e94f8a77ab6d266e84ab test: add MAX_REPLACEMENT_CANDIDATES to mempool_util (fanquake)
aa7d0a5b582f92cc5be9544be7a0f395646e53c3 test: use TRUC constants from mempool_util (fanquake)

Pull request description:

Consolidate usage of mempool constants in the functional tests.
As well as one instance of `MAX_FUTURE_BLOCK_TIME`.

ACKs for top commit:
stickies-v:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7
mercie-ux:
re-ACK https://github.com/bitcoin/bitcoin/commit/d8cca0c110b264be0cca69fb4c55ebee0e8152a7
hodlinator:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7

Tree-SHA512: 8399f61e3fcc375863842a6ebae23ef48d38e7a6fc264888b671cc57401277c66f7f31a4aa414619b64e8bafceeb4dd2e3d9585113b221d0a3fe8c44589f8ce9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a test-only cleanup. It moves several hard-coded numbers used in Bitcoin Core's functional tests into a shared helper file so they are defined in one place. No production code, consensus rules, or network behavior were changed.

Lower-priorityMerge bitcoin/bitcoin#36701: ci: Disable tests on ARM32 in GHA yamlby merge-script · b048a3e8 · Oct 30, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36701: ci: Disable tests on ARM32 in GHA yaml

fa01c3c533b8d645a400d23e785d4467b07e8bb5 ci: Disable tests on ARM32 in GHA yaml (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/36602

Now that GitHub is spinning up Neoverse-V3 without a 32-bit mode, the CI fails on GHA.

Fix it by disabling the tests on GHA.

The tests can still be run locally (e.g. on a R-pi 4).

ACKs for top commit:
hebasto:
ACK fa01c3c533b8d645a400d23e785d4467b07e8bb5.

Tree-SHA512: ef4e6a4ddc7d5b0ee135bd316fc01853cacf71d5a6723aa666387113e0fcd1143b7a97c51e8cd5898a28dbe6eea9470d497c1a9e779947d51502321a5175fb66

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI review queuedMerge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details windowby Hennadii Stepanov · 43a33e51 · Oct 30, 2026 · 2 filesMessage 91 · StrongInformational 19Details
Commit message · Hennadii Stepanov

Merge bitcoin-core/gui#970: Remove legacy BIP70 merchant name from tx details window

fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962 Remove legacy BIP70 merchant name from tx details window (MarcoFalke)

Pull request description:

BIP70 is now dead for roughly half a decade. There is no need to print the merchant name in the tx details window, so remove that feature.

The parser has no tests, nor fuzzing, so removing it will likely also fix some parsing issues with corrupt data.

ACKs for top commit:
l0rinc:
lightweight code review ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962
fanquake:
ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962

Tree-SHA512: 082f8ae958f616f5b344c0da4800ceaafb7bbcf44180eb3f0915b9d4cfb3834e39e943186e383026b90ad3245ce4f61d529c568e2477be6f5b28e7fd9b6a55fe

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes an old feature in the Bitcoin Core wallet's transaction details window that displayed a merchant name for BIP70 payment requests. BIP70 is an outdated payment protocol that is no longer used. The removed code parsed certificate data in a simple, untested way. The change is described as a cleanup, but it also eliminates a small bit of code that handled untrusted data without proper validation.

Lower-priorityMerge bitcoin/bitcoin#36703: test: Sync blocks in test_witness_block in p2p_segwit.pyby merge-script · 07efc592 · Oct 30, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36703: test: Sync blocks in test_witness_block in p2p_segwit.py

fab8fd026cfb24c9f246fb60fbff155f3414bacd test: Sync blocks in test_witness_block in p2p_segwit.py (MarcoFalke)

Pull request description:

`test_witness_block` does not sync the blocks across nodes by default, so the test may intermittently fail.

Fixes https://github.com/bitcoin/bitcoin/issues/36700 by adding the sync.

ACKs for top commit:
Crypt-iQ:
crACK fab8fd026cfb24c9f246fb60fbff155f3414bacd

Tree-SHA512: e87d4f77a9f2ebf7dda3d846cd55b7bf7c533f069518c1d9954e18da62a4e94ac554789966197b0454e763cd4e0ede39de4b4befceb3f884a0d1ee47e4d160e3

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36594: net: make orphan reconsideration more granularby merge-script · 3c51322d · Oct 30, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36594: net: make orphan reconsideration more granular

83003cafaa81bb116526419246608658ede824b6 qa: test a single orphan is processed per peer turn, regardless of its validation result (Antoine Poinsot)
28a41e61ab5d993d344dc5c8180482eb146c6bd5 net: reconsider at most one orphan per call, whatever the validation result (Antoine Poinsot)

Pull request description:

We currently concentrate the validation of all the assigned peer’s reconsiderable orphans that are still missing inputs in a single message-processing turn. This ties orphan processing to validation result, and adds latency to processing other peers' messages.

Always process a single reconsiderable orphan per turn instead. This removes the need for an immediate validation result, and shifts the latency from other peers to the assigned peer.

ACKs for top commit:
fametrano:
tACK 83003cafaa81bb116526419246608658ede824b6
instagibbs:
ACK 83003cafaa81bb116526419246608658ede824b6
ViniciusCestarii:
ACK 83003cafaa81bb116526419246608658ede824b6
furszy:
ACK 83003cafaa81bb116526419246608658ede824b6

Tree-SHA512: b2f8003cd126dea4ada694cd90c5bb9a37c5c6b38b9053e06259a2ca46ebf8d5fce88d69b6f1ddd4db640cb5bfa1806587a5d3013bff8ea5c6b7febbaaec6b53

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queueddoc: use doxygen comments for blocks containing @paramby fanquake · 0e9ac2cb · Oct 30, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · fanquake

doc: use doxygen comments for blocks containing @param

Plain /* comments are ignored by Doxygen and by clang's -Wdocumentation,
so mistakes in them go unnoticed. Also wrap the CoinGrinder ASCII trees
in @verbatim so Doxygen keeps their layout.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes code comments. It converts plain block comments into Doxygen-style documentation comments (starting with /** instead of /*) so that developer documentation tools can read them. It also wraps ASCII art diagrams in special tags so they keep their formatting. There are no changes to actual program behavior, and no security impact.

AI review queueddoc: fix incorrect @param annotationsby fanquake · 68e8429b · Oct 30, 2026 · 7 filesMessage 45 · ThinInformational 15Details
Commit message · fanquake

doc: fix incorrect @param annotations

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation comments that describe whether function parameters are inputs, outputs, or both. No actual code logic was changed, so it cannot affect program behavior or introduce a security vulnerability.

AI review queuedMerge bitcoin/bitcoin#36071: refactor: fuzz: remove cost_of_change from coin-grinder fuzz targetby merge-script · d1fb1ba3 · Oct 30, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36071: refactor: fuzz: remove cost_of_change from coin-grinder fuzz target

5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc refactor: fuzz: remove cost_of_change from coin-grinder fuzz target (yancy)

Pull request description:

coin-grinder selection algorithm does not take cost_of_change as a parameter.

> CoinGrinder doesn’t use coin_params.m_cost_of_change and the comparison of selection results from CoinGrinder, SRD, and Knapsack does not need it either as only the weight of the selections is relevant. So, [line 96](https://github.com/bitcoin/bitcoin/blob/2990bd773551c835ab0b6b59d85730adab2fd428/src/wallet/test/fuzz/coinselection.cpp#L96) in that fuzz test is both incorrect and dead code. It should be removed.

cite: [stackexchange](https://bitcoin.stackexchange.com/questions/130861/difference-between-long-term-fee-rate-and-discard-fee-rate)

verified `coin_grinder` fuzz target still works after removal

ACKs for top commit:
brunoerg:
ACK 5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc
frankomosh:
ACK 5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc

Tree-SHA512: 46c4d5e22e342fdac918e52348b346a18b41478b0a8859675ee38819b45c57cc8a617bad507f3e810d346534d6875175f44ae1599533b3acc8123dafc1f69f14

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes one unused line from a fuzz test (a type of automated test that throws random data at code to find bugs). The removed line set a 'cost of change' value that the CoinGrinder coin-selection algorithm never actually reads. The change only affects test code, not the real Bitcoin wallet, and does not fix or introduce any security issue.

Lower-priorityMerge bitcoin/bitcoin#36663: test: Use single node in mempool_reorg.pyby merge-script · d14b94dd · Oct 30, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36663: test: Use single node in mempool_reorg.py

fa3aeb51cfb1f664627730ccfded040a16ad2e91 test: Extract first test case in mempool_reorg.py (MarcoFalke)
fa329d62c5194dd4e974bcb3cd314593d17b1a68 test: Use single node in mempool_reorg.py (MarcoFalke)
fabf5c52ccba619060610f3da181802c3b193478 test: refactor: Use trigger_reorg helper in mempool_reorg.py (MarcoFalke)

Pull request description:

`mempool_reorg.py` is a bit confusing:

* There is a `trigger_reorg` helper, but it is not used consistently.
* It tests tx trickle delay on node1, but the global args have immediate tx relay configured for node0.
* Using two nodes is not needed, in light of Python helpers to create forks and P2P connections.

So fix all issues by using a single node and the Python helpers.

ACKs for top commit:
jpk68:
ACK fa3aeb51cfb1f664627730ccfded040a16ad2e91
mercie-ux:
ACK fa3aeb51cfb1f664627730ccfded040a16ad2e91
Waridi318:
ACK fa3aeb5
darosior:
utACK fa3aeb51cfb1f664627730ccfded040a16ad2e91

Tree-SHA512: 3329624226ec699cfd6d6c4691e0dc7d510ba58c526a41a05ad06c616db2e168e31cf21b34a6806f4bfee9e87e11378bd1de867cc2e6f5d10ccf83483bee0f7e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36124: http: Make `HTTPRequest` update state internallyby merge-script · 6ed5aad0 · Oct 29, 2026 · 4 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36124: http: Make `HTTPRequest` update state internally

6a5212fb97c2c332fc3cb901f8e9a110622ef841 doc: Add missing names to activate grouping syntax (Hodlinator)
148210fe99bb54583fd47f2c39bf0b9390161185 refactor: Flatten HTTPRemoteClient::ReadRequest() into HTTPRemoteClient::TryReadRequestInternal() (Hodlinator)
9692e6f7d00f3fa5b1d57465730c8c50e090a06f refactor: Extract HTTPRemoteClient::TryReadRequestInternal() from static HTTPRemoteClient::TryReadRequest() (Hodlinator)
05897e53b2f92bcd28d2ced7ffd76d82b682b400 http: Extract HTTPRequest::Load() to remove SetState() (Hodlinator)

Pull request description:

### Issues in order of importance

#35829 made the fields of `HTTPRequest` & `HTTPRemoteClient` private, but still allows anyone with a reference to a request to update the internal state `enum`. https://github.com/bitcoin/bitcoin/pull/35829#discussion_r3860447518

`HTTPRemoteClient::TryReadRequest()` only needs to be a `static` method in order to forward a `shared_ptr` of a client to a new request.

### Commits solving these issues in same order

* http: Remove `HTTPRequest::SetState()` and introduce `HTTPRequest::Load()` - Removes the ability for other classes to directly modify the request state.
* 2 refactors: Extract `HTTPRemoteClient::TryReadRequestInternal()` from a combination of `HTTPRemoteClient::TryReadRequest()` and `HTTPRemoteClient::ReadRequest()` (the latter is removed)

ACKs for top commit:
pinheadmz:
ACK 6a5212fb97c2c332fc3cb901f8e9a110622ef841

Tree-SHA512: 57f4f76969e67a23261620faeddb665021532fd90055d2d8e1f67c1bae784d5cebd73a07069f8e5dcd751c9e1b5d0ca7b7b826f35136fc73c4e36458723e8628

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36606: test, bench: construct inputs/outputs declaratively in context-dependent casesby merge-script · 18953bd0 · Oct 29, 2026 · 5 filesMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36606: test, bench: construct inputs/outputs declaratively in context-dependent cases

bdf58dd89cc2fe2f0be5ac63755e821661022be6 test: construct transaction_tests test_Get inputs/outputs declaratively (Alexander Wiederin)
24d00c4539479415207d3b912ec3648b4020c4e0 bench: construct ccoins_caching inputs/outputs declaratively (Alexander Wiederin)
a45478aa27553d28479cb288bb2d33f917bc544b test: construct sigopcount_tests BuildTxs inputs/outputs declaratively (Alexander Wiederin)
524d554e2bf952082f7e621145ca1b3a4b81d6c7 test: construct CreateBlockChain coinbase declaratively (Alexander Wiederin)
60be0930ca92eeee960ef6a2d7e2c61ef03c93dd test: construct transaction_utils inputs/outputs declaratively (Alexander Wiederin)

Pull request description:

Part of https://github.com/bitcoin/bitcoin/issues/36692 (previously discussed in https://github.com/bitcoin/bitcoin/pull/35994): replace procedural, field-by-field construction of `COutPoint`, `CTxIn` and `CTxOut` in test code with constructor calls.

This PR covers cases that are context-dependent and need manual changes, independent of a scripted-diff for the trivial bulk:
- `test/util/transaction_utils`: in `BuildSpendingTransaction`, the `scriptWitness` assignment has to be moved after `vin` is replaced, otherwise the witness is dropped.
- `test/util/mining`: in `CreateBlockChain`, the coinbase input's fields were split by the output assignments, with comments that are now kept next to the constructor arguments.
- `sigopcount_tests`: `BuildTxs` has the same witness ordering issue as `BuildSpendingTransaction`.
- `bench/ccoins_caching`: The `scriptSig`s are built with `<<` appends, and the second output was created by `vout.resize(2)` but never assigned, so it is kept as a null `CTxOut{}`.
- `transaction_tests`: `test_Get` builds the same transaction as `bench/ccoins_caching`, with the same `<<` appends and null second output.

**This change is test- and bench-only and does not change the constructed transactions.**

Notes for reviewers:
- `CTxIn` has no witness constructor argument, so `scriptWitness` is assigned after `vin` is replaced.
- `BuildTxs` is called repeatedly on the same transaction objects. Previously, `resize(1)` kept the existing inputs and only overwrote some of their fields; now they are replaced entirely. The fields that were left untouched by `BuildTxs` are never modified by the test, so the transactions are unchanged.
- The null second output in `ccoins_caching` is copied from `test_Get` in `transaction_tests` and looks like an oversight. It is kept here to avoid behaviour changes.

ACKs for top commit:
maflcko:
review ACK bdf58dd89cc2fe2f0be5ac63755e821661022be6 🍠
purpleKarrot:
But even when the approach does not follow the steps 1 and 2, it is a step in the right direction, hence ACK bdf58dd89cc2fe2f0be5ac63755e821661022be6

Tree-SHA512: af4c7489ddc553eda466b7ac4ca33cff400a495264b8cb2d869929e108fab8dac08f3cc164be79a3505b7c8b461514fc6f87f5afd42919f0712dd1d325d824b7

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code cleanup inside Bitcoin Core's tests and benchmarks. It replaces a manual, field-by-field way of building fake transactions with a more direct constructor style. The author explicitly states that the actual transaction data being built is unchanged, and the diff confirms the values and structure stay the same. There is no security issue here.

Security candidateMerge bitcoin/bitcoin#29843: policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)by merge-script · 05187ec2 · Oct 29, 2026 · 8 filesMessage 100 · StrongInformational 22Details
Commit message · merge-script

Merge bitcoin/bitcoin#29843: policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)

1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a doc: add release note for -acceptnonstdtxn changes (Anthony Towns)
1df5910720495eb2e8e453fb40da222dd794424a validation: Add compile-time checks for consensus flags (Anthony Towns)
425115713c5e37e78c9051b1b0a997ad62067ec8 validation: Check only (potential) block script flags when -acceptnonstdtxn is set (Anthony Towns)
703ebdf9de87ffb6010d89e3f0bd49e3c6cdb030 validation: Be explicit about whether CheckInputScripts is for block/mempool (Anthony Towns)
81ef18236fc74913344bd9e28b1e27a50a4e3ae7 tests: test tx rejection for both -acceptnonstdtxn=0 and 1 (Anthony Towns)
9b6342e5d295e337791984af2d42681d9c8e08bb tests: in p2p_segwit, check non-mandatory errors with -acceptnonstdtxn=0 node (Anthony Towns)

Pull request description:

This PR changes `-acceptnonstdtxn=1` so that it also skips the non-mandatory script checks, allowing txs that (eg) use OP_NOPx or OP_SUCCESS into the mempool. This remains only available on test nets.

ACKs for top commit:
fjahr:
reACK 1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a
instagibbs:
reACK 1176a20d5263d6ae7ff80398928a2a5b1a0ebd6a

Tree-SHA512: 6157072c98369d06642bd7383bfabe82a4054a1f204b7a669a90b01429a2104e8815bd20785b11910f1b4d578db11e8a5a71f7f043d1aad083ec120233c9690c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 22/100

This change loosens transaction acceptance rules only on Bitcoin test networks when a special command-line option (-acceptnonstdtxn=1) is used. It lets developers test unusual or experimental scripts in the mempool, while still enforcing all consensus rules that protect real money. Main network behavior is unchanged, and the option is not available there.

AI review queuedMerge bitcoin/bitcoin#36682: refactor: Use std::erase and std::erase_ifby merge-script · 363d9e9d · Oct 29, 2026 · 13 filesMessage 93 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36682: refactor: Use std::erase and std::erase_if

fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e refactor: Use std::erase and std::erase_if over iterator-based erase (MarcoFalke)
fa93a02563145aca3f96badaabe302b2dfa331d5 refactor: Use std::erase and std::erase_if over list removal or vector erase-remove (MarcoFalke)

Pull request description:

Convert `remove` and `remove_if` to the C++20 `std::erase` and `std::erase_if` overloads.

The legacy ones can be confusing, because:

* Array-based containers (like vector) must use the erase-remove idiom. Forgetting the erase, or forgetting to pass the end iterator (`bugprone-inaccurate-erase`) can be a bug, see also https://github.com/bitcoin/bitcoin/pull/36588#discussion_r4345799022. So a call only to "remove" will not erase.
* Node-based containers (like list or set) must not use the idiom. Using it will be a pessimization or won't compile. And correctly not using the idiom reads confusing, because a call to "remove" will actually erase.
* They are more verbose.

Also convert simple iterator-erase (which is verbose, but fine) to the std overload.

ACKs for top commit:
jpk68:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e
hodlinator:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e
w0xlt:
ACK fa87bfe31dfda2d102c4e0cb5d39813cf84c7d1e

Tree-SHA512: 08fca3ecb73a5c45371a2e65339d9e35911f89dc717568cc29564f1a1395a44d84e939b9d38a21cadf5f2cbd64463c2564b1f7239ca75f53cf0bb30ae724dafd

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathparser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code cleanup that replaces older, more verbose ways of removing items from lists and vectors with newer C++20 standard helpers called std::erase and std::erase_if. It does not change what the program does, only how the source code expresses it. There is no security bug being fixed here.

Lower-priorityMerge bitcoin/bitcoin#35714: validation: return block-file flush errorsby Ryan Ofsky · 9bf4815b · Oct 28, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#35714: validation: return block-file flush errors

12f691cf286ea9a020583d267b94efca102a4056 validation: return block-file flush errors (Lőrinc)
07d23eb75527b8dd6571a33b3bc304815764bc07 test: characterize writes after flush failure (Lőrinc)

Pull request description:

**Problem:** When flushing block or undo data fails, `FlushStateToDisk()` still writes block-index metadata and coins data, then advances `m_last_flushed_block`.
With a separate `-blocksdir`, persistent failures there can leave metadata referring to block data that is not durable even when chainstate writes succeed.

**Fix:** Return the flush error before those writes, leaving the last-flushed marker and on-disk coins tip unchanged in the failing call.
Later flushes can retry and write if they succeed, including during shutdown.
`ConnectTip()` and `DisconnectTip()` propagate the error before updating the chain tip, after applying the coins changes in memory.

**History:**
* [#27866](https://github.com/bitcoin/bitcoin/pull/27866#discussion_r1297313148) raised whether saving other state after a flush failure was preferable. This change preserves later retries while skipping writes in the failing call.
* [#34897](https://github.com/bitcoin/bitcoin/pull/34897) introduced `m_last_flushed_block` to prevent persistent indexes from advancing past flushed chainstate. This fix keeps it at the last successful flush.

ACKs for top commit:
optout21:
reACK 12f691cf286ea9a020583d267b94efca102a4056
arejula27:
reACK 12f691cf286ea9a020583d267b94efca102a4056
pzafonte:
reACK 12f691cf286ea9a020583d267b94efca102a4056
maflcko:
review ACK 12f691cf286ea9a020583d267b94efca102a4056 👟
ryanofsky:
Code review ACK 12f691cf286ea9a020583d267b94efca102a4056. Thanks for putting the test first, it makes the behavior change easy to verify.

Tree-SHA512: 227d7836918b457ed4afcab0ece67d7dd717876e967483cd773eefc7a790c0f1b940a67c9023341223b08b2a17260912a2bcfef04154815d103bf9dbaeb6d82e

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount