Bitcoin Core

This commit simply removes two outdated code comments (TODOs) from a Bitcoin Core wallet file related to external signers. No actual code behavior was changed, so it does not fix or introduce any security issue on its own.

This commit removes unused global pointer variables in three test-only fuzzing files. It is a code cleanup change to silence compiler warnings and has no effect on the live Bitcoin Core software that users run.

This commit only adds a new test case to Bitcoin Core's test suite. It verifies that a 65535-byte data push in Bitcoin scripts is considered 'minimal' only when encoded with OP_PUSHDATA2, not OP_PUSHDATA4. The commit does not change any production code, so it cannot directly introduce or fix a live vulnerability. It is a regression test that documents an existing consensus rule boundary.

This is a developer tooling fix for a Python script that generates manual pages for Bitcoin Core. The script was failing on non-English systems because bitcoin-qt's version and help output was translated, causing an assertion to fail. The fix forces English output by adding --lang=en. It does not change any user-facing code, network behavior, or wallet handling.

This is a large but purely cosmetic cleanup commit. It removes unnecessary '&' captures from C++ lambda functions used to define Bitcoin RPC commands. The code behavior is unchanged; the change only makes the source code slightly cleaner and avoids compiler warnings about unused captures.

This commit is a purely cosmetic rename of a C++ class used to define Bitcoin RPC commands. Every occurrence of 'RPCHelpMan' is replaced with 'RPCMethod' across 27 source files using an automated script. No behavior, logic, or security properties of the software change.

This commit simply archives the release notes for Bitcoin Core version 28.4. It is a documentation-only change that adds a markdown file summarizing what went into the release. There is no code change and no security issue introduced or fixed by this commit itself.

This commit is a hardening change for Bitcoin Core's test code. It removes most uses of shutil.rmtree, a Python function that recursively deletes directories, because it could accidentally wipe out the wrong folder if a test variable ever pointed somewhere unexpected. The patch replaces those calls with safer alternatives: a new cleanup_folder helper that refuses to delete anything outside the test's temporary directory, tempfile.TemporaryDirectory which cleans itself up, or explicit removal of known files. It also adds a lint rule to prevent new rmtree uses in test code. This is a defensive, preventive fix in the test suite, not a fix for an active security bug in the running Bitcoin node software.

This commit is a defensive cleanup: it removes almost all uses of a filesystem function called remove_all() that can wipe out entire directory trees, and adds an automated lint check to prevent it from being reintroduced. The changes only affect benchmark and test code, not the live Bitcoin wallet or node software that ordinary users run. It reduces the risk of accidental data loss during testing, but does not fix an active security bug.

This commit removes an unused command-line option called --keepcache from Bitcoin Core's functional test runner. It is a cleanup change that switches test cache handling to an automatic temporary directory. There is no security relevance.

This commit only updates a documentation file (doc/cjdns.md) describing how to use Bitcoin Core with the CJDNS network. It removes outdated manual peering instructions and replaces them with current upstream CJDNS v22 guidance about automatic peer discovery via DNS seeding. No code, configuration defaults, or security behavior of Bitcoin Core is changed.

This commit adds a new public API to Bitcoin Core's kernel library that lets outside callers run basic sanity checks on a raw Bitcoin block (for example, checking size limits, coinbase structure, and optionally proof-of-work and the merkle root). It is purely an addition of a new validation entry point and its tests. There is no bug fix, no change to existing consensus logic, and no indication of a security issue.

This commit is a simple variable rename inside Bitcoin Core's continuous integration (CI) scripts. It changes the name `TIDY_LLVM_V` to `IWYU_LLVM_V` in scripts that run the 'Include What You Use' (IWYU) code-analysis tool. There is no change to the Bitcoin software that users run, no change to security logic, and no fix for a vulnerability.

This commit adds a new public API to the Bitcoin Core library that lets outside programs read the network's consensus parameters (like block timing rules) from the existing chain parameters object. It does not change any validation logic or security behavior; it only exposes data that was already available internally in a more convenient way for library users.

This commit is a small internal code cleanup in Bitcoin Core's private transaction-broadcast feature. It wraps an existing list of per-peer send records inside a new 'TxSendStatus' container and adds a timestamp for when each transaction was first added. There is no change to network behavior, no bug fix, and no security-relevant change visible in the diff.

This commit simply adds a new optional information block called 'backgroundvalidation' to the getblockchaininfo RPC output. It exposes read-only status about an existing background chain-validation process, plus some minor capitalization fixes in help text. There is no security-relevant change.

This commit only adds a new automated test that checks what information the getblockchaininfo RPC returns about a background validation process. It does not change any production code, network behavior, or wallet logic, so it cannot introduce a security vulnerability or fix one.

This commit is a documentation-only release note. It describes a new RPC feature that exposes background validation progress for the assumeutxo feature. There is no code change, no bug fix, and no security issue.

This commit only changes how Bitcoin Core calculates and prints a progress percentage in log messages during a special background validation mode (used with the assume-utxo feature). It does not change consensus rules, network behavior, wallet handling, or any security-critical logic. The old code could show a misleading progress number; the new code makes the log estimate more accurate. There is no security vulnerability here.

This is a small internal cleanup change for a Bitcoin Core function that calculates statistics about the unspent coin set (used by the gettxoutsetinfo RPC). It moves where a variable is declared and refactors how the statistics object is built so the code is easier to read. There is no direct security fix in this commit itself; it is described as a follow-up to a prior pull request that addressed a race condition.

This is a tiny code cleanup in Bitcoin Core's networking code. It removes an unnecessary conversion of a string-like variable to std::string before passing it to a function that accepts std::string_view. There is no security impact.

This commit adds a new automated build test for Bitcoin Core that compiles the software for FreeBSD from a Linux machine. It does not change any Bitcoin code, wallet logic, networking, or security behavior. It only affects internal continuous integration (CI) scripts.

This commit adds FreeBSD to the list of operating systems for which Bitcoin Core's build system will compile the optional QR code generation library (qrencode). It is a one-line build configuration change with no apparent security relevance.

This commit updates Bitcoin Core's build system to support cross-compiling FreeBSD binaries using Clang and the LLVM toolchain. It changes compiler and linker settings in makefiles used only during the build process. There is no indication this fixes or introduces a security vulnerability.

This commit changes how Bitcoin Core builds the Qt GUI library on FreeBSD. It disables Qt's inotify feature during the build process. Inotify is a Linux-style file-change notification mechanism that Qt tries to use on FreeBSD, but it can cause build or runtime problems because FreeBSD's support differs. The change is a build-system compatibility fix; there is no direct evidence in the commit that it fixes an exploitable security vulnerability.