BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 1 minute ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36580: refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailureby merge-script · 504aab70 · Nov 4, 2026 · 3 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36580: refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailure

fafbcadc1bc512e16154649984d48b60a54f5f9d refactor: Use util::log::FormatString in BaseIndex::FatalErrorf and LogConnectFailure (MarcoFalke)

Pull request description:

Both functions format a message that is ultimately logged, so it must not contain a redundant trailing newline. Otherwise, it could lead to escaped \x0a inside log messages.

This continues https://github.com/bitcoin/bitcoin/pull/36397

ACKs for top commit:
stickies-v:
ACK fafbcadc1bc512e16154649984d48b60a54f5f9d
sedited:
ACK fafbcadc1bc512e16154649984d48b60a54f5f9d

Tree-SHA512: 426d56e74fda757ede0213b8919aef175f73880b3a6e648d016f1a20631810b425680919b2f843da06fd49560119bea65926ddaa5c83bfe927cdf5b621254115

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36601: test: avoid reusing AssumeUTXO coin insertion method in test fixturesby merge-script · e319d306 · Nov 4, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36601: test: avoid reusing AssumeUTXO coin insertion method in test fixtures

1c62336903ccf5f7f2aa1217eaf8344dee4e197a test: avoid snapshot insertion in coin fixtures (Lőrinc)

Pull request description:

**Problem:** Several coin-cache fixtures use `EmplaceCoinInternalDANGER` just to set up their coins, even though it is reserved for snapshot loading.

**Fix:** Use `AddCoin` and `SpendCoin` for fixture setup, keeping the entries dirty but not fresh, as before. Keep the [simulation](https://github.com/bitcoin/bitcoin/pull/33512), [fuzz and duplicate-insertion coverage](https://github.com/bitcoin/bitcoin/pull/32313) that intentionally tests the bypass.

This is a small extraction from #36598 that can be reviewed and merged independently of the broader AssumeUTXO removal demo. The overlay fixture change also follows the earlier [suggestion in #35295](https://github.com/bitcoin/bitcoin/pull/35295#discussion_r3421846300).

ACKs for top commit:
Hamza1610:
Tested ACK 1c62336903
sedited:
ACK 1c62336903ccf5f7f2aa1217eaf8344dee4e197a

Tree-SHA512: c67cee9efaa7cf56a76ee51bb1274033e6f618e14c15c2f0f3e7625b6e401417c71e9bb956cbff2e9c937453b106a5e469ad8bc391343d86838d39d9f99a89df

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36617: test: Fix intermittent issue in p2p_orphan_handling.pyby merge-script · 102f7830 · Nov 4, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36617: test: Fix intermittent issue in p2p_orphan_handling.py

faf819bf23e8752644695e332cc00413d94af938 test: Fix intermittent issue in p2p_orphan_handling.py (MarcoFalke)

Pull request description:

Turns out https://github.com/bitcoin/bitcoin/pull/32092 was incomplete and the issue can still happen:

https://github.com/bitcoin/bitcoin/actions/runs/39809026827/job/119929911875#step:14:14454

The basic idea is that peer1 disconnects to clear its orphan state. This happens in `DisconnectNodes`->`DeleteNode`->`FinalizeNode`->`TxDownloadManager::DisconnectedPeer`.

In my prior fix, I assumed that `DisconnectNodes` in the `net` thread would be possible to sync on via a ping-pong. However, the msghand thread may hold a reference to the node, preventing deletion and only moving the node to `m_nodes_disconnected`. Afterward, the `net` thread may hand the pings to the `msghand` thread and go to sleep for a bit.

Thus, the test proceed and cause a split `getdata`, meaning that `peer2.wait_for_parent_requests([int(parent_peekaboo_AB["txid"], 16), int(parent_missing["txid"], 16)])` fails.

Fix this by just waiting for `TxDownloadManager::DisconnectedPeer` to have happened via `self.wait_until(lambda: len(node.getorphantxs(verbosity=2)[0]["from"]) == 1)`.

Edit: Possible diff to reproduce with ~10% failure rate:

```diff
diff --git a/src/net.cpp b/src/net.cpp
index 1201d3bcb4..e81623484b 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -2229,2 +2229,3 @@ void CConnman::SocketHandlerConnected(const std::vector<CNode*>& nodes,
WakeMessageHandler();
+ UninterruptibleSleep(333ms *m_nodes_disconnected.size());
}
@@ -3261,2 +3262,3 @@ void CConnman::ThreadMessageHandler()
}
+ UninterruptibleSleep(33ms);
}
```

Cmd: `./bld-cmake/test/functional/test_runner.py $(for i in {1..20}; do echo -n "p2p_orphan_handling.py ";done) -j $( nproc )`

ACKs for top commit:
Conradgabe:
crACK faf819bf23e8752644695e332cc00413d94af938
sedited:
ACK faf819bf23e8752644695e332cc00413d94af938

Tree-SHA512: 062e152be3d8f90cb5c9b3b533a7cacff3db21aaca16d6e7768867577a442a6e978fd8950d17d43a3467d162cea70a174de306da8bc558aa5f0b7c390f01c78c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36670: fuzz: check GetStale() returns exactly the stale private broadcast txsby merge-script · bfab449b · Nov 4, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36670: fuzz: check GetStale() returns exactly the stale private broadcast txs

4f3dcb76ab35ed6fe7d81e4997d36333efff12b9 fuzz: check GetStale() returns exactly the stale private broadcast txs (frankomosh)

Pull request description:

The `private_broadcast` fuzz test checks each tx that `GetStale()` returns. This adds to it by checking that all stale txs are returned. `ReattemptPrivateBroadcast()` only retries what `GetStale()` returns, and a stale tx left out is never retried.

This partly came up during review in https://github.com/bitcoin/bitcoin/pull/35129#pullrequestreview-4427536924, and recently also surfaced in https://mutanthub.space/mutants/3752 , where changing `continue` to `break` in `GetStale()` passes all current tests.

This PR records when each tx is added and when each node confirms it. Then it checks that `GetStale()` returns exactly the expected txs.

ACKs for top commit:
andrewtoth:
ACK 4f3dcb76ab35ed6fe7d81e4997d36333efff12b9
sedited:
ACK 4f3dcb76ab35ed6fe7d81e4997d36333efff12b9

Tree-SHA512: e88c5773c4d38b6c2fba29fd715d277ef943c240fc8dc839744ec7546afe14cd7a31b4d8808c624274376500f6d46939aa19d31abc5ac167652411fd90dba1b9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36539: gui: Use PSBT v0by Ava Chow · 5965d476 · Nov 4, 2026 · 8 filesMessage 86 · StrongLow 35Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36539: gui: Use PSBT v0

3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0 refactor: psbt: Don't set a default version for PSBT constructor (David Gumberg)
23dcb03a2c6b9fed84896ac4d751ba9e8034a6bf gui: wallet: Use v0 PSBT (David Gumberg)

Pull request description:

This fixes: https://github.com/bitcoin/bitcoin/issues/36518

There is no test added here for the bump fee PSBT's being v0, since there aren't any existing tests for watch only wallet feebumping in the GUI. If reviewers insist on this I can add it, but I wanted to keep the diff minimal. I have tested this manually.

AFAIU for the external signer stuff it shouldn't matter much whether it's v0 or v2, since users are very unlikely to be using HWI software that doesn't speak v0, but out of caution I've set the external signer PSBT to v0 for the GUI.

_This PR originally took the approach of adding a checkbox, ([davidgumberg/gui/2026-10-15-psbt-gui](https://github.com/davidgumberg/gui/tree/2026-10-15-psbt-gui)), but this was dropped to simplify backporting past string freeze._

_LLM Disclosure: The previous approach was drafted using an LLM, but this branch was written by me. I used an LLM to explore adding a fee bump watchonly GUI test, and decided against it._

ACKs for top commit:
Sjors:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
achow101:
ACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0
w0xlt:
crACK 3fdc45d1fa2a6f32f251aa6f639a52bbfd5245b0

Tree-SHA512: 9f157aed7c2b3395e51322a9f7ff54879e6e3ee2913ea532922291f7ba055b8294c850b430fb0193759cdae0a041109ce57cb924bc2ed2d429e005041a8da0da

86/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 35/100

This change makes the Bitcoin Core graphical wallet produce older PSBT v0 files instead of PSBT v2 in several common user flows (creating unsigned transactions, bumping fees). PSBT v2 is newer and not supported by some older external signer tools/hardware wallet software. By defaulting to v0 in the GUI, the wallet stays compatible with more hardware signing tools. The change also removes the automatic default version from the PSBT constructor so callers must explicitly choose a version. This is a compatibility/usability fix, not a fix for theft-of-funds or remote code execution.

Lower-priorityMerge bitcoin/bitcoin#36348: doc/i2p: mention -privatebroadcast bypasses persistent addressby merge-script · 94181c18 · Nov 4, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36348: doc/i2p: mention -privatebroadcast bypasses persistent address

4307c2e0b01765932ad9518c63b764ef8dd16927 doc/i2p: mention -privatebroadcast bypasses persistent address (jpk68)

Pull request description:

It is not entirely accurate that persistent I2P addresses are used for making outbound connections and accepting incoming ones, as the `-privatebroadcast` option forces the use of a new transient destination for each transaction it relays.

ACKs for top commit:
davidgumberg:
text ACK https://github.com/bitcoin/bitcoin/commit/4307c2e0b01765932ad9518c63b764ef8dd16927
sedited:
ACK 4307c2e0b01765932ad9518c63b764ef8dd16927

Tree-SHA512: fc7bd4f7f2e29bd7110c9fcf8a509ceacb66c3745b67bce6764948bae61e50bdd6b1301c2126b4a024c4d90ee60ca2bb3192ac6626a5deb569338c550cb22a0c

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36679: ci: enable IPC in the i686 jobby merge-script · 037a33de · Nov 4, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36679: ci: enable IPC in the i686 job

65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd ci: Enable IPC in the i686 job (Sjors Provoost)

Pull request description:

Enable IPC on 32-bit x86. It was chosen arbitrarily in #31802 to have coverage for `-DENABLE_IPC=OFF`, but this was not a good choice given issues like:
- https://github.com/bitcoin-core/libmultiprocess/pull/383

I could not find a good candidate CI configuration to disable IPC.

It's still disabled on Windows, until #32387. It's also disabled on RISC-V.

ACKs for top commit:
maflcko:
Otherwise, lgtm ACK 65ddcb4f35c5fd315ecb9d9a6d0f076b37edcadd

Tree-SHA512: 2d3262a25f6af27240dbd74244521e6e3a30bfc707ffffc6bdb9802d9458d5f27d2ca06eb6ef084fc19695e955d151f0aec2bb9c73134423de888740eac19f3d

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36686: test: cover cumulative input value range in CheckTxInput tests.by merge-script · a0ebf34b · Nov 4, 2026 · 1 fileMessage 96 · StrongInformational 14Details
Commit message · merge-script

Merge bitcoin/bitcoin#36686: test: cover cumulative input value range in CheckTxInput tests.

98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 test: cover negative input in CheckTxInputs (KY-U)
133714d1695bc40277b213afd252c3e320cac73e test: cover cumulative input value range in CheckTxInputs (KY-U)
f8c6cd84e08043f206ca338d0ba7e4dc8bef5214 test: support multiple inputs in CheckTxInputs test helper (KY-U)

Pull request description:

In `Consensus::CheckTxInputs`, the inputs are invalid if, for every input coin, either `coin.out.nValue` or `nValueIn` is out of range. However, the current `checktxinputs_invalid_transactions_test` only covers cases with one input, so the sum `nValueIn` is always equal to `coin.out.nValue`, leaving the [following mutant](https://mutanthub.space/mutants/275) alive.
```diff
--- a/src/consensus/tx_verify.cpp
+++ b/src/consensus/tx_verify.cpp
@@ -189,7 +189,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, TxValidationState& state,

// Check for negative or overflow input values
nValueIn += coin.out.nValue;
- if (!MoneyRange(coin.out.nValue) || !MoneyRange(nValueIn)) {
+ if (!MoneyRange(coin.out.nValue) && !MoneyRange(nValueIn)) {
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-inputvalues-outofrange");
}
}
```
https://github.com/bitcoin/bitcoin/pull/36686/commits/f8c6cd84e08043f206ca338d0ba7e4dc8bef5214 adds support for multiple inputs in the test helper.

https://github.com/bitcoin/bitcoin/pull/36686/commits/133714d1695bc40277b213afd252c3e320cac73e adds a test case with multiple valid inputs, whose sum exceed `MAX_MONEY`, while also having `nValueIn` != `coin.out.nValue`, killing the mutant.

https://github.com/bitcoin/bitcoin/pull/36686/commits/98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 adds a test for uncovered negative input case.

ACKs for top commit:
mercie-ux:
reACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1
ViniciusCestarii:
ACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1 nice!
sedited:
ACK 98f9eb6afdfd2bb1cd2872bd7d2eb439ec2043a1

Tree-SHA512: 1199a03bcc85ee56317f0d3089c03a3dd3116868630174c0ee26523c9e6d86370065e830a476e1c573b2504e5c45487c77d50e25e64f2e20e7c1dadaa12eb2b4

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetyconsensus or confidential-proof validationsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 14/100

This commit only adds new test cases to Bitcoin Core's test suite. It does not change any production consensus, validation, or networking code. The tests verify that an existing check in the transaction validation logic correctly rejects transactions with out-of-range input values, including cases with multiple inputs. There is no security vulnerability being fixed here—only test coverage is being improved.

Security candidateMerge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txidby merge-script · fef06b86 · Nov 4, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36685: wallet: export replaces_txid and replaced_by_txid

bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0 wallet: export replaces_txid and replaced_by_txid (Vasil Dimov)

Pull request description:

Export the fields `replaces_txid` and `replaced_by_txid` from `wallet::CWalletTx` to `interfaces::WalletTx`.

In May 2026 https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c hooked a usage of `interfaces::WalletTx::value_map["replaces_txid"]` and `interfaces::WalletTx::value_map["replaced_by_txid"]` into the QML GUI.

Then, in June 2026 https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497 removed the map entirely from the main repository, but the `replaces_txid` and `replaced_by_txid` fields were not exposed in `interfaces::WalletTx`. Thus the QML GUI has no access to them.

Export the fields to solve this.

The QT5 GUI never used those.

ACKs for top commit:
pseudoramdom:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
johnny9:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
sedited:
ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0

Tree-SHA512: 2dcfd67ef2cca6bef778911d3e8039a91d3eca5d26d4ca7a83c31ebba71aced8b3b7add825baa001f2466ba6e4e7180764fe5d0a8ff99ebe98eb7c80635d385e

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit simply exposes two existing transaction-replacement identifiers (replaces_txid and replaced_by_txid) through an internal wallet interface so that a future QML-based user interface can read them. It is a straightforward data plumbing change with no security implications.

Lower-priorityMerge bitcoin/bitcoin#36619: rest: don't log an error for /spenttxouts on a block without undo databy merge-script · 59cadd7c · Nov 4, 2026 · 2 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36619: rest: don't log an error for /spenttxouts on a block without undo data

eebc145847b4f05da61e95fcae1b420a6ce3ea0f rest: don't log an error for /spenttxouts on a block without undo data (Kanan)

Pull request description:

`/rest/spenttxouts/<hash>` reads the undo file for every block above genesis. For a block that was stored but never connected (a side branch) or whose undo data was pruned, there is no undo position, so `OpenUndoFile()` fails and `ReadBlockUndo()` writes `OpenUndoFile failed for FlatFilePos(nFile=-1, nPos=0)` to debug.log with `LogError`. The request itself already returns 404, but each unauthenticated request for such a block adds an `[error]` line that looks like disk corruption.

This checks `CheckBlockDataAvailability()` for `BLOCK_HAVE_UNDO` before reading, so nothing is logged. Pruning clears `BLOCK_HAVE_UNDO`, so pruned blocks are covered too. The response is unchanged.

The new check at the end of `interface_rest.py` requests a stale block and fails on master because of the logged error.

ACKs for top commit:
maflcko:
review ACK eebc145847b4f05da61e95fcae1b420a6ce3ea0f 🛠
stickies-v:
re-ACK eebc145847b4f05da61e95fcae1b420a6ce3ea0f
sedited:
ACK eebc145847b4f05da61e95fcae1b420a6ce3ea0f

Tree-SHA512: 39a8267870f71ea0e9cfb7a4d362cf61b91dd5f4a295ce037aa2cd504983be2a298ada9ea047533a6b61f0219ca2fd56f7f2d5a4a4ab5aebe2eaa9dc66f62400

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36754: test: Use `contains` in miniminer_testsby merge-script · 31d8f587 · Nov 4, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36754: test: Use `contains` in miniminer_tests

158a9868f5395cb3761a61adfabf73a768b67a93 test: Use `contains` in miniminer_tests (rustaceanrob)

Pull request description:

These tests use `count` which is then cast to a boolean, but we can check `contains` here directly. This is a tidy failure in #35713 but it seems fine to update here regardless of what happens with #35713.

ACKs for top commit:
fanquake:
ACK 158a9868f5395cb3761a61adfabf73a768b67a93
sedited:
ACK 158a9868f5395cb3761a61adfabf73a768b67a93

Tree-SHA512: b65f833d791b5f0aeb64760039118ad08a56efdee52a1931943ea8a542896ec62ee5c8e5e011048b415f2134901ee5dad8e568ef8e23cefcb7232c0678f941ed

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36632: kernel: document the import_blocks abortby merge-script · 6355c9f8 · Nov 4, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36632: kernel: document the import_blocks abort

2077d1571ee98f8b2fba611e8bdfc73797b8bd3f kernel: document the import_blocks abort (Ferdinando Ametrano)

Pull request description:

A second btck_chainstate_manager_import_blocks call on the same chainstate manager, while one is in progress, aborts the process, and the kernel header does not say so. I document it. The abort is the assert in ImportingNow in node/blockstorage.cpp, which I keep.

ACKs for top commit:
sedited:
ACK 2077d1571ee98f8b2fba611e8bdfc73797b8bd3f

Tree-SHA512: 0dd6d3d744d3c27429652c6447268eefcab09723996b084954ec9a66b79312c6ac08e8ae1b8a5eb1fe214ee0988c36013f7fce033c65815faeeae84c4a87aa90

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36578: p2p: clean up a 1p1c package child that is already in the mempoolby merge-script · d97f027a · Nov 4, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36578: p2p: clean up a 1p1c package child that is already in the mempool

9e8e61ae8e398f36c52c7eb2c4e57f2359c9db8d p2p: clean up a 1p1c package child that is already in the mempool (Greg Sanders)

Pull request description:

An orphan that enters the mempool other than through peer relay (e.g. by
RPC) stays in the orphanage, so Find1P1CPackage can pick it as the child
of a reconsiderable parent, and package evaluation then reports it as
MEMPOOL_ENTRY, which hits Assume(false). Have Find1P1CPackage erase such
children from the orphanage and skip them.

ACKs for top commit:
ismaelsadeeq:
reACK 9e8e61ae8e398f36c52c7eb2c4e57f2359c9db8d
marcofleon:
ACK 9e8e61ae8e398f36c52c7eb2c4e57f2359c9db8d

Tree-SHA512: 1ad187ed5261af0aab97d0074963926cabd9de0cae0606b58a26a9575ce61b093e7be06d9b3206ceea613d796b96e99ff1760205ed91b3677cb8b0afe9f9628d

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36254: bench: add and use undo-data for BlockToJsonVerbosity3 benchby merge-script · f103de70 · Nov 4, 2026 · 3 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36254: bench: add and use undo-data for BlockToJsonVerbosity3 bench

0771dd89d6eec31ea39f25b283aacbf2092c7c15 bench: add undo-data for BlockToJsonVerbosity3 (0xb10c)

Pull request description:

blockToJSON only includes prevouts and fees when we have undo-data. The benchmarks did not have any undo-data, so `TxVerbosity::SHOW_DETAILS` and `TxVerbosity::SHOW_DETAILS_AND_PREVOUT` did exactly the same work.

This adds the 136 KB of undo-data of block 413567 and uses it in the benchmarks.

```
$ ./build/bin/bench_bitcoin --filter=BlockToJson.* -min-time=5000
```

Before:

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 10,273,470.25 | 97.34 | 0.2% | 5.51 | `BlockToJsonVerboseWrite`
| 104,973.68 | 9,526.20 | 0.1% | 5.51 | `BlockToJsonVerbosity1`
| 17,071,753.65 | 58.58 | 0.1% | 5.52 | `BlockToJsonVerbosity2`
| 17,256,754.10 | 57.95 | 0.1% | 5.51 | `BlockToJsonVerbosity3`

Note that the `BlockToJsonVerbosity2` and `BlockToJsonVerbosity3` times were the same.

After:

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 16,207,066.75 | 61.70 | 0.7% | 5.45 | `BlockToJsonVerboseWrite`
| 109,119.99 | 9,164.22 | 0.4% | 5.59 | `BlockToJsonVerbosity1`
| 17,907,169.45 | 55.84 | 0.1% | 5.49 | `BlockToJsonVerbosity2`
| 34,274,126.50 | 29.18 | 0.1% | 5.30 | `BlockToJsonVerbosity3`

- `BlockToJsonVerboseWrite`: slower as it now also writes the prevouts too
- `BlockToJsonVerbosity1`: unchanged
- `BlockToJsonVerbosity2`: slightly slower as we now read the undo-data and calculate the fee field
- `BlockToJsonVerbosity3`: slower as it's using undo-data now

ACKs for top commit:
ismaelsadeeq:
Tested ACK 0771dd89d6eec31ea39f25b283aacbf2092c7c15
sedited:
ACK 0771dd89d6eec31ea39f25b283aacbf2092c7c15

Tree-SHA512: 485b803c37cca1ddbcb9835bf758d06b529e21fe15c93b256cb424b84aef66e822b57d7d663c43be5ad23c49b3ff1c16770a3048ba43825c199668801448688b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36615: guix: add --no-same-owner to codesign.sh TAR_OPTIONSby merge-script · eb1b70d8 · Nov 4, 2026 · 1 fileMessage 93 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#36615: guix: add --no-same-owner to codesign.sh TAR_OPTIONS

d2e5108ea2ddce1952d4db8b42d39a40e3d9f521 guix: add --no-same-owner to codesign.sh TAR_OPTIONS (marcofleon)

Pull request description:

Just ran `guix-codesign` for v32.0 as root, in fanquake's container image ([option 3](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/INSTALL.md#option-3-using-fanquakes-container-image) in INSTALL.md) and got this error while unpacking the codesigning tarball:

```bash
tar: ./detached-sig-create.sh: Cannot change ownership to uid 0, gid 0: Invalid argument
tar: ./unsigned/bitcoin-32.0: Cannot change ownership to uid 0, gid 0: Invalid argument
tar: ./unsigned/bitcoin-32.0-win64-setup-unsigned.exe: Cannot change ownership to uid 0, gid 0: Invalid argument
...
tar: Exiting with failure status due to previous errors
```
Same happens for the macOS files.

When updating guix in https://github.com/bitcoin/bitcoin/pull/34550, `--no-same-owner` was added in `build.sh` (now in `setup.sh`) in 0f323e10759aba4429677d0e1e202bf575b6d664, but not in `codesign.sh`. This PR adds it to `TAR_OPTIONS` in `codesign.sh`. This fixed the issue for me and my hashes match the other attestations for v32.0.

ACKs for top commit:
fanquake:
ACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521
willcl-ark:
utACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521

Tree-SHA512: e0a10053839144f7042590ad8d46b762099983fd9eca55a9c5b7aecc9aa3b61ac833f1e1f1fd36dfe0a6b17d111215e0b56faa188b6e5c286618a15013e3ee24

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundaryupdate trustsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 18/100

This is a one-line fix for the Bitcoin Core release-codesigning script used in reproducible builds. When a release signer ran the signing tool as root inside a container, tar failed because it tried to preserve file ownership from the original tarball (root-owned files) but could not assign those owners in the container environment. The patch tells tar not to try to keep the original owners, which lets the signing process finish and lets the signer produce matching release signatures. It is a build-tool reliability fix, not a vulnerability in the Bitcoin network or wallet software.

AI review queuedMerge bitcoin/bitcoin#35492: wallet: fail dump on incomplete writesby merge-script · 2e06f371 · Nov 4, 2026 · 2 filesMessage 81 · StrongLow 43Details
Commit message · merge-script

Merge bitcoin/bitcoin#35492: wallet: fail dump on incomplete writes

385a001f66ad23b3963d5c0acf960b94359c4e21 wallet: commit dump output before success (Velarde)
bb2a207d08782b93f77c003287d9b6bf4ea17fa1 wallet: fail dump on incomplete writes (Velarde)

Pull request description:

This makes `bitcoin-wallet dump` fail if writing the dump file does not complete successfully.

Previously, `DumpWallet()` only checked whether the dump file could be opened. If later writes or close failed, the tool could still return success and print the private-key warning, leaving a truncated dump file behind.

The change adds write/close checks while dumping wallet records. If writing fails, the partial dump file is removed and `bitcoin-wallet` returns an error.

ACKs for top commit:
maflcko:
review with --function-context --ignore-all-space ACK 385a001f66ad23b3963d5c0acf960b94359c4e21 🍵
pablomartin4btc:
ACK 385a001f66ad23b3963d5c0acf960b94359c4e21

Tree-SHA512: 89c8901ac8f22057ed970427418b339c59313511c40860e2d48f88d49758dc6d300d5861d4d9a54e0b30b2f2070f4adce5544d2e847870ae23a68a738251e654

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 43/100

This change fixes a bug in the `bitcoin-wallet dump` command. Previously, if writing the dump file failed partway through (for example, because the disk was full), the tool could still report success and leave behind an incomplete, misleading file. Now the tool checks every write and close operation, reports failure, and deletes the partial file. This is a reliability and data-integrity improvement rather than a remote attack vector.

AI review queuedMerge bitcoin/bitcoin#31507: build: Use clang-cl to build on Windows nativelyby merge-script · cfe5ccea · Nov 4, 2026 · 20 filesMessage 91 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#31507: build: Use clang-cl to build on Windows natively

331902f1dda63b5b8e5e9296f9871c358bf5d2b3 doc: Rename `build-windows-msvc.md` to `build-windows-native.md` (Hennadii Stepanov)
fe2ffef6bc786e515b9fc99a4bf10792b45c6a91 doc: Add clang-cl release notes (Hennadii Stepanov)
4f1e6de6c44790c3abbaf83dfe09947610520e1e cmake: Drop support for the MSVC compiler (cl.exe) (Hennadii Stepanov)
720f381a264f8a136689bd50b29a78482e3b19f7 Couple `BSWAP_CONSTEXPR` definition to bswap implementation (Hennadii Stepanov)
4d7e07035dfd82730b8b1dcb17bee059e6102800 cmake: Adjust diagnostic flags for clang-cl (Hennadii Stepanov)
c4111989e47654db4325fbf3935228bd9385b392 cmake: Link to clang-cl builtins library on Windows (Hennadii Stepanov)
d2645f7ed486718d2af39cf5fc50f46bb8503be9 cmake: Always link `bitcoinqt` to `shlwapi` when building on Windows (Hennadii Stepanov)

Pull request description:

Building on Windows using Clang instead of the MS compiler may be beneficial, considering the issues with the latter, as outlined in https://github.com/bitcoin/bitcoin/issues/31456:

> * non-optimized codegen: [build: remove need to test for endianness #29852 (comment)](https://github.com/bitcoin/bitcoin/pull/29852#issuecomment-2049803970)
>
> * compile failure: [MSVC 17.12.0 internal compiler error #31303](https://github.com/bitcoin/bitcoin/issues/31303)
>
> * ~legal, but brittle stdlib: [util: Drop boost posix_time in ParseISO8601DateTime #31391 (comment)](https://github.com/bitcoin/bitcoin/pull/31391#issuecomment-2510762011)~
>
> * unspecified issue: [refactor: Check translatable format strings at compile-time #31061 (comment)](https://github.com/bitcoin/bitcoin/pull/31061#issuecomment-2531244463)

Additionally, MSVC does not [support](https://learn.microsoft.com/en-us/cpp/assembler/inline/inline-assembler) inline assembly on the ARM and x64 processors.

So this PR:
1. Closes https://github.com/bitcoin/bitcoin/issues/31456 (and addresses https://github.com/bitcoin/bitcoin/issues/14118).
2. Could be an alternative to https://github.com/bitcoin/bitcoin/pull/24773.
3. Closes https://github.com/bitcoin/bitcoin/issues/36153.
---

Additionally, clang-cl:
1. Produces binaries with [better](https://github.com/bitcoin-core/secp256k1/pull/1681) performance. For example:

| MSVC, block/s | clang-cl, block/s | benchmark |
|--------------:|------------------:|:----------|
| 7.40 | 11.52 | `ConnectBlockAllEcdsa`
| 7.32 | 11.81 | `ConnectBlockAllSchnorr`
| 7.38 | 11.45 | `ConnectBlockMixedEcdsaSchnorr`
| 91.86 | 143.12 | `DeserializeAndCheckBlockTest`
| 121.46 | 189.04 | `DeserializeBlockTest`

2. Builds faster on the CI:
- [MSVC](https://github.com/bitcoin/bitcoin/actions/runs/13792522864/job/38575846787) - 20m 35s
- [clang-cl](https://github.com/bitcoin/bitcoin/actions/runs/13792522864/job/38575849680) - 12m 43s

ACKs for top commit:
maflcko:
review ACK 331902f1dda63b5b8e5e9296f9871c358bf5d2b3 😈
hodlinator:
re-ACK 331902f1dda63b5b8e5e9296f9871c358bf5d2b3

Tree-SHA512: f6bad9c98db19952424f7a8789cea74bc5e5e56fe85de151da8c77295d312f98081d88e4e2709603288721a622ccbdc99de0b19044cc955dd5008c9b75943b3d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: unusually broad change
AI analysis · Informational 18/100

This commit changes Bitcoin Core's Windows build system to use the Clang compiler (clang-cl) instead of Microsoft's own C++ compiler (MSVC/cl.exe). It is a build-toolchain change, not a fix for a security vulnerability in running code. The pull request mentions that MSVC had bugs and missing features, but those are described as development/maintenance problems, not as remotely exploitable flaws. There is no indication this patch fixes an active security issue.

Lower-priorityMerge bitcoin/bitcoin#35041: descriptor: speed-up `Parse` (xpub/xpriv) in ~30%by merge-script · 002b119c · Nov 4, 2026 · 5 filesMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#35041: descriptor: speed-up `Parse` (xpub/xpriv) in ~30%

61cb3d966a855a551307889daea9c45c2c1db203 descriptor: replace O(n) INPUT_CHARSET.find() with precomputed lookup table (brunoerg)
75fd00099ccfa1039df044ca373131e384af1a9d descriptor, key_io: avoid redundant work when parsing keys (brunoerg)

Pull request description:

This PR speeds up descriptor parsing, for basically descriptors that use xpub/xpriv, through some targeted improvements (I've been working on fuzz targets for wallet stuff for a while. I've noticed that some of them are slow so I started to work on understanding why and improve what can be improved. The finding came from it):

- Avoid redundant base58 decoding when parsing extended keys (this is the major improvement)

ParsePubkeyInner unconditionally called both DecodeExtKey() and DecodeExtPubKey(), each running a full DecodeBase58Check (two SHA256 passes over ~111 bytes). A new DecodeExtKeyOrPubKey() function performs a single base58 decode and then checks the prefix, halving the cryptographic work per key. The interfaces of DecodeSecret, DecodeExtKey, and DecodeExtPubKey are also updated to accept string_view instead of const std::string&, eliminating unnecessary string copies in the descriptor parser and allowing DecodeBase58/DecodeBase58Check to use pointer-range iteration instead of strlen.

- Replace O(n) charset lookup with precomputed table

DescriptorChecksum previously called std::string::find() for every character in the descriptor string, doing up to 96 comparisons per character. This replaces it with a 256-entry precomputed lookup table for O(1) lookups. The benefit scales with descriptor length.

-----------

`Parse()` with the following descriptor:
```sh
tr(xpub6CGCzpvrZVssNNXuP1Awcz8GoakYyJHra2WHASXfCzsD9szbQFoT1pLMdQopyqaSqXUprH7fkk8NG2pUbQa5HpNzpWmEsdNZDHxXvSLPTrn/*,{{multi_a(20,xpub6CGCzpvrZVssNNXuP1Awcz8GoakYyJHra2WHASXfCzsD9szbQFoT1pLMdQopyqaSqXUprH7fkk8NG2pUbQa5HpNzpWmEsdNZDHxXvSLPTrn/*,xpub6C5MW95EE8hAmxm96LdAFYkweaAktQoojCf2MwJmNL9Fi6oUPeBnpFdEzhs9zHwr4HQEeF1r1yAUR8MqDJqk4YPteh75rNoCKCtud7shDDk/*,xpub6DNEUJP1zLAZ1P6gYRba9FyxuppmkrPmSKz3FLM7msRwn2LEr4LnKfAnNoSoAbnbW2orTfsitdfWTxLbJCZ6LizqV7cFUavSAjWzNjqdfCP/*,xpub6Cm5sAgCZQvYtnatYPdFuLhsD9VtgY3Rtt48TrdgqXm4DttXfM6nFmFTko8KcyGhPswTvPcTzfpMUvqV3F9tgLPvzfzoKwjmU668vBmGXEX/*,xpub6DN66R61Luv95HLvznR2ZWsbYuGBoK9LDR6XiNm1pvp5zRJ2vFhLQ4PBe2pDn59sKmRnEFbdLtBVZFN3QAujcGZ5PomGCvrnisxkP2fcgHg/*,xpub6D2GtAtYodmjwEoAzorKUta44NDvAB4JjafYXxsQ5hTWvCAK55nnkyNHfdjrsx3umfgGe1nnHut13mLuFqqi2fs7VVyv6rht76ddrDGhrTY/*,xpub6Bfi8jsDMuu2XHQ1TGRB6ehjdHKKmTwRFQYU6QcgHoZswqbzKsXs9Qd87nAxevjZwuQ37jaVnQoPF6wY34BJoeLxXkEYMpKz2CBHLcEmJVF/*,xpub6CYiNdQesStiBwZkWjPBxwxxf6oPMH9meBMujCwBX74X8nCpMF9zRZUbDrU9raQah1LQcnzLQrHC6Kr6LNCmsBpaMkYD3U6FyhHZfTHQGUB/*,xpub6CddszJHLa3VisZ6ufU4hiFcGsuuPHo7hYa24o3kPuPfAbMED4ajuDa6svuqxxBxYgUQhN8LK7MtTMetquNo7YsWhiV8hX2gBfjszJVXgkG/*,xpub6DAM262AxC4Um3rxBiP5FoA7SJJG3a7MjaJkEyXWyMA6iNuyqWueKZHSSNjKEWnn8Wi3PUQNTV1Z3a59C2Qaidha88GTWtAMhJBAWBBvuTN/*,xpub6ByZcsLsr8xTCJmYxvLpLrsFzuHNXRLR4xMyB9ZFLek1hDVh7zba2xAVTU8M6eonFFAAPYpTA76bDuopF5zyBkZqFc3rtJ3ziH1BUXkjC6j/*,xpub6Bx2LErujvR1noXrk7RHQB9htiDcPM5qYuV7Jg1nZh5jWeK8pYB4DnYQ73EX9sB9M6rnNsF8LDPUejHiXrBx2JJQSdVQ9i9FfEzJLuAnzEd/*,xpub6DSBog1uLngjBWVDUpLTQ19jGGKovgc3iTd1ijL4fjk9sgNqrnG5kGLjUWncay2jbqdgt6yrbYSHhfwsTMp7i8pUD1FMCQuFyqdsZpgUNH8/*,xpub6C53ov8LpuGp5MM4ghqUFJcdTnXJCRHyXaz1RVCys2uQErpdzUWHtm8Bsg8NJyaqfhGWvm9WPSE7jMneCRw1xs1CTajpToXyRqSCc41JiuY/*,xpub6CscWPNXdEybbJVvx7fJTrfHyTkKZtb97qcpQ9fH4k4xtm4nkckSpvy86heQsdyoF28CugwLHg5kLDwpGoPQAYXQ3RG9cJB2Na1FdeN1wt5/*,xpub6Cmrivt6w3kVAxw7NmcKSY19gSLmC2tVwx46cdigr9d1UEnttJCGZJ7NQu1MkugpZgF9rQ3j3NKUiZ2MoaC2QoZUfi4nwxbpH39SQZaBHut/*,xpub6D1Ey5JAYnBxFE8i2V2SUsEpJt7r3ykJKcShcpT2xN9CXtVQy5dKeYiZ9D1bdnkPrmgEajrSuA5nWqf94s6u7FwvXy3cU4BXUMgAt9C8wGT/*,xpub6CwJ2vicnoSJNFDzhonucHNVHDwyb1vyiu2VF6zmjQrzGb4qoAma1i2QJ7qRNe1qmpvvWwzSuQDgMnCECFQhZaPKuPFjcMo33r2xenBauxf/*,xpub6CiLNz8mFB4fB51x6gMNu44Up9PyVhq7fSxQb8UzYQermvMShwWyqzQe99Uiyxpfy1ow42xUGpPGBHf8ErxDbQojBf7Uy7hKFgYk8KpgMm2/*,xpub6DQ2qVMZ2o2QGGpYDsw5hpAcygNVEycAkkCib2Lexwm8gYWMCSecZ256AbAV93Rgze6h8yEoTcqUnvnz7L69WUqp7cXd85X8HoeKWjPHRRZ/*),multi_a(20,xpub6CGCzpvrZVssNNXuP1Awcz8GoakYyJHra2WHASXfCzsD9szbQFoT1pLMdQopyqaSqXUprH7fkk8NG2pUbQa5HpNzpWmEsdNZDHxXvSLPTrn/*,xpub6C5MW95EE8hAmxm96LdAFYkweaAktQoojCf2MwJmNL9Fi6oUPeBnpFdEzhs9zHwr4HQEeF1r1yAUR8MqDJqk4YPteh75rNoCKCtud7shDDk/*,xpub6DNEUJP1zLAZ1P6gYRba9FyxuppmkrPmSKz3FLM7msRwn2LEr4LnKfAnNoSoAbnbW2orTfsitdfWTxLbJCZ6LizqV7cFUavSAjWzNjqdfCP/*,xpub6Cm5sAgCZQvYtnatYPdFuLhsD9VtgY3Rtt48TrdgqXm4DttXfM6nFmFTko8KcyGhPswTvPcTzfpMUvqV3F9tgLPvzfzoKwjmU668vBmGXEX/*,xpub6DN66R61Luv95HLvznR2ZWsbYuGBoK9LDR6XiNm1pvp5zRJ2vFhLQ4PBe2pDn59sKmRnEFbdLtBVZFN3QAujcGZ5PomGCvrnisxkP2fcgHg/*,xpub6D2GtAtYodmjwEoAzorKUta44NDvAB4JjafYXxsQ5hTWvCAK55nnkyNHfdjrsx3umfgGe1nnHut13mLuFqqi2fs7VVyv6rht76ddrDGhrTY/*,xpub6Bfi8jsDMuu2XHQ1TGRB6ehjdHKKmTwRFQYU6QcgHoZswqbzKsXs9Qd87nAxevjZwuQ37jaVnQoPF6wY34BJoeLxXkEYMpKz2CBHLcEmJVF/*,xpub6CYiNdQesStiBwZkWjPBxwxxf6oPMH9meBMujCwBX74X8nCpMF9zRZUbDrU9raQah1LQcnzLQrHC6Kr6LNCmsBpaMkYD3U6FyhHZfTHQGUB/*,xpub6CddszJHLa3VisZ6ufU4hiFcGsuuPHo7hYa24o3kPuPfAbMED4ajuDa6svuqxxBxYgUQhN8LK7MtTMetquNo7YsWhiV8hX2gBfjszJVXgkG/*,xpub6DAM262AxC4Um3rxBiP5FoA7SJJG3a7MjaJkEyXWyMA6iNuyqWueKZHSSNjKEWnn8Wi3PUQNTV1Z3a59C2Qaidha88GTWtAMhJBAWBBvuTN/*,xpub6ByZcsLsr8xTCJmYxvLpLrsFzuHNXRLR4xMyB9ZFLek1hDVh7zba2xAVTU8M6eonFFAAPYpTA76bDuopF5zyBkZqFc3rtJ3ziH1BUXkjC6j/*,xpub6Bx2LErujvR1noXrk7RHQB9htiDcPM5qYuV7Jg1nZh5jWeK8pYB4DnYQ73EX9sB9M6rnNsF8LDPUejHiXrBx2JJQSdVQ9i9FfEzJLuAnzEd/*,xpub6DSBog1uLngjBWVDUpLTQ19jGGKovgc3iTd1ijL4fjk9sgNqrnG5kGLjUWncay2jbqdgt6yrbYSHhfwsTMp7i8pUD1FMCQuFyqdsZpgUNH8/*,xpub6C53ov8LpuGp5MM4ghqUFJcdTnXJCRHyXaz1RVCys2uQErpdzUWHtm8Bsg8NJyaqfhGWvm9WPSE7jMneCRw1xs1CTajpToXyRqSCc41JiuY/*,xpub6CscWPNXdEybbJVvx7fJTrfHyTkKZtb97qcpQ9fH4k4xtm4nkckSpvy86heQsdyoF28CugwLHg5kLDwpGoPQAYXQ3RG9cJB2Na1FdeN1wt5/*,xpub6Cmrivt6w3kVAxw7NmcKSY19gSLmC2tVwx46cdigr9d1UEnttJCGZJ7NQu1MkugpZgF9rQ3j3NKUiZ2MoaC2QoZUfi4nwxbpH39SQZaBHut/*,xpub6D1Ey5JAYnBxFE8i2V2SUsEpJt7r3ykJKcShcpT2xN9CXtVQy5dKeYiZ9D1bdnkPrmgEajrSuA5nWqf94s6u7FwvXy3cU4BXUMgAt9C8wGT/*,xpub6CwJ2vicnoSJNFDzhonucHNVHDwyb1vyiu2VF6zmjQrzGb4qoAma1i2QJ7qRNe1qmpvvWwzSuQDgMnCECFQhZaPKuPFjcMo33r2xenBauxf/*,xpub6CiLNz8mFB4fB51x6gMNu44Up9PyVhq7fSxQb8UzYQermvMShwWyqzQe99Uiyxpfy1ow42xUGpPGBHf8ErxDbQojBf7Uy7hKFgYk8KpgMm2/*,xpub6DQ2qVMZ2o2QGGpYDsw5hpAcygNVEycAkkCib2Lexwm8gYWMCSecZ256AbAV93Rgze6h8yEoTcqUnvnz7L69WUqp7cXd85X8HoeKWjPHRRZ/*)},{multi_a(20,xpub6CGCzpvrZVssNNXuP1Awcz8GoakYyJHra2WHASXfCzsD9szbQFoT1pLMdQopyqaSqXUprH7fkk8NG2pUbQa5HpNzpWmEsdNZDHxXvSLPTrn/*,xpub6C5MW95EE8hAmxm96LdAFYkweaAktQoojCf2MwJmNL9Fi6oUPeBnpFdEzhs9zHwr4HQEeF1r1yAUR8MqDJqk4YPteh75rNoCKCtud7shDDk/*,xpub6DNEUJP1zLAZ1P6gYRba9FyxuppmkrPmSKz3FLM7msRwn2LEr4LnKfAnNoSoAbnbW2orTfsitdfWTxLbJCZ6LizqV7cFUavSAjWzNjqdfCP/*,xpub6Cm5sAgCZQvYtnatYPdFuLhsD9VtgY3Rtt48TrdgqXm4DttXfM6nFmFTko8KcyGhPswTvPcTzfpMUvqV3F9tgLPvzfzoKwjmU668vBmGXEX/*,xpub6DN66R61Luv95HLvznR2ZWsbYuGBoK9LDR6XiNm1pvp5zRJ2vFhLQ4PBe2pDn59sKmRnEFbdLtBVZFN3QAujcGZ5PomGCvrnisxkP2fcgHg/*,xpub6D2GtAtYodmjwEoAzorKUta44NDvAB4JjafYXxsQ5hTWvCAK55nnkyNHfdjrsx3umfgGe1nnHut13mLuFqqi2fs7VVyv6rht76ddrDGhrTY/*,xpub6Bfi8jsDMuu2XHQ1TGRB6ehjdHKKmTwRFQYU6QcgHoZswqbzKsXs9Qd87nAxevjZwuQ37jaVnQoPF6wY34BJoeLxXkEYMpKz2CBHLcEmJVF/*,xpub6CYiNdQesStiBwZkWjPBxwxxf6oPMH9meBMujCwBX74X8nCpMF9zRZUbDrU9raQah1LQcnzLQrHC6Kr6LNCmsBpaMkYD3U6FyhHZfTHQGUB/*,xpub6CddszJHLa3VisZ6ufU4hiFcGsuuPHo7hYa24o3kPuPfAbMED4ajuDa6svuqxxBxYgUQhN8LK7MtTMetquNo7YsWhiV8hX2gBfjszJVXgkG/*,xpub6DAM262AxC4Um3rxBiP5FoA7SJJG3a7MjaJkEyXWyMA6iNuyqWueKZHSSNjKEWnn8Wi3PUQNTV1Z3a59C2Qaidha88GTWtAMhJBAWBBvuTN/*,xpub6ByZcsLsr8xTCJmYxvLpLrsFzuHNXRLR4xMyB9ZFLek1hDVh7zba2xAVTU8M6eonFFAAPYpTA76bDuopF5zyBkZqFc3rtJ3ziH1BUXkjC6j/*,xpub6Bx2LErujvR1noXrk7RHQB9htiDcPM5qYuV7Jg1nZh5jWeK8pYB4DnYQ73EX9sB9M6rnNsF8LDPUejHiXrBx2JJQSdVQ9i9FfEzJLuAnzEd/*,xpub6DSBog1uLngjBWVDUpLTQ19jGGKovgc3iTd1ijL4fjk9sgNqrnG5kGLjUWncay2jbqdgt6yrbYSHhfwsTMp7i8pUD1FMCQuFyqdsZpgUNH8/*,xpub6C53ov8LpuGp5MM4ghqUFJcdTnXJCRHyXaz1RVCys2uQErpdzUWHtm8Bsg8NJyaqfhGWvm9WPSE7jMneCRw1xs1CTajpToXyRqSCc41JiuY/*,xpub6CscWPNXdEybbJVvx7fJTrfHyTkKZtb97qcpQ9fH4k4xtm4nkckSpvy86heQsdyoF28CugwLHg5kLDwpGoPQAYXQ3RG9cJB2Na1FdeN1wt5/*,xpub6Cmrivt6w3kVAxw7NmcKSY19gSLmC2tVwx46cdigr9d1UEnttJCGZJ7NQu1MkugpZgF9rQ3j3NKUiZ2MoaC2QoZUfi4nwxbpH39SQZaBHut/*,xpub6D1Ey5JAYnBxFE8i2V2SUsEpJt7r3ykJKcShcpT2xN9CXtVQy5dKeYiZ9D1bdnkPrmgEajrSuA5nWqf94s6u7FwvXy3cU4BXUMgAt9C8wGT/*,xpub6CwJ2vicnoSJNFDzhonucHNVHDwyb1vyiu2VF6zmjQrzGb4qoAma1i2QJ7qRNe1qmpvvWwzSuQDgMnCECFQhZaPKuPFjcMo33r2xenBauxf/*,xpub6CiLNz8mFB4fB51x6gMNu44Up9PyVhq7fSxQb8UzYQermvMShwWyqzQe99Uiyxpfy1ow42xUGpPGBHf8ErxDbQojBf7Uy7hKFgYk8KpgMm2/*,xpub6DQ2qVMZ2o2QGGpYDsw5hpAcygNVEycAkkCib2Lexwm8gYWMCSecZ256AbAV93Rgze6h8yEoTcqUnvnz7L69WUqp7cXd85X8HoeKWjPHRRZ/*),multi_a(20,xpub6CGCzpvrZVssNNXuP1Awcz8GoakYyJHra2WHASXfCzsD9szbQFoT1pLMdQopyqaSqXUprH7fkk8NG2pUbQa5HpNzpWmEsdNZDHxXvSLPTrn/*,xpub6C5MW95EE8hAmxm96LdAFYkweaAktQoojCf2MwJmNL9Fi6oUPeBnpFdEzhs9zHwr4HQEeF1r1yAUR8MqDJqk4YPteh75rNoCKCtud7shDDk/*,xpub6DNEUJP1zLAZ1P6gYRba9FyxuppmkrPmSKz3FLM7msRwn2LEr4LnKfAnNoSoAbnbW2orTfsitdfWTxLbJCZ6LizqV7cFUavSAjWzNjqdfCP/*,xpub6Cm5sAgCZQvYtnatYPdFuLhsD9VtgY3Rtt48TrdgqXm4DttXfM6nFmFTko8KcyGhPswTvPcTzfpMUvqV3F9tgLPvzfzoKwjmU668vBmGXEX/*,xpub6DN66R61Luv95HLvznR2ZWsbYuGBoK9LDR6XiNm1pvp5zRJ2vFhLQ4PBe2pDn59sKmRnEFbdLtBVZFN3QAujcGZ5PomGCvrnisxkP2fcgHg/*,xpub6D2GtAtYodmjwEoAzorKUta44NDvAB4JjafYXxsQ5hTWvCAK55nnkyNHfdjrsx3umfgGe1nnHut13mLuFqqi2fs7VVyv6rht76ddrDGhrTY/*,xpub6Bfi8jsDMuu2XHQ1TGRB6ehjdHKKmTwRFQYU6QcgHoZswqbzKsXs9Qd87nAxevjZwuQ37jaVnQoPF6wY34BJoeLxXkEYMpKz2CBHLcEmJVF/*,xpub6CYiNdQesStiBwZkWjPBxwxxf6oPMH9meBMujCwBX74X8nCpMF9zRZUbDrU9raQah1LQcnzLQrHC6Kr6LNCmsBpaMkYD3U6FyhHZfTHQGUB/*,xpub6CddszJHLa3VisZ6ufU4hiFcGsuuPHo7hYa24o3kPuPfAbMED4ajuDa6svuqxxBxYgUQhN8LK7MtTMetquNo7YsWhiV8hX2gBfjszJVXgkG/*,xpub6DAM262AxC4Um3rxBiP5FoA7SJJG3a7MjaJkEyXWyMA6iNuyqWueKZHSSNjKEWnn8Wi3PUQNTV1Z3a59C2Qaidha88GTWtAMhJBAWBBvuTN/*,xpub6ByZcsLsr8xTCJmYxvLpLrsFzuHNXRLR4xMyB9ZFLek1hDVh7zba2xAVTU8M6eonFFAAPYpTA76bDuopF5zyBkZqFc3rtJ3ziH1BUXkjC6j/*,xpub6Bx2LErujvR1noXrk7RHQB9htiDcPM5qYuV7Jg1nZh5jWeK8pYB4DnYQ73EX9sB9M6rnNsF8LDPUejHiXrBx2JJQSdVQ9i9FfEzJLuAnzEd/*,xpub6DSBog1uLngjBWVDUpLTQ19jGGKovgc3iTd1ijL4fjk9sgNqrnG5kGLjUWncay2jbqdgt6yrbYSHhfwsTMp7i8pUD1FMCQuFyqdsZpgUNH8/*,xpub6C53ov8LpuGp5MM4ghqUFJcdTnXJCRHyXaz1RVCys2uQErpdzUWHtm8Bsg8NJyaqfhGWvm9WPSE7jMneCRw1xs1CTajpToXyRqSCc41JiuY/*,xpub6CscWPNXdEybbJVvx7fJTrfHyTkKZtb97qcpQ9fH4k4xtm4nkckSpvy86heQsdyoF28CugwLHg5kLDwpGoPQAYXQ3RG9cJB2Na1FdeN1wt5/*,xpub6Cmrivt6w3kVAxw7NmcKSY19gSLmC2tVwx46cdigr9d1UEnttJCGZJ7NQu1MkugpZgF9rQ3j3NKUiZ2MoaC2QoZUfi4nwxbpH39SQZaBHut/*,xpub6D1Ey5JAYnBxFE8i2V2SUsEpJt7r3ykJKcShcpT2xN9CXtVQy5dKeYiZ9D1bdnkPrmgEajrSuA5nWqf94s6u7FwvXy3cU4BXUMgAt9C8wGT/*,xpub6CwJ2vicnoSJNFDzhonucHNVHDwyb1vyiu2VF6zmjQrzGb4qoAma1i2QJ7qRNe1qmpvvWwzSuQDgMnCECFQhZaPKuPFjcMo33r2xenBauxf/*,xpub6CiLNz8mFB4fB51x6gMNu44Up9PyVhq7fSxQb8UzYQermvMShwWyqzQe99Uiyxpfy1ow42xUGpPGBHf8ErxDbQojBf7Uy7hKFgYk8KpgMm2/*,xpub6DQ2qVMZ2o2QGGpYDsw5hpAcygNVEycAkkCib2Lexwm8gYWMCSecZ256AbAV93Rgze6h8yEoTcqUnvnz7L69WUqp7cXd85X8HoeKWjPHRRZ/*)}})
```

This PR:
```sh
| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 90,253.50 | 11,079.90 | 0.2% | 0.01 | `ParseDescriptor`
```

Master:
```sh
| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 127,812.50 | 7,823.96 | 0.5% | 0.01 | `ParseDescriptor`
```

I didn't put the benchmark itself here but if reviewers think worth, I can do it.

--------

Joint work with claude 😅

ACKs for top commit:
hodlinator:
re-ACK 61cb3d966a855a551307889daea9c45c2c1db203
fametrano:
tACK 61cb3d966a855a551307889daea9c45c2c1db203
sedited:
ACK 61cb3d966a855a551307889daea9c45c2c1db203

Tree-SHA512: 19ea44eaa1b01bba05f2c974da6877019d9cde13251994c4ec5f543538de63496c05db4f26d646e7ec1d0d6fc65c959d6d17386a21043eb7e315ee1a8e086fd4

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36748: test: Small test sync fixupsby merge-script · 3b5ba5d3 · Nov 4, 2026 · 3 filesMessage 96 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36748: test: Small test sync fixups

fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa test: Use send_self_transfer_chain (MarcoFalke)
fa2986921cd53146fb8a1fc9585714a064a137d9 test: Use generateblock with submit=False over manual create_block from tmpl (MarcoFalke)
facf4a0ea98ef52f505e4f72eab1b6183df3832f test: Remove redundant sync_blocks (MarcoFalke)

Pull request description:

Just a few random sync style-only test-only fixups. See the commit msgs for the rationales.

ACKs for top commit:
musaHaruna:
ACK [fa6f1c0](https://github.com/bitcoin/bitcoin/pull/36748/changes/fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa)
sedited:
ACK fa6f1c00c5fb1c8e51595f387b7c62c7253e89fa

Tree-SHA512: 3f411f8221f7804ca4f2e17963e165560b7fee7e9576e1a1d849e5a9c527a3de272b7b739bd9ba958adfcb487b3b1a43ce5c399b5c2f5234f4760dc201123fa5

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal test scripts. It simplifies how tests create transactions and blocks, and removes a couple of unnecessary synchronization steps. There is no change to the actual Bitcoin node software that users run, so it cannot affect live networks, wallets, or funds.

AI review queuedMerge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSizeby merge-script · ed3d34ba · Nov 3, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSize

3e2cf63da5090d59218c66dcc9a54c0f8c67e648 policy: remove unused GetVirtualTransactionInputSize (fanquake)

Pull request description:

The last non-test caller was removed in 9b7ec393b8 (#26567). Since then it has only been used by the `tx_in` fuzz target and a helper in `wallet_tests`.

ACKs for top commit:
jpk68:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
l0rinc:
lightly tested code review ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
ismaelsadeeq:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
sedited:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648

Tree-SHA512: 5d59717d0e6cc900817854c35275f9009a07fc45bbaa3fda7c73e726c6f12108a789e2d35723df5b96c68865aec55a57dba95bdc6d940faf442bcb78570202b9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes an unused helper function called GetVirtualTransactionInputSize and updates the few remaining callers to use an equivalent calculation directly. It is a routine code cleanup with no security relevance.

Security candidateMerge bitcoin/bitcoin#36494: wallet: reject unknown options in sendallby merge-script · f3cd4e4b · Nov 3, 2026 · 3 filesMessage 81 · StrongModerate 64Details
Commit message · merge-script

Merge bitcoin/bitcoin#36494: wallet: reject unknown options in sendall

702ec9d40f84dfd0ca9bf73e37052c36f3802702 wallet: reject unknown options in sendall (Thomas)

Pull request description:

`sendall` silently ignores unknown keys in its `options` object, including misspelled ones: `input` instead of `inputs` spends all available UTXOs rather than the given ones, and a misspelled `add_to_wallet` or `psbt` can broadcast a transaction the caller asked not to broadcast.

Reject unknown options, like `send`, `fundrawtransaction`, `walletcreatefundedpsbt` and `bumpfee` already do.

ACKs for top commit:
maflcko:
review ACK 702ec9d40f84dfd0ca9bf73e37052c36f3802702 🐀
Zippo76:
tACK 702ec9d40f
polespinasa:
ACK 702ec9d40f84dfd0ca9bf73e37052c36f3802702

Tree-SHA512: b6a4b9c87014ddc4782f20c7053617cb7d52971a511e344ba9b35bd2cb2145a06489648802455f421fe712802b5ba8665d0aab77390df82bc3ebbc5661e78ed7

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This change fixes a bug in Bitcoin Core's `sendall` wallet command where misspelled or unknown options in the options object were silently ignored. For example, typing `input` instead of `inputs` would spend all coins instead of only the chosen ones, and misspelling `add_to_wallet` or `psbt` could broadcast a transaction the user did not want broadcast. The fix makes `sendall` reject unknown or wrongly typed options, matching other wallet commands.

Lower-priorityMerge bitcoin/bitcoin#36636: netaddress: make .onion suffix check case-insensitiveby merge-script · 9d39cec9 · Nov 3, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36636: netaddress: make .onion suffix check case-insensitive

0574f096abf0cfe75501542efe1787679340d3d3 netaddress: make .onion suffix check case-insensitive (jpk68)

Pull request description:

Makes the suffix/TLD check case-insensitive when parsing `.onion` addresses, as is already done for I2P hostnames. With the current code, a name like `<addr>.ONION` will not be parsed as a Tor address, and will instead fall through to regular hostname resolution.

ACKs for top commit:
Husteem:
ACK [0574f09](https://github.com/bitcoin/bitcoin/pull/36636/commits/0574f096abf0cfe75501542efe1787679340d3d3)
vasild:
ACK 0574f096abf0cfe75501542efe1787679340d3d3
AndreaDiazCorreia:
ACK 0574f096abf0cfe75501542efe1787679340d3d3
winterrdog:
tested ACK 0574f096abf0cfe75501542efe1787679340d3d3
sedited:
ACK 0574f096abf0cfe75501542efe1787679340d3d3

Tree-SHA512: 1d0060cccbbd93ab25b243f33adc1c61b68c4d910cd770bcb8c8bc5b9adae3999ccf73a38bffe9eda339b04be6d5357f56d59d3a61872bd5d57e06fae26553ea

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35728: rpc: Properly throw on internal I/O errors in GetTransactionby Ryan Ofsky · fb19fed3 · Nov 3, 2026 · 7 filesMessage 91 · StrongLow 43Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#35728: rpc: Properly throw on internal I/O errors in GetTransaction

fad49fd81fcffd1dd9f40320a239881a0881be25 Add doc/release-notes-35728.md (MarcoFalke)
fa7d278aad832250e2c1e07ef10afdffee36da4e refactor: Use GetTransaction in ProcessPSBT (MarcoFalke)
fa32e607531c712dab33a712127e473086e32f9f rpc: Properly throw on internal FindTx IO errors in ProcessPSBT and GetTransaction (MarcoFalke)
faaf4a751c68d57ea21d40fbd66dcbbc69abbbac test: Add test to check RPCs throw on IO errors (MarcoFalke)
fad44f18b88fddae160bffb672e12c01c92d6a7f rpc: Return proper error messages from getrawtransaction (MarcoFalke)
fa5ad60c32860786251afc9b764deeb9b5fdcf62 test: Add test for getrawtransaction block read errors (MarcoFalke)

Pull request description:

Currently the GetTransaction return value is a nullable transaction
pointer, where nullptr represents two different outcomes: I/O error and
missing tx.

Reporting a confirmed transaction as missing is wrong, so properly
return an error instead.

ACKs for top commit:
furszy:
ACK fad49fd81fcffd1dd9f40320a239881a0881be25
l0rinc:
ACK fad49fd81fcffd1dd9f40320a239881a0881be25
musaHaruna:
re-ACK [fad49fd](https://github.com/bitcoin/bitcoin/commit/fad49fd81fcffd1dd9f40320a239881a0881be25)
ryanofsky:
Code review ACK fad49fd81fcffd1dd9f40320a239881a0881be25. Since last review, `WarnAndThrowErr` takes the format string and arguments directly, and the release note wording is updated. Thanks!

Tree-SHA512: 6ed11f58a05c46e300412c8db18ae49308af386449fe417a1c3c7de61b3ad85341747b5b4af331d6fa956d55fe039c8fffd9da8f080090f514df11acdcfbcb66

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 43/100

This Bitcoin Core update fixes a bug where several RPC commands and one REST endpoint would incorrectly tell users a confirmed transaction was missing, when in fact the software had hit a disk-read or index corruption problem. After the patch, these interfaces return a clear internal error instead of a misleading 'not found' result. It is a correctness/reliability fix rather than a remote-code-execution style vulnerability.

Security candidateMerge bitcoin/bitcoin#36344: wallet: reject duplicate inputs in sendallby merge-script · 67d9d7fe · Nov 3, 2026 · 2 filesMessage 100 · StrongLow 37Details
Commit message · merge-script

Merge bitcoin/bitcoin#36344: wallet: reject duplicate inputs in sendall

654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be wallet: reject duplicate inputs in sendall (Bruce0X)

Pull request description:

`sendall` with the `inputs` option doesn't check for duplicates. Each listed input is added to `total_input_value` in the loop at spend.cpp:1472, so passing the same UTXO twice counts its value twice.

On regtest, with a wallet that has a single 1 BTC UTXO:

```
sendall '["<addr>"]' '{"inputs": [<utxo>, <utxo>]}'
```

- the RPC returns `complete: true`
- the committed tx has 2 inputs (the same outpoint twice) and one output of 1.99998230 BTC
- it isn't in the mempool, and `testmempoolaccept` rejects it with `bad-txns-inputs-duplicate`
- after that, `listunspent` is empty and `getbalances` shows `nonmempool: -1.0` until the tx is abandoned

`send` and `walletcreatefundedpsbt` aren't affected, because `CCoinControl::Select` removes duplicates.

This rejects a duplicated input with `Invalid parameter, duplicated input: <txid>:<vout>` (RPC_INVALID_PARAMETER). The message matches what `createrawtransaction` says for duplicated addresses. The new `sendall_fails_on_duplicate_input` test fails on master ("No exception raised") and passes with the fix. `wallet_send.py` still passes.

ACKs for top commit:
l0rinc:
ACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be
maflcko:
review ACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be 🚪
molnard:
tACK 654a92a9d3e76f3ff4ec4975f4fbcfba1a6091be

Tree-SHA512: ae8541f9458a12e97d6c516cd2327519d2be8cf0e7501622c7a9d295ecbfd61290d7f874e205cf1e8fc8bcc147edc55e4d773fbe700b6a20db4a7071a9a97b19

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 37/100

This patch fixes a bug in Bitcoin Core's `sendall` wallet RPC command. Previously, if a user accidentally listed the same coin (UTXO) twice in the `inputs` option, the command would create an invalid transaction that counted the coin's value twice. The transaction would be rejected by the network, but it would temporarily confuse the wallet's balance display. The fix now rejects duplicate inputs immediately with a clear error message.

Lower-priorityMerge bitcoin/bitcoin#36584: kernel: make btck_LogEntry opaqueby merge-script · f5e10868 · Nov 3, 2026 · 3 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36584: kernel: make btck_LogEntry opaque

b2c077394a585a4155bd9d7a28b9b7c7553c9dc5 kernel: make btck_LogEntry opaque (stickies-v)

Pull request description:

Makes `btck_LogEntry` an opaque type with `btck_log_entry_get_*` accessors, instead of a public struct. This allows adding or changing fields without breaking the ABI, and is consistent with ~all other kernel objects. Follow-up to https://github.com/bitcoin/bitcoin/pull/34374#discussion_r4207440088.

I added a benchmark in https://github.com/bitcoin/bitcoin/compare/master...stickies-v:bitcoin:2026-10/kernel-logentry-bench, and found that performance is not meaningfully impacted either way. Some results below.

<details>
<summary>Performance stats</summary>

### Performance

Fields are now converted only when read, at the cost of a library call per field. The [benchmark](https://github.com/bitcoin/bitcoin/compare/master...stickies-v:bitcoin:2026-10/kernel-logentry-bench) measures a kernel log statement up to and including the callback (Apple M4 Pro, static library, `-O2`, median of 2×25 interleaved runs):

| Callback reads | master | PR | Delta |
|---|---:|---:|---:|
| no fields | 57.4 ns | 55.2 ns | −1.6 to −2.5 ns |
| message only | 57.8 ns | 56.0 ns | −1.4 to −2.0 ns |
| all 9 fields | 57.9 ns | 62.7 ns | +4.8 to +5.4 ns |

Break-even is at 2-3 fields. Either way, the difference is small next to the ~50 ns the log statement costs before the callback, and to what a consumer typically does with the entry (formatting, I/O).
</details>

ACKs for top commit:
pzafonte:
Code review and tested ACK b2c077394a585a4155bd9d7a28b9b7c7553c9dc5
nervana21:
tACK b2c077394a585a4155bd9d7a28b9b7c7553c9dc5
sedited:
ACK b2c077394a585a4155bd9d7a28b9b7c7553c9dc5
musaHaruna:
Code Review ACK [b2c0773](https://github.com/bitcoin/bitcoin/pull/36584/changes/b2c077394a585a4155bd9d7a28b9b7c7553c9dc5)

Tree-SHA512: 2694d8155be7a73e85ec1eddc7056a18815e0d44a8abd61c3b7b535481367e553084507f686f8181ed65edef9125841f04d410a36c2f470577aadeba86efd9bb

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount