BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
172commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 35 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36869: refactor, memusage: Make fields of STL helper structs publicby merge-script · e211dd01 · Nov 16, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36869: refactor, memusage: Make fields of STL helper structs public

b9a6b0ca51801e95956b7d5307d5b198b9fb7d3f memusage: Make fields of STL helper structs public (Hennadii Stepanov)

Pull request description:

The `stl_tree_node`, `list_node` and `unordered_node` class templates only mimic the layout of the standard library's container nodes, so that `sizeof` yields an estimate of the memory they use. Their fields are never accessed.

Since llvm/llvm-project#237374, Clang 24 diagnoses these fields with `-Wunused-private-field`:
```console
$ cmake --build build
[308/655] Building CXX object src/util/CMakeFiles/bitcoin_util.dir/__/logging.cpp.o
In file included from ../src/logging.cpp:7:
../src/memusage.h:169:11: warning: private field 'ptr_next' is not used [-Wunused-private-field]
169 | void* ptr_next;
| ^
../src/memusage.h:170:11: warning: private field 'ptr_prev' is not used [-Wunused-private-field]
170 | void* ptr_prev;
| ^
2 warnings generated.
[355/655] Building CXX object src/CMakeFiles/bitcoin_node.dir/kernel/disconnected_transactions.cpp.o
In file included from ../src/kernel/disconnected_transactions.cpp:8:
In file included from ../src/core_memusage.h:10:
../src/memusage.h:184:11: warning: private field 'ptr' is not used [-Wunused-private-field]
184 | void* ptr;
| ^
../src/memusage.h:169:11: warning: private field 'ptr_next' is not used [-Wunused-private-field]
169 | void* ptr_next;
| ^
../src/memusage.h:170:11: warning: private field 'ptr_prev' is not used [-Wunused-private-field]
170 | void* ptr_prev;
| ^
3 warnings generated.
[424/655] Building CXX object src/CMakeFiles/bitcoin_node.dir/txgraph.cpp.o
In file included from ../src/txgraph.cpp:7:
In file included from ../src/cluster_linearize.h:17:
../src/memusage.h:72:9: warning: private field 'color' is not used [-Wunused-private-field]
72 | int color;
| ^
../src/memusage.h:73:11: warning: private field 'parent' is not used [-Wunused-private-field]
73 | void* parent;
| ^
../src/memusage.h:74:11: warning: private field 'left' is not used [-Wunused-private-field]
74 | void* left;
| ^
../src/memusage.h:75:11: warning: private field 'right' is not used [-Wunused-private-field]
75 | void* right;
| ^
4 warnings generated.
[425/655] Building CXX object src/CMakeFiles/bitcoin_node.dir/txmempool.cpp.o
In file included from ../src/txmempool.cpp:6:
In file included from ../src/txmempool.h:9:
In file included from ../src/coins.h:11:
In file included from ../src/core_memusage.h:10:
../src/memusage.h:72:9: warning: private field 'color' is not used [-Wunused-private-field]
72 | int color;
| ^
../src/memusage.h:73:11: warning: private field 'parent' is not used [-Wunused-private-field]
73 | void* parent;
| ^
../src/memusage.h:74:11: warning: private field 'left' is not used [-Wunused-private-field]
74 | void* left;
| ^
../src/memusage.h:75:11: warning: private field 'right' is not used [-Wunused-private-field]
75 | void* right;
| ^
../src/memusage.h:72:9: warning: private field 'color' is not used [-Wunused-private-field]
72 | int color;
| ^
../src/memusage.h:73:11: warning: private field 'parent' is not used [-Wunused-private-field]
73 | void* parent;
| ^
../src/memusage.h:74:11: warning: private field 'left' is not used [-Wunused-private-field]
74 | void* left;
| ^
../src/memusage.h:75:11: warning: private field 'right' is not used [-Wunused-private-field]
75 | void* right;
| ^
../src/memusage.h:72:9: warning: private field 'color' is not used [-Wunused-private-field]
72 | int color;
| ^
../src/memusage.h:73:11: warning: private field 'parent' is not used [-Wunused-private-field]
73 | void* parent;
| ^
../src/memusage.h:74:11: warning: private field 'left' is not used [-Wunused-private-field]
74 | void* left;
| ^
../src/memusage.h:75:11: warning: private field 'right' is not used [-Wunused-private-field]
75 | void* right;
| ^
12 warnings generated.
[535/655] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/disconnected_transactions.cpp.o
In file included from ../src/test/disconnected_transactions.cpp:6:
In file included from ../src/core_memusage.h:10:
../src/memusage.h:184:11: warning: private field 'ptr' is not used [-Wunused-private-field]
184 | void* ptr;
| ^
1 warning generated.
[566/655] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/pool_tests.cpp.o
In file included from ../src/test/pool_tests.cpp:5:
../src/memusage.h:184:11: warning: private field 'ptr' is not used [-Wunused-private-field]
184 | void* ptr;
| ^
1 warning generated.
[655/655] Linking CXX executable bin/test_bitcoin
```

This PR drops the `private:` access specifiers. It does not affect the size or alignment of the structs, as all their fields keep the same access control, and it is consistent with `stl_shared_counter`.

ACKs for top commit:
maflcko:
lgtm ACK b9a6b0ca51801e95956b7d5307d5b198b9fb7d3f
l0rinc:
ACK b9a6b0ca51801e95956b7d5307d5b198b9fb7d3f

Tree-SHA512: 380927f0302cbf7405d0f5236981c0f2b82681c0fb386d8e575be1751643a4bb1e6ffb643b999350c9cbc4579c116c2cb2f940e1c9e3655074bbcb014bf5a9c3

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includesby merge-script · 1fbb5253 · Nov 16, 2026 · 65 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

53561d803747567fc01ca1513ecfb280a01aa5a9 lint: Update `lint_includes_build_config` function (Hennadii Stepanov)
04108a0dbb4633a861232238a53008f15906b953 scripted-diff: Drop `IWYU pragma: keep` from build config includes (Hennadii Stepanov)

Pull request description:

This PR marks the `bitcoin-build-config.h` header with the dedicated [`IWYU pragma: always_keep`](https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-always_keep), which makes the per-include `IWYU pragma: keep` comments redundant.

As a result, grepping for `IWYU pragma: keep` returns only the genuine use cases, each of which should be properly documented.

ACKs for top commit:
l0rinc:
code review and diff reACK 53561d803747567fc01ca1513ecfb280a01aa5a9
vasild:
ACK 53561d803747567fc01ca1513ecfb280a01aa5a9

Tree-SHA512: e7c41a0bddff816effd10fba706fd07aea383b63bae23d117fa1c4a8fa270db6a063d09caadcc96bcf4add1fd9694240cc3a9a09ec830dbe26c2db21994fbfa5

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. There is no functional change to Bitcoin Core, no bug fix, and no security impact.

AI review queuedMerge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimplsby Ryan Ofsky · 8130b3b8 · Nov 16, 2026 · 30 filesMessage 91 · StrongInformational 19Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

fa9158641839e6dbc3cab63b07929998247b1f97 refactor: Return NotNull from CreateNewBlock (MarcoFalke)
fa071a2c451d2cab12e181711b2dd64d61f3ea18 refactor: Mark pimpls as NotNull (MarcoFalke)
fa4785828e804f44726102070fb1adeacbdce6e5 util: refactor: Add and use MakeNotNullShared and MakeNotNullUnique (MarcoFalke)
faf85b0321797a811260a90f6b9a839a9ad9e3c2 test: Add some NotNull test cases (MarcoFalke)

Pull request description:

Current code uses nullable smart pointers for some stuff that is never null. This is perfectly fine, but a bit confusing:

* When reading the code, it is not clear which pointer is nullable or never null.
* Pointers that are never null still have confusing null checks (with possible error handling return branches), which are always dead in coverage reports or when applying mutation testing.
* While some places have the redundant null checks on pointers that are never null, other places do not, which adds to the confusion.

Clarify this at compile-time by using `NotNull` (or a plain reference)

ACKs for top commit:
l0rinc:
reACK fa9158641839e6dbc3cab63b07929998247b1f97
ViniciusCestarii:
reACK fa9158641839e6dbc3cab63b07929998247b1f97
enochaz:
ACK fa9158641839
ryanofsky:
Code review ACK fa9158641839e6dbc3cab63b07929998247b1f97. Nice cleanup: makes it obvious that `CreateNewBlock` can't fail and that these pimpls are always set, and removes the dead error paths that went with them.

Tree-SHA512: 7bcf67bf9f41d146e6f5db0782fb42e5ce93970ea914004f9f30d47d64f2e182a93a064c16bf1d56cc6962fdb95409bbe03eea015f6738710fdbbee8212c212f

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: unusually broad change
AI analysis · Informational 19/100

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null pointers. There is no security vulnerability being fixed here, and no behavior change to the running program.

Lower-priorityMerge bitcoin/bitcoin#36862: test: use long timeout for event waits in interface_ipc_miningby merge-script · 29f7e30d · Nov 16, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36862: test: use long timeout for event waits in interface_ipc_mining

74135e2e625030b18daf7539bd19dabb75948af1 test: use long timeout for event waits in interface_ipc_mining (ViniciusCestarii)

Pull request description:

Follow-up to #36791, https://github.com/bitcoin/bitcoin/pull/36791#discussion_r4565761925 by ryanofsky.

#36791 fixed the `waitTipChanged` timeout on slow hosts, but the `template6` `waitNext` call has the same race: it waits for an event the test triggers after a 0.1s sleep, with a 1s timeout.

This adds `long_ipc_timeout` and uses it for all waits that end on an event the test triggers.

To reproduce failure on master:

```diff
diff --git a/test/functional/interface_ipc_mining.py b/test/functional/interface_ipc_mining.py
index cdef196fd0..49e1c8a9c1 100755
--- a/test/functional/interface_ipc_mining.py
+++ b/test/functional/interface_ipc_mining.py
@@ -320,7 +320,8 @@ class IPCMiningTest(BitcoinTestFramework):
self.log.debug("Wait for another, get one after increase in fees in the mempool")
template6 = await wait_and_do(
mining_wait_next_template(template5, stack, ctx, waitoptions),
- lambda: self.miniwallet.send_self_transfer(fee_rate=10, from_node=self.nodes[0]))
+ lambda: self.miniwallet.send_self_transfer(fee_rate=10, from_node=self.nodes[0]),
+ sleep_time=1.2)
assert template6 is not None
block4 = await mining_get_block(template6, ctx)
assert_equal(len(block4.vtx), 3)

```

ACKs for top commit:
nervana21:
tACK 74135e2e625030b18daf7539bd19dabb75948af1
ryanofsky:
Tested ACK 74135e2e625030b18daf7539bd19dabb75948af1. This finishes the fix from #36791: every wait that returns on an event the test triggers now has at least a minute, so none of them can time out on a slow host with the default timeout factor. I checked that the test passes normally, with the faketime command from #36791, and with `sleep_time=1.2` on the `template6` wait, which failed before.
w0xlt:
ACK 74135e2e625030b18daf7539bd19dabb75948af1

Tree-SHA512: f1648296f955a4be375ee9c6cf514df546559bdf50a6e05d7dd8f42d771da44ef3439e6cde3e10f348f6126dea9d8ac7b3264b692c56eb630583e4c416de42dc

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.pyby merge-script · e1a27bbb · Nov 16, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

75a23e7d36afbbcfedef11bca94967b88bf40de0 test: drop flaky "server too slow" check from interface_http.py (Matthew Zipkin)

Pull request description:

Closes https://github.com/bitcoin/bitcoin/issues/36755

To cover `-rpcservertimeout` behavior our test expected the Bitcoin Core HTTP server to disconnect the test framework client after the configured duration but also *before* a somewhat arbitrary upper bound. This was helpful during development of #35182 but has led to false negatives in CI on platforms that are just plain slow.

Solve the flakiness by simply deleting the test case. Note that a regression is still caught by both the functional test and unit test suite. #36159 added a mock clock in the unit test to assert the disconnect timing. A server with no timeout would also fail the functional test which will time out during `sock.recv()` waiting for the EOF.

Both regression test failures can be observed on top of this branch by disabling rpcservertimeout:

```diff
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
index 069eace507..7a090c4ca8 100644
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -1205,7 +1205,7 @@ bool HTTPRemoteClient::ShouldDisconnect(MockableSteadyClock::time_point now, std
"HTTP client idle timeout %s (id=%llu)",
m_origin,
m_id);
- return true;
+ return false;
// Disconnect this client because the server is shutting down and we need to
// disconnect all clients... Unless the client is still being handled by a
// worker thread, in which case we'd rather continue the I/O loop (but might

```

ACKs for top commit:
maflcko:
lgtm ACK 75a23e7d36afbbcfedef11bca94967b88bf40de0
Pranav-error:
tACK 75a23e7d36afbbcfedef11bca94967b88bf40de0. Ran `interface_http.py` with the PR and it passes. With the mutant from the description, it fails with a `TimeoutError` after about 71 seconds in `recv_raw`.

Tree-SHA512: 61ad6efcc0a8dc6141f8bdd28b1a8f62d9f89b162796c4bffe605867f0b67617b764a0ff071318bbc81631fc407ea1c8e7608d533627758bf7c752df10c9a5bb

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet code, so it does not introduce or fix a security issue in the software users run.

Lower-prioritytest: use long timeout for event waits in interface_ipc_miningby ViniciusCestarii · 74135e2e · Nov 13, 2026 · 1 fileMessage 95 · StrongTriage 0Details
Commit message · ViniciusCestarii

test: use long timeout for event waits in interface_ipc_mining

Waits that return on an event the test triggers could time out on slow
hosts with the 1s default. Use a long timeout for all of them.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityMerge bitcoin/bitcoin#36791: test: fix waitTipChanged timeout on slow hosts and use monotonic clock in interface_ipc_miningby Ryan Ofsky · a527a007 · Nov 13, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36791: test: fix waitTipChanged timeout on slow hosts and use monotonic clock in interface_ipc_mining

46ee95db49c9fa7f4b80a1e59816660f5ee0c4f4 test: use time.monotonic() for durations in interface_ipc_mining (ViniciusCestarii)
9b6dadb39c22bfb6d8b8040519316768919ff906 test: fix waitTipChanged timeout on slow hosts in interface_ipc_mining (ViniciusCestarii)

Pull request description:

Follow up suggested in https://github.com/bitcoin/bitcoin/pull/36731#issuecomment-6675432663.

The first commit fix the timeout on a slow host and the second one use time.monotonic() for durations.

Command to reproduce the errors with a simulated slow wall clock:
```
faketime --exclude-monotonic -f "+0 x0.1" build/test/functional/interface_ipc_mining.py
```

ACKs for top commit:
nervana21:
tACK 46ee95db49c9fa7f4b80a1e59816660f5ee0c4f4
hebasto:
ACK 46ee95db49c9fa7f4b80a1e59816660f5ee0c4f4, I have reviewed the code and it looks OK.
ryanofsky:
Code review ACK 46ee95db49c9fa7f4b80a1e59816660f5ee0c4f4. This makes `interface_ipc_mining.py` more robust than on master: duration checks no longer fail when the system clock steps (like hebasto's NetBSD run, where the measured duration came out negative), and the `waitTipChanged` call that waits for a mined block no longer has only 1 second (with the default timeout factor) for the test to mine it.

Tree-SHA512: d85f3df354c38d42ee8eae77fff0d034480415cd7d32dfb3855b3bb8b4bbc4a9458611505db80e1eeed3176932dd6a86881041265fccb78dfe361c6f62f563b7

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36574: ci: Reword stale readmeby merge-script · 9183edd2 · Nov 12, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36574: ci: Reword stale readme

fa05bcd88ff1edb1971dba9a000e74358fdc7730 ci: Add a note on pinning dependencies (MarcoFalke)
fa8e4b7094e79d7ab3eb21108176de8cd08c4163 ci: lint: Use shellcheck from apt install (MarcoFalke)
faf2b224d5691ffde5e09556bb467e622c0ed00d ci: Reword readme (MarcoFalke)
faf6ed1b3c7761136b2f6d9cee29d0a293bacb23 ci: Update binfmt qemu note (MarcoFalke)

Pull request description:

The ci readme is a bit stale, so update it.

ACKs for top commit:
Hamza1610:
ACK https://github.com/bitcoin/bitcoin/commit/fa05bcd88ff1edb1971dba9a000e74358fdc7730
willcl-ark:
ACK fa05bcd88ff1edb1971dba9a000e74358fdc7730

Tree-SHA512: 4676e5adc64618068a597d2210c299a757b06bdda4e8f98528fc066e1dc7025647565ad59e1683319d941bc0a87e7618a96ce3e30542524f12c75d3b7de849f2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecationby merge-script · 8b0b5775 · Nov 12, 2026 · 4 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

fad45cacbcac4831082d4fcf596c255fd9c5a55d rpc: wallet: Schedule mixed-case confTarget option deprecation (MarcoFalke)

Pull request description:

Since commit 91f6d2bc8ff4d4cd1b86daa370ec9d2d9662394d in 2020, the wallet accepts and documents `conf_target` for the fee bump RPC.

So it seems time to cut the confusion and properly deprecate it with the next cycle.

ACKs for top commit:
seduless:
Tested ACK fad45cacbcac4831082d4fcf596c255fd9c5a55d
willcl-ark:
ACK fad45cacbcac4831082d4fcf596c255fd9c5a55d

Tree-SHA512: e3786e103529aba807ecec208d6153e4b5fb9dbd558aa50b21ff858bdc83a63b1bf777d5769cbb1b94c1a980c56ea1f0bb72bcfb473771bc7b42f1fd39a0884c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the user explicitly turns the old name back on with a special startup flag. The change is documented in release notes and tested.

Lower-priorityMerge bitcoin/bitcoin#36105: bitcoin wrapper: Fix Windows exec so wrapper waits for child processby Hennadii Stepanov · ff90ca6c · Nov 12, 2026 · 7 filesMessage 100 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36105: bitcoin wrapper: Fix Windows exec so wrapper waits for child process

ad98271f512d89fb37cc1debe3a9319165210a22 bitcoin: Use generic_category for errno from exec/spawn CRT functions (Ryan Ofsky)
7fc08852e4b8852ec8a48b82ff90da17fe7fc342 test: Enable tool_bitcoin.py and interface_gui.py tests on Windows (Ryan Ofsky)
4453ead3270b0a63a224fbcb67d15a4ea4ceb5d7 util: Fix ExecVp on Windows to wait for child process (Ryan Ofsky)

Pull request description:

**Problem**: On Windows, `bitcoin.exe` spawns a child process and immediately exits rather than waiting for it to finish. This breaks capturing output and checking exit codes in scripts and tests.

**Solution**: Switch `util::ExecVp` from `_execvp` to `_spawnvp(_P_WAIT)`, which blocks until the child exits and forwards its exit code. Also enable `tool_bitcoin.py` and `interface_gui.py` tests which were skipped due to previous behavior.

This fix requires small changes to `src/util/exec.cpp` and `src/bitcoin.cpp` and there is also an extra commit fixing `errno` message strings on Windows when `ExecVp` fails. Details in commit messages.

ACKs for top commit:
cyb3ralbert:
tACK ad98271f512d89fb37cc1debe3a9319165210a22
hodlinator:
ACK ad98271f512d89fb37cc1debe3a9319165210a22
hebasto:
ACK ad98271f512d89fb37cc1debe3a9319165210a22, I have reviewed the code and it looks OK.

Tree-SHA512: 998a1a8a5c4aaa9978524d4966ea731db0de5eb966d358f9f52d338e236c4d744d73fe61a23e1efd40988b6f6f059362d07c345d43c55a5a6b6a13f1cdb68304

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amountby merge-script · dd9d016b · Nov 12, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

050409b2c5522eff0dc37c00a6d1225a8a437e17 test: allow 3 bytes of fee overestimate in assert_fee_amount (Ferdinando Ametrano)

Pull request description:

The wallet sizes a transaction assuming a 71-byte low-R ECDSA signature. A signature whose r or s has leading zero bytes is shorter, so the fee can cover a few bytes more than the signed transaction needs. In #36394 the wallet estimated 219 bytes and paid 438 sat at 2 sat/vB, but the signed transaction was 216 bytes: the signature was 3 bytes short. That happens about once in 4 million signatures. `assert_fee_amount` allows only 2 bytes of overestimate, so the test failed.

I raise the allowance to 3 bytes, which makes the failure about 200 times rarer. The check that the fee is not too low is unchanged. maflcko suggested 3 bytes in #24151 and #25164.

Fixes #36394.

*Made with my usual tools: a computer, the Internet and an LLM. The mistakes, as usual, are all mine.*

ACKs for top commit:
Ayoazeez26:
tACK 050409b2c5522eff0dc37c00a6d1225a8a437e17
ismaelsadeeq:
ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17
sedited:
ACK 050409b2c5522eff0dc37c00a6d1225a8a437e17

Tree-SHA512: d75ddf117a87a4e2e7e6d85e3c63c1ef2c9e5c12cf50b51f2016392da0c4c4172e1333d9a287f6c28f171f49b99a88505093083c2928391a760c552812f9e45e

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Informational 15/100

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare random test failure occurs.

Security candidateMerge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`by merge-script · 791173ae · Nov 12, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36224: test: Add test coverage for `PartiallySignedTransaction::Merge()`

7b124184394e016d6e3c119c50ff08d1512dfab9 test: merge PSBT `m_tx_modifiable` coverage and renaming bit positions with BIP370 flags (nebula-21)
776fb263759693a5db6aa11a8a464662d5f36da4 test: merge PSBT `fallback_locktime` coverage (nebula-21)
6fc2ebd5216975de40e9ef3b1dea1de623268794 test: only merge PSBTs with same version (nebula-21)

Pull request description:

This PR adds test coverage for `PartiallySignedTransaction::Merge()` divided into 3 tests:

Only merge PSBTs with same version: The test can be triggered with this mutant as an example:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..cf5eef0089 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -43,7 +43,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
return false;
}
if (GetVersion() != psbt.GetVersion()) {
- return false;
+ return true;
}

for (unsigned int i = 0; i < inputs.size(); ++i) {
```

Merge PSBT `fallback_locktime` coverage: If the psbt has no fallback locktime, it adopts the one from the psbt it is merging. The test can be triggered with this mutant as an example:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..ce909eb062 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -53,7 +53,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
outputs[i].Merge(psbt.outputs[i]);
}
MergeGlobalXPubs(psbt);
- if (fallback_locktime == std::nullopt && psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;
+ if (fallback_locktime == std::nullopt || psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;

// Set m_tx_modifiable only if either PSBT had it set
if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) {
```

While writing this test I had a question: If both PSBTs have a `fallback_locktime` value, the "this" (receiving side) wins silently. Is this the expected behavior? Why not keep the max or directly fail merging if we have two conflicting fallback_locktimes? The test can be triggered with this mutant as one of the various examples:

```diff
diff --git a/src/psbt.cpp b/src/psbt.cpp
index 51fb19591a..29eb910014 100644
--- a/src/psbt.cpp
+++ b/src/psbt.cpp
@@ -56,7 +56,7 @@ bool PartiallySignedTransaction::Merge(const PartiallySignedTransaction& psbt)
if (fallback_locktime == std::nullopt && psbt.fallback_locktime != std::nullopt) fallback_locktime = psbt.fallback_locktime;

// Set m_tx_modifiable only if either PSBT had it set
- if (m_tx_modifiable.has_value() || psbt.m_tx_modifiable.has_value()) {
+ if (m_tx_modifiable.has_value() && psbt.m_tx_modifiable.has_value()) {
// In general, we AND the modifiable flags
std::bitset<8> this_modifiable = m_tx_modifiable.value_or(0);
std::bitset<8> psbt_modifiable = psbt.m_tx_modifiable.value_or(0);
```

ACKs for top commit:
polespinasa:
ACK 7b124184394e016d6e3c119c50ff08d1512dfab9
fametrano:
reACK 7b124184394e016d6e3c119c50ff08d1512dfab9
sedited:
ACK 7b124184394e016d6e3c119c50ff08d1512dfab9

Tree-SHA512: 216746a77e8967441d55bb2b988a0a069292a993476afb2f33daa66356df2b8e837ad9d3fdde550623f106c9ba0fe3333230a844cafc62e772364dd8a2bf3d4f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new unit tests for an existing PSBT merging function and renames some hard-coded bit numbers to named constants. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly.

Lower-priorityMerge bitcoin/bitcoin#36757: net: ignore privacy network peer's view of our addressby merge-script · 6c7e4642 · Nov 12, 2026 · 2 filesMessage 96 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36757: net: ignore privacy network peer's view of our address

9cfd6014005197d9d2d67dacb3c079980e3b284c test: check privacy-network peers' view of our address is not used (stratospher)
533fee6b9da3801612f245af461fb2d8fb06f197 net: ignore privacy-network peers' view of our address (stratospher)

Pull request description:

privacy networks set `addrMe` ("IP address peer thinks I am") in the VERSION message [as all zeroes](https://github.com/bitcoin/bitcoin/blob/f103de70de0662a1395dca2e536cf5872d86eaa2/src/net_processing.cpp#L1667).
this PR ensures we ignore it when processing VERSION message.

this fixes a fingerprint which makes it possible to correlate clearnet and privacy network IPs but it requires some not so easy preconditions:
1. we need to choose this adversarial tor/i2p peer to make an outbound connection to from our addrman
2. we need to be using a unique enough port. this would become easier in a future if we ever support random ports.

h/t to Loupe and instagibbs for finding this fingerprint!

ACKs for top commit:
mzumsande:
re-ACK [9cfd601](https://github.com/bitcoin/bitcoin/commit/9cfd6014005197d9d2d67dacb3c079980e3b284c)
danielabrozzoni:
ACK 9cfd6014005197d9d2d67dacb3c079980e3b284c
sedited:
ACK 9cfd6014005197d9d2d67dacb3c079980e3b284c

Tree-SHA512: 450733757073538ca3ebd3ea73402d7e3d579fc322f358158d2e7533a4d087e32361cddac1c4b00009a8ed6017a911376c4d0290bdfc5b25ee4de514f82321ad

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36807: refactor: Move `NodeId` declaration into `net_types.h` and fix includes in related modulesby merge-script · a06515e9 · Nov 12, 2026 · 13 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36807: refactor: Move `NodeId` declaration into `net_types.h` and fix includes in related modules

541a000542d6bafb783e080ba427424e96233c4c refactor: Fix includes in `net`, `net_types` and `node/eviction` modules (Hennadii Stepanov)
f58f08c565210e8400995bd1a93d24d7565e27ad refactor: Move `NodeId` declaration into `net_types.h` (Hennadii Stepanov)

Pull request description:

Two identical declarations of `NodeId` make it ambiguous for static analysis tools such as IWYU which header should provide the symbol. Move the declaration into `net_types.h`.

The second commit fixes the `#include`s of the `net`, `net_types` and `node/eviction` modules, which the first commit touched, and adds the headers that other files previously received transitively from them.

A prerequisite for https://github.com/bitcoin/bitcoin/pull/36808.

ACKs for top commit:
maflcko:
review ACK 541a000542d6bafb783e080ba427424e96233c4c 🍨
sedited:
ACK 541a000542d6bafb783e080ba427424e96233c4c

Tree-SHA512: dec40104861aa784d133a448bde220c62ef8a038b984e1b913774756e217e7dd357dcfa89ff2544c56bbf727af9e08dd63283e63bac64590837038e608f08995

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritybuild: enable -Wdocumentation-pedanticby fanquake · e8b442c7 · Nov 11, 2026 · 1 fileMessage 70 · AdequateTriage 0Details
Commit message · fanquake

build: enable -Wdocumentation-pedantic

Catches misspelled doxygen commands such as '@peer[in]' (for
'@param[in]'), which -Wdocumentation alone does not report. i.e

```bash
../src/net_processing.cpp:717:8: warning: unknown command tag name [-Wdocumentation-unknown-command]
717 | * @peer[in] peer The peer whose orphan transactions we will reconsider. Generally only
| ^~~~~
1 warning generated.
```

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
Lower-prioritydoc: spell out escape sequences in doxygen commentsby fanquake · 03838872 · Nov 11, 2026 · 6 filesMessage 73 · AdequateTriage 0Details
Commit message · fanquake

doc: spell out escape sequences in doxygen comments

Doxygen interprets a backslash followed by a letter as a command, so
'\n' renders as a line break and '\t' etc. are unknown commands.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritydoc: use @param and @return in subprocess.hby fanquake · f3ce77ca · Nov 11, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · fanquake

doc: use @param and @return in subprocess.h

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateMerge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputsby merge-script · c68583ab · Nov 11, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36068: fuzz: reuse one fuzzed wallet across inputs

fd3b09e8bcb83351c30b37505501c2a9756d907e fuzz: reuse one fuzzed wallet across inputs (brunoerg)
2553b4cd9678f9d7ba78be3573eb3cd095ab3ea6 wallet: add test-only helper to clear in-memory transaction state (brunoerg)

Pull request description:

FuzzedWallet was rebuilt for every input. That imports eight
descriptors, and each address it then hands out costs a BIP32
derivation plus three separate WalletBatch transactions (see
DescriptorScriptPubKeyMan::GetNewDestination) - all paid before the
target reaches the code under test.

This PR changes it to build the wallet once in the target's .init hook and
reset it perinput instead. I benchmarked on my Ubuntu machine without
sanitizers and got a ~6x speedup.

ACKs for top commit:
frankomosh:
reACK fd3b09e8bcb83351c30b37505501c2a9756d907e
maflcko:
re-ACK fd3b09e8bcb83351c30b37505501c2a9756d907e 👕

Tree-SHA512: 73ab582c1a054525ef4c101d4cd14741b4bbf57315db5db8982640ec499d8047701d3ab5e4442b386a55ef65a1bb7ecee2d8e407c749ea1d2ce032b10e75a6bf

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialdefensive validationfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a performance improvement for Bitcoin Core's internal fuzz testing (automated randomized testing). It reuses a single test wallet across many fuzz inputs instead of rebuilding it each time, and adds a test-only helper to clear in-memory transaction state. There is no indication this fixes a security vulnerability or affects production wallet behavior.

Lower-priorityMerge bitcoin/bitcoin#36824: ci: Switch to self-hosted CDashby Hennadii Stepanov · 6f1365e3 · Nov 10, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36824: ci: Switch to self-hosted CDash

f16d5166a26a1e8b9539297dc960d7cde28778bf ci: Switch to self-hosted CDash (will)

Pull request description:

Switch our CDash submissions from my.cdash.org to our self-hosted instance at https://cdash.fish.foo/index.php?project=bitcoin-core.

my.cdash.org sometimes deletes our logs extremely quickly. That leaves too little time to investigate failures and makes links to earlier results 404, which is annoying.

The new instance runs on a dedicated Hetzner VPS and gives us control over retention. Submissions are configured to be retained for 90 days, and the project's build retention is also set to 90 days.

ACKs for top commit:
hebasto:
ACK f16d5166a26a1e8b9539297dc960d7cde28778bf.

Tree-SHA512: 3b01912ca6a2743c9678f2818b526f0ffca7aa768fa724083016859f14d2a50b6defda5a0a3440b20073a265dee43b22365eb1daaa4c225a9f0ee508e8a6dc59

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36556: depends: fix non-atomic reads in capnp debug assertionsby merge-script · 117c54d4 · Nov 10, 2026 · 3 filesMessage 81 · StrongLow 29Details
Commit message · merge-script

Merge bitcoin/bitcoin#36556: depends: fix non-atomic reads in capnp debug assertions

6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec depends: fix non-atomic reads in capnp debug assertions (xyzconstant)

Pull request description:

KJ's debug assertions read the mutex futex word and `AtomicRefcounted` refcounts non-atomically. The TSan job builds capnp without optimization, which automatically enables these assertions, and TSan reports these reads as data races the moment KJ objects start communicating across threads.

libmultiprocess enables cross-thread communication for the first time in bitcoin-core/libmultiprocess#376, which replaces the pipe used in `EventLoop::sync()` with `kj::Executor::executeSync()`. This is what triggered the [failure](https://github.com/bitcoin-core/libmultiprocess/actions/runs/38094008438/job/114336046070?pr=376).

Patches are the upstream commits capnproto/capnproto@b91a6ba7c7 and capnproto/capnproto@cc13c8c45f, which are backports of the v2 fixes in capnproto/capnproto#2781 and capnproto/capnproto#2843 (backport PR: capnproto/capnproto#2855).

ACKs for top commit:
Sjors:
ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec
ryanofsky:
Code review ACK 6e8e85ddcf2eb4a062fab3cd2b9c046edfbf72ec. Thanks for tracking down the race and getting the fix merged upstream first, which makes the patches easy to check.

Tree-SHA512: 07bc877c39b9e598b29eba73d066561dfd981ddf2d750d1cab383697084ecea497b6c7e7d1925fb4eed59bd7ccadfc05eef734b46e83b654a2e31033d34189ab

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 29/100

This commit adds two upstream patches to Bitcoin Core's build of the Cap'n Proto library. The patches fix debug-only assertions that read shared memory values without using atomic operations. These non-atomic reads were flagged by ThreadSanitizer as data races once KJ objects communicate across threads. The fix only affects debug/TSan builds and does not change release behavior; it is a correctness and testing-infrastructure improvement rather than a user-facing security bug.

AI review queuedMerge bitcoin/bitcoin#36817: ipc: remove pre-v14 libmultiprocess compat definitionsby merge-script · 9320233a · Nov 10, 2026 · 5 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36817: ipc: remove pre-v14 libmultiprocess compat definitions

ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1 ipc: remove pre-v14 libmultiprocess compat definitions (fanquake)

Pull request description:

ACKs for top commit:
ryanofsky:
Code review ACK ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1. Just adds requested documentation update since last review. Thanks!

Tree-SHA512: 879d0031612d758e29fe2d963a48486c6b05e6f080c927748ec7b288d0fa29828f325e8ad7fd22ab3a157c16628bf33f4928db4176ee74e3597193bb01fbc6a2

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes old compatibility code that was only needed for an earlier version of a supporting library called libmultiprocess. It is a routine cleanup: the project now requires libmultiprocess v14.0 or newer, so the fallback definitions for older versions are no longer needed. There is no security fix or vulnerability patch here.

AI review queuedMerge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent optionsby merge-script · 4677f884 · Nov 10, 2026 · 5 filesMessage 81 · StrongInformational 16Details
Commit message · merge-script

Merge bitcoin/bitcoin#36785: rpc: wallet: Add snake_case aliases for listunspent options

facf53acf43cb392d3af72ef837a4b825ed31406 refactor: Re-use a single GetOptionWithAlias (MarcoFalke)
fab4cb51b453817b23289ec7f33c40a6cd30e3d4 rpc: wallet: Add snake_case aliases for listunspent options (MarcoFalke)

Pull request description:

This concludes the snake_case aliases for all wallet option objects or named args.

Deprecation can be done in the future, in a few releases.

ACKs for top commit:
Zippo76:
tACK facf53acf4
willcl-ark:
ACK facf53acf43cb392d3af72ef837a4b825ed31406

Tree-SHA512: 139d85c29ce1fbb68e4d3dbc3d99de3f4dddb78588f937f6ff98878407c2c00b119722ad9fbdf4aa1af8d41c8041150b7dd9c04ad85f9c8eef27d047547c20dd

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This change adds snake_case aliases (like minimum_amount) for existing camelCase options (like minimumAmount) in the listunspent RPC command. It also refactors some helper code so other wallet RPCs can reuse the same alias-handling logic. There is no security vulnerability here; it is a backward-compatible usability and consistency improvement.

AI review queuedMerge bitcoin/bitcoin#36805: Enclose all header content in include guardsby merge-script · 36be848e · Nov 10, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36805: Enclose all header content in include guards

ca14da90250fb5211983021a754473cde194d59e lint: Require all code in a header to be inside its include guard (Hennadii Stepanov)
00e1f35524ac52e3936db1f1d9ba44fda4911544 Enclose all header content in include guards (Hennadii Stepanov)

Pull request description:

From https://gcc.gnu.org/onlinedocs/cpp/Once-Only-Headers.html:
> If a header file happens to be included twice, the compiler will process its contents twice. This is very likely to cause an error, e.g. when the compiler sees the same structure definition twice. Even if it does not, it will certainly waste time.

This PR fixes the three headers that have content outside their guards and modifies [`test/lint/lint-include-guards.py`](https://github.com/bitcoin/bitcoin/blob/master/test/lint/lint-include-guards.py) to catch such violations in the future.

A prerequisite for https://github.com/bitcoin/bitcoin/pull/36808.

ACKs for top commit:
maflcko:
review ACK ca14da90250fb5211983021a754473cde194d59e 🖨

Tree-SHA512: 79a3e7591d4393343df9dcd39d48fe637d62b640e4dad71079fdc2bbbbcf2c01db36c3de77e82d26f90bbc0bdd2864f0e289eb45536f9df9f6e797ee7467874d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a code-quality cleanup, not a security fix. It moves include guards in three header files so they wrap all content, and updates a lint script to enforce that rule going forward. Include guards prevent the compiler from accidentally processing the same header twice, which avoids build errors and wasted compile time. There is no runtime security impact.

AI review queuedMerge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declarativelyby merge-script · 0b9c2c30 · Nov 10, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36810: test: construct `miner_tests` transactions declaratively

8d33ffe47e38ebf84e2c832d426d307484a8d342 test: construct miner_tests sigops transactions declaratively (yuvicc)
b2ce6c1727e762cd63eb5353df52a529861d8af8 test: construct miner_tests package selection transactions declaratively (yuvicc)

Pull request description:

Part of #36692.

Add `MakeTx()` and use it in `TestPackageSelection` and `TestPrioritisedMining` so each transaction is fully specified where it is created, instead of overwriting the `prevout` and `nValue` of the previous one. Also build the `CreateBigSigOpsTx()` and `CreateBigSigOpsCluster()` transactions in place.

One implicit dependency is now explicit: BulkTransaction() pads the output script of hashFreeTx2, and the next two transactions inherited it. Their size matters for the fee rate checks, so the padded script is now passed to `MakeTx()` explicitly.

The txid, wtxid and fee of every transaction added to the mempool are unchanged.

ACKs for top commit:
purpleKarrot:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
alexanderwiederin:
ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342
maflcko:
review ACK 8d33ffe47e38ebf84e2c832d426d307484a8d342 🦆

Tree-SHA512: ce4a052769e3dc78e1ba2aacded671c61a226fa5e501e07e4ab2325421abae78cdc8a6e3b3731983db0cbe8cb9f8e9ba5c291bda9481ed94d4c7ce266b09d51c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a pure test-code cleanup. It refactors how fake transactions are built in Bitcoin Core's miner unit tests, making them more explicit and easier to read. It does not change any production code, network behavior, or transaction hashes used in the tests.

Lower-priorityMerge bitcoin/bitcoin#36642: rpc: parse each batch element into its own requestby Ryan Ofsky · d19c4f8b · Nov 10, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#36642: rpc: parse each batch element into its own request

5861dd29a73a9f0a21851a83adfa21d4637282b5 rpc: parse each batch element into its own request (Ferdinando Ametrano)

Pull request description:

In a JSON-RPC batch, an element that is not an object gets an error reply with the id and version of the element before it.

`ExecuteHTTPRPC` parses every element of a batch into the same request object, and `parse()` throws on a non-object before it sets `id` and `m_json_version`. For `[{"jsonrpc":"2.0","method":"getblockcount","id":"X"}, 2]` the reply has two objects with `"id":"X"`, one with a result and one with an error. If the first element is a notification, the error is dropped. I give each element its own copy of the request, which holds only the HTTP fields, so the error is the one the first element of a batch already gets. The new case in `interface_rpc.py` fails on master and passes with this change.

ACKs for top commit:
janb84:
ACK 5861dd29a73a9f0a21851a83adfa21d4637282b5
hodlinator:
ACK 5861dd29a73a9f0a21851a83adfa21d4637282b5
pinheadmz:
ACK 5861dd29a73a9f0a21851a83adfa21d4637282b5

Tree-SHA512: d7022194652bc8ae9bbc7cc47d799485d2a337844bdc05427284d23f944997fe4598795788f62d1360ae518aa0a73e322fd7148a5298920939b00ea2f60af761

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount